e6df2fad28
All checks were successful
CD Pipeline / deploy (push) Successful in 2m39s
Critic-approved 3-point revision (REVISE → adopted): 1. Disable weekly_insight trigger at definition (line 279-285) — EA no longer evaluates the 6h / >=5 ai_insights condition that fired _generate_strategy_report without force_tg_alert=True. 2. Remove the openclaw weekly/meta dispatch table branches (line 591-606). The 5 actions (generate_strategic_analysis, generate_weekly_strategy, generate_market_analysis, generate_pricing_strategy, generate_meta_analysis) now fall through to the existing `raise ValueError(f"Unrecognized step: ...")` at line 631, which _execute_decision's try/except converts into a circuit-breaker failure. This is the correct failure semantics critic asked for. 3. Convert _generate_strategy_report / _generate_meta_report into hard RuntimeError raisers and drop their imports of openclaw_strategist_service. Deep insurance: any future caller crashes immediately instead of silently bypassing dedupe. Evidence: ai_insights logged 35+ duplicate weekly_strategy sends in 7 days because EA's `_generate_strategy_report` invoked generate_weekly_strategy_report() without force_tg_alert=True, bypassing the run_scheduler.py weekly dedupe gate. Out of scope (per task contract): - run_scheduler.py:115 Monday 06:00 schedule — preserved (sole owner) - services/openclaw_strategist_service.py — owned by B-series (SQL) - Other EA triggers (price_drop_alert / market_opportunity / threat_escalation / code_exception / resource_optimization) — preserved - Other dispatch branches (hermes / nemotron / auto_heal / code_fix / price_adjustment review) — preserved - Did NOT add force_tg_alert=True defensive layer (critic flagged as anti-pattern) - Did NOT touch _TRIGGER_TO_DECISION_TYPE / _ALLOWED_ACTION_TYPES Not pushed, not deployed. D1 deployment will be issued separately and must use `docker compose up -d --no-deps --force-recreate momo-scheduler` (per feedback_compose_restart_vs_up). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
