新增市場情報 review decision writer run package
All checks were successful
CD Pipeline / deploy (push) Successful in 1m4s

This commit is contained in:
OoO
2026-05-19 15:14:34 +08:00
parent 02f9b49d4d
commit ec378258e7
10 changed files with 863 additions and 68 deletions

View File

@@ -145,6 +145,7 @@
- V10.259 補 Phase 70 preflight 合約與 OCLearn queue 時區preflight 補 planned/read-only catalog probe 欄位、dedupe unique index 檢查與 route 重複註冊清理OCLearn embedding queue 的 created_at/updated_at/stale cutoff 改為台北 naive避免 UTC/台北時間差讓 processing 任務卡住。
- Phase 71 candidate queue review decision writer post-write smoke新增 `services/market_intel/candidate_queue_review_decision_writer_postwrite_smoke.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` 與 UI smoke 按鈕,人工 CLI 更新 review_state 後可用 dedupe key 只讀驗證 row 是否存在且 state 符合預期API/UI 預設不連 DBexecute=true 也只讀查詢,不更新 review_state、不 commit、不讀 token、不掛 scheduler版本同步至 V10.260。
- Phase 72 candidate queue review decision writer operator drill新增 `services/market_intel/candidate_queue_review_decision_writer_operator_drill.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` 與 UI drill 按鈕,將 review_state CLI 更新前後的 transaction JSON、備份、preflight、CLI writer、post-write smoke 與 rollback plan 組成可稽核操作順序API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler版本同步至 V10.261。
- Phase 73 candidate queue review decision writer run package新增 `services/market_intel/candidate_queue_review_decision_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 與 UI package 按鈕,將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 run packageAPI/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler版本同步至 V10.262。
- V10.248 補市場情報 390px preview panel QAsample review 工具列改為 textarea + 可換行 action rail移除舊的硬編 8 欄 grid`check_responsive_overflow` 新增 `--screenshot-all`,本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。
- V10.250 補 Code Review Gemini 備援遙測護欄Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援,避免誤判 Gemini-first。
- Schema smoke`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。

View File

@@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '')
# ==========================================
# 系統版本與路徑
# ==========================================
SYSTEM_VERSION = "V10.261"
SYSTEM_VERSION = "V10.262"
LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log')
public_url = PUBLIC_URL # 用於模板顯示

View File

@@ -198,6 +198,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome
- 2026-05-19 追加 candidate queue review decision writer preflight`services.market_intel.candidate_queue_review_decision_writer_preflight``/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight` 檢查 writer status、review_state update payload、狀態轉換與 token 外洩風險。API/UI 即使收到 `execute=true``apply_real_write=true` 也只回 blocked preview不連 DB、不執行 CLI、不更新 `review_state`、不 commit、不讀 approval token、不掛 scheduler。
- 2026-05-19 追加 candidate queue review decision writer post-write smoke`services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke``/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` 依 review_state transaction preview 的 dedupe key 只讀查詢 `market_alert_review_queue`,確認人工 CLI 更新後的 `review_state` 是否符合預期。UI 預設 `execute=false` 不連 DB人工 smoke 即使 `execute=true` 也只讀查詢,不更新 `review_state`、不 commit、不讀 approval token、不掛 scheduler。
- 2026-05-19 追加 candidate queue review decision writer operator drill`services.market_intel.candidate_queue_review_decision_writer_operator_drill``/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` 整理 review_state CLI 更新前後的操作員順序、preflight、post-write smoke、gate 與 rollback plan。此 drill 只輸出可稽核操作計畫API/UI 不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。
- 2026-05-19 追加 candidate queue review decision writer run package`services.market_intel.candidate_queue_review_decision_writer_run_package``/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 package。此 package 只輸出預覽API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。
### Phase 4Coupang / Shopee Adapter

View File

@@ -19,8 +19,8 @@
| `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` |
| `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` |
| `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` |
| `market_intel_routes.py` | 市場情報 Phase 72 candidate queue review decision writer operator drill 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` |
| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` |
| `market_intel_routes.py` | 市場情報 Phase 73 candidate queue review decision writer run package 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` |
| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` |
| `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` |
| `export_routes.py` | 匯出功能 | `/api/export/*` |
| `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` |

View File

@@ -33,6 +33,9 @@ from services.market_intel.candidate_queue_review_decision_writer_postwrite_smok
from services.market_intel.candidate_queue_review_decision_writer_operator_drill import (
build_candidate_queue_review_decision_writer_operator_drill,
)
from services.market_intel.candidate_queue_review_decision_writer_run_package import (
build_candidate_queue_review_decision_writer_run_package,
)
from services.market_intel.candidate_queue_writer_cli import (
build_candidate_queue_writer_cli_plan,
)
@@ -520,3 +523,63 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_operator_d
)
data["phase"] = service.phase
return jsonify(data), 400 if payload_error else 200
@market_intel_review_bp.route(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_package",
methods=["POST"],
)
@login_required
def market_intel_manual_sample_candidate_queue_review_decision_writer_run_package():
service = MarketIntelService()
sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = (
_extract_run_payload()
)
transaction = _build_review_decision_transaction_stack(
service=service,
sample_result=sample_result,
payload_error=payload_error,
operator_evidence=operator_evidence,
writer_output=writer_output,
postwrite_smoke_result=smoke_result,
limit=limit,
execute_requested=False,
)
writer_status = build_candidate_queue_review_decision_writer_cli_plan(
transaction_preview=transaction,
operator_evidence=operator_evidence,
execute_requested=False,
apply_real_write=False,
approval_token=None,
approval_token_secret=None,
backup_verified=False,
review_inventory_smoke_passed=False,
)
writer_preflight = build_candidate_queue_review_decision_writer_preflight(
writer_status=writer_status,
transaction_preview=transaction,
operator_evidence=operator_evidence,
execute_requested=False,
apply_real_write=False,
)
postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke(
transaction_preview=transaction,
execute_requested=False,
)
operator_drill = build_candidate_queue_review_decision_writer_operator_drill(
transaction_preview=transaction,
writer_preflight=writer_preflight,
writer_status=writer_status,
postwrite_smoke=postwrite_smoke,
operator_evidence=operator_evidence,
)
data = build_candidate_queue_review_decision_writer_run_package(
transaction_preview=transaction,
writer_preflight=writer_preflight,
writer_status=writer_status,
postwrite_smoke=postwrite_smoke,
operator_drill=operator_drill,
)
data["phase"] = service.phase
return jsonify(data), 400 if payload_error else 200

View File

@@ -0,0 +1,343 @@
"""候選審核 queue review_state writer run package preview。
本模組只把人工 CLI 更新 review_state 前需要保存的 payload、命令、
證據與回退資訊整理成可審核預覽;不讀 approval token、不寫本機檔案、
不開 DB connection、不執行 CLI、不更新 review_state、不 commit、不掛 scheduler。
"""
import hashlib
import json
from services.market_intel.candidate_queue_review_decision_transaction import (
ALLOWED_DECISIONS,
TARGET_TABLE,
)
def _as_dict(value):
return value if isinstance(value, dict) else {}
def _as_list(value):
if value is None:
return []
if isinstance(value, (list, tuple, set)):
return list(value)
return [value]
def _stable_hash(value):
encoded = json.dumps(
value,
ensure_ascii=False,
sort_keys=True,
separators=(",", ":"),
).encode("utf-8")
return hashlib.sha256(encoded).hexdigest()
def _statement_payloads(transaction_preview):
payloads = []
for statement in _as_list(_as_dict(transaction_preview).get("statements")):
statement = _as_dict(statement)
payload = _as_dict(statement.get("parameter_preview"))
dedupe_key = payload.get("dedupe_key") or _as_dict(statement.get("lookup")).get(
"dedupe_key"
)
current_state = (
payload.get("expected_current_review_state")
or statement.get("expected_current_review_state")
)
next_state = payload.get("next_review_state") or statement.get(
"next_review_state"
)
manifest = {
"index": statement.get("index"),
"idempotency_key": statement.get("idempotency_key"),
"dedupe_key": dedupe_key,
"expected_current_review_state": current_state,
"next_review_state": next_state,
"operation": statement.get("operation"),
"statement_type": statement.get("statement_type"),
"payload_hash": _stable_hash(payload),
}
if dedupe_key and current_state and next_state:
payloads.append(manifest)
return payloads
def _package_gates(
*,
transaction_preview,
writer_preflight,
writer_status,
postwrite_smoke,
operator_drill,
payloads,
):
transaction_preview = _as_dict(transaction_preview)
writer_preflight = _as_dict(writer_preflight)
writer_status = _as_dict(writer_status)
postwrite_smoke = _as_dict(postwrite_smoke)
operator_drill = _as_dict(operator_drill)
return [
{
"key": "transaction_preview_created",
"label": "已產生 review_state transaction preview",
"passed": bool(transaction_preview.get("transaction_preview_created")),
},
{
"key": "transaction_has_update_statements",
"label": "run package 至少需包含一筆 update_review_state statement",
"passed": bool(payloads),
},
{
"key": "transaction_updates_are_small_batch",
"label": "首次 review_state run package 必須是小批次,最多 5 筆",
"passed": 0 < len(payloads) <= 5,
},
{
"key": "transaction_transition_allowed",
"label": "只能從 needs_review 更新為 confirmed / rejected / deferred",
"passed": bool(
payloads
and all(
item.get("expected_current_review_state") == "needs_review"
and item.get("next_review_state") in ALLOWED_DECISIONS
for item in payloads
)
),
},
{
"key": "writer_preflight_available",
"label": "writer preflight 已可用,正式操作前需另跑只讀檢查",
"passed": bool(writer_preflight),
},
{
"key": "writer_cli_gate_available",
"label": "review_state writer CLI gate 已可用,真更新只允許 CLI 執行",
"passed": bool(writer_status),
},
{
"key": "operator_drill_available",
"label": "operator drill 已產生正式操作順序",
"passed": bool(operator_drill),
},
{
"key": "postwrite_smoke_available",
"label": "post-write smoke 已可用,更新後可只讀驗證 review_state",
"passed": bool(postwrite_smoke),
},
{
"key": "writer_status_still_blocks_api_write",
"label": "writer gate 仍需阻擋 API/UI 寫入",
"passed": bool(
writer_status.get("mode")
== "candidate_queue_review_decision_writer_cli_blocked"
and not writer_status.get("ready_for_real_write")
),
},
{
"key": "run_artifacts_saved_by_operator",
"label": "正式更新前操作員必須保存 transaction JSON 與 preflight 輸出",
"passed": False,
},
{
"key": "backup_artifact_path_recorded",
"label": "正式更新前必須記錄最新備份檔路徑",
"passed": False,
},
{
"key": "one_time_token_supplied_in_shell_only",
"label": "一次性 approval token 只能在 CLI shell 提供",
"passed": False,
},
{
"key": "postwrite_evidence_saved",
"label": "正式更新後必須保存 writer output 與 post-write smoke 結果",
"passed": False,
},
]
def build_candidate_queue_review_decision_writer_run_package(
*,
transaction_preview,
writer_preflight,
writer_status,
postwrite_smoke,
operator_drill,
):
"""建立 review_state writer run package preview不執行任何副作用。"""
payloads = _statement_payloads(transaction_preview)
payload_manifest_hash = _stable_hash(payloads)
gates = _package_gates(
transaction_preview=transaction_preview,
writer_preflight=writer_preflight,
writer_status=writer_status,
postwrite_smoke=postwrite_smoke,
operator_drill=operator_drill,
payloads=payloads,
)
blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]]
package_ready = bool(payloads and not blocked_reasons)
return {
"mode": "candidate_queue_review_decision_writer_run_package_preview",
"target_table": TARGET_TABLE,
"target_operation": "update_review_state",
"package_ready": package_ready,
"package_artifact_created": False,
"ready_for_api_review_state_update": False,
"ready_for_api_database_write": False,
"ready_for_scheduler_attach": False,
"api_writes_file": False,
"api_executes_cli": False,
"api_reads_approval_token": False,
"api_writes_database": False,
"api_updates_review_state": False,
"approval_record_written": False,
"decision_record_written": False,
"review_state_update_executed": False,
"database_connection_opened": False,
"database_session_created": False,
"explicit_transaction_opened": False,
"transaction_opened": False,
"transaction_committed": False,
"database_write_executed": False,
"database_commit_executed": False,
"database_rollback_executed": False,
"external_network_executed": False,
"scheduler_attached": False,
"writes_executed": False,
"would_write_database": False,
"blocked_reasons": blocked_reasons,
"package_gates": gates,
"payload_manifest": {
"payload_count": len(payloads),
"manifest_hash": payload_manifest_hash,
"dedupe_keys": [
item["dedupe_key"] for item in payloads if item.get("dedupe_key")
],
"allowed_next_states": list(ALLOWED_DECISIONS),
"payloads": payloads,
"redaction_policy": [
"do_not_include_approval_token",
"do_not_include_raw_html",
"do_not_include_login_or_member_data",
],
},
"required_artifacts": [
{
"key": "review_state_transaction_json",
"label": "操作員保存的 review_state transaction JSON",
"path_shape": "artifacts/market_intel/review-state-transaction-YYYYMMDD-HHMMSS.json",
"created_by_api": False,
},
{
"key": "project_backup_zip",
"label": "正式更新前備份檔",
"path_shape": "scripts/tools/backups/momo_pro_system_backup_*.zip",
"created_by_api": False,
},
{
"key": "read_only_preflight_json",
"label": "CLI read-only preflight 輸出",
"path_shape": "artifacts/market_intel/review-state-preflight-*.json",
"created_by_api": False,
},
{
"key": "review_state_writer_output_json",
"label": "CLI review_state writer 正式執行輸出",
"path_shape": "artifacts/market_intel/review-state-writer-output-*.json",
"created_by_api": False,
},
{
"key": "review_state_postwrite_smoke_json",
"label": "review_state post-write smoke 只讀驗證輸出",
"path_shape": "artifacts/market_intel/review-state-postwrite-smoke-*.json",
"created_by_api": False,
},
],
"command_bundle": [
{
"step": 1,
"key": "save_review_state_transaction",
"command_shape": (
"mkdir -p artifacts/market_intel && write transaction JSON to "
"artifacts/market_intel/review-state-transaction-YYYYMMDD-HHMMSS.json"
),
"executes_database": False,
},
{
"step": 2,
"key": "backup",
"command_shape": "python3 scripts/tools/backup_system.py",
"executes_database": False,
},
{
"step": 3,
"key": "preflight",
"command_shape": (
"python3 scripts/market_intel_review_decision_writer.py "
"--transaction-json artifacts/market_intel/review-state-transaction.json "
"--read-only-preflight > artifacts/market_intel/review-state-preflight.json"
),
"executes_database": False,
},
{
"step": 4,
"key": "review_state_writer",
"command_shape": (
"MARKET_INTEL_QUEUE_WRITE_APPROVAL=... "
"python3 scripts/market_intel_review_decision_writer.py --execute "
"--apply-real-write --transaction-json "
"artifacts/market_intel/review-state-transaction.json "
"> artifacts/market_intel/review-state-writer-output.json"
),
"executes_database": True,
},
{
"step": 5,
"key": "postwrite_smoke",
"command_shape": (
"POST /api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_postwrite_smoke?execute=true "
"> artifacts/market_intel/review-state-postwrite-smoke.json"
),
"executes_database": False,
},
],
"operator_signoff": [
"確認每個 dedupe_key 仍是 needs_review",
"確認下一狀態只包含 confirmed / rejected / deferred",
"確認備份檔路徑與時間",
"確認 approval token 只在 shell 環境提供",
"確認 post-write smoke 的 review_state 與 transaction preview 相符",
],
"rollback_plan": [
{
"key": "no_preview_side_effect",
"label": "此 run package preview 沒有副作用,不需要 DB rollback",
},
{
"key": "review_state_reversal_requires_manual_audit",
"label": "正式 CLI 更新後若需回退,必須依 dedupe_key 與審核證據人工稽核",
},
{
"key": "keep_market_flags_disabled",
"label": "異常時維持 MARKET_INTEL_* flags 關閉,不掛 scheduler",
},
],
"safe_boundaries": [
"do_not_create_review_state_run_artifacts_from_api",
"do_not_execute_review_state_writer_from_run_package_api",
"do_not_read_approval_token_from_run_package_api",
"do_not_open_database_connection_from_review_state_run_package",
"do_not_update_review_state_from_review_state_run_package",
"do_not_commit_review_state_run_package",
"do_not_attach_scheduler_from_review_state_run_package",
"no_remove_orphans",
"no_momo_db_lifecycle_change",
],
}

View File

@@ -20,10 +20,11 @@ from services.market_intel.candidate_queue_review_decision_writer_cli import bui
from services.market_intel.candidate_queue_review_decision_writer_preflight import build_candidate_queue_review_decision_writer_preflight
from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import build_candidate_queue_review_decision_writer_postwrite_smoke
from services.market_intel.candidate_queue_review_decision_writer_operator_drill import build_candidate_queue_review_decision_writer_operator_drill
from services.market_intel.candidate_queue_review_decision_writer_run_package import build_candidate_queue_review_decision_writer_run_package
BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database")
PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status")
PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status")
def _run_review_preview_safe(payload, mode):
@@ -133,6 +134,13 @@ def build_deployment_readiness_preview(
writer_status=candidate_queue_review_decision_writer_status,
postwrite_smoke=candidate_queue_review_decision_writer_postwrite_smoke,
)
candidate_queue_review_decision_writer_run_package = build_candidate_queue_review_decision_writer_run_package(
transaction_preview=candidate_queue_review_decision_transaction,
writer_preflight=candidate_queue_review_decision_writer_preflight,
writer_status=candidate_queue_review_decision_writer_status,
postwrite_smoke=candidate_queue_review_decision_writer_postwrite_smoke,
operator_drill=candidate_queue_review_decision_writer_operator_drill,
)
checks = {
"schema_smoke_passed": bool(schema_smoke["passed"]),
"feature_flags_default_safe": bool(
@@ -383,6 +391,10 @@ def build_deployment_readiness_preview(
candidate_queue_review_decision_writer_operator_drill,
"candidate_queue_review_decision_writer_operator_drill_preview",
),
"candidate_queue_review_decision_writer_run_package_preview_safe": _run_review_preview_safe(
candidate_queue_review_decision_writer_run_package,
"candidate_queue_review_decision_writer_run_package_preview",
),
"candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe(
candidate_queue_review_decision_writer_status,
"candidate_queue_review_decision_writer_cli_blocked",
@@ -622,6 +634,7 @@ def build_deployment_readiness_preview(
"candidate_queue_review_decision_writer_preflight": candidate_queue_review_decision_writer_preflight,
"candidate_queue_review_decision_writer_postwrite_smoke": candidate_queue_review_decision_writer_postwrite_smoke,
"candidate_queue_review_decision_writer_operator_drill": candidate_queue_review_decision_writer_operator_drill,
"candidate_queue_review_decision_writer_run_package": candidate_queue_review_decision_writer_run_package,
"candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status,
"match_review_plan": match_review_plan,
"opportunity_plan": opportunity_plan,

View File

@@ -1,3 +1,3 @@
"""市場情報 rollout phase 單一來源。"""
MARKET_INTEL_PHASE = "phase_72_candidate_queue_review_decision_writer_operator_drill"
MARKET_INTEL_PHASE = "phase_73_candidate_queue_review_decision_writer_run_package"

View File

@@ -652,6 +652,9 @@
<button class="market-intel-icon-button" type="button" title="產生 queue review decision writer operator drill" data-market-intel-sample-candidate-queue-review-decision-operator-drill>
<i class="fas fa-list-check" aria-hidden="true"></i>
</button>
<button class="market-intel-icon-button" type="button" title="產生 queue review decision writer run package" data-market-intel-sample-candidate-queue-review-decision-run-package>
<i class="fas fa-box-archive" aria-hidden="true"></i>
</button>
<button class="market-intel-icon-button" type="button" title="檢查 queue review decision writer CLI gate" data-market-intel-sample-candidate-queue-review-decision-writer>
<i class="fas fa-terminal" aria-hidden="true"></i>
</button>
@@ -1000,6 +1003,7 @@
const sampleCandidateQueueReviewDecisionPreflight = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-preflight]') : null;
const sampleCandidateQueueReviewDecisionPostwriteSmoke = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-postwrite-smoke]') : null;
const sampleCandidateQueueReviewDecisionOperatorDrill = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-operator-drill]') : null;
const sampleCandidateQueueReviewDecisionRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-package]') : null;
const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null;
const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}";
const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}";
@@ -1023,6 +1027,7 @@
const sampleCandidateQueueReviewDecisionPreflightEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_preflight') }}";
const sampleCandidateQueueReviewDecisionPostwriteSmokeEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_postwrite_smoke') }}";
const sampleCandidateQueueReviewDecisionOperatorDrillEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_operator_drill') }}";
const sampleCandidateQueueReviewDecisionRunPackageEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_package') }}";
const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}";
const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null;
const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null;
@@ -3966,6 +3971,135 @@
}
};
const renderCandidateQueueReviewDecisionRunPackage = data => {
const blockers = (data.blocked_reasons || []).join(' / ');
const gates = data.package_gates || [];
const manifest = data.payload_manifest || {};
const artifacts = data.required_artifacts || [];
const commands = data.command_bundle || [];
sampleReviewMeta.innerHTML = [
`mode=${data.mode || 'unknown'}`,
`package=${data.package_ready ? 'ready' : 'blocked'}`,
`payloads=${manifest.payload_count || 0}`,
`artifact=${data.package_artifact_created ? 'created' : 'preview'}`,
`api_write=${data.api_updates_review_state ? 'yes' : 'no'}`
].map(item => `<span class="market-intel-pill">${escapeHtml(item)}</span>`).join('');
sampleReviewBody.innerHTML = `
<div class="market-intel-empty mb-3">此卡只產生 review_state writer run package 預覽API/UI 不寫檔、不讀 token、不執行 CLI、不更新 review_state。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}</div>
<div class="market-intel-deploy-grid">
<div>
<p class="market-intel-deploy-section-title">PACKAGE GATES</p>
<div class="market-intel-check-list">${
gates.map(gate => `
<div class="market-intel-check">
<div>
<strong>${escapeHtml(gate.key)}</strong>
<small>${escapeHtml(gate.label)}</small>
</div>
<span>${gate.passed ? 'PASS' : 'BLOCK'}</span>
</div>
`).join('') || '<div class="market-intel-empty">尚未產生 package gate。</div>'
}</div>
</div>
<div>
<p class="market-intel-deploy-section-title">PAYLOAD MANIFEST</p>
<div class="market-intel-check-list">
${[
['payload_count', manifest.payload_count || 0],
['manifest_hash', manifest.manifest_hash || 'none'],
['dedupe_keys', (manifest.dedupe_keys || []).join(', ') || 'none'],
['allowed_next_states', (manifest.allowed_next_states || []).join(', ') || 'none']
].map(([key, value]) => `
<div class="market-intel-check">
<div><strong>${escapeHtml(key)}</strong></div>
<span>${escapeHtml(String(value))}</span>
</div>
`).join('')}
</div>
</div>
</div>
<div class="market-intel-deploy-grid mt-3">
<div>
<p class="market-intel-deploy-section-title">ARTIFACTS</p>
<div class="market-intel-check-list">${
artifacts.map(item => `
<div class="market-intel-check">
<div>
<strong>${escapeHtml(item.key)}</strong>
<small>${escapeHtml(item.path_shape || '')}</small>
</div>
<span>${item.created_by_api ? 'API' : 'MANUAL'}</span>
</div>
`).join('') || '<div class="market-intel-empty">尚未提供 artifact 清單。</div>'
}</div>
</div>
<div>
<p class="market-intel-deploy-section-title">COMMANDS</p>
<div class="market-intel-check-list">${
commands.map(command => `
<div class="market-intel-check">
<div>
<strong>${escapeHtml(`${command.step}. ${command.key}`)}</strong>
<small>${escapeHtml(command.command_shape || '')}</small>
</div>
<span>${command.executes_database ? 'DB' : 'NO DB'}</span>
</div>
`).join('') || '<div class="market-intel-empty">尚未產生命令 bundle。</div>'
}</div>
</div>
<div>
<p class="market-intel-deploy-section-title">WRITE FLAGS</p>
<div class="market-intel-check-list">
${[
['api_writes_file', data.api_writes_file],
['api_executes_cli', data.api_executes_cli],
['api_reads_token', data.api_reads_approval_token],
['api_updates_review_state', data.api_updates_review_state],
['database_write', data.database_write_executed],
['scheduler', data.scheduler_attached]
].map(([key, value]) => `
<div class="market-intel-check">
<div><strong>${escapeHtml(key)}</strong></div>
<span>${escapeHtml(String(value))}</span>
</div>
`).join('')}
</div>
</div>
</div>
`;
};
const loadCandidateQueueReviewDecisionRunPackage = async () => {
if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return;
let parsed;
try {
parsed = JSON.parse(sampleReviewInput.value || '{}');
} catch (error) {
sampleReviewMeta.innerHTML = '<span class="market-intel-pill">json_error</span>';
sampleReviewBody.innerHTML = `<div class="market-intel-empty">JSON 格式錯誤:${escapeHtml(error.message)}</div>`;
return;
}
const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed };
sampleReviewBody.innerHTML = '<div class="market-intel-empty">產生 queue review decision writer run package 中...</div>';
try {
const response = await fetch(sampleCandidateQueueReviewDecisionRunPackageEndpoint, {
method: 'POST',
credentials: 'same-origin',
headers: {
'Content-Type': 'application/json',
'X-CSRFToken': csrfToken
},
body: JSON.stringify(body)
});
const data = await response.json();
if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`);
renderCandidateQueueReviewDecisionRunPackage(data);
} catch (error) {
sampleReviewMeta.innerHTML = '<span class="market-intel-pill">error</span>';
sampleReviewBody.innerHTML = `<div class="market-intel-empty">queue review decision writer run package 失敗:${escapeHtml(error.message)}</div>`;
}
};
const renderCandidateQueueReviewDecisionWriter = data => {
const blockers = (data.blocked_reasons || []).join(' / ');
const summary = data.statement_summary || {};
@@ -5633,6 +5767,9 @@
if (sampleCandidateQueueReviewDecisionOperatorDrill) {
sampleCandidateQueueReviewDecisionOperatorDrill.addEventListener('click', loadCandidateQueueReviewDecisionOperatorDrill);
}
if (sampleCandidateQueueReviewDecisionRunPackage) {
sampleCandidateQueueReviewDecisionRunPackage.addEventListener('click', loadCandidateQueueReviewDecisionRunPackage);
}
if (sampleCandidateQueueReviewDecisionWriter) {
sampleCandidateQueueReviewDecisionWriter.addEventListener('click', loadCandidateQueueReviewDecisionWriter);
}

View File

@@ -848,6 +848,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_operator_drill"
in template
)
assert (
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_package"
in template
)
assert (
"data-market-intel-sample-candidate-queue-review-decision-writer"
in template
@@ -864,6 +868,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
"data-market-intel-sample-candidate-queue-review-decision-operator-drill"
in template
)
assert (
"data-market-intel-sample-candidate-queue-review-decision-run-package"
in template
)
assert "X-CSRFToken" in template
assert "market_intel.market_intel_scheduler_plan" in template
assert "market_intel.market_intel_match_review_plan" in template
@@ -900,7 +908,7 @@ def test_legacy_source_bridge_default_is_planned_only():
bridge = MarketIntelService().build_legacy_source_bridge()
assert bridge["mode"] == "legacy_source_bridge_planned"
assert bridge["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert bridge["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert bridge["execute_requested"] is False
assert bridge["read_only_query_executed"] is False
assert bridge["database_connection_opened"] is False
@@ -1058,7 +1066,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
contract = MarketIntelService().build_mcp_tool_contract()
assert contract["mode"] == "mcp_tool_contract_preview"
assert contract["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert contract["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert contract["caller"] == "market_intel"
assert contract["contract_ready"] is True
assert contract["blocked_reasons"] == []
@@ -1191,7 +1199,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_activation_runbook_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -1204,7 +1212,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
assert gate["mode"] == "mcp_fetch_gate_planned"
assert gate["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert gate["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert gate["fetch_requested"] is True
assert gate["manual_fetch_gate_open"] is False
assert gate["network_request_allowed"] is False
@@ -1274,7 +1282,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_fetch_gate_planned"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["fetch_requested"] is False
assert data["network_request_allowed"] is False
assert data["external_network_executed"] is False
@@ -1286,7 +1294,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write():
plan = MarketIntelService().build_manual_sample_plan()
assert plan["mode"] == "manual_sample_fetch_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_for_manual_sample_fetch"] is False
assert plan["sample_fetch_executed"] is False
assert plan["external_network_executed"] is False
@@ -1334,7 +1342,7 @@ def test_manual_sample_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_fetch_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["sample_fetch_executed"] is False
assert data["external_network_executed"] is False
assert data["database_write_executed"] is False
@@ -1345,7 +1353,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import():
acceptance = MarketIntelService().build_manual_sample_acceptance()
assert acceptance["mode"] == "manual_sample_acceptance_preview"
assert acceptance["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert acceptance["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert acceptance["contract_ready"] is True
assert acceptance["sample_result_loaded"] is False
assert acceptance["sample_result_accepted"] is False
@@ -1387,7 +1395,7 @@ def test_manual_sample_acceptance_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_acceptance_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["sample_result_loaded"] is False
assert data["candidate_import_allowed"] is False
assert data["external_network_executed"] is False
@@ -1399,7 +1407,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded():
review = MarketIntelService().build_manual_sample_review()
assert review["mode"] == "manual_sample_review_preview"
assert review["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert review["contract_ready"] is True
assert review["sample_result_loaded"] is False
assert review["sample_result_reviewed"] is False
@@ -1510,7 +1518,7 @@ def test_manual_sample_review_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_review_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["sample_result_loaded"] is False
assert data["sample_result_reviewed"] is False
assert data["candidate_import_allowed"] is False
@@ -1549,7 +1557,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist
)
assert review["mode"] == "manual_sample_review_evaluation_preview"
assert review["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert review["review_request_type"] == "operator_posted_json"
assert review["payload_received"] is True
assert review["payload_valid_json_object"] is True
@@ -1611,7 +1619,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_review_evaluation_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["payload_received"] is True
assert data["payload_valid_json_object"] is True
assert data["payload_persisted"] is False
@@ -1691,7 +1699,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers
)
assert handoff["mode"] == "manual_sample_candidate_handoff_preview"
assert handoff["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert handoff["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert handoff["payload_received"] is True
assert handoff["payload_valid_json_object"] is True
assert handoff["payload_persisted"] is False
@@ -1755,7 +1763,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_handoff_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["payload_received"] is True
assert data["handoff_ready"] is True
assert data["candidate_handoff_created"] is True
@@ -1814,7 +1822,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without
)
assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview"
assert queue_draft["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert queue_draft["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert queue_draft["payload_received"] is True
assert queue_draft["payload_valid_json_object"] is True
assert queue_draft["payload_persisted"] is False
@@ -1888,7 +1896,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_draft_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["payload_received"] is True
assert data["handoff_ready"] is True
assert data["queue_draft_ready"] is True
@@ -1951,7 +1959,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro
)
assert approval["mode"] == "manual_sample_candidate_queue_approval_preview"
assert approval["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert approval["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert approval["payload_received"] is True
assert approval["payload_valid_json_object"] is True
assert approval["payload_persisted"] is False
@@ -2029,7 +2037,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write(
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_approval_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["payload_received"] is True
assert data["approval_preview_created"] is True
assert data["approval_request_created"] is False
@@ -2092,7 +2100,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution():
)
assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview"
assert transaction["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert transaction["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert transaction["payload_received"] is True
assert transaction["payload_valid_json_object"] is True
assert transaction["payload_persisted"] is False
@@ -2172,7 +2180,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_transaction_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["payload_received"] is True
assert data["transaction_preview_created"] is True
assert data["transaction_ready"] is False
@@ -4170,6 +4178,94 @@ def test_candidate_queue_review_decision_writer_operator_drill_preview_is_safe()
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_review_decision_writer_run_package_preview_is_safe():
from services.market_intel.candidate_queue_review_decision_writer_cli import (
build_candidate_queue_review_decision_writer_cli_plan,
)
from services.market_intel.candidate_queue_review_decision_writer_preflight import (
build_candidate_queue_review_decision_writer_preflight,
)
from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import (
build_candidate_queue_review_decision_writer_postwrite_smoke,
)
from services.market_intel.candidate_queue_review_decision_writer_operator_drill import (
build_candidate_queue_review_decision_writer_operator_drill,
)
from services.market_intel.candidate_queue_review_decision_writer_run_package import (
build_candidate_queue_review_decision_writer_run_package,
)
transaction, operator_evidence = _build_ready_review_decision_transaction()
operator_evidence = {
**operator_evidence,
"operator_confirmed_manual_shell_window": True,
"operator_confirmed_post_update_inventory_planned": True,
"operator_drill_notes": "review_state shell drill reviewed",
}
writer_status = build_candidate_queue_review_decision_writer_cli_plan(
transaction_preview=transaction,
operator_evidence=operator_evidence,
)
preflight = build_candidate_queue_review_decision_writer_preflight(
writer_status=writer_status,
transaction_preview=transaction,
operator_evidence=operator_evidence,
)
smoke = build_candidate_queue_review_decision_writer_postwrite_smoke(
transaction_preview=transaction,
execute_requested=False,
)
drill = build_candidate_queue_review_decision_writer_operator_drill(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_evidence=operator_evidence,
)
package = build_candidate_queue_review_decision_writer_run_package(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_drill=drill,
)
payload = json.dumps(package, ensure_ascii=False, sort_keys=True)
assert package["mode"] == (
"candidate_queue_review_decision_writer_run_package_preview"
)
assert package["target_table"] == "market_alert_review_queue"
assert package["target_operation"] == "update_review_state"
assert package["package_ready"] is False
assert package["package_artifact_created"] is False
assert package["ready_for_api_review_state_update"] is False
assert package["ready_for_api_database_write"] is False
assert package["ready_for_scheduler_attach"] is False
assert package["api_writes_file"] is False
assert package["api_executes_cli"] is False
assert package["api_reads_approval_token"] is False
assert package["api_writes_database"] is False
assert package["api_updates_review_state"] is False
assert package["review_state_update_executed"] is False
assert package["database_connection_opened"] is False
assert package["database_session_created"] is False
assert package["transaction_opened"] is False
assert package["transaction_committed"] is False
assert package["database_write_executed"] is False
assert package["database_commit_executed"] is False
assert package["scheduler_attached"] is False
assert package["payload_manifest"]["payload_count"] == 1
assert package["payload_manifest"]["payloads"][0]["next_review_state"] == "confirmed"
assert len(package["required_artifacts"]) == 5
assert len(package["command_bundle"]) == 5
assert "backup_artifact_path_recorded" in package["blocked_reasons"]
assert "one_time_token_supplied_in_shell_only" in package["blocked_reasons"]
assert "do_not_update_review_state_from_review_state_run_package" in package[
"safe_boundaries"
]
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
@@ -4212,7 +4308,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_preflight_planned"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -4269,7 +4365,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_cli_blocked"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["approval_token_present"] is False
@@ -4358,7 +4454,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write(
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -4412,7 +4508,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write()
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_operator_drill_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["operator_drill_ready"] is True
assert data["api_executes_cli"] is False
assert data["api_reads_approval_token"] is False
@@ -4468,7 +4564,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_package_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["package_ready"] is True
assert data["package_artifact_created"] is False
assert data["api_writes_file"] is False
@@ -4534,7 +4630,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_readiness_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["ready_for_cli_operator_run"] is True
assert data["ready_for_api_database_write"] is False
assert data["api_executes_cli"] is False
@@ -4836,7 +4932,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["receipt_passed"] is True
assert data["ready_for_api_database_write"] is False
assert data["ready_for_scheduler_attach"] is False
@@ -4884,7 +4980,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_closeout_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["closeout_passed"] is True
assert data["ready_for_next_manual_phase"] is True
assert data["ready_for_api_database_write"] is False
@@ -4933,7 +5029,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_handoff_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["handoff_ready"] is True
assert data["ready_for_manual_queue_review"] is True
assert data["ready_for_api_database_write"] is False
@@ -4991,7 +5087,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write():
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_inventory_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["review_inventory_ready"] is False
assert data["ready_for_human_decision_review"] is False
@@ -5057,7 +5153,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write():
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["decision_ready"] is False
assert data["ready_for_human_decision_record"] is False
assert data["ready_for_api_review_state_update"] is False
@@ -5128,7 +5224,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_approval_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["approval_ready"] is False
assert data["ready_for_review_state_transaction_preview"] is False
assert data["ready_for_cli_decision_writer"] is False
@@ -5204,7 +5300,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_transaction_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["transaction_preview_created"] is False
assert data["transaction_ready"] is False
assert data["ready_for_manual_shell_update_window"] is False
@@ -5286,7 +5382,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["approval_token_present"] is False
@@ -5372,7 +5468,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and
assert data["mode"] == (
"candidate_queue_review_decision_writer_preflight_preview"
)
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["read_only_query_executed"] is False
@@ -5455,7 +5551,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on
assert data["mode"] == (
"candidate_queue_review_decision_writer_postwrite_smoke_planned"
)
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -5538,7 +5634,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl
assert data["mode"] == (
"candidate_queue_review_decision_writer_operator_drill_preview"
)
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["operator_drill_ready"] is False
assert data["ready_for_api_review_state_update"] is False
assert data["ready_for_api_database_write"] is False
@@ -5566,6 +5662,90 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
from routes.market_intel_review_routes import market_intel_review_bp
fixture = _build_candidate_queue_writer_receipt_fixture(
"sample-batch-review-decision-run-package-route"
)
app = Flask(__name__)
app.secret_key = "test-secret"
app.register_blueprint(market_intel_bp)
app.register_blueprint(market_intel_review_bp)
client = app.test_client()
with client.session_transaction() as session:
session["logged_in"] = True
get_response = client.get(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_package"
)
response = client.post(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_package",
json={
"sample_result": fixture["sample_result"],
"operator_evidence": {
**fixture["operator_evidence"],
"closeout_artifact_path": "artifacts/market_intel/closeout.json",
"operator_confirmed_queue_review_next": True,
"operator_confirmed_no_scheduler_attach": True,
"operator_confirmed_no_api_db_write": True,
"operator_confirmed_inventory_read_only": True,
"reviewer_id": "operator-a",
"proposed_review_decision": "confirmed",
"decision_notes": "manual review only",
"operator_confirmed_manual_decision_only": True,
"decision_approval_notes": "cli-only approval gate",
"operator_confirmed_decision_payload_reviewed": True,
"operator_confirmed_decision_apply_requires_cli": True,
"operator_confirmed_review_state_update_is_not_api": True,
"decision_transaction_notes": "shell-only transaction preview",
"operator_confirmed_transaction_payload_reviewed": True,
"operator_confirmed_cli_only_transaction": True,
"operator_confirmed_manual_shell_window": True,
"operator_confirmed_post_update_inventory_planned": True,
"operator_drill_notes": "manual shell drill reviewed",
},
"writer_output": fixture["writer_output"],
"postwrite_smoke_result": fixture["postwrite_smoke_result"],
},
)
data = response.get_json()
payload = json.dumps(data, ensure_ascii=False, sort_keys=True)
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == (
"candidate_queue_review_decision_writer_run_package_preview"
)
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["package_ready"] is False
assert data["package_artifact_created"] is False
assert data["ready_for_api_review_state_update"] is False
assert data["ready_for_api_database_write"] is False
assert data["ready_for_scheduler_attach"] is False
assert data["api_writes_file"] is False
assert data["api_executes_cli"] is False
assert data["api_reads_approval_token"] is False
assert data["api_writes_database"] is False
assert data["api_updates_review_state"] is False
assert data["database_connection_opened"] is False
assert data["database_write_executed"] is False
assert data["database_commit_executed"] is False
assert data["review_state_update_executed"] is False
assert data["scheduler_attached"] is False
assert data["payload_manifest"]["payload_count"] == 0
assert "transaction_preview_created" in data["blocked_reasons"]
assert "transaction_has_update_statements" in data["blocked_reasons"]
assert "backup_artifact_path_recorded" in data["blocked_reasons"]
assert "do_not_execute_review_state_writer_from_run_package_api" in data[
"safe_boundaries"
]
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
@@ -5594,7 +5774,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["receipt_passed"] is True
assert data["ready_for_next_manual_review"] is True
assert data["ready_for_api_database_write"] is False
@@ -5619,7 +5799,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
plan = MarketIntelService().build_scheduler_plan()
assert plan["mode"] == "scheduler_attach_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_to_attach_scheduler"] is False
assert plan["scheduler_attached"] is False
assert plan["scheduler_registration_executed"] is False
@@ -5657,7 +5837,7 @@ def test_scheduler_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "scheduler_attach_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["scheduler_registration_executed"] is False
assert data["crawler_job_started"] is False
assert data["external_network_executed"] is False
@@ -5668,7 +5848,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
plan = MarketIntelService().build_match_review_plan()
assert plan["mode"] == "match_review_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_for_review_queue"] is False
assert plan["review_queue_created"] is False
assert plan["auto_match_executed"] is False
@@ -5704,7 +5884,7 @@ def test_match_review_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "match_review_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["review_queue_created"] is False
assert data["auto_confirm_executed"] is False
assert data["external_network_executed"] is False
@@ -5715,7 +5895,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
plan = MarketIntelService().build_opportunity_plan()
assert plan["mode"] == "opportunity_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_for_opportunity_queue"] is False
assert plan["opportunity_queue_created"] is False
assert plan["threat_alert_dispatched"] is False
@@ -5756,7 +5936,7 @@ def test_opportunity_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["opportunity_queue_created"] is False
assert data["threat_alert_dispatched"] is False
assert data["ai_summary_generated"] is False
@@ -5767,7 +5947,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
plan = MarketIntelService().build_opportunity_scoring_plan()
assert plan["mode"] == "opportunity_scoring_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_for_scoring_job"] is False
assert plan["scoring_job_created"] is False
assert plan["score_calculation_executed"] is False
@@ -5815,7 +5995,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_scoring_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["scoring_job_created"] is False
assert data["score_calculation_executed"] is False
assert data["sample_scores_generated"] is False
@@ -5827,7 +6007,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
plan = MarketIntelService().build_opportunity_evidence_plan()
assert plan["mode"] == "opportunity_evidence_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_for_evidence_bundle"] is False
assert plan["evidence_bundle_created"] is False
assert plan["evidence_query_executed"] is False
@@ -5873,7 +6053,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_evidence_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["evidence_bundle_created"] is False
assert data["evidence_query_executed"] is False
assert data["sample_evidence_generated"] is False
@@ -5886,7 +6066,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
plan = MarketIntelService().build_opportunity_alert_plan()
assert plan["mode"] == "opportunity_alert_plan_preview"
assert plan["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["ready_for_alert_candidates"] is False
assert plan["alert_candidate_created"] is False
assert plan["alert_queue_created"] is False
@@ -5971,7 +6151,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_alert_plan_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["alert_candidate_created"] is False
assert data["alert_queue_created"] is False
assert data["review_queue_created"] is False
@@ -6049,7 +6229,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_external_deploy_preflight_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -6064,7 +6244,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
readiness = MarketIntelService().build_mcp_readiness()
assert readiness["mode"] == "mcp_readiness_planned"
assert readiness["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert readiness["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert readiness["execute_requested"] is False
assert readiness["router_enabled"] is False
assert readiness["external_mcp_complete"] is False
@@ -6528,6 +6708,12 @@ def test_deployment_readiness_reports_app_only_release_gate():
]
is True
)
assert (
readiness["checks"][
"candidate_queue_review_decision_writer_run_package_preview_safe"
]
is True
)
assert (
readiness["checks"][
"candidate_queue_review_decision_writer_cli_status_safe"
@@ -6637,6 +6823,11 @@ def test_deployment_readiness_reports_app_only_release_gate():
"candidate_queue_review_decision_writer_operator_drill"
in readiness["production_smoke_targets"]
)
assert (
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_package"
in readiness["production_smoke_targets"]
)
assert (
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_status"
@@ -7578,6 +7769,52 @@ def test_deployment_readiness_reports_app_only_release_gate():
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"]["mode"]
== "candidate_queue_review_decision_writer_run_package_preview"
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"package_artifact_created"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"api_writes_file"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"api_executes_cli"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"api_reads_approval_token"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"api_updates_review_state"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"database_write_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_package"][
"scheduler_attached"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_status"]["mode"]
== "candidate_queue_review_decision_writer_cli_blocked"
@@ -7728,7 +7965,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only():
drill = MarketIntelService().build_migration_apply_drill()
assert drill["mode"] == "migration_apply_drill_preview"
assert drill["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert drill["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert drill["execute_requested"] is False
assert drill["schema_state"] == "planned_no_db_probe"
assert drill["drill_ready_for_operator_review"] is True
@@ -7843,7 +8080,7 @@ def test_migration_apply_drill_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_apply_drill_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["migration_executed"] is False
assert data["rollback_executed"] is False
@@ -7855,7 +8092,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic():
review = MarketIntelService().build_migration_catalog_review()
assert review["mode"] == "migration_catalog_review_preview"
assert review["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert review["execute_requested"] is False
assert review["catalog_state"] == "planned_no_probe"
assert review["seed_state"] == "planned_no_probe"
@@ -7970,7 +8207,7 @@ def test_migration_catalog_review_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_catalog_review_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["catalog_state"] == "planned_no_probe"
assert data["migration_executed"] is False
@@ -7983,7 +8220,7 @@ def test_migration_live_smoke_planned_is_preview_only():
smoke = MarketIntelService().build_migration_live_smoke()
assert smoke["mode"] == "migration_live_smoke_preview"
assert smoke["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert smoke["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert smoke["execute_requested"] is False
assert smoke["smoke_result"] == "planned_no_execution"
assert smoke["live_smoke_passed"] is False
@@ -8045,7 +8282,7 @@ def test_migration_live_smoke_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_live_smoke_preview"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["smoke_result"] == "planned_no_execution"
assert data["migration_executed"] is False
@@ -8058,7 +8295,7 @@ def test_live_db_inventory_planned_is_preview_only():
inventory = MarketIntelService().build_live_db_inventory()
assert inventory["mode"] == "live_db_inventory_planned"
assert inventory["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert inventory["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert inventory["execute_requested"] is False
assert inventory["read_only_query_executed"] is False
assert inventory["database_connection_opened"] is False
@@ -8202,7 +8439,7 @@ def test_live_db_inventory_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "live_db_inventory_planned"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_write_executed"] is False
@@ -8429,7 +8666,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path):
assert result.returncode == 0
assert data["mode"] == "candidate_queue_writer_cli_blocked"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["apply_real_write_requested"] is False
assert data["writes_executed"] is False
@@ -8458,7 +8695,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en
assert result.returncode == 0
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
assert data["phase"] == "phase_72_candidate_queue_review_decision_writer_operator_drill"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["execute_requested"] is False
assert data["apply_real_write_requested"] is False
assert data["approval_token_present"] is False