新增市場情報 review decision writer postwrite smoke
All checks were successful
CD Pipeline / deploy (push) Successful in 1m4s
All checks were successful
CD Pipeline / deploy (push) Successful in 1m4s
This commit is contained in:
@@ -143,6 +143,7 @@
|
||||
- Phase 69 candidate queue review decision writer CLI gate:新增 `services/market_intel/candidate_queue_review_decision_writer_cli.py`、`scripts/market_intel_review_decision_writer.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status` 與 UI writer gate 按鈕,先建立 shell-only review_state writer gate 與 command bundle;writer implementation 本階段保持 disabled,API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state、不掛 scheduler;版本同步至 V10.257。
|
||||
- Phase 70 candidate queue review decision writer preflight:新增 `services/market_intel/candidate_queue_review_decision_writer_preflight.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight` 與 UI preflight 按鈕,檢查 writer status、review_state update payload、狀態轉換與禁止 token 進 API;API/UI 即使收到 execute/apply_real_write 也不連 DB、不執行 CLI、不更新 review_state、不 commit、不讀 token、不掛 scheduler;版本同步至 V10.258。
|
||||
- V10.259 補 Phase 70 preflight 合約與 OCLearn queue 時區:preflight 補 planned/read-only catalog probe 欄位、dedupe unique index 檢查與 route 重複註冊清理;OCLearn embedding queue 的 created_at/updated_at/stale cutoff 改為台北 naive,避免 UTC/台北時間差讓 processing 任務卡住。
|
||||
- Phase 71 candidate queue review decision writer post-write smoke:新增 `services/market_intel/candidate_queue_review_decision_writer_postwrite_smoke.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` 與 UI smoke 按鈕,人工 CLI 更新 review_state 後可用 dedupe key 只讀驗證 row 是否存在且 state 符合預期;API/UI 預設不連 DB,execute=true 也只讀查詢,不更新 review_state、不 commit、不讀 token、不掛 scheduler;版本同步至 V10.260。
|
||||
- V10.248 補市場情報 390px preview panel QA:sample review 工具列改為 textarea + 可換行 action rail,移除舊的硬編 8 欄 grid;`check_responsive_overflow` 新增 `--screenshot-all`,本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。
|
||||
- V10.250 補 Code Review Gemini 備援遙測護欄:Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`,測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」;AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援,避免誤判 Gemini-first。
|
||||
- Schema smoke:`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。
|
||||
|
||||
@@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '')
|
||||
# ==========================================
|
||||
# 系統版本與路徑
|
||||
# ==========================================
|
||||
SYSTEM_VERSION = "V10.259"
|
||||
SYSTEM_VERSION = "V10.260"
|
||||
LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log')
|
||||
public_url = PUBLIC_URL # 用於模板顯示
|
||||
|
||||
|
||||
@@ -196,6 +196,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome
|
||||
- 2026-05-19 追加 candidate queue review decision transaction:`services.market_intel.candidate_queue_review_decision_transaction` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction` 將已批准的人工決策整理成 `review_state` update statement preview、payload hash、runtime order 與 rollback plan。此階段不連 DB、不開 transaction、不 commit、不更新 `review_state`、不讀 approval token、不執行 CLI、不掛 scheduler;真正更新只允許後續人工 shell/CLI 寫入窗口。
|
||||
- 2026-05-19 追加 candidate queue review decision writer CLI gate:`services.market_intel.candidate_queue_review_decision_writer_cli`、`scripts/market_intel_review_decision_writer.py` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status` 先建立 review_state writer 的 shell-only gate、一次性 token env var、command bundle 與 rollback plan。此階段 writer implementation 保持 disabled;API/UI 不讀 approval token、不執行 CLI、不連 DB、不開 transaction、不 commit、不更新 `review_state`、不掛 scheduler。
|
||||
- 2026-05-19 追加 candidate queue review decision writer preflight:`services.market_intel.candidate_queue_review_decision_writer_preflight` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight` 檢查 writer status、review_state update payload、狀態轉換與 token 外洩風險。API/UI 即使收到 `execute=true` 或 `apply_real_write=true` 也只回 blocked preview,不連 DB、不執行 CLI、不更新 `review_state`、不 commit、不讀 approval token、不掛 scheduler。
|
||||
- 2026-05-19 追加 candidate queue review decision writer post-write smoke:`services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` 依 review_state transaction preview 的 dedupe key 只讀查詢 `market_alert_review_queue`,確認人工 CLI 更新後的 `review_state` 是否符合預期。UI 預設 `execute=false` 不連 DB;人工 smoke 即使 `execute=true` 也只讀查詢,不更新 `review_state`、不 commit、不讀 approval token、不掛 scheduler。
|
||||
|
||||
### Phase 4:Coupang / Shopee Adapter
|
||||
|
||||
|
||||
@@ -19,8 +19,8 @@
|
||||
| `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` |
|
||||
| `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` |
|
||||
| `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` |
|
||||
| `market_intel_routes.py` | 市場情報 Phase 70 candidate queue review decision writer preflight 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` |
|
||||
| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight` |
|
||||
| `market_intel_routes.py` | 市場情報 Phase 71 candidate queue review decision writer post-write smoke 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` |
|
||||
| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` |
|
||||
| `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` |
|
||||
| `export_routes.py` | 匯出功能 | `/api/export/*` |
|
||||
| `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` |
|
||||
|
||||
@@ -27,6 +27,9 @@ from services.market_intel.candidate_queue_review_decision_writer_cli import (
|
||||
from services.market_intel.candidate_queue_review_decision_writer_preflight import (
|
||||
build_candidate_queue_review_decision_writer_preflight,
|
||||
)
|
||||
from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import (
|
||||
build_candidate_queue_review_decision_writer_postwrite_smoke,
|
||||
)
|
||||
from services.market_intel.candidate_queue_writer_cli import (
|
||||
build_candidate_queue_writer_cli_plan,
|
||||
)
|
||||
@@ -431,3 +434,33 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_preflight(
|
||||
)
|
||||
data["phase"] = service.phase
|
||||
return jsonify(data), 400 if payload_error else 200
|
||||
|
||||
|
||||
@market_intel_review_bp.route(
|
||||
"/api/market_intel/manual_sample_review/"
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke",
|
||||
methods=["POST"],
|
||||
)
|
||||
@login_required
|
||||
def market_intel_manual_sample_candidate_queue_review_decision_writer_postwrite_smoke():
|
||||
service = MarketIntelService()
|
||||
execute_requested = request.args.get("execute", "false").lower() == "true"
|
||||
sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = (
|
||||
_extract_run_payload()
|
||||
)
|
||||
transaction = _build_review_decision_transaction_stack(
|
||||
service=service,
|
||||
sample_result=sample_result,
|
||||
payload_error=payload_error,
|
||||
operator_evidence=operator_evidence,
|
||||
writer_output=writer_output,
|
||||
postwrite_smoke_result=smoke_result,
|
||||
limit=limit,
|
||||
execute_requested=False,
|
||||
)
|
||||
data = build_candidate_queue_review_decision_writer_postwrite_smoke(
|
||||
transaction_preview=transaction,
|
||||
execute_requested=execute_requested,
|
||||
)
|
||||
data["phase"] = service.phase
|
||||
return jsonify(data), 400 if payload_error else 200
|
||||
|
||||
@@ -0,0 +1,284 @@
|
||||
"""候選審核 queue review_state writer post-write 只讀 smoke。
|
||||
|
||||
本模組只依 review_state transaction preview 的 dedupe key 查詢
|
||||
market_alert_review_queue,確認人工 CLI 更新後 row 的 review_state 是否符合預期;
|
||||
不建立 ORM session、不更新 review_state、不 commit、不掛 scheduler。
|
||||
"""
|
||||
|
||||
from sqlalchemy import bindparam, create_engine, text
|
||||
|
||||
from services.market_intel.candidate_queue_review_decision_transaction import (
|
||||
ALLOWED_DECISIONS,
|
||||
TARGET_TABLE,
|
||||
)
|
||||
|
||||
|
||||
def _as_dict(value):
|
||||
return value if isinstance(value, dict) else {}
|
||||
|
||||
|
||||
def _expected_updates_from_transaction(transaction_preview):
|
||||
updates = []
|
||||
for statement in _as_dict(transaction_preview).get("statements", []):
|
||||
statement = _as_dict(statement)
|
||||
parameter_preview = _as_dict(statement.get("parameter_preview"))
|
||||
lookup = _as_dict(statement.get("lookup"))
|
||||
dedupe_key = (
|
||||
parameter_preview.get("dedupe_key")
|
||||
or lookup.get("dedupe_key")
|
||||
or statement.get("dedupe_key")
|
||||
)
|
||||
expected_state = (
|
||||
parameter_preview.get("next_review_state")
|
||||
or statement.get("next_review_state")
|
||||
)
|
||||
expected_current_state = (
|
||||
parameter_preview.get("expected_current_review_state")
|
||||
or statement.get("expected_current_review_state")
|
||||
)
|
||||
updates.append(
|
||||
{
|
||||
"dedupe_key": str(dedupe_key) if dedupe_key else None,
|
||||
"expected_current_review_state": expected_current_state,
|
||||
"expected_review_state": expected_state,
|
||||
"idempotency_key": statement.get("idempotency_key"),
|
||||
"parameter_payload_hash": statement.get("parameter_payload_hash"),
|
||||
}
|
||||
)
|
||||
return updates
|
||||
|
||||
|
||||
def _safe_row(row):
|
||||
payload = dict(row._mapping)
|
||||
for key, value in list(payload.items()):
|
||||
if value is not None and not isinstance(value, (bool, int, float, str)):
|
||||
payload[key] = str(value)
|
||||
return payload
|
||||
|
||||
|
||||
def _base_payload(*, mode, execute_requested, expected_updates):
|
||||
dedupe_keys = sorted(
|
||||
{item["dedupe_key"] for item in expected_updates if item.get("dedupe_key")}
|
||||
)
|
||||
return {
|
||||
"mode": mode,
|
||||
"target_table": TARGET_TABLE,
|
||||
"target_operation": "verify_review_state_update",
|
||||
"execute_requested": bool(execute_requested),
|
||||
"read_only_query_executed": False,
|
||||
"database_connection_opened": False,
|
||||
"database_session_created": False,
|
||||
"explicit_transaction_opened": False,
|
||||
"transaction_opened": False,
|
||||
"transaction_committed": False,
|
||||
"database_write_executed": False,
|
||||
"database_commit_executed": False,
|
||||
"database_rollback_executed": False,
|
||||
"external_network_executed": False,
|
||||
"scheduler_attached": False,
|
||||
"review_state_update_executed": False,
|
||||
"api_updates_review_state": False,
|
||||
"ready_for_api_review_state_update": False,
|
||||
"ready_for_api_database_write": False,
|
||||
"ready_for_scheduler_attach": False,
|
||||
"writes_executed": False,
|
||||
"would_write_database": False,
|
||||
"expected_update_count": len(expected_updates),
|
||||
"expected_dedupe_key_count": len(dedupe_keys),
|
||||
"dedupe_keys": dedupe_keys,
|
||||
"expected_review_state_updates": expected_updates,
|
||||
"allowed_review_states": list(ALLOWED_DECISIONS),
|
||||
"found_count": 0,
|
||||
"missing_count": len(dedupe_keys),
|
||||
"state_mismatch_count": 0,
|
||||
"found_dedupe_keys": [],
|
||||
"missing_dedupe_keys": dedupe_keys,
|
||||
"state_mismatches": [],
|
||||
"row_summaries": [],
|
||||
"postwrite_smoke_passed": False,
|
||||
"review_state_update_verified": False,
|
||||
"ready_for_operator_review": False,
|
||||
"safety_contract": _safety_contract(),
|
||||
"safe_boundaries": [
|
||||
"do_not_execute_review_state_writer_from_smoke_api",
|
||||
"do_not_update_review_state_from_postwrite_smoke",
|
||||
"do_not_read_approval_token_from_postwrite_smoke",
|
||||
"do_not_commit_review_state_postwrite_smoke",
|
||||
"do_not_attach_scheduler_from_review_state_postwrite_smoke",
|
||||
"no_remove_orphans",
|
||||
"no_momo_db_lifecycle_change",
|
||||
],
|
||||
}
|
||||
|
||||
|
||||
def _safety_contract():
|
||||
return {
|
||||
"target_table": TARGET_TABLE,
|
||||
"target_operation": "verify_review_state_update",
|
||||
"read_only_query_only": True,
|
||||
"does_not_read_approval_token": True,
|
||||
"does_not_open_transaction": True,
|
||||
"does_not_update_review_state": True,
|
||||
"does_not_commit": True,
|
||||
"does_not_attach_scheduler": True,
|
||||
"allowed_review_states": list(ALLOWED_DECISIONS),
|
||||
}
|
||||
|
||||
|
||||
def _planned_result(expected_updates):
|
||||
payload = _base_payload(
|
||||
mode="candidate_queue_review_decision_writer_postwrite_smoke_planned",
|
||||
execute_requested=False,
|
||||
expected_updates=expected_updates,
|
||||
)
|
||||
payload["blocked_reasons"] = [
|
||||
"execute_false_planned_only",
|
||||
"review_decision_writer_postwrite_smoke_not_loaded",
|
||||
]
|
||||
if not payload["dedupe_keys"]:
|
||||
payload["blocked_reasons"].append("transaction_statement_dedupe_keys_missing")
|
||||
return payload
|
||||
|
||||
|
||||
def build_candidate_queue_review_decision_writer_postwrite_smoke(
|
||||
*,
|
||||
transaction_preview,
|
||||
execute_requested=False,
|
||||
database_url=None,
|
||||
database_type=None,
|
||||
engine=None,
|
||||
):
|
||||
"""建立 review_state writer post-write smoke;execute=true 仍只讀查詢。"""
|
||||
expected_updates = _expected_updates_from_transaction(transaction_preview)
|
||||
if not execute_requested:
|
||||
return _planned_result(expected_updates)
|
||||
|
||||
from config import DATABASE_PATH, DATABASE_TYPE
|
||||
|
||||
effective_database_type = (database_type or DATABASE_TYPE or "").lower()
|
||||
effective_database_url = database_url or DATABASE_PATH
|
||||
created_engine = False
|
||||
connection_opened = False
|
||||
payload = _base_payload(
|
||||
mode="candidate_queue_review_decision_writer_postwrite_smoke_read_only",
|
||||
execute_requested=True,
|
||||
expected_updates=expected_updates,
|
||||
)
|
||||
|
||||
try:
|
||||
if engine is None:
|
||||
connect_args = {}
|
||||
if effective_database_type == "postgresql":
|
||||
connect_args = {
|
||||
"connect_timeout": 8,
|
||||
"options": "-c statement_timeout=15000",
|
||||
}
|
||||
engine = create_engine(
|
||||
effective_database_url,
|
||||
isolation_level="AUTOCOMMIT",
|
||||
pool_pre_ping=True,
|
||||
connect_args=connect_args,
|
||||
)
|
||||
created_engine = True
|
||||
|
||||
rows = []
|
||||
if payload["dedupe_keys"]:
|
||||
query = text(
|
||||
"""
|
||||
SELECT
|
||||
id,
|
||||
alert_candidate_id,
|
||||
review_state,
|
||||
priority_lane,
|
||||
threshold_level,
|
||||
total_score,
|
||||
evidence_bundle_id,
|
||||
dedupe_key,
|
||||
source_batch_id,
|
||||
reviewed_at,
|
||||
created_at,
|
||||
updated_at
|
||||
FROM market_alert_review_queue
|
||||
WHERE dedupe_key IN :dedupe_keys
|
||||
ORDER BY dedupe_key
|
||||
"""
|
||||
).bindparams(bindparam("dedupe_keys", expanding=True))
|
||||
with engine.connect() as conn:
|
||||
connection_opened = True
|
||||
rows = conn.execute(
|
||||
query,
|
||||
{"dedupe_keys": tuple(payload["dedupe_keys"])},
|
||||
).fetchall()
|
||||
else:
|
||||
with engine.connect():
|
||||
connection_opened = True
|
||||
|
||||
row_summaries = [_safe_row(row) for row in rows]
|
||||
found_by_key = {row["dedupe_key"]: row for row in row_summaries}
|
||||
expected_by_key = {
|
||||
item["dedupe_key"]: item
|
||||
for item in expected_updates
|
||||
if item.get("dedupe_key")
|
||||
}
|
||||
found_keys = sorted(found_by_key)
|
||||
missing_keys = [
|
||||
key for key in payload["dedupe_keys"] if key not in found_by_key
|
||||
]
|
||||
state_mismatches = []
|
||||
for dedupe_key, expected in expected_by_key.items():
|
||||
row = found_by_key.get(dedupe_key)
|
||||
if not row:
|
||||
continue
|
||||
actual_state = row.get("review_state")
|
||||
expected_state = expected.get("expected_review_state")
|
||||
if actual_state != expected_state:
|
||||
state_mismatches.append(
|
||||
{
|
||||
"dedupe_key": dedupe_key,
|
||||
"expected_review_state": expected_state,
|
||||
"actual_review_state": actual_state,
|
||||
}
|
||||
)
|
||||
|
||||
passed = bool(payload["dedupe_keys"] and not missing_keys and not state_mismatches)
|
||||
blocked_reasons = []
|
||||
if not payload["dedupe_keys"]:
|
||||
blocked_reasons.append("transaction_statement_dedupe_keys_missing")
|
||||
if missing_keys:
|
||||
blocked_reasons.append("queue_rows_missing_after_review_state_write")
|
||||
if state_mismatches:
|
||||
blocked_reasons.append("review_state_mismatch_after_write")
|
||||
|
||||
payload.update(
|
||||
{
|
||||
"read_only_query_executed": True,
|
||||
"database_connection_opened": connection_opened,
|
||||
"found_count": len(found_keys),
|
||||
"missing_count": len(missing_keys),
|
||||
"state_mismatch_count": len(state_mismatches),
|
||||
"found_dedupe_keys": found_keys,
|
||||
"missing_dedupe_keys": missing_keys,
|
||||
"state_mismatches": state_mismatches,
|
||||
"row_summaries": row_summaries,
|
||||
"postwrite_smoke_passed": passed,
|
||||
"review_state_update_verified": passed,
|
||||
"ready_for_operator_review": passed,
|
||||
"blocked_reasons": blocked_reasons,
|
||||
}
|
||||
)
|
||||
return payload
|
||||
except Exception as exc:
|
||||
payload.update(
|
||||
{
|
||||
"mode": "candidate_queue_review_decision_writer_postwrite_smoke_error",
|
||||
"database_connection_opened": connection_opened,
|
||||
"blocked_reasons": [
|
||||
"review_decision_writer_postwrite_smoke_error"
|
||||
],
|
||||
"error_message": str(exc),
|
||||
}
|
||||
)
|
||||
return payload
|
||||
finally:
|
||||
if created_engine:
|
||||
engine.dispose()
|
||||
@@ -18,10 +18,11 @@ from services.market_intel.candidate_queue_review_decision_approval import build
|
||||
from services.market_intel.candidate_queue_review_decision_transaction import build_candidate_queue_review_decision_transaction
|
||||
from services.market_intel.candidate_queue_review_decision_writer_cli import build_candidate_queue_review_decision_writer_cli_plan
|
||||
from services.market_intel.candidate_queue_review_decision_writer_preflight import build_candidate_queue_review_decision_writer_preflight
|
||||
from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import build_candidate_queue_review_decision_writer_postwrite_smoke
|
||||
|
||||
|
||||
BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database")
|
||||
PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status")
|
||||
PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status")
|
||||
|
||||
|
||||
def _run_review_preview_safe(payload, mode):
|
||||
@@ -121,6 +122,10 @@ def build_deployment_readiness_preview(
|
||||
writer_status=candidate_queue_review_decision_writer_status,
|
||||
transaction_preview=candidate_queue_review_decision_transaction,
|
||||
)
|
||||
candidate_queue_review_decision_writer_postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke(
|
||||
transaction_preview=candidate_queue_review_decision_transaction,
|
||||
execute_requested=False,
|
||||
)
|
||||
checks = {
|
||||
"schema_smoke_passed": bool(schema_smoke["passed"]),
|
||||
"feature_flags_default_safe": bool(
|
||||
@@ -363,6 +368,10 @@ def build_deployment_readiness_preview(
|
||||
candidate_queue_review_decision_writer_preflight,
|
||||
"candidate_queue_review_decision_writer_preflight_preview",
|
||||
),
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke_planned_safe": _run_review_preview_safe(
|
||||
candidate_queue_review_decision_writer_postwrite_smoke,
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke_planned",
|
||||
),
|
||||
"candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe(
|
||||
candidate_queue_review_decision_writer_status,
|
||||
"candidate_queue_review_decision_writer_cli_blocked",
|
||||
@@ -600,6 +609,7 @@ def build_deployment_readiness_preview(
|
||||
"candidate_queue_review_decision_approval": candidate_queue_review_decision_approval,
|
||||
"candidate_queue_review_decision_transaction": candidate_queue_review_decision_transaction,
|
||||
"candidate_queue_review_decision_writer_preflight": candidate_queue_review_decision_writer_preflight,
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke": candidate_queue_review_decision_writer_postwrite_smoke,
|
||||
"candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status,
|
||||
"match_review_plan": match_review_plan,
|
||||
"opportunity_plan": opportunity_plan,
|
||||
|
||||
@@ -1,3 +1,3 @@
|
||||
"""市場情報 rollout phase 單一來源。"""
|
||||
|
||||
MARKET_INTEL_PHASE = "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
MARKET_INTEL_PHASE = "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
|
||||
@@ -646,6 +646,9 @@
|
||||
<button class="market-intel-icon-button" type="button" title="檢查 queue review decision writer preflight" data-market-intel-sample-candidate-queue-review-decision-preflight>
|
||||
<i class="fas fa-database" aria-hidden="true"></i>
|
||||
</button>
|
||||
<button class="market-intel-icon-button" type="button" title="檢查 queue review decision writer post-write smoke" data-market-intel-sample-candidate-queue-review-decision-postwrite-smoke>
|
||||
<i class="fas fa-search" aria-hidden="true"></i>
|
||||
</button>
|
||||
<button class="market-intel-icon-button" type="button" title="檢查 queue review decision writer CLI gate" data-market-intel-sample-candidate-queue-review-decision-writer>
|
||||
<i class="fas fa-terminal" aria-hidden="true"></i>
|
||||
</button>
|
||||
@@ -992,6 +995,7 @@
|
||||
const sampleCandidateQueueReviewDecisionApproval = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-approval]') : null;
|
||||
const sampleCandidateQueueReviewDecisionTransaction = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-transaction]') : null;
|
||||
const sampleCandidateQueueReviewDecisionPreflight = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-preflight]') : null;
|
||||
const sampleCandidateQueueReviewDecisionPostwriteSmoke = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-postwrite-smoke]') : null;
|
||||
const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null;
|
||||
const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}";
|
||||
const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}";
|
||||
@@ -1013,6 +1017,7 @@
|
||||
const sampleCandidateQueueReviewDecisionApprovalEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_approval') }}";
|
||||
const sampleCandidateQueueReviewDecisionTransactionEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_transaction') }}";
|
||||
const sampleCandidateQueueReviewDecisionPreflightEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_preflight') }}";
|
||||
const sampleCandidateQueueReviewDecisionPostwriteSmokeEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_postwrite_smoke') }}";
|
||||
const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}";
|
||||
const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null;
|
||||
const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null;
|
||||
@@ -3738,6 +3743,117 @@
|
||||
}
|
||||
};
|
||||
|
||||
const renderCandidateQueueReviewDecisionPostwriteSmoke = data => {
|
||||
const blockers = (data.blocked_reasons || []).join(' / ');
|
||||
const rows = data.row_summaries || [];
|
||||
const mismatches = data.state_mismatches || [];
|
||||
sampleReviewMeta.innerHTML = [
|
||||
`mode=${data.mode || 'unknown'}`,
|
||||
`passed=${data.postwrite_smoke_passed ? 'yes' : 'no'}`,
|
||||
`expected=${data.expected_dedupe_key_count || 0}`,
|
||||
`found=${data.found_count || 0}`,
|
||||
`mismatch=${data.state_mismatch_count || 0}`
|
||||
].map(item => `<span class="market-intel-pill">${escapeHtml(item)}</span>`).join('');
|
||||
sampleReviewBody.innerHTML = `
|
||||
<div class="market-intel-empty mb-3">此卡只做 review_state writer post-write 只讀驗證;API/UI 不讀 token、不更新 review_state、不 commit、不掛 scheduler。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}</div>
|
||||
<div class="market-intel-deploy-grid">
|
||||
<div>
|
||||
<p class="market-intel-deploy-section-title">EXPECTED UPDATES</p>
|
||||
<div class="market-intel-check-list">${
|
||||
(data.expected_review_state_updates || []).map(item => `
|
||||
<div class="market-intel-check">
|
||||
<div>
|
||||
<strong>${escapeHtml(item.dedupe_key || 'unknown')}</strong>
|
||||
<small>${escapeHtml(item.expected_current_review_state || 'unknown')} -> ${escapeHtml(item.expected_review_state || 'none')}</small>
|
||||
</div>
|
||||
<span>${escapeHtml(item.parameter_payload_hash || 'preview')}</span>
|
||||
</div>
|
||||
`).join('') || '<div class="market-intel-empty">尚未提供 review_state update payload。</div>'
|
||||
}</div>
|
||||
</div>
|
||||
<div>
|
||||
<p class="market-intel-deploy-section-title">READ-ONLY RESULT</p>
|
||||
<div class="market-intel-check-list">
|
||||
${[
|
||||
['read_only_query', data.read_only_query_executed],
|
||||
['db_connection', data.database_connection_opened],
|
||||
['api_updates_review_state', data.api_updates_review_state],
|
||||
['review_state_update_executed', data.review_state_update_executed],
|
||||
['database_write', data.database_write_executed],
|
||||
['scheduler', data.scheduler_attached]
|
||||
].map(([key, value]) => `
|
||||
<div class="market-intel-check">
|
||||
<div><strong>${escapeHtml(key)}</strong></div>
|
||||
<span>${escapeHtml(String(value))}</span>
|
||||
</div>
|
||||
`).join('')}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<div class="market-intel-deploy-grid mt-3">
|
||||
<div>
|
||||
<p class="market-intel-deploy-section-title">ROWS</p>
|
||||
<div class="market-intel-check-list">${
|
||||
rows.map(row => `
|
||||
<div class="market-intel-check">
|
||||
<div>
|
||||
<strong>${escapeHtml(row.dedupe_key || 'unknown')}</strong>
|
||||
<small>${escapeHtml(row.review_state || 'unknown')}</small>
|
||||
</div>
|
||||
<span>${escapeHtml(row.updated_at || 'pending')}</span>
|
||||
</div>
|
||||
`).join('') || '<div class="market-intel-empty">尚未執行只讀查詢或查無 row。</div>'
|
||||
}</div>
|
||||
</div>
|
||||
<div>
|
||||
<p class="market-intel-deploy-section-title">MISMATCH</p>
|
||||
<div class="market-intel-check-list">${
|
||||
mismatches.map(item => `
|
||||
<div class="market-intel-check">
|
||||
<div>
|
||||
<strong>${escapeHtml(item.dedupe_key || 'unknown')}</strong>
|
||||
<small>${escapeHtml(item.expected_review_state || 'none')} / ${escapeHtml(item.actual_review_state || 'none')}</small>
|
||||
</div>
|
||||
<span>CHECK</span>
|
||||
</div>
|
||||
`).join('') || '<div class="market-intel-empty">目前沒有 state mismatch。</div>'
|
||||
}</div>
|
||||
</div>
|
||||
</div>
|
||||
`;
|
||||
};
|
||||
|
||||
const loadCandidateQueueReviewDecisionPostwriteSmoke = async () => {
|
||||
if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return;
|
||||
let parsed;
|
||||
try {
|
||||
parsed = JSON.parse(sampleReviewInput.value || '{}');
|
||||
} catch (error) {
|
||||
sampleReviewMeta.innerHTML = '<span class="market-intel-pill">json_error</span>';
|
||||
sampleReviewBody.innerHTML = `<div class="market-intel-empty">JSON 格式錯誤:${escapeHtml(error.message)}</div>`;
|
||||
return;
|
||||
}
|
||||
const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed };
|
||||
sampleReviewBody.innerHTML = '<div class="market-intel-empty">檢查 queue review decision writer post-write smoke 中...</div>';
|
||||
try {
|
||||
const response = await fetch(sampleCandidateQueueReviewDecisionPostwriteSmokeEndpoint, {
|
||||
method: 'POST',
|
||||
credentials: 'same-origin',
|
||||
headers: {
|
||||
'Content-Type': 'application/json',
|
||||
'X-CSRFToken': csrfToken
|
||||
},
|
||||
body: JSON.stringify(body)
|
||||
});
|
||||
const data = await response.json();
|
||||
if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`);
|
||||
renderCandidateQueueReviewDecisionPostwriteSmoke(data);
|
||||
} catch (error) {
|
||||
sampleReviewMeta.innerHTML = '<span class="market-intel-pill">error</span>';
|
||||
sampleReviewBody.innerHTML = `<div class="market-intel-empty">queue review decision writer post-write smoke 失敗:${escapeHtml(error.message)}</div>`;
|
||||
}
|
||||
};
|
||||
|
||||
const renderCandidateQueueReviewDecisionWriter = data => {
|
||||
const blockers = (data.blocked_reasons || []).join(' / ');
|
||||
const summary = data.statement_summary || {};
|
||||
@@ -5399,6 +5515,9 @@
|
||||
if (sampleCandidateQueueReviewDecisionPreflight) {
|
||||
sampleCandidateQueueReviewDecisionPreflight.addEventListener('click', loadCandidateQueueReviewDecisionPreflight);
|
||||
}
|
||||
if (sampleCandidateQueueReviewDecisionPostwriteSmoke) {
|
||||
sampleCandidateQueueReviewDecisionPostwriteSmoke.addEventListener('click', loadCandidateQueueReviewDecisionPostwriteSmoke);
|
||||
}
|
||||
if (sampleCandidateQueueReviewDecisionWriter) {
|
||||
sampleCandidateQueueReviewDecisionWriter.addEventListener('click', loadCandidateQueueReviewDecisionWriter);
|
||||
}
|
||||
|
||||
@@ -840,6 +840,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
|
||||
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_preflight"
|
||||
in template
|
||||
)
|
||||
assert (
|
||||
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
in template
|
||||
)
|
||||
assert (
|
||||
"data-market-intel-sample-candidate-queue-review-decision-writer"
|
||||
in template
|
||||
@@ -848,6 +852,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
|
||||
"data-market-intel-sample-candidate-queue-review-decision-preflight"
|
||||
in template
|
||||
)
|
||||
assert (
|
||||
"data-market-intel-sample-candidate-queue-review-decision-postwrite-smoke"
|
||||
in template
|
||||
)
|
||||
assert "X-CSRFToken" in template
|
||||
assert "market_intel.market_intel_scheduler_plan" in template
|
||||
assert "market_intel.market_intel_match_review_plan" in template
|
||||
@@ -884,7 +892,7 @@ def test_legacy_source_bridge_default_is_planned_only():
|
||||
bridge = MarketIntelService().build_legacy_source_bridge()
|
||||
|
||||
assert bridge["mode"] == "legacy_source_bridge_planned"
|
||||
assert bridge["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert bridge["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert bridge["execute_requested"] is False
|
||||
assert bridge["read_only_query_executed"] is False
|
||||
assert bridge["database_connection_opened"] is False
|
||||
@@ -1042,7 +1050,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
|
||||
contract = MarketIntelService().build_mcp_tool_contract()
|
||||
|
||||
assert contract["mode"] == "mcp_tool_contract_preview"
|
||||
assert contract["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert contract["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert contract["caller"] == "market_intel"
|
||||
assert contract["contract_ready"] is True
|
||||
assert contract["blocked_reasons"] == []
|
||||
@@ -1175,7 +1183,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "mcp_activation_runbook_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["deployment_actions_executed"] is False
|
||||
assert data["docker_command_executed"] is False
|
||||
assert data["ssh_command_executed"] is False
|
||||
@@ -1188,7 +1196,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
|
||||
gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
|
||||
|
||||
assert gate["mode"] == "mcp_fetch_gate_planned"
|
||||
assert gate["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert gate["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert gate["fetch_requested"] is True
|
||||
assert gate["manual_fetch_gate_open"] is False
|
||||
assert gate["network_request_allowed"] is False
|
||||
@@ -1258,7 +1266,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "mcp_fetch_gate_planned"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["fetch_requested"] is False
|
||||
assert data["network_request_allowed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -1270,7 +1278,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write():
|
||||
plan = MarketIntelService().build_manual_sample_plan()
|
||||
|
||||
assert plan["mode"] == "manual_sample_fetch_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_for_manual_sample_fetch"] is False
|
||||
assert plan["sample_fetch_executed"] is False
|
||||
assert plan["external_network_executed"] is False
|
||||
@@ -1318,7 +1326,7 @@ def test_manual_sample_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_fetch_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["sample_fetch_executed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
@@ -1329,7 +1337,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import():
|
||||
acceptance = MarketIntelService().build_manual_sample_acceptance()
|
||||
|
||||
assert acceptance["mode"] == "manual_sample_acceptance_preview"
|
||||
assert acceptance["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert acceptance["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert acceptance["contract_ready"] is True
|
||||
assert acceptance["sample_result_loaded"] is False
|
||||
assert acceptance["sample_result_accepted"] is False
|
||||
@@ -1371,7 +1379,7 @@ def test_manual_sample_acceptance_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_acceptance_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["sample_result_loaded"] is False
|
||||
assert data["candidate_import_allowed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -1383,7 +1391,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded():
|
||||
review = MarketIntelService().build_manual_sample_review()
|
||||
|
||||
assert review["mode"] == "manual_sample_review_preview"
|
||||
assert review["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert review["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert review["contract_ready"] is True
|
||||
assert review["sample_result_loaded"] is False
|
||||
assert review["sample_result_reviewed"] is False
|
||||
@@ -1494,7 +1502,7 @@ def test_manual_sample_review_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_review_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["sample_result_loaded"] is False
|
||||
assert data["sample_result_reviewed"] is False
|
||||
assert data["candidate_import_allowed"] is False
|
||||
@@ -1533,7 +1541,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist
|
||||
)
|
||||
|
||||
assert review["mode"] == "manual_sample_review_evaluation_preview"
|
||||
assert review["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert review["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert review["review_request_type"] == "operator_posted_json"
|
||||
assert review["payload_received"] is True
|
||||
assert review["payload_valid_json_object"] is True
|
||||
@@ -1595,7 +1603,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_review_evaluation_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["payload_received"] is True
|
||||
assert data["payload_valid_json_object"] is True
|
||||
assert data["payload_persisted"] is False
|
||||
@@ -1675,7 +1683,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers
|
||||
)
|
||||
|
||||
assert handoff["mode"] == "manual_sample_candidate_handoff_preview"
|
||||
assert handoff["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert handoff["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert handoff["payload_received"] is True
|
||||
assert handoff["payload_valid_json_object"] is True
|
||||
assert handoff["payload_persisted"] is False
|
||||
@@ -1739,7 +1747,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_handoff_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["payload_received"] is True
|
||||
assert data["handoff_ready"] is True
|
||||
assert data["candidate_handoff_created"] is True
|
||||
@@ -1798,7 +1806,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without
|
||||
)
|
||||
|
||||
assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview"
|
||||
assert queue_draft["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert queue_draft["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert queue_draft["payload_received"] is True
|
||||
assert queue_draft["payload_valid_json_object"] is True
|
||||
assert queue_draft["payload_persisted"] is False
|
||||
@@ -1872,7 +1880,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_queue_draft_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["payload_received"] is True
|
||||
assert data["handoff_ready"] is True
|
||||
assert data["queue_draft_ready"] is True
|
||||
@@ -1935,7 +1943,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro
|
||||
)
|
||||
|
||||
assert approval["mode"] == "manual_sample_candidate_queue_approval_preview"
|
||||
assert approval["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert approval["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert approval["payload_received"] is True
|
||||
assert approval["payload_valid_json_object"] is True
|
||||
assert approval["payload_persisted"] is False
|
||||
@@ -2013,7 +2021,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write(
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_queue_approval_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["payload_received"] is True
|
||||
assert data["approval_preview_created"] is True
|
||||
assert data["approval_request_created"] is False
|
||||
@@ -2076,7 +2084,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution():
|
||||
)
|
||||
|
||||
assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview"
|
||||
assert transaction["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert transaction["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert transaction["payload_received"] is True
|
||||
assert transaction["payload_valid_json_object"] is True
|
||||
assert transaction["payload_persisted"] is False
|
||||
@@ -2156,7 +2164,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_queue_transaction_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["payload_received"] is True
|
||||
assert data["transaction_preview_created"] is True
|
||||
assert data["transaction_ready"] is False
|
||||
@@ -3952,6 +3960,115 @@ def test_candidate_queue_review_decision_writer_preflight_is_payload_only():
|
||||
assert TEST_APPROVAL_TOKEN not in payload
|
||||
|
||||
|
||||
def test_candidate_queue_review_decision_writer_postwrite_smoke_is_read_only():
|
||||
from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import (
|
||||
build_candidate_queue_review_decision_writer_postwrite_smoke,
|
||||
)
|
||||
|
||||
transaction, _operator_evidence = _build_ready_review_decision_transaction()
|
||||
statement = transaction["statements"][0]
|
||||
dedupe_key = statement["lookup"]["dedupe_key"]
|
||||
expected_state = statement["next_review_state"]
|
||||
plan = build_candidate_queue_review_decision_writer_postwrite_smoke(
|
||||
transaction_preview=transaction,
|
||||
execute_requested=False,
|
||||
)
|
||||
engine = create_engine("sqlite:///:memory:")
|
||||
with engine.begin() as conn:
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
CREATE TABLE market_alert_review_queue (
|
||||
id INTEGER PRIMARY KEY,
|
||||
alert_candidate_id INTEGER,
|
||||
review_state TEXT,
|
||||
priority_lane TEXT,
|
||||
threshold_level TEXT,
|
||||
total_score REAL,
|
||||
evidence_bundle_id TEXT,
|
||||
dedupe_key TEXT UNIQUE,
|
||||
source_batch_id TEXT,
|
||||
reviewed_at TEXT,
|
||||
created_at TEXT,
|
||||
updated_at TEXT
|
||||
)
|
||||
"""
|
||||
)
|
||||
)
|
||||
conn.execute(
|
||||
text(
|
||||
"""
|
||||
INSERT INTO market_alert_review_queue (
|
||||
alert_candidate_id,
|
||||
review_state,
|
||||
priority_lane,
|
||||
threshold_level,
|
||||
total_score,
|
||||
evidence_bundle_id,
|
||||
dedupe_key,
|
||||
source_batch_id,
|
||||
reviewed_at,
|
||||
created_at,
|
||||
updated_at
|
||||
)
|
||||
VALUES (
|
||||
101,
|
||||
:review_state,
|
||||
'urgent',
|
||||
'high',
|
||||
91.5,
|
||||
'evidence-1',
|
||||
:dedupe_key,
|
||||
'sample-batch',
|
||||
'2026-05-19T12:00:00',
|
||||
'2026-05-19T11:00:00',
|
||||
'2026-05-19T12:00:00'
|
||||
)
|
||||
"""
|
||||
),
|
||||
{"review_state": expected_state, "dedupe_key": dedupe_key},
|
||||
)
|
||||
smoke = build_candidate_queue_review_decision_writer_postwrite_smoke(
|
||||
transaction_preview=transaction,
|
||||
execute_requested=True,
|
||||
engine=engine,
|
||||
database_type="sqlite",
|
||||
)
|
||||
payload = json.dumps(smoke, ensure_ascii=False, sort_keys=True)
|
||||
|
||||
assert plan["mode"] == (
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke_planned"
|
||||
)
|
||||
assert plan["read_only_query_executed"] is False
|
||||
assert plan["database_connection_opened"] is False
|
||||
assert plan["review_state_update_executed"] is False
|
||||
assert plan["api_updates_review_state"] is False
|
||||
assert plan["database_write_executed"] is False
|
||||
assert plan["database_commit_executed"] is False
|
||||
assert "review_decision_writer_postwrite_smoke_not_loaded" in plan[
|
||||
"blocked_reasons"
|
||||
]
|
||||
assert smoke["mode"] == (
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke_read_only"
|
||||
)
|
||||
assert smoke["read_only_query_executed"] is True
|
||||
assert smoke["database_connection_opened"] is True
|
||||
assert smoke["database_session_created"] is False
|
||||
assert smoke["explicit_transaction_opened"] is False
|
||||
assert smoke["transaction_committed"] is False
|
||||
assert smoke["database_write_executed"] is False
|
||||
assert smoke["database_commit_executed"] is False
|
||||
assert smoke["review_state_update_executed"] is False
|
||||
assert smoke["api_updates_review_state"] is False
|
||||
assert smoke["scheduler_attached"] is False
|
||||
assert smoke["postwrite_smoke_passed"] is True
|
||||
assert smoke["review_state_update_verified"] is True
|
||||
assert smoke["missing_count"] == 0
|
||||
assert smoke["state_mismatch_count"] == 0
|
||||
assert smoke["found_dedupe_keys"] == [dedupe_key]
|
||||
assert TEST_APPROVAL_TOKEN not in payload
|
||||
|
||||
|
||||
def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
|
||||
from routes.market_intel_routes import market_intel_bp
|
||||
|
||||
@@ -3994,7 +4111,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_preflight_planned"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["read_only_query_executed"] is False
|
||||
assert data["database_connection_opened"] is False
|
||||
@@ -4051,7 +4168,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_cli_blocked"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is True
|
||||
assert data["apply_real_write_requested"] is True
|
||||
assert data["approval_token_present"] is False
|
||||
@@ -4140,7 +4257,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write(
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["read_only_query_executed"] is False
|
||||
assert data["database_connection_opened"] is False
|
||||
@@ -4194,7 +4311,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write()
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_operator_drill_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["operator_drill_ready"] is True
|
||||
assert data["api_executes_cli"] is False
|
||||
assert data["api_reads_approval_token"] is False
|
||||
@@ -4250,7 +4367,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_run_package_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["package_ready"] is True
|
||||
assert data["package_artifact_created"] is False
|
||||
assert data["api_writes_file"] is False
|
||||
@@ -4316,7 +4433,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_run_readiness_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["ready_for_cli_operator_run"] is True
|
||||
assert data["ready_for_api_database_write"] is False
|
||||
assert data["api_executes_cli"] is False
|
||||
@@ -4618,7 +4735,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["receipt_passed"] is True
|
||||
assert data["ready_for_api_database_write"] is False
|
||||
assert data["ready_for_scheduler_attach"] is False
|
||||
@@ -4666,7 +4783,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_run_closeout_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["closeout_passed"] is True
|
||||
assert data["ready_for_next_manual_phase"] is True
|
||||
assert data["ready_for_api_database_write"] is False
|
||||
@@ -4715,7 +4832,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_review_handoff_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["handoff_ready"] is True
|
||||
assert data["ready_for_manual_queue_review"] is True
|
||||
assert data["ready_for_api_database_write"] is False
|
||||
@@ -4773,7 +4890,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write():
|
||||
assert get_response.status_code == 405
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_review_inventory_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["review_inventory_ready"] is False
|
||||
assert data["ready_for_human_decision_review"] is False
|
||||
@@ -4839,7 +4956,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write():
|
||||
assert get_response.status_code == 405
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_review_decision_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["decision_ready"] is False
|
||||
assert data["ready_for_human_decision_record"] is False
|
||||
assert data["ready_for_api_review_state_update"] is False
|
||||
@@ -4910,7 +5027,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ
|
||||
assert get_response.status_code == 405
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_review_decision_approval_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["approval_ready"] is False
|
||||
assert data["ready_for_review_state_transaction_preview"] is False
|
||||
assert data["ready_for_cli_decision_writer"] is False
|
||||
@@ -4986,7 +5103,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w
|
||||
assert get_response.status_code == 405
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_review_decision_transaction_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["transaction_preview_created"] is False
|
||||
assert data["transaction_ready"] is False
|
||||
assert data["ready_for_manual_shell_update_window"] is False
|
||||
@@ -5068,7 +5185,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no
|
||||
assert get_response.status_code == 405
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is True
|
||||
assert data["apply_real_write_requested"] is True
|
||||
assert data["approval_token_present"] is False
|
||||
@@ -5154,7 +5271,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and
|
||||
assert data["mode"] == (
|
||||
"candidate_queue_review_decision_writer_preflight_preview"
|
||||
)
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is True
|
||||
assert data["apply_real_write_requested"] is True
|
||||
assert data["read_only_query_executed"] is False
|
||||
@@ -5183,6 +5300,85 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and
|
||||
]
|
||||
|
||||
|
||||
def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_only_and_no_write():
|
||||
from routes.market_intel_routes import market_intel_bp
|
||||
from routes.market_intel_review_routes import market_intel_review_bp
|
||||
|
||||
fixture = _build_candidate_queue_writer_receipt_fixture(
|
||||
"sample-batch-review-decision-postwrite-smoke-route"
|
||||
)
|
||||
app = Flask(__name__)
|
||||
app.secret_key = "test-secret"
|
||||
app.register_blueprint(market_intel_bp)
|
||||
app.register_blueprint(market_intel_review_bp)
|
||||
client = app.test_client()
|
||||
with client.session_transaction() as session:
|
||||
session["logged_in"] = True
|
||||
|
||||
get_response = client.get(
|
||||
"/api/market_intel/manual_sample_review/"
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
)
|
||||
response = client.post(
|
||||
"/api/market_intel/manual_sample_review/"
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke",
|
||||
json={
|
||||
"sample_result": fixture["sample_result"],
|
||||
"operator_evidence": {
|
||||
**fixture["operator_evidence"],
|
||||
"closeout_artifact_path": "artifacts/market_intel/closeout.json",
|
||||
"operator_confirmed_queue_review_next": True,
|
||||
"operator_confirmed_no_scheduler_attach": True,
|
||||
"operator_confirmed_no_api_db_write": True,
|
||||
"operator_confirmed_inventory_read_only": True,
|
||||
"reviewer_id": "operator-a",
|
||||
"proposed_review_decision": "confirmed",
|
||||
"decision_notes": "manual review only",
|
||||
"operator_confirmed_manual_decision_only": True,
|
||||
"decision_approval_notes": "cli-only approval gate",
|
||||
"operator_confirmed_decision_payload_reviewed": True,
|
||||
"operator_confirmed_decision_apply_requires_cli": True,
|
||||
"operator_confirmed_review_state_update_is_not_api": True,
|
||||
"decision_transaction_notes": "shell-only transaction preview",
|
||||
"operator_confirmed_transaction_payload_reviewed": True,
|
||||
"operator_confirmed_cli_only_transaction": True,
|
||||
},
|
||||
"writer_output": fixture["writer_output"],
|
||||
"postwrite_smoke_result": fixture["postwrite_smoke_result"],
|
||||
},
|
||||
)
|
||||
data = response.get_json()
|
||||
|
||||
assert get_response.status_code == 405
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == (
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke_planned"
|
||||
)
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["read_only_query_executed"] is False
|
||||
assert data["database_connection_opened"] is False
|
||||
assert data["database_session_created"] is False
|
||||
assert data["explicit_transaction_opened"] is False
|
||||
assert data["transaction_opened"] is False
|
||||
assert data["transaction_committed"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
assert data["database_commit_executed"] is False
|
||||
assert data["review_state_update_executed"] is False
|
||||
assert data["api_updates_review_state"] is False
|
||||
assert data["scheduler_attached"] is False
|
||||
assert data["writes_executed"] is False
|
||||
assert data["would_write_database"] is False
|
||||
assert data["postwrite_smoke_passed"] is False
|
||||
assert data["review_state_update_verified"] is False
|
||||
assert "review_decision_writer_postwrite_smoke_not_loaded" in data[
|
||||
"blocked_reasons"
|
||||
]
|
||||
assert "do_not_update_review_state_from_postwrite_smoke" in data[
|
||||
"safe_boundaries"
|
||||
]
|
||||
|
||||
|
||||
def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
|
||||
from routes.market_intel_routes import market_intel_bp
|
||||
|
||||
@@ -5211,7 +5407,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["receipt_passed"] is True
|
||||
assert data["ready_for_next_manual_review"] is True
|
||||
assert data["ready_for_api_database_write"] is False
|
||||
@@ -5236,7 +5432,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
|
||||
plan = MarketIntelService().build_scheduler_plan()
|
||||
|
||||
assert plan["mode"] == "scheduler_attach_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_to_attach_scheduler"] is False
|
||||
assert plan["scheduler_attached"] is False
|
||||
assert plan["scheduler_registration_executed"] is False
|
||||
@@ -5274,7 +5470,7 @@ def test_scheduler_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "scheduler_attach_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["scheduler_registration_executed"] is False
|
||||
assert data["crawler_job_started"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -5285,7 +5481,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
|
||||
plan = MarketIntelService().build_match_review_plan()
|
||||
|
||||
assert plan["mode"] == "match_review_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_for_review_queue"] is False
|
||||
assert plan["review_queue_created"] is False
|
||||
assert plan["auto_match_executed"] is False
|
||||
@@ -5321,7 +5517,7 @@ def test_match_review_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "match_review_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["review_queue_created"] is False
|
||||
assert data["auto_confirm_executed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -5332,7 +5528,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
|
||||
plan = MarketIntelService().build_opportunity_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_for_opportunity_queue"] is False
|
||||
assert plan["opportunity_queue_created"] is False
|
||||
assert plan["threat_alert_dispatched"] is False
|
||||
@@ -5373,7 +5569,7 @@ def test_opportunity_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["opportunity_queue_created"] is False
|
||||
assert data["threat_alert_dispatched"] is False
|
||||
assert data["ai_summary_generated"] is False
|
||||
@@ -5384,7 +5580,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
|
||||
plan = MarketIntelService().build_opportunity_scoring_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_scoring_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_for_scoring_job"] is False
|
||||
assert plan["scoring_job_created"] is False
|
||||
assert plan["score_calculation_executed"] is False
|
||||
@@ -5432,7 +5628,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_scoring_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["scoring_job_created"] is False
|
||||
assert data["score_calculation_executed"] is False
|
||||
assert data["sample_scores_generated"] is False
|
||||
@@ -5444,7 +5640,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
|
||||
plan = MarketIntelService().build_opportunity_evidence_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_evidence_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_for_evidence_bundle"] is False
|
||||
assert plan["evidence_bundle_created"] is False
|
||||
assert plan["evidence_query_executed"] is False
|
||||
@@ -5490,7 +5686,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_evidence_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["evidence_bundle_created"] is False
|
||||
assert data["evidence_query_executed"] is False
|
||||
assert data["sample_evidence_generated"] is False
|
||||
@@ -5503,7 +5699,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
|
||||
plan = MarketIntelService().build_opportunity_alert_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_alert_plan_preview"
|
||||
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert plan["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert plan["ready_for_alert_candidates"] is False
|
||||
assert plan["alert_candidate_created"] is False
|
||||
assert plan["alert_queue_created"] is False
|
||||
@@ -5588,7 +5784,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_alert_plan_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["alert_candidate_created"] is False
|
||||
assert data["alert_queue_created"] is False
|
||||
assert data["review_queue_created"] is False
|
||||
@@ -5666,7 +5862,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "mcp_external_deploy_preflight_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["deployment_actions_executed"] is False
|
||||
assert data["docker_command_executed"] is False
|
||||
assert data["ssh_command_executed"] is False
|
||||
@@ -5681,7 +5877,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
|
||||
readiness = MarketIntelService().build_mcp_readiness()
|
||||
|
||||
assert readiness["mode"] == "mcp_readiness_planned"
|
||||
assert readiness["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert readiness["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert readiness["execute_requested"] is False
|
||||
assert readiness["router_enabled"] is False
|
||||
assert readiness["external_mcp_complete"] is False
|
||||
@@ -6133,6 +6329,12 @@ def test_deployment_readiness_reports_app_only_release_gate():
|
||||
]
|
||||
is True
|
||||
)
|
||||
assert (
|
||||
readiness["checks"][
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke_planned_safe"
|
||||
]
|
||||
is True
|
||||
)
|
||||
assert (
|
||||
readiness["checks"][
|
||||
"candidate_queue_review_decision_writer_cli_status_safe"
|
||||
@@ -6232,6 +6434,11 @@ def test_deployment_readiness_reports_app_only_release_gate():
|
||||
"candidate_queue_review_decision_writer_preflight"
|
||||
in readiness["production_smoke_targets"]
|
||||
)
|
||||
assert (
|
||||
"/api/market_intel/manual_sample_review/"
|
||||
"candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
in readiness["production_smoke_targets"]
|
||||
)
|
||||
assert (
|
||||
"/api/market_intel/manual_sample_review/"
|
||||
"candidate_queue_review_decision_writer_status"
|
||||
@@ -7075,6 +7282,52 @@ def test_deployment_readiness_reports_app_only_release_gate():
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"]["mode"]
|
||||
== "candidate_queue_review_decision_writer_postwrite_smoke_planned"
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"read_only_query_executed"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"database_connection_opened"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"database_write_executed"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"database_commit_executed"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"review_state_update_executed"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"api_updates_review_state"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_postwrite_smoke"][
|
||||
"scheduler_attached"
|
||||
]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_review_decision_writer_status"]["mode"]
|
||||
== "candidate_queue_review_decision_writer_cli_blocked"
|
||||
@@ -7225,7 +7478,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only():
|
||||
drill = MarketIntelService().build_migration_apply_drill()
|
||||
|
||||
assert drill["mode"] == "migration_apply_drill_preview"
|
||||
assert drill["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert drill["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert drill["execute_requested"] is False
|
||||
assert drill["schema_state"] == "planned_no_db_probe"
|
||||
assert drill["drill_ready_for_operator_review"] is True
|
||||
@@ -7340,7 +7593,7 @@ def test_migration_apply_drill_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "migration_apply_drill_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["migration_executed"] is False
|
||||
assert data["rollback_executed"] is False
|
||||
@@ -7352,7 +7605,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic():
|
||||
review = MarketIntelService().build_migration_catalog_review()
|
||||
|
||||
assert review["mode"] == "migration_catalog_review_preview"
|
||||
assert review["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert review["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert review["execute_requested"] is False
|
||||
assert review["catalog_state"] == "planned_no_probe"
|
||||
assert review["seed_state"] == "planned_no_probe"
|
||||
@@ -7467,7 +7720,7 @@ def test_migration_catalog_review_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "migration_catalog_review_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["catalog_state"] == "planned_no_probe"
|
||||
assert data["migration_executed"] is False
|
||||
@@ -7480,7 +7733,7 @@ def test_migration_live_smoke_planned_is_preview_only():
|
||||
smoke = MarketIntelService().build_migration_live_smoke()
|
||||
|
||||
assert smoke["mode"] == "migration_live_smoke_preview"
|
||||
assert smoke["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert smoke["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert smoke["execute_requested"] is False
|
||||
assert smoke["smoke_result"] == "planned_no_execution"
|
||||
assert smoke["live_smoke_passed"] is False
|
||||
@@ -7542,7 +7795,7 @@ def test_migration_live_smoke_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "migration_live_smoke_preview"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["smoke_result"] == "planned_no_execution"
|
||||
assert data["migration_executed"] is False
|
||||
@@ -7555,7 +7808,7 @@ def test_live_db_inventory_planned_is_preview_only():
|
||||
inventory = MarketIntelService().build_live_db_inventory()
|
||||
|
||||
assert inventory["mode"] == "live_db_inventory_planned"
|
||||
assert inventory["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert inventory["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert inventory["execute_requested"] is False
|
||||
assert inventory["read_only_query_executed"] is False
|
||||
assert inventory["database_connection_opened"] is False
|
||||
@@ -7699,7 +7952,7 @@ def test_live_db_inventory_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "live_db_inventory_planned"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["read_only_query_executed"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
@@ -7926,7 +8179,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path):
|
||||
|
||||
assert result.returncode == 0
|
||||
assert data["mode"] == "candidate_queue_writer_cli_blocked"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["apply_real_write_requested"] is False
|
||||
assert data["writes_executed"] is False
|
||||
@@ -7955,7 +8208,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en
|
||||
|
||||
assert result.returncode == 0
|
||||
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
|
||||
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
|
||||
assert data["phase"] == "phase_71_candidate_queue_review_decision_writer_postwrite_smoke"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["apply_real_write_requested"] is False
|
||||
assert data["approval_token_present"] is False
|
||||
|
||||
Reference in New Issue
Block a user