diff --git a/config.py b/config.py index 25d6b38..af367e4 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.193" +SYSTEM_VERSION = "V10.194" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 70be3ae..d62ec05 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -160,6 +160,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 +- 2026-05-18 追加 opportunity scoring plan preview:`services.market_intel.opportunity_scoring` 與 `/api/market_intel/opportunity_scoring_plan` 定義價差、折扣深度、比對可信度、活動急迫性與資料新鮮度五個 scoring dimensions、分級門檻、evidence tables 與人工升級順序。此階段不計分、不產生 sample scores、不建立 scoring job、不寫 DB、不派送 Telegram、不產生 AI 摘要。 ### Phase 4:Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 4ac87be..d71ac05 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,7 +19,7 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 35 opportunity plan preview | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 36 opportunity scoring plan preview | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index a01e0cd..42bddf4 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -169,6 +169,12 @@ def market_intel_opportunity_plan(): return jsonify(_service().build_opportunity_plan()) +@market_intel_bp.route("/api/market_intel/opportunity_scoring_plan") +@login_required +def market_intel_opportunity_scoring_plan(): + return jsonify(_service().build_opportunity_scoring_plan()) + + @market_intel_bp.route("/api/market_intel/adapters") @login_required def market_intel_adapters(): diff --git a/services/market_intel/opportunity_scoring.py b/services/market_intel/opportunity_scoring.py new file mode 100644 index 0000000..1299880 --- /dev/null +++ b/services/market_intel/opportunity_scoring.py @@ -0,0 +1,214 @@ +"""市場情報機會與威脅分數模型 preview。 + +只定義未來 scoring job 的欄位、權重、門檻與 evidence 要求;不查 DB、 +不建立 queue、不派送 Telegram、不產生 AI 摘要。 +""" + + +SCORING_DIMENSIONS = ( + { + "key": "price_gap_pct", + "label": "競品活動價差百分比", + "weight": 35, + "evidence": [ + "confirmed_market_product_match", + "market_product_price_history.price", + "momo_reference_price", + ], + "calculation": "max(0, momo_reference_price - market_price) / momo_reference_price", + }, + { + "key": "discount_depth", + "label": "活動折扣深度", + "weight": 20, + "evidence": [ + "market_campaign_products.original_price", + "market_campaign_products.price", + "market_campaign_products.discount_rate", + ], + "calculation": "normalized_discount_rate", + }, + { + "key": "match_confidence", + "label": "商品比對可信度", + "weight": 20, + "evidence": [ + "market_product_matches.match_score", + "market_product_matches.match_status", + "market_product_matches.match_reason_json", + ], + "calculation": "confirmed=1.0, needs_review=score, rejected=0", + }, + { + "key": "campaign_urgency", + "label": "活動時間急迫性", + "weight": 15, + "evidence": [ + "market_campaigns.end_at", + "market_campaigns.status", + "market_campaign_snapshots.crawled_at", + ], + "calculation": "higher_when_active_and_ending_within_72h", + }, + { + "key": "data_freshness", + "label": "資料新鮮度", + "weight": 10, + "evidence": [ + "market_product_price_history.crawled_at", + "market_crawler_runs.finished_at", + ], + "calculation": "higher_when_snapshot_age_under_24h", + }, +) + +SEVERITY_THRESHOLDS = ( + { + "level": "critical", + "minimum_score": 85, + "action": "只建立人工審核項;必須有 confirmed match 與最新價格 evidence。", + }, + { + "level": "high", + "minimum_score": 70, + "action": "排入威脅審核清單;不得自動調價或直接推播。", + }, + { + "level": "medium", + "minimum_score": 50, + "action": "排入日報候選;需人工確認後才可進 AI 摘要。", + }, + { + "level": "watch", + "minimum_score": 30, + "action": "只保留觀察訊號,不進即時告警。", + }, +) + +REQUIRED_EVIDENCE_TABLES = ( + "market_campaigns", + "market_campaign_products", + "market_product_price_history", + "market_product_matches", + "market_crawler_runs", +) + + +def _schema_tables(schema_smoke): + expected_tables = schema_smoke.get("expected_tables") or [] + if expected_tables: + return set(expected_tables) + smoke = schema_smoke.get("schema_smoke") or schema_smoke + return { + item.get("table") + for item in smoke.get("tables", []) + if item.get("table") + } + + +def build_opportunity_scoring_plan_preview( + *, + runtime_status, + opportunity_plan, + match_review_plan, + scheduler_plan, + schema_smoke, + mcp_fetch_gate, +): + """建立機會與威脅分數模型 preview;不執行任何計算或寫入。""" + available_tables = _schema_tables(schema_smoke) + required_tables_present = set(REQUIRED_EVIDENCE_TABLES) <= available_tables + dimensions = list(SCORING_DIMENSIONS) + total_weight = sum(item["weight"] for item in dimensions) + opportunity_preview_safe = ( + opportunity_plan.get("mode") == "opportunity_plan_preview" + and not opportunity_plan.get("opportunity_queue_created") + and not opportunity_plan.get("threat_alert_dispatched") + and not opportunity_plan.get("database_write_executed") + ) + match_review_preview_safe = ( + match_review_plan.get("mode") == "match_review_plan_preview" + and not match_review_plan.get("auto_confirm_executed") + and not match_review_plan.get("database_write_executed") + ) + scheduler_preview_safe = ( + scheduler_plan.get("mode") == "scheduler_attach_plan_preview" + and not scheduler_plan.get("scheduler_registration_executed") + and not scheduler_plan.get("crawler_job_started") + ) + gate_checks = { + "opportunity_plan_preview_safe": opportunity_preview_safe, + "opportunity_rules_available": bool(opportunity_plan.get("rule_count")), + "opportunity_queue_ready": bool( + opportunity_plan.get("ready_for_opportunity_queue") + ), + "match_review_preview_safe": match_review_preview_safe, + "confirmed_match_source_ready": bool( + match_review_plan.get("ready_for_review_queue") + ), + "schema_smoke_passed": bool( + (schema_smoke.get("schema_smoke") or schema_smoke).get("passed") + ), + "required_evidence_tables_declared": required_tables_present, + "mcp_fetch_gate_closed_for_preview": not bool( + mcp_fetch_gate.get("network_request_allowed") + ), + "scheduler_plan_preview_safe": scheduler_preview_safe, + "database_write_still_blocked": not bool( + runtime_status.database_write_allowed + ), + "manual_operator_approval": False, + } + blocked_reasons = [ + key for key, passed in gate_checks.items() + if not passed + ] + + return { + "mode": "opportunity_scoring_plan_preview", + "ready_for_scoring_job": False, + "scoring_job_created": False, + "score_calculation_executed": False, + "sample_scores_generated": False, + "opportunity_queue_created": False, + "review_queue_created": False, + "threat_alert_dispatched": False, + "telegram_dispatched": False, + "ai_summary_generated": False, + "database_session_created": False, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "dimension_count": len(dimensions), + "total_weight": total_weight, + "dimensions": dimensions, + "thresholds": list(SEVERITY_THRESHOLDS), + "required_evidence_tables": list(REQUIRED_EVIDENCE_TABLES), + "gate_checks": gate_checks, + "blocked_reasons": blocked_reasons, + "formula": "sum(normalized_dimension_score * weight) / 100", + "promotion_policy": { + "critical": "只可進人工審核;人工確認後才可生成 Telegram 候選。", + "high": "只可進審核清單;不得直接觸發價格調整。", + "medium": "只可進日報候選;AI 摘要必須附 evidence id。", + "watch": "只做趨勢觀察,不進告警。", + }, + "operator_sequence": [ + "確認 market_* migration 與 seed rows 已完成", + "確認商品比對 queue 已有 confirmed / needs_review evidence", + "用最新 price history 與 campaign snapshot 計算 dimension scores", + "依 thresholds 建立人工審核候選,不直接推播或調價", + "人工批准後才允許 AI 摘要或 Telegram 候選進入下一階段", + ], + "safe_boundaries": [ + "do_not_score_without_confirmed_or_reviewed_match", + "do_not_generate_sample_scores_from_placeholder_data", + "do_not_write_scoring_results_from_preview", + "do_not_dispatch_alerts_from_scoring_preview", + "do_not_generate_ai_summary_from_scoring_preview", + "do_not_auto_adjust_price", + ], + } diff --git a/services/market_intel/service.py b/services/market_intel/service.py index ffeab8b..0f07ea6 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -28,6 +28,9 @@ from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview from services.market_intel.mcp_readiness import build_mcp_readiness_plan from services.market_intel.migration_blueprint import build_migration_blueprint from services.market_intel.opportunity_plan import build_opportunity_plan_preview +from services.market_intel.opportunity_scoring import ( + build_opportunity_scoring_plan_preview, +) from services.market_intel.platform_seed import build_platform_seed_rows from services.market_intel.platform_seed_db_diff import build_platform_seed_db_diff_plan from services.market_intel.scheduler_plan import build_scheduler_attach_plan @@ -71,7 +74,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務,先集中 feature gate 與安全狀態。""" - phase = "phase_35_opportunity_plan_preview" + phase = "phase_36_opportunity_scoring_plan_preview" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( @@ -405,6 +408,20 @@ class MarketIntelService: plan["phase"] = self.phase return plan + def build_opportunity_scoring_plan(self): + """回報機會與威脅分數模型計畫;不計分、不寫入。""" + schema_smoke = self.build_schema_smoke() + plan = build_opportunity_scoring_plan_preview( + runtime_status=self.get_runtime_status(), + opportunity_plan=self.build_opportunity_plan(), + match_review_plan=self.build_match_review_plan(), + scheduler_plan=self.build_scheduler_plan(), + schema_smoke=schema_smoke, + mcp_fetch_gate=self.build_mcp_fetch_gate(), + ) + plan["phase"] = self.phase + return plan + def build_platform_seed_writer_plan(self, platform_code="all"): """建立 platform seed writer dry-run plan,不建立 DB session。""" seed_plan = self.build_platform_seed_plan(platform_code=platform_code) @@ -487,6 +504,7 @@ class MarketIntelService: scheduler_plan = self.build_scheduler_plan() match_review_plan = self.build_match_review_plan() opportunity_plan = self.build_opportunity_plan() + opportunity_scoring_plan = self.build_opportunity_scoring_plan() checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -549,6 +567,13 @@ class MarketIntelService: and not opportunity_plan["threat_alert_dispatched"] and not opportunity_plan["database_write_executed"] ), + "opportunity_scoring_plan_preview_safe": bool( + opportunity_scoring_plan["mode"] + == "opportunity_scoring_plan_preview" + and not opportunity_scoring_plan["scoring_job_created"] + and not opportunity_scoring_plan["score_calculation_executed"] + and not opportunity_scoring_plan["database_write_executed"] + ), } ready_for_production_deploy = all(checks.values()) blocked_reasons = [ @@ -680,6 +705,7 @@ class MarketIntelService: "/api/market_intel/scheduler_plan", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", + "/api/market_intel/opportunity_scoring_plan", ], "status": status.to_dict(), "schema_smoke": schema_smoke, @@ -702,4 +728,5 @@ class MarketIntelService: "scheduler_plan": scheduler_plan, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, + "opportunity_scoring_plan": opportunity_scoring_plan, } diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index ec23034..0b5f8e6 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -540,6 +540,24 @@ +
+
+
+

OPPORTUNITY / SCORING MODEL

+

機會威脅分數模型

+
+ +
+
+ loading +
+
+
讀取機會威脅分數模型中...
+
+
+
@@ -612,10 +630,11 @@ const schedulerRoot = document.querySelector('[data-market-intel-scheduler]'); const matchReviewRoot = document.querySelector('[data-market-intel-match-review]'); const opportunityRoot = document.querySelector('[data-market-intel-opportunity]'); + const opportunityScoringRoot = document.querySelector('[data-market-intel-opportunity-scoring]'); const migrationRoot = document.querySelector('[data-market-intel-migration]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !migrationRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !migrationRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -669,6 +688,10 @@ const opportunityBody = opportunityRoot ? opportunityRoot.querySelector('[data-market-intel-opportunity-body]') : null; const opportunityRefresh = opportunityRoot ? opportunityRoot.querySelector('[data-market-intel-opportunity-refresh]') : null; const opportunityEndpoint = "{{ url_for('market_intel.market_intel_opportunity_plan') }}"; + const opportunityScoringMeta = opportunityScoringRoot ? opportunityScoringRoot.querySelector('[data-market-intel-opportunity-scoring-meta]') : null; + const opportunityScoringBody = opportunityScoringRoot ? opportunityScoringRoot.querySelector('[data-market-intel-opportunity-scoring-body]') : null; + const opportunityScoringRefresh = opportunityScoringRoot ? opportunityScoringRoot.querySelector('[data-market-intel-opportunity-scoring-refresh]') : null; + const opportunityScoringEndpoint = "{{ url_for('market_intel.market_intel_opportunity_scoring_plan') }}"; const migrationMeta = migrationRoot ? migrationRoot.querySelector('[data-market-intel-migration-meta]') : null; const migrationBody = migrationRoot ? migrationRoot.querySelector('[data-market-intel-migration-body]') : null; const migrationRefresh = migrationRoot ? migrationRoot.querySelector('[data-market-intel-migration-refresh]') : null; @@ -1674,6 +1697,124 @@ } }; + const renderOpportunityScoringMeta = data => { + opportunityScoringMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `ready=${data.ready_for_scoring_job ? 'yes' : 'no'}`, + `dimensions=${data.dimension_count || 0}`, + `weight=${data.total_weight || 0}`, + `score=${data.score_calculation_executed ? 'executed' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderOpportunityScoringBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const checks = Object.entries(data.gate_checks || {}); + const dimensions = data.dimensions || []; + const thresholds = data.thresholds || []; + const evidenceTables = data.required_evidence_tables || []; + const sequence = data.operator_sequence || []; + const renderCheck = ([name, passed]) => ` +
+
+ ${escapeHtml(name)} +
+ ${passed ? 'PASS' : 'BLOCK'} +
+ `; + const renderDimension = item => ` +
+ ${escapeHtml(item.key)} / ${escapeHtml(item.weight)}% + ${escapeHtml(item.label)} + ${escapeHtml((item.evidence || []).join(' + '))} + ${escapeHtml(item.calculation)} +
+ `; + opportunityScoringBody.innerHTML = ` +
目前只定義機會與威脅分數模型;不計分、不建立 queue、不派送 Telegram、不產生 AI 摘要、不寫 DB。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

SCORING GATES

+
${ + checks.length + ? checks.map(renderCheck).join('') + : '
尚未提供分數 gate。
' + }
+
+
+

DIMENSIONS

+
${ + dimensions.length + ? dimensions.map(renderDimension).join('') + : '
尚未提供分數欄位。
' + }
+
+
+

THRESHOLDS

+
${ + thresholds.length + ? thresholds.map(item => ` +
+
+ ${escapeHtml(item.level)} + ${escapeHtml(item.action)} +
+ ${escapeHtml(item.minimum_score)}+ +
+ `).join('') + : '
尚未提供門檻。
' + }
+
+
+

EVIDENCE TABLES

+
${ + evidenceTables.length + ? evidenceTables.map(item => ` +
+
+ ${escapeHtml(item)} +
+ REQUIRED +
+ `).join('') + : '
尚未提供 evidence tables。
' + }
+
+
+

OPERATOR SEQUENCE

+
${ + sequence.length + ? sequence.map((item, index) => ` +
+
+ ${escapeHtml(`step_${index + 1}`)} + ${escapeHtml(item)} +
+ REQUIRED +
+ `).join('') + : '
尚未提供操作順序。
' + }
+
+
+ `; + }; + + const loadOpportunityScoring = async () => { + if (!opportunityScoringMeta || !opportunityScoringBody) return; + opportunityScoringBody.innerHTML = '
讀取機會威脅分數模型中...
'; + try { + const response = await fetch(opportunityScoringEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderOpportunityScoringMeta(data); + renderOpportunityScoringBody(data); + } catch (error) { + opportunityScoringMeta.innerHTML = 'error'; + opportunityScoringBody.innerHTML = `
機會威脅分數模型讀取失敗:${escapeHtml(error.message)}
`; + } + }; + const renderMigrationMeta = data => { const seedWriter = data.command_plan && data.command_plan.seed_writer_command ? data.command_plan.seed_writer_command @@ -1947,6 +2088,9 @@ if (opportunityRefresh) { opportunityRefresh.addEventListener('click', loadOpportunity); } + if (opportunityScoringRefresh) { + opportunityScoringRefresh.addEventListener('click', loadOpportunityScoring); + } if (migrationRefresh) { migrationRefresh.addEventListener('click', loadMigration); } @@ -1969,6 +2113,7 @@ loadScheduler(); loadMatchReview(); loadOpportunity(); + loadOpportunityScoring(); loadMigration(); loadApproval(); loadDeploy(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 5c26ba5..60f0820 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -458,6 +458,12 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-opportunity-rules" in template assert "data-market-intel-opportunity-severity" in template assert "data-market-intel-opportunity-sequence" in template + assert "data-market-intel-opportunity-scoring" in template + assert "data-market-intel-opportunity-scoring-checks" in template + assert "data-market-intel-opportunity-scoring-dimensions" in template + assert "data-market-intel-opportunity-scoring-thresholds" in template + assert "data-market-intel-opportunity-scoring-evidence" in template + assert "data-market-intel-opportunity-scoring-sequence" in template assert "data-market-intel-migration" in template assert "data-market-intel-migration-tables" in template assert "data-market-intel-approval" in template @@ -478,6 +484,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template assert "market_intel.market_intel_opportunity_plan" in template + assert "market_intel.market_intel_opportunity_scoring_plan" in template assert "market_intel.market_intel_migration_blueprint" in template assert "market_intel.market_intel_write_approval_runbook" in template assert "market_intel.market_intel_deployment_readiness" in template @@ -503,7 +510,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_35_opportunity_plan_preview" + assert bridge["phase"] == "phase_36_opportunity_scoring_plan_preview" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -661,7 +668,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_35_opportunity_plan_preview" + assert contract["phase"] == "phase_36_opportunity_scoring_plan_preview" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -794,7 +801,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_35_opportunity_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -807,7 +814,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_35_opportunity_plan_preview" + assert gate["phase"] == "phase_36_opportunity_scoring_plan_preview" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -877,7 +884,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_35_opportunity_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -889,7 +896,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_35_opportunity_plan_preview" + assert plan["phase"] == "phase_36_opportunity_scoring_plan_preview" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -927,7 +934,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_35_opportunity_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -938,7 +945,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_35_opportunity_plan_preview" + assert plan["phase"] == "phase_36_opportunity_scoring_plan_preview" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -974,7 +981,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_35_opportunity_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -985,7 +992,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_35_opportunity_plan_preview" + assert plan["phase"] == "phase_36_opportunity_scoring_plan_preview" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -1026,13 +1033,73 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_35_opportunity_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False assert data["database_write_executed"] is False +def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): + plan = MarketIntelService().build_opportunity_scoring_plan() + + assert plan["mode"] == "opportunity_scoring_plan_preview" + assert plan["phase"] == "phase_36_opportunity_scoring_plan_preview" + assert plan["ready_for_scoring_job"] is False + assert plan["scoring_job_created"] is False + assert plan["score_calculation_executed"] is False + assert plan["sample_scores_generated"] is False + assert plan["opportunity_queue_created"] is False + assert plan["review_queue_created"] is False + assert plan["threat_alert_dispatched"] is False + assert plan["telegram_dispatched"] is False + assert plan["ai_summary_generated"] is False + assert plan["database_session_created"] is False + assert plan["database_write_executed"] is False + assert plan["database_commit_executed"] is False + assert plan["external_network_executed"] is False + assert plan["scheduler_attached"] is False + assert plan["writes_executed"] is False + assert plan["would_write_database"] is False + assert plan["dimension_count"] == 5 + assert plan["total_weight"] == 100 + assert {item["key"] for item in plan["dimensions"]} == { + "price_gap_pct", + "discount_depth", + "match_confidence", + "campaign_urgency", + "data_freshness", + } + assert "opportunity_queue_ready" in plan["blocked_reasons"] + assert "confirmed_match_source_ready" in plan["blocked_reasons"] + assert "manual_operator_approval" in plan["blocked_reasons"] + assert "do_not_write_scoring_results_from_preview" in plan["safe_boundaries"] + assert "do_not_auto_adjust_price" in plan["safe_boundaries"] + + +def test_opportunity_scoring_plan_route_is_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.get("/api/market_intel/opportunity_scoring_plan") + data = response.get_json() + + assert response.status_code == 200 + assert data["mode"] == "opportunity_scoring_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" + assert data["scoring_job_created"] is False + assert data["score_calculation_executed"] is False + assert data["sample_scores_generated"] is False + assert data["database_write_executed"] is False + assert data["external_network_executed"] is False + + def test_mcp_deploy_preflight_blocks_without_required_env(): preflight = build_mcp_deploy_preflight_plan(env={}) @@ -1096,7 +1163,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_35_opportunity_plan_preview" + assert data["phase"] == "phase_36_opportunity_scoring_plan_preview" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1111,7 +1178,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_35_opportunity_plan_preview" + assert readiness["phase"] == "phase_36_opportunity_scoring_plan_preview" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -1501,6 +1568,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["match_review_plan_preview_safe"] is True assert readiness["checks"]["opportunity_plan_preview_safe"] is True + assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True assert readiness["checks"]["writer_plan_dry_run_only"] is True assert readiness["writer_plan_summary"]["writes_executed"] is False assert "readiness_checks_not_all_passed" not in readiness["blocked_reasons"] @@ -1524,6 +1592,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/match_review_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/opportunity_plan" in readiness["production_smoke_targets"] + assert "/api/market_intel/opportunity_scoring_plan" in readiness["production_smoke_targets"] assert readiness["write_approval_runbook"]["ready_for_real_write"] is False assert readiness["write_approval_runbook"]["writes_executed"] is False assert readiness["migration_blueprint"]["migration_executed"] is False @@ -1551,6 +1620,9 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["opportunity_plan"]["opportunity_queue_created"] is False assert readiness["opportunity_plan"]["threat_alert_dispatched"] is False assert readiness["opportunity_plan"]["database_write_executed"] is False + assert readiness["opportunity_scoring_plan"]["scoring_job_created"] is False + assert readiness["opportunity_scoring_plan"]["score_calculation_executed"] is False + assert readiness["opportunity_scoring_plan"]["database_write_executed"] is False def test_write_approval_runbook_is_read_only_and_blocks_real_write():