From e217865cccfd76a9665965ae009a3e36fe1d63a5 Mon Sep 17 00:00:00 2001 From: OoO Date: Tue, 19 May 2026 10:11:14 +0800 Subject: [PATCH] =?UTF-8?q?=E6=96=B0=E5=A2=9E=E5=B8=82=E5=A0=B4=E6=83=85?= =?UTF-8?q?=E5=A0=B1=E4=BD=87=E5=88=97=E5=AF=AB=E5=85=A5=E5=BE=8C=20smoke?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TODO_NEXT_STEPS.txt | 3 +- config.py | 2 +- ...s-platform-market-campaign-intelligence.md | 1 + routes/README.md | 2 +- routes/market_intel_routes.py | 34 ++ .../candidate_queue_writer_postwrite_smoke.py | 203 ++++++++++ services/market_intel/deployment_readiness.py | 22 ++ services/market_intel/service.py | 2 +- templates/market_intel/disabled.html | 69 ++++ tests/test_market_intel_skeleton.py | 352 +++++++++++++++--- 10 files changed, 640 insertions(+), 50 deletions(-) create mode 100644 services/market_intel/candidate_queue_writer_postwrite_smoke.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 2cecec4..5e123a6 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -120,6 +120,7 @@ - Phase 56 candidate queue writer preflight：新增 `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight` POST 與 `services/market_intel/candidate_queue_writer_preflight.py`，檢查 transaction payload key 到 `market_alert_review_queue` 欄位映射、缺欄與 dedupe unique index；頁面預設 execute=false 不連 DB，CLI 可明確 `--read-only-preflight` 只讀 catalog；版本同步至 V10.232。 - Phase 57 candidate queue writer CLI transaction：`scripts/market_intel_candidate_queue_writer.py` 在 CLI-only 情境支援受控 transaction，必須同時通過 transaction payload、read-only preflight、`--execute`、`--apply-real-write`、一次性 token、備份確認與 migration live smoke 才會以 SQLAlchemy Core idempotent insert `market_alert_review_queue`；API/UI 仍不傳 token、不連 DB、不寫 queue、不掛 scheduler；版本同步至 V10.234。 - V10.235 補 PPT 視覺 QA stale recovery：背景狀態寫入 worker PID；若部署 reload 後舊 PID 已不存在，`/observability/ppt_audit/vision_status` 會自動把 running 轉為可診斷 error 並允許重新排入，避免人工清 runtime state。 + - Phase 58 candidate queue writer post-write smoke：新增 `services/market_intel/candidate_queue_writer_postwrite_smoke.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke` 與 UI smoke 按鈕，依 transaction preview 的 dedupe key 只讀查詢 `market_alert_review_queue`，讓 CLI 真寫入後可驗證 row 是否存在；頁面預設 execute=false 不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.236。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 - Desktop UI QA：本機只註冊 `market_intel_bp` 的 Flask harness 載入 `/market_intel`，確認 Phase 15、候選預覽、writer preview、安全 flags、點陣暖紙視覺正常，console error 0。 - API QA：`/api/market_intel/schema_smoke` 通過 7 張表與 `market_platforms` 必要欄位檢查；`/api/market_intel/platform_seed_writer_plan` 回傳 4 筆 dry-run upsert preview，`writes_executed=false`，四平台皆 `blocked_dry_run_only`。 @@ -130,7 +131,7 @@ - 補 UI preview panel 真 390px 截圖 QA；本輪 in-app browser 不支援直接設定 viewport，且 data URL iframe QA 被瀏覽器安全策略阻擋，不做繞過。 - 正式端 seed writer token-hardening drift：優先白名單同步 main 的一次性環境 token 版本，避免 API 暴露固定 approval token hint。 - 正式推版前需實際執行 worktree scope review、`python backup_system.py`、commit/push 目標變更、讀 deployment SOP 與 ADR-011，且只跑 `/health` 與市場情報頁 smoke。 - - 下一步才可在明確批准後做正式 DB 的 queue writer operator drill；預設 API/UI 不得寫 DB，也不得執行 migration。 + - 下一步才可在明確批准後做正式 DB 的 queue writer operator drill；先用 post-write smoke 做只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 - 市場情報 UI 後續頁面必須沿用 V2 暖紙、暖墨、等寬數字與點陣風格，禁止複製巨型分析頁 template 模式。 ================================================================================ diff --git a/config.py b/config.py index 107f98c..95c42d7 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.235" +SYSTEM_VERSION = "V10.236" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 208f84d..70ac52c 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -183,6 +183,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue writer CLI gate：`services.market_intel.candidate_queue_writer_cli`、`scripts/market_intel_candidate_queue_writer.py` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_status` 定義 `MARKET_INTEL_QUEUE_WRITE_APPROVAL` 一次性 token、execute/apply flags、備份、migration smoke 與 rollback gate。此階段只回 writer status，不開 DB connection、不啟用實際 writer、不寫 `market_alert_review_queue`、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer preflight：`services.market_intel.candidate_queue_writer_preflight` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight` 檢查 transaction preview payload key 到 `market_alert_review_queue` 欄位映射、缺欄與 dedupe unique index。UI 預設 `execute=false` 不連 DB；CLI 明確 `--read-only-preflight` 時也只查 catalog，不寫 DB、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer CLI transaction：`scripts/market_intel_candidate_queue_writer.py` 在 CLI-only 情境支援受控 idempotent insert transaction，必須同時通過 transaction payload、read-only preflight、`--execute`、`--apply-real-write`、一次性 approval token、備份確認與 migration live smoke。API/UI 仍不得讀取 approval token、不得開 DB connection、不得寫 `market_alert_review_queue`、不得掛 scheduler；部署 smoke 不執行正式 DB 寫入。 +- 2026-05-19 追加 candidate queue writer post-write smoke：`services.market_intel.candidate_queue_writer_postwrite_smoke` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke` 依 transaction preview dedupe key 只讀查詢 `market_alert_review_queue`，供 CLI 真寫入後確認 row 是否落地。UI 預設 `execute=false` 不連 DB；人工 smoke 即使 `execute=true` 也只讀查詢，不寫 DB、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 637efcf..2fc6ec0 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,7 +19,7 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 57 candidate queue writer CLI transaction | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 58 candidate queue writer post-write smoke | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index 5eded1d..e38f36e 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -15,6 +15,9 @@ from services.market_intel.candidate_queue_writer_cli import ( from services.market_intel.candidate_queue_writer_preflight import ( build_candidate_queue_writer_preflight, ) +from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, +) TAIPEI_TZ = timezone(timedelta(hours=8)) @@ -369,6 +372,37 @@ def market_intel_manual_sample_candidate_queue_writer_preflight(): return jsonify(data), status_code +@market_intel_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_writer_postwrite_smoke(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + execute_requested = request.args.get("execute", "false").lower() == "true" + service = _service() + payload_error = None + if not isinstance(payload, dict): + sample_result = None + payload_error = "invalid_json_object" + else: + sample_result = payload.get("sample_result", payload) + + transaction_preview = service.build_manual_sample_candidate_queue_transaction( + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + ) + data = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction_preview, + execute_requested=execute_requested, + ) + data["phase"] = service.phase + status_code = 400 if payload_error else 200 + return jsonify(data), status_code + + @market_intel_bp.route("/api/market_intel/match_review_plan") @login_required def market_intel_match_review_plan(): diff --git a/services/market_intel/candidate_queue_writer_postwrite_smoke.py b/services/market_intel/candidate_queue_writer_postwrite_smoke.py new file mode 100644 index 0000000..d401009 --- /dev/null +++ b/services/market_intel/candidate_queue_writer_postwrite_smoke.py @@ -0,0 +1,203 @@ +"""候選審核 queue writer post-write 只讀 smoke。 + +本模組只依 transaction preview 的 dedupe key 查詢 +market_alert_review_queue，確認 CLI 寫入後的 row 是否存在； +不建立 ORM session、不寫 DB、不 commit、不掛 scheduler。 +""" + +from sqlalchemy import bindparam, create_engine, text + +from services.market_intel.candidate_queue_writer_preflight import QUEUE_TABLE + + +def _dedupe_keys_from_transaction(transaction_preview): + keys = [] + for statement in transaction_preview.get("statements", []): + lookup = statement.get("lookup") or {} + key = lookup.get("dedupe_key") + if key: + keys.append(str(key)) + return sorted(set(keys)) + + +def _safe_row(row): + payload = dict(row._mapping) + for key, value in list(payload.items()): + if value is not None and not isinstance(value, (bool, int, float, str)): + payload[key] = str(value) + return payload + + +def _safety_contract(): + return { + "read_only_query_only": True, + "does_not_open_transaction": True, + "does_not_commit": True, + "does_not_insert_queue_rows": True, + "does_not_attach_scheduler": True, + "target_table": QUEUE_TABLE, + } + + +def _planned_result(dedupe_keys): + return { + "mode": "candidate_queue_writer_postwrite_smoke_planned", + "target_table": QUEUE_TABLE, + "execute_requested": False, + "read_only_query_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": len(dedupe_keys), + "found_count": 0, + "missing_count": len(dedupe_keys), + "dedupe_keys": dedupe_keys, + "found_dedupe_keys": [], + "missing_dedupe_keys": dedupe_keys, + "row_summaries": [], + "postwrite_smoke_passed": False, + "ready_for_operator_review": False, + "blocked_reasons": [ + "execute_false_planned_only", + "candidate_queue_writer_postwrite_smoke_not_loaded", + ], + "safety_contract": _safety_contract(), + } + + +def build_candidate_queue_writer_postwrite_smoke( + *, + transaction_preview, + execute_requested=False, + database_url=None, + database_type=None, + engine=None, +): + """建立 post-write smoke；execute=true 仍只讀查詢 queue rows。""" + dedupe_keys = _dedupe_keys_from_transaction(transaction_preview) + if not execute_requested: + return _planned_result(dedupe_keys) + + from config import DATABASE_PATH, DATABASE_TYPE + + effective_database_type = (database_type or DATABASE_TYPE or "").lower() + effective_database_url = database_url or DATABASE_PATH + created_engine = False + connection_opened = False + + try: + if engine is None: + connect_args = {} + if effective_database_type == "postgresql": + connect_args = { + "connect_timeout": 8, + "options": "-c statement_timeout=15000", + } + engine = create_engine( + effective_database_url, + isolation_level="AUTOCOMMIT", + pool_pre_ping=True, + connect_args=connect_args, + ) + created_engine = True + + rows = [] + if dedupe_keys: + query = text( + """ + SELECT + alert_candidate_id, + review_state, + priority_lane, + threshold_level, + total_score, + evidence_bundle_id, + dedupe_key, + source_batch_id, + created_at, + updated_at + FROM market_alert_review_queue + WHERE dedupe_key IN :dedupe_keys + ORDER BY dedupe_key + """ + ).bindparams(bindparam("dedupe_keys", expanding=True)) + with engine.connect() as conn: + connection_opened = True + rows = conn.execute( + query, + {"dedupe_keys": tuple(dedupe_keys)}, + ).fetchall() + else: + with engine.connect(): + connection_opened = True + + row_summaries = [_safe_row(row) for row in rows] + found_keys = sorted(row["dedupe_key"] for row in row_summaries) + missing_keys = [key for key in dedupe_keys if key not in set(found_keys)] + passed = bool(dedupe_keys and not missing_keys) + blocked_reasons = [] + if not dedupe_keys: + blocked_reasons.append("transaction_statement_dedupe_keys_missing") + if missing_keys: + blocked_reasons.append("queue_rows_missing_after_write") + + return { + "mode": "candidate_queue_writer_postwrite_smoke_read_only", + "target_table": QUEUE_TABLE, + "execute_requested": True, + "read_only_query_executed": True, + "database_connection_opened": connection_opened, + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": len(dedupe_keys), + "found_count": len(found_keys), + "missing_count": len(missing_keys), + "dedupe_keys": dedupe_keys, + "found_dedupe_keys": found_keys, + "missing_dedupe_keys": missing_keys, + "row_summaries": row_summaries, + "postwrite_smoke_passed": passed, + "ready_for_operator_review": passed, + "blocked_reasons": blocked_reasons, + "safety_contract": _safety_contract(), + } + except Exception as exc: + return { + "mode": "candidate_queue_writer_postwrite_smoke_error", + "target_table": QUEUE_TABLE, + "execute_requested": True, + "read_only_query_executed": False, + "database_connection_opened": connection_opened, + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": len(dedupe_keys), + "found_count": 0, + "missing_count": len(dedupe_keys), + "dedupe_keys": dedupe_keys, + "found_dedupe_keys": [], + "missing_dedupe_keys": dedupe_keys, + "row_summaries": [], + "postwrite_smoke_passed": False, + "ready_for_operator_review": False, + "blocked_reasons": ["candidate_queue_writer_postwrite_smoke_error"], + "error_message": str(exc), + "safety_contract": _safety_contract(), + } + finally: + if created_engine: + engine.dispose() diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index aeaf8e1..cf6b0e2 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -9,6 +9,9 @@ from services.market_intel.candidate_queue_writer_cli import ( from services.market_intel.candidate_queue_writer_preflight import ( build_candidate_queue_writer_preflight, ) +from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, +) def build_deployment_readiness_preview( @@ -51,6 +54,12 @@ def build_deployment_readiness_preview( transaction_preview=manual_sample_candidate_queue_transaction, writer_preflight=candidate_queue_writer_preflight, ) + candidate_queue_writer_postwrite_smoke = ( + build_candidate_queue_writer_postwrite_smoke( + transaction_preview=manual_sample_candidate_queue_transaction, + execute_requested=False, + ) + ) match_review_plan = service.build_match_review_plan() opportunity_plan = service.build_opportunity_plan() opportunity_scoring_plan = service.build_opportunity_scoring_plan() @@ -227,6 +236,15 @@ def build_deployment_readiness_preview( and not candidate_queue_writer_preflight["database_commit_executed"] and not candidate_queue_writer_preflight["scheduler_attached"] ), + "candidate_queue_writer_postwrite_smoke_planned_safe": bool( + candidate_queue_writer_postwrite_smoke["mode"] + == "candidate_queue_writer_postwrite_smoke_planned" + and not candidate_queue_writer_postwrite_smoke["read_only_query_executed"] + and not candidate_queue_writer_postwrite_smoke["database_connection_opened"] + and not candidate_queue_writer_postwrite_smoke["database_write_executed"] + and not candidate_queue_writer_postwrite_smoke["database_commit_executed"] + and not candidate_queue_writer_postwrite_smoke["scheduler_attached"] + ), "match_review_plan_preview_safe": bool( match_review_plan["mode"] == "match_review_plan_preview" and not match_review_plan["review_queue_created"] @@ -441,6 +459,7 @@ def build_deployment_readiness_preview( "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", + "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", ], "status": status.to_dict(), "schema_smoke": schema_smoke, @@ -479,6 +498,9 @@ def build_deployment_readiness_preview( ), "candidate_queue_writer_preflight": candidate_queue_writer_preflight, "candidate_queue_writer_cli_status": candidate_queue_writer_cli_status, + "candidate_queue_writer_postwrite_smoke": ( + candidate_queue_writer_postwrite_smoke + ), "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, "opportunity_scoring_plan": opportunity_scoring_plan, diff --git a/services/market_intel/service.py b/services/market_intel/service.py index d6fa5cf..4285ee1 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -108,7 +108,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務，先集中 feature gate 與安全狀態。""" - phase = "phase_57_candidate_queue_writer_cli_transaction" + phase = "phase_58_candidate_queue_writer_postwrite_smoke" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 6e2f7ab..99e152a 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -594,6 +594,9 @@ + @@ -924,6 +927,7 @@ const sampleCandidateQueueTransaction = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-transaction]') : null; const sampleCandidateQueueWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-writer]') : null; const sampleCandidateQueuePreflight = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-preflight]') : null; + const sampleCandidateQueuePostwriteSmoke = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-postwrite-smoke]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -932,6 +936,7 @@ const sampleCandidateQueueTransactionEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_transaction') }}"; const sampleCandidateQueueWriterEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_status') }}"; const sampleCandidateQueuePreflightEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_preflight') }}"; + const sampleCandidateQueuePostwriteSmokeEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_postwrite_smoke') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -2389,6 +2394,67 @@ } }; + const renderCandidateQueuePostwriteSmoke = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const found = data.found_dedupe_keys || []; + const missing = data.missing_dedupe_keys || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `passed=${data.postwrite_smoke_passed ? 'yes' : 'no'}`, + `expected=${data.expected_dedupe_key_count || 0}`, + `found=${data.found_count || 0}`, + `missing=${data.missing_count || 0}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只做 CLI 寫入後的 queue row 只讀驗證；頁面預設不連 DB、不寫 queue。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+ found dedupe keys + ${escapeHtml(found.join(', ') || 'none')} +
+
+ missing dedupe keys + ${escapeHtml(missing.join(', ') || 'none')} +
+
+ read-only status + query=${data.read_only_query_executed ? 'yes' : 'no'} / write=${data.database_write_executed ? 'yes' : 'no'} / commit=${data.database_commit_executed ? 'yes' : 'no'} +
+
+ `; + }; + + const loadCandidateQueuePostwriteSmoke = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + + sampleReviewBody.innerHTML = '
檢查 queue writer post-write smoke 中...
'; + try { + const response = await fetch(sampleCandidateQueuePostwriteSmokeEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ sample_result: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueuePostwriteSmoke(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue writer post-write smoke 檢查失敗：${escapeHtml(error.message)}
`; + } + }; + const renderSchedulerMeta = data => { schedulerMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -3901,6 +3967,9 @@ if (sampleCandidateQueuePreflight) { sampleCandidateQueuePreflight.addEventListener('click', loadCandidateQueuePreflight); } + if (sampleCandidateQueuePostwriteSmoke) { + sampleCandidateQueuePostwriteSmoke.addEventListener('click', loadCandidateQueuePostwriteSmoke); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index b87de25..1d01f01 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -549,6 +549,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "market_intel.market_intel_manual_sample_candidate_queue_transaction" in template assert "market_intel.market_intel_manual_sample_candidate_queue_writer_status" in template assert "market_intel.market_intel_manual_sample_candidate_queue_writer_preflight" in template + assert ( + "market_intel.market_intel_manual_sample_candidate_queue_writer_postwrite_smoke" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -585,7 +589,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert bridge["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -743,7 +747,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert contract["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -876,7 +880,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -889,7 +893,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert gate["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -959,7 +963,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -971,7 +975,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1019,7 +1023,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1030,7 +1034,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert acceptance["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1072,7 +1076,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1084,7 +1088,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert review["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1195,7 +1199,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1234,7 +1238,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert review["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1296,7 +1300,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1376,7 +1380,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert handoff["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1440,7 +1444,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1499,7 +1503,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert queue_draft["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1573,7 +1577,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1636,7 +1640,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert approval["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -1714,7 +1718,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -1777,7 +1781,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert transaction["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -1857,7 +1861,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -2224,6 +2228,168 @@ def test_candidate_queue_writer_cli_sqlite_transaction_is_idempotent(): assert second_run["database_commit_executed"] is True +def test_candidate_queue_writer_postwrite_smoke_planned_without_db(): + from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, + ) + + sample_result = { + "batch_id": "sample-batch-20", + "platform_code": "momo", + "source_key": "homepage", + "source_url": "https://www.momoshop.com.tw/", + "status": "fetched", + "status_code": 200, + "content_length": 1700, + "page_hash": "2" * 64, + "title": "MOMO 活動", + "diagnostics": { + "link_count": 1, + "same_host_link_count": 1, + "campaign_link_candidates": [ + { + "confidence_band": "high", + "score": 94, + "url": "https://www.momoshop.com.tw/activity/sample", + "text": "品牌活動", + }, + ], + }, + } + transaction = MarketIntelService().build_manual_sample_candidate_queue_transaction( + sample_result=sample_result + ) + smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + + assert smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" + assert smoke["execute_requested"] is False + assert smoke["read_only_query_executed"] is False + assert smoke["database_connection_opened"] is False + assert smoke["database_session_created"] is False + assert smoke["explicit_transaction_opened"] is False + assert smoke["database_write_executed"] is False + assert smoke["database_commit_executed"] is False + assert smoke["scheduler_attached"] is False + assert smoke["expected_dedupe_key_count"] == 1 + assert smoke["found_count"] == 0 + assert smoke["missing_count"] == 1 + assert smoke["postwrite_smoke_passed"] is False + assert "candidate_queue_writer_postwrite_smoke_not_loaded" in smoke["blocked_reasons"] + + +def test_candidate_queue_writer_postwrite_smoke_sqlite_read_only_finds_rows(): + from services.market_intel.candidate_queue_writer_cli import ( + build_candidate_queue_writer_cli_plan, + ) + from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_writer_preflight import ( + build_candidate_queue_writer_preflight, + ) + + sample_result = { + "batch_id": "sample-batch-21", + "platform_code": "pchome", + "source_key": "homepage", + "source_url": "https://24h.pchome.com.tw/", + "status": "fetched", + "status_code": 200, + "content_length": 1800, + "page_hash": "3" * 64, + "title": "PChome 活動", + "diagnostics": { + "link_count": 1, + "same_host_link_count": 1, + "campaign_link_candidates": [ + { + "confidence_band": "medium", + "score": 74, + "url": "https://24h.pchome.com.tw/activity/sample", + "text": "活動頁", + }, + ], + }, + } + transaction = MarketIntelService().build_manual_sample_candidate_queue_transaction( + sample_result=sample_result + ) + engine = create_engine("sqlite:///:memory:") + with engine.begin() as conn: + conn.execute( + text( + """ + CREATE TABLE market_alert_review_queue ( + id INTEGER PRIMARY KEY AUTOINCREMENT, + alert_candidate_id TEXT NOT NULL UNIQUE, + review_state TEXT NOT NULL DEFAULT 'draft', + priority_lane TEXT NOT NULL DEFAULT 'watch', + threshold_level TEXT NOT NULL, + total_score FLOAT NOT NULL DEFAULT 0, + evidence_bundle_id TEXT NOT NULL, + dedupe_key TEXT NOT NULL, + source_batch_id TEXT NOT NULL, + metadata_json TEXT, + created_at TEXT DEFAULT CURRENT_TIMESTAMP, + updated_at TEXT DEFAULT CURRENT_TIMESTAMP + ) + """ + ) + ) + conn.execute( + text( + "CREATE UNIQUE INDEX ux_market_alert_review_queue_dedupe " + "ON market_alert_review_queue (dedupe_key)" + ) + ) + preflight = build_candidate_queue_writer_preflight( + transaction_preview=transaction, + execute_requested=True, + engine=engine, + database_type="sqlite", + ) + writer = build_candidate_queue_writer_cli_plan( + transaction_preview=transaction, + writer_preflight=preflight, + execute_requested=True, + apply_real_write=True, + approval_token=TEST_APPROVAL_TOKEN, + approval_token_secret=TEST_APPROVAL_TOKEN, + backup_verified=True, + migration_live_smoke_passed=True, + engine=engine, + database_type="sqlite", + ) + smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=True, + engine=engine, + database_type="sqlite", + ) + + assert writer["inserted_count"] == 1 + assert smoke["mode"] == "candidate_queue_writer_postwrite_smoke_read_only" + assert smoke["execute_requested"] is True + assert smoke["read_only_query_executed"] is True + assert smoke["database_connection_opened"] is True + assert smoke["database_session_created"] is False + assert smoke["explicit_transaction_opened"] is False + assert smoke["database_write_executed"] is False + assert smoke["database_commit_executed"] is False + assert smoke["scheduler_attached"] is False + assert smoke["expected_dedupe_key_count"] == 1 + assert smoke["found_count"] == 1 + assert smoke["missing_count"] == 0 + assert smoke["missing_dedupe_keys"] == [] + assert smoke["postwrite_smoke_passed"] is True + assert smoke["ready_for_operator_review"] is True + assert smoke["blocked_reasons"] == [] + assert smoke["row_summaries"][0]["review_state"] == "needs_review" + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -2266,7 +2432,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -2323,7 +2489,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -2369,11 +2535,65 @@ def test_candidate_queue_writer_status_blocks_invalid_payload(): assert "transaction_preview_created" in data["blocked_reasons"] +def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_writer_postwrite_smoke", + json={ + "sample_result": { + "batch_id": "sample-batch-22", + "platform_code": "momo", + "source_key": "homepage", + "source_url": "https://www.momoshop.com.tw/", + "status": "fetched", + "status_code": 200, + "content_length": 1700, + "page_hash": "4" * 64, + "title": "MOMO 活動", + "diagnostics": { + "link_count": 1, + "same_host_link_count": 1, + "campaign_link_candidates": [ + { + "confidence_band": "high", + "score": 94, + "url": "https://www.momoshop.com.tw/activity/sample", + "text": "品牌活動", + }, + ], + }, + } + }, + ) + data = response.get_json() + + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" + assert data["execute_requested"] is False + assert data["read_only_query_executed"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["expected_dedupe_key_count"] == 1 + assert data["postwrite_smoke_passed"] is False + + def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -2411,7 +2631,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -2422,7 +2642,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -2458,7 +2678,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -2469,7 +2689,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -2510,7 +2730,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -2521,7 +2741,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -2569,7 +2789,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -2581,7 +2801,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -2627,7 +2847,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -2640,7 +2860,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert plan["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -2725,7 +2945,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -2803,7 +3023,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -2818,7 +3038,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert readiness["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -3216,6 +3436,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["manual_sample_candidate_queue_transaction_post_safe"] is True assert readiness["checks"]["candidate_queue_writer_cli_status_safe"] is True assert readiness["checks"]["candidate_queue_writer_preflight_planned_safe"] is True + assert ( + readiness["checks"]["candidate_queue_writer_postwrite_smoke_planned_safe"] + is True + ) assert readiness["checks"]["match_review_plan_preview_safe"] is True assert readiness["checks"]["opportunity_plan_preview_safe"] is True assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True @@ -3258,6 +3482,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/migration_catalog_review" in readiness["production_smoke_targets"] assert "/api/market_intel/migration_live_smoke" in readiness["production_smoke_targets"] assert "/api/market_intel/live_db_inventory" in readiness["production_smoke_targets"] + assert ( + "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke" + in readiness["production_smoke_targets"] + ) assert readiness["write_approval_runbook"]["ready_for_real_write"] is False assert readiness["write_approval_runbook"]["writes_executed"] is False assert readiness["migration_blueprint"]["migration_executed"] is False @@ -3573,6 +3801,38 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["candidate_queue_writer_preflight"]["scheduler_attached"] is False ) + assert ( + readiness["candidate_queue_writer_postwrite_smoke"]["mode"] + == "candidate_queue_writer_postwrite_smoke_planned" + ) + assert ( + readiness["candidate_queue_writer_postwrite_smoke"][ + "read_only_query_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_postwrite_smoke"][ + "database_connection_opened" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_postwrite_smoke"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_postwrite_smoke"][ + "database_commit_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_postwrite_smoke"]["scheduler_attached"] + is False + ) assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False assert readiness["scheduler_plan"]["crawler_job_started"] is False assert readiness["scheduler_plan"]["database_write_executed"] is False @@ -3677,7 +3937,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert drill["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -3792,7 +4052,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -3804,7 +4064,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert review["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -3919,7 +4179,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -3932,7 +4192,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert smoke["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -3994,7 +4254,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -4007,7 +4267,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert inventory["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -4151,7 +4411,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -4378,7 +4638,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_57_candidate_queue_writer_cli_transaction" + assert data["phase"] == "phase_58_candidate_queue_writer_postwrite_smoke" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False