diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index acf5460..d87c76f 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.503 新增市場情報 MCP Fetch Candidate Queue Writer Review Handoff 安全預覽 gate:只審核 post-closeout inventory review 通過後的人工 candidate queue review 交接包,確認 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation;API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler。 - V10.502 修正 AiderHeal 自動修復診斷鏈:先做 ADR-020 檔案白名單再打 110 preflight,`tests/` finding 會明確略過而不誤報 repo preflight;Code Review 完成通知會把全數不在白名單的 finding 標成需人工處理,不再宣稱已觸發 AiderHeal;白名單放行 `services/routes/database` 子目錄 Python 檔,preflight 通知帶 stderr/stdout 細節,健康檢查同時接受 `/health` 回 `ok` 與 `healthy`。 - V10.501 新增市場情報 MCP Fetch Candidate Queue Writer Post-Closeout Inventory Review 安全預覽 gate:只審核 closeout review 後由操作員 shell 完成的 live inventory read-only 摘要,確認 closeout linkage、row count、inventory artifact、closeout review artifact、read-only query result、missing/duplicate rows 與 operator confirmation;API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 inventory query、不掛 scheduler。 - V10.500 新增市場情報 MCP Fetch Candidate Queue Writer Run Closeout Review 安全預覽 gate:只審核 receipt review 通過後的 operator closeout 摘要,確認 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmation;API 不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler。 diff --git a/config.py b/config.py index 9a48799..bfc6ca4 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.502" +SYSTEM_VERSION = "V10.503" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 31b2ff8..aa74181 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -173,6 +173,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate queue writer run receipt review gate:`services.market_intel.mcp_fetch_candidate_queue_writer_run_receipt_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_receipt_review` 在 run readiness 通過後審核 operator shell writer run 的 receipt 摘要,檢查 readiness linkage、run package id、候選/dedupe keys、writer output artifact、post-write smoke artifact、backup path、operator confirmations 與 token redaction;API/UI 不讀 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 post-write query、不掛 scheduler,只放行到 closeout review。 - 2026-05-31 追加 MCP fetch candidate queue writer run closeout review gate:`services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review` 在 receipt review 通過後審核 operator closeout 摘要,檢查 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmations;API/UI 不讀 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler,只放行到 read-only post-closeout inventory review。 - 2026-05-31 追加 MCP fetch candidate queue writer post-closeout inventory review gate:`services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_post_closeout_inventory_review` 在 closeout review 通過後審核 operator live inventory read-only 摘要,檢查 closeout linkage、row count、inventory artifact、closeout review artifact、read-only query result、missing/duplicate rows 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 inventory query、不掛 scheduler,只放行到 candidate queue review handoff。 +- 2026-05-31 追加 MCP fetch candidate queue writer review handoff gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff` 在 post-closeout inventory review 通過後審核 operator candidate queue review handoff 摘要,檢查 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 16a837b..61be9d0 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -51,6 +51,7 @@ - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer run receipt review gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_receipt_review.py` 為 688 行,略過 600 行提醒門檻。暫不拆分的理由是 receipt gate 需同時審核 readiness linkage、receipt identity、artifact path policy、operator confirmation、token redaction 與 side-effect blocklist;若下一段 closeout gate 重複相同 path/side-effect policy,應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer run closeout review gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review.py` 為 724 行,略過 600 行提醒門檻。暫不拆分的理由是 closeout gate 需同時審核 receipt review linkage、artifact manifest preservation、rollback note、read-only inventory next-step、lightweight preview sample 與 side-effect blocklist;若下一段 post-closeout inventory gate 重複 path/side-effect policy,應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer post-closeout inventory review gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_post_closeout_inventory_review.py` 為 649 行,略過 600 行提醒門檻。暫不拆分的理由是 inventory gate 需同時審核 closeout linkage、read-only inventory 摘要、artifact path policy、operator boundary confirmation 與 side-effect blocklist;後續若 candidate queue review handoff 再複用同一套 path/side-effect policy,應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 +- 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer review handoff gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次將 sample payload 抽到 `services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff_sample.py`(105 行),主 gate `services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff.py` 降為 571 行,低於 600 行提醒門檻;後續若 candidate queue review inventory 繼續複用 path/side-effect policy,應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-24 追記:同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數;此處只更新 inventory,不變更 Code Review 行為。 - 2026-05-21 追記:同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 @@ -103,7 +104,7 @@ | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | | 917 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 1583 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 1655 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index 621f2ec..bb00ea8 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -98,6 +98,7 @@ - 2026-05-31 起,`V10.500` 新增市場情報 MCP Fetch Candidate Queue Writer Run Closeout Review gate:在 receipt review 通過後只審核 operator closeout 摘要,要求 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmation 對齊;仍不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler,只放行到 read-only post-closeout inventory review。 - 2026-05-31 起,`V10.501` 新增市場情報 MCP Fetch Candidate Queue Writer Post-Closeout Inventory Review gate:在 closeout review 通過後只審核 operator live inventory read-only 摘要,要求 closeout linkage、row count、inventory artifact、closeout review artifact、read-only query result、missing/duplicate rows 與 operator confirmation 對齊;仍不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 inventory query、不掛 scheduler,只放行到 candidate queue review handoff。 - 2026-05-31 起,`V10.502` 修正 AiderHeal 自動修復診斷鏈:先檢查 ADR-020 檔案白名單再執行 110 preflight,`tests/` finding 會明確略過而不誤報 repo preflight;Code Review 完成通知會把全數不在白名單的 finding 標成需人工處理,不再宣稱已觸發 AiderHeal;白名單放行 `services/routes/database` 子目錄 Python 檔,preflight 通知帶遠端錯誤細節,健康檢查接受 `/health` 回 `healthy`。 +- 2026-05-31 起,`V10.503` 新增市場情報 MCP Fetch Candidate Queue Writer Review Handoff gate:在 post-closeout inventory review 通過後只審核 operator candidate queue review handoff 摘要,要求 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation 對齊;仍不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index a99d704..dc54b56 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24:PChome 近門檻身份回收第二輪 +- **V10.503 市場情報 MCP Fetch Candidate Queue Writer Review Handoff gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff` 與 UI preview,只審核 post-closeout inventory review 通過後的 operator candidate queue review handoff 摘要;要求 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation 對齊,且 API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 - **V10.502 AiderHeal 自動修復診斷鏈修正**: `execute_code_fix()` 改為先檢查 ADR-020 檔案白名單再執行 110 preflight,避免 `tests/...` 這類不得自動修的 finding 被誤報成 `/home/wooo/ewoooc` preflight 失敗;Code Review 完成通知會把全數不在白名單的 finding 標成需人工處理,不再宣稱已觸發 AiderHeal;白名單同步放行 `services/routes/database` 子目錄 Python 檔,preflight 通知帶 stderr/stdout 細節,健康檢查接受正式 `/health` 回傳的 `healthy`。 - **V10.501 市場情報 MCP Fetch Candidate Queue Writer Post-Closeout Inventory Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_post_closeout_inventory_review` 與 UI preview,只審核 closeout review 通過後的 operator live inventory read-only 摘要;要求 closeout linkage、row count、inventory artifact、closeout review artifact、read-only query result、missing/duplicate rows 與 operator confirmation 對齊,且 API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 inventory query、不掛 scheduler,只放行到 candidate queue review handoff。 - **V10.500 市場情報 MCP Fetch Candidate Queue Writer Run Closeout Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review` 與 UI preview,只審核 receipt review 通過後的 operator closeout 摘要;要求 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmation 對齊,且 API 不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler,只放行到 read-only post-closeout inventory review。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index a8fbffc..90b5407 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -46,6 +46,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review from services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review import ( build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff import ( + build_mcp_fetch_candidate_queue_writer_review_handoff_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -602,3 +605,60 @@ def market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_review_handoff(): + writer_post_closeout_inventory_review_package = {} + writer_post_closeout_inventory_review_result = None + operator_handoff = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_review_handoff_package") + or payload.get("candidate_queue_writer_review_handoff") + or payload.get("review_handoff") + or payload.get("operator_handoff_review") + or payload.get("operator_handoff") + or payload + ) + writer_post_closeout_inventory_review_package = ( + package.get("writer_post_closeout_inventory_review_package") + or package.get("candidate_queue_writer_post_closeout_inventory_review") + or package.get("writer_post_closeout_inventory_review") + or package.get("post_closeout_inventory_review_package") + or package.get("post_closeout_inventory_review") + or package.get("operator_inventory_review") + or {} + ) + writer_post_closeout_inventory_review_result = ( + package.get("writer_post_closeout_inventory_review_result") + or package.get( + "mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + ) + ) + operator_handoff = ( + package.get("operator_handoff") + or package.get("candidate_queue_review_handoff") + or package.get("writer_review_handoff") + or package.get("handoff_payload") + or package.get("handoff") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_review_handoff_preview( + writer_post_closeout_inventory_review_package=( + writer_post_closeout_inventory_review_package + ), + writer_post_closeout_inventory_review_result=( + writer_post_closeout_inventory_review_result + ), + operator_handoff=operator_handoff, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 968fd67..04ab82e 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -102,6 +102,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review from services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review import ( build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff import ( + build_mcp_fetch_candidate_queue_writer_review_handoff_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -271,6 +274,11 @@ PRODUCTION_SMOKE_TARGETS = ( ) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -355,6 +363,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_review_handoff = ( + build_mcp_fetch_candidate_queue_writer_review_handoff_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -1180,6 +1193,64 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "scheduler_attached" ] ), + "mcp_fetch_candidate_queue_writer_review_handoff_preview_safe": bool( + mcp_fetch_candidate_queue_writer_review_handoff["mode"] + == "mcp_fetch_candidate_queue_writer_review_handoff_preview" + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "payload_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "review_handoff_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "handoff_file_written" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "package_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_writes_file" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_executes_cli" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_reads_approval_token" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_writes_database" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_updates_review_state" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "api_inventory_query_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "database_commit_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "cli_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "file_written" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "scheduler_attached" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "candidate_queue_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_handoff[ + "candidate_review_state_updated" + ] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1506,6 +1577,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_candidate_queue_writer_run_receipt_review": mcp_fetch_candidate_queue_writer_run_receipt_review, "mcp_fetch_candidate_queue_writer_run_closeout_review": mcp_fetch_candidate_queue_writer_run_closeout_review, "mcp_fetch_candidate_queue_writer_post_closeout_inventory_review": mcp_fetch_candidate_queue_writer_post_closeout_inventory_review, + "mcp_fetch_candidate_queue_writer_review_handoff": mcp_fetch_candidate_queue_writer_review_handoff, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff.py b/services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff.py new file mode 100644 index 0000000..93d3bab --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff.py @@ -0,0 +1,571 @@ +"""市場情報 MCP fetch candidate queue writer review handoff。 + +本模組只審核 post-closeout inventory review 之後的 operator handoff 摘要; +API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不寫檔、 +不做 inventory query、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + ARTIFACT_PREFIX, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review import ( + FORBIDDEN_SECRET_KEYS, + SAFE_SECRET_METADATA_KEYS, + _as_dict, + _as_list, + _blocked_side_effects, + _contains_forbidden_key, + _safe_int, + _safe_path, + _safe_text, + build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff_sample import ( + build_sample_writer_review_handoff_package, +) + +_HANDOFF_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_candidate_review_update", + "allow_api_execution", + "allow_api_file_write", + "allow_api_queue_write", + "allow_cli_execution", + "allow_database_write", + "api_candidate_review_update_executed", + "api_created_review_handoff_file", + "api_created_review_queue", + "api_executed_candidate_review", + "api_inventory_query_executed", + "api_review_handoff_persisted", + "api_review_state_update_executed", + "api_updates_review_state", + "api_writes_review_queue", + "candidate_queue_review_created_by_api", + "candidate_queue_review_handoff_file_written", + "candidate_queue_review_handoff_persisted", + "candidate_queue_review_started_by_api", + "candidate_review_file_written", + "candidate_review_queue_written", + "handoff_file_written", + "handoff_persisted", + "manual_review_record_written", + "queue_review_persisted", + "review_queue_file_written", + "review_queue_row_written", + "review_state_update_executed", +) + + +def _blocked_handoff_side_effects(payload): + found = list(_blocked_side_effects(payload)) + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _HANDOFF_BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return sorted(set(found)) + + +def _inventory_review_from_inputs(inventory_package, inventory_result, phase): + if isinstance(inventory_result, dict) and inventory_result: + return inventory_result + + inventory_package = _as_dict(inventory_package) + return build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview( + writer_run_closeout_review_package=( + inventory_package.get("writer_run_closeout_review_package") + or inventory_package.get("candidate_queue_writer_run_closeout_review") + or inventory_package.get("writer_run_closeout_review") + or inventory_package.get("run_closeout_review_package") + or {} + ), + writer_run_closeout_review_result=( + inventory_package.get("writer_run_closeout_review_result") + or inventory_package.get( + "mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + ), + operator_inventory=( + inventory_package.get("operator_inventory") + or inventory_package.get("post_closeout_inventory") + or inventory_package.get("writer_post_closeout_inventory") + or inventory_package.get("inventory_payload") + or inventory_package.get("inventory") + ), + phase=phase, + ) + + +def _inventory_review_summary(inventory_result): + inventory_result = _as_dict(inventory_result) + operator_inventory = _as_dict(inventory_result.get("operator_inventory_summary")) + side_effects_clear = bool( + not inventory_result.get("payload_persisted") + and not inventory_result.get("post_closeout_inventory_review_persisted") + and not inventory_result.get("post_closeout_inventory_persisted") + and not inventory_result.get("post_closeout_inventory_file_written") + and not inventory_result.get("inventory_file_written") + and not inventory_result.get("package_artifact_created") + and not inventory_result.get("network_request_allowed") + and not inventory_result.get("api_executes_cli") + and not inventory_result.get("api_reads_approval_token") + and not inventory_result.get("api_opens_database_connection") + and not inventory_result.get("api_writes_database") + and not inventory_result.get("api_writes_file") + and not inventory_result.get("api_uses_external_network") + and not inventory_result.get("api_inventory_query_executed") + and not inventory_result.get("post_closeout_query_executed_by_api") + and not inventory_result.get("database_write_executed") + and not inventory_result.get("cli_executed") + and not inventory_result.get("file_written") + and not inventory_result.get("scheduler_attached") + and not inventory_result.get("candidate_queue_created") + and not inventory_result.get("candidate_queue_persisted") + and not inventory_result.get("candidate_review_state_updated") + ) + return { + "mode": inventory_result.get("mode"), + "accepted": bool( + inventory_result.get( + "mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepted" + ) + ), + "ready_for_candidate_queue_review_handoff": bool( + inventory_result.get("ready_for_candidate_queue_review_handoff") + ), + "inventory_review_id": _safe_text( + operator_inventory.get("inventory_review_id"), 160 + ), + "closeout_id": _safe_text(operator_inventory.get("closeout_id"), 160), + "run_package_id": _safe_text( + operator_inventory.get("run_package_id"), 160 + ), + "receipt_id": _safe_text(operator_inventory.get("receipt_id"), 160), + "target_table": _safe_text(operator_inventory.get("target_table"), 160), + "payload_row_count": _safe_int(operator_inventory.get("payload_row_count")), + "found_row_count": _safe_int(operator_inventory.get("found_row_count")), + "inventory_artifact_path": _safe_text( + operator_inventory.get("inventory_artifact_path") + ), + "closeout_review_artifact_path": _safe_text( + operator_inventory.get("closeout_review_artifact_path") + ), + "read_only_query_result_path": _safe_text( + operator_inventory.get("read_only_query_result_path") + ), + "inventory_artifact_path_safe": bool( + operator_inventory.get("inventory_artifact_path_safe") + ), + "closeout_review_artifact_path_safe": bool( + operator_inventory.get("closeout_review_artifact_path_safe") + ), + "read_only_query_result_path_safe": bool( + operator_inventory.get("read_only_query_result_path_safe") + ), + "side_effects_clear": side_effects_clear, + "blocked_reasons": inventory_result.get("blocked_reasons", []), + } + + +def _operator_handoff_summary(operator_handoff): + operator_handoff = _as_dict(operator_handoff) + confirmations = _as_dict(operator_handoff.get("operator_confirmations")) + contract = _as_dict(operator_handoff.get("review_contract")) + required_columns = [ + _safe_text(item, 120) + for item in _as_list(contract.get("required_columns")) + if _safe_text(item, 120) + ] + allowed_manual_actions = [ + _safe_text(item, 120) + for item in _as_list(contract.get("allowed_manual_actions")) + if _safe_text(item, 120) + ] + forbidden_api_actions = [ + _safe_text(item, 120) + for item in _as_list(contract.get("forbidden_api_actions")) + if _safe_text(item, 120) + ] + return { + "provided_keys": sorted(operator_handoff.keys()), + "handoff_id": _safe_text(operator_handoff.get("handoff_id"), 160), + "inventory_review_id": _safe_text( + operator_handoff.get("inventory_review_id"), 160 + ), + "closeout_id": _safe_text(operator_handoff.get("closeout_id"), 160), + "run_package_id": _safe_text(operator_handoff.get("run_package_id"), 160), + "receipt_id": _safe_text(operator_handoff.get("receipt_id"), 160), + "target_table": _safe_text(operator_handoff.get("target_table"), 160), + "payload_row_count": _safe_int(operator_handoff.get("payload_row_count")), + "expected_payload_row_count": _safe_int( + operator_handoff.get("expected_payload_row_count") + or operator_handoff.get("payload_row_count") + ), + "expected_review_state": _safe_text( + operator_handoff.get("expected_review_state") + or contract.get("expected_review_state"), + 80, + ), + "contract_expected_review_state": _safe_text( + contract.get("expected_review_state"), 80 + ), + "required_columns": required_columns, + "allowed_manual_actions": allowed_manual_actions, + "forbidden_api_actions": forbidden_api_actions, + "review_scope": _safe_text(operator_handoff.get("review_scope"), 120), + "next_queue": _safe_text(operator_handoff.get("next_queue"), 120), + "review_queue_artifact_path": _safe_text( + operator_handoff.get("review_queue_artifact_path") + ), + "inventory_artifact_path": _safe_text( + operator_handoff.get("inventory_artifact_path") + ), + "handoff_artifact_path": _safe_text( + operator_handoff.get("handoff_artifact_path") + ), + "review_queue_artifact_path_safe": _safe_path( + operator_handoff.get("review_queue_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "inventory_artifact_path_safe": _safe_path( + operator_handoff.get("inventory_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "handoff_artifact_path_safe": _safe_path( + operator_handoff.get("handoff_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "inventory_reviewed": bool(confirmations.get("inventory_reviewed")), + "inventory_artifacts_preserved": bool( + confirmations.get("inventory_artifacts_preserved") + ), + "candidate_queue_review_only": bool( + confirmations.get("candidate_queue_review_only") + ), + "manual_review_only": bool( + confirmations.get("manual_review_only") + or confirmations.get("candidate_queue_review_only") + ), + "manual_review_required": bool(confirmations.get("manual_review_required")), + "no_approval_token_payload": bool( + confirmations.get("no_approval_token_payload") + ), + "no_api_cli_execution": bool(confirmations.get("no_api_cli_execution")), + "no_api_database_write": bool(confirmations.get("no_api_database_write")), + "no_api_inventory_query": bool( + confirmations.get("no_api_inventory_query") + ), + "no_api_file_write": bool(confirmations.get("no_api_file_write")), + "no_scheduler_attach": bool(confirmations.get("no_scheduler_attach")), + "no_api_review_state_update": bool( + confirmations.get("no_api_review_state_update") + ), + "no_api_queue_insert": bool(confirmations.get("no_api_queue_insert")), + "api_execution_allowed": bool(operator_handoff.get("api_execution_allowed")), + "real_write_allowed_by_api": bool( + operator_handoff.get("real_write_allowed_by_api") + ), + "api_candidate_review_allowed": bool( + operator_handoff.get("api_candidate_review_allowed") + ), + "api_updates_review_state": bool(operator_handoff.get("api_updates_review_state")), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + operator_handoff, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_handoff_side_effects(operator_handoff), + } + + +def _handoff_gates(*, inventory_received, handoff_received, inventory, handoff): + operator_confirmed_boundaries = bool( + handoff["inventory_reviewed"] + and handoff["inventory_artifacts_preserved"] + and handoff["candidate_queue_review_only"] + and handoff["manual_review_only"] + and handoff["manual_review_required"] + and handoff["no_approval_token_payload"] + and handoff["no_api_cli_execution"] + and handoff["no_api_database_write"] + and handoff["no_api_inventory_query"] + and handoff["no_api_file_write"] + and handoff["no_api_review_state_update"] + and handoff["no_api_queue_insert"] + and handoff["no_scheduler_attach"] + ) + contract_valid = bool( + handoff["expected_review_state"] == "needs_review" + and handoff["contract_expected_review_state"] == "needs_review" + and {"dedupe_key", "review_state"}.issubset(set(handoff["required_columns"])) + and handoff["allowed_manual_actions"] + ) + forbids_api_mutations = bool( + {"update_review_state", "insert_missing_queue_row"}.issubset( + set(handoff["forbidden_api_actions"]) + ) + and handoff["no_api_review_state_update"] + and handoff["no_api_queue_insert"] + ) + return [ + { + "key": "post_closeout_inventory_review_payload_or_result_received", + "label": "已提供 post-closeout inventory review package 或已審核結果", + "passed": inventory_received, + }, + { + "key": "post_closeout_inventory_review_accepted", + "label": "post-closeout inventory review gate 必須已通過", + "passed": inventory["accepted"], + }, + { + "key": "post_closeout_inventory_ready_for_handoff", + "label": "inventory review 必須只放行到 candidate queue review handoff", + "passed": inventory["ready_for_candidate_queue_review_handoff"], + }, + { + "key": "post_closeout_inventory_side_effect_free", + "label": "inventory review 未顯示 API 執行、寫 DB、寫檔、查 DB 或掛 scheduler", + "passed": inventory["side_effects_clear"], + }, + { + "key": "post_closeout_inventory_identity_recorded", + "label": "inventory review 必須保留 inventory_review_id、closeout_id、run_package_id 與 receipt_id", + "passed": bool( + inventory["inventory_review_id"] + and inventory["closeout_id"] + and inventory["run_package_id"] + and inventory["receipt_id"] + ), + }, + { + "key": "candidate_queue_review_handoff_payload_received", + "label": "已提供 operator candidate queue review handoff 摘要", + "passed": handoff_received, + }, + { + "key": "candidate_queue_review_handoff_identity_recorded", + "label": "handoff 必須記錄 handoff_id、inventory_review_id、closeout_id、run_package_id 與 receipt_id", + "passed": bool( + handoff["handoff_id"] + and handoff["inventory_review_id"] + and handoff["closeout_id"] + and handoff["run_package_id"] + and handoff["receipt_id"] + ), + }, + { + "key": "candidate_queue_review_handoff_identity_matches_inventory", + "label": "handoff identity 必須對齊 inventory review", + "passed": bool( + handoff["inventory_review_id"] == inventory["inventory_review_id"] + and handoff["closeout_id"] == inventory["closeout_id"] + and handoff["run_package_id"] == inventory["run_package_id"] + and handoff["receipt_id"] == inventory["receipt_id"] + ), + }, + { + "key": "candidate_queue_review_handoff_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": handoff["target_table"] == TARGET_TABLE, + }, + { + "key": "candidate_queue_review_handoff_row_count_matches_inventory", + "label": "handoff row count 必須對齊 inventory payload rows", + "passed": bool( + handoff["expected_payload_row_count"] + and handoff["expected_payload_row_count"] + == inventory["payload_row_count"] + and handoff["payload_row_count"] == inventory["payload_row_count"] + and inventory["found_row_count"] == inventory["payload_row_count"] + ), + }, + { + "key": "candidate_queue_review_handoff_artifact_paths_safe", + "label": "review queue、inventory 與 handoff artifact paths 必須安全", + "passed": bool( + handoff["review_queue_artifact_path_safe"] + and handoff["inventory_artifact_path_safe"] + and handoff["handoff_artifact_path_safe"] + and handoff["inventory_artifact_path"] + == inventory["inventory_artifact_path"] + ), + }, + { + "key": "candidate_queue_review_handoff_scope_safe", + "label": "handoff 僅能交接到 manual candidate queue review", + "passed": bool( + handoff["review_scope"] == "candidate_queue_review" + and handoff["next_queue"] == "manual_candidate_queue_review" + ), + }, + { + "key": "candidate_queue_review_handoff_contract_valid", + "label": "review contract 必須鎖定 needs_review、必備欄位與人工操作", + "passed": contract_valid, + }, + { + "key": "candidate_queue_review_handoff_forbids_api_mutations", + "label": "review contract 必須禁止 API 更新 review_state 或補寫 queue row", + "passed": forbids_api_mutations, + }, + { + "key": "candidate_queue_review_handoff_operator_boundaries_confirmed", + "label": "操作員確認僅進人工 review,且 API 未執行 CLI/DB/query/file/scheduler", + "passed": operator_confirmed_boundaries, + }, + { + "key": "candidate_queue_review_handoff_no_api_execution_or_real_write", + "label": "handoff payload 不得允許 API execution、real write 或 API review update", + "passed": bool( + not handoff["api_execution_allowed"] + and not handoff["real_write_allowed_by_api"] + and not handoff["api_candidate_review_allowed"] + and not handoff["api_updates_review_state"] + ), + }, + { + "key": "candidate_queue_review_handoff_no_secret_or_token_key", + "label": "handoff payload 不得包含 secret、cookie、password 或 token key", + "passed": not handoff["secret_or_token_submitted_to_api"], + }, + { + "key": "candidate_queue_review_handoff_side_effect_free", + "label": "handoff payload 不得要求 API 寫檔、執行、查 DB、寫 DB 或掛 scheduler", + "passed": not handoff["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_queue_writer_review_handoff_preview( + *, + writer_post_closeout_inventory_review_package=None, + writer_post_closeout_inventory_review_result=None, + operator_handoff=None, + phase=None, +): + """建立 writer review handoff;不執行查詢、寫檔或寫入。""" + writer_post_closeout_inventory_review_package = _as_dict( + writer_post_closeout_inventory_review_package + ) + inventory_result_received = bool( + isinstance(writer_post_closeout_inventory_review_result, dict) + and writer_post_closeout_inventory_review_result + ) + handoff_valid_object = ( + isinstance(operator_handoff, dict) if operator_handoff is not None else True + ) + handoff_payload = _as_dict(operator_handoff) + inventory_received = bool( + writer_post_closeout_inventory_review_package or inventory_result_received + ) + inventory_result = ( + _inventory_review_from_inputs( + writer_post_closeout_inventory_review_package, + writer_post_closeout_inventory_review_result, + phase, + ) + if inventory_received + else {} + ) + payload_received = bool( + inventory_received or handoff_payload or operator_handoff is not None + ) + handoff_received = bool(handoff_payload) + inventory = _inventory_review_summary(inventory_result) + handoff = _operator_handoff_summary(handoff_payload) + gates = _handoff_gates( + inventory_received=inventory_received, + handoff_received=handoff_received and handoff_valid_object, + inventory=inventory, + handoff=handoff, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + if not handoff_valid_object: + blocked_reasons.append("operator_handoff_payload_valid_object") + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_review_handoff" + if payload_received + else "mcp_fetch_candidate_queue_writer_review_handoff_preview" + ), + "phase": phase, + "writer_review_handoff_payload_received": payload_received, + "review_handoff_payload_received": payload_received, + "writer_post_closeout_inventory_review_received": inventory_received, + "operator_handoff_received": handoff_received, + "operator_handoff_valid_object": handoff_valid_object, + "writer_post_closeout_inventory_review_accepted": inventory["accepted"], + "mcp_fetch_candidate_queue_writer_review_handoff_accepted": accepted, + "candidate_queue_writer_review_handoff_ready": accepted, + "ready_for_candidate_queue_review_inventory": accepted, + "ready_for_candidate_queue_human_review": accepted, + "ready_for_candidate_queue_review_decision": False, + "ready_for_api_database_write": False, + "ready_for_real_write": False, + "ready_for_scheduler_attach": False, + "ready_for_candidate_queue_review_api_update": False, + "ready_for_api_review_state_update": False, + "network_request_allowed": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_writes_file": False, + "api_uses_external_network": False, + "api_inventory_query_executed": False, + "api_candidate_review_update_executed": False, + "api_updates_review_state": False, + "post_closeout_query_executed_by_api": False, + "payload_row_count": handoff["payload_row_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "writer_post_closeout_inventory_review_summary": inventory, + "operator_handoff_summary": handoff, + "sample_writer_review_handoff_package": ( + build_sample_writer_review_handoff_package() + ), + "next_operator_steps": [ + "Handoff 通過後,只代表可交給人工 candidate queue review inventory", + "API/UI 仍不得自動寫 review state、補寫 queue row、讀 token 或掛 scheduler", + "後續 review 必須引用已審核 artifact,並保留人工決策紀錄與 false-positive 保護", + ], + "payload_persisted": False, + "review_handoff_persisted": False, + "writer_review_handoff_persisted": False, + "candidate_queue_review_handoff_persisted": False, + "candidate_queue_review_handoff_file_written": False, + "handoff_file_written": False, + "review_queue_file_written": False, + "candidate_review_file_written": False, + "package_artifact_created": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "cli_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + } diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff_sample.py b/services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff_sample.py new file mode 100644 index 0000000..54cd7be --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff_sample.py @@ -0,0 +1,105 @@ +"""Sample payload for the market intel candidate queue review handoff gate.""" + +from copy import deepcopy + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + ARTIFACT_PREFIX, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review import ( + build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview, +) + + +_SAMPLE_WRITER_REVIEW_HANDOFF_PACKAGE = None + + +def build_sample_writer_review_handoff_package(): + global _SAMPLE_WRITER_REVIEW_HANDOFF_PACKAGE + if _SAMPLE_WRITER_REVIEW_HANDOFF_PACKAGE is not None: + return deepcopy(_SAMPLE_WRITER_REVIEW_HANDOFF_PACKAGE) + + inventory_preview = ( + build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview() + ) + inventory_package = inventory_preview[ + "sample_writer_post_closeout_inventory_review_package" + ] + inventory_result = ( + build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview( + writer_run_closeout_review_package=inventory_package[ + "writer_run_closeout_review_package" + ], + writer_run_closeout_review_result=inventory_package[ + "writer_run_closeout_review_result" + ], + operator_inventory=inventory_package["operator_inventory"], + ) + ) + inventory = inventory_result["operator_inventory_summary"] + operator_handoff = { + "handoff_id": "market-intel-candidate-writer-review-handoff-sample", + "inventory_review_id": inventory["inventory_review_id"], + "closeout_id": inventory["closeout_id"], + "run_package_id": inventory["run_package_id"], + "receipt_id": inventory["receipt_id"], + "target_table": TARGET_TABLE, + "payload_row_count": inventory["payload_row_count"], + "expected_payload_row_count": inventory["payload_row_count"], + "expected_review_state": "needs_review", + "review_scope": "candidate_queue_review", + "next_queue": "manual_candidate_queue_review", + "review_queue_artifact_path": ( + ARTIFACT_PREFIX + + "candidate-queue-review-handoff-review-queue-sample.json" + ), + "inventory_artifact_path": inventory["inventory_artifact_path"], + "handoff_artifact_path": ( + ARTIFACT_PREFIX + + "candidate-queue-review-handoff-sample.json" + ), + "review_contract": { + "expected_review_state": "needs_review", + "required_columns": [ + "dedupe_key", + "review_state", + "momo_product_id", + "pchome_product_id", + ], + "allowed_manual_actions": [ + "mark_matched", + "mark_low_score", + "mark_identity_veto", + "request_fresh_search", + ], + "forbidden_api_actions": [ + "update_review_state", + "insert_missing_queue_row", + "execute_matching_decision", + ], + }, + "operator_confirmations": { + "inventory_reviewed": True, + "inventory_artifacts_preserved": True, + "candidate_queue_review_only": True, + "manual_review_only": True, + "manual_review_required": True, + "no_approval_token_payload": True, + "no_api_cli_execution": True, + "no_api_database_write": True, + "no_api_inventory_query": True, + "no_api_file_write": True, + "no_api_review_state_update": True, + "no_api_queue_insert": True, + "no_scheduler_attach": True, + }, + "api_execution_allowed": False, + "real_write_allowed_by_api": False, + "api_candidate_review_allowed": False, + } + _SAMPLE_WRITER_REVIEW_HANDOFF_PACKAGE = { + "writer_post_closeout_inventory_review_package": inventory_package, + "writer_post_closeout_inventory_review_result": inventory_result, + "operator_handoff": operator_handoff, + } + return deepcopy(_SAMPLE_WRITER_REVIEW_HANDOFF_PACKAGE) diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 9aa5ce1..ae5cb6b 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" +MARKET_INTEL_PHASE = "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 5b17f47..8e9fd76 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -1020,6 +1020,32 @@ +
+
+
+

MCP / REVIEW HANDOFF

+

MCP Candidate Queue Writer Review Handoff

+
+ +
+
+ loading +
+
+
讀取 MCP Writer Review Handoff 中...
+
+
+ +
+ +
+
+
+
@@ -1542,6 +1568,7 @@ const mcpFetchCandidateQueueWriterRunReceiptReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-receipt-review]'); const mcpFetchCandidateQueueWriterRunCloseoutReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review]'); const mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-post-closeout-inventory-review]'); + const mcpFetchCandidateQueueWriterReviewHandoffRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1558,7 +1585,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot && !mcpFetchCandidateQueueWriterReviewHandoffRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1713,6 +1740,12 @@ const mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewReview = mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot ? mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-post-closeout-inventory-review-review]') : null; const mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRefresh = mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot ? mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-post-closeout-inventory-review-refresh]') : null; const mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review') }}"; + const mcpFetchCandidateQueueWriterReviewHandoffMeta = mcpFetchCandidateQueueWriterReviewHandoffRoot ? mcpFetchCandidateQueueWriterReviewHandoffRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-meta]') : null; + const mcpFetchCandidateQueueWriterReviewHandoffBody = mcpFetchCandidateQueueWriterReviewHandoffRoot ? mcpFetchCandidateQueueWriterReviewHandoffRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-body]') : null; + const mcpFetchCandidateQueueWriterReviewHandoffInput = mcpFetchCandidateQueueWriterReviewHandoffRoot ? mcpFetchCandidateQueueWriterReviewHandoffRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-input]') : null; + const mcpFetchCandidateQueueWriterReviewHandoffReview = mcpFetchCandidateQueueWriterReviewHandoffRoot ? mcpFetchCandidateQueueWriterReviewHandoffRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-review]') : null; + const mcpFetchCandidateQueueWriterReviewHandoffRefresh = mcpFetchCandidateQueueWriterReviewHandoffRoot ? mcpFetchCandidateQueueWriterReviewHandoffRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-refresh]') : null; + const mcpFetchCandidateQueueWriterReviewHandoffEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_handoff') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -4941,6 +4974,131 @@ } }; + const renderMcpFetchCandidateQueueWriterReviewHandoffMeta = data => { + mcpFetchCandidateQueueWriterReviewHandoffMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_review_handoff_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || 0}`, + `inventory=${data.ready_for_candidate_queue_review_inventory ? 'ready' : 'blocked'}`, + `state=${data.api_updates_review_state ? 'api' : 'manual'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterReviewHandoffBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const inventory = data.writer_post_closeout_inventory_review_summary || {}; + const handoff = data.operator_handoff_summary || {}; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterReviewHandoffBody.innerHTML = ` +
此 review handoff 只把已通過的 post-closeout inventory 交接給人工 candidate queue review;API 不更新 review_state、不補寫 queue row、不讀 approval token、不執行 CLI、不掛 scheduler。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

HANDOFF GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 handoff gates。
' + }
+
+
+

INVENTORY LINK

+
+ ${renderCheck('inventory_review', `${inventory.accepted ? 'accepted' : 'pending'} / rows=${inventory.payload_row_count || 0}`, inventory.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('inventory_review_id', inventory.inventory_review_id || 'missing', inventory.inventory_review_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('found_rows', `${inventory.found_row_count || 0}/${inventory.payload_row_count || 0}`, inventory.found_row_count === inventory.payload_row_count ? 'MATCH' : 'BLOCK')} + ${renderCheck('api_boundary', 'no DB / no queue write / no review_state update / no scheduler', inventory.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

HANDOFF SUMMARY

+
+ ${renderCheck('handoff_id', handoff.handoff_id || 'missing', handoff.handoff_id ? 'RECORDED' : 'BLOCK')} + ${renderCheck('target_table', handoff.target_table || 'missing', handoff.target_table === 'market_alert_review_queue' ? 'SAFE' : 'BLOCK')} + ${renderCheck('review_scope', handoff.review_scope || 'missing', handoff.review_scope === 'candidate_queue_review' ? 'SAFE' : 'BLOCK')} + ${renderCheck('next_queue', handoff.next_queue || 'missing', handoff.next_queue === 'manual_candidate_queue_review' ? 'MANUAL' : 'BLOCK')} + ${renderCheck('row_count', String(handoff.payload_row_count || 0), handoff.payload_row_count === inventory.payload_row_count ? 'MATCH' : 'BLOCK')} +
+
+
+

REVIEW CONTRACT

+
+ ${renderCheck('review_queue_artifact_path', handoff.review_queue_artifact_path || 'missing', handoff.review_queue_artifact_path_safe ? 'SAFE' : 'BLOCK')} + ${renderCheck('inventory_artifact_path', handoff.inventory_artifact_path || 'missing', handoff.inventory_artifact_path_safe ? 'SAFE' : 'BLOCK')} + ${renderCheck('handoff_artifact_path', handoff.handoff_artifact_path || 'missing', handoff.handoff_artifact_path_safe ? 'SAFE' : 'BLOCK')} + ${renderCheck('operator_boundaries', 'manual only / no API DB query/write/file/CLI/scheduler', handoff.inventory_reviewed && handoff.inventory_artifacts_preserved && handoff.candidate_queue_review_only && handoff.manual_review_required && handoff.no_api_database_write && handoff.no_api_inventory_query && handoff.no_api_cli_execution && handoff.no_api_file_write && handoff.no_scheduler_attach ? 'CONFIRMED' : 'BLOCK')} +
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck('api_side_effects', 'no review_state update / no DB write / no queue write / no scheduler', data.api_updates_review_state || data.api_writes_database || data.candidate_queue_persisted || data.scheduler_attached ? 'BLOCK' : 'CLOSED')} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterReviewHandoffInput && !mcpFetchCandidateQueueWriterReviewHandoffInput.value.trim() && data.sample_writer_review_handoff_package) { + mcpFetchCandidateQueueWriterReviewHandoffInput.value = JSON.stringify(data.sample_writer_review_handoff_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterReviewHandoff = async () => { + if (!mcpFetchCandidateQueueWriterReviewHandoffMeta || !mcpFetchCandidateQueueWriterReviewHandoffBody) return; + mcpFetchCandidateQueueWriterReviewHandoffBody.innerHTML = '
讀取 MCP Writer Review Handoff 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterReviewHandoffEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterReviewHandoffMeta(data); + renderMcpFetchCandidateQueueWriterReviewHandoffBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterReviewHandoffMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterReviewHandoffBody.innerHTML = `
MCP Writer Review Handoff 讀取失敗:${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterReviewHandoff = async () => { + if (!mcpFetchCandidateQueueWriterReviewHandoffMeta || !mcpFetchCandidateQueueWriterReviewHandoffBody || !mcpFetchCandidateQueueWriterReviewHandoffInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterReviewHandoffInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterReviewHandoffMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterReviewHandoffBody.innerHTML = `
JSON 格式錯誤:${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterReviewHandoffBody.innerHTML = '
審核 MCP Writer Review Handoff 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterReviewHandoffEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_review_handoff_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterReviewHandoffMeta(data); + renderMcpFetchCandidateQueueWriterReviewHandoffBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterReviewHandoffMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterReviewHandoffBody.innerHTML = `
MCP Writer Review Handoff 審核失敗:${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -14452,6 +14610,12 @@ if (mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewReview) { mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterPostCloseoutInventoryReview); } + if (mcpFetchCandidateQueueWriterReviewHandoffRefresh) { + mcpFetchCandidateQueueWriterReviewHandoffRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterReviewHandoff); + } + if (mcpFetchCandidateQueueWriterReviewHandoffReview) { + mcpFetchCandidateQueueWriterReviewHandoffReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterReviewHandoff); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -14724,6 +14888,7 @@ loadMcpFetchCandidateQueueWriterRunReceiptReview(); loadMcpFetchCandidateQueueWriterRunCloseoutReview(); loadMcpFetchCandidateQueueWriterPostCloseoutInventoryReview(); + loadMcpFetchCandidateQueueWriterReviewHandoff(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 9b1e51e..0a079df 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -59,6 +59,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review from services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review import ( build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff import ( + build_mcp_fetch_candidate_queue_writer_review_handoff_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1232,6 +1235,34 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-post-closeout-inventory-review-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_handoff" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-inventory" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-handoff" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-contract" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1702,7 +1733,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert bridge["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1860,7 +1891,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert contract["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1993,7 +2024,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -2006,7 +2037,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert gate["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -2076,7 +2107,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -2090,7 +2121,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert audit["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -2164,7 +2195,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -2181,11 +2212,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert evidence["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2210,7 +2241,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2268,12 +2299,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2282,11 +2313,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert receipt["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2314,7 +2345,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2379,12 +2410,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2393,11 +2424,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert promotion["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2425,7 +2456,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2485,12 +2516,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2499,11 +2530,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert handoff["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2531,7 +2562,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2593,12 +2624,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2609,11 +2640,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert review["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2643,7 +2674,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2721,13 +2752,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2739,11 +2770,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert package["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2775,7 +2806,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2850,13 +2881,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2870,11 +2901,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert readiness["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2909,11 +2940,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert readiness["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2989,13 +3020,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -3009,11 +3040,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert receipt["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -3050,11 +3081,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert receipt["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -3133,13 +3164,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3155,11 +3186,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert parser["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3198,11 +3229,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert parser["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3287,13 +3318,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3309,11 +3340,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert handoff["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3352,11 +3383,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert handoff["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3446,13 +3477,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3469,11 +3500,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert review["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3510,11 +3541,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert review["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3605,13 +3636,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert get_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert post_data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3627,13 +3658,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3671,13 +3702,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3781,7 +3812,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3790,7 +3821,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3806,13 +3837,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( review["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert review["writer_cli_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False @@ -3848,13 +3879,13 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): writer_preflight_package=sample["writer_preflight_package"], writer_preflight_result=sample["writer_preflight_result"], writer_cli_review=sample["writer_cli_review"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( review["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert review["candidate_queue_writer_cli_review_ready"] is True @@ -3955,7 +3986,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -3964,7 +3995,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True @@ -3981,7 +4012,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == ( @@ -3989,7 +4020,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_wit ) assert ( review["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert review["writer_run_package_review_payload_received"] is False assert ( @@ -4039,13 +4070,13 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_accepts_sample_revi writer_cli_review_package=sample["writer_cli_review_package"], writer_cli_review_result=sample["writer_cli_review_result"], writer_run_package_review=sample["writer_run_package_review"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_run_package_review" assert ( review["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4169,7 +4200,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4181,7 +4212,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4201,7 +4232,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert readiness["mode"] == ( @@ -4209,7 +4240,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_ ) assert ( readiness["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert readiness["writer_run_readiness_payload_received"] is False assert ( @@ -4255,13 +4286,13 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_accepts_sample_review(): ], writer_run_package_review_result=sample["writer_run_package_review_result"], operator_readiness=sample["operator_readiness"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert readiness["mode"] == "mcp_fetch_candidate_queue_writer_run_readiness_review" assert ( readiness["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4377,7 +4408,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4389,7 +4420,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4409,7 +4440,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_without_payload(): receipt = build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert receipt["mode"] == ( @@ -4417,7 +4448,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_wit ) assert ( receipt["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert receipt["writer_run_receipt_review_payload_received"] is False assert ( @@ -4462,13 +4493,13 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_accepts_sample_revi writer_run_readiness_package=sample["writer_run_readiness_package"], writer_run_readiness_result=sample["writer_run_readiness_result"], writer_run_receipt=sample["writer_run_receipt"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert receipt["mode"] == "mcp_fetch_candidate_queue_writer_run_receipt_review" assert ( receipt["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( receipt["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4600,7 +4631,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4612,7 +4643,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4632,7 +4663,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_without_payload(): closeout = build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert closeout["mode"] == ( @@ -4640,7 +4671,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_wi ) assert ( closeout["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert closeout["writer_run_closeout_review_payload_received"] is False assert ( @@ -4693,13 +4724,13 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_accepts_sample_rev ], writer_run_receipt_review_result=sample["writer_run_receipt_review_result"], operator_closeout=sample["operator_closeout"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) assert closeout["mode"] == "mcp_fetch_candidate_queue_writer_run_closeout_review" assert ( closeout["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( closeout["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] @@ -4840,7 +4871,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post ) assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4852,7 +4883,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post ) assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] @@ -4876,7 +4907,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview_is_safe_without_payload(): inventory = ( build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview( - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) ) @@ -4885,7 +4916,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview ) assert ( inventory["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert inventory["post_closeout_inventory_review_payload_received"] is False assert ( @@ -4941,7 +4972,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepts "writer_run_closeout_review_result" ], operator_inventory=sample["operator_inventory"], - phase="phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review", + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", ) ) @@ -4951,7 +4982,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepts ) assert ( inventory["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( inventory[ @@ -5101,7 +5132,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g ) assert ( get_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5114,7 +5145,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g ) assert ( post_data["phase"] - == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert ( post_data[ @@ -5135,11 +5166,264 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g assert post_data["api_opens_database_connection"] is False +def test_mcp_fetch_candidate_queue_writer_review_handoff_preview_is_safe_without_payload(): + handoff = build_mcp_fetch_candidate_queue_writer_review_handoff_preview( + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", + ) + + assert handoff["mode"] == ( + "mcp_fetch_candidate_queue_writer_review_handoff_preview" + ) + assert ( + handoff["phase"] + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" + ) + assert handoff["review_handoff_payload_received"] is False + assert ( + handoff["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] + is False + ) + assert handoff["candidate_queue_writer_review_handoff_ready"] is False + assert handoff["ready_for_candidate_queue_human_review"] is False + assert handoff["ready_for_candidate_queue_review_decision"] is False + assert handoff["ready_for_api_review_state_update"] is False + assert handoff["ready_for_api_database_write"] is False + assert handoff["ready_for_real_write"] is False + assert handoff["ready_for_scheduler_attach"] is False + assert handoff["network_request_allowed"] is False + assert handoff["api_executes_cli"] is False + assert handoff["api_reads_approval_token"] is False + assert handoff["api_writes_database"] is False + assert handoff["api_updates_review_state"] is False + assert handoff["payload_persisted"] is False + assert handoff["review_handoff_persisted"] is False + assert handoff["handoff_file_written"] is False + assert handoff["database_write_executed"] is False + assert handoff["database_commit_executed"] is False + assert handoff["candidate_review_state_updated"] is False + assert handoff["scheduler_attached"] is False + assert ( + "post_closeout_inventory_review_payload_or_result_received" + in handoff["blocked_reasons"] + ) + assert "candidate_queue_review_handoff_payload_received" in handoff[ + "blocked_reasons" + ] + assert "operator_handoff" in handoff["sample_writer_review_handoff_package"] + + +def test_mcp_fetch_candidate_queue_writer_review_handoff_accepts_sample_review(): + sample = build_mcp_fetch_candidate_queue_writer_review_handoff_preview()[ + "sample_writer_review_handoff_package" + ] + handoff = build_mcp_fetch_candidate_queue_writer_review_handoff_preview( + writer_post_closeout_inventory_review_package=sample[ + "writer_post_closeout_inventory_review_package" + ], + writer_post_closeout_inventory_review_result=sample[ + "writer_post_closeout_inventory_review_result" + ], + operator_handoff=sample["operator_handoff"], + phase="phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff", + ) + + assert handoff["mode"] == "mcp_fetch_candidate_queue_writer_review_handoff" + assert ( + handoff["phase"] + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" + ) + assert ( + handoff["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] + is True + ) + assert handoff["candidate_queue_writer_review_handoff_ready"] is True + assert handoff["ready_for_candidate_queue_human_review"] is True + assert handoff["ready_for_candidate_queue_review_decision"] is False + assert handoff["ready_for_api_review_state_update"] is False + assert handoff["ready_for_api_database_write"] is False + assert handoff["ready_for_real_write"] is False + assert handoff["blocked_reasons"] == [] + assert handoff["passed_gate_count"] == handoff["gate_count"] + assert handoff["writer_post_closeout_inventory_review_accepted"] is True + inventory = handoff["writer_post_closeout_inventory_review_summary"] + summary = handoff["operator_handoff_summary"] + assert inventory["target_table"] == "market_alert_review_queue" + assert summary["target_table"] == "market_alert_review_queue" + assert summary["inventory_review_id"] == inventory["inventory_review_id"] + assert summary["run_package_id"] == inventory["run_package_id"] + assert summary["receipt_id"] == inventory["receipt_id"] + assert summary["closeout_id"] == inventory["closeout_id"] + assert summary["expected_payload_row_count"] == inventory["payload_row_count"] + assert summary["expected_review_state"] == "needs_review" + assert summary["contract_expected_review_state"] == "needs_review" + assert summary["handoff_artifact_path_safe"] is True + assert "update_review_state" in summary["forbidden_api_actions"] + assert "insert_missing_queue_row" in summary["forbidden_api_actions"] + assert "review_state" in summary["required_columns"] + assert summary["secret_or_token_submitted_to_api"] is False + assert handoff["network_request_allowed"] is False + assert handoff["api_executes_cli"] is False + assert handoff["api_reads_approval_token"] is False + assert handoff["api_writes_file"] is False + assert handoff["api_writes_database"] is False + assert handoff["api_updates_review_state"] is False + assert handoff["candidate_queue_persisted"] is False + assert handoff["candidate_review_state_updated"] is False + assert handoff["database_write_executed"] is False + assert handoff["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_review_handoff_blocks_unsafe_review(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_review_handoff_preview()[ + "sample_writer_review_handoff_package" + ] + ) + ) + handoff_payload = sample["operator_handoff"] + handoff_payload["inventory_review_id"] = "wrong-inventory" + handoff_payload["closeout_id"] = "wrong-closeout" + handoff_payload["run_package_id"] = "wrong-package" + handoff_payload["receipt_id"] = "wrong-receipt" + handoff_payload["target_table"] = "market_campaign_products" + handoff_payload["expected_payload_row_count"] = 999 + handoff_payload["expected_review_state"] = "confirmed" + handoff_payload["handoff_artifact_path"] = "/tmp/unsafe.json" + handoff_payload["approval_token"] = TEST_APPROVAL_TOKEN + handoff_payload["api_execution_allowed"] = True + handoff_payload["real_write_allowed_by_api"] = True + handoff_payload["api_updates_review_state"] = True + handoff_payload["database_write_executed_by_api"] = True + handoff_payload["review_contract"]["expected_review_state"] = "confirmed" + handoff_payload["review_contract"]["forbidden_api_actions"] = ["dispatch_alert"] + handoff_payload["review_contract"]["required_columns"] = ["dedupe_key"] + handoff_payload["operator_confirmations"]["manual_review_only"] = False + handoff_payload["operator_confirmations"]["no_api_review_state_update"] = False + + handoff = build_mcp_fetch_candidate_queue_writer_review_handoff_preview( + writer_post_closeout_inventory_review_package=sample[ + "writer_post_closeout_inventory_review_package" + ], + writer_post_closeout_inventory_review_result=sample[ + "writer_post_closeout_inventory_review_result" + ], + operator_handoff=handoff_payload, + ) + + assert ( + handoff["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] + is False + ) + assert handoff["writer_post_closeout_inventory_review_accepted"] is True + assert ( + "candidate_queue_review_handoff_identity_matches_inventory" + in handoff["blocked_reasons"] + ) + assert "candidate_queue_review_handoff_target_table_safe" in handoff[ + "blocked_reasons" + ] + assert "candidate_queue_review_handoff_row_count_matches_inventory" in handoff[ + "blocked_reasons" + ] + assert "candidate_queue_review_handoff_artifact_paths_safe" in handoff[ + "blocked_reasons" + ] + assert "candidate_queue_review_handoff_contract_valid" in handoff[ + "blocked_reasons" + ] + assert "candidate_queue_review_handoff_forbids_api_mutations" in handoff[ + "blocked_reasons" + ] + assert ( + "candidate_queue_review_handoff_operator_boundaries_confirmed" + in handoff["blocked_reasons"] + ) + assert "candidate_queue_review_handoff_no_api_execution_or_real_write" in handoff[ + "blocked_reasons" + ] + assert "candidate_queue_review_handoff_no_secret_or_token_key" in handoff[ + "blocked_reasons" + ] + assert "candidate_queue_review_handoff_side_effect_free" in handoff[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + handoff, + ensure_ascii=False, + sort_keys=True, + ) + assert handoff["api_executes_cli"] is False + assert handoff["api_reads_approval_token"] is False + assert handoff["api_writes_database"] is False + assert handoff["api_updates_review_state"] is False + assert handoff["candidate_review_state_updated"] is False + assert handoff["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_review_handoff_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff", + json={"writer_review_handoff_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == ( + "mcp_fetch_candidate_queue_writer_review_handoff_preview" + ) + assert ( + get_data["phase"] + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_updates_review_state"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_handoff" + assert ( + post_data["phase"] + == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" + ) + assert ( + post_data["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] + is True + ) + assert post_data["ready_for_candidate_queue_human_review"] is True + assert post_data["ready_for_api_review_state_update"] is False + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["api_updates_review_state"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["candidate_review_state_updated"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -5187,7 +5471,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -5198,7 +5482,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert acceptance["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -5240,7 +5524,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -5252,7 +5536,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert review["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -5363,7 +5647,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -5402,7 +5686,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert review["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -5464,7 +5748,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -5544,7 +5828,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert handoff["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -5608,7 +5892,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -5667,7 +5951,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert queue_draft["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -5741,7 +6025,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -5804,7 +6088,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert approval["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -5882,7 +6166,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -5945,7 +6229,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert transaction["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -6025,7 +6309,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -11736,7 +12020,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -11811,7 +12095,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -12083,7 +12367,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -12371,7 +12655,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -12681,7 +12965,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -12984,7 +13268,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -13243,7 +13527,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -13516,7 +13800,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -13764,7 +14048,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -13994,7 +14278,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -14231,7 +14515,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -14473,7 +14757,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -14749,7 +15033,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -15026,7 +15310,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -15305,7 +15589,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -15634,7 +15918,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -15896,7 +16180,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -16160,7 +16444,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -16430,7 +16714,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -16718,7 +17002,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -17005,7 +17289,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -17091,7 +17375,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -17148,7 +17432,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -17237,7 +17521,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -17291,7 +17575,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -17347,7 +17631,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -17413,7 +17697,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -17715,7 +17999,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -17763,7 +18047,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -17812,7 +18096,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -17870,7 +18154,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -17936,7 +18220,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -18007,7 +18291,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -18083,7 +18367,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -18165,7 +18449,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -18251,7 +18535,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -18334,7 +18618,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -18417,7 +18701,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -18503,7 +18787,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -18594,7 +18878,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -18704,7 +18988,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -18790,7 +19074,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -18847,7 +19131,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -18900,7 +19184,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -18953,7 +19237,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -19014,7 +19298,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -19083,7 +19367,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -19155,7 +19439,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -19228,7 +19512,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -19299,7 +19583,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -19364,7 +19648,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -19435,7 +19719,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -19508,7 +19792,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -19585,7 +19869,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -19662,7 +19946,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -19739,7 +20023,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -19813,7 +20097,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -19892,7 +20176,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -19979,7 +20263,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -20060,7 +20344,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -20142,7 +20426,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -20225,7 +20509,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -20250,7 +20534,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -20288,7 +20572,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -20299,7 +20583,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -20335,7 +20619,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -20346,7 +20630,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -20387,7 +20671,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -20398,7 +20682,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -20446,7 +20730,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -20458,7 +20742,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -20504,7 +20788,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -20517,7 +20801,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert plan["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -20602,7 +20886,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -20680,7 +20964,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -20695,7 +20979,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert readiness["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -21136,6 +21420,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_review_handoff_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -21519,6 +21809,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff" + in readiness["production_smoke_targets"] + ) assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -25560,7 +25854,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert drill["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -25675,7 +25969,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -25687,7 +25981,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert review["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -25802,7 +26096,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -25815,7 +26109,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert smoke["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -25877,7 +26171,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -25890,7 +26184,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert inventory["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -26034,7 +26328,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -26270,7 +26564,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -26299,7 +26593,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_134_market_intel_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review" + assert data["phase"] == "phase_135_market_intel_mcp_fetch_candidate_queue_writer_review_handoff" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False