diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 8590814..1b6b3d2 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.495 新增市場情報 MCP Fetch Candidate Queue Writer Preflight 安全預覽 gate:只審核 queue review 後的 writer preflight 草案,確認 target_table、write_mode、dedupe strategy、insert columns、payload rows 與候選 key 對齊;API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - V10.494 新增市場情報 MCP Fetch Candidate Queue Review 安全預覽 gate:只審核 candidate handoff 後的人工 queue review 草案,要求候選 key 對齊、review_state 停在 needs_review、allowed actions 限定人工確認/否決/延後、queue_write_status 維持 not_persisted;API 不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - V10.493 新增市場情報 MCP Fetch Candidate Handoff Review 安全預覽 gate:只審核 parser review 後的候選交接包,確認 source/candidate key 對齊、queue policy 仍是 manual preview、候選數維持小批次、無 raw/secret/side-effect;API 不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 - V10.492 收緊 PChome 近門檻自動回刷隊列:`retryable_candidate_revalidation` 不再把 `identity_veto`、`unit_comparable`、`true_low_confidence` 納入每日自動回刷;只處理 `recoverable_low_score` 與 legacy `low_score / refresh_low_score`,並要求無 hard veto、仍在 `exact_identity`、且具備同品線/identity anchor 證據。這讓「可救回」與「正確阻擋」在操作層面真正分流,避免為了壓低 low_score 而重跑不該自動推進的候選。 diff --git a/config.py b/config.py index 7751e96..ba664cc 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.494" +SYSTEM_VERSION = "V10.495" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 2016173..be46888 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -166,6 +166,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch result parser review gate:`services.market_intel.mcp_fetch_result_parser_review` 與 `/api/market_intel/mcp_fetch_result_parser_review` 在 receipt 通過後審核操作員貼回的 parser 結構化摘要,檢查 receipt source/receipt path 對帳、parser artifact path、活動/商品候選必要欄位、公開 URL、小批次候選上限、raw HTML/secret 外洩與 API/DB/scheduler 副作用旗標;API/UI 不讀 artifact、不執行 parser CLI、不發外部 request、不保存 parser result、不寫入、不掛 scheduler,只放行到候選 handoff review。 - 2026-05-31 追加 MCP fetch candidate handoff review gate:`services.market_intel.mcp_fetch_candidate_handoff_review` 與 `/api/market_intel/mcp_fetch_candidate_handoff_review` 在 parser review 通過後審核候選交接包,檢查 source/candidate key 對齊、queue policy 是否仍是 `manual_candidate_review` / `preview_only`、小批次候選上限、操作員無寫入/無連外/無排程確認、raw HTML/secret 外洩與 side-effect flags;API/UI 不建立 queue、不讀 artifact、不寫 DB、不掛 scheduler,只放行到人工 candidate queue review。 - 2026-05-31 追加 MCP fetch candidate queue review gate:`services.market_intel.mcp_fetch_candidate_queue_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_review` 在 handoff review 通過後審核人工 queue review 草案,檢查候選 key 對齊、`review_state=needs_review`、allowed actions 人工限定、`queue_write_status=not_persisted`、操作員無寫入/無連外/無排程確認、raw HTML/secret 外洩與 side-effect flags;API/UI 不建立 queue、不更新 review_state、不讀 artifact、不寫 DB、不掛 scheduler,只放行到 writer preflight。 +- 2026-05-31 追加 MCP fetch candidate queue writer preflight gate:`services.market_intel.mcp_fetch_candidate_queue_writer_preflight` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 在 queue review 通過後審核 writer preflight 草案,檢查 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows、候選 key 對齊、小批次上限、操作員無寫入/無連外/無 CLI/無排程確認、raw HTML/secret 外洩與 side-effect flags;API/UI 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不掛 scheduler,只放行到 CLI writer review。 - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index dff34d0..51c44e8 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -43,6 +43,8 @@ - 2026-05-24 追記:同步市場情報 MCP fetch run package gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增 endpoint 已拆到 `routes/market_intel_mcp_run_routes.py`,主 Blueprint 只新增 extension import,後續 MCP route 應延續此模式。 - 2026-05-24 追記:同步市場情報 MCP fetch run readiness gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 endpoint 延續 `routes/market_intel_mcp_run_routes.py` route extension,新增邏輯放在獨立 `services/market_intel/mcp_fetch_run_readiness.py`。 - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue review gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增邏輯維持在獨立 `services/market_intel/mcp_fetch_candidate_queue_review.py`,route 延續 `routes/market_intel_mcp_run_routes.py` extension。 +- 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer preflight gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增邏輯維持在獨立 `services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py`,route 延續 `routes/market_intel_mcp_run_routes.py` extension。 +- 2026-05-31 追記:`services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py` 目前 628 行,略過 600 行提醒門檻;暫不拆分的理由是 gate 條件、sample payload 與 side-effect blocklist 需留在單一 preview module 便於審核,下一個 writer CLI review gate 若共用相同常數再抽 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-24 追記:同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數;此處只更新 inventory,不變更 Code Review 行為。 - 2026-05-21 追記:同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 @@ -95,7 +97,7 @@ | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | | 917 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 1181 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 1219 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index 0cde6d3..63d9ca4 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -90,6 +90,7 @@ - 2026-05-31 起,`V10.492` 收緊 PChome 近門檻自動回刷:`run_retryable_candidate_revalidation()` 只回刷 `recoverable_low_score` 與 legacy `low_score / refresh_low_score`,且 SQL 端要求 `hard_veto=false`、`comparison_mode=exact_identity`、diagnostic reasons 命中同品線/identity anchor;`identity_veto`、`unit_comparable`、`true_low_confidence` 不再進每日自動回刷隊列,需等待新證據或人工處理。 - 2026-05-31 起,`V10.493` 新增市場情報 MCP Fetch Candidate Handoff Review gate:在 parser review 通過後只審核候選交接包,要求 source/candidate key 完全對齊、queue policy 維持 manual preview、小批次上限與操作員無寫入/無連外/無排程確認;仍不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 - 2026-05-31 起,`V10.494` 新增市場情報 MCP Fetch Candidate Queue Review gate:在 handoff review 通過後只審核人工 queue review 草案,要求候選 key 完全對齊、review_state 只停在 `needs_review`、allowed actions 限人工操作、queue_write_status 維持 `not_persisted`;仍不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 +- 2026-05-31 起,`V10.495` 新增市場情報 MCP Fetch Candidate Queue Writer Preflight gate:在 queue review 通過後只審核 writer preflight 草案,要求 target table、write mode、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊;仍不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index a6bda9a..cecbf94 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24:PChome 近門檻身份回收第二輪 +- **V10.495 市場情報 MCP Fetch Candidate Queue Writer Preflight gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 與 UI preview,只審核 queue review 後的 writer preflight 草案;要求 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊,且 API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - **V10.494 市場情報 MCP Fetch Candidate Queue Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_review` 與 UI preview,只審核 candidate handoff 後的人工 queue review 草案;要求候選 key 完全對齊、`review_state=needs_review`、allowed actions 限人工確認/否決/延後、`queue_write_status=not_persisted`,且 API 不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - **V10.493 市場情報 MCP Fetch Candidate Handoff Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_handoff_review` 與 UI preview,只審核 parser review 後的候選交接包;要求 source/candidate key 完全對齊、queue policy 維持 `manual_candidate_review` / `preview_only`、候選數維持小批次,且 API 不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 - **V10.491 市場情報 MCP Fetch Result Parser Review gate**: 新增 `/api/market_intel/mcp_fetch_result_parser_review` 與 UI preview,只審核操作員 shell parser 後貼回的結構化摘要;API 不讀 artifact、不執行 parser CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,且會阻擋 raw HTML/body/snapshot、secret/token 欄位與 side-effect flags。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index 47bb264..aefbd64 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -25,6 +25,9 @@ from services.market_intel.mcp_fetch_candidate_handoff_review import ( from services.market_intel.mcp_fetch_candidate_queue_review import ( build_mcp_fetch_candidate_queue_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( + build_mcp_fetch_candidate_queue_writer_preflight_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -250,3 +253,48 @@ def market_intel_mcp_fetch_candidate_queue_review(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_preflight", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_preflight(): + queue_review_package = {} + queue_review_result = None + writer_preflight = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_preflight_review") + or payload.get("candidate_queue_writer_preflight") + or payload.get("writer_preflight") + or payload + ) + queue_review_package = ( + package.get("queue_review_package") + or package.get("candidate_queue_review") + or package.get("queue_review") + or {} + ) + queue_review_result = ( + package.get("queue_review_result") + or package.get("mcp_fetch_candidate_queue_review") + ) + writer_preflight = ( + package.get("writer_preflight") + or package.get("candidate_queue_writer_preflight") + or package.get("preflight") + or package.get("preflight_payload") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_preflight_preview( + queue_review_package=queue_review_package, + queue_review_result=queue_review_result, + writer_preflight=writer_preflight, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 8e3b067..9f4818c 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -81,6 +81,9 @@ from services.market_intel.mcp_fetch_candidate_handoff_review import ( from services.market_intel.mcp_fetch_candidate_queue_review import ( build_mcp_fetch_candidate_queue_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( + build_mcp_fetch_candidate_queue_writer_preflight_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -213,6 +216,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_candidate_queue_review",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_preflight",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -262,6 +270,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_preflight = ( + build_mcp_fetch_candidate_queue_writer_preflight_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -785,6 +798,30 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not candidate_queue_writer_preflight["database_commit_executed"] and not candidate_queue_writer_preflight["scheduler_attached"] ), + "mcp_fetch_candidate_queue_writer_preflight_preview_safe": bool( + mcp_fetch_candidate_queue_writer_preflight["mode"] + == "mcp_fetch_candidate_queue_writer_preflight_preview" + and not mcp_fetch_candidate_queue_writer_preflight["payload_persisted"] + and not mcp_fetch_candidate_queue_writer_preflight["preflight_persisted"] + and not mcp_fetch_candidate_queue_writer_preflight["candidate_queue_created"] + and not mcp_fetch_candidate_queue_writer_preflight["candidate_queue_persisted"] + and not mcp_fetch_candidate_queue_writer_preflight["candidate_review_state_updated"] + and not mcp_fetch_candidate_queue_writer_preflight["network_request_allowed"] + and not mcp_fetch_candidate_queue_writer_preflight["api_executes_cli"] + and not mcp_fetch_candidate_queue_writer_preflight[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_preflight["api_writes_database"] + and not mcp_fetch_candidate_queue_writer_preflight[ + "api_uses_external_network" + ] + and not mcp_fetch_candidate_queue_writer_preflight[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_preflight["cli_executed"] + and not mcp_fetch_candidate_queue_writer_preflight["file_written"] + and not mcp_fetch_candidate_queue_writer_preflight["scheduler_attached"] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1104,6 +1141,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_result_parser_review": mcp_fetch_result_parser_review, "mcp_fetch_candidate_handoff_review": mcp_fetch_candidate_handoff_review, "mcp_fetch_candidate_queue_review": mcp_fetch_candidate_queue_review, + "mcp_fetch_candidate_queue_writer_preflight": mcp_fetch_candidate_queue_writer_preflight, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py b/services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py new file mode 100644 index 0000000..c808aa5 --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py @@ -0,0 +1,628 @@ +"""市場情報 MCP fetch candidate queue writer preflight preview。 + +本模組只審核 candidate queue review 後的 writer preflight 草案; +不開 DB、不建立 transaction、不執行 CLI、不寫 queue、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_candidate_queue_review import ( + build_mcp_fetch_candidate_queue_review_preview, +) + + +TARGET_TABLE = "market_alert_review_queue" +MAX_PREFLIGHT_ITEMS = 80 +SAFE_PREFLIGHT_MODES = {"candidate_queue_writer_preflight_preview"} +SAFE_WRITE_MODES = {"cli_only_later"} +SAFE_DEDUPE_STRATEGIES = {"candidate_type_platform_source_key"} +REQUIRED_INSERT_COLUMNS = ( + "candidate_type", + "platform_code", + "source_key", + "candidate_key", + "candidate_name", + "candidate_url", + "review_state", + "priority_lane", + "evidence_ref", +) + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "secret", + "session_cookie", + "token", +) + +SAFE_SECRET_METADATA_KEYS = { + "operator_confirmed_no_secret_payload", +} + +FORBIDDEN_RAW_PAYLOAD_KEYS = ( + "body_html", + "document_html", + "html", + "page_html", + "raw_body", + "raw_html", + "raw_snapshot", + "response_body", +) + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_executed_cli", + "api_executes_cli", + "api_executes_docker", + "api_executes_health_check", + "api_executes_ssh", + "api_opens_database_connection", + "api_uses_external_network", + "api_writes_database", + "attach_scheduler", + "candidate_queue_created", + "candidate_queue_persisted", + "candidate_review_state_updated", + "cli_executed", + "command_executed", + "database_commit_executed", + "database_session_created", + "database_write_executed", + "external_network_executed", + "file_written", + "network_request_allowed", + "payload_persisted", + "preflight_persisted", + "scheduler_attached", + "write_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _contains_forbidden_key(value, forbidden_keys, *, safe_keys=None): + safe_keys = safe_keys or set() + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in safe_keys and isinstance(nested, bool): + continue + if any(forbidden_key in normalized_key for forbidden_key in forbidden_keys): + return True + if _contains_forbidden_key(nested, forbidden_keys, safe_keys=safe_keys): + return True + elif isinstance(value, list): + return any( + _contains_forbidden_key(item, forbidden_keys, safe_keys=safe_keys) + for item in value + ) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _queue_review_from_inputs(queue_review_package, queue_review_result, phase): + if isinstance(queue_review_result, dict) and queue_review_result: + return queue_review_result + + queue_review_package = _as_dict(queue_review_package) + return build_mcp_fetch_candidate_queue_review_preview( + handoff_review_package=( + queue_review_package.get("handoff_review_package") + or queue_review_package.get("candidate_handoff_review") + or queue_review_package.get("handoff_review") + ), + handoff_review_result=( + queue_review_package.get("handoff_review_result") + or queue_review_package.get("mcp_fetch_candidate_handoff_review") + ), + candidate_queue_review=( + queue_review_package.get("candidate_queue_review") + or queue_review_package.get("queue_review") + or queue_review_package.get("review_payload") + ), + phase=phase, + ) + + +def _sample_writer_preflight_package(): + queue_preview = build_mcp_fetch_candidate_queue_review_preview() + queue_review_package = queue_preview["sample_candidate_queue_review_package"] + queue_review_result = build_mcp_fetch_candidate_queue_review_preview( + handoff_review_package=queue_review_package["handoff_review_package"], + handoff_review_result=queue_review_package["handoff_review_result"], + candidate_queue_review=queue_review_package["candidate_queue_review"], + ) + review_summary = queue_review_result["candidate_queue_review_summary"] + items = review_summary.get("review_items", []) + payload_rows = [] + for item in items: + payload_rows.append( + { + "candidate_type": item.get("candidate_type"), + "platform_code": item.get("platform_code"), + "source_key": item.get("source_key"), + "candidate_key": item.get("candidate_key"), + "candidate_name": item.get("candidate_name"), + "candidate_url": item.get("candidate_url"), + "review_state": item.get("review_state"), + "priority_lane": item.get("priority_lane"), + "evidence_ref": item.get("evidence_ref"), + "dedupe_key": ( + f"{item.get('candidate_type')}::" + f"{item.get('platform_code')}::" + f"{item.get('source_key')}::" + f"{item.get('candidate_key')}" + ), + } + ) + + return { + "queue_review_package": queue_review_package, + "queue_review_result": queue_review_result, + "writer_preflight": { + "preflight_id": "market-intel-candidate-writer-preflight-sample", + "preflight_mode": "candidate_queue_writer_preflight_preview", + "target_table": TARGET_TABLE, + "write_mode": "cli_only_later", + "dedupe_strategy": "candidate_type_platform_source_key", + "insert_columns": list(REQUIRED_INSERT_COLUMNS), + "operator_confirmed_no_database_write": True, + "operator_confirmed_no_external_network": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_cli_execution": True, + "operator_confirmed_no_persistence": True, + "operator_confirmed_no_secret_payload": True, + "summary": { + "payload_row_count": len(payload_rows), + "campaign_candidate_count": review_summary.get( + "campaign_candidate_count", + 0, + ), + "product_candidate_count": review_summary.get( + "product_candidate_count", + 0, + ), + }, + "payload_rows": payload_rows, + }, + } + + +def _queue_review_summary(queue_review): + queue_review = _as_dict(queue_review) + side_effects_clear = bool( + not queue_review.get("network_request_allowed") + and not queue_review.get("api_executes_cli") + and not queue_review.get("api_opens_database_connection") + and not queue_review.get("api_writes_database") + and not queue_review.get("api_uses_external_network") + and not queue_review.get("database_write_executed") + and not queue_review.get("fetch_executed") + and not queue_review.get("cli_executed") + and not queue_review.get("file_written") + and not queue_review.get("scheduler_attached") + and not queue_review.get("candidate_queue_created") + and not queue_review.get("candidate_queue_persisted") + and not queue_review.get("candidate_review_state_updated") + ) + summary = _as_dict(queue_review.get("candidate_queue_review_summary")) + return { + "mode": queue_review.get("mode"), + "accepted": bool( + queue_review.get("mcp_fetch_candidate_queue_review_accepted") + ), + "ready_for_candidate_queue_writer_preflight": bool( + queue_review.get("ready_for_candidate_queue_writer_preflight") + ), + "review_item_count": _safe_int(queue_review.get("review_item_count")), + "campaign_candidate_count": _safe_int( + queue_review.get("campaign_candidate_count") + ), + "product_candidate_count": _safe_int( + queue_review.get("product_candidate_count") + ), + "campaign_candidate_keys": sorted( + key for key in _as_list(summary.get("campaign_candidate_keys")) if key + ), + "product_candidate_keys": sorted( + key for key in _as_list(summary.get("product_candidate_keys")) if key + ), + "side_effects_clear": side_effects_clear, + "blocked_reasons": queue_review.get("blocked_reasons", []), + } + + +def _payload_row_summary(row): + row = _as_dict(row) + return { + "candidate_type": _safe_text(row.get("candidate_type"), 40), + "platform_code": _safe_text(row.get("platform_code"), 80), + "source_key": _safe_text(row.get("source_key"), 160), + "candidate_key": _safe_text(row.get("candidate_key"), 240), + "candidate_name": _safe_text(row.get("candidate_name"), 300), + "candidate_url": _safe_text(row.get("candidate_url"), 500), + "review_state": _safe_text(row.get("review_state"), 80), + "priority_lane": _safe_text(row.get("priority_lane"), 80), + "evidence_ref": _safe_text(row.get("evidence_ref"), 160), + "dedupe_key": _safe_text(row.get("dedupe_key"), 500), + "required_fields_present": bool( + row.get("candidate_type") in {"campaign", "product"} + and row.get("platform_code") + and row.get("source_key") + and row.get("candidate_key") + and row.get("candidate_name") + and row.get("candidate_url") + and row.get("review_state") == "needs_review" + and row.get("dedupe_key") + ), + } + + +def _preflight_summary(writer_preflight): + writer_preflight = _as_dict(writer_preflight) + rows = [_payload_row_summary(row) for row in _as_list( + writer_preflight.get("payload_rows") + )] + campaign_rows = [row for row in rows if row["candidate_type"] == "campaign"] + product_rows = [row for row in rows if row["candidate_type"] == "product"] + summary = _as_dict(writer_preflight.get("summary")) + insert_columns = sorted( + column for column in _as_list(writer_preflight.get("insert_columns")) if column + ) + return { + "provided_keys": sorted(writer_preflight.keys()), + "preflight_id": _safe_text(writer_preflight.get("preflight_id"), 160), + "preflight_mode": _safe_text(writer_preflight.get("preflight_mode"), 120), + "target_table": _safe_text(writer_preflight.get("target_table"), 160), + "write_mode": _safe_text(writer_preflight.get("write_mode"), 80), + "dedupe_strategy": _safe_text(writer_preflight.get("dedupe_strategy"), 160), + "insert_columns": insert_columns, + "operator_confirmed_no_database_write": bool( + writer_preflight.get("operator_confirmed_no_database_write") + ), + "operator_confirmed_no_external_network": bool( + writer_preflight.get("operator_confirmed_no_external_network") + ), + "operator_confirmed_no_scheduler_attach": bool( + writer_preflight.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_cli_execution": bool( + writer_preflight.get("operator_confirmed_no_cli_execution") + ), + "operator_confirmed_no_persistence": bool( + writer_preflight.get("operator_confirmed_no_persistence") + ), + "operator_confirmed_no_secret_payload": bool( + writer_preflight.get("operator_confirmed_no_secret_payload") + ), + "payload_row_count": len(rows), + "summary_payload_row_count": _safe_int(summary.get("payload_row_count")), + "campaign_candidate_count": len(campaign_rows), + "summary_campaign_candidate_count": _safe_int( + summary.get("campaign_candidate_count") + ), + "product_candidate_count": len(product_rows), + "summary_product_candidate_count": _safe_int( + summary.get("product_candidate_count") + ), + "campaign_candidate_keys": sorted( + row["candidate_key"] for row in campaign_rows if row["candidate_key"] + ), + "product_candidate_keys": sorted( + row["candidate_key"] for row in product_rows if row["candidate_key"] + ), + "payload_rows": rows, + "insert_columns_cover_required": bool( + set(REQUIRED_INSERT_COLUMNS).issubset(set(insert_columns)) + ), + "all_rows_required_fields_present": bool( + rows and all(row["required_fields_present"] for row in rows) + ), + "dedupe_keys_unique": bool( + rows + and len({row["dedupe_key"] for row in rows if row["dedupe_key"]}) + == len(rows) + ), + "summary_counts_match_rows": bool( + _safe_int(summary.get("payload_row_count")) == len(rows) + and _safe_int(summary.get("campaign_candidate_count")) == len(campaign_rows) + and _safe_int(summary.get("product_candidate_count")) == len(product_rows) + ), + "raw_payload_submitted_to_api": _contains_forbidden_key( + writer_preflight, + FORBIDDEN_RAW_PAYLOAD_KEYS, + ), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + writer_preflight, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_side_effects(writer_preflight), + } + + +def _preflight_gates( + *, + queue_review_received, + writer_preflight_received, + writer_preflight_valid_object, + queue_review, + preflight, +): + queue_campaign_keys = set(queue_review["campaign_candidate_keys"]) + preflight_campaign_keys = set(preflight["campaign_candidate_keys"]) + queue_product_keys = set(queue_review["product_candidate_keys"]) + preflight_product_keys = set(preflight["product_candidate_keys"]) + operator_boundaries_confirmed = bool( + preflight["operator_confirmed_no_database_write"] + and preflight["operator_confirmed_no_external_network"] + and preflight["operator_confirmed_no_scheduler_attach"] + and preflight["operator_confirmed_no_cli_execution"] + and preflight["operator_confirmed_no_persistence"] + and preflight["operator_confirmed_no_secret_payload"] + ) + return [ + { + "key": "queue_review_payload_or_result_received", + "label": "已提供 candidate queue review package 或已審核結果", + "passed": queue_review_received, + }, + { + "key": "queue_review_accepted", + "label": "candidate queue review gate 必須已通過", + "passed": queue_review["accepted"], + }, + { + "key": "queue_review_ready_for_writer_preflight", + "label": "queue review 只放行到 writer preflight", + "passed": queue_review["ready_for_candidate_queue_writer_preflight"], + }, + { + "key": "queue_review_side_effect_free", + "label": "queue review 未顯示 API 執行、連外、寫檔、寫 DB 或掛 scheduler", + "passed": queue_review["side_effects_clear"], + }, + { + "key": "writer_preflight_payload_received", + "label": "已提供 writer preflight 草案", + "passed": writer_preflight_received, + }, + { + "key": "writer_preflight_valid_object", + "label": "writer preflight payload 必須是 JSON object", + "passed": writer_preflight_valid_object, + }, + { + "key": "writer_preflight_identity_recorded", + "label": "writer preflight 必須記錄 preflight_id", + "passed": bool(preflight["preflight_id"]), + }, + { + "key": "writer_preflight_mode_preview_only", + "label": "writer preflight 必須維持 preview mode", + "passed": preflight["preflight_mode"] in SAFE_PREFLIGHT_MODES, + }, + { + "key": "writer_preflight_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": preflight["target_table"] == TARGET_TABLE, + }, + { + "key": "writer_preflight_write_mode_cli_later", + "label": "write mode 必須是 cli_only_later,不得由 API 寫入", + "passed": preflight["write_mode"] in SAFE_WRITE_MODES, + }, + { + "key": "writer_preflight_dedupe_strategy_safe", + "label": "dedupe strategy 必須可由候選 identity 決定", + "passed": preflight["dedupe_strategy"] in SAFE_DEDUPE_STRATEGIES, + }, + { + "key": "writer_preflight_candidates_match_queue_review", + "label": "writer payload candidate key 必須完全對齊 queue review", + "passed": bool( + queue_campaign_keys + and queue_product_keys + and preflight_campaign_keys == queue_campaign_keys + and preflight_product_keys == queue_product_keys + ), + }, + { + "key": "writer_preflight_payload_count_within_limit", + "label": "writer payload rows 需維持小批次上限", + "passed": bool(0 < preflight["payload_row_count"] <= MAX_PREFLIGHT_ITEMS), + }, + { + "key": "writer_preflight_counts_match_summary", + "label": "summary count 必須與 payload rows 數量一致", + "passed": preflight["summary_counts_match_rows"], + }, + { + "key": "writer_preflight_required_columns_present", + "label": "insert columns 必須覆蓋 queue 基本欄位", + "passed": preflight["insert_columns_cover_required"], + }, + { + "key": "writer_preflight_required_fields_present", + "label": "payload rows 必須具備候選識別與 needs_review 狀態", + "passed": preflight["all_rows_required_fields_present"], + }, + { + "key": "writer_preflight_dedupe_keys_unique", + "label": "payload rows dedupe key 必須唯一", + "passed": preflight["dedupe_keys_unique"], + }, + { + "key": "writer_preflight_operator_boundaries_confirmed", + "label": "操作員確認無寫入、無連外、無 CLI、無排程、無保存", + "passed": operator_boundaries_confirmed, + }, + { + "key": "writer_preflight_no_raw_payload", + "label": "writer preflight payload 不得回貼 raw HTML/body/snapshot", + "passed": not preflight["raw_payload_submitted_to_api"], + }, + { + "key": "writer_preflight_no_secret_or_token_key", + "label": "writer preflight payload 不得包含 secret、cookie、password 或 token key", + "passed": not preflight["secret_or_token_submitted_to_api"], + }, + { + "key": "writer_preflight_side_effect_free", + "label": "writer preflight payload 不得要求 API 執行、連外、寫檔、寫 DB 或掛 scheduler", + "passed": not preflight["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_queue_writer_preflight_preview( + *, + queue_review_package=None, + queue_review_result=None, + writer_preflight=None, + phase=None, +): + """建立 fetch candidate queue writer preflight;不開 DB 或寫入。""" + queue_review_package = _as_dict(queue_review_package) + queue_review_result_received = bool( + isinstance(queue_review_result, dict) and queue_review_result + ) + writer_preflight_valid_object = isinstance(writer_preflight, dict) if ( + writer_preflight is not None + ) else True + writer_preflight_payload = _as_dict(writer_preflight) + queue_review_data = _queue_review_from_inputs( + queue_review_package, + queue_review_result, + phase, + ) + queue_review_received = bool( + queue_review_package or queue_review_result_received + ) + payload_received = bool( + queue_review_received + or writer_preflight_payload + or writer_preflight is not None + ) + writer_preflight_received = bool(writer_preflight_payload) + queue_review = _queue_review_summary(queue_review_data) + preflight = _preflight_summary(writer_preflight_payload) + gates = _preflight_gates( + queue_review_received=queue_review_received, + writer_preflight_received=writer_preflight_received, + writer_preflight_valid_object=writer_preflight_valid_object, + queue_review=queue_review, + preflight=preflight, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_preflight" + if payload_received + else "mcp_fetch_candidate_queue_writer_preflight_preview" + ), + "phase": phase, + "writer_preflight_payload_received": payload_received, + "queue_review_received": queue_review_received, + "writer_preflight_received": writer_preflight_received, + "writer_preflight_valid_object": writer_preflight_valid_object, + "queue_review_accepted": queue_review["accepted"], + "mcp_fetch_candidate_queue_writer_preflight_accepted": accepted, + "candidate_queue_writer_preflight_ready": accepted, + "ready_for_candidate_queue_writer_cli_review": accepted, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "network_request_allowed": False, + "cli_executed": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + "review_item_count": queue_review["review_item_count"], + "payload_row_count": preflight["payload_row_count"], + "campaign_candidate_count": preflight["campaign_candidate_count"], + "product_candidate_count": preflight["product_candidate_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "queue_review_summary": queue_review, + "writer_preflight_summary": preflight, + "sample_writer_preflight_package": _sample_writer_preflight_package(), + "next_operator_steps": [ + "writer preflight 通過後,只代表可進 CLI writer review,不代表可寫 market_*", + "實際 writer run、DB commit、post-write smoke、scheduler attach 都必須另開獨立 gate", + "API/UI 仍不得開 DB、不得執行 CLI、不得建立 queue、不得更新 review_state", + ], + "payload_persisted": False, + "preflight_persisted": False, + "api_executes_health_check": False, + "api_executes_docker": False, + "api_executes_ssh": False, + "api_executes_cli": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 921a009..b663c49 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_127_market_intel_mcp_fetch_candidate_queue_review" +MARKET_INTEL_PHASE = "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 8a9ff50..0d718ec 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -838,6 +838,32 @@ +
+
+
+

MCP / QUEUE WRITER PREFLIGHT

+

MCP Candidate Queue Writer Preflight

+
+ +
+
+ loading +
+
+
讀取 MCP Candidate Queue Writer Preflight 中...
+
+
+ +
+ +
+
+
+
@@ -1353,6 +1379,7 @@ const mcpFetchResultParserReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-result-parser-review]'); const mcpFetchCandidateHandoffReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review]'); const mcpFetchCandidateQueueReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-review]'); + const mcpFetchCandidateQueueWriterPreflightRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1369,7 +1396,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1482,6 +1509,12 @@ const mcpFetchCandidateQueueReviewReview = mcpFetchCandidateQueueReviewRoot ? mcpFetchCandidateQueueReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-review-review]') : null; const mcpFetchCandidateQueueReviewRefresh = mcpFetchCandidateQueueReviewRoot ? mcpFetchCandidateQueueReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-review-refresh]') : null; const mcpFetchCandidateQueueReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_review') }}"; + const mcpFetchCandidateQueueWriterPreflightMeta = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-meta]') : null; + const mcpFetchCandidateQueueWriterPreflightBody = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-body]') : null; + const mcpFetchCandidateQueueWriterPreflightInput = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-input]') : null; + const mcpFetchCandidateQueueWriterPreflightReview = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-review]') : null; + const mcpFetchCandidateQueueWriterPreflightRefresh = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-refresh]') : null; + const mcpFetchCandidateQueueWriterPreflightEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_preflight') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -3819,6 +3852,135 @@ } }; + const renderMcpFetchCandidateQueueWriterPreflightMeta = data => { + mcpFetchCandidateQueueWriterPreflightMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_preflight_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || 0}`, + `campaigns=${data.campaign_candidate_count || 0}`, + `products=${data.product_candidate_count || 0}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterPreflightBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const queue = data.queue_review_summary || {}; + const preflight = data.writer_preflight_summary || {}; + const rows = preflight.payload_rows || []; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterPreflightBody.innerHTML = ` +
此 writer preflight 只審核未來 CLI writer 草案;API 不開 DB、不建立 transaction、不執行 CLI、不寫 queue、不掛 scheduler。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

WRITER PREFLIGHT GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 writer preflight gates。
' + }
+
+
+

QUEUE REVIEW LINK

+
+ ${renderCheck('queue_review', `${queue.accepted ? 'accepted' : 'pending'} / items=${queue.review_item_count || 0}`, queue.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('writer_ready', queue.ready_for_candidate_queue_writer_preflight ? 'ready_for_writer_preflight' : 'not_ready', queue.ready_for_candidate_queue_writer_preflight ? 'READY' : 'BLOCK')} + ${renderCheck('queue_boundary', 'no queue create / no DB / no scheduler', queue.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

WRITER PAYLOAD ROWS

+
${ + rows.slice(0, 10).map(item => renderCheck( + item.candidate_key || 'candidate', + `${item.candidate_type || 'candidate'} / ${item.review_state || 'missing'} / ${item.priority_lane || 'lane'}`, + item.required_fields_present ? 'READY' : 'BLOCK' + )).join('') || '
尚未提供 writer payload rows。
' + }
+
+
+

WRITE PLAN

+
+ ${renderCheck('target_table', preflight.target_table || 'missing', preflight.target_table === 'market_alert_review_queue' ? 'TARGET' : 'BLOCK')} + ${renderCheck('write_mode', preflight.write_mode || 'missing', preflight.write_mode === 'cli_only_later' ? 'CLI LATER' : 'BLOCK')} + ${renderCheck('dedupe_strategy', preflight.dedupe_strategy || 'missing', preflight.dedupe_strategy === 'candidate_type_platform_source_key' ? 'READY' : 'BLOCK')} + ${renderCheck('required_columns', 'candidate queue insert columns', preflight.insert_columns_cover_required ? 'READY' : 'BLOCK')} +
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck( + 'api_boundary', + 'no DB / no transaction / no CLI / no queue write / no scheduler', + data.api_writes_database ? 'BLOCK' : 'CLOSED' + )} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterPreflightInput && !mcpFetchCandidateQueueWriterPreflightInput.value.trim() && data.sample_writer_preflight_package) { + mcpFetchCandidateQueueWriterPreflightInput.value = JSON.stringify(data.sample_writer_preflight_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterPreflight = async () => { + if (!mcpFetchCandidateQueueWriterPreflightMeta || !mcpFetchCandidateQueueWriterPreflightBody) return; + mcpFetchCandidateQueueWriterPreflightBody.innerHTML = '
讀取 MCP Candidate Queue Writer Preflight 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterPreflightEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterPreflightMeta(data); + renderMcpFetchCandidateQueueWriterPreflightBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterPreflightMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterPreflightBody.innerHTML = `
MCP Candidate Queue Writer Preflight 讀取失敗:${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterPreflight = async () => { + if (!mcpFetchCandidateQueueWriterPreflightMeta || !mcpFetchCandidateQueueWriterPreflightBody || !mcpFetchCandidateQueueWriterPreflightInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterPreflightInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterPreflightMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterPreflightBody.innerHTML = `
JSON 格式錯誤:${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterPreflightBody.innerHTML = '
審核 MCP Candidate Queue Writer Preflight 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterPreflightEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ candidate_queue_writer_preflight: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterPreflightMeta(data); + renderMcpFetchCandidateQueueWriterPreflightBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterPreflightMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterPreflightBody.innerHTML = `
MCP Candidate Queue Writer Preflight 審核失敗:${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -13288,6 +13450,12 @@ if (mcpFetchCandidateQueueReviewReview) { mcpFetchCandidateQueueReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueReview); } + if (mcpFetchCandidateQueueWriterPreflightRefresh) { + mcpFetchCandidateQueueWriterPreflightRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterPreflight); + } + if (mcpFetchCandidateQueueWriterPreflightReview) { + mcpFetchCandidateQueueWriterPreflightReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterPreflight); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -13553,6 +13721,7 @@ loadMcpFetchResultParserReview(); loadMcpFetchCandidateHandoffReview(); loadMcpFetchCandidateQueueReview(); + loadMcpFetchCandidateQueueWriterPreflight(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index b0da3ac..2ba1a01 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -38,6 +38,9 @@ from services.market_intel.mcp_fetch_candidate_handoff_review import ( from services.market_intel.mcp_fetch_candidate_queue_review import ( build_mcp_fetch_candidate_queue_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( + build_mcp_fetch_candidate_queue_writer_preflight_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1021,6 +1024,31 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-mcp-fetch-candidate-queue-review-items" in template assert "data-market-intel-mcp-fetch-candidate-queue-review-policy" in template assert "data-market-intel-mcp-fetch-candidate-queue-review-next" in template + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_preflight" + in template + ) + assert "data-market-intel-mcp-fetch-candidate-queue-writer-preflight" in template + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-preflight-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-preflight-queue" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-preflight-payload" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-preflight-columns" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-preflight-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1491,7 +1519,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert bridge["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1649,7 +1677,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert contract["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1782,7 +1810,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1795,7 +1823,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert gate["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1865,7 +1893,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1879,7 +1907,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert audit["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -1953,7 +1981,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -1970,11 +1998,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review" + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert evidence["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -1999,7 +2027,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2057,12 +2085,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2071,11 +2099,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review" + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert receipt["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2103,7 +2131,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2168,12 +2196,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2182,11 +2210,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review" + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert promotion["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2214,7 +2242,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2274,12 +2302,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2288,11 +2316,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2320,7 +2348,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2382,12 +2410,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2398,11 +2426,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2432,7 +2460,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2510,13 +2538,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2528,11 +2556,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert package["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2564,7 +2592,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2639,13 +2667,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2659,11 +2687,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert readiness["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2698,11 +2726,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert readiness["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2778,13 +2806,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2798,11 +2826,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert receipt["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -2839,11 +2867,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert receipt["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -2922,13 +2950,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -2944,11 +2972,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert parser["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -2987,11 +3015,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert parser["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3076,13 +3104,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3098,11 +3126,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3141,11 +3169,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3235,13 +3263,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3258,11 +3286,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3299,11 +3327,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_127_market_intel_mcp_fetch_candidate_queue_review", + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3394,13 +3422,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3414,11 +3442,190 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert post_data["api_uses_external_network"] is False +def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): + preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + ) + + assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" + assert ( + preflight["phase"] + == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + ) + assert preflight["writer_preflight_payload_received"] is False + assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False + assert preflight["candidate_queue_writer_preflight_ready"] is False + assert preflight["ready_for_candidate_queue_writer_cli_review"] is False + assert preflight["ready_for_api_database_write"] is False + assert preflight["ready_for_scheduler_attach"] is False + assert preflight["network_request_allowed"] is False + assert preflight["cli_executed"] is False + assert preflight["payload_persisted"] is False + assert preflight["preflight_persisted"] is False + assert preflight["candidate_queue_created"] is False + assert preflight["candidate_queue_persisted"] is False + assert preflight["candidate_review_state_updated"] is False + assert preflight["api_executes_cli"] is False + assert preflight["api_opens_database_connection"] is False + assert preflight["api_writes_database"] is False + assert preflight["api_uses_external_network"] is False + assert preflight["database_write_executed"] is False + assert preflight["external_network_executed"] is False + assert preflight["file_written"] is False + assert preflight["scheduler_attached"] is False + assert "queue_review_payload_or_result_received" in preflight["blocked_reasons"] + assert "writer_preflight_payload_received" in preflight["blocked_reasons"] + assert "queue_review_package" in preflight["sample_writer_preflight_package"] + assert "writer_preflight" in preflight["sample_writer_preflight_package"] + + +def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): + sample = ( + build_mcp_fetch_candidate_queue_writer_preflight_preview() + ["sample_writer_preflight_package"] + ) + preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( + queue_review_package=sample["queue_review_package"], + queue_review_result=sample["queue_review_result"], + writer_preflight=sample["writer_preflight"], + phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + ) + + assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" + assert ( + preflight["phase"] + == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + ) + assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True + assert preflight["candidate_queue_writer_preflight_ready"] is True + assert preflight["ready_for_candidate_queue_writer_cli_review"] is True + assert preflight["ready_for_api_database_write"] is False + assert preflight["blocked_reasons"] == [] + assert preflight["passed_gate_count"] == preflight["gate_count"] + assert preflight["queue_review_accepted"] is True + assert preflight["payload_row_count"] == ( + preflight["campaign_candidate_count"] + preflight["product_candidate_count"] + ) + summary = preflight["writer_preflight_summary"] + assert summary["target_table"] == "market_alert_review_queue" + assert summary["write_mode"] == "cli_only_later" + assert summary["dedupe_strategy"] == "candidate_type_platform_source_key" + assert summary["insert_columns_cover_required"] is True + assert summary["all_rows_required_fields_present"] is True + assert summary["dedupe_keys_unique"] is True + assert summary["summary_counts_match_rows"] is True + assert summary["raw_payload_submitted_to_api"] is False + assert summary["secret_or_token_submitted_to_api"] is False + assert summary["blocked_side_effects"] == [] + assert preflight["network_request_allowed"] is False + assert preflight["cli_executed"] is False + assert preflight["candidate_queue_created"] is False + assert preflight["candidate_queue_persisted"] is False + assert preflight["candidate_review_state_updated"] is False + assert preflight["file_written"] is False + assert preflight["database_write_executed"] is False + assert preflight["api_uses_external_network"] is False + assert preflight["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_preflight_blocks_unsafe_preflight(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_preflight_preview() + ["sample_writer_preflight_package"] + ) + ) + writer_preflight = sample["writer_preflight"] + writer_preflight["target_table"] = "market_campaign_products" + writer_preflight["write_mode"] = "api_write_now" + writer_preflight["approval_token"] = "do-not-submit" + writer_preflight["raw_html"] = "raw" + writer_preflight["api_writes_database"] = True + writer_preflight["operator_confirmed_no_database_write"] = False + first_row = writer_preflight["payload_rows"][0] + first_row["review_state"] = "approved" + first_row.pop("candidate_key") + + preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( + queue_review_package=sample["queue_review_package"], + queue_review_result=sample["queue_review_result"], + writer_preflight=writer_preflight, + ) + + assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False + assert preflight["queue_review_accepted"] is True + assert "writer_preflight_target_table_safe" in preflight["blocked_reasons"] + assert "writer_preflight_write_mode_cli_later" in preflight["blocked_reasons"] + assert ( + "writer_preflight_candidates_match_queue_review" + in preflight["blocked_reasons"] + ) + assert "writer_preflight_required_fields_present" in preflight["blocked_reasons"] + assert ( + "writer_preflight_operator_boundaries_confirmed" + in preflight["blocked_reasons"] + ) + assert "writer_preflight_no_raw_payload" in preflight["blocked_reasons"] + assert "writer_preflight_no_secret_or_token_key" in preflight["blocked_reasons"] + assert "writer_preflight_side_effect_free" in preflight["blocked_reasons"] + assert preflight["api_writes_database"] is False + assert preflight["candidate_queue_persisted"] is False + assert preflight["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_preflight" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_preflight_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_preflight", + json={"writer_preflight_review": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" + assert ( + get_data["phase"] + == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_uses_external_network"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" + assert ( + post_data["phase"] + == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + ) + assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True + assert post_data["ready_for_candidate_queue_writer_cli_review"] is True + assert post_data["ready_for_api_database_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["candidate_review_state_updated"] is False + assert post_data["api_opens_database_connection"] is False + assert post_data["api_uses_external_network"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -3466,7 +3673,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -3477,7 +3684,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert acceptance["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -3519,7 +3726,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -3531,7 +3738,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -3642,7 +3849,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -3681,7 +3888,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -3743,7 +3950,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -3823,7 +4030,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -3887,7 +4094,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -3946,7 +4153,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert queue_draft["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -4020,7 +4227,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -4083,7 +4290,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert approval["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -4161,7 +4368,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -4224,7 +4431,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert transaction["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -4304,7 +4511,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -10015,7 +10222,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10090,7 +10297,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -10362,7 +10569,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10650,7 +10857,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -10960,7 +11167,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -11263,7 +11470,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -11522,7 +11729,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -11795,7 +12002,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -12043,7 +12250,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -12273,7 +12480,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -12510,7 +12717,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -12752,7 +12959,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -13028,7 +13235,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -13305,7 +13512,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -13584,7 +13791,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -13913,7 +14120,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -14175,7 +14382,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -14439,7 +14646,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -14709,7 +14916,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -14997,7 +15204,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -15284,7 +15491,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -15370,7 +15577,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15427,7 +15634,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15516,7 +15723,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15570,7 +15777,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -15626,7 +15833,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -15692,7 +15899,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -15994,7 +16201,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -16042,7 +16249,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -16091,7 +16298,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -16149,7 +16356,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -16215,7 +16422,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -16286,7 +16493,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -16362,7 +16569,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -16444,7 +16651,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -16530,7 +16737,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -16613,7 +16820,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16696,7 +16903,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -16782,7 +16989,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -16873,7 +17080,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -16983,7 +17190,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17069,7 +17276,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17126,7 +17333,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17179,7 +17386,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17232,7 +17439,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17293,7 +17500,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17362,7 +17569,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17434,7 +17641,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -17507,7 +17714,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -17578,7 +17785,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -17643,7 +17850,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -17714,7 +17921,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -17787,7 +17994,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -17864,7 +18071,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -17941,7 +18148,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -18018,7 +18225,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -18092,7 +18299,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -18171,7 +18378,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -18258,7 +18465,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -18339,7 +18546,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -18421,7 +18628,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_127_market_intel_mcp_fetch_candidate_queue_review" + "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -18504,7 +18711,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -18529,7 +18736,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -18567,7 +18774,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -18578,7 +18785,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -18614,7 +18821,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -18625,7 +18832,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -18666,7 +18873,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -18677,7 +18884,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -18725,7 +18932,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -18737,7 +18944,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -18783,7 +18990,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -18796,7 +19003,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -18881,7 +19088,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -18959,7 +19166,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -18974,7 +19181,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert readiness["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -19373,6 +19580,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["mcp_fetch_result_parser_review_preview_safe"] is True assert readiness["checks"]["mcp_fetch_candidate_handoff_review_preview_safe"] is True assert readiness["checks"]["mcp_fetch_candidate_queue_review_preview_safe"] is True + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_preflight_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -23793,7 +24006,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert drill["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -23908,7 +24121,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -23920,7 +24133,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -24035,7 +24248,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -24048,7 +24261,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert smoke["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -24110,7 +24323,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -24123,7 +24336,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert inventory["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -24267,7 +24480,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -24503,7 +24716,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -24532,7 +24745,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_127_market_intel_mcp_fetch_candidate_queue_review" + assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False