From bdae154237fbb7cbf6fedd9075a98d3d372a82b6 Mon Sep 17 00:00:00 2001 From: OoO Date: Tue, 19 May 2026 13:00:46 +0800 Subject: [PATCH] =?UTF-8?q?=E6=96=B0=E5=A2=9E=E5=B8=82=E5=A0=B4=E6=83=85?= =?UTF-8?q?=E5=A0=B1=20queue=20review=20inventory?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TODO_NEXT_STEPS.txt | 1 + app.py | 3 + config.py | 2 +- ...s-platform-market-campaign-intelligence.md | 1 + routes/README.md | 3 +- routes/market_intel_review_routes.py | 166 ++++++ .../candidate_queue_review_inventory.py | 288 +++++++++++ services/market_intel/deployment_readiness.py | 50 +- services/market_intel/service.py | 2 +- templates/market_intel/disabled.html | 123 +++++ tests/test_market_intel_skeleton.py | 484 ++++++++++++++++-- 11 files changed, 1030 insertions(+), 93 deletions(-) create mode 100644 routes/market_intel_review_routes.py create mode 100644 services/market_intel/candidate_queue_review_inventory.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 3fe7863..caf4991 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -134,6 +134,7 @@ - Phase 62 candidate queue writer run receipt：新增 `services/market_intel/candidate_queue_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt` 與 UI receipt 按鈕，審核 CLI 寫入後的 writer output、post-write smoke、dedupe key 一致性與 artifact 路徑；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler；版本同步至 V10.247。 - Phase 63 candidate queue writer run closeout：新增 `services/market_intel/candidate_queue_writer_run_closeout.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout` 與 UI closeout 按鈕，在 receipt 通過後檢查 closeout artifact、操作員人工 queue review/read-only inventory 確認與安全 promotion gate；API/UI 不回吐原始 receipt、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler；版本同步至 V10.248。 - Phase 64 candidate queue review handoff：新增 `services/market_intel/candidate_queue_review_handoff.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_handoff` 與 UI handoff 按鈕，將 writer closeout 轉成人工 queue review / read-only inventory 交接契約；API/UI 不讀 approval token、不查 DB、不更新 review_state、不補寫 queue、不掛 scheduler；版本同步至 V10.251。 + - Phase 65 candidate queue review inventory：新增 `services/market_intel/candidate_queue_review_inventory.py`、`routes/market_intel_review_routes.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_inventory` 與 UI inventory 按鈕，把 handoff、post-write smoke、live DB inventory 合併成只讀人工審核庫存檢查；預設不連 DB，人工只讀查詢仍不更新 review_state、不補寫 queue、不讀 token、不掛 scheduler；版本同步至 V10.252。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/app.py b/app.py index ab31489..2b6d19f 100644 --- a/app.py +++ b/app.py @@ -385,6 +385,9 @@ sys_log.info("[Blueprint] ✅ pchome_bp 已註冊") from routes.market_intel_routes import market_intel_bp app.register_blueprint(market_intel_bp) sys_log.info("[Blueprint] ✅ market_intel_bp 已註冊") +from routes.market_intel_review_routes import market_intel_review_bp +app.register_blueprint(market_intel_review_bp) +sys_log.info("[Blueprint] ✅ market_intel_review_bp 已註冊") # V-Fix: 註冊 slugify 函數供模板使用（實作搬至 utils/text_helpers.py） from utils.text_helpers import slugify # noqa: E402 diff --git a/config.py b/config.py index ad501b8..b5e1550 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.251" +SYSTEM_VERSION = "V10.252" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 50c244d..cfba11d 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -190,6 +190,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue writer run receipt：`services.market_intel.candidate_queue_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt` 審核 CLI 小流量寫入後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer run closeout：`services.market_intel.candidate_queue_writer_run_closeout` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout` 在 receipt 通過後整理 closeout gate、人工確認與下一階段 promotion 摘要。此 closeout 只允許放行到人工 queue review / read-only inventory；API/UI 不回吐原始 receipt、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler。 - 2026-05-19 追加 candidate queue review handoff：`services.market_intel.candidate_queue_review_handoff` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_handoff` 將 closeout 後的 expected dedupe key、review contract、人工操作順序與 forbidden API actions 整理為交接包。此 handoff 不查 DB、不更新 `review_state`、不補寫 missing queue row、不讀 approval token、不掛 scheduler。 +- 2026-05-19 追加 candidate queue review inventory：`services.market_intel.candidate_queue_review_inventory` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_inventory` 將 handoff、post-write smoke 與 live DB inventory 串成只讀人工審核庫存檢查。預設不連 DB；人工明確要求只讀查詢時仍不更新 `review_state`、不補寫 queue row、不讀 approval token、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 9a36201..3aabdb6 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,7 +19,8 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 64 candidate queue review handoff | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 65 candidate queue review inventory 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py new file mode 100644 index 0000000..2740368 --- /dev/null +++ b/routes/market_intel_review_routes.py @@ -0,0 +1,166 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +"""市場情報人工審核延伸 API。""" + +from flask import Blueprint, jsonify, request + +from auth import login_required +from services.market_intel import MarketIntelService +from services.market_intel.candidate_queue_review_handoff import ( + build_candidate_queue_review_handoff, +) +from services.market_intel.candidate_queue_review_inventory import ( + build_candidate_queue_review_inventory, +) +from services.market_intel.candidate_queue_writer_cli import ( + build_candidate_queue_writer_cli_plan, +) +from services.market_intel.candidate_queue_writer_operator_drill import ( + build_candidate_queue_writer_operator_drill, +) +from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, +) +from services.market_intel.candidate_queue_writer_preflight import ( + build_candidate_queue_writer_preflight, +) +from services.market_intel.candidate_queue_writer_run_closeout import ( + build_candidate_queue_writer_run_closeout, +) +from services.market_intel.candidate_queue_writer_run_package import ( + build_candidate_queue_writer_run_package, +) +from services.market_intel.candidate_queue_writer_run_readiness import ( + build_candidate_queue_writer_run_readiness, +) +from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, +) + + +market_intel_review_bp = Blueprint("market_intel_review", __name__) + + +def _extract_run_payload(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + if not isinstance(payload, dict): + return None, {}, {}, {}, "invalid_json_object", limit + return ( + payload.get("sample_result", payload), + payload.get("operator_evidence", {}), + payload.get("writer_output", {}), + payload.get("postwrite_smoke_result", {}), + None, + limit, + ) + + +def _build_closeout_stack( + *, + service, + sample_result, + payload_error, + operator_evidence, + writer_output, + postwrite_smoke_result, + limit, +): + transaction_preview = service.build_manual_sample_candidate_queue_transaction( + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + ) + writer_preflight = build_candidate_queue_writer_preflight( + transaction_preview=transaction_preview, + execute_requested=False, + ) + writer_status = build_candidate_queue_writer_cli_plan( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + approval_token=None, + approval_token_secret=None, + ) + planned_smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction_preview, + execute_requested=False, + ) + operator_drill = build_candidate_queue_writer_operator_drill( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=planned_smoke, + ) + run_package = build_candidate_queue_writer_run_package( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=planned_smoke, + operator_drill=operator_drill, + ) + run_readiness = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=planned_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=transaction_preview, + run_readiness=run_readiness, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=operator_evidence, + ) + closeout = build_candidate_queue_writer_run_closeout( + transaction_preview=transaction_preview, + run_receipt=receipt, + operator_evidence=operator_evidence, + ) + handoff = build_candidate_queue_review_handoff( + transaction_preview=transaction_preview, + run_closeout=closeout, + operator_evidence=operator_evidence, + ) + return transaction_preview, handoff + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_inventory(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction_preview, handoff = _build_closeout_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + limit=limit, + ) + read_only_allowed = bool(execute_requested and handoff.get("handoff_ready")) + postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction_preview, + execute_requested=read_only_allowed, + ) + live_db_inventory = service.build_live_db_inventory( + execute_requested=read_only_allowed, + ) + data = build_candidate_queue_review_inventory( + review_handoff=handoff, + postwrite_smoke=postwrite_smoke, + live_db_inventory=live_db_inventory, + operator_evidence=operator_evidence, + execute_requested=execute_requested, + ) + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 diff --git a/services/market_intel/candidate_queue_review_inventory.py b/services/market_intel/candidate_queue_review_inventory.py new file mode 100644 index 0000000..ac2431b --- /dev/null +++ b/services/market_intel/candidate_queue_review_inventory.py @@ -0,0 +1,288 @@ +"""候選審核 queue inventory 只讀檢查。 + +本模組只整理 handoff 後的人工審核庫存檢查結果； +不更新 review_state、不補寫 queue row、不讀 approval token、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +TARGET_TABLE = "market_alert_review_queue" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _row_summaries(postwrite_smoke): + rows = [] + for row in _as_list(_as_dict(postwrite_smoke).get("row_summaries")): + row = _as_dict(row) + rows.append( + { + "dedupe_key": row.get("dedupe_key"), + "review_state": row.get("review_state"), + "priority_lane": row.get("priority_lane"), + "total_score": row.get("total_score"), + "source_batch_id": row.get("source_batch_id"), + "created_at": row.get("created_at"), + "updated_at": row.get("updated_at"), + } + ) + return rows + + +def _alert_table_status(live_db_inventory): + for item in _as_list(_as_dict(live_db_inventory).get("table_statuses")): + item = _as_dict(item) + if item.get("table") == TARGET_TABLE: + return { + "exists": bool(item.get("exists")), + "row_count": item.get("row_count"), + "status": item.get("status"), + } + return {"exists": False, "row_count": None, "status": "not_reported"} + + +def _operator_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "operator_confirmed_queue_review_next": bool( + operator_evidence.get("operator_confirmed_queue_review_next") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "operator_confirmed_inventory_read_only": bool( + operator_evidence.get("operator_confirmed_inventory_read_only") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _side_effects_clear(postwrite_smoke, live_db_inventory): + payloads = [_as_dict(postwrite_smoke), _as_dict(live_db_inventory)] + blocked_keys = ( + "api_writes_database", + "database_write_executed", + "database_commit_executed", + "migration_executed", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ) + return all(not payload.get(key) for payload in payloads for key in blocked_keys) + + +def _review_gates( + *, + handoff, + postwrite_smoke, + live_db_inventory, + operator_summary, + expected_keys, + found_keys, + missing_keys, + rows, + alert_table_status, +): + read_only_executed = bool( + postwrite_smoke.get("read_only_query_executed") + or live_db_inventory.get("read_only_query_executed") + ) + return [ + { + "key": "handoff_ready", + "label": "上一階段 handoff 必須通過", + "passed": bool(handoff.get("handoff_ready")), + }, + { + "key": "expected_dedupe_keys_present", + "label": "必須有 expected dedupe key 才能人工比對", + "passed": bool(expected_keys), + }, + { + "key": "inventory_probe_is_read_only", + "label": "inventory / smoke 只能做只讀查詢，不得寫 DB 或掛 scheduler", + "passed": _side_effects_clear(postwrite_smoke, live_db_inventory), + }, + { + "key": "operator_confirmed_inventory_read_only", + "label": "操作員確認本階段只讀，不由 API 寫入或更新 review_state", + "passed": bool( + operator_summary["operator_confirmed_inventory_read_only"] + and operator_summary["operator_confirmed_no_api_db_write"] + and operator_summary["operator_confirmed_no_scheduler_attach"] + ), + }, + { + "key": "review_inventory_no_approval_token_submitted_to_api", + "label": "payload 不得包含一次性 approval token key", + "passed": not operator_summary["approval_token_submitted_to_api"], + }, + { + "key": "read_only_inventory_executed", + "label": "正式人工審核前需執行只讀 inventory / post-write smoke", + "passed": read_only_executed, + }, + { + "key": "alert_review_queue_table_exists", + "label": "market_alert_review_queue 必須存在於只讀 inventory", + "passed": bool(alert_table_status["exists"]), + }, + { + "key": "dedupe_keys_found", + "label": "所有 expected dedupe key 都必須在 queue 中找到", + "passed": bool(expected_keys and found_keys and not missing_keys), + }, + { + "key": "review_state_needs_review", + "label": "找到的 queue row 必須維持 needs_review，後續由人工審核處理", + "passed": bool(rows and all(row.get("review_state") == "needs_review" for row in rows)), + }, + ] + + +def build_candidate_queue_review_inventory( + *, + review_handoff, + postwrite_smoke, + live_db_inventory, + operator_evidence=None, + execute_requested=False, +): + """建立人工 queue review inventory；只整理只讀結果，不執行副作用。""" + handoff = _as_dict(review_handoff) + postwrite_smoke = _as_dict(postwrite_smoke) + live_db_inventory = _as_dict(live_db_inventory) + operator_summary = _operator_summary(operator_evidence) + expected_keys = _as_list(handoff.get("expected_dedupe_keys")) + found_keys = _as_list(postwrite_smoke.get("found_dedupe_keys")) + missing_keys = _as_list(postwrite_smoke.get("missing_dedupe_keys")) + rows = _row_summaries(postwrite_smoke) + table_status = _alert_table_status(live_db_inventory) + gates = _review_gates( + handoff=handoff, + postwrite_smoke=postwrite_smoke, + live_db_inventory=live_db_inventory, + operator_summary=operator_summary, + expected_keys=expected_keys, + found_keys=found_keys, + missing_keys=missing_keys, + rows=rows, + alert_table_status=table_status, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + review_inventory_ready = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_inventory_preview", + "target_table": TARGET_TABLE, + "execute_requested": bool(execute_requested), + "review_inventory_ready": review_inventory_ready, + "ready_for_human_decision_review": review_inventory_ready, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "read_only_query_executed": bool( + postwrite_smoke.get("read_only_query_executed") + or live_db_inventory.get("read_only_query_executed") + ), + "database_connection_opened": bool( + postwrite_smoke.get("database_connection_opened") + or live_db_inventory.get("database_connection_opened") + ), + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "expected_dedupe_keys": expected_keys, + "found_dedupe_keys": found_keys, + "missing_dedupe_keys": missing_keys, + "row_summaries": rows, + "alert_review_queue_table": table_status, + "live_inventory_summary": { + "mode": live_db_inventory.get("mode"), + "summary_ready": bool(live_db_inventory.get("summary_ready")), + "total_rows": live_db_inventory.get("total_rows"), + "alert_review_state_breakdown": _as_list( + live_db_inventory.get("alert_review_state_breakdown") + ), + }, + "postwrite_smoke_summary": { + "mode": postwrite_smoke.get("mode"), + "postwrite_smoke_passed": bool(postwrite_smoke.get("postwrite_smoke_passed")), + "found_count": postwrite_smoke.get("found_count"), + "missing_count": postwrite_smoke.get("missing_count"), + }, + "operator_inventory_summary": operator_summary, + "blocked_reasons": blocked_reasons, + "gates": gates, + "next_operator_steps": [ + "確認 expected / found dedupe key 完全一致", + "確認 row review_state 仍為 needs_review", + "人工審核 evidence_json 後，在 API 外部審核流程記錄 confirmed / rejected / deferred", + "若 row 缺失或狀態不符，停回 writer post-write smoke 與 closeout", + ], + "safe_boundaries": [ + "do_not_update_review_state_from_api", + "do_not_insert_missing_queue_row_from_api", + "do_not_read_approval_token_from_api", + "do_not_execute_cli_from_review_inventory", + "do_not_attach_scheduler_from_review_inventory", + "read_only_inventory_only_when_operator_requested", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 76247ee..09512ec 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -12,9 +12,11 @@ from services.market_intel.candidate_queue_writer_run_readiness import build_can from services.market_intel.candidate_queue_writer_run_receipt import build_candidate_queue_writer_run_receipt from services.market_intel.candidate_queue_writer_run_closeout import build_candidate_queue_writer_run_closeout from services.market_intel.candidate_queue_review_handoff import build_candidate_queue_review_handoff +from services.market_intel.candidate_queue_review_inventory import build_candidate_queue_review_inventory -BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "database_connection_opened", "database_write_executed", "database_commit_executed", "scheduler_attached") +BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "database_connection_opened", "database_write_executed", "database_commit_executed", "scheduler_attached", "writes_executed", "would_write_database") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory") def _run_review_preview_safe(payload, mode): @@ -99,6 +101,11 @@ def build_deployment_readiness_preview( migration_catalog_review = service.build_migration_catalog_review() migration_live_smoke = service.build_migration_live_smoke() live_db_inventory = service.build_live_db_inventory() + candidate_queue_review_inventory = build_candidate_queue_review_inventory( + review_handoff=candidate_queue_review_handoff, + postwrite_smoke=candidate_queue_writer_postwrite_smoke, + live_db_inventory=live_db_inventory, + ) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -321,6 +328,10 @@ def build_deployment_readiness_preview( candidate_queue_review_handoff, "candidate_queue_review_handoff_preview", ), + "candidate_queue_review_inventory_preview_safe": _run_review_preview_safe( + candidate_queue_review_inventory, + "candidate_queue_review_inventory_preview", + ), "match_review_plan_preview_safe": bool( match_review_plan["mode"] == "match_review_plan_preview" and not match_review_plan["review_queue_created"] @@ -508,41 +519,7 @@ def build_deployment_readiness_preview( "required_manual_steps": required_manual_steps, "fallback_plan": fallback_plan, "safe_deploy_boundaries": safe_deploy_boundaries, - "production_smoke_targets": [ - "/health", - "/market_intel", - "/api/market_intel/status", - "/api/market_intel/deployment_readiness", - "/api/market_intel/schema_smoke", - "/api/market_intel/schema_db_probe", - "/api/market_intel/platform_seed_db_diff", - "/api/market_intel/legacy_source_bridge", - "/api/market_intel/mcp_readiness", - "/api/market_intel/mcp_tool_contract", - "/api/market_intel/mcp_deploy_preflight", - "/api/market_intel/mcp_activation_runbook", - "/api/market_intel/mcp_fetch_gate", - "/api/market_intel/scheduler_plan", - "/api/market_intel/manual_sample_plan", - "/api/market_intel/manual_sample_acceptance", - "/api/market_intel/manual_sample_review", - "/api/market_intel/match_review_plan", - "/api/market_intel/opportunity_plan", - "/api/market_intel/opportunity_scoring_plan", - "/api/market_intel/opportunity_evidence_plan", - "/api/market_intel/opportunity_alert_plan", - "/api/market_intel/migration_apply_drill", - "/api/market_intel/migration_catalog_review", - "/api/market_intel/migration_live_smoke", - "/api/market_intel/live_db_inventory", - "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", - "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", - "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", - ], + "production_smoke_targets": list(PRODUCTION_SMOKE_TARGETS), "status": status.to_dict(), "schema_smoke": schema_smoke, "writer_plan_summary": { @@ -591,6 +568,7 @@ def build_deployment_readiness_preview( "candidate_queue_writer_run_receipt": candidate_queue_writer_run_receipt, "candidate_queue_writer_run_closeout": candidate_queue_writer_run_closeout, "candidate_queue_review_handoff": candidate_queue_review_handoff, + "candidate_queue_review_inventory": candidate_queue_review_inventory, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, "opportunity_scoring_plan": opportunity_scoring_plan, diff --git a/services/market_intel/service.py b/services/market_intel/service.py index f8048c9..c6388c9 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -108,7 +108,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務，先集中 feature gate 與安全狀態。""" - phase = "phase_64_candidate_queue_review_handoff" + phase = "phase_65_candidate_queue_review_inventory" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index c7a7ce8..75b74db 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -631,6 +631,9 @@ + @@ -969,6 +972,7 @@ const sampleCandidateQueueRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-receipt]') : null; const sampleCandidateQueueRunCloseout = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-closeout]') : null; const sampleCandidateQueueReviewHandoff = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-handoff]') : null; + const sampleCandidateQueueReviewInventory = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-inventory]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -984,6 +988,7 @@ const sampleCandidateQueueRunReceiptEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_receipt') }}"; const sampleCandidateQueueRunCloseoutEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_closeout') }}"; const sampleCandidateQueueReviewHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_review_handoff') }}"; + const sampleCandidateQueueReviewInventoryEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_inventory') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -3129,6 +3134,121 @@ } }; + const renderCandidateQueueReviewInventory = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const operator = data.operator_inventory_summary || {}; + const table = data.alert_review_queue_table || {}; + const smoke = data.postwrite_smoke_summary || {}; + const live = data.live_inventory_summary || {}; + const gates = data.gates || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `inventory=${data.review_inventory_ready ? 'ready' : 'blocked'}`, + `read_only=${data.read_only_query_executed ? 'yes' : 'no'}`, + `found=${(data.found_dedupe_keys || []).length}`, + `api_update=${data.api_updates_review_state ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只做 queue review inventory 只讀交接檢查；不更新 review_state、不補寫 queue、不讀 token、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
expected：${escapeHtml((data.expected_dedupe_keys || []).join(', ') || 'none')} / found：${escapeHtml((data.found_dedupe_keys || []).join(', ') || 'none')}
+
+
+

INVENTORY GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 inventory gates。
' + }
+
+
+

QUEUE TABLE

+
+ ${[ + ['table_exists', table.exists], + ['row_count', table.row_count ?? 'n/a'], + ['table_status', table.status || 'not_reported'], + ['postwrite_mode', smoke.mode || 'planned'], + ['smoke_passed', smoke.postwrite_smoke_passed] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

LIVE INVENTORY

+
+ ${[ + ['live_mode', live.mode || 'planned'], + ['summary_ready', live.summary_ready], + ['total_rows', live.total_rows ?? 'n/a'], + ['operator_read_only', operator.operator_confirmed_inventory_read_only], + ['approval_token_submitted_to_api', operator.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

ROWS

+
${ + (data.row_summaries || []).map(row => ` +
+
+ ${escapeHtml(row.dedupe_key || 'unknown')} + ${escapeHtml(row.priority_lane || 'n/a')} / score=${escapeHtml(String(row.total_score ?? 'n/a'))} +
+ ${escapeHtml(row.review_state || 'unknown')} +
+ `).join('') || '
尚未執行只讀 row inventory。
' + }
+
+
+ `; + }; + + const loadCandidateQueueReviewInventory = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue review inventory 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewInventoryEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewInventory(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review inventory 檢查失敗：${escapeHtml(error.message)}
`; + } + }; + const renderSchedulerMeta = data => { schedulerMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -4662,6 +4782,9 @@ if (sampleCandidateQueueReviewHandoff) { sampleCandidateQueueReviewHandoff.addEventListener('click', loadCandidateQueueReviewHandoff); } + if (sampleCandidateQueueReviewInventory) { + sampleCandidateQueueReviewInventory.addEventListener('click', loadCandidateQueueReviewInventory); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 2591e99..b5a2809 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -164,6 +164,18 @@ def _build_candidate_queue_writer_receipt_fixture(batch_id="sample-batch-receipt "missing_count": 0, "found_dedupe_keys": expected_keys, "missing_dedupe_keys": [], + "row_summaries": [ + { + "dedupe_key": key, + "review_state": "needs_review", + "priority_lane": "watch", + "total_score": 82.5, + "source_batch_id": batch_id, + "created_at": "2026-05-19T12:00:00", + "updated_at": "2026-05-19T12:00:00", + } + for key in expected_keys + ], } return { "sample_result": sample_result, @@ -678,6 +690,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-sample-candidate-queue-run-receipt" in template assert "data-market-intel-sample-candidate-queue-run-closeout" in template assert "data-market-intel-sample-candidate-queue-review-handoff" in template + assert "data-market-intel-sample-candidate-queue-review-inventory" in template assert "data-market-intel-approval" in template assert "data-market-intel-approval-gates" in template assert "data-market-intel-deploy" in template @@ -731,6 +744,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel.market_intel_manual_sample_candidate_queue_review_handoff" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_inventory" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -767,7 +784,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_64_candidate_queue_review_handoff" + assert bridge["phase"] == "phase_65_candidate_queue_review_inventory" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -925,7 +942,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_64_candidate_queue_review_handoff" + assert contract["phase"] == "phase_65_candidate_queue_review_inventory" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1058,7 +1075,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1071,7 +1088,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_64_candidate_queue_review_handoff" + assert gate["phase"] == "phase_65_candidate_queue_review_inventory" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1141,7 +1158,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1153,7 +1170,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1201,7 +1218,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1212,7 +1229,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_64_candidate_queue_review_handoff" + assert acceptance["phase"] == "phase_65_candidate_queue_review_inventory" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1254,7 +1271,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1266,7 +1283,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_64_candidate_queue_review_handoff" + assert review["phase"] == "phase_65_candidate_queue_review_inventory" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1377,7 +1394,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1416,7 +1433,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_64_candidate_queue_review_handoff" + assert review["phase"] == "phase_65_candidate_queue_review_inventory" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1478,7 +1495,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1558,7 +1575,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_64_candidate_queue_review_handoff" + assert handoff["phase"] == "phase_65_candidate_queue_review_inventory" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1622,7 +1639,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1681,7 +1698,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_64_candidate_queue_review_handoff" + assert queue_draft["phase"] == "phase_65_candidate_queue_review_inventory" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1755,7 +1772,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1818,7 +1835,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_64_candidate_queue_review_handoff" + assert approval["phase"] == "phase_65_candidate_queue_review_inventory" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -1896,7 +1913,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -1959,7 +1976,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_64_candidate_queue_review_handoff" + assert transaction["phase"] == "phase_65_candidate_queue_review_inventory" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2039,7 +2056,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -3133,6 +3150,254 @@ def test_candidate_queue_review_handoff_preview_is_manual_only(): ) +def test_candidate_queue_review_inventory_preview_is_read_only(): + from services.market_intel.candidate_queue_review_handoff import ( + build_candidate_queue_review_handoff, + ) + from services.market_intel.candidate_queue_review_inventory import ( + build_candidate_queue_review_inventory, + ) + from services.market_intel.candidate_queue_writer_run_closeout import ( + build_candidate_queue_writer_run_closeout, + ) + from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, + ) + + fixture = _build_candidate_queue_writer_receipt_fixture() + operator_evidence = { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_inventory_read_only": True, + } + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output=fixture["writer_output"], + postwrite_smoke_result=fixture["postwrite_smoke_result"], + operator_evidence=fixture["operator_evidence"], + ) + closeout = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence=operator_evidence, + ) + handoff = build_candidate_queue_review_handoff( + transaction_preview=fixture["transaction"], + run_closeout=closeout, + operator_evidence=operator_evidence, + ) + postwrite_smoke = { + **fixture["postwrite_smoke_result"], + "database_commit_executed": False, + "row_summaries": [ + { + "dedupe_key": fixture["expected_keys"][0], + "review_state": "needs_review", + "priority_lane": "review", + "total_score": 94, + "source_batch_id": fixture["sample_result"]["batch_id"], + } + ], + } + live_db_inventory = { + "mode": "live_db_inventory_read_only", + "summary_ready": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "migration_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "table_statuses": [ + { + "table": "market_alert_review_queue", + "exists": True, + "row_count": 1, + "status": "loaded", + } + ], + "total_rows": 1, + "alert_review_state_breakdown": [ + { + "review_state": "needs_review", + "priority_lane": "review", + "alert_count": 1, + } + ], + } + inventory = build_candidate_queue_review_inventory( + review_handoff=handoff, + postwrite_smoke=postwrite_smoke, + live_db_inventory=live_db_inventory, + operator_evidence=operator_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_inventory( + review_handoff=handoff, + postwrite_smoke=postwrite_smoke, + live_db_inventory=live_db_inventory, + operator_evidence={**operator_evidence, "approval_token": TEST_APPROVAL_TOKEN}, + execute_requested=True, + ) + + assert inventory["mode"] == "candidate_queue_review_inventory_preview" + assert inventory["review_inventory_ready"] is True + assert inventory["ready_for_human_decision_review"] is True + assert inventory["ready_for_api_review_state_update"] is False + assert inventory["ready_for_api_database_write"] is False + assert inventory["ready_for_scheduler_attach"] is False + assert inventory["api_executes_cli"] is False + assert inventory["api_reads_approval_token"] is False + assert inventory["api_writes_database"] is False + assert inventory["api_updates_review_state"] is False + assert inventory["read_only_query_executed"] is True + assert inventory["database_connection_opened"] is True + assert inventory["database_write_executed"] is False + assert inventory["database_commit_executed"] is False + assert inventory["scheduler_attached"] is False + assert inventory["expected_dedupe_keys"] == fixture["expected_keys"] + assert inventory["found_dedupe_keys"] == fixture["expected_keys"] + assert inventory["missing_dedupe_keys"] == [] + assert inventory["row_summaries"][0]["review_state"] == "needs_review" + assert inventory["alert_review_queue_table"]["exists"] is True + assert inventory["blocked_reasons"] == [] + assert "do_not_update_review_state_from_api" in inventory["safe_boundaries"] + assert token_leak["review_inventory_ready"] is False + assert token_leak["operator_inventory_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "review_inventory_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + +def test_candidate_queue_review_inventory_preview_is_read_only_manual_gate(): + from services.market_intel.candidate_queue_review_handoff import ( + build_candidate_queue_review_handoff, + ) + from services.market_intel.candidate_queue_review_inventory import ( + build_candidate_queue_review_inventory, + ) + from services.market_intel.candidate_queue_writer_run_closeout import ( + build_candidate_queue_writer_run_closeout, + ) + from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, + ) + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-review-inventory" + ) + operator_evidence = { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_inventory_read_only": True, + } + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output=fixture["writer_output"], + postwrite_smoke_result=fixture["postwrite_smoke_result"], + operator_evidence=fixture["operator_evidence"], + ) + closeout = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence=operator_evidence, + ) + handoff = build_candidate_queue_review_handoff( + transaction_preview=fixture["transaction"], + run_closeout=closeout, + operator_evidence=operator_evidence, + ) + live_inventory = { + "mode": "live_db_inventory_read_only", + "summary_ready": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "migration_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "total_rows": len(fixture["expected_keys"]), + "table_statuses": [ + { + "table": "market_alert_review_queue", + "exists": True, + "row_count": len(fixture["expected_keys"]), + "status": "loaded", + } + ], + "alert_review_state_breakdown": [ + { + "review_state": "needs_review", + "priority_lane": "watch", + "alert_count": len(fixture["expected_keys"]), + } + ], + } + + inventory = build_candidate_queue_review_inventory( + review_handoff=handoff, + postwrite_smoke=fixture["postwrite_smoke_result"], + live_db_inventory=live_inventory, + operator_evidence=operator_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_inventory( + review_handoff=handoff, + postwrite_smoke=fixture["postwrite_smoke_result"], + live_db_inventory=live_inventory, + operator_evidence={**operator_evidence, "approval_token": TEST_APPROVAL_TOKEN}, + execute_requested=True, + ) + + assert inventory["mode"] == "candidate_queue_review_inventory_preview" + assert inventory["review_inventory_ready"] is True + assert inventory["ready_for_human_decision_review"] is True + assert inventory["ready_for_api_review_state_update"] is False + assert inventory["ready_for_api_database_write"] is False + assert inventory["ready_for_scheduler_attach"] is False + assert inventory["api_executes_cli"] is False + assert inventory["api_reads_approval_token"] is False + assert inventory["api_writes_database"] is False + assert inventory["api_updates_review_state"] is False + assert inventory["read_only_query_executed"] is True + assert inventory["database_write_executed"] is False + assert inventory["database_commit_executed"] is False + assert inventory["scheduler_attached"] is False + assert inventory["expected_dedupe_keys"] == fixture["expected_keys"] + assert inventory["found_dedupe_keys"] == fixture["expected_keys"] + assert inventory["missing_dedupe_keys"] == [] + assert inventory["row_summaries"][0]["review_state"] == "needs_review" + assert inventory["alert_review_queue_table"]["exists"] is True + assert "do_not_update_review_state_from_api" in inventory["safe_boundaries"] + assert inventory["blocked_reasons"] == [] + assert token_leak["review_inventory_ready"] is False + assert "review_inventory_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -3175,7 +3440,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -3232,7 +3497,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -3321,7 +3586,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -3375,7 +3640,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -3431,7 +3696,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -3497,7 +3762,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -3799,7 +4064,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -3847,7 +4112,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -3896,7 +4161,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -3913,6 +4178,68 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert data["blocked_reasons"] == [] +def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-review-inventory-route" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_inventory" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_inventory?execute=false", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_inventory_read_only": True, + }, + "writer_output": fixture["writer_output"], + "postwrite_smoke_result": fixture["postwrite_smoke_result"], + }, + ) + data = response.get_json() + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_review_inventory_preview" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" + assert data["execute_requested"] is False + assert data["review_inventory_ready"] is False + assert data["ready_for_human_decision_review"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["read_only_query_executed"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["expected_dedupe_keys"] == fixture["expected_keys"] + assert "read_only_inventory_executed" in data["blocked_reasons"] + assert "do_not_insert_missing_queue_row_from_api" in data["safe_boundaries"] + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -3941,7 +4268,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -3966,7 +4293,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -4004,7 +4331,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -4015,7 +4342,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -4051,7 +4378,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -4062,7 +4389,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -4103,7 +4430,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -4114,7 +4441,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -4162,7 +4489,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -4174,7 +4501,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -4220,7 +4547,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -4233,7 +4560,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_64_candidate_queue_review_handoff" + assert plan["phase"] == "phase_65_candidate_queue_review_inventory" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -4318,7 +4645,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -4396,7 +4723,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -4411,7 +4738,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_64_candidate_queue_review_handoff" + assert readiness["phase"] == "phase_65_candidate_queue_review_inventory" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -4837,6 +5164,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["checks"]["candidate_queue_review_handoff_preview_safe"] is True ) + assert ( + readiness["checks"]["candidate_queue_review_inventory_preview_safe"] + is True + ) assert readiness["checks"]["match_review_plan_preview_safe"] is True assert readiness["checks"]["opportunity_plan_preview_safe"] is True assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True @@ -4907,6 +5238,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/manual_sample_review/candidate_queue_review_handoff" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/candidate_queue_review_inventory" + in readiness["production_smoke_targets"] + ) assert readiness["write_approval_runbook"]["ready_for_real_write"] is False assert readiness["write_approval_runbook"]["writes_executed"] is False assert readiness["migration_blueprint"]["migration_executed"] is False @@ -5470,6 +5805,47 @@ def test_deployment_readiness_reports_app_only_release_gate(): is False ) assert readiness["candidate_queue_review_handoff"]["scheduler_attached"] is False + assert ( + readiness["candidate_queue_review_inventory"]["mode"] + == "candidate_queue_review_inventory_preview" + ) + assert ( + readiness["candidate_queue_review_inventory"]["review_inventory_ready"] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"][ + "ready_for_api_review_state_update" + ] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"]["api_updates_review_state"] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"]["read_only_query_executed"] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"]["database_connection_opened"] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"]["database_write_executed"] + is False + ) + assert ( + readiness["candidate_queue_review_inventory"]["database_commit_executed"] + is False + ) + assert readiness["candidate_queue_review_inventory"]["scheduler_attached"] is False assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False assert readiness["scheduler_plan"]["crawler_job_started"] is False assert readiness["scheduler_plan"]["database_write_executed"] is False @@ -5574,7 +5950,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_64_candidate_queue_review_handoff" + assert drill["phase"] == "phase_65_candidate_queue_review_inventory" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -5689,7 +6065,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -5701,7 +6077,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_64_candidate_queue_review_handoff" + assert review["phase"] == "phase_65_candidate_queue_review_inventory" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -5816,7 +6192,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -5829,7 +6205,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_64_candidate_queue_review_handoff" + assert smoke["phase"] == "phase_65_candidate_queue_review_inventory" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -5891,7 +6267,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -5904,7 +6280,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_64_candidate_queue_review_handoff" + assert inventory["phase"] == "phase_65_candidate_queue_review_inventory" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -6048,7 +6424,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -6275,7 +6651,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_64_candidate_queue_review_handoff" + assert data["phase"] == "phase_65_candidate_queue_review_inventory" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False