diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 55c202a..64df9ee 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.409 補市場情報 MCP fetch target review gate：新增 `mcp_fetch_target_review` read-only builder、GET/POST endpoint、UI target review 審核面板與 deployment readiness smoke target，讓 manual fetch handoff 通過後，先人工審核 adapter registry 公開入口、每平台節流、樣本數、timeout 與 rollback plan；API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler，也不會自動打開 manual fetch。 - V10.405 補市場情報 MCP manual fetch handoff gate：新增 `mcp_manual_fetch_handoff` read-only builder、GET/POST endpoint、UI handoff package 審核面板與 deployment readiness smoke target，將 runtime promotion package 與操作員安全確認合併成「可進人工 fetch gate 審核」的交接收據；API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler，也不會自動打開 manual fetch。 - V10.379 補市場情報 MCP runtime promotion gate：新增 `mcp_runtime_promotion` read-only builder、GET/POST endpoint、UI promotion package 審核面板與 deployment readiness smoke target，將 MCP activation evidence 與 runtime smoke receipt 合併成可審核的 runtime promotion package；API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler，也不會自動打開人工 fetch gate。 - V10.366 補市場情報 MCP runtime smoke 收據審核：新增 `mcp_runtime_smoke_receipt` read-only builder、GET/POST endpoint、UI receipt JSON 審核面板與 deployment readiness smoke target，讓操作員貼上 `/api/market_intel/mcp_readiness?execute=true&timeout=3` 的實際收據後，判斷 external/internal MCP runtime 是否可升級為已驗收；API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler，且會阻擋任何 DB write/commit/scheduler/writes 旗標或原始 readiness blocked reasons。 diff --git a/config.py b/config.py index 8993933..6da6b19 100644 --- a/config.py +++ b/config.py @@ -325,7 +325,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.408" +SYSTEM_VERSION = "V10.409" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index d0e74f1..9d0d1a0 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -159,6 +159,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-18 追加 MCP activation runbook preview：`services.market_intel.mcp_activation_runbook` 與 `/api/market_intel/mcp_activation_runbook` 只輸出人工啟用順序與 gate：補必要 env、人工建立/驗證 `mcp_readonly`、啟動外部 MCP stack、四個 health 全過、最後才允許 `MCP_ROUTER_ENABLED=true`。此 runbook 不執行 docker/SSH、不寫 env、不建立 DB role、不跑 health、不啟用 router、不寫 DB、不掛 scheduler。 - 2026-05-18 追加 MCP fetch gate preview：`services.market_intel.mcp_fetch_gate` 與 `/api/market_intel/mcp_fetch_gate` 將人工 discovery fetch 改成必須先通過市場情報 feature flags、MCP readiness、router、外部 MCP health 與 tool contract gate；`run_manual_discovery(fetch=true)` 即使 flags 開啟也會先被此 gate 阻擋，直到 MCP 條件全過。此 gate 不抓電商頁、不寫 DB、不掛 scheduler、不執行 deployment，UI 預設只呼叫 `fetch=false&execute=false`。 - 2026-05-24 追加 MCP manual fetch handoff gate：`services.market_intel.mcp_manual_fetch_handoff` 與 `/api/market_intel/mcp_manual_fetch_handoff` 將 runtime promotion package 與操作員安全確認合併成可審核 handoff，只放行到人工 fetch gate operator review；API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler，也不會自動打開 manual fetch。 +- 2026-05-24 追加 MCP fetch target review gate：`services.market_intel.mcp_fetch_target_review` 與 `/api/market_intel/mcp_fetch_target_review` 在 manual fetch handoff 後審核 adapter registry 公開入口白名單、平台來源、每平台 delay / timeout / max pages / sample_limit、rollback plan 與操作員確認；API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler，也不會自動打開 manual fetch，只放行到後續人工 fetch run package review。 - 2026-05-18 追加 scheduler attach plan preview：`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB；排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview：`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP；價格只能作為輔助訊號，不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview：`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB；高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 430d67c..321901c 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -38,6 +38,7 @@ - 2026-05-21 追記：同步專業比價分級連動合併後的 `services/competitor_intel_repository.py` 與 `services/nemoton_dispatcher_service.py` 行數；此處只更新 inventory，不變更比價或告警行為。 - 2026-05-21 追記：同步市場情報 MCP runtime promotion gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數；此處只更新 inventory，後續市場情報 MCP route 應拆出子 Blueprint。 - 2026-05-24 追記：同步市場情報 MCP manual fetch handoff gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數；本次新增邏輯已放在獨立 `services/market_intel/mcp_manual_fetch_handoff.py`，route 僅保留薄 glue，下一個 MCP/UI gate 應優先拆出子 Blueprint 或 route registration helper。 +- 2026-05-24 追記：同步市場情報 MCP fetch target review gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數；本次新增邏輯已放在獨立 `services/market_intel/mcp_fetch_target_review.py`，route 僅保留薄 glue，後續市場情報 MCP route 應拆出子 Blueprint 或 route registration helper。 - 2026-05-21 追記：同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 - 2026-05-21 追記：同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 - 2026-05-21 追記：同步 EDM 失效頁 alert guard 與 REJURAN 唇膏寬價差 exact-identity matcher 更新後的 `scheduler.py`、`services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 @@ -71,7 +72,7 @@ | 940 | `services/import_service.py` | P2 import service | validators / import writers / report builders | | 933 | `services/telegram_templates.py` | P2 Telegram templates | alert template groups / channel-specific formatting / reusable render helpers | | 867 | `services/token_report_service.py` | P2 token report service | query / aggregation / chart payload / notification formatting | -| 3313 | `services/marketplace_product_matcher.py` | P2 marketplace matcher | identity parsing / unit-comparable scoring / search term quality / persistence normalization | +| 3365 | `services/marketplace_product_matcher.py` | P2 marketplace matcher | identity parsing / unit-comparable scoring / search term quality / persistence normalization | | 865 | `routes/daily_sales_routes.py` | P2 Daily Sales Blueprint | route glue / export helpers / daily query and formatting service | | 961 | `services/ollama_service.py` | P2 Ollama client | host health / request client / fallback policy / response parsing | | 849 | `services/pchome_crawler.py` | P2 PChome crawler | search fetch / parsing / fallback source handling / rate limit policy | @@ -82,8 +83,8 @@ | 1327 | `services/competitor_intel_repository.py` | P2 competitor intel repository | review queue query / cache shaping / formatting helpers | | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | -| 884 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 954 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 914 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | +| 979 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index e293746..d792398 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24：PChome 近門檻身份回收第二輪 +- **V10.409 MCP fetch target review gate**: 新增 `mcp_fetch_target_review` read-only builder、GET/POST endpoint、UI target review 審核面板與 deployment readiness smoke target，讓 manual fetch handoff 通過後，先審核 adapter registry 公開入口、每平台節流、樣本數、timeout 與 rollback plan；API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler，也不會自動打開 manual fetch。 - **V10.408 OPI 指甲油 catalog review-only 回收**: marketplace matcher 針對 OPI 類光繚指甲油加入同系列 catalog focused identity，只在「白日夢遊」或「驕傲果凍」系列名雙方一致時進 `identity_review`；12色/11色視為可選色號數差異，不當作販售件數，跨系列仍維持 suppress。下一輪回刷會搭配 KATE 怪獸級持色唇膏限量款既有規則候選，延續不放寬全域門檻的近門檻回收策略。 - **V10.407 Hermes/OpenClaw runner 熱駐留收斂**: V10.406 後續觀測顯示 GCP-B 仍會被 Hermes/OpenClaw 的 `24h` keep-alive runner 壓高 load，導致 GCP-B generate timeout 後轉落 111。`HERMES_KEEP_ALIVE` 與 `OPENCLAW_STRATEGY_OLLAMA_KEEP_ALIVE` 改為 env 可控且預設 `5m`，並補測試禁止 OpenClaw strategy 再硬寫 `keep_alive="24h"`；GCP-A 目前從 188 仍逾時，需另行修復主機/防火牆。 - **V10.406 Code Review Ollama keep-alive 收斂**: production audit 顯示 Gemini 24h 已為 0，但 GCP-A `34.143.170.20:11434` 從 188 逾時、GCP-B 曾因多個 Ollama runner 長駐造成 generate timeout，導致部署後 Code Review 轉落 111。`CODE_REVIEW_OLLAMA_KEEP_ALIVE` 預設由 `24h` 改為 `5m`，讓 GCP-B/111 的 code review runner 不再長時間常駐；實測已重啟 GCP-B Ollama 並確認 `gemma3:4b` 可於約 6.2s 完成短生成。 diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index f4ba7de..c16a837 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -19,6 +19,9 @@ from services.market_intel.candidate_queue_writer_run_receipt import build_candi from services.market_intel.candidate_queue_writer_run_closeout import build_candidate_queue_writer_run_closeout from services.market_intel.candidate_queue_review_handoff import build_candidate_queue_review_handoff from services.market_intel.mcp_activation_evidence import build_mcp_activation_evidence_preview +from services.market_intel.mcp_fetch_target_review import ( + build_mcp_fetch_target_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -249,6 +252,33 @@ def market_intel_mcp_manual_fetch_handoff(): ) +@market_intel_bp.route("/api/market_intel/mcp_fetch_target_review", methods=["GET", "POST"]) +@login_required +def market_intel_mcp_fetch_target_review(): + handoff_package = {} + handoff_review = None + target_review = {} + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = payload.get("target_review_package") or payload + handoff_package = package.get("handoff_package", {}) + handoff_review = package.get("handoff_review") + target_review = ( + package + if "platform_targets" in package + else package.get("target_review", {}) + ) + + return jsonify( + build_mcp_fetch_target_review_preview( + handoff_package=handoff_package, + handoff_review=handoff_review, + target_review=target_review, + phase=_service().phase, + ) + ) + + @market_intel_bp.route("/api/market_intel/scheduler_plan") @login_required def market_intel_scheduler_plan(): diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 7e67695..d323a25 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -60,6 +60,9 @@ from services.market_intel.candidate_queue_review_ai_summary_persistence_transac from services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight import build_candidate_queue_review_ai_summary_persistence_writer_preflight from services.market_intel.candidate_queue_review_ai_summary_run_package import build_candidate_queue_review_ai_summary_run_package from services.market_intel.mcp_activation_evidence import build_mcp_activation_evidence_preview +from services.market_intel.mcp_fetch_target_review import ( + build_mcp_fetch_target_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -157,6 +160,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_manual_fetch_handoff",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_target_review",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -181,6 +189,9 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s runtime_status=status, phase=service.phase, ) + mcp_fetch_target_review = build_mcp_fetch_target_review_preview( + phase=service.phase, + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -442,6 +453,19 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_manual_fetch_handoff["api_writes_database"] and not mcp_manual_fetch_handoff["api_uses_external_network"] ), + "mcp_fetch_target_review_preview_safe": bool( + mcp_fetch_target_review["mode"] == "mcp_fetch_target_review_preview" + and not mcp_fetch_target_review["payload_persisted"] + and not mcp_fetch_target_review["target_review_persisted"] + and not mcp_fetch_target_review["manual_fetch_gate_opened_by_api"] + and not mcp_fetch_target_review["network_request_allowed"] + and not mcp_fetch_target_review["api_opens_database_connection"] + and not mcp_fetch_target_review["api_writes_database"] + and not mcp_fetch_target_review["api_uses_external_network"] + and not mcp_fetch_target_review["database_write_executed"] + and not mcp_fetch_target_review["fetch_executed"] + and not mcp_fetch_target_review["scheduler_attached"] + ), "scheduler_plan_preview_safe": bool( scheduler_plan["mode"] == "scheduler_attach_plan_preview" and not scheduler_plan["scheduler_registration_executed"] @@ -877,6 +901,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_runtime_smoke_receipt": mcp_runtime_smoke_receipt, "mcp_runtime_promotion": mcp_runtime_promotion, "mcp_manual_fetch_handoff": mcp_manual_fetch_handoff, + "mcp_fetch_target_review": mcp_fetch_target_review, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_target_review.py b/services/market_intel/mcp_fetch_target_review.py new file mode 100644 index 0000000..e31c4fd --- /dev/null +++ b/services/market_intel/mcp_fetch_target_review.py @@ -0,0 +1,557 @@ +"""市場情報 MCP manual fetch target review preview。 + +本模組只審核下一段人工 fetch run package 前的公開目標、節流、樣本數與 +回退條件；不發 HTTP request、不開 DB、不保存 payload、不掛 scheduler。 +""" + +from services.market_intel.adapters import get_adapter_registry +from services.market_intel.mcp_manual_fetch_handoff import ( + build_mcp_manual_fetch_handoff_preview, +) + + +MIN_DELAY_SECONDS = 1.0 +MAX_TIMEOUT_SECONDS = 30 +MAX_SAMPLE_LIMIT = 5 + +TARGET_ACKNOWLEDGEMENT_LABELS = { + "target_urls_from_adapter_registry": "目標 URL 只能來自 adapter registry 的公開入口", + "public_pages_only": "只允許公開頁面與公開結構化資料", + "rate_limit_reviewed": "每平台 delay / timeout / max pages 已人工確認", + "sample_limits_reviewed": "每平台樣本數已人工確認且維持小批次", + "no_login_no_antibot": "不得登入、不得處理會員資料、不得繞反爬或帳號池", + "no_api_fetch_execution": "本 API 不執行抓取或外部 network request", + "no_database_write": "本階段不得寫 DB", + "no_scheduler_attach": "不得掛 scheduler", +} + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_external_network_in_api", + "api_executes_health_check", + "api_executes_docker", + "api_executes_ssh", + "api_opens_database_connection", + "api_writes_database", + "api_uses_external_network", + "attach_scheduler", + "database_session_created", + "database_write_executed", + "database_commit_executed", + "external_network_executed", + "fetch_executed", + "manual_fetch_gate_opened_by_api", + "network_request_allowed", + "scheduler_attached", + "write_database", + "writes_executed", + "would_write_database", +) + + +def _adapter_targets(registry): + return [ + { + "platform_code": adapter.platform_code, + "platform_name": adapter.platform_name, + "base_url": adapter.base_url, + "safety_policy": adapter.safety_policy.to_dict(), + "sources": [source.to_dict() for source in adapter.campaign_sources()], + } + for adapter in registry.values() + ] + + +def _sample_target_review(registry): + targets = [] + for adapter in registry.values(): + policy = adapter.safety_policy + targets.append( + { + "platform_code": adapter.platform_code, + "source_keys": [ + source.source_key for source in adapter.campaign_sources() + ], + "public_pages_only": True, + "max_pages": min(2, policy.max_pages_per_run), + "sample_limit": min(3, MAX_SAMPLE_LIMIT), + "delay_seconds": max(MIN_DELAY_SECONDS, policy.request_interval_sec), + "timeout_seconds": min(policy.timeout_sec, MAX_TIMEOUT_SECONDS), + "allow_external_network_in_api": False, + "write_database": False, + "attach_scheduler": False, + "requires_operator_run_command": True, + } + ) + + return { + "platform_targets": targets, + "rollback_plan": { + "feature_flag_kill_switch": True, + "stop_after_error_count": 2, + "preserve_run_log_only": True, + "no_db_rollback_needed": True, + }, + "operator_acknowledgements": { + key: True for key in TARGET_ACKNOWLEDGEMENT_LABELS + }, + } + + +def _sample_target_review_package(registry): + handoff = build_mcp_manual_fetch_handoff_preview() + return { + "handoff_package": handoff["sample_handoff_package"], + "target_review": _sample_target_review(registry), + } + + +def _target_review_from_input(target_review): + return target_review if isinstance(target_review, dict) else {} + + +def _handoff_review_from_inputs(handoff_package, handoff_review, phase): + if isinstance(handoff_review, dict) and handoff_review: + return handoff_review + + handoff_package = handoff_package if isinstance(handoff_package, dict) else {} + return build_mcp_manual_fetch_handoff_preview( + promotion_package=handoff_package.get("promotion_package", {}), + promotion_review=handoff_package.get("promotion_review"), + operator_acknowledgements=handoff_package.get( + "operator_acknowledgements", + {}, + ), + phase=phase, + ) + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + key_path = f"{path}.{key}" if path else key + if key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _build_known_source_index(registry): + return { + code: { + source.source_key + for source in adapter.campaign_sources() + } + for code, adapter in registry.items() + } + + +def _to_positive_float(value): + try: + parsed = float(value) + except (TypeError, ValueError): + return None + if parsed <= 0: + return None + return parsed + + +def _to_positive_int(value): + try: + parsed = int(value) + except (TypeError, ValueError): + return None + if parsed <= 0: + return None + return parsed + + +def _review_targets(target_review, registry): + known_sources = _build_known_source_index(registry) + platform_targets = target_review.get("platform_targets", []) + if not isinstance(platform_targets, list): + platform_targets = [] + + summaries = [] + unknown_platforms = [] + unknown_sources = [] + missing_sources = [] + unsafe_platforms = [] + rate_limit_violations = [] + sample_limit_violations = [] + + for target in platform_targets: + if not isinstance(target, dict): + unsafe_platforms.append("invalid_target_payload") + continue + + platform_code = str(target.get("platform_code") or "").lower() + adapter = registry.get(platform_code) + source_keys = target.get("source_keys") or [] + if isinstance(source_keys, str): + source_keys = [source_keys] + source_keys = [str(item) for item in source_keys if item] + + if not adapter: + unknown_platforms.append(platform_code or "missing_platform_code") + summaries.append( + { + "platform_code": platform_code, + "source_keys": source_keys, + "known_platform": False, + "ready": False, + } + ) + continue + + allowed_sources = known_sources.get(platform_code, set()) + missing = [key for key in source_keys if key not in allowed_sources] + if missing: + unknown_sources.extend( + { + "platform_code": platform_code, + "source_key": key, + } + for key in missing + ) + if not source_keys: + missing_sources.append(platform_code) + + policy = adapter.safety_policy + delay = _to_positive_float(target.get("delay_seconds")) + timeout = _to_positive_int(target.get("timeout_seconds")) + max_pages = _to_positive_int(target.get("max_pages")) + sample_limit = _to_positive_int(target.get("sample_limit")) + min_delay = max(MIN_DELAY_SECONDS, policy.request_interval_sec) + rate_ok = bool( + delay is not None + and delay >= min_delay + and timeout is not None + and timeout <= MAX_TIMEOUT_SECONDS + ) + sample_ok = bool( + max_pages is not None + and max_pages <= policy.max_pages_per_run + and sample_limit is not None + and sample_limit <= MAX_SAMPLE_LIMIT + ) + public_only = target.get("public_pages_only") is True + api_network_closed = not target.get("allow_external_network_in_api") + db_closed = not target.get("write_database") + scheduler_closed = not target.get("attach_scheduler") + operator_run_required = target.get("requires_operator_run_command") is True + + if not rate_ok: + rate_limit_violations.append(platform_code) + if not sample_ok: + sample_limit_violations.append(platform_code) + if not ( + public_only + and api_network_closed + and db_closed + and scheduler_closed + and operator_run_required + ): + unsafe_platforms.append(platform_code) + + summaries.append( + { + "platform_code": platform_code, + "platform_name": adapter.platform_name, + "base_url": adapter.base_url, + "source_keys": source_keys, + "known_platform": True, + "unknown_source_keys": missing, + "public_pages_only": public_only, + "delay_seconds": delay, + "min_delay_seconds": min_delay, + "timeout_seconds": timeout, + "max_pages": max_pages, + "max_pages_per_policy": policy.max_pages_per_run, + "sample_limit": sample_limit, + "max_sample_limit": MAX_SAMPLE_LIMIT, + "api_network_closed": api_network_closed, + "database_write_closed": db_closed, + "scheduler_attach_closed": scheduler_closed, + "operator_run_required": operator_run_required, + "rate_limit_ok": rate_ok, + "sample_limit_ok": sample_ok, + "ready": bool( + not missing + and source_keys + and public_only + and api_network_closed + and db_closed + and scheduler_closed + and operator_run_required + and rate_ok + and sample_ok + ), + } + ) + + return { + "summaries": summaries, + "target_count": len(summaries), + "source_target_count": sum( + len(item.get("source_keys", [])) for item in summaries + ), + "unknown_platforms": unknown_platforms, + "unknown_sources": unknown_sources, + "missing_sources": missing_sources, + "unsafe_platforms": unsafe_platforms, + "rate_limit_violations": rate_limit_violations, + "sample_limit_violations": sample_limit_violations, + } + + +def _acknowledgement_status(target_review): + acknowledgements = target_review.get("operator_acknowledgements", {}) + if not isinstance(acknowledgements, dict): + acknowledgements = {} + return { + key: { + "label": label, + "acknowledged": bool(acknowledgements.get(key)), + } + for key, label in TARGET_ACKNOWLEDGEMENT_LABELS.items() + } + + +def _rollback_plan_confirmed(target_review): + rollback = target_review.get("rollback_plan", {}) + if not isinstance(rollback, dict): + return False + error_count = _to_positive_int(rollback.get("stop_after_error_count")) + return bool( + rollback.get("feature_flag_kill_switch") is True + and rollback.get("preserve_run_log_only") is True + and rollback.get("no_db_rollback_needed") is True + and error_count is not None + and error_count <= 3 + ) + + +def build_mcp_fetch_target_review_preview( + *, + handoff_package=None, + handoff_review=None, + target_review=None, + phase=None, +): + """建立 manual fetch target review；只輸出審核結果，不執行 fetch。""" + registry = get_adapter_registry() + handoff_package = handoff_package if isinstance(handoff_package, dict) else {} + handoff = _handoff_review_from_inputs(handoff_package, handoff_review, phase) + target_review_payload = _target_review_from_input(target_review) + target_payload_received = bool(target_review_payload) + target_payload_valid_object = isinstance(target_review, dict) if target_review is not None else True + target_report = _review_targets(target_review_payload, registry) + acknowledgement_status = _acknowledgement_status(target_review_payload) + acknowledgements_complete = all( + item["acknowledged"] for item in acknowledgement_status.values() + ) + blocked_side_effects = _blocked_side_effects(target_review_payload) + handoff_side_effects = _blocked_side_effects(handoff) + handoff_accepted = bool(handoff.get("manual_fetch_handoff_accepted")) + no_api_fetch_execution = bool( + not target_review_payload.get("allow_external_network_in_api") + and not target_review_payload.get("fetch_executed") + and not target_review_payload.get("network_request_allowed") + and not target_review_payload.get("manual_fetch_gate_opened_by_api") + ) + no_database_write = bool( + not target_review_payload.get("write_database") + and not target_review_payload.get("api_writes_database") + and not target_review_payload.get("database_write_executed") + ) + no_scheduler_attach = bool( + not target_review_payload.get("attach_scheduler") + and not target_review_payload.get("scheduler_attached") + ) + + gates = [ + { + "key": "manual_fetch_handoff_payload_or_review_received", + "passed": bool(handoff_package or handoff_review), + "label": "已提供 manual fetch handoff package 或已審核結果", + }, + { + "key": "manual_fetch_handoff_accepted", + "passed": handoff_accepted, + "label": "manual fetch handoff 已通過，可進入目標審核", + }, + { + "key": "target_payload_received", + "passed": target_payload_received, + "label": "已提供平台目標、節流、樣本數與回退計畫", + }, + { + "key": "target_payload_valid_object", + "passed": target_payload_valid_object, + "label": "target review payload 必須是 JSON object", + }, + { + "key": "adapter_targets_present", + "passed": bool(registry), + "label": "adapter registry 內已有可審核公開入口", + }, + { + "key": "all_target_platforms_known", + "passed": bool( + target_report["target_count"] + and not target_report["unknown_platforms"] + ), + "label": "所有目標平台都存在於 adapter registry", + }, + { + "key": "all_source_keys_known", + "passed": bool( + target_report["target_count"] + and not target_report["unknown_sources"] + and not target_report["missing_sources"] + ), + "label": "所有來源 key 都存在於對應平台公開入口白名單", + }, + { + "key": "public_pages_only_confirmed", + "passed": bool( + target_report["target_count"] + and not target_report["unsafe_platforms"] + ), + "label": "每個平台都確認公開頁面、人工命令、API 不抓取/不寫入/不掛排程", + }, + { + "key": "rate_limits_within_policy", + "passed": bool( + target_report["target_count"] + and not target_report["rate_limit_violations"] + ), + "label": "每平台 delay 與 timeout 未突破安全政策", + }, + { + "key": "sample_limits_within_policy", + "passed": bool( + target_report["target_count"] + and not target_report["sample_limit_violations"] + ), + "label": "每平台 max_pages 與 sample_limit 維持小批次", + }, + { + "key": "rollback_plan_confirmed", + "passed": _rollback_plan_confirmed(target_review_payload), + "label": "已確認 kill switch、錯誤停止門檻、只保留 run log 與無 DB rollback", + }, + { + "key": "operator_acknowledgements_complete", + "passed": acknowledgements_complete, + "label": "操作員已確認來源、公開頁面、節流、樣本數、無登入/反爬與無副作用", + }, + { + "key": "no_api_fetch_execution", + "passed": no_api_fetch_execution, + "label": "本 API 不執行 fetch、不允許 external network", + }, + { + "key": "no_database_write", + "passed": no_database_write, + "label": "本階段不寫 DB、不開 commit", + }, + { + "key": "no_scheduler_attach", + "passed": no_scheduler_attach, + "label": "本階段不掛 scheduler", + }, + { + "key": "target_review_side_effect_free", + "passed": bool(not blocked_side_effects and not handoff_side_effects), + "label": "target review 與 handoff 均未帶入任何執行/寫入/排程副作用旗標", + }, + ] + gates.extend( + { + "key": f"ack_{key}", + "passed": item["acknowledged"], + "label": item["label"], + } + for key, item in acknowledgement_status.items() + ) + blocked_reasons = [ + gate["key"] for gate in gates + if not gate["passed"] + ] + accepted = bool(target_payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_target_review" + if target_payload_received + else "mcp_fetch_target_review_preview" + ), + "phase": phase, + "target_payload_received": target_payload_received, + "target_payload_valid_object": target_payload_valid_object, + "manual_fetch_handoff_accepted": handoff_accepted, + "operator_acknowledgements_complete": acknowledgements_complete, + "mcp_fetch_target_review_accepted": accepted, + "ready_for_manual_fetch_run_package_review": accepted, + "manual_fetch_gate_opened_by_api": False, + "network_request_allowed": False, + "fetch_executed": False, + "database_write_executed": False, + "scheduler_attached": False, + "adapter_target_count": len(registry), + "platform_target_count": target_report["target_count"], + "source_target_count": target_report["source_target_count"], + "unknown_platform_codes": target_report["unknown_platforms"], + "unknown_source_keys": target_report["unknown_sources"], + "missing_source_platforms": target_report["missing_sources"], + "unsafe_platform_targets": target_report["unsafe_platforms"], + "rate_limit_violations": target_report["rate_limit_violations"], + "sample_limit_violations": target_report["sample_limit_violations"], + "blocked_side_effects": blocked_side_effects + handoff_side_effects, + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_acknowledgement_status": acknowledgement_status, + "target_summaries": target_report["summaries"], + "adapter_targets": _adapter_targets(registry), + "handoff_summary": { + "mode": handoff.get("mode"), + "accepted": handoff_accepted, + "passed_gate_count": handoff.get("passed_gate_count", 0), + "gate_count": handoff.get("gate_count", 0), + "blocked_reasons": handoff.get("blocked_reasons", []), + "ready_for_manual_fetch_gate_operator_review": bool( + handoff.get("ready_for_manual_fetch_gate_operator_review") + ), + }, + "mcp_manual_fetch_handoff": handoff, + "sample_target_review_package": _sample_target_review_package(registry), + "next_operator_steps": [ + "若 target review 通過，只代表可整理人工 fetch run package，不代表 API 可抓取", + "操作員需以獨立命令與 run receipt 回報實際公開頁面抓取結果", + "正式 DB write、scheduler attach、Telegram/AI 摘要仍需各自獨立 gate", + ], + "payload_persisted": False, + "target_review_persisted": False, + "api_executes_health_check": False, + "api_executes_docker": False, + "api_executes_ssh": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "database_session_created": False, + "database_commit_executed": False, + "external_network_executed": False, + "writes_executed": False, + "would_write_database": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index e359b96..7215f1d 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_120_market_intel_mcp_manual_fetch_handoff" +MARKET_INTEL_PHASE = "phase_121_market_intel_mcp_fetch_target_review" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 9500e75..4bb05c1 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -656,6 +656,32 @@ +
+
+
+

MCP / FETCH TARGET REVIEW

+

MCP Fetch Target Review 審核

+
+ +
+
+ loading +
+
+
讀取 MCP Fetch Target Review 審核中...
+
+
+ +
+ +
+
+
+
@@ -1164,6 +1190,7 @@ const mcpRuntimeSmokeRoot = document.querySelector('[data-market-intel-mcp-runtime-smoke]'); const mcpRuntimePromotionRoot = document.querySelector('[data-market-intel-mcp-runtime-promotion]'); const mcpManualFetchHandoffRoot = document.querySelector('[data-market-intel-mcp-manual-fetch-handoff]'); + const mcpFetchTargetReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-target-review]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1180,7 +1207,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1251,6 +1278,12 @@ const mcpManualFetchHandoffReview = mcpManualFetchHandoffRoot ? mcpManualFetchHandoffRoot.querySelector('[data-market-intel-mcp-manual-fetch-handoff-review]') : null; const mcpManualFetchHandoffRefresh = mcpManualFetchHandoffRoot ? mcpManualFetchHandoffRoot.querySelector('[data-market-intel-mcp-manual-fetch-handoff-refresh]') : null; const mcpManualFetchHandoffEndpoint = "{{ url_for('market_intel.market_intel_mcp_manual_fetch_handoff') }}"; + const mcpFetchTargetReviewMeta = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-meta]') : null; + const mcpFetchTargetReviewBody = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-body]') : null; + const mcpFetchTargetReviewInput = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-input]') : null; + const mcpFetchTargetReviewReview = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-review]') : null; + const mcpFetchTargetReviewRefresh = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-refresh]') : null; + const mcpFetchTargetReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_target_review') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -2695,6 +2728,119 @@ } }; + const renderMcpFetchTargetReviewMeta = data => { + mcpFetchTargetReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_target_review_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `targets=${data.platform_target_count || 0}`, + `sources=${data.source_target_count || 0}`, + `network=${data.network_request_allowed ? 'open' : 'closed'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchTargetReviewBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const targets = data.target_summaries || []; + const handoff = data.handoff_summary || {}; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchTargetReviewBody.innerHTML = ` +
此 target review 只審核公開入口白名單、節流、樣本數與回退條件；API 不執行抓取、不連外、不開 DB、不保存 payload。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

TARGET GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 target gates。
' + }
+
+
+

PLATFORM TARGETS

+
${ + targets.length + ? targets.map(item => renderCheck( + item.platform_code || 'unknown', + `${(item.source_keys || []).join(', ') || 'no source'} / delay=${item.delay_seconds || 'n/a'} / limit=${item.sample_limit || 'n/a'}`, + item.ready ? 'READY' : 'BLOCK' + )).join('') + : '
尚未提供平台目標。
' + }
+
+
+

HANDOFF / NEXT

+
+ ${renderCheck( + 'manual_fetch_handoff', + `${handoff.passed_gate_count || 0}/${handoff.gate_count || 0} gates`, + handoff.accepted ? 'ACCEPTED' : 'PENDING' + )} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'MANUAL')).join('')} +
+
+
+ `; + if (mcpFetchTargetReviewInput && !mcpFetchTargetReviewInput.value.trim() && data.sample_target_review_package) { + mcpFetchTargetReviewInput.value = JSON.stringify(data.sample_target_review_package, null, 2); + } + }; + + const loadMcpFetchTargetReview = async () => { + if (!mcpFetchTargetReviewMeta || !mcpFetchTargetReviewBody) return; + mcpFetchTargetReviewBody.innerHTML = '
讀取 MCP Fetch Target Review 審核中...
'; + try { + const response = await fetch(mcpFetchTargetReviewEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchTargetReviewMeta(data); + renderMcpFetchTargetReviewBody(data); + } catch (error) { + mcpFetchTargetReviewMeta.innerHTML = 'error'; + mcpFetchTargetReviewBody.innerHTML = `
MCP Fetch Target Review 審核讀取失敗：${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchTargetReview = async () => { + if (!mcpFetchTargetReviewMeta || !mcpFetchTargetReviewBody || !mcpFetchTargetReviewInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchTargetReviewInput.value || '{}'); + } catch (error) { + mcpFetchTargetReviewMeta.innerHTML = 'json_error'; + mcpFetchTargetReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + mcpFetchTargetReviewBody.innerHTML = '
審核 MCP Fetch Target Review 中...
'; + try { + const response = await fetch(mcpFetchTargetReviewEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ target_review_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchTargetReviewMeta(data); + renderMcpFetchTargetReviewBody(data); + } catch (error) { + mcpFetchTargetReviewMeta.innerHTML = 'error'; + mcpFetchTargetReviewBody.innerHTML = `
MCP Fetch Target Review 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -12122,6 +12268,12 @@ if (mcpManualFetchHandoffReview) { mcpManualFetchHandoffReview.addEventListener('click', reviewMcpManualFetchHandoff); } + if (mcpFetchTargetReviewRefresh) { + mcpFetchTargetReviewRefresh.addEventListener('click', loadMcpFetchTargetReview); + } + if (mcpFetchTargetReviewReview) { + mcpFetchTargetReviewReview.addEventListener('click', reviewMcpFetchTargetReview); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -12380,6 +12532,7 @@ loadMcpRuntimeSmoke(); loadMcpRuntimePromotion(); loadMcpManualFetchHandoff(); + loadMcpFetchTargetReview(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 4715f01..1304424 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -20,6 +20,9 @@ from services.market_intel.mcp_completion_audit import build_mcp_completion_audi from services.market_intel.mcp_contract import build_mcp_tool_contract_preview from services.market_intel.mcp_deploy_preflight import build_mcp_deploy_preflight_plan from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview +from services.market_intel.mcp_fetch_target_review import ( + build_mcp_fetch_target_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -957,6 +960,11 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-mcp-manual-fetch-handoff-gates" in template assert "data-market-intel-mcp-manual-fetch-handoff-summary" in template assert "data-market-intel-mcp-manual-fetch-handoff-next" in template + assert "market_intel.market_intel_mcp_fetch_target_review" in template + assert "data-market-intel-mcp-fetch-target-review" in template + assert "data-market-intel-mcp-fetch-target-review-gates" in template + assert "data-market-intel-mcp-fetch-target-review-targets" in template + assert "data-market-intel-mcp-fetch-target-review-next" in template assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1427,7 +1435,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert bridge["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1585,7 +1593,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert contract["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1718,7 +1726,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1731,7 +1739,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert gate["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1801,7 +1809,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1815,7 +1823,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert audit["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -1889,7 +1897,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -1906,11 +1914,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_120_market_intel_mcp_manual_fetch_handoff" + phase="phase_121_market_intel_mcp_fetch_target_review" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert evidence["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -1935,7 +1943,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_120_market_intel_mcp_manual_fetch_handoff", + phase="phase_121_market_intel_mcp_fetch_target_review", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -1993,12 +2001,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2007,11 +2015,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_120_market_intel_mcp_manual_fetch_handoff" + phase="phase_121_market_intel_mcp_fetch_target_review" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert receipt["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2039,7 +2047,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_120_market_intel_mcp_manual_fetch_handoff", + phase="phase_121_market_intel_mcp_fetch_target_review", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2104,12 +2112,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2118,11 +2126,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_120_market_intel_mcp_manual_fetch_handoff" + phase="phase_121_market_intel_mcp_fetch_target_review" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert promotion["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2150,7 +2158,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_120_market_intel_mcp_manual_fetch_handoff", + phase="phase_121_market_intel_mcp_fetch_target_review", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2210,12 +2218,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2224,11 +2232,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_120_market_intel_mcp_manual_fetch_handoff", + phase="phase_121_market_intel_mcp_fetch_target_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert handoff["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2256,7 +2264,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_120_market_intel_mcp_manual_fetch_handoff", + phase="phase_121_market_intel_mcp_fetch_target_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2318,12 +2326,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2332,11 +2340,141 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert post_data["api_uses_external_network"] is False +def test_mcp_fetch_target_review_preview_is_safe_without_payload(): + review = build_mcp_fetch_target_review_preview( + phase="phase_121_market_intel_mcp_fetch_target_review", + ) + + assert review["mode"] == "mcp_fetch_target_review_preview" + assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert review["target_payload_received"] is False + assert review["mcp_fetch_target_review_accepted"] is False + assert review["ready_for_manual_fetch_run_package_review"] is False + assert review["adapter_target_count"] >= 4 + assert review["manual_fetch_gate_opened_by_api"] is False + assert review["network_request_allowed"] is False + assert review["fetch_executed"] is False + assert review["payload_persisted"] is False + assert review["target_review_persisted"] is False + assert review["api_executes_health_check"] is False + assert review["api_opens_database_connection"] is False + assert review["api_writes_database"] is False + assert review["api_uses_external_network"] is False + assert review["database_write_executed"] is False + assert review["external_network_executed"] is False + assert review["scheduler_attached"] is False + assert "manual_fetch_handoff_payload_or_review_received" in review["blocked_reasons"] + assert "target_payload_received" in review["blocked_reasons"] + assert "handoff_package" in review["sample_target_review_package"] + assert "target_review" in review["sample_target_review_package"] + + +def test_mcp_fetch_target_review_accepts_sample_targets(): + sample = build_mcp_fetch_target_review_preview()[ + "sample_target_review_package" + ] + review = build_mcp_fetch_target_review_preview( + handoff_package=sample["handoff_package"], + target_review=sample["target_review"], + phase="phase_121_market_intel_mcp_fetch_target_review", + ) + + assert review["mode"] == "mcp_fetch_target_review" + assert review["mcp_fetch_target_review_accepted"] is True + assert review["ready_for_manual_fetch_run_package_review"] is True + assert review["manual_fetch_handoff_accepted"] is True + assert review["operator_acknowledgements_complete"] is True + assert review["blocked_reasons"] == [] + assert review["passed_gate_count"] == review["gate_count"] + assert review["platform_target_count"] >= 4 + assert review["source_target_count"] >= 8 + assert {item["platform_code"] for item in review["target_summaries"]} >= { + "momo", + "pchome", + "coupang", + "shopee", + } + assert all(item["ready"] for item in review["target_summaries"]) + assert review["manual_fetch_gate_opened_by_api"] is False + assert review["network_request_allowed"] is False + assert review["fetch_executed"] is False + assert review["database_write_executed"] is False + assert review["target_review_persisted"] is False + assert review["api_opens_database_connection"] is False + assert review["api_uses_external_network"] is False + assert review["scheduler_attached"] is False + + +def test_mcp_fetch_target_review_blocks_unknown_or_unsafe_target(): + sample = build_mcp_fetch_target_review_preview()[ + "sample_target_review_package" + ] + target_review = sample["target_review"] + target_review["platform_targets"][0]["source_keys"] = ["unknown_source"] + target_review["platform_targets"][0]["delay_seconds"] = 0.1 + target_review["platform_targets"][0]["allow_external_network_in_api"] = True + target_review["operator_acknowledgements"]["no_api_fetch_execution"] = False + + review = build_mcp_fetch_target_review_preview( + handoff_package=sample["handoff_package"], + target_review=target_review, + ) + + assert review["mcp_fetch_target_review_accepted"] is False + assert review["manual_fetch_handoff_accepted"] is True + assert review["unknown_source_keys"][0]["source_key"] == "unknown_source" + assert "all_source_keys_known" in review["blocked_reasons"] + assert "rate_limits_within_policy" in review["blocked_reasons"] + assert "public_pages_only_confirmed" in review["blocked_reasons"] + assert "target_review_side_effect_free" in review["blocked_reasons"] + assert "ack_no_api_fetch_execution" in review["blocked_reasons"] + assert review["network_request_allowed"] is False + assert review["api_writes_database"] is False + assert review["scheduler_attached"] is False + + +def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get("/api/market_intel/mcp_fetch_target_review") + get_data = get_response.get_json() + sample = get_data["sample_target_review_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_target_review", + json={"target_review_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == "mcp_fetch_target_review_preview" + assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert get_data["api_executes_health_check"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_uses_external_network"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_target_review" + assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert post_data["mcp_fetch_target_review_accepted"] is True + assert post_data["manual_fetch_gate_opened_by_api"] is False + assert post_data["network_request_allowed"] is False + assert post_data["fetch_executed"] is False + assert post_data["target_review_persisted"] is False + assert post_data["api_opens_database_connection"] is False + assert post_data["api_uses_external_network"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -2384,7 +2522,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -2395,7 +2533,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert acceptance["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -2437,7 +2575,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -2449,7 +2587,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -2560,7 +2698,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -2599,7 +2737,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -2661,7 +2799,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -2741,7 +2879,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert handoff["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -2805,7 +2943,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -2864,7 +3002,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert queue_draft["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2938,7 +3076,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -3001,7 +3139,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert approval["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -3079,7 +3217,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -3142,7 +3280,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert transaction["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -3222,7 +3360,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -8933,7 +9071,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9008,7 +9146,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -9280,7 +9418,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9568,7 +9706,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -9878,7 +10016,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -10181,7 +10319,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -10440,7 +10578,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -10713,7 +10851,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -10961,7 +11099,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -11191,7 +11329,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -11428,7 +11566,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -11670,7 +11808,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -11946,7 +12084,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -12223,7 +12361,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -12502,7 +12640,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -12831,7 +12969,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -13093,7 +13231,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -13357,7 +13495,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -13627,7 +13765,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -13915,7 +14053,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -14202,7 +14340,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -14288,7 +14426,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -14345,7 +14483,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -14434,7 +14572,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -14488,7 +14626,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -14544,7 +14682,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -14610,7 +14748,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -14912,7 +15050,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -14960,7 +15098,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -15009,7 +15147,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -15067,7 +15205,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -15133,7 +15271,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -15204,7 +15342,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -15280,7 +15418,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -15362,7 +15500,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15448,7 +15586,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -15531,7 +15669,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15614,7 +15752,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -15700,7 +15838,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -15791,7 +15929,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -15901,7 +16039,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -15987,7 +16125,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16044,7 +16182,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16097,7 +16235,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16150,7 +16288,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16211,7 +16349,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16280,7 +16418,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16352,7 +16490,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -16425,7 +16563,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -16496,7 +16634,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -16561,7 +16699,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -16632,7 +16770,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -16705,7 +16843,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -16782,7 +16920,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -16859,7 +16997,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -16936,7 +17074,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -17010,7 +17148,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -17089,7 +17227,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -17176,7 +17314,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -17257,7 +17395,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -17339,7 +17477,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_120_market_intel_mcp_manual_fetch_handoff" + "phase_121_market_intel_mcp_fetch_target_review" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -17422,7 +17560,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -17447,7 +17585,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -17485,7 +17623,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -17496,7 +17634,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -17532,7 +17670,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -17543,7 +17681,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -17584,7 +17722,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -17595,7 +17733,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -17643,7 +17781,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -17655,7 +17793,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -17701,7 +17839,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -17714,7 +17852,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -17799,7 +17937,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -17877,7 +18015,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -17892,7 +18030,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert readiness["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -18284,6 +18422,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["mcp_runtime_smoke_receipt_preview_safe"] is True assert readiness["checks"]["mcp_runtime_promotion_preview_safe"] is True assert readiness["checks"]["mcp_manual_fetch_handoff_preview_safe"] is True + assert readiness["checks"]["mcp_fetch_target_review_preview_safe"] is True assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -18659,6 +18798,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/mcp_runtime_smoke_receipt" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_runtime_promotion" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_manual_fetch_handoff" in readiness["production_smoke_targets"] + assert "/api/market_intel/mcp_fetch_target_review" in readiness["production_smoke_targets"] assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -19023,6 +19163,16 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["mcp_manual_fetch_handoff"]["network_request_allowed"] is False assert readiness["mcp_manual_fetch_handoff"]["api_writes_database"] is False assert readiness["mcp_manual_fetch_handoff"]["api_uses_external_network"] is False + assert readiness["mcp_fetch_target_review"]["mode"] == "mcp_fetch_target_review_preview" + assert readiness["mcp_fetch_target_review"]["target_payload_received"] is False + assert readiness["mcp_fetch_target_review"]["payload_persisted"] is False + assert readiness["mcp_fetch_target_review"]["target_review_persisted"] is False + assert readiness["mcp_fetch_target_review"]["manual_fetch_gate_opened_by_api"] is False + assert readiness["mcp_fetch_target_review"]["network_request_allowed"] is False + assert readiness["mcp_fetch_target_review"]["fetch_executed"] is False + assert readiness["mcp_fetch_target_review"]["api_writes_database"] is False + assert readiness["mcp_fetch_target_review"]["api_uses_external_network"] is False + assert readiness["mcp_fetch_target_review"]["scheduler_attached"] is False assert readiness["manual_sample_plan"]["mode"] == "manual_sample_fetch_plan_preview" assert readiness["manual_sample_plan"]["sample_fetch_executed"] is False assert readiness["manual_sample_plan"]["external_network_executed"] is False @@ -22642,7 +22792,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert drill["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -22757,7 +22907,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -22769,7 +22919,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -22884,7 +23034,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -22897,7 +23047,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert smoke["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -22959,7 +23109,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -22972,7 +23122,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert inventory["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -23116,7 +23266,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -23352,7 +23502,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -23381,7 +23531,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_120_market_intel_mcp_manual_fetch_handoff" + assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False