diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 0542b39..6077e7f 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -170,6 +170,7 @@ - Phase 84 candidate queue review AI summary persistence transaction：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_transaction.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction` 與 UI transaction 按鈕，在 persistence preflight 後產生 future CLI-only `metadata_json` UPDATE statement preview、parameter preview 與 rollback plan；API/UI 不開 DB、不執行 SQL、不寫 transaction、不寫 summary record、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；版本同步至 V10.287。 - Phase 85 candidate queue review AI summary persistence writer preflight：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_writer_preflight.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight` 與 UI writer preflight 按鈕，在 transaction preview 後檢查 CLI-only writer contract、metadata_json backup requirement、post-write smoke requirement 與 artifact path gate；API/UI 不開 DB、不執行 SQL、不寫 preflight、不寫 summary record、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；版本同步至 V10.290。 - Phase 86 candidate queue review AI summary persistence run package：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package` 與 UI run package 按鈕，在 writer preflight 後整理 payload manifest、CLI command bundle、required artifacts、operator signoff 與 rollback plan；API/UI 不開 DB、不執行 SQL、不寫 run package、不寫 summary record、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；版本同步至 V10.294。 + - Phase 87 candidate queue review AI summary persistence run readiness：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness` 與 UI readiness 按鈕，在 run package 後檢查 artifact path、metadata_json backup、read-only preflight、shell-only token 與 post-write smoke 計畫；API/UI 不開 DB、不執行 SQL、不寫 readiness artifact、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；版本同步至 V10.297。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/config.py b/config.py index 624677a..bb30b86 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.296" +SYSTEM_VERSION = "V10.297" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index ecdf125..6885bd8 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -212,6 +212,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review AI summary persistence transaction：`services.market_intel.candidate_queue_review_ai_summary_persistence_transaction` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction` 在 persistence preflight 後產生未來 CLI-only `metadata_json` UPDATE statement preview、parameter preview 與 rollback plan。此 transaction gate 不開 DB、不執行 SQL、不寫 transaction、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須另開 CLI writer gate 與 post-write smoke。 - 2026-05-19 追加 candidate queue review AI summary persistence writer preflight：`services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight` 在 transaction preview 後檢查 CLI-only writer contract、`metadata_json` backup requirement、post-write smoke requirement 與 artifact path gate。此 writer preflight 不開 DB、不執行 SQL、不寫 preflight、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須另開 CLI run package、operator readiness、receipt 與 post-write smoke。 - 2026-05-19 追加 candidate queue review AI summary persistence run package：`services.market_intel.candidate_queue_review_ai_summary_persistence_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package` 在 writer preflight 後整理 payload manifest、CLI command bundle、required artifacts、operator signoff 與 rollback plan。此 run package 不開 DB、不執行 SQL、不寫 run package、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須另開 operator readiness、CLI receipt、post-write smoke 與 closeout。 +- 2026-05-20 追加 candidate queue review AI summary persistence run readiness：`services.market_intel.candidate_queue_review_ai_summary_persistence_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness` 在 run package 後檢查操作員 artifact path、metadata_json backup、read-only preflight、shell-only token acknowledgement 與 post-write smoke 計畫。此 readiness 不開 DB、不執行 SQL、不寫 readiness artifact、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須由後續人工 CLI 與 receipt/post-write smoke gate 驗收。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/market_intel_review_post_ai_routes.py b/routes/market_intel_review_post_ai_routes.py new file mode 100644 index 0000000..1934dbf --- /dev/null +++ b/routes/market_intel_review_post_ai_routes.py @@ -0,0 +1,58 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +"""市場情報 AI summary persistence 後續 POST API。""" + +from flask import jsonify, request + +from auth import login_required +from routes.market_intel_review_routes import _extract_run_payload, market_intel_review_bp +from routes.market_intel_review_post_routes import ( + _build_review_ai_summary_persistence_writer_preflight_stack, +) +from services.market_intel import MarketIntelService +from services.market_intel.candidate_queue_review_ai_summary_persistence_run_package import ( + build_candidate_queue_review_ai_summary_persistence_run_package, +) +from services.market_intel.candidate_queue_review_ai_summary_persistence_run_readiness import ( + build_candidate_queue_review_ai_summary_persistence_run_readiness, +) + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_readiness", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_readiness(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + apply_real_write = request.args.get("apply_real_write", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + stack = _build_review_ai_summary_persistence_writer_preflight_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + smoke_result=smoke_result, + limit=limit, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + ) + run_package = build_candidate_queue_review_ai_summary_persistence_run_package( + ai_summary_persistence_writer_preflight=stack[-1], + operator_evidence=operator_evidence, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + ) + data = build_candidate_queue_review_ai_summary_persistence_run_readiness( + ai_summary_persistence_run_package=run_package, + operator_evidence=operator_evidence, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + ) + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py index 1857195..0ae90a1 100644 --- a/routes/market_intel_review_routes.py +++ b/routes/market_intel_review_routes.py @@ -791,3 +791,4 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeo from routes import market_intel_review_post_routes # noqa: E402,F401 +from routes import market_intel_review_post_ai_routes # noqa: E402,F401 diff --git a/services/market_intel/candidate_queue_review_ai_summary_persistence_run_readiness.py b/services/market_intel/candidate_queue_review_ai_summary_persistence_run_readiness.py new file mode 100644 index 0000000..8eda964 --- /dev/null +++ b/services/market_intel/candidate_queue_review_ai_summary_persistence_run_readiness.py @@ -0,0 +1,382 @@ +"""候選審核 queue AI summary persistence operator readiness preview。 + +本模組只檢查 CLI 寫入 metadata_json 前的操作員證據是否齊備；不讀 +approval token、不執行 CLI、不開 DB connection、不寫 metadata_json、不派送 +Telegram、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +TARGET_TABLE = "market_alert_review_queue" +TARGET_COLUMN = "metadata_json" +SUMMARY_METADATA_KEY = "ai_summary_review" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _safe_text(value, limit=300): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _side_effects_clear(*payloads): + blocked_keys = ( + "ready_for_api_database_write", + "ready_for_telegram_dispatch", + "ready_for_scheduler_attach", + "api_executes_cli", + "api_executes_llm", + "api_reads_approval_token", + "api_writes_file", + "api_writes_database", + "api_updates_review_state", + "summary_persistence_run_readiness_file_written", + "run_readiness_file_written", + "summary_persistence_run_package_file_written", + "run_package_file_written", + "package_artifact_created", + "summary_persistence_writer_preflight_file_written", + "summary_persistence_transaction_file_written", + "summary_file_written", + "summary_record_written", + "summary_persistence_record_written", + "metadata_patch_written", + "transaction_file_written", + "database_connection_opened", + "database_session_created", + "explicit_transaction_opened", + "transaction_opened", + "transaction_committed", + "database_write_executed", + "database_commit_executed", + "review_state_update_executed", + "llm_call_executed", + "ollama_call_executed", + "gemini_call_executed", + "telegram_dispatched", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ) + return all( + not _as_dict(payload).get(key) + for payload in payloads + for key in blocked_keys + ) + + +def _operator_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + artifact_paths = { + "ai_summary_persistence_transaction_artifact_path": _safe_text( + operator_evidence.get("ai_summary_persistence_transaction_artifact_path") + or operator_evidence.get("summary_persistence_transaction_artifact_path") + ), + "ai_summary_persistence_writer_preflight_artifact_path": _safe_text( + operator_evidence.get("ai_summary_persistence_writer_preflight_artifact_path") + or operator_evidence.get("summary_persistence_writer_preflight_artifact_path") + ), + "ai_summary_persistence_run_package_artifact_path": _safe_text( + operator_evidence.get("ai_summary_persistence_run_package_artifact_path") + or operator_evidence.get("summary_persistence_run_package_artifact_path") + ), + "metadata_json_backup_artifact_path": _safe_text( + operator_evidence.get("metadata_json_backup_artifact_path") + or operator_evidence.get("summary_metadata_backup_artifact_path") + ), + "ai_summary_persistence_postwrite_smoke_artifact_path": _safe_text( + operator_evidence.get("ai_summary_persistence_postwrite_smoke_artifact_path") + or operator_evidence.get("summary_persistence_postwrite_smoke_artifact_path") + ), + } + return { + "provided_keys": sorted(operator_evidence.keys()), + **artifact_paths, + "artifact_path_count": sum(1 for value in artifact_paths.values() if _has_text(value)), + "operator_confirmed_ai_summary_persistence_run_readiness": bool( + operator_evidence.get("operator_confirmed_ai_summary_persistence_run_readiness") + or operator_evidence.get("operator_confirmed_summary_persistence_run_readiness") + ), + "operator_confirmed_run_package_artifact_reviewed": bool( + operator_evidence.get("operator_confirmed_run_package_artifact_reviewed") + or operator_evidence.get("operator_confirmed_payload_manifest_reviewed") + ), + "operator_confirmed_backup_artifact_reviewed": bool( + operator_evidence.get("operator_confirmed_backup_artifact_reviewed") + ), + "operator_confirmed_writer_preflight_reviewed": bool( + operator_evidence.get("operator_confirmed_writer_preflight_reviewed") + or operator_evidence.get("operator_confirmed_cli_preflight_reviewed") + ), + "operator_confirmed_cli_command_reviewed": bool( + operator_evidence.get("operator_confirmed_cli_command_reviewed") + ), + "operator_confirmed_one_time_token_shell_only": bool( + operator_evidence.get("operator_confirmed_one_time_token_shell_only") + or operator_evidence.get("operator_acknowledged_shell_only_token") + ), + "operator_confirmed_postwrite_smoke_required": bool( + operator_evidence.get("operator_confirmed_postwrite_smoke_required") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "operator_confirmed_no_telegram_dispatch": bool( + operator_evidence.get("operator_confirmed_no_telegram_dispatch") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key(operator_evidence), + } + + +def _package_summary(run_package): + run_package = _as_dict(run_package) + manifest = _as_dict(run_package.get("payload_manifest")) + commands = [_as_dict(item) for item in _as_list(run_package.get("command_bundle"))] + required_artifacts = [_as_dict(item) for item in _as_list(run_package.get("required_artifacts"))] + return { + "mode": run_package.get("mode"), + "package_ready": bool(run_package.get("package_ready")), + "ready_for_summary_persistence_run_readiness": bool( + run_package.get("ready_for_summary_persistence_run_readiness") + ), + "payload_count": int(manifest.get("payload_count") or 0), + "manifest_hash": manifest.get("manifest_hash"), + "dedupe_keys": _as_list(manifest.get("dedupe_keys")), + "summary_payload_hash": manifest.get("summary_payload_hash"), + "command_count": len(commands), + "writer_command_present": any( + command.get("key") == "metadata_json_writer" + and command.get("executes_database") is True + and command.get("executed") is False + for command in commands + ), + "commands_executed": any(command.get("executed") for command in commands), + "required_artifact_count": len(required_artifacts), + "required_artifact_keys": [item.get("key") for item in required_artifacts], + "side_effects_clear": _side_effects_clear(run_package), + } + + +def _readiness_gates(*, package, operator, apply_real_write): + return [ + { + "key": "summary_persistence_run_package_ready", + "label": "AI summary persistence run package 必須已通過", + "passed": bool( + package["mode"] + == "candidate_queue_review_ai_summary_persistence_run_package_preview" + and package["package_ready"] + and package["ready_for_summary_persistence_run_readiness"] + ), + }, + { + "key": "summary_persistence_payload_manifest_small_batch", + "label": "metadata_json persistence 首次 operator run 必須是 1 到 5 筆小流量", + "passed": bool(0 < package["payload_count"] <= 5), + }, + { + "key": "summary_persistence_command_bundle_ready", + "label": "run package 必須含 CLI writer 命令，且 API 尚未執行任何命令", + "passed": bool( + package["command_count"] >= 5 + and package["writer_command_present"] + and not package["commands_executed"] + ), + }, + { + "key": "summary_persistence_required_artifacts_recorded", + "label": "transaction、preflight、run package、metadata backup 與 post-write smoke artifact path 必須齊備", + "passed": bool( + operator["ai_summary_persistence_transaction_artifact_path"] + and operator["ai_summary_persistence_writer_preflight_artifact_path"] + and operator["ai_summary_persistence_run_package_artifact_path"] + and operator["metadata_json_backup_artifact_path"] + and operator["ai_summary_persistence_postwrite_smoke_artifact_path"] + ), + }, + { + "key": "operator_confirmed_summary_persistence_run_readiness", + "label": "操作員確認 CLI-only、備份、post-write smoke、無 API 寫入與無排程掛載", + "passed": bool( + operator["operator_confirmed_ai_summary_persistence_run_readiness"] + and operator["operator_confirmed_run_package_artifact_reviewed"] + and operator["operator_confirmed_backup_artifact_reviewed"] + and operator["operator_confirmed_writer_preflight_reviewed"] + and operator["operator_confirmed_cli_command_reviewed"] + and operator["operator_confirmed_one_time_token_shell_only"] + and operator["operator_confirmed_postwrite_smoke_required"] + and operator["operator_confirmed_no_api_db_write"] + and operator["operator_confirmed_no_telegram_dispatch"] + and operator["operator_confirmed_no_scheduler_attach"] + ), + }, + { + "key": "summary_persistence_run_readiness_no_approval_token_submitted_to_api", + "label": "payload 不得包含一次性 approval token key", + "passed": not operator["approval_token_submitted_to_api"], + }, + { + "key": "summary_persistence_run_readiness_apply_real_write_not_requested_from_api", + "label": "API/UI readiness 不接受 apply_real_write", + "passed": not apply_real_write, + }, + { + "key": "summary_persistence_run_readiness_has_no_side_effects", + "label": "readiness preview 不得開 DB、寫檔、呼叫 LLM、派 Telegram 或掛 scheduler", + "passed": package["side_effects_clear"], + }, + ] + + +def build_candidate_queue_review_ai_summary_persistence_run_readiness( + *, + ai_summary_persistence_run_package, + operator_evidence=None, + execute_requested=False, + apply_real_write=False, +): + """建立 AI summary persistence operator readiness preview；不執行副作用。""" + package = _package_summary(ai_summary_persistence_run_package) + operator = _operator_summary(operator_evidence) + gates = _readiness_gates( + package=package, + operator=operator, + apply_real_write=bool(apply_real_write), + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + run_readiness_ready = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_ai_summary_persistence_run_readiness_preview", + "target_table": TARGET_TABLE, + "target_column": TARGET_COLUMN, + "target_json_path": [SUMMARY_METADATA_KEY], + "target_operation": "persist_ai_summary_metadata_json", + "execute_requested": bool(execute_requested), + "apply_real_write_requested": bool(apply_real_write), + "run_readiness_ready": run_readiness_ready, + "summary_persistence_run_readiness_ready": run_readiness_ready, + "ready_for_cli_operator_run": run_readiness_ready, + "ready_for_summary_persistence_run_receipt": run_readiness_ready, + "ready_for_summary_persistence_cli_run": False, + "ready_for_real_write": False, + "ready_for_api_database_write": False, + "ready_for_telegram_dispatch": False, + "ready_for_scheduler_attach": False, + "package_artifact_created": False, + "summary_persistence_run_readiness_file_written": False, + "run_readiness_file_written": False, + "api_executes_cli": False, + "api_executes_llm": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "summary_file_written": False, + "summary_record_written": False, + "summary_persistence_record_written": False, + "metadata_patch_written": False, + "transaction_file_written": False, + "ai_summary_generated": False, + "llm_call_executed": False, + "ollama_call_executed": False, + "gemini_call_executed": False, + "telegram_dispatched": False, + "review_state_update_executed": False, + "read_only_query_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "statement_count": package["payload_count"], + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_ai_summary_persistence_run_readiness": operator, + "run_package_summary": package, + "cli_execution_boundary": { + "api_may_execute_cli": False, + "operator_shell_required": True, + "one_time_token_shell_only": True, + "requires_metadata_json_backup": True, + "requires_read_only_preflight": True, + "requires_postwrite_smoke_after_cli": True, + }, + "next_operator_steps": [ + "保存 AI summary persistence run package JSON", + "保存 metadata_json 寫入前備份", + "保存 CLI read-only preflight 輸出", + "確認一次性 approval token 只在 CLI shell 注入", + "CLI 寫入後立即保存 writer output 與 post-write smoke 結果", + ], + "safe_boundaries": [ + "do_not_execute_summary_persistence_writer_from_run_readiness_api", + "do_not_read_approval_token_from_summary_persistence_run_readiness_api", + "do_not_create_summary_persistence_run_readiness_artifacts_from_api", + "do_not_open_database_connection_from_summary_persistence_run_readiness", + "do_not_write_metadata_json_from_summary_persistence_run_readiness", + "do_not_update_review_state_from_summary_persistence_run_readiness", + "do_not_dispatch_telegram_from_summary_persistence_run_readiness", + "do_not_attach_scheduler_from_summary_persistence_run_readiness", + "future_summary_persistence_write_must_use_cli_only_gate", + "metadata_json_backup_required_before_summary_persistence_write", + "summary_persistence_postwrite_smoke_required", + "ai_summary_persistence_run_readiness_preview_only", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 73d504d..fda48a6 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -1,7 +1,4 @@ -"""市場情報 app-only release gate 組裝器。 - -本模組只組裝 preview payload，不執行 git、部署、SSH、migration 或 DB write。 -""" +"""市場情報 app-only release gate 組裝器；只組裝 preview payload，不執行 git、部署、SSH、migration 或 DB write。""" from services.market_intel.candidate_queue_writer_cli import build_candidate_queue_writer_cli_plan from services.market_intel.candidate_queue_writer_preflight import build_candidate_queue_writer_preflight @@ -31,6 +28,7 @@ from services.market_intel.candidate_queue_review_ai_summary_preflight import bu from services.market_intel.candidate_queue_review_ai_summary_output_receipt import build_candidate_queue_review_ai_summary_output_receipt from services.market_intel.candidate_queue_review_ai_summary_persistence_preflight import build_candidate_queue_review_ai_summary_persistence_preflight from services.market_intel.candidate_queue_review_ai_summary_persistence_run_package import build_candidate_queue_review_ai_summary_persistence_run_package +from services.market_intel.candidate_queue_review_ai_summary_persistence_run_readiness import build_candidate_queue_review_ai_summary_persistence_run_readiness from services.market_intel.candidate_queue_review_ai_summary_persistence_transaction import build_candidate_queue_review_ai_summary_persistence_transaction from services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight import build_candidate_queue_review_ai_summary_persistence_writer_preflight from services.market_intel.candidate_queue_review_ai_summary_run_package import build_candidate_queue_review_ai_summary_run_package @@ -60,6 +58,7 @@ BLOCKED_RUN_REVIEW_KEYS = ( "summary_persistence_transaction_file_written", "summary_persistence_writer_preflight_file_written", "summary_persistence_run_package_file_written", + "summary_persistence_run_readiness_file_written", "run_readiness_file_written", "summary_persistence_record_written", "metadata_patch_written", "transaction_file_written", @@ -82,7 +81,7 @@ BLOCKED_RUN_REVIEW_KEYS = ( "writes_executed", "would_write_database", ) -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -244,6 +243,7 @@ def build_deployment_readiness_preview( candidate_queue_review_ai_summary_persistence_transaction = build_candidate_queue_review_ai_summary_persistence_transaction(ai_summary_persistence_preflight=candidate_queue_review_ai_summary_persistence_preflight) candidate_queue_review_ai_summary_persistence_writer_preflight = build_candidate_queue_review_ai_summary_persistence_writer_preflight(ai_summary_persistence_transaction=candidate_queue_review_ai_summary_persistence_transaction) candidate_queue_review_ai_summary_persistence_run_package = build_candidate_queue_review_ai_summary_persistence_run_package(ai_summary_persistence_writer_preflight=candidate_queue_review_ai_summary_persistence_writer_preflight) + candidate_queue_review_ai_summary_persistence_run_readiness = build_candidate_queue_review_ai_summary_persistence_run_readiness(ai_summary_persistence_run_package=candidate_queue_review_ai_summary_persistence_run_package) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -535,6 +535,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_ai_summary_persistence_transaction_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_transaction, "candidate_queue_review_ai_summary_persistence_transaction_preview"), "candidate_queue_review_ai_summary_persistence_writer_preflight_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_writer_preflight, "candidate_queue_review_ai_summary_persistence_writer_preflight_preview"), "candidate_queue_review_ai_summary_persistence_run_package_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_run_package, "candidate_queue_review_ai_summary_persistence_run_package_preview"), + "candidate_queue_review_ai_summary_persistence_run_readiness_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_run_readiness, "candidate_queue_review_ai_summary_persistence_run_readiness_preview"), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -788,6 +789,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_ai_summary_persistence_transaction": candidate_queue_review_ai_summary_persistence_transaction, "candidate_queue_review_ai_summary_persistence_writer_preflight": candidate_queue_review_ai_summary_persistence_writer_preflight, "candidate_queue_review_ai_summary_persistence_run_package": candidate_queue_review_ai_summary_persistence_run_package, + "candidate_queue_review_ai_summary_persistence_run_readiness": candidate_queue_review_ai_summary_persistence_run_readiness, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 4e11a50..15adc90 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_86_candidate_queue_review_ai_summary_persistence_run_package" +MARKET_INTEL_PHASE = "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 378b8e5..8d26228 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -697,6 +697,9 @@ + @@ -1057,6 +1060,7 @@ const sampleCandidateQueueReviewAiSummaryPersistenceTransaction = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-transaction]') : null; const sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflight = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-writer-preflight]') : null; const sampleCandidateQueueReviewAiSummaryPersistenceRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-package]') : null; + const sampleCandidateQueueReviewAiSummaryPersistenceRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-readiness]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1094,6 +1098,7 @@ const sampleCandidateQueueReviewAiSummaryPersistenceTransactionEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_transaction') }}"; const sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflightEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_writer_preflight') }}"; const sampleCandidateQueueReviewAiSummaryPersistenceRunPackageEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_package') }}"; + const sampleCandidateQueueReviewAiSummaryPersistenceRunReadinessEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_readiness') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -5552,6 +5557,124 @@ } }; + const renderCandidateQueueReviewAiSummaryPersistenceRunReadiness = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const summary = data.run_package_summary || {}; + const operator = data.operator_ai_summary_persistence_run_readiness || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `readiness=${data.run_readiness_ready ? 'ready' : 'blocked'}`, + `payloads=${summary.payload_count || 0}`, + `operator_artifacts=${operator.artifact_path_count || 0}`, + `db=${data.database_write_executed ? 'written' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只檢查 AI summary persistence operator readiness；API/UI 不讀 token、不執行 CLI、不開 DB、不寫 metadata_json、不派送 Telegram。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

READINESS GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 readiness gate。
' + }
+
+
+

PACKAGE SUMMARY

+
+ ${[ + ['package_ready', summary.package_ready], + ['payload_count', summary.payload_count || 0], + ['command_count', summary.command_count || 0], + ['writer_command_present', summary.writer_command_present], + ['manifest_hash', summary.manifest_hash || 'missing'] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

OPERATOR EVIDENCE

+
+ ${[ + ['run_package_path', operator.ai_summary_persistence_run_package_artifact_path || 'missing'], + ['writer_preflight_path', operator.ai_summary_persistence_writer_preflight_artifact_path || 'missing'], + ['backup_path', operator.metadata_json_backup_artifact_path || 'missing'], + ['postwrite_smoke_path', operator.ai_summary_persistence_postwrite_smoke_artifact_path || 'missing'], + ['token_submitted_to_api', operator.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

NO-SIDE-EFFECTS

+
+ ${[ + ['api_executes_cli', data.api_executes_cli], + ['api_reads_approval_token', data.api_reads_approval_token], + ['api_writes_database', data.api_writes_database], + ['run_readiness_file_written', data.run_readiness_file_written], + ['database_connection_opened', data.database_connection_opened], + ['database_write_executed', data.database_write_executed], + ['telegram_dispatched', data.telegram_dispatched], + ['scheduler_attached', data.scheduler_attached] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueReviewAiSummaryPersistenceRunReadiness = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue review AI summary persistence run readiness 中...
'; + try { + const response = await fetch(`${sampleCandidateQueueReviewAiSummaryPersistenceRunReadinessEndpoint}?execute=false&apply_real_write=false`, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewAiSummaryPersistenceRunReadiness(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review AI summary persistence run readiness 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -7264,6 +7387,9 @@ if (sampleCandidateQueueReviewAiSummaryPersistenceRunPackage) { sampleCandidateQueueReviewAiSummaryPersistenceRunPackage.addEventListener('click', loadCandidateQueueReviewAiSummaryPersistenceRunPackage); } + if (sampleCandidateQueueReviewAiSummaryPersistenceRunReadiness) { + sampleCandidateQueueReviewAiSummaryPersistenceRunReadiness.addEventListener('click', loadCandidateQueueReviewAiSummaryPersistenceRunReadiness); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 3846c1e..7ea0a52 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -1067,6 +1067,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_package" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_readiness" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -1139,6 +1143,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-package" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-readiness" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -1175,7 +1183,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert bridge["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1333,7 +1341,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert contract["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1466,7 +1474,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1479,7 +1487,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert gate["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1549,7 +1557,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1561,7 +1569,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1609,7 +1617,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1620,7 +1628,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert acceptance["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1662,7 +1670,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1674,7 +1682,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert review["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1785,7 +1793,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1824,7 +1832,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert review["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1886,7 +1894,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1966,7 +1974,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert handoff["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -2030,7 +2038,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -2089,7 +2097,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert queue_draft["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2163,7 +2171,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -2226,7 +2234,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert approval["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2304,7 +2312,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2367,7 +2375,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert transaction["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2447,7 +2455,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -6448,6 +6456,155 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_previews_cli_ ) +def test_candidate_queue_review_ai_summary_persistence_run_readiness_checks_operator_artifacts(): + from services.market_intel.candidate_queue_review_ai_summary_persistence_run_package import ( + build_candidate_queue_review_ai_summary_persistence_run_package, + ) + from services.market_intel.candidate_queue_review_ai_summary_persistence_run_readiness import ( + build_candidate_queue_review_ai_summary_persistence_run_readiness, + ) + + expected_key = "market-alert-review:sample-batch:sku-001" + writer_preflight = { + "mode": "candidate_queue_review_ai_summary_persistence_writer_preflight_preview", + "summary_persistence_writer_preflight_ready": True, + "ready_for_summary_persistence_run_package": True, + "statement_count": 1, + "invalid_statement_count": 0, + "expected_dedupe_keys": [expected_key], + "summary_payload_hash": "f" * 64, + "statement_payloads": [ + { + "statement_type": "UPDATE", + "table": "market_alert_review_queue", + "target_column": "metadata_json", + "dedupe_key": expected_key, + "metadata_key": "ai_summary_review", + "payload_hash": "f" * 64, + "execute_in_api": False, + } + ], + "writer_preflight_contract": { + "target_table": "market_alert_review_queue", + "target_column": "metadata_json", + "target_json_path": ["ai_summary_review"], + "manual_cli_required": True, + "api_write_allowed": False, + "requires_metadata_json_backup": True, + "requires_postwrite_smoke": True, + }, + "database_connection_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "llm_call_executed": False, + "telegram_dispatched": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + } + operator_evidence = { + "ai_summary_persistence_transaction_artifact_path": ( + "artifacts/market_intel/ai-summary-persistence-transaction.json" + ), + "ai_summary_persistence_writer_preflight_artifact_path": ( + "artifacts/market_intel/ai-summary-persistence-writer-preflight.json" + ), + "ai_summary_persistence_run_package_artifact_path": ( + "artifacts/market_intel/ai-summary-persistence-run-package.json" + ), + "metadata_json_backup_artifact_path": ( + "artifacts/market_intel/metadata-json-backup.json" + ), + "ai_summary_persistence_postwrite_smoke_artifact_path": ( + "artifacts/market_intel/ai-summary-persistence-postwrite-smoke.json" + ), + "operator_confirmed_ai_summary_persistence_run_package": True, + "operator_confirmed_payload_manifest_reviewed": True, + "operator_confirmed_summary_persistence_is_cli_only": True, + "operator_confirmed_ai_summary_persistence_run_readiness": True, + "operator_confirmed_run_package_artifact_reviewed": True, + "operator_confirmed_backup_artifact_reviewed": True, + "operator_confirmed_writer_preflight_reviewed": True, + "operator_confirmed_cli_command_reviewed": True, + "operator_confirmed_one_time_token_shell_only": True, + "operator_confirmed_postwrite_smoke_required": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_no_telegram_dispatch": True, + "operator_confirmed_no_scheduler_attach": True, + } + run_package = build_candidate_queue_review_ai_summary_persistence_run_package( + ai_summary_persistence_writer_preflight=writer_preflight, + operator_evidence=operator_evidence, + execute_requested=True, + ) + readiness = build_candidate_queue_review_ai_summary_persistence_run_readiness( + ai_summary_persistence_run_package=run_package, + operator_evidence=operator_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_ai_summary_persistence_run_readiness( + ai_summary_persistence_run_package=run_package, + operator_evidence={**operator_evidence, "approval_token": TEST_APPROVAL_TOKEN}, + execute_requested=True, + ) + apply_write = build_candidate_queue_review_ai_summary_persistence_run_readiness( + ai_summary_persistence_run_package=run_package, + operator_evidence=operator_evidence, + execute_requested=True, + apply_real_write=True, + ) + + assert run_package["package_ready"] is True + assert readiness["mode"] == ( + "candidate_queue_review_ai_summary_persistence_run_readiness_preview" + ) + assert readiness["run_readiness_ready"] is True + assert readiness["summary_persistence_run_readiness_ready"] is True + assert readiness["ready_for_cli_operator_run"] is True + assert readiness["ready_for_summary_persistence_cli_run"] is False + assert readiness["ready_for_real_write"] is False + assert readiness["ready_for_api_database_write"] is False + assert readiness["ready_for_telegram_dispatch"] is False + assert readiness["summary_persistence_run_readiness_file_written"] is False + assert readiness["run_readiness_file_written"] is False + assert readiness["api_executes_cli"] is False + assert readiness["api_reads_approval_token"] is False + assert readiness["api_writes_file"] is False + assert readiness["api_writes_database"] is False + assert readiness["database_connection_opened"] is False + assert readiness["database_write_executed"] is False + assert readiness["database_commit_executed"] is False + assert readiness["llm_call_executed"] is False + assert readiness["telegram_dispatched"] is False + assert readiness["scheduler_attached"] is False + assert readiness["writes_executed"] is False + assert readiness["would_write_database"] is False + assert readiness["statement_count"] == 1 + assert readiness["run_package_summary"]["payload_count"] == 1 + assert readiness["run_package_summary"]["writer_command_present"] is True + assert readiness["operator_ai_summary_persistence_run_readiness"][ + "artifact_path_count" + ] == 5 + assert readiness["blocked_reasons"] == [] + assert token_leak["run_readiness_ready"] is False + assert token_leak["operator_ai_summary_persistence_run_readiness"][ + "approval_token_submitted_to_api" + ] is True + assert ( + "summary_persistence_run_readiness_no_approval_token_submitted_to_api" + in token_leak["blocked_reasons"] + ) + assert ( + "summary_persistence_run_readiness_apply_real_write_not_requested_from_api" + in apply_write["blocked_reasons"] + ) + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6490,7 +6647,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6547,7 +6704,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -6636,7 +6793,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6690,7 +6847,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -6746,7 +6903,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -6812,7 +6969,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -7114,7 +7271,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -7162,7 +7319,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -7211,7 +7368,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -7269,7 +7426,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -7335,7 +7492,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -7406,7 +7563,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -7482,7 +7639,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -7564,7 +7721,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -7650,7 +7807,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -7733,7 +7890,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -7816,7 +7973,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -7902,7 +8059,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -7993,7 +8150,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -8103,7 +8260,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -8189,7 +8346,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -8246,7 +8403,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -8299,7 +8456,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -8352,7 +8509,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8413,7 +8570,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8482,7 +8639,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8554,7 +8711,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -8627,7 +8784,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -8698,7 +8855,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -8763,7 +8920,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -8834,7 +8991,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -8876,6 +9033,83 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_readiness" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_readiness" + "?execute=true&apply_real_write=true", + json={"sample_result": {}}, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_ai_summary_persistence_run_readiness_preview" + ) + assert data["phase"] == ( + "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" + ) + assert data["run_readiness_ready"] is False + assert data["summary_persistence_run_readiness_ready"] is False + assert data["ready_for_cli_operator_run"] is False + assert data["ready_for_summary_persistence_cli_run"] is False + assert data["ready_for_real_write"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_telegram_dispatch"] is False + assert data["package_artifact_created"] is False + assert data["summary_persistence_run_readiness_file_written"] is False + assert data["run_readiness_file_written"] is False + assert data["api_executes_llm"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["summary_persistence_record_written"] is False + assert data["metadata_patch_written"] is False + assert data["transaction_file_written"] is False + assert data["ai_summary_generated"] is False + assert data["llm_call_executed"] is False + assert data["telegram_dispatched"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["scheduler_attached"] is False + assert data["statement_count"] == 0 + assert data["run_package_summary"]["payload_count"] == 0 + assert "summary_persistence_run_package_ready" in data["blocked_reasons"] + assert "summary_persistence_payload_manifest_small_batch" in data[ + "blocked_reasons" + ] + assert ( + "summary_persistence_run_readiness_apply_real_write_not_requested_from_api" + in data["blocked_reasons"] + ) + assert ( + "do_not_open_database_connection_from_summary_persistence_run_readiness" + in data["safe_boundaries"] + ) + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -8904,7 +9138,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -8929,7 +9163,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -8967,7 +9201,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -8978,7 +9212,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -9014,7 +9248,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -9025,7 +9259,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -9066,7 +9300,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -9077,7 +9311,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -9125,7 +9359,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -9137,7 +9371,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -9183,7 +9417,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -9196,7 +9430,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert plan["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -9281,7 +9515,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -9359,7 +9593,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -9374,7 +9608,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert readiness["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -9922,6 +10156,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_ai_summary_persistence_run_readiness_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -10101,6 +10341,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_ai_summary_persistence_run_package" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_readiness" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -12058,6 +12303,78 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "mode" + ] + == "candidate_queue_review_ai_summary_persistence_run_readiness_preview" + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "run_readiness_ready" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "ready_for_summary_persistence_cli_run" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "statement_count" + ] + == 0 + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "run_package_summary" + ]["payload_count"] + == 0 + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "summary_persistence_run_readiness_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "run_readiness_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "api_executes_llm" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "telegram_dispatched" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "database_connection_opened" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_readiness"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -12208,7 +12525,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert drill["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -12323,7 +12640,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -12335,7 +12652,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert review["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -12450,7 +12767,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -12463,7 +12780,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert smoke["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -12525,7 +12842,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -12538,7 +12855,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert inventory["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -12682,7 +12999,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -12909,7 +13226,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -12938,7 +13255,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_86_candidate_queue_review_ai_summary_persistence_run_package" + assert data["phase"] == "phase_87_candidate_queue_review_ai_summary_persistence_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False