diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 83d5fcf..0c2bc51 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.505 新增市場情報 MCP Fetch Candidate Queue Writer Review Decision 安全預覽 gate:只審核 review inventory 通過後由操作員貼回的人工 candidate queue review decision 摘要,確認 decision identity、target table、row count、dedupe keys、`needs_review` 現態、允許決策集合、evidence refs、matched row exact-identity/variant/overwrite guard、operator confirmation 與 forbidden API actions;API 不讀 token、不執行 CLI、不開 DB、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler。UI 同步新增 Decision gates / Inventory link / Decision summary / Decision rows / Boundary next 預覽區。 - V10.504 新增市場情報 MCP Fetch Candidate Queue Writer Review Inventory 安全預覽 gate:只審核 writer review handoff 通過後由操作員貼回的 read-only candidate queue inventory 摘要,確認 handoff identity、target table、row count、dedupe keys、review_state、artifact paths、read-only query result、missing/duplicate rows、operator confirmation 與 forbidden API actions;API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不做 inventory query、不掛 scheduler。主 gate 拆為 inventory / gates / sample 三檔,避免單檔膨脹。 - V10.503 新增市場情報 MCP Fetch Candidate Queue Writer Review Handoff 安全預覽 gate:只審核 post-closeout inventory review 通過後的人工 candidate queue review 交接包,確認 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation;API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler。 - V10.502 修正 AiderHeal 自動修復診斷鏈:先做 ADR-020 檔案白名單再打 110 preflight,`tests/` finding 會明確略過而不誤報 repo preflight;Code Review 完成通知會把全數不在白名單的 finding 標成需人工處理,不再宣稱已觸發 AiderHeal;白名單放行 `services/routes/database` 子目錄 Python 檔,preflight 通知帶 stderr/stdout 細節,健康檢查同時接受 `/health` 回 `ok` 與 `healthy`。 diff --git a/config.py b/config.py index 0fde452..541a221 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.504" +SYSTEM_VERSION = "V10.505" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 9e484ea..93bcc4d 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -175,6 +175,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate queue writer post-closeout inventory review gate:`services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_post_closeout_inventory_review` 在 closeout review 通過後審核 operator live inventory read-only 摘要,檢查 closeout linkage、row count、inventory artifact、closeout review artifact、read-only query result、missing/duplicate rows 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 inventory query、不掛 scheduler,只放行到 candidate queue review handoff。 - 2026-05-31 追加 MCP fetch candidate queue writer review handoff gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff` 在 post-closeout inventory review 通過後審核 operator candidate queue review handoff 摘要,檢查 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 - 2026-05-31 追加 MCP fetch candidate queue writer review inventory gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory_gates`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory_sample` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_inventory` 在 writer review handoff 通過後審核 operator read-only candidate queue inventory 摘要,檢查 handoff identity、target table、row count、dedupe keys、review_state、artifact paths、read-only query result、missing/duplicate rows 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不做 inventory query、不掛 scheduler,只放行到後續人工 candidate queue review。 +- 2026-05-31 追加 MCP fetch candidate queue writer review decision gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_gates`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_sample` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision` 在 review inventory 通過後審核 operator candidate queue review decision 摘要,檢查 decision identity、target table、row count、dedupe keys、`needs_review` 現態、允許決策集合、evidence refs、matched row exact-identity/variant/overwrite guard、operator confirmations 與 forbidden API actions;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler,只放行到 decision approval / writer preflight 設計。 - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 6512a23..d1a3fa2 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -53,6 +53,7 @@ - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer post-closeout inventory review gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_post_closeout_inventory_review.py` 為 649 行,略過 600 行提醒門檻。暫不拆分的理由是 inventory gate 需同時審核 closeout linkage、read-only inventory 摘要、artifact path policy、operator boundary confirmation 與 side-effect blocklist;後續若 candidate queue review handoff 再複用同一套 path/side-effect policy,應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer review handoff gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次將 sample payload 抽到 `services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff_sample.py`(105 行),主 gate `services/market_intel/mcp_fetch_candidate_queue_writer_review_handoff.py` 降為 571 行,低於 600 行提醒門檻;後續若 candidate queue review inventory 繼續複用 path/side-effect policy,應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer review inventory gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_review_inventory.py`(462 行)、`services/market_intel/mcp_fetch_candidate_queue_writer_review_inventory_gates.py`(183 行)與 `services/market_intel/mcp_fetch_candidate_queue_writer_review_inventory_sample.py`(107 行),全部低於 600 行提醒門檻;`routes/market_intel_mcp_run_routes.py` 目前 717 行,仍低於 800 行但後續新增 MCP gate 應持續評估拆第二個 route extension。 +- 2026-05-31 追記:同步市場情報 MCP fetch candidate queue writer review decision gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_review_decision.py`(498 行)、`services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_gates.py`(241 行)與 `services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_sample.py`(118 行),全部低於 600 行提醒門檻;`routes/market_intel_mcp_run_routes.py` 目前 772 行,仍低於 800 行但已接近門檻,下一段 MCP route 應優先拆第二個 route extension。 - 2026-05-24 追記:同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數;此處只更新 inventory,不變更 Code Review 行為。 - 2026-05-21 追記:同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index 4107b34..1d62dd5 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -100,6 +100,7 @@ - 2026-05-31 起,`V10.502` 修正 AiderHeal 自動修復診斷鏈:先檢查 ADR-020 檔案白名單再執行 110 preflight,`tests/` finding 會明確略過而不誤報 repo preflight;Code Review 完成通知會把全數不在白名單的 finding 標成需人工處理,不再宣稱已觸發 AiderHeal;白名單放行 `services/routes/database` 子目錄 Python 檔,preflight 通知帶遠端錯誤細節,健康檢查接受 `/health` 回 `healthy`。 - 2026-05-31 起,`V10.503` 新增市場情報 MCP Fetch Candidate Queue Writer Review Handoff gate:在 post-closeout inventory review 通過後只審核 operator candidate queue review handoff 摘要,要求 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation 對齊;仍不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 - 2026-05-31 起,`V10.504` 新增市場情報 MCP Fetch Candidate Queue Writer Review Inventory gate:在 writer review handoff 通過後只審核 operator read-only candidate queue inventory 摘要,要求 handoff identity、target table、row count、dedupe keys、review_state、artifact paths、read-only query result、missing/duplicate rows 與 operator confirmation 對齊;仍不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不做 inventory query、不掛 scheduler,只放行到後續人工 candidate queue review。 +- 2026-05-31 起,`V10.505` 新增市場情報 MCP Fetch Candidate Queue Writer Review Decision gate:在 review inventory 通過後只審核 operator candidate queue review decision 摘要,要求 decision identity、target table、row count、dedupe keys、`needs_review` 現態、允許決策、evidence refs、matched row exact-identity/variant/overwrite guard 與 operator confirmation 對齊;仍不讀 token、不執行 CLI、不開 DB、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler,只放行到 decision approval / writer preflight 設計。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 2d0e533..07694ff 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24:PChome 近門檻身份回收第二輪 +- **V10.505 市場情報 MCP Fetch Candidate Queue Writer Review Decision gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision` 與 UI preview,只審核 review inventory 通過後的 operator candidate queue review decision 摘要;要求 decision identity、target table、row count、dedupe keys、`needs_review` 現態、允許決策集合、evidence refs、matched row exact-identity/variant/overwrite guard 與 operator confirmation 對齊,且 API 不讀 token、不執行 CLI、不開 DB、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler,只放行到 decision approval / writer preflight 設計。 - **V10.504 市場情報 MCP Fetch Candidate Queue Writer Review Inventory gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_inventory` 與 UI preview,只審核 writer review handoff 通過後的 operator read-only candidate queue inventory 摘要;要求 handoff identity、target table、row count、dedupe keys、review_state、artifact paths、read-only query result、missing/duplicate rows 與 operator confirmation 對齊,且 API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不做 inventory query、不掛 scheduler,只放行到後續人工 candidate queue review。 - **V10.503 市場情報 MCP Fetch Candidate Queue Writer Review Handoff gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff` 與 UI preview,只審核 post-closeout inventory review 通過後的 operator candidate queue review handoff 摘要;要求 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation 對齊,且 API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 - **V10.502 AiderHeal 自動修復診斷鏈修正**: `execute_code_fix()` 改為先檢查 ADR-020 檔案白名單再執行 110 preflight,避免 `tests/...` 這類不得自動修的 finding 被誤報成 `/home/wooo/ewoooc` preflight 失敗;Code Review 完成通知會把全數不在白名單的 finding 標成需人工處理,不再宣稱已觸發 AiderHeal;白名單同步放行 `services/routes/database` 子目錄 Python 檔,preflight 通知帶 stderr/stdout 細節,健康檢查接受正式 `/health` 回傳的 `healthy`。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index 9bb10e0..2585bb7 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -52,6 +52,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff impor from services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory import ( build_mcp_fetch_candidate_queue_writer_review_inventory_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision import ( + build_mcp_fetch_candidate_queue_writer_review_decision_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -715,3 +718,53 @@ def market_intel_mcp_fetch_candidate_queue_writer_review_inventory(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_review_decision(): + writer_review_inventory_package = {} + writer_review_inventory_result = None + operator_review_decision = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_review_decision_package") + or payload.get("candidate_queue_writer_review_decision") + or payload.get("review_decision") + or payload.get("operator_review_decision") + or payload + ) + writer_review_inventory_package = ( + package.get("writer_review_inventory_package") + or package.get("candidate_queue_writer_review_inventory") + or package.get("writer_review_inventory") + or package.get("review_inventory_package") + or package.get("review_inventory") + or {} + ) + writer_review_inventory_result = ( + package.get("writer_review_inventory_result") + or package.get("mcp_fetch_candidate_queue_writer_review_inventory") + ) + operator_review_decision = ( + package.get("operator_review_decision") + or package.get("candidate_queue_review_decision") + or package.get("writer_review_decision") + or package.get("review_decision_payload") + or package.get("decision_payload") + or package.get("decision") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_review_decision_preview( + writer_review_inventory_package=writer_review_inventory_package, + writer_review_inventory_result=writer_review_inventory_result, + operator_review_decision=operator_review_decision, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 8e447e9..34d8d2d 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -108,6 +108,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff impor from services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory import ( build_mcp_fetch_candidate_queue_writer_review_inventory_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision import ( + build_mcp_fetch_candidate_queue_writer_review_decision_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -287,8 +290,17 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_candidate_queue_writer_review_inventory",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) + + def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) + + def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): """建立市場情報推版準備狀態;不執行 git、部署或遠端操作。""" status = service.get_runtime_status() @@ -381,6 +393,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_review_decision = ( + build_mcp_fetch_candidate_queue_writer_review_decision_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -1325,6 +1342,76 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "candidate_review_state_updated" ] ), + "mcp_fetch_candidate_queue_writer_review_decision_preview_safe": bool( + mcp_fetch_candidate_queue_writer_review_decision["mode"] + == "mcp_fetch_candidate_queue_writer_review_decision_preview" + and not mcp_fetch_candidate_queue_writer_review_decision[ + "payload_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "review_decision_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "candidate_queue_review_decision_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "candidate_queue_review_decision_file_written" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "decision_record_written" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "decision_record_file_written" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "package_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_writes_file" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_executes_cli" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_reads_approval_token" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_writes_database" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_updates_review_state" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "api_writes_decision_record" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "database_commit_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "database_connection_opened" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "cli_executed" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "file_written" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "scheduler_attached" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "candidate_queue_persisted" + ] + and not mcp_fetch_candidate_queue_writer_review_decision[ + "candidate_review_state_updated" + ] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1653,6 +1740,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_candidate_queue_writer_post_closeout_inventory_review": mcp_fetch_candidate_queue_writer_post_closeout_inventory_review, "mcp_fetch_candidate_queue_writer_review_handoff": mcp_fetch_candidate_queue_writer_review_handoff, "mcp_fetch_candidate_queue_writer_review_inventory": mcp_fetch_candidate_queue_writer_review_inventory, + "mcp_fetch_candidate_queue_writer_review_decision": mcp_fetch_candidate_queue_writer_review_decision, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision.py b/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision.py new file mode 100644 index 0000000..eb98597 --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision.py @@ -0,0 +1,498 @@ +"""市場情報 MCP fetch candidate queue writer review decision。 + +本模組只審核 review inventory 後的人工候選隊列決策摘要; +API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 inventory query、 +不更新 review_state、不寫 match result、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + ARTIFACT_PREFIX, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_post_closeout_inventory_review import ( + FORBIDDEN_SECRET_KEYS, + SAFE_SECRET_METADATA_KEYS, + _as_dict, + _as_list, + _blocked_side_effects, + _contains_forbidden_key, + _safe_int, + _safe_path, + _safe_text, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory import ( + build_mcp_fetch_candidate_queue_writer_review_inventory_preview, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_gates import ( + ALLOWED_REVIEW_DECISIONS, + build_review_decision_gates, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_sample import ( + build_sample_writer_review_decision_package, +) + + +_REVIEW_DECISION_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_candidate_review_update", + "allow_api_execution", + "allow_api_file_write", + "allow_api_inventory_query", + "allow_api_match_write", + "allow_api_queue_insert", + "allow_api_queue_write", + "allow_cli_execution", + "allow_database_write", + "api_candidate_review_update_executed", + "api_created_review_decision_file", + "api_created_review_queue", + "api_executed_candidate_review", + "api_inventory_query_executed", + "api_review_decision_persisted", + "api_review_state_update_executed", + "api_updates_review_state", + "api_writes_match_result", + "api_writes_review_queue", + "candidate_queue_review_decision_file_written", + "candidate_queue_review_decision_persisted", + "candidate_queue_review_started_by_api", + "candidate_review_file_written", + "candidate_review_queue_written", + "decision_record_written", + "identity_match_written", + "manual_review_record_written", + "market_product_match_written", + "match_result_written", + "queue_review_persisted", + "review_decision_file_written", + "review_decision_persisted", + "review_queue_file_written", + "review_queue_row_written", + "review_state_update_executed", +) + + +def _blocked_review_decision_side_effects(payload): + found = list(_blocked_side_effects(payload)) + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if ( + normalized_key in _REVIEW_DECISION_BLOCKED_SIDE_EFFECT_KEYS + and bool(item) + ): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return sorted(set(found)) + + +def _inventory_from_inputs(inventory_package, inventory_result, phase): + if isinstance(inventory_result, dict) and inventory_result: + return inventory_result + + inventory_package = _as_dict(inventory_package) + return build_mcp_fetch_candidate_queue_writer_review_inventory_preview( + writer_review_handoff_package=( + inventory_package.get("writer_review_handoff_package") + or inventory_package.get("candidate_queue_writer_review_handoff") + or inventory_package.get("writer_review_handoff") + or inventory_package.get("review_handoff_package") + or inventory_package.get("review_handoff") + or {} + ), + writer_review_handoff_result=( + inventory_package.get("writer_review_handoff_result") + or inventory_package.get( + "mcp_fetch_candidate_queue_writer_review_handoff" + ) + ), + operator_review_inventory=( + inventory_package.get("operator_review_inventory") + or inventory_package.get("candidate_queue_review_inventory") + or inventory_package.get("writer_review_inventory") + or inventory_package.get("review_inventory_payload") + or inventory_package.get("inventory_payload") + or inventory_package.get("inventory") + ), + phase=phase, + ) + + +def _inventory_summary(inventory_result): + inventory_result = _as_dict(inventory_result) + inventory = _as_dict(inventory_result.get("operator_review_inventory_summary")) + side_effects_clear = bool( + not inventory_result.get("payload_persisted") + and not inventory_result.get("review_inventory_persisted") + and not inventory_result.get("writer_review_inventory_persisted") + and not inventory_result.get("candidate_queue_review_inventory_persisted") + and not inventory_result.get("candidate_queue_review_inventory_file_written") + and not inventory_result.get("review_inventory_file_written") + and not inventory_result.get("inventory_file_written") + and not inventory_result.get("review_queue_file_written") + and not inventory_result.get("candidate_review_file_written") + and not inventory_result.get("package_artifact_created") + and not inventory_result.get("network_request_allowed") + and not inventory_result.get("api_executes_cli") + and not inventory_result.get("api_reads_approval_token") + and not inventory_result.get("api_opens_database_connection") + and not inventory_result.get("api_writes_database") + and not inventory_result.get("api_writes_file") + and not inventory_result.get("api_uses_external_network") + and not inventory_result.get("api_inventory_query_executed") + and not inventory_result.get("api_candidate_review_update_executed") + and not inventory_result.get("api_updates_review_state") + and not inventory_result.get("review_inventory_query_executed_by_api") + and not inventory_result.get("database_write_executed") + and not inventory_result.get("database_commit_executed") + and not inventory_result.get("cli_executed") + and not inventory_result.get("file_written") + and not inventory_result.get("scheduler_attached") + and not inventory_result.get("candidate_queue_created") + and not inventory_result.get("candidate_queue_persisted") + and not inventory_result.get("candidate_review_state_updated") + ) + return { + "mode": inventory_result.get("mode"), + "accepted": bool( + inventory_result.get( + "mcp_fetch_candidate_queue_writer_review_inventory_accepted" + ) + ), + "ready_for_candidate_queue_review_decision": bool( + inventory_result.get("ready_for_candidate_queue_review_decision") + ), + "review_inventory_id": _safe_text( + inventory.get("review_inventory_id"), 160 + ), + "handoff_id": _safe_text(inventory.get("handoff_id"), 160), + "inventory_review_id": _safe_text(inventory.get("inventory_review_id"), 160), + "closeout_id": _safe_text(inventory.get("closeout_id"), 160), + "run_package_id": _safe_text(inventory.get("run_package_id"), 160), + "receipt_id": _safe_text(inventory.get("receipt_id"), 160), + "target_table": _safe_text(inventory.get("target_table"), 160), + "payload_row_count": _safe_int(inventory.get("payload_row_count")), + "expected_payload_row_count": _safe_int( + inventory.get("expected_payload_row_count") + or inventory.get("payload_row_count") + ), + "found_row_count": _safe_int(inventory.get("found_row_count")), + "dedupe_key_count": _safe_int(inventory.get("dedupe_key_count")), + "sample_dedupe_keys": [ + _safe_text(item, 160) + for item in _as_list(inventory.get("sample_dedupe_keys")) + if _safe_text(item, 160) + ], + "review_state": _safe_text(inventory.get("review_state"), 80), + "review_state_breakdown": _as_dict(inventory.get("review_state_breakdown")), + "review_queue_artifact_path": _safe_text( + inventory.get("review_queue_artifact_path") + ), + "review_inventory_artifact_path": _safe_text( + inventory.get("review_inventory_artifact_path") + ), + "read_only_query_result_path": _safe_text( + inventory.get("read_only_query_result_path") + ), + "side_effects_clear": side_effects_clear, + "blocked_reasons": inventory_result.get("blocked_reasons", []), + } + + +def _decision_row_summary(row): + row = _as_dict(row) + return { + "dedupe_key": _safe_text(row.get("dedupe_key"), 160), + "current_review_state": _safe_text(row.get("current_review_state"), 80), + "proposed_review_decision": _safe_text( + row.get("proposed_review_decision"), 80 + ), + "decision_bucket": _safe_text(row.get("decision_bucket"), 120), + "evidence_lane": _safe_text(row.get("evidence_lane"), 120), + "evidence_ref": _safe_text(row.get("evidence_ref")), + "evidence_ref_safe": _safe_path( + row.get("evidence_ref"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "decision_notes_present": bool(_safe_text(row.get("decision_notes"))), + "hard_veto_present": bool(row.get("hard_veto_present")), + "stronger_existing_match_conflict": bool( + row.get("stronger_existing_match_conflict") + ), + "false_positive_guard_passed": bool(row.get("false_positive_guard_passed")), + "variant_conflict_checked": bool(row.get("variant_conflict_checked")), + "overwrite_protection_checked": bool( + row.get("overwrite_protection_checked") + ), + "exact_identity_confirmed": bool(row.get("exact_identity_confirmed")), + } + + +def _operator_review_decision_summary(operator_decision): + operator_decision = _as_dict(operator_decision) + confirmations = _as_dict(operator_decision.get("operator_confirmations")) + rows = [_decision_row_summary(row) for row in _as_list( + operator_decision.get("decision_rows") + )] + expected_dedupe_keys = [ + _safe_text(item, 160) + for item in _as_list(operator_decision.get("expected_dedupe_keys")) + if _safe_text(item, 160) + ] + return { + "provided_keys": sorted(operator_decision.keys()), + "review_decision_id": _safe_text( + operator_decision.get("review_decision_id"), 160 + ), + "review_inventory_id": _safe_text( + operator_decision.get("review_inventory_id"), 160 + ), + "handoff_id": _safe_text(operator_decision.get("handoff_id"), 160), + "inventory_review_id": _safe_text( + operator_decision.get("inventory_review_id"), 160 + ), + "closeout_id": _safe_text(operator_decision.get("closeout_id"), 160), + "run_package_id": _safe_text(operator_decision.get("run_package_id"), 160), + "receipt_id": _safe_text(operator_decision.get("receipt_id"), 160), + "target_table": _safe_text(operator_decision.get("target_table"), 160), + "decision_scope": _safe_text(operator_decision.get("decision_scope"), 120), + "decision_mode": _safe_text(operator_decision.get("decision_mode"), 120), + "expected_current_review_state": _safe_text( + operator_decision.get("expected_current_review_state"), 80 + ), + "decision_row_count": _safe_int(operator_decision.get("decision_row_count")), + "expected_decision_row_count": _safe_int( + operator_decision.get("expected_decision_row_count") + or operator_decision.get("decision_row_count") + ), + "expected_dedupe_keys": expected_dedupe_keys, + "decision_rows": rows, + "review_queue_artifact_path": _safe_text( + operator_decision.get("review_queue_artifact_path") + ), + "review_inventory_artifact_path": _safe_text( + operator_decision.get("review_inventory_artifact_path") + ), + "review_decision_artifact_path": _safe_text( + operator_decision.get("review_decision_artifact_path") + ), + "review_queue_artifact_path_safe": _safe_path( + operator_decision.get("review_queue_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "review_inventory_artifact_path_safe": _safe_path( + operator_decision.get("review_inventory_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "review_decision_artifact_path_safe": _safe_path( + operator_decision.get("review_decision_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "review_inventory_checked": bool( + confirmations.get("review_inventory_checked") + ), + "candidate_queue_review_only": bool( + confirmations.get("candidate_queue_review_only") + ), + "human_decision_only": bool(confirmations.get("human_decision_only")), + "manual_record_required": bool(confirmations.get("manual_record_required")), + "no_approval_token_payload": bool( + confirmations.get("no_approval_token_payload") + ), + "no_api_cli_execution": bool(confirmations.get("no_api_cli_execution")), + "no_api_database_write": bool(confirmations.get("no_api_database_write")), + "no_api_inventory_query": bool(confirmations.get("no_api_inventory_query")), + "no_api_review_state_update": bool( + confirmations.get("no_api_review_state_update") + ), + "no_api_queue_insert": bool(confirmations.get("no_api_queue_insert")), + "no_api_file_write": bool(confirmations.get("no_api_file_write")), + "no_scheduler_attach": bool(confirmations.get("no_scheduler_attach")), + "stronger_existing_match_guard_preserved": bool( + confirmations.get("stronger_existing_match_guard_preserved") + ), + "false_positive_guard_completed": bool( + confirmations.get("false_positive_guard_completed") + ), + "variant_sensitive_review_completed": bool( + confirmations.get("variant_sensitive_review_completed") + ), + "hard_veto_respected": bool(confirmations.get("hard_veto_respected")), + "api_execution_allowed": bool(operator_decision.get("api_execution_allowed")), + "real_write_allowed_by_api": bool( + operator_decision.get("real_write_allowed_by_api") + ), + "api_candidate_review_allowed": bool( + operator_decision.get("api_candidate_review_allowed") + ), + "api_updates_review_state": bool( + operator_decision.get("api_updates_review_state") + ), + "api_writes_match_result": bool( + operator_decision.get("api_writes_match_result") + ), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + operator_decision, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_review_decision_side_effects( + operator_decision + ), + } + + +def build_mcp_fetch_candidate_queue_writer_review_decision_preview( + *, + writer_review_inventory_package=None, + writer_review_inventory_result=None, + operator_review_decision=None, + phase=None, +): + """建立 writer review decision;不執行查詢、寫檔或寫入。""" + writer_review_inventory_package = _as_dict(writer_review_inventory_package) + inventory_result_received = bool( + isinstance(writer_review_inventory_result, dict) + and writer_review_inventory_result + ) + decision_valid_object = ( + isinstance(operator_review_decision, dict) + if operator_review_decision is not None + else True + ) + decision_payload = _as_dict(operator_review_decision) + inventory_received = bool( + writer_review_inventory_package or inventory_result_received + ) + inventory_result = ( + _inventory_from_inputs( + writer_review_inventory_package, + writer_review_inventory_result, + phase, + ) + if inventory_received + else {} + ) + payload_received = bool( + inventory_received or decision_payload or operator_review_decision is not None + ) + decision_received = bool(decision_payload) + inventory = _inventory_summary(inventory_result) + decision = _operator_review_decision_summary(decision_payload) + gates = build_review_decision_gates( + inventory_received=inventory_received, + decision_received=decision_received and decision_valid_object, + inventory=inventory, + decision=decision, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + if not decision_valid_object: + blocked_reasons.append("operator_review_decision_payload_valid_object") + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_review_decision" + if payload_received + else "mcp_fetch_candidate_queue_writer_review_decision_preview" + ), + "phase": phase, + "writer_review_decision_payload_received": payload_received, + "review_decision_payload_received": payload_received, + "writer_review_inventory_received": inventory_received, + "operator_review_decision_received": decision_received, + "operator_review_decision_valid_object": decision_valid_object, + "writer_review_inventory_accepted": inventory["accepted"], + "mcp_fetch_candidate_queue_writer_review_decision_accepted": accepted, + "candidate_queue_writer_review_decision_ready": accepted, + "ready_for_candidate_queue_human_review": accepted, + "ready_for_candidate_queue_review_decision_approval": accepted, + "ready_for_candidate_queue_review_state_writer": False, + "ready_for_candidate_queue_review_decision_writer_preflight": False, + "ready_for_api_database_write": False, + "ready_for_real_write": False, + "ready_for_scheduler_attach": False, + "ready_for_candidate_queue_review_api_update": False, + "ready_for_api_review_state_update": False, + "ready_for_api_match_write": False, + "network_request_allowed": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_writes_file": False, + "api_uses_external_network": False, + "api_inventory_query_executed": False, + "api_candidate_review_update_executed": False, + "api_updates_review_state": False, + "api_writes_decision_record": False, + "api_writes_match_result": False, + "review_decision_query_executed_by_api": False, + "payload_row_count": decision["decision_row_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "writer_review_inventory_summary": inventory, + "operator_review_decision_summary": decision, + "decision_rows": decision["decision_rows"], + "decision_contract": { + "expected_current_state": "needs_review", + "allowed_next_states": list(ALLOWED_REVIEW_DECISIONS), + "manual_decision_required": True, + "next_gate": "candidate_queue_review_decision_approval", + "decision_scope": "candidate_queue_review_decision", + "forbidden_api_actions": [ + "update_review_state", + "write_match_result", + "write_decision_record", + "insert_missing_queue_row", + "attach_scheduler", + ], + }, + "sample_writer_review_decision_package": ( + build_sample_writer_review_decision_package() + ), + "next_operator_steps": [ + "Decision 通過後,只代表可進入人工 approval / writer preflight 設計", + "API/UI 仍不得自動寫 review_state、寫 match result、補 queue row 或讀 token", + "matched 決策必須保留 exact identity、variant、false-positive 與 overwrite guard", + ], + "payload_persisted": False, + "review_decision_persisted": False, + "writer_review_decision_persisted": False, + "candidate_queue_review_decision_persisted": False, + "candidate_queue_review_decision_file_written": False, + "review_decision_file_written": False, + "decision_record_written": False, + "decision_record_file_written": False, + "review_queue_file_written": False, + "candidate_review_file_written": False, + "match_result_written": False, + "market_product_match_written": False, + "package_artifact_created": False, + "database_connection_opened": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "cli_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + } diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_gates.py b/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_gates.py new file mode 100644 index 0000000..069da49 --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_gates.py @@ -0,0 +1,241 @@ +"""Gate checks for market intel candidate queue review decision.""" + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE + + +ALLOWED_REVIEW_DECISIONS = ( + "matched", + "low_score", + "identity_veto", + "unit_comparable", + "fresh_search_required", + "deferred", +) + + +def _sample_keys_covered_by_expected(inventory, decision): + sample_keys = set(inventory["sample_dedupe_keys"]) + expected_keys = set(decision["expected_dedupe_keys"]) + return bool(sample_keys and sample_keys.issubset(expected_keys)) + + +def _row_keys_match_expected(decision): + row_keys = [row["dedupe_key"] for row in decision["decision_rows"]] + expected_keys = decision["expected_dedupe_keys"] + return bool( + row_keys + and len(row_keys) == len(set(row_keys)) + and set(row_keys) == set(expected_keys) + ) + + +def _all_rows_have_allowed_decisions(decision): + return bool( + decision["decision_rows"] + and all( + row["proposed_review_decision"] in ALLOWED_REVIEW_DECISIONS + for row in decision["decision_rows"] + ) + ) + + +def _all_rows_have_manual_evidence(decision): + return bool( + decision["decision_rows"] + and all( + row["decision_notes_present"] and row["evidence_ref_safe"] + for row in decision["decision_rows"] + ) + ) + + +def _matched_rows_keep_identity_guards(decision): + matched_rows = [ + row + for row in decision["decision_rows"] + if row["proposed_review_decision"] == "matched" + ] + if not matched_rows: + return True + return all( + row["evidence_lane"] == "exact_identity" + and row["exact_identity_confirmed"] + and not row["hard_veto_present"] + and not row["stronger_existing_match_conflict"] + and row["false_positive_guard_passed"] + and row["variant_conflict_checked"] + and row["overwrite_protection_checked"] + for row in matched_rows + ) + + +def build_review_decision_gates(*, inventory_received, decision_received, inventory, decision): + operator_confirmed_boundaries = bool( + decision["review_inventory_checked"] + and decision["candidate_queue_review_only"] + and decision["human_decision_only"] + and decision["manual_record_required"] + and decision["no_approval_token_payload"] + and decision["no_api_cli_execution"] + and decision["no_api_database_write"] + and decision["no_api_inventory_query"] + and decision["no_api_review_state_update"] + and decision["no_api_queue_insert"] + and decision["no_api_file_write"] + and decision["no_scheduler_attach"] + and decision["stronger_existing_match_guard_preserved"] + and decision["false_positive_guard_completed"] + and decision["variant_sensitive_review_completed"] + and decision["hard_veto_respected"] + ) + return [ + { + "key": "candidate_queue_review_inventory_payload_or_result_received", + "label": "已提供 review inventory package 或已審核結果", + "passed": inventory_received, + }, + { + "key": "candidate_queue_review_inventory_accepted", + "label": "review inventory gate 必須已通過", + "passed": inventory["accepted"], + }, + { + "key": "candidate_queue_review_inventory_ready_for_decision", + "label": "inventory 必須只放行到 candidate queue review decision", + "passed": inventory["ready_for_candidate_queue_review_decision"], + }, + { + "key": "candidate_queue_review_inventory_side_effect_free", + "label": "inventory 未顯示 API 執行、寫 DB、查 DB、更新 review_state 或掛 scheduler", + "passed": inventory["side_effects_clear"], + }, + { + "key": "candidate_queue_review_decision_payload_received", + "label": "已提供 operator candidate queue review decision 摘要", + "passed": decision_received, + }, + { + "key": "candidate_queue_review_decision_identity_recorded", + "label": "decision 必須記錄 review_decision_id 與上游 identity", + "passed": bool( + decision["review_decision_id"] + and decision["review_inventory_id"] + and decision["handoff_id"] + and decision["inventory_review_id"] + and decision["closeout_id"] + and decision["run_package_id"] + and decision["receipt_id"] + ), + }, + { + "key": "candidate_queue_review_decision_identity_matches_inventory", + "label": "decision identity 必須對齊 review inventory", + "passed": bool( + decision["review_inventory_id"] == inventory["review_inventory_id"] + and decision["handoff_id"] == inventory["handoff_id"] + and decision["inventory_review_id"] == inventory["inventory_review_id"] + and decision["closeout_id"] == inventory["closeout_id"] + and decision["run_package_id"] == inventory["run_package_id"] + and decision["receipt_id"] == inventory["receipt_id"] + ), + }, + { + "key": "candidate_queue_review_decision_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": decision["target_table"] == TARGET_TABLE, + }, + { + "key": "candidate_queue_review_decision_scope_safe", + "label": "decision 僅能是 human review only", + "passed": bool( + decision["decision_scope"] == "candidate_queue_review_decision" + and decision["decision_mode"] == "human_review_only" + and decision["expected_current_review_state"] == "needs_review" + ), + }, + { + "key": "candidate_queue_review_decision_row_count_matches_inventory", + "label": "decision row count 必須對齊 inventory dedupe count", + "passed": bool( + decision["expected_decision_row_count"] + and decision["decision_row_count"] + == decision["expected_decision_row_count"] + == inventory["dedupe_key_count"] + == inventory["found_row_count"] + and len(decision["decision_rows"]) == inventory["dedupe_key_count"] + ), + }, + { + "key": "candidate_queue_review_decision_dedupe_keys_match_inventory", + "label": "decision dedupe keys 必須覆蓋 inventory keys 且逐列對齊", + "passed": bool( + _sample_keys_covered_by_expected(inventory, decision) + and _row_keys_match_expected(decision) + ), + }, + { + "key": "candidate_queue_review_decision_rows_still_needs_review", + "label": "所有 decision rows 的目前狀態必須仍是 needs_review", + "passed": bool( + decision["decision_rows"] + and all( + row["current_review_state"] == "needs_review" + for row in decision["decision_rows"] + ) + ), + }, + { + "key": "candidate_queue_review_decision_values_allowed", + "label": "人工決策只能使用允許的狀態集合", + "passed": _all_rows_have_allowed_decisions(decision), + }, + { + "key": "candidate_queue_review_decision_row_evidence_complete", + "label": "每列決策必須保留 evidence ref 與 notes", + "passed": _all_rows_have_manual_evidence(decision), + }, + { + "key": "candidate_queue_review_decision_matched_rows_keep_identity_guards", + "label": "matched rows 必須保留 exact identity、false-positive、variant 與 overwrite guard", + "passed": _matched_rows_keep_identity_guards(decision), + }, + { + "key": "candidate_queue_review_decision_artifact_paths_safe", + "label": "review queue、inventory 與 decision artifact paths 必須安全並對齊", + "passed": bool( + decision["review_queue_artifact_path_safe"] + and decision["review_inventory_artifact_path_safe"] + and decision["review_decision_artifact_path_safe"] + and decision["review_queue_artifact_path"] + == inventory["review_queue_artifact_path"] + and decision["review_inventory_artifact_path"] + == inventory["review_inventory_artifact_path"] + ), + }, + { + "key": "candidate_queue_review_decision_operator_boundaries_confirmed", + "label": "操作員確認 API 未執行 CLI/DB/query/file/review_state/scheduler,且 guardrail 已完成", + "passed": operator_confirmed_boundaries, + }, + { + "key": "candidate_queue_review_decision_no_api_execution_or_real_write", + "label": "decision payload 不得允許 API execution、real write、review update 或 match write", + "passed": bool( + not decision["api_execution_allowed"] + and not decision["real_write_allowed_by_api"] + and not decision["api_candidate_review_allowed"] + and not decision["api_updates_review_state"] + and not decision["api_writes_match_result"] + ), + }, + { + "key": "candidate_queue_review_decision_no_secret_or_token_key", + "label": "decision payload 不得包含 secret、cookie、password 或 token key", + "passed": not decision["secret_or_token_submitted_to_api"], + }, + { + "key": "candidate_queue_review_decision_side_effect_free", + "label": "decision payload 不得要求 API 寫檔、執行、查 DB、寫 DB、補 queue、寫 match 或掛 scheduler", + "passed": not decision["blocked_side_effects"], + }, + ] diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_sample.py b/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_sample.py new file mode 100644 index 0000000..199811a --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_sample.py @@ -0,0 +1,118 @@ +"""Sample payload for the market intel candidate queue review decision gate.""" + +from copy import deepcopy + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + ARTIFACT_PREFIX, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory import ( + build_mcp_fetch_candidate_queue_writer_review_inventory_preview, +) + + +_SAMPLE_WRITER_REVIEW_DECISION_PACKAGE = None + + +def build_sample_writer_review_decision_package(): + global _SAMPLE_WRITER_REVIEW_DECISION_PACKAGE + if _SAMPLE_WRITER_REVIEW_DECISION_PACKAGE is not None: + return deepcopy(_SAMPLE_WRITER_REVIEW_DECISION_PACKAGE) + + inventory_preview = ( + build_mcp_fetch_candidate_queue_writer_review_inventory_preview() + ) + inventory_package = inventory_preview["sample_writer_review_inventory_package"] + inventory_result = build_mcp_fetch_candidate_queue_writer_review_inventory_preview( + writer_review_handoff_package=inventory_package[ + "writer_review_handoff_package" + ], + writer_review_handoff_result=inventory_package[ + "writer_review_handoff_result" + ], + operator_review_inventory=inventory_package["operator_review_inventory"], + ) + inventory = inventory_result["operator_review_inventory_summary"] + dedupe_keys = inventory["sample_dedupe_keys"] + decision_rows = [] + for index, dedupe_key in enumerate(dedupe_keys): + proposed_decision = "matched" if index == 0 else "low_score" + decision_rows.append( + { + "dedupe_key": dedupe_key, + "current_review_state": "needs_review", + "proposed_review_decision": proposed_decision, + "decision_bucket": "recoverable_low_score", + "evidence_lane": "exact_identity", + "evidence_ref": ( + ARTIFACT_PREFIX + + f"candidate-queue-review-decision-evidence-{index + 1}.json" + ), + "decision_notes": ( + "same candidate lane checked; keep human audit trail" + ), + "hard_veto_present": False, + "stronger_existing_match_conflict": False, + "false_positive_guard_passed": True, + "variant_conflict_checked": True, + "overwrite_protection_checked": True, + "exact_identity_confirmed": proposed_decision == "matched", + } + ) + + operator_review_decision = { + "review_decision_id": ( + "market-intel-candidate-writer-review-decision-sample" + ), + "review_inventory_id": inventory["review_inventory_id"], + "handoff_id": inventory["handoff_id"], + "inventory_review_id": inventory["inventory_review_id"], + "closeout_id": inventory["closeout_id"], + "run_package_id": inventory["run_package_id"], + "receipt_id": inventory["receipt_id"], + "target_table": TARGET_TABLE, + "decision_scope": "candidate_queue_review_decision", + "decision_mode": "human_review_only", + "expected_current_review_state": "needs_review", + "decision_row_count": len(decision_rows), + "expected_decision_row_count": inventory["dedupe_key_count"], + "expected_dedupe_keys": dedupe_keys, + "review_queue_artifact_path": inventory["review_queue_artifact_path"], + "review_inventory_artifact_path": ( + inventory["review_inventory_artifact_path"] + ), + "review_decision_artifact_path": ( + ARTIFACT_PREFIX + + "candidate-queue-review-decision-sample.json" + ), + "decision_rows": decision_rows, + "operator_confirmations": { + "review_inventory_checked": True, + "candidate_queue_review_only": True, + "human_decision_only": True, + "manual_record_required": True, + "no_approval_token_payload": True, + "no_api_cli_execution": True, + "no_api_database_write": True, + "no_api_inventory_query": True, + "no_api_review_state_update": True, + "no_api_queue_insert": True, + "no_api_file_write": True, + "no_scheduler_attach": True, + "stronger_existing_match_guard_preserved": True, + "false_positive_guard_completed": True, + "variant_sensitive_review_completed": True, + "hard_veto_respected": True, + }, + "api_execution_allowed": False, + "real_write_allowed_by_api": False, + "api_candidate_review_allowed": False, + "api_updates_review_state": False, + "api_writes_match_result": False, + } + _SAMPLE_WRITER_REVIEW_DECISION_PACKAGE = { + "writer_review_inventory_package": inventory_package, + "writer_review_inventory_result": inventory_result, + "operator_review_decision": operator_review_decision, + } + return deepcopy(_SAMPLE_WRITER_REVIEW_DECISION_PACKAGE) diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 5c20390..a3fdc48 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" +MARKET_INTEL_PHASE = "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index f541d09..ef2b5bb 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -1072,6 +1072,32 @@ +
+
+
+

MCP / REVIEW DECISION

+

MCP Candidate Queue Writer Review Decision

+
+ +
+
+ loading +
+
+
讀取 MCP Writer Review Decision 中...
+
+
+ +
+ +
+
+
+
@@ -1596,6 +1622,7 @@ const mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-post-closeout-inventory-review]'); const mcpFetchCandidateQueueWriterReviewHandoffRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff]'); const mcpFetchCandidateQueueWriterReviewInventoryRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-inventory]'); + const mcpFetchCandidateQueueWriterReviewDecisionRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1612,7 +1639,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot && !mcpFetchCandidateQueueWriterReviewHandoffRoot && !mcpFetchCandidateQueueWriterReviewInventoryRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot && !mcpFetchCandidateQueueWriterReviewHandoffRoot && !mcpFetchCandidateQueueWriterReviewInventoryRoot && !mcpFetchCandidateQueueWriterReviewDecisionRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1779,6 +1806,12 @@ const mcpFetchCandidateQueueWriterReviewInventoryReview = mcpFetchCandidateQueueWriterReviewInventoryRoot ? mcpFetchCandidateQueueWriterReviewInventoryRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-inventory-review]') : null; const mcpFetchCandidateQueueWriterReviewInventoryRefresh = mcpFetchCandidateQueueWriterReviewInventoryRoot ? mcpFetchCandidateQueueWriterReviewInventoryRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-inventory-refresh]') : null; const mcpFetchCandidateQueueWriterReviewInventoryEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_inventory') }}"; + const mcpFetchCandidateQueueWriterReviewDecisionMeta = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-meta]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionBody = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-body]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionInput = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-input]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionReview = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-review]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionRefresh = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-refresh]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_decision') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -5261,6 +5294,143 @@ } }; + const renderMcpFetchCandidateQueueWriterReviewDecisionMeta = data => { + const decisionRows = data.decision_rows || data.operator_review_decision_summary?.decision_rows || []; + mcpFetchCandidateQueueWriterReviewDecisionMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_review_decision_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || data.operator_review_decision_summary?.decision_row_count || decisionRows.length || 0}`, + `decision=${data.ready_for_candidate_queue_review_decision_approval ? 'ready' : 'blocked'}`, + `match=${data.api_writes_match_result ? 'api' : 'manual'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterReviewDecisionBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const inventory = data.writer_review_inventory_summary || {}; + const decision = data.operator_review_decision_summary || {}; + const rows = decision.decision_rows || data.decision_rows || []; + const contract = data.decision_contract || {}; + const allowedDecisions = contract.allowed_next_states || []; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterReviewDecisionBody.innerHTML = ` +
此 review decision 只審核人工候選隊列決策摘要;API 不更新 review_state、不寫 match result、不補 queue row、不讀 approval token、不執行 CLI、不開 DB、不掛 scheduler。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

DECISION GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 decision gates。
' + }
+
+
+

INVENTORY LINK

+
+ ${renderCheck('inventory', `${inventory.mode || 'missing'} / ${inventory.accepted ? 'accepted' : 'pending'}`, inventory.accepted ? 'ACCEPTED' : 'BLOCK')} + ${renderCheck('review_inventory_id', inventory.review_inventory_id || 'missing', inventory.review_inventory_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('handoff_id', inventory.handoff_id || 'missing', inventory.handoff_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('target_table', inventory.target_table || 'missing', inventory.target_table === 'market_alert_review_queue' ? 'SAFE' : 'BLOCK')} + ${renderCheck('rows', `${inventory.found_row_count || 0}/${inventory.dedupe_key_count || 0}`, inventory.found_row_count === inventory.dedupe_key_count && inventory.found_row_count > 0 ? 'MATCH' : 'BLOCK')} + ${renderCheck('api_boundary', 'no DB / no queue write / no review_state update / no scheduler', inventory.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

DECISION SUMMARY

+
+ ${renderCheck('review_decision_id', decision.review_decision_id || 'missing', decision.review_decision_id ? 'RECORDED' : 'BLOCK')} + ${renderCheck('scope', `${decision.decision_scope || 'missing'} / ${decision.decision_mode || 'missing'}`, decision.decision_scope === 'candidate_queue_review_decision' && decision.decision_mode === 'human_review_only' ? 'SAFE' : 'BLOCK')} + ${renderCheck('current_state', decision.expected_current_review_state || 'missing', decision.expected_current_review_state === 'needs_review' ? 'LOCKED' : 'BLOCK')} + ${renderCheck('artifacts', `${decision.review_decision_artifact_path || 'missing'}`, decision.review_decision_artifact_path_safe ? 'SAFE' : 'BLOCK')} +
+
+
+

DECISION ROWS

+
${ + rows.length + ? rows.map((row, index) => renderCheck( + row.dedupe_key || `row_${index + 1}`, + `${row.current_review_state || 'missing'} -> ${row.proposed_review_decision || 'missing'} / ${row.evidence_lane || 'missing'}`, + allowedDecisions.includes(row.proposed_review_decision) && row.current_review_state === 'needs_review' && row.evidence_ref_safe && row.decision_notes_present ? 'READY' : 'BLOCK' + )).join('') + : '
尚未提供 decision rows。
' + }
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck('allowed_decisions', allowedDecisions.join(' / ') || 'missing', allowedDecisions.length ? 'LOCKED' : 'BLOCK')} + ${renderCheck('manual_only', `${contract.next_gate || 'candidate_queue_review_decision_approval'} / ${contract.decision_scope || 'missing'}`, contract.manual_decision_required ? 'CONFIRMED' : 'BLOCK')} + ${renderCheck('operator_boundaries', 'manual decision / no API DB write / no review_state update / no match write', decision.review_inventory_checked && decision.human_decision_only && decision.no_api_cli_execution && decision.no_api_database_write && decision.no_api_inventory_query && decision.no_api_review_state_update && decision.no_api_queue_insert && decision.no_api_file_write && decision.no_scheduler_attach ? 'CONFIRMED' : 'BLOCK')} + ${renderCheck('identity_guards', 'stronger existing match / false positive / variant / hard veto', decision.stronger_existing_match_guard_preserved && decision.false_positive_guard_completed && decision.variant_sensitive_review_completed && decision.hard_veto_respected ? 'CONFIRMED' : 'BLOCK')} + ${renderCheck('api_side_effects', 'no decision record write / no match write / no scheduler', data.api_writes_decision_record || data.api_writes_match_result || data.decision_record_written || data.candidate_review_state_updated || data.scheduler_attached ? 'BLOCK' : 'CLOSED')} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterReviewDecisionInput && !mcpFetchCandidateQueueWriterReviewDecisionInput.value.trim() && data.sample_writer_review_decision_package) { + mcpFetchCandidateQueueWriterReviewDecisionInput.value = JSON.stringify(data.sample_writer_review_decision_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterReviewDecision = async () => { + if (!mcpFetchCandidateQueueWriterReviewDecisionMeta || !mcpFetchCandidateQueueWriterReviewDecisionBody) return; + mcpFetchCandidateQueueWriterReviewDecisionBody.innerHTML = '
讀取 MCP Writer Review Decision 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterReviewDecisionEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterReviewDecisionMeta(data); + renderMcpFetchCandidateQueueWriterReviewDecisionBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterReviewDecisionMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterReviewDecisionBody.innerHTML = `
MCP Writer Review Decision 讀取失敗:${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterReviewDecision = async () => { + if (!mcpFetchCandidateQueueWriterReviewDecisionMeta || !mcpFetchCandidateQueueWriterReviewDecisionBody || !mcpFetchCandidateQueueWriterReviewDecisionInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterReviewDecisionInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterReviewDecisionMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterReviewDecisionBody.innerHTML = `
JSON 格式錯誤:${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterReviewDecisionBody.innerHTML = '
審核 MCP Writer Review Decision 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterReviewDecisionEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_review_decision_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterReviewDecisionMeta(data); + renderMcpFetchCandidateQueueWriterReviewDecisionBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterReviewDecisionMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterReviewDecisionBody.innerHTML = `
MCP Writer Review Decision 審核失敗:${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -14784,6 +14954,12 @@ if (mcpFetchCandidateQueueWriterReviewInventoryReview) { mcpFetchCandidateQueueWriterReviewInventoryReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterReviewInventory); } + if (mcpFetchCandidateQueueWriterReviewDecisionRefresh) { + mcpFetchCandidateQueueWriterReviewDecisionRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterReviewDecision); + } + if (mcpFetchCandidateQueueWriterReviewDecisionReview) { + mcpFetchCandidateQueueWriterReviewDecisionReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterReviewDecision); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -15058,6 +15234,7 @@ loadMcpFetchCandidateQueueWriterPostCloseoutInventoryReview(); loadMcpFetchCandidateQueueWriterReviewHandoff(); loadMcpFetchCandidateQueueWriterReviewInventory(); + loadMcpFetchCandidateQueueWriterReviewDecision(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index f6964b5..bfabab1 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -65,6 +65,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff impor from services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory import ( build_mcp_fetch_candidate_queue_writer_review_inventory_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision import ( + build_mcp_fetch_candidate_queue_writer_review_decision_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1294,6 +1297,34 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-review-inventory-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_decision" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-inventory" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-decision" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-rows" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1764,7 +1795,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert bridge["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1922,7 +1953,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert contract["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -2055,7 +2086,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -2068,7 +2099,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert gate["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -2138,7 +2169,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -2152,7 +2183,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert audit["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -2226,7 +2257,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -2243,11 +2274,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert evidence["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2272,7 +2303,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2330,12 +2361,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2344,11 +2375,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert receipt["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2376,7 +2407,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2441,12 +2472,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2455,11 +2486,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert promotion["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2487,7 +2518,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2547,12 +2578,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2561,11 +2592,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2593,7 +2624,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2655,12 +2686,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2671,11 +2702,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2705,7 +2736,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2783,13 +2814,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2801,11 +2832,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert package["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2837,7 +2868,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2912,13 +2943,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2932,11 +2963,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert readiness["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2971,11 +3002,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert readiness["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -3051,13 +3082,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -3071,11 +3102,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert receipt["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -3112,11 +3143,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert receipt["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -3195,13 +3226,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3217,11 +3248,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert parser["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3260,11 +3291,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert parser["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3349,13 +3380,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3371,11 +3402,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3414,11 +3445,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3508,13 +3539,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3531,11 +3562,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3572,11 +3603,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3667,13 +3698,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3689,13 +3720,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3733,13 +3764,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3843,7 +3874,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3852,7 +3883,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3868,13 +3899,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( review["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert review["writer_cli_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False @@ -3910,13 +3941,13 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): writer_preflight_package=sample["writer_preflight_package"], writer_preflight_result=sample["writer_preflight_result"], writer_cli_review=sample["writer_cli_review"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( review["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert review["candidate_queue_writer_cli_review_ready"] is True @@ -4017,7 +4048,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4026,7 +4057,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True @@ -4043,7 +4074,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == ( @@ -4051,7 +4082,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_wit ) assert ( review["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert review["writer_run_package_review_payload_received"] is False assert ( @@ -4101,13 +4132,13 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_accepts_sample_revi writer_cli_review_package=sample["writer_cli_review_package"], writer_cli_review_result=sample["writer_cli_review_result"], writer_run_package_review=sample["writer_run_package_review"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_run_package_review" assert ( review["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4231,7 +4262,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4243,7 +4274,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4263,7 +4294,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert readiness["mode"] == ( @@ -4271,7 +4302,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_ ) assert ( readiness["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert readiness["writer_run_readiness_payload_received"] is False assert ( @@ -4317,13 +4348,13 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_accepts_sample_review(): ], writer_run_package_review_result=sample["writer_run_package_review_result"], operator_readiness=sample["operator_readiness"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert readiness["mode"] == "mcp_fetch_candidate_queue_writer_run_readiness_review" assert ( readiness["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4439,7 +4470,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4451,7 +4482,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4471,7 +4502,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_without_payload(): receipt = build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert receipt["mode"] == ( @@ -4479,7 +4510,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_wit ) assert ( receipt["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert receipt["writer_run_receipt_review_payload_received"] is False assert ( @@ -4524,13 +4555,13 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_accepts_sample_revi writer_run_readiness_package=sample["writer_run_readiness_package"], writer_run_readiness_result=sample["writer_run_readiness_result"], writer_run_receipt=sample["writer_run_receipt"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert receipt["mode"] == "mcp_fetch_candidate_queue_writer_run_receipt_review" assert ( receipt["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( receipt["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4662,7 +4693,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4674,7 +4705,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4694,7 +4725,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_without_payload(): closeout = build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert closeout["mode"] == ( @@ -4702,7 +4733,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_wi ) assert ( closeout["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert closeout["writer_run_closeout_review_payload_received"] is False assert ( @@ -4755,13 +4786,13 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_accepts_sample_rev ], writer_run_receipt_review_result=sample["writer_run_receipt_review_result"], operator_closeout=sample["operator_closeout"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert closeout["mode"] == "mcp_fetch_candidate_queue_writer_run_closeout_review" assert ( closeout["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( closeout["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] @@ -4902,7 +4933,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4914,7 +4945,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post ) assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] @@ -4938,7 +4969,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview_is_safe_without_payload(): inventory = ( build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) ) @@ -4947,7 +4978,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview ) assert ( inventory["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert inventory["post_closeout_inventory_review_payload_received"] is False assert ( @@ -5003,7 +5034,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepts "writer_run_closeout_review_result" ], operator_inventory=sample["operator_inventory"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) ) @@ -5013,7 +5044,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepts ) assert ( inventory["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( inventory[ @@ -5163,7 +5194,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5176,7 +5207,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g ) assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data[ @@ -5199,7 +5230,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g def test_mcp_fetch_candidate_queue_writer_review_handoff_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_queue_writer_review_handoff_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert handoff["mode"] == ( @@ -5207,7 +5238,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_preview_is_safe_without ) assert ( handoff["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert handoff["review_handoff_payload_received"] is False assert ( @@ -5255,13 +5286,13 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_accepts_sample_review() "writer_post_closeout_inventory_review_result" ], operator_handoff=sample["operator_handoff"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert handoff["mode"] == "mcp_fetch_candidate_queue_writer_review_handoff" assert ( handoff["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( handoff["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] @@ -5419,7 +5450,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_prev ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5429,7 +5460,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_prev assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_handoff" assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] @@ -5452,7 +5483,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_prev def test_mcp_fetch_candidate_queue_writer_review_inventory_preview_is_safe_without_payload(): inventory = build_mcp_fetch_candidate_queue_writer_review_inventory_preview( - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert inventory["mode"] == ( @@ -5460,7 +5491,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_preview_is_safe_witho ) assert ( inventory["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert inventory["review_inventory_payload_received"] is False assert ( @@ -5504,13 +5535,13 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_accepts_sample_invent writer_review_handoff_package=sample["writer_review_handoff_package"], writer_review_handoff_result=sample["writer_review_handoff_result"], operator_review_inventory=sample["operator_review_inventory"], - phase="phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory", + phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", ) assert inventory["mode"] == "mcp_fetch_candidate_queue_writer_review_inventory" assert ( inventory["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( inventory["mcp_fetch_candidate_queue_writer_review_inventory_accepted"] @@ -5646,7 +5677,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5656,7 +5687,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_inventory" assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_inventory_accepted"] @@ -5833,7 +5864,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr ) assert ( get_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5843,7 +5874,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_inventory" assert ( post_data["phase"] - == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_inventory_accepted"] @@ -5864,11 +5895,265 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr assert post_data["api_opens_database_connection"] is False +def test_mcp_fetch_candidate_queue_writer_review_decision_preview_is_safe_without_payload(): + decision = build_mcp_fetch_candidate_queue_writer_review_decision_preview( + phase="phase-test" + ) + + assert decision["mode"] == ( + "mcp_fetch_candidate_queue_writer_review_decision_preview" + ) + assert decision["phase"] == "phase-test" + assert ( + decision["mcp_fetch_candidate_queue_writer_review_decision_accepted"] + is False + ) + assert decision["candidate_queue_writer_review_decision_ready"] is False + assert decision["ready_for_candidate_queue_review_decision_approval"] is False + assert decision["ready_for_api_review_state_update"] is False + assert decision["ready_for_api_database_write"] is False + assert decision["api_executes_cli"] is False + assert decision["api_reads_approval_token"] is False + assert decision["api_opens_database_connection"] is False + assert decision["api_writes_database"] is False + assert decision["api_updates_review_state"] is False + assert decision["api_writes_decision_record"] is False + assert decision["decision_record_written"] is False + assert decision["candidate_review_state_updated"] is False + assert decision["scheduler_attached"] is False + assert ( + "candidate_queue_review_inventory_payload_or_result_received" + in decision["blocked_reasons"] + ) + assert "candidate_queue_review_decision_payload_received" in decision[ + "blocked_reasons" + ] + assert ( + "operator_review_decision" + in decision["sample_writer_review_decision_package"] + ) + + +def test_mcp_fetch_candidate_queue_writer_review_decision_accepts_sample_decision(): + sample = build_mcp_fetch_candidate_queue_writer_review_decision_preview()[ + "sample_writer_review_decision_package" + ] + decision = build_mcp_fetch_candidate_queue_writer_review_decision_preview( + writer_review_inventory_package=sample["writer_review_inventory_package"], + writer_review_inventory_result=sample["writer_review_inventory_result"], + operator_review_decision=sample["operator_review_decision"], + phase="phase-test", + ) + + assert decision["mode"] == "mcp_fetch_candidate_queue_writer_review_decision" + assert decision["phase"] == "phase-test" + assert ( + decision["mcp_fetch_candidate_queue_writer_review_decision_accepted"] + is True + ) + assert decision["writer_review_inventory_accepted"] is True + assert decision["candidate_queue_writer_review_decision_ready"] is True + assert decision["ready_for_candidate_queue_review_decision_approval"] is True + assert decision["ready_for_candidate_queue_review_state_writer"] is False + assert decision["ready_for_api_review_state_update"] is False + assert decision["ready_for_api_database_write"] is False + assert decision["blocked_reasons"] == [] + assert decision["passed_gate_count"] == decision["gate_count"] + inventory = decision["writer_review_inventory_summary"] + summary = decision["operator_review_decision_summary"] + assert summary["target_table"] == "market_alert_review_queue" + assert summary["review_inventory_id"] == inventory["review_inventory_id"] + assert summary["handoff_id"] == inventory["handoff_id"] + assert summary["inventory_review_id"] == inventory["inventory_review_id"] + assert summary["run_package_id"] == inventory["run_package_id"] + assert summary["receipt_id"] == inventory["receipt_id"] + assert summary["expected_decision_row_count"] == inventory["found_row_count"] + assert summary["decision_row_count"] == inventory["found_row_count"] + assert len(summary["expected_dedupe_keys"]) == inventory["dedupe_key_count"] + assert summary["decision_scope"] == "candidate_queue_review_decision" + assert summary["decision_mode"] == "human_review_only" + assert all( + row["current_review_state"] == "needs_review" + for row in decision["decision_rows"] + ) + assert all( + row["proposed_review_decision"] + in { + "matched", + "low_score", + "identity_veto", + "unit_comparable", + "fresh_search_required", + "deferred", + } + for row in decision["decision_rows"] + ) + assert summary["secret_or_token_submitted_to_api"] is False + assert decision["network_request_allowed"] is False + assert decision["api_executes_cli"] is False + assert decision["api_reads_approval_token"] is False + assert decision["api_writes_file"] is False + assert decision["api_writes_database"] is False + assert decision["api_updates_review_state"] is False + assert decision["api_writes_decision_record"] is False + assert decision["candidate_queue_persisted"] is False + assert decision["candidate_review_state_updated"] is False + assert decision["database_write_executed"] is False + assert decision["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_review_decision_blocks_unsafe_decision(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_review_decision_preview()[ + "sample_writer_review_decision_package" + ] + ) + ) + decision_payload = sample["operator_review_decision"] + decision_payload["review_inventory_id"] = "wrong-inventory" + decision_payload["handoff_id"] = "wrong-handoff" + decision_payload["target_table"] = "market_campaign_products" + decision_payload["expected_decision_row_count"] = 999 + decision_payload["decision_row_count"] = 999 + decision_payload["decision_scope"] = "auto_review_state_update" + decision_payload["approval_token"] = TEST_APPROVAL_TOKEN + decision_payload["api_execution_allowed"] = True + decision_payload["real_write_allowed_by_api"] = True + decision_payload["api_candidate_review_allowed"] = True + decision_payload["api_updates_review_state"] = True + decision_payload["api_writes_match_result"] = True + decision_payload["review_state_update_executed"] = True + decision_payload["decision_rows"][0]["current_review_state"] = "confirmed" + decision_payload["decision_rows"][0]["proposed_review_decision"] = "auto_confirmed" + decision_payload["decision_rows"][0]["decision_notes"] = "" + decision_payload["decision_rows"][0]["evidence_ref"] = "/tmp/unsafe.json" + decision_payload["decision_rows"][0]["false_positive_guard_passed"] = False + decision_payload["operator_confirmations"]["human_decision_only"] = False + decision_payload["operator_confirmations"][ + "no_api_review_state_update" + ] = False + + decision = build_mcp_fetch_candidate_queue_writer_review_decision_preview( + writer_review_inventory_package=sample["writer_review_inventory_package"], + writer_review_inventory_result=sample["writer_review_inventory_result"], + operator_review_decision=decision_payload, + ) + + assert ( + decision["mcp_fetch_candidate_queue_writer_review_decision_accepted"] + is False + ) + assert decision["writer_review_inventory_accepted"] is True + assert "candidate_queue_review_decision_identity_matches_inventory" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_target_table_safe" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_scope_safe" in decision["blocked_reasons"] + assert "candidate_queue_review_decision_row_count_matches_inventory" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_rows_still_needs_review" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_values_allowed" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_row_evidence_complete" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_operator_boundaries_confirmed" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_no_api_execution_or_real_write" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_no_secret_or_token_key" in decision[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_side_effect_free" in decision[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + decision, + ensure_ascii=False, + sort_keys=True, + ) + assert decision["api_executes_cli"] is False + assert decision["api_reads_approval_token"] is False + assert decision["api_writes_database"] is False + assert decision["api_updates_review_state"] is False + assert decision["api_writes_decision_record"] is False + assert decision["candidate_review_state_updated"] is False + assert decision["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_review_decision_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_review_decision_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision", + json={"writer_review_decision_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == ( + "mcp_fetch_candidate_queue_writer_review_decision_preview" + ) + assert ( + get_data["phase"] + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_updates_review_state"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_decision" + assert ( + post_data["phase"] + == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + ) + assert ( + post_data["mcp_fetch_candidate_queue_writer_review_decision_accepted"] + is True + ) + assert post_data["ready_for_candidate_queue_review_decision_approval"] is True + assert post_data["ready_for_api_review_state_update"] is False + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["api_updates_review_state"] is False + assert post_data["api_writes_decision_record"] is False + assert post_data["decision_record_written"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["candidate_review_state_updated"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -5916,7 +6201,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -5927,7 +6212,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert acceptance["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -5969,7 +6254,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -5981,7 +6266,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -6092,7 +6377,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -6131,7 +6416,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -6193,7 +6478,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -6273,7 +6558,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -6337,7 +6622,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -6396,7 +6681,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert queue_draft["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -6470,7 +6755,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -6533,7 +6818,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert approval["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -6611,7 +6896,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -6674,7 +6959,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert transaction["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -6754,7 +7039,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -12465,7 +12750,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -12540,7 +12825,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -12812,7 +13097,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -13100,7 +13385,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -13410,7 +13695,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -13713,7 +13998,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -13972,7 +14257,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -14245,7 +14530,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -14493,7 +14778,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -14723,7 +15008,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -14960,7 +15245,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -15202,7 +15487,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -15478,7 +15763,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -15755,7 +16040,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -16034,7 +16319,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -16363,7 +16648,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -16625,7 +16910,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -16889,7 +17174,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -17159,7 +17444,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -17447,7 +17732,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -17734,7 +18019,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -17820,7 +18105,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -17877,7 +18162,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -17966,7 +18251,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -18020,7 +18305,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -18076,7 +18361,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -18142,7 +18427,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -18444,7 +18729,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -18492,7 +18777,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -18541,7 +18826,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -18599,7 +18884,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -18665,7 +18950,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -18736,7 +19021,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -18812,7 +19097,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -18894,7 +19179,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -18980,7 +19265,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -19063,7 +19348,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -19146,7 +19431,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -19232,7 +19517,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -19323,7 +19608,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -19433,7 +19718,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -19519,7 +19804,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -19576,7 +19861,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -19629,7 +19914,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -19682,7 +19967,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -19743,7 +20028,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -19812,7 +20097,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -19884,7 +20169,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -19957,7 +20242,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -20028,7 +20313,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -20093,7 +20378,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -20164,7 +20449,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -20237,7 +20522,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -20314,7 +20599,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -20391,7 +20676,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -20468,7 +20753,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -20542,7 +20827,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -20621,7 +20906,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -20708,7 +20993,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -20789,7 +21074,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -20871,7 +21156,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -20954,7 +21239,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -20979,7 +21264,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -21017,7 +21302,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -21028,7 +21313,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -21064,7 +21349,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -21075,7 +21360,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -21116,7 +21401,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -21127,7 +21412,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -21175,7 +21460,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -21187,7 +21472,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -21233,7 +21518,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -21246,7 +21531,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -21331,7 +21616,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -21409,7 +21694,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -21424,7 +21709,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert readiness["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -21877,6 +22162,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_review_decision_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -22268,6 +22559,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/mcp_fetch_candidate_queue_writer_review_inventory" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision" + in readiness["production_smoke_targets"] + ) assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -26309,7 +26604,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert drill["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -26424,7 +26719,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -26436,7 +26731,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -26551,7 +26846,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -26564,7 +26859,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert smoke["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -26626,7 +26921,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -26639,7 +26934,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert inventory["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -26783,7 +27078,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -27019,7 +27314,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -27048,7 +27343,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_136_market_intel_mcp_fetch_candidate_queue_writer_review_inventory" + assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False