diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 82a1b27..ca38ca6 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.299 補市場情報 candidate queue review AI summary persistence run closeout：新增 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_closeout` 與 UI 按鈕，在 receipt 通過後收尾 metadata_json persistence gate，確認 closeout artifact、操作員確認與後續 Telegram dispatch 必須另開 gate；API/UI 仍不讀 approval token、不執行 CLI、不連 DB、不寫 `metadata_json`、不派送 Telegram、不掛 scheduler。 - V10.298 補市場情報 candidate queue review AI summary persistence run receipt：新增 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_receipt` 與 UI 按鈕，審核操作員貼回的 metadata_json CLI writer output、post-write smoke、dedupe key、summary payload hash、artifact path 與 token 外洩風險；API/UI 仍不讀 approval token、不執行 CLI、不連 DB、不寫 `metadata_json`、不派送 Telegram、不掛 scheduler。 - V10.297 將 PChome 單位價覆核隊列接回商品看板第一屏：KPI 顯示待處理/需單位價覆核數，焦點區列出候選 PChome 商品、候選價、match score 與人工動作；新增 `filter=pchome_review` 的比價覆核隊列，讓使用者可直接進入待處理 SKU，不再只在 daily/growth/PPT 摘要看到統計。 - V10.296 補核心 MOMO/PChome 比價第三層語意與覆核閉環：同核心商品但買送、套組、件數不同且只有單一基礎規格時標記 `unit_comparable`，只寫入 `competitor_match_attempts`；商品看板、daily/growth 報表、OpenClaw/PPT 摘要共用 `competitor_intel_repository` 的覆核隊列，顯示「需單位價比較」、候選商品、候選 PChome 價格與單位價換算證據；多容量/多品項套組仍保持不可比較，避免把不同販售組合直接寫進正式總價差。 diff --git a/config.py b/config.py index f8aadb0..9c0008b 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.298" +SYSTEM_VERSION = "V10.299" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index d31551e..c06f770 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -214,6 +214,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review AI summary persistence run package：`services.market_intel.candidate_queue_review_ai_summary_persistence_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package` 在 writer preflight 後整理 payload manifest、CLI command bundle、required artifacts、operator signoff 與 rollback plan。此 run package 不開 DB、不執行 SQL、不寫 run package、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須另開 operator readiness、CLI receipt、post-write smoke 與 closeout。 - 2026-05-20 追加 candidate queue review AI summary persistence run readiness：`services.market_intel.candidate_queue_review_ai_summary_persistence_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness` 在 run package 後檢查操作員 artifact path、metadata_json backup、read-only preflight、shell-only token acknowledgement 與 post-write smoke 計畫。此 readiness 不開 DB、不執行 SQL、不寫 readiness artifact、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須由後續人工 CLI 與 receipt/post-write smoke gate 驗收。 - 2026-05-20 追加 candidate queue review AI summary persistence run receipt：`services.market_intel.candidate_queue_review_ai_summary_persistence_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_receipt` 審核 metadata_json CLI 寫入後的 writer output、post-write smoke、dedupe key、summary payload hash、artifact path 與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 `metadata_json`、不更新 `review_state`、不派送 Telegram、不 commit、不掛 scheduler。 +- 2026-05-20 追加 candidate queue review AI summary persistence run closeout：`services.market_intel.candidate_queue_review_ai_summary_persistence_run_closeout` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_closeout` 在 receipt 通過後整理 closeout gate、操作員 closeout artifact、Telegram dispatch separate-gate 確認與 promotion 摘要。此 closeout 只允許放行到後續 Telegram dispatch gate；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 `metadata_json`、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/market_intel_review_post_ai_routes.py b/routes/market_intel_review_post_ai_routes.py index 2151796..6caba05 100644 --- a/routes/market_intel_review_post_ai_routes.py +++ b/routes/market_intel_review_post_ai_routes.py @@ -19,6 +19,9 @@ from services.market_intel.candidate_queue_review_ai_summary_persistence_run_rea from services.market_intel.candidate_queue_review_ai_summary_persistence_run_receipt import ( build_candidate_queue_review_ai_summary_persistence_run_receipt, ) +from services.market_intel.candidate_queue_review_ai_summary_persistence_run_closeout import ( + build_candidate_queue_review_ai_summary_persistence_run_closeout, +) def _build_ai_summary_persistence_run_readiness( @@ -58,6 +61,39 @@ def _build_ai_summary_persistence_run_readiness( ) +def _build_ai_summary_persistence_run_receipt( + *, + service, + sample_result, + operator_evidence, + writer_output, + smoke_result, + payload_error, + limit, + execute_requested, + apply_real_write, +): + run_readiness = _build_ai_summary_persistence_run_readiness( + service=service, + sample_result=sample_result, + operator_evidence=operator_evidence, + writer_output=writer_output, + smoke_result=smoke_result, + payload_error=payload_error, + limit=limit, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + ) + return build_candidate_queue_review_ai_summary_persistence_run_receipt( + ai_summary_persistence_run_readiness=run_readiness, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + ) + + @market_intel_review_bp.route( "/api/market_intel/manual_sample_review/" "candidate_queue_review_ai_summary_persistence_run_readiness", @@ -99,7 +135,7 @@ def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( _extract_run_payload() ) - run_readiness = _build_ai_summary_persistence_run_readiness( + data = _build_ai_summary_persistence_run_receipt( service=service, sample_result=sample_result, operator_evidence=operator_evidence, @@ -110,11 +146,37 @@ def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run execute_requested=execute_requested, apply_real_write=apply_real_write, ) - data = build_candidate_queue_review_ai_summary_persistence_run_receipt( - ai_summary_persistence_run_readiness=run_readiness, + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_closeout", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_closeout(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + apply_real_write = request.args.get("apply_real_write", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + run_receipt = _build_ai_summary_persistence_run_receipt( + service=service, + sample_result=sample_result, operator_evidence=operator_evidence, writer_output=writer_output, - postwrite_smoke_result=smoke_result, + smoke_result=smoke_result, + payload_error=payload_error, + limit=limit, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + ) + data = build_candidate_queue_review_ai_summary_persistence_run_closeout( + run_receipt=run_receipt, + operator_evidence=operator_evidence, execute_requested=execute_requested, apply_real_write=apply_real_write, ) diff --git a/services/market_intel/candidate_queue_review_ai_summary_persistence_run_closeout.py b/services/market_intel/candidate_queue_review_ai_summary_persistence_run_closeout.py new file mode 100644 index 0000000..0db33e2 --- /dev/null +++ b/services/market_intel/candidate_queue_review_ai_summary_persistence_run_closeout.py @@ -0,0 +1,431 @@ +"""候選審核 queue AI summary persistence operator run closeout preview。 + +本模組只在 metadata_json persistence receipt review 之後整理 closeout gate； +不回吐原始 receipt、不讀 approval token、不執行 CLI、不開 DB connection、不寫 +metadata_json、不派送 Telegram、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +REQUIRED_RECEIPT_BOUNDARIES = { + "do_not_execute_summary_persistence_writer_from_receipt_api", + "do_not_read_approval_token_from_summary_persistence_receipt_api", + "do_not_echo_operator_receipt_payload", + "do_not_create_summary_persistence_receipt_artifact_from_api", + "do_not_open_database_connection_from_summary_persistence_receipt", + "do_not_write_metadata_json_from_summary_persistence_receipt", + "do_not_update_review_state_from_summary_persistence_receipt", + "do_not_commit_summary_persistence_receipt", + "do_not_dispatch_telegram_from_summary_persistence_receipt", + "do_not_attach_scheduler_from_summary_persistence_receipt", +} +TARGET_TABLE = "market_alert_review_queue" +TARGET_COLUMN = "metadata_json" +SUMMARY_METADATA_KEY = "ai_summary_review" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _receipt_summary(run_receipt): + run_receipt = _as_dict(run_receipt) + writer = _as_dict(run_receipt.get("writer_output_summary")) + smoke = _as_dict(run_receipt.get("postwrite_smoke_summary")) + expected_keys = _as_list(run_receipt.get("expected_dedupe_keys")) + blocked_reasons = _as_list(run_receipt.get("blocked_reasons")) + safe_boundaries = set(str(item) for item in _as_list(run_receipt.get("safe_boundaries"))) + missing_boundaries = sorted(REQUIRED_RECEIPT_BOUNDARIES - safe_boundaries) + + return { + "provided": bool(run_receipt), + "mode": run_receipt.get("mode"), + "target_operation": run_receipt.get("target_operation"), + "receipt_passed": bool( + run_receipt.get("run_receipt_passed") + or run_receipt.get("summary_persistence_run_receipt_passed") + ), + "ready_for_summary_persistence_closeout": bool( + run_receipt.get("ready_for_summary_persistence_closeout") + ), + "ready_for_next_manual_phase": bool( + run_receipt.get("ready_for_next_manual_phase") + ), + "expected_dedupe_key_count": len(expected_keys), + "expected_summary_payload_hash": run_receipt.get( + "expected_summary_payload_hash" + ), + "blocked_count": len(blocked_reasons), + "writer_mode": writer.get("mode"), + "writer_metadata_json_update_executed": bool( + writer.get("metadata_json_update_executed") + ), + "writer_dedupe_keys_match_expected": bool( + writer.get("dedupe_keys_match_expected") + ), + "writer_summary_hash_matches_expected": bool( + writer.get("summary_payload_hash_matches_expected") + ), + "postwrite_smoke_passed": bool(smoke.get("postwrite_smoke_passed")), + "postwrite_smoke_read_only": bool(smoke.get("read_only_query_executed")), + "postwrite_smoke_metadata_json_verified": bool( + smoke.get("metadata_json_update_verified") + ), + "postwrite_smoke_dedupe_keys_match_expected": bool( + smoke.get("dedupe_keys_match_expected") + ), + "postwrite_smoke_summary_hash_matches_expected": bool( + smoke.get("summary_payload_hash_matches_expected") + ), + "safe_boundaries_complete": not missing_boundaries, + "missing_safe_boundaries": missing_boundaries, + "ready_for_api_database_write": bool( + run_receipt.get("ready_for_api_database_write") + ), + "ready_for_telegram_dispatch": bool( + run_receipt.get("ready_for_telegram_dispatch") + ), + "ready_for_scheduler_attach": bool(run_receipt.get("ready_for_scheduler_attach")), + "api_executes_cli": bool(run_receipt.get("api_executes_cli")), + "api_executes_llm": bool(run_receipt.get("api_executes_llm")), + "api_reads_approval_token": bool(run_receipt.get("api_reads_approval_token")), + "api_writes_file": bool(run_receipt.get("api_writes_file")), + "api_writes_database": bool(run_receipt.get("api_writes_database")), + "api_updates_review_state": bool(run_receipt.get("api_updates_review_state")), + "summary_persistence_record_written": bool( + run_receipt.get("summary_persistence_record_written") + ), + "metadata_patch_written": bool(run_receipt.get("metadata_patch_written")), + "llm_call_executed": bool(run_receipt.get("llm_call_executed")), + "telegram_dispatched": bool(run_receipt.get("telegram_dispatched")), + "database_connection_opened": bool( + run_receipt.get("database_connection_opened") + ), + "database_write_executed": bool(run_receipt.get("database_write_executed")), + "database_commit_executed": bool(run_receipt.get("database_commit_executed")), + "review_state_update_executed": bool( + run_receipt.get("review_state_update_executed") + ), + "scheduler_attached": bool(run_receipt.get("scheduler_attached")), + } + + +def _operator_closeout_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "closeout_artifact_path_recorded": _has_text( + operator_evidence.get("ai_summary_persistence_closeout_artifact_path") + or operator_evidence.get("summary_persistence_closeout_artifact_path") + or operator_evidence.get("closeout_artifact_path") + ), + "operator_confirmed_summary_persistence_closeout": bool( + operator_evidence.get("operator_confirmed_summary_persistence_closeout") + or operator_evidence.get("operator_confirmed_ai_summary_persistence_closeout") + ), + "operator_confirmed_telegram_dispatch_requires_separate_gate": bool( + operator_evidence.get( + "operator_confirmed_telegram_dispatch_requires_separate_gate" + ) + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "operator_confirmed_no_telegram_dispatch": bool( + operator_evidence.get("operator_confirmed_no_telegram_dispatch") + ), + "closeout_notes_recorded": _has_text(operator_evidence.get("closeout_notes")), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _closeout_gates(receipt_summary, closeout_summary, apply_real_write): + return [ + { + "key": "receipt_preview_provided", + "label": "必須提供上一階段 AI summary persistence receipt preview 摘要", + "passed": bool( + receipt_summary["provided"] + and receipt_summary["mode"] + == "candidate_queue_review_ai_summary_persistence_run_receipt_preview" + ), + }, + { + "key": "receipt_target_operation_metadata_json", + "label": "receipt 必須鎖定 metadata_json.ai_summary_review 持久化", + "passed": bool( + receipt_summary["target_operation"] + == "persist_ai_summary_metadata_json" + ), + }, + { + "key": "receipt_passed", + "label": "receipt 必須已通過 writer output 與 post-write smoke 審核", + "passed": receipt_summary["receipt_passed"], + }, + { + "key": "receipt_ready_for_summary_persistence_closeout", + "label": "receipt 必須只放行到 summary persistence closeout", + "passed": bool( + receipt_summary["ready_for_summary_persistence_closeout"] + and receipt_summary["ready_for_next_manual_phase"] + ), + }, + { + "key": "receipt_expected_dedupe_keys_present", + "label": "receipt 必須保有 run package dedupe key 摘要", + "passed": bool(receipt_summary["expected_dedupe_key_count"]), + }, + { + "key": "writer_and_smoke_metadata_json_confirmed", + "label": "writer output 與 smoke 必須確認 metadata_json.ai_summary_review 且 hash/key 一致", + "passed": bool( + receipt_summary["writer_metadata_json_update_executed"] + and receipt_summary["writer_dedupe_keys_match_expected"] + and receipt_summary["writer_summary_hash_matches_expected"] + and receipt_summary["postwrite_smoke_read_only"] + and receipt_summary["postwrite_smoke_passed"] + and receipt_summary["postwrite_smoke_metadata_json_verified"] + and receipt_summary["postwrite_smoke_dedupe_keys_match_expected"] + and receipt_summary["postwrite_smoke_summary_hash_matches_expected"] + ), + }, + { + "key": "receipt_safe_boundaries_complete", + "label": "receipt 必須保留不讀 token、不執行 CLI、不寫 metadata_json 的安全邊界", + "passed": receipt_summary["safe_boundaries_complete"], + }, + { + "key": "receipt_no_api_database_write", + "label": "closeout 前不得出現 API/UI DB 寫入或 commit", + "passed": bool( + not receipt_summary["ready_for_api_database_write"] + and not receipt_summary["api_writes_database"] + and not receipt_summary["database_write_executed"] + and not receipt_summary["database_commit_executed"] + ), + }, + { + "key": "receipt_no_api_metadata_or_review_state_write", + "label": "closeout 前不得由 API/UI 寫 metadata_json 或更新 review_state", + "passed": bool( + not receipt_summary["summary_persistence_record_written"] + and not receipt_summary["metadata_patch_written"] + and not receipt_summary["api_updates_review_state"] + and not receipt_summary["review_state_update_executed"] + ), + }, + { + "key": "receipt_no_scheduler_cli_llm_or_telegram", + "label": "closeout 前不得從 API/UI 執行 CLI、LLM、Telegram 或掛 scheduler", + "passed": bool( + not receipt_summary["ready_for_telegram_dispatch"] + and not receipt_summary["ready_for_scheduler_attach"] + and not receipt_summary["api_executes_cli"] + and not receipt_summary["api_executes_llm"] + and not receipt_summary["llm_call_executed"] + and not receipt_summary["telegram_dispatched"] + and not receipt_summary["scheduler_attached"] + ), + }, + { + "key": "receipt_no_token_or_file_side_effect", + "label": "closeout 前 API/UI 不得讀 token 或寫 artifact 檔案", + "passed": bool( + not receipt_summary["api_reads_approval_token"] + and not receipt_summary["api_writes_file"] + ), + }, + { + "key": "closeout_artifact_path_recorded", + "label": "操作員需記錄 summary persistence closeout artifact 路徑", + "passed": closeout_summary["closeout_artifact_path_recorded"], + }, + { + "key": "operator_confirmed_summary_persistence_closeout", + "label": "操作員確認 closeout 後才可進下一個 Telegram dispatch gate", + "passed": closeout_summary[ + "operator_confirmed_summary_persistence_closeout" + ], + }, + { + "key": "operator_confirmed_telegram_dispatch_requires_separate_gate", + "label": "操作員確認 Telegram dispatch 必須另開 gate，不由 closeout 發送", + "passed": closeout_summary[ + "operator_confirmed_telegram_dispatch_requires_separate_gate" + ], + }, + { + "key": "operator_confirmed_no_scheduler_attach", + "label": "操作員確認本階段不掛 scheduler", + "passed": closeout_summary["operator_confirmed_no_scheduler_attach"], + }, + { + "key": "operator_confirmed_no_api_db_write", + "label": "操作員確認本階段不由 API/UI 寫 DB", + "passed": closeout_summary["operator_confirmed_no_api_db_write"], + }, + { + "key": "operator_confirmed_no_telegram_dispatch", + "label": "操作員確認本階段不派送 Telegram", + "passed": closeout_summary["operator_confirmed_no_telegram_dispatch"], + }, + { + "key": "closeout_no_approval_token_submitted_to_api", + "label": "closeout payload 不得包含一次性 approval token key", + "passed": not closeout_summary["approval_token_submitted_to_api"], + }, + { + "key": "closeout_apply_real_write_not_requested_from_api", + "label": "API/UI closeout 不接受 apply_real_write", + "passed": not apply_real_write, + }, + ] + + +def build_candidate_queue_review_ai_summary_persistence_run_closeout( + *, + run_receipt, + operator_evidence=None, + execute_requested=False, + apply_real_write=False, +): + """建立 AI summary persistence CLI 寫入後 closeout gate；不執行副作用。""" + receipt_summary = _receipt_summary(run_receipt) + closeout_summary = _operator_closeout_summary(operator_evidence) + gates = _closeout_gates( + receipt_summary, + closeout_summary, + bool(apply_real_write), + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + closeout_passed = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_ai_summary_persistence_run_closeout_preview", + "target_table": TARGET_TABLE, + "target_column": TARGET_COLUMN, + "target_json_path": [SUMMARY_METADATA_KEY], + "target_operation": "persist_ai_summary_metadata_json", + "execute_requested": bool(execute_requested), + "apply_real_write_requested": bool(apply_real_write), + "closeout_reviewed": True, + "closeout_passed": closeout_passed, + "summary_persistence_closeout_passed": closeout_passed, + "ready_for_next_manual_phase": closeout_passed, + "ready_for_summary_persistence_telegram_dispatch_gate": closeout_passed, + "ready_for_summary_persistence_cli_run": False, + "ready_for_real_write": False, + "ready_for_api_database_write": False, + "ready_for_telegram_dispatch": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_executes_llm": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "summary_persistence_closeout_file_written": False, + "closeout_file_written": False, + "summary_file_written": False, + "summary_record_written": False, + "summary_persistence_record_written": False, + "metadata_patch_written": False, + "transaction_file_written": False, + "ai_summary_generated": False, + "llm_call_executed": False, + "ollama_call_executed": False, + "gemini_call_executed": False, + "telegram_dispatched": False, + "review_state_update_executed": False, + "read_only_query_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "statement_count": receipt_summary["expected_dedupe_key_count"], + "blocked_reasons": blocked_reasons, + "gates": gates, + "receipt_summary": receipt_summary, + "operator_closeout_summary": closeout_summary, + "promotion_gate": { + "allowed": closeout_passed, + "next_manual_phase": "summary_persistence_telegram_dispatch_gate", + "requires_real_db_write": False, + "requires_scheduler_attach": False, + "requires_operator_approval": True, + "telegram_dispatch_requires_separate_gate": True, + }, + "next_operator_steps": [ + "保存 summary persistence closeout artifact 與 receipt 摘要", + "人工確認 metadata_json.ai_summary_review 已可供後續摘要派送 gate 使用", + "另開 Telegram dispatch preflight / run package / receipt gate 後才允許派送", + "若任何 closeout gate 阻擋，停在 receipt 階段並保留 feature flags 關閉", + ], + "safe_boundaries": [ + "do_not_echo_operator_receipt_payload", + "do_not_execute_summary_persistence_writer_from_closeout_api", + "do_not_read_approval_token_from_summary_persistence_closeout_api", + "do_not_write_closeout_artifact_from_summary_persistence_closeout_api", + "do_not_open_database_connection_from_summary_persistence_closeout", + "do_not_write_metadata_json_from_summary_persistence_closeout", + "do_not_update_review_state_from_summary_persistence_closeout", + "do_not_dispatch_telegram_from_summary_persistence_closeout", + "do_not_attach_scheduler_from_summary_persistence_closeout", + "future_telegram_dispatch_must_use_separate_gate", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 77dd710..6a25f23 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -29,6 +29,7 @@ from services.market_intel.candidate_queue_review_ai_summary_persistence_preflig from services.market_intel.candidate_queue_review_ai_summary_persistence_run_package import build_candidate_queue_review_ai_summary_persistence_run_package from services.market_intel.candidate_queue_review_ai_summary_persistence_run_readiness import build_candidate_queue_review_ai_summary_persistence_run_readiness from services.market_intel.candidate_queue_review_ai_summary_persistence_run_receipt import build_candidate_queue_review_ai_summary_persistence_run_receipt +from services.market_intel.candidate_queue_review_ai_summary_persistence_run_closeout import build_candidate_queue_review_ai_summary_persistence_run_closeout from services.market_intel.candidate_queue_review_ai_summary_persistence_transaction import build_candidate_queue_review_ai_summary_persistence_transaction from services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight import build_candidate_queue_review_ai_summary_persistence_writer_preflight from services.market_intel.candidate_queue_review_ai_summary_run_package import build_candidate_queue_review_ai_summary_run_package @@ -56,7 +57,7 @@ BLOCKED_RUN_REVIEW_KEYS = ( "summary_persistence_transaction_file_written", "summary_persistence_writer_preflight_file_written", "summary_persistence_run_package_file_written", - "summary_persistence_run_readiness_file_written", "run_readiness_file_written", "summary_persistence_run_receipt_file_written", "run_receipt_file_written", "receipt_file_written", + "summary_persistence_run_readiness_file_written", "run_readiness_file_written", "summary_persistence_run_receipt_file_written", "run_receipt_file_written", "receipt_file_written", "summary_persistence_closeout_file_written", "closeout_file_written", "summary_persistence_record_written", "metadata_patch_written", "transaction_file_written", @@ -79,7 +80,7 @@ BLOCKED_RUN_REVIEW_KEYS = ( "writes_executed", "would_write_database", ) -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) @@ -242,6 +243,7 @@ def build_deployment_readiness_preview( candidate_queue_review_ai_summary_persistence_run_package = build_candidate_queue_review_ai_summary_persistence_run_package(ai_summary_persistence_writer_preflight=candidate_queue_review_ai_summary_persistence_writer_preflight) candidate_queue_review_ai_summary_persistence_run_readiness = build_candidate_queue_review_ai_summary_persistence_run_readiness(ai_summary_persistence_run_package=candidate_queue_review_ai_summary_persistence_run_package) candidate_queue_review_ai_summary_persistence_run_receipt = build_candidate_queue_review_ai_summary_persistence_run_receipt(ai_summary_persistence_run_readiness=candidate_queue_review_ai_summary_persistence_run_readiness) + candidate_queue_review_ai_summary_persistence_run_closeout = build_candidate_queue_review_ai_summary_persistence_run_closeout(run_receipt=candidate_queue_review_ai_summary_persistence_run_receipt) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -452,82 +454,25 @@ def build_deployment_readiness_preview( and not candidate_queue_writer_run_readiness["database_commit_executed"] and not candidate_queue_writer_run_readiness["scheduler_attached"] ), - "candidate_queue_writer_run_receipt_preview_safe": _run_review_preview_safe( - candidate_queue_writer_run_receipt, - "candidate_queue_writer_run_receipt_preview", - ), - "candidate_queue_writer_run_closeout_preview_safe": _run_review_preview_safe( - candidate_queue_writer_run_closeout, - "candidate_queue_writer_run_closeout_preview", - ), - "candidate_queue_review_handoff_preview_safe": _run_review_preview_safe( - candidate_queue_review_handoff, - "candidate_queue_review_handoff_preview", - ), - "candidate_queue_review_inventory_preview_safe": _run_review_preview_safe( - candidate_queue_review_inventory, - "candidate_queue_review_inventory_preview", - ), - "candidate_queue_review_decision_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision, - "candidate_queue_review_decision_preview", - ), - "candidate_queue_review_decision_approval_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_approval, - "candidate_queue_review_decision_approval_preview", - ), - "candidate_queue_review_decision_transaction_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_transaction, - "candidate_queue_review_decision_transaction_preview", - ), - "candidate_queue_review_decision_writer_preflight_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_preflight, - "candidate_queue_review_decision_writer_preflight_preview", - ), - "candidate_queue_review_decision_writer_postwrite_smoke_planned_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_postwrite_smoke, - "candidate_queue_review_decision_writer_postwrite_smoke_planned", - ), - "candidate_queue_review_decision_writer_operator_drill_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_operator_drill, - "candidate_queue_review_decision_writer_operator_drill_preview", - ), - "candidate_queue_review_decision_writer_run_package_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_run_package, - "candidate_queue_review_decision_writer_run_package_preview", - ), - "candidate_queue_review_decision_writer_run_readiness_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_run_readiness, - "candidate_queue_review_decision_writer_run_readiness_preview", - ), - "candidate_queue_review_decision_writer_run_receipt_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_run_receipt, - "candidate_queue_review_decision_writer_run_receipt_preview", - ), - "candidate_queue_review_decision_writer_run_closeout_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_writer_run_closeout, - "candidate_queue_review_decision_writer_run_closeout_preview", - ), - "candidate_queue_review_decision_post_closeout_inventory_preview_safe": _run_review_preview_safe( - candidate_queue_review_decision_post_closeout_inventory, - "candidate_queue_review_decision_post_closeout_inventory_preview", - ), - "candidate_queue_review_completion_archive_preview_safe": _run_review_preview_safe( - candidate_queue_review_completion_archive, - "candidate_queue_review_completion_archive_preview", - ), - "candidate_queue_review_archive_summary_preview_safe": _run_review_preview_safe( - candidate_queue_review_archive_summary, - "candidate_queue_review_archive_summary_preview", - ), - "candidate_queue_review_ai_summary_preflight_preview_safe": _run_review_preview_safe( - candidate_queue_review_ai_summary_preflight, - "candidate_queue_review_ai_summary_preflight_preview", - ), - "candidate_queue_review_ai_summary_run_package_preview_safe": _run_review_preview_safe( - candidate_queue_review_ai_summary_run_package, - "candidate_queue_review_ai_summary_run_package_preview", - ), + "candidate_queue_writer_run_receipt_preview_safe": _run_review_preview_safe(candidate_queue_writer_run_receipt, "candidate_queue_writer_run_receipt_preview"), + "candidate_queue_writer_run_closeout_preview_safe": _run_review_preview_safe(candidate_queue_writer_run_closeout, "candidate_queue_writer_run_closeout_preview"), + "candidate_queue_review_handoff_preview_safe": _run_review_preview_safe(candidate_queue_review_handoff, "candidate_queue_review_handoff_preview"), + "candidate_queue_review_inventory_preview_safe": _run_review_preview_safe(candidate_queue_review_inventory, "candidate_queue_review_inventory_preview"), + "candidate_queue_review_decision_preview_safe": _run_review_preview_safe(candidate_queue_review_decision, "candidate_queue_review_decision_preview"), + "candidate_queue_review_decision_approval_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_approval, "candidate_queue_review_decision_approval_preview"), + "candidate_queue_review_decision_transaction_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_transaction, "candidate_queue_review_decision_transaction_preview"), + "candidate_queue_review_decision_writer_preflight_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_preflight, "candidate_queue_review_decision_writer_preflight_preview"), + "candidate_queue_review_decision_writer_postwrite_smoke_planned_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_postwrite_smoke, "candidate_queue_review_decision_writer_postwrite_smoke_planned"), + "candidate_queue_review_decision_writer_operator_drill_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_operator_drill, "candidate_queue_review_decision_writer_operator_drill_preview"), + "candidate_queue_review_decision_writer_run_package_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_run_package, "candidate_queue_review_decision_writer_run_package_preview"), + "candidate_queue_review_decision_writer_run_readiness_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_run_readiness, "candidate_queue_review_decision_writer_run_readiness_preview"), + "candidate_queue_review_decision_writer_run_receipt_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_run_receipt, "candidate_queue_review_decision_writer_run_receipt_preview"), + "candidate_queue_review_decision_writer_run_closeout_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_writer_run_closeout, "candidate_queue_review_decision_writer_run_closeout_preview"), + "candidate_queue_review_decision_post_closeout_inventory_preview_safe": _run_review_preview_safe(candidate_queue_review_decision_post_closeout_inventory, "candidate_queue_review_decision_post_closeout_inventory_preview"), + "candidate_queue_review_completion_archive_preview_safe": _run_review_preview_safe(candidate_queue_review_completion_archive, "candidate_queue_review_completion_archive_preview"), + "candidate_queue_review_archive_summary_preview_safe": _run_review_preview_safe(candidate_queue_review_archive_summary, "candidate_queue_review_archive_summary_preview"), + "candidate_queue_review_ai_summary_preflight_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_preflight, "candidate_queue_review_ai_summary_preflight_preview"), + "candidate_queue_review_ai_summary_run_package_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_run_package, "candidate_queue_review_ai_summary_run_package_preview"), "candidate_queue_review_ai_summary_output_receipt_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_output_receipt, "candidate_queue_review_ai_summary_output_receipt_preview"), "candidate_queue_review_ai_summary_persistence_preflight_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_preflight, "candidate_queue_review_ai_summary_persistence_preflight_preview"), "candidate_queue_review_ai_summary_persistence_transaction_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_transaction, "candidate_queue_review_ai_summary_persistence_transaction_preview"), @@ -535,6 +480,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_ai_summary_persistence_run_package_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_run_package, "candidate_queue_review_ai_summary_persistence_run_package_preview"), "candidate_queue_review_ai_summary_persistence_run_readiness_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_run_readiness, "candidate_queue_review_ai_summary_persistence_run_readiness_preview"), "candidate_queue_review_ai_summary_persistence_run_receipt_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_run_receipt, "candidate_queue_review_ai_summary_persistence_run_receipt_preview"), + "candidate_queue_review_ai_summary_persistence_run_closeout_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_run_closeout, "candidate_queue_review_ai_summary_persistence_run_closeout_preview"), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -790,6 +736,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_ai_summary_persistence_run_package": candidate_queue_review_ai_summary_persistence_run_package, "candidate_queue_review_ai_summary_persistence_run_readiness": candidate_queue_review_ai_summary_persistence_run_readiness, "candidate_queue_review_ai_summary_persistence_run_receipt": candidate_queue_review_ai_summary_persistence_run_receipt, + "candidate_queue_review_ai_summary_persistence_run_closeout": candidate_queue_review_ai_summary_persistence_run_closeout, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 117edad..876c40e 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" +MARKET_INTEL_PHASE = "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 1fd6f09..8e3d5e1 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -703,6 +703,9 @@ + @@ -1065,6 +1068,7 @@ const sampleCandidateQueueReviewAiSummaryPersistenceRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-package]') : null; const sampleCandidateQueueReviewAiSummaryPersistenceRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-readiness]') : null; const sampleCandidateQueueReviewAiSummaryPersistenceRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-receipt]') : null; + const sampleCandidateQueueReviewAiSummaryPersistenceRunCloseout = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-closeout]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1104,6 +1108,7 @@ const sampleCandidateQueueReviewAiSummaryPersistenceRunPackageEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_package') }}"; const sampleCandidateQueueReviewAiSummaryPersistenceRunReadinessEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_readiness') }}"; const sampleCandidateQueueReviewAiSummaryPersistenceRunReceiptEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_receipt') }}"; + const sampleCandidateQueueReviewAiSummaryPersistenceRunCloseoutEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_closeout') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -5818,6 +5823,144 @@ } }; + const renderCandidateQueueReviewAiSummaryPersistenceRunCloseout = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const receipt = data.receipt_summary || {}; + const operator = data.operator_closeout_summary || {}; + const promotion = data.promotion_gate || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `closeout=${data.closeout_passed ? 'passed' : 'blocked'}`, + `telegram_gate=${data.ready_for_summary_persistence_telegram_dispatch_gate ? 'ready' : 'blocked'}`, + `statements=${data.statement_count || 0}`, + `db=${data.database_write_executed ? 'written' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只收尾 AI summary persistence receipt；後續 Telegram dispatch 必須另開 gate。API/UI 不讀 token、不執行 CLI、不開 DB、不寫 metadata_json、不派送 Telegram。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

CLOSEOUT GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 closeout gate。
' + }
+
+
+

RECEIPT SUMMARY

+
+ ${[ + ['receipt_passed', receipt.receipt_passed], + ['closeout_ready', receipt.ready_for_summary_persistence_closeout], + ['expected_keys', receipt.expected_dedupe_key_count || 0], + ['writer_metadata', receipt.writer_metadata_json_update_executed], + ['smoke_verified', receipt.postwrite_smoke_metadata_json_verified], + ['safe_boundaries', receipt.safe_boundaries_complete] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

OPERATOR CLOSEOUT

+
+ ${[ + ['closeout_artifact', operator.closeout_artifact_path_recorded], + ['closeout_confirmed', operator.operator_confirmed_summary_persistence_closeout], + ['telegram_separate_gate', operator.operator_confirmed_telegram_dispatch_requires_separate_gate], + ['no_api_db_write', operator.operator_confirmed_no_api_db_write], + ['no_telegram_dispatch', operator.operator_confirmed_no_telegram_dispatch], + ['token_submitted', operator.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

PROMOTION

+
+ ${[ + ['allowed', promotion.allowed], + ['next_phase', promotion.next_manual_phase || 'blocked'], + ['requires_real_db_write', promotion.requires_real_db_write], + ['requires_scheduler_attach', promotion.requires_scheduler_attach], + ['telegram_separate_gate', promotion.telegram_dispatch_requires_separate_gate] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

NO-SIDE-EFFECTS

+
+ ${[ + ['api_executes_cli', data.api_executes_cli], + ['api_reads_approval_token', data.api_reads_approval_token], + ['api_writes_database', data.api_writes_database], + ['closeout_file_written', data.closeout_file_written], + ['database_connection_opened', data.database_connection_opened], + ['database_write_executed', data.database_write_executed], + ['telegram_dispatched', data.telegram_dispatched], + ['scheduler_attached', data.scheduler_attached] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueReviewAiSummaryPersistenceRunCloseout = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
收尾 queue review AI summary persistence run closeout 中...
'; + try { + const response = await fetch(`${sampleCandidateQueueReviewAiSummaryPersistenceRunCloseoutEndpoint}?execute=false&apply_real_write=false`, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewAiSummaryPersistenceRunCloseout(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review AI summary persistence run closeout 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -7536,6 +7679,9 @@ if (sampleCandidateQueueReviewAiSummaryPersistenceRunReceipt) { sampleCandidateQueueReviewAiSummaryPersistenceRunReceipt.addEventListener('click', loadCandidateQueueReviewAiSummaryPersistenceRunReceipt); } + if (sampleCandidateQueueReviewAiSummaryPersistenceRunCloseout) { + sampleCandidateQueueReviewAiSummaryPersistenceRunCloseout.addEventListener('click', loadCandidateQueueReviewAiSummaryPersistenceRunCloseout); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 9a01ed7..0cf3a00 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -1075,6 +1075,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_receipt" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_run_closeout" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -1155,6 +1159,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-receipt" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-ai-summary-persistence-run-closeout" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -1191,7 +1199,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert bridge["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1349,7 +1357,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert contract["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1482,7 +1490,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1495,7 +1503,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert gate["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1565,7 +1573,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1577,7 +1585,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1625,7 +1633,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1636,7 +1644,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert acceptance["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1678,7 +1686,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1690,7 +1698,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert review["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1801,7 +1809,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1840,7 +1848,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert review["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1902,7 +1910,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1982,7 +1990,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert handoff["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -2046,7 +2054,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -2105,7 +2113,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert queue_draft["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2179,7 +2187,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -2242,7 +2250,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert approval["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2320,7 +2328,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2383,7 +2391,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert transaction["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2463,7 +2471,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -6812,6 +6820,147 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_reviews_cli_o ) +def test_candidate_queue_review_ai_summary_persistence_run_closeout_promotes_telegram_gate_only(): + from services.market_intel.candidate_queue_review_ai_summary_persistence_run_closeout import ( + build_candidate_queue_review_ai_summary_persistence_run_closeout, + ) + + expected_key = "market-alert-review:sample-batch:sku-001" + expected_hash = "f" * 64 + run_receipt = { + "mode": "candidate_queue_review_ai_summary_persistence_run_receipt_preview", + "target_operation": "persist_ai_summary_metadata_json", + "run_receipt_passed": True, + "summary_persistence_run_receipt_passed": True, + "ready_for_summary_persistence_closeout": True, + "ready_for_next_manual_phase": True, + "expected_dedupe_keys": [expected_key], + "expected_summary_payload_hash": expected_hash, + "blocked_reasons": [], + "writer_output_summary": { + "mode": "candidate_queue_review_ai_summary_persistence_writer_cli_executed", + "metadata_json_update_executed": True, + "dedupe_keys_match_expected": True, + "summary_payload_hash_matches_expected": True, + }, + "postwrite_smoke_summary": { + "mode": "candidate_queue_review_ai_summary_persistence_postwrite_smoke_read_only", + "postwrite_smoke_passed": True, + "read_only_query_executed": True, + "metadata_json_update_verified": True, + "dedupe_keys_match_expected": True, + "summary_payload_hash_matches_expected": True, + }, + "ready_for_api_database_write": False, + "ready_for_telegram_dispatch": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_executes_llm": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "summary_persistence_record_written": False, + "metadata_patch_written": False, + "llm_call_executed": False, + "telegram_dispatched": False, + "database_connection_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "review_state_update_executed": False, + "scheduler_attached": False, + "safe_boundaries": [ + "do_not_execute_summary_persistence_writer_from_receipt_api", + "do_not_read_approval_token_from_summary_persistence_receipt_api", + "do_not_echo_operator_receipt_payload", + "do_not_create_summary_persistence_receipt_artifact_from_api", + "do_not_open_database_connection_from_summary_persistence_receipt", + "do_not_write_metadata_json_from_summary_persistence_receipt", + "do_not_update_review_state_from_summary_persistence_receipt", + "do_not_commit_summary_persistence_receipt", + "do_not_dispatch_telegram_from_summary_persistence_receipt", + "do_not_attach_scheduler_from_summary_persistence_receipt", + ], + } + operator_evidence = { + "ai_summary_persistence_closeout_artifact_path": ( + "artifacts/market_intel/ai-summary-persistence-closeout.json" + ), + "operator_confirmed_summary_persistence_closeout": True, + "operator_confirmed_telegram_dispatch_requires_separate_gate": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_no_telegram_dispatch": True, + "closeout_notes": "Receipt reviewed; next gate is Telegram dispatch.", + } + closeout = build_candidate_queue_review_ai_summary_persistence_run_closeout( + run_receipt=run_receipt, + operator_evidence=operator_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_ai_summary_persistence_run_closeout( + run_receipt=run_receipt, + operator_evidence={**operator_evidence, "approval_token": TEST_APPROVAL_TOKEN}, + ) + apply_write = build_candidate_queue_review_ai_summary_persistence_run_closeout( + run_receipt=run_receipt, + operator_evidence=operator_evidence, + apply_real_write=True, + ) + + assert closeout["mode"] == ( + "candidate_queue_review_ai_summary_persistence_run_closeout_preview" + ) + assert closeout["closeout_passed"] is True + assert closeout["summary_persistence_closeout_passed"] is True + assert closeout["ready_for_summary_persistence_telegram_dispatch_gate"] is True + assert closeout["ready_for_telegram_dispatch"] is False + assert closeout["ready_for_api_database_write"] is False + assert closeout["ready_for_scheduler_attach"] is False + assert closeout["summary_persistence_closeout_file_written"] is False + assert closeout["closeout_file_written"] is False + assert closeout["api_executes_cli"] is False + assert closeout["api_executes_llm"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_file"] is False + assert closeout["api_writes_database"] is False + assert closeout["database_connection_opened"] is False + assert closeout["database_write_executed"] is False + assert closeout["database_commit_executed"] is False + assert closeout["llm_call_executed"] is False + assert closeout["telegram_dispatched"] is False + assert closeout["scheduler_attached"] is False + assert closeout["writes_executed"] is False + assert closeout["would_write_database"] is False + assert closeout["statement_count"] == 1 + assert closeout["receipt_summary"]["safe_boundaries_complete"] is True + assert closeout["operator_closeout_summary"][ + "closeout_artifact_path_recorded" + ] is True + assert closeout["promotion_gate"]["next_manual_phase"] == ( + "summary_persistence_telegram_dispatch_gate" + ) + assert closeout["promotion_gate"][ + "telegram_dispatch_requires_separate_gate" + ] is True + assert closeout["blocked_reasons"] == [] + assert token_leak["closeout_passed"] is False + assert "closeout_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert "closeout_apply_real_write_not_requested_from_api" in apply_write[ + "blocked_reasons" + ] + assert "do_not_dispatch_telegram_from_summary_persistence_closeout" in closeout[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6854,7 +7003,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6911,7 +7060,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -7000,7 +7149,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -7054,7 +7203,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -7110,7 +7259,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -7176,7 +7325,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -7478,7 +7627,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -7526,7 +7675,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -7575,7 +7724,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -7633,7 +7782,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -7699,7 +7848,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -7770,7 +7919,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -7846,7 +7995,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -7928,7 +8077,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -8014,7 +8163,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -8097,7 +8246,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -8180,7 +8329,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -8266,7 +8415,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -8357,7 +8506,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -8467,7 +8616,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -8553,7 +8702,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -8610,7 +8759,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -8663,7 +8812,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -8716,7 +8865,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8777,7 +8926,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8846,7 +8995,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8918,7 +9067,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -8991,7 +9140,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -9062,7 +9211,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -9127,7 +9276,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -9198,7 +9347,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -9271,7 +9420,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -9348,7 +9497,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -9394,6 +9543,83 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_closeout" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_closeout" + "?execute=true&apply_real_write=true", + json={"sample_result": {}}, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_ai_summary_persistence_run_closeout_preview" + ) + assert data["phase"] == ( + "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" + ) + assert data["closeout_passed"] is False + assert data["summary_persistence_closeout_passed"] is False + assert data["ready_for_summary_persistence_telegram_dispatch_gate"] is False + assert data["ready_for_telegram_dispatch"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["summary_persistence_closeout_file_written"] is False + assert data["closeout_file_written"] is False + assert data["api_executes_llm"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["summary_persistence_record_written"] is False + assert data["metadata_patch_written"] is False + assert data["transaction_file_written"] is False + assert data["ai_summary_generated"] is False + assert data["llm_call_executed"] is False + assert data["telegram_dispatched"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["scheduler_attached"] is False + assert data["statement_count"] == 0 + assert data["receipt_summary"]["mode"] == ( + "candidate_queue_review_ai_summary_persistence_run_receipt_preview" + ) + assert "receipt_passed" in data["blocked_reasons"] + assert "receipt_expected_dedupe_keys_present" in data["blocked_reasons"] + assert "closeout_artifact_path_recorded" in data["blocked_reasons"] + assert "operator_confirmed_telegram_dispatch_requires_separate_gate" in data[ + "blocked_reasons" + ] + assert "closeout_apply_real_write_not_requested_from_api" in data[ + "blocked_reasons" + ] + assert "do_not_open_database_connection_from_summary_persistence_closeout" in data[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -9422,7 +9648,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -9447,7 +9673,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -9485,7 +9711,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -9496,7 +9722,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -9532,7 +9758,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -9543,7 +9769,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -9584,7 +9810,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -9595,7 +9821,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -9643,7 +9869,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -9655,7 +9881,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -9701,7 +9927,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -9714,7 +9940,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert plan["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -9799,7 +10025,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -9877,7 +10103,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -9892,7 +10118,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert readiness["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -10452,6 +10678,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_ai_summary_persistence_run_closeout_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -10641,6 +10873,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_ai_summary_persistence_run_receipt" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_run_closeout" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -12742,6 +12979,72 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "mode" + ] + == "candidate_queue_review_ai_summary_persistence_run_closeout_preview" + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "closeout_passed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "ready_for_summary_persistence_telegram_dispatch_gate" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "statement_count" + ] + == 0 + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "summary_persistence_closeout_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "closeout_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "api_executes_llm" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "telegram_dispatched" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "database_connection_opened" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_run_closeout"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -12892,7 +13195,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert drill["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -13007,7 +13310,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -13019,7 +13322,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert review["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -13134,7 +13437,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -13147,7 +13450,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert smoke["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -13209,7 +13512,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -13222,7 +13525,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert inventory["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -13366,7 +13669,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -13593,7 +13896,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -13622,7 +13925,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_88_candidate_queue_review_ai_summary_persistence_run_receipt" + assert data["phase"] == "phase_89_candidate_queue_review_ai_summary_persistence_run_closeout" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False