diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 1b6b3d2..a6003b5 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.496 新增市場情報 MCP Fetch Candidate Queue Writer CLI Review 安全預覽 gate：只審核 writer preflight 後的 CLI review 草案，確認 script path、target table、preflight id、payload row count、candidate/dedupe keys 與 command argv；禁止 API 執行 CLI、禁止 `--execute` / `--apply-real-write` / `--approval-token` 進 payload，API 不讀 token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - V10.495 新增市場情報 MCP Fetch Candidate Queue Writer Preflight 安全預覽 gate：只審核 queue review 後的 writer preflight 草案，確認 target_table、write_mode、dedupe strategy、insert columns、payload rows 與候選 key 對齊；API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - V10.494 新增市場情報 MCP Fetch Candidate Queue Review 安全預覽 gate：只審核 candidate handoff 後的人工 queue review 草案，要求候選 key 對齊、review_state 停在 needs_review、allowed actions 限定人工確認/否決/延後、queue_write_status 維持 not_persisted；API 不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - V10.493 新增市場情報 MCP Fetch Candidate Handoff Review 安全預覽 gate：只審核 parser review 後的候選交接包，確認 source/candidate key 對齊、queue policy 仍是 manual preview、候選數維持小批次、無 raw/secret/side-effect；API 不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 diff --git a/config.py b/config.py index ba664cc..2eb762e 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.495" +SYSTEM_VERSION = "V10.496" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index be46888..9920a4d 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -167,6 +167,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate handoff review gate：`services.market_intel.mcp_fetch_candidate_handoff_review` 與 `/api/market_intel/mcp_fetch_candidate_handoff_review` 在 parser review 通過後審核候選交接包，檢查 source/candidate key 對齊、queue policy 是否仍是 `manual_candidate_review` / `preview_only`、小批次候選上限、操作員無寫入/無連外/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不建立 queue、不讀 artifact、不寫 DB、不掛 scheduler，只放行到人工 candidate queue review。 - 2026-05-31 追加 MCP fetch candidate queue review gate：`services.market_intel.mcp_fetch_candidate_queue_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_review` 在 handoff review 通過後審核人工 queue review 草案，檢查候選 key 對齊、`review_state=needs_review`、allowed actions 人工限定、`queue_write_status=not_persisted`、操作員無寫入/無連外/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不建立 queue、不更新 review_state、不讀 artifact、不寫 DB、不掛 scheduler，只放行到 writer preflight。 - 2026-05-31 追加 MCP fetch candidate queue writer preflight gate：`services.market_intel.mcp_fetch_candidate_queue_writer_preflight` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 在 queue review 通過後審核 writer preflight 草案，檢查 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows、候選 key 對齊、小批次上限、操作員無寫入/無連外/無 CLI/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不掛 scheduler，只放行到 CLI writer review。 +- 2026-05-31 追加 MCP fetch candidate queue writer CLI review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_cli_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review` 在 writer preflight 通過後審核 CLI review 草案，檢查 script path、target table、preflight id、payload row count、candidate/dedupe keys、`--sample-json`、`--read-only-preflight` 與 forbidden flags；API/UI 不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler，只放行到 operator run package review。 - 2026-05-18 追加 scheduler attach plan preview：`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB；排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview：`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP；價格只能作為輔助訊號，不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview：`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB；高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 51c44e8..e754dd3 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -45,6 +45,7 @@ - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增邏輯維持在獨立 `services/market_intel/mcp_fetch_candidate_queue_review.py`，route 延續 `routes/market_intel_mcp_run_routes.py` extension。 - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer preflight gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增邏輯維持在獨立 `services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py`，route 延續 `routes/market_intel_mcp_run_routes.py` extension。 - 2026-05-31 追記：`services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py` 目前 628 行，略過 600 行提醒門檻；暫不拆分的理由是 gate 條件、sample payload 與 side-effect blocklist 需留在單一 preview module 便於審核，下一個 writer CLI review gate 若共用相同常數再抽 `mcp_fetch_candidate_queue_writer_policy.py`。 +- 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer CLI review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_cli_review.py` 為 591 行，仍低於 600 行提醒門檻。 - 2026-05-24 追記：同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數；此處只更新 inventory，不變更 Code Review 行為。 - 2026-05-21 追記：同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 - 2026-05-21 追記：同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 @@ -97,7 +98,7 @@ | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | | 917 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 1219 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 1260 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index 63d9ca4..38f7a81 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -91,6 +91,7 @@ - 2026-05-31 起，`V10.493` 新增市場情報 MCP Fetch Candidate Handoff Review gate：在 parser review 通過後只審核候選交接包，要求 source/candidate key 完全對齊、queue policy 維持 manual preview、小批次上限與操作員無寫入/無連外/無排程確認；仍不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 - 2026-05-31 起，`V10.494` 新增市場情報 MCP Fetch Candidate Queue Review gate：在 handoff review 通過後只審核人工 queue review 草案，要求候選 key 完全對齊、review_state 只停在 `needs_review`、allowed actions 限人工操作、queue_write_status 維持 `not_persisted`；仍不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - 2026-05-31 起，`V10.495` 新增市場情報 MCP Fetch Candidate Queue Writer Preflight gate：在 queue review 通過後只審核 writer preflight 草案，要求 target table、write mode、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊；仍不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 +- 2026-05-31 起，`V10.496` 新增市場情報 MCP Fetch Candidate Queue Writer CLI Review gate：在 writer preflight 通過後只審核 CLI review 草案，要求 script path、target table、preflight id、row count、candidate/dedupe keys 與 read-only command argv 對齊；仍不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index cecbf94..06e6732 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24：PChome 近門檻身份回收第二輪 +- **V10.496 市場情報 MCP Fetch Candidate Queue Writer CLI Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review` 與 UI preview，只審核 writer preflight 後的 CLI review 草案；要求 script path、target table、preflight id、payload row count、candidate/dedupe keys 與 command argv 完全對齊，並禁止 `--execute`、`--apply-real-write`、`--approval-token` 進 API payload，且 API 不執行 CLI、不讀 token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - **V10.495 市場情報 MCP Fetch Candidate Queue Writer Preflight gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 與 UI preview，只審核 queue review 後的 writer preflight 草案；要求 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊，且 API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - **V10.494 市場情報 MCP Fetch Candidate Queue Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_review` 與 UI preview，只審核 candidate handoff 後的人工 queue review 草案；要求候選 key 完全對齊、`review_state=needs_review`、allowed actions 限人工確認/否決/延後、`queue_write_status=not_persisted`，且 API 不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - **V10.493 市場情報 MCP Fetch Candidate Handoff Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_handoff_review` 與 UI preview，只審核 parser review 後的候選交接包；要求 source/candidate key 完全對齊、queue policy 維持 `manual_candidate_review` / `preview_only`、候選數維持小批次，且 API 不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index aefbd64..6f3eb0f 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -28,6 +28,9 @@ from services.market_intel.mcp_fetch_candidate_queue_review import ( from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( build_mcp_fetch_candidate_queue_writer_preflight_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( + build_mcp_fetch_candidate_queue_writer_cli_review_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -298,3 +301,49 @@ def market_intel_mcp_fetch_candidate_queue_writer_preflight(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_cli_review(): + writer_preflight_package = {} + writer_preflight_result = None + writer_cli_review = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_cli_review_package") + or payload.get("candidate_queue_writer_cli_review") + or payload.get("writer_cli_review") + or payload + ) + writer_preflight_package = ( + package.get("writer_preflight_package") + or package.get("candidate_queue_writer_preflight") + or package.get("writer_preflight") + or package.get("preflight_package") + or {} + ) + writer_preflight_result = ( + package.get("writer_preflight_result") + or package.get("mcp_fetch_candidate_queue_writer_preflight") + ) + writer_cli_review = ( + package.get("writer_cli_review") + or package.get("candidate_queue_writer_cli_review") + or package.get("cli_review") + or package.get("review_payload") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_cli_review_preview( + writer_preflight_package=writer_preflight_package, + writer_preflight_result=writer_preflight_result, + writer_cli_review=writer_cli_review, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 9f4818c..6fabad6 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -84,6 +84,9 @@ from services.market_intel.mcp_fetch_candidate_queue_review import ( from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( build_mcp_fetch_candidate_queue_writer_preflight_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( + build_mcp_fetch_candidate_queue_writer_cli_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -221,6 +224,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_candidate_queue_writer_preflight",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -275,6 +283,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_cli_review = ( + build_mcp_fetch_candidate_queue_writer_cli_review_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -822,6 +835,33 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_fetch_candidate_queue_writer_preflight["file_written"] and not mcp_fetch_candidate_queue_writer_preflight["scheduler_attached"] ), + "mcp_fetch_candidate_queue_writer_cli_review_preview_safe": bool( + mcp_fetch_candidate_queue_writer_cli_review["mode"] + == "mcp_fetch_candidate_queue_writer_cli_review_preview" + and not mcp_fetch_candidate_queue_writer_cli_review["payload_persisted"] + and not mcp_fetch_candidate_queue_writer_cli_review["cli_review_persisted"] + and not mcp_fetch_candidate_queue_writer_cli_review[ + "package_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_cli_review["api_writes_file"] + and not mcp_fetch_candidate_queue_writer_cli_review["api_executes_cli"] + and not mcp_fetch_candidate_queue_writer_cli_review[ + "api_reads_approval_token" + ] + and not mcp_fetch_candidate_queue_writer_cli_review[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_cli_review["api_writes_database"] + and not mcp_fetch_candidate_queue_writer_cli_review[ + "api_uses_external_network" + ] + and not mcp_fetch_candidate_queue_writer_cli_review[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_cli_review["cli_executed"] + and not mcp_fetch_candidate_queue_writer_cli_review["file_written"] + and not mcp_fetch_candidate_queue_writer_cli_review["scheduler_attached"] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1142,6 +1182,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_candidate_handoff_review": mcp_fetch_candidate_handoff_review, "mcp_fetch_candidate_queue_review": mcp_fetch_candidate_queue_review, "mcp_fetch_candidate_queue_writer_preflight": mcp_fetch_candidate_queue_writer_preflight, + "mcp_fetch_candidate_queue_writer_cli_review": mcp_fetch_candidate_queue_writer_cli_review, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_cli_review.py b/services/market_intel/mcp_fetch_candidate_queue_writer_cli_review.py new file mode 100644 index 0000000..39a04d2 --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_cli_review.py @@ -0,0 +1,591 @@ +"""市場情報 MCP fetch candidate queue writer CLI review preview。 + +本模組只審核 writer preflight 後的 CLI review 草案；API/UI 不執行 CLI、 +不讀 approval token、不開 DB、不寫 queue、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( + TARGET_TABLE, + build_mcp_fetch_candidate_queue_writer_preflight_preview, +) + + +SCRIPT_PATH = "scripts/market_intel_candidate_queue_writer.py" +MAX_CLI_REVIEW_ITEMS = 80 +SAFE_REVIEW_MODES = {"candidate_queue_writer_cli_review_preview"} +SAFE_COMMAND_MODES = {"manual_shell_review_only"} +REQUIRED_SAFE_FLAGS = ("--sample-json", "--read-only-preflight") +FORBIDDEN_COMMAND_FLAGS = ( + "--apply-real-write", + "--approval-token", + "--execute", +) + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "secret", + "session_cookie", + "token", +) + +SAFE_SECRET_METADATA_KEYS = { + "approval_token_shell_only", + "operator_confirmed_no_approval_token_in_payload", + "operator_confirmed_no_secret_payload", +} + +FORBIDDEN_RAW_PAYLOAD_KEYS = ( + "body_html", + "document_html", + "html", + "page_html", + "raw_body", + "raw_html", + "raw_snapshot", + "response_body", +) + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_cli_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_executed_cli", + "api_executes_cli", + "api_opens_database_connection", + "api_reads_approval_token", + "api_uses_external_network", + "api_writes_database", + "api_writes_file", + "apply_real_write", + "attach_scheduler", + "candidate_queue_created", + "candidate_queue_persisted", + "candidate_review_state_updated", + "cli_executed", + "command_executed", + "database_commit_executed", + "database_connection_opened", + "database_session_created", + "database_write_executed", + "execute_requested", + "external_network_executed", + "file_written", + "network_request_allowed", + "package_artifact_created", + "payload_persisted", + "ready_for_api_database_write", + "ready_for_real_write", + "review_state_update_executed", + "scheduler_attached", + "write_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _contains_forbidden_key(value, forbidden_keys, *, safe_keys=None): + safe_keys = safe_keys or set() + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in safe_keys and isinstance(nested, bool): + continue + if any(forbidden_key in normalized_key for forbidden_key in forbidden_keys): + return True + if _contains_forbidden_key(nested, forbidden_keys, safe_keys=safe_keys): + return True + elif isinstance(value, list): + return any( + _contains_forbidden_key(item, forbidden_keys, safe_keys=safe_keys) + for item in value + ) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _preflight_from_inputs(preflight_package, preflight_result, phase): + if isinstance(preflight_result, dict) and preflight_result: + return preflight_result + + preflight_package = _as_dict(preflight_package) + return build_mcp_fetch_candidate_queue_writer_preflight_preview( + queue_review_package=( + preflight_package.get("queue_review_package") + or preflight_package.get("candidate_queue_review") + or preflight_package.get("queue_review") + ), + queue_review_result=( + preflight_package.get("queue_review_result") + or preflight_package.get("mcp_fetch_candidate_queue_review") + ), + writer_preflight=( + preflight_package.get("writer_preflight") + or preflight_package.get("candidate_queue_writer_preflight") + or preflight_package.get("preflight") + ), + phase=phase, + ) + + +def _preflight_summary(preflight): + preflight = _as_dict(preflight) + writer_summary = _as_dict(preflight.get("writer_preflight_summary")) + rows = _as_list(writer_summary.get("payload_rows")) + side_effects_clear = bool( + not preflight.get("network_request_allowed") + and not preflight.get("api_executes_cli") + and not preflight.get("api_opens_database_connection") + and not preflight.get("api_writes_database") + and not preflight.get("api_uses_external_network") + and not preflight.get("database_write_executed") + and not preflight.get("cli_executed") + and not preflight.get("file_written") + and not preflight.get("scheduler_attached") + and not preflight.get("candidate_queue_created") + and not preflight.get("candidate_queue_persisted") + and not preflight.get("candidate_review_state_updated") + ) + return { + "mode": preflight.get("mode"), + "accepted": bool( + preflight.get("mcp_fetch_candidate_queue_writer_preflight_accepted") + ), + "ready_for_candidate_queue_writer_cli_review": bool( + preflight.get("ready_for_candidate_queue_writer_cli_review") + ), + "target_table": writer_summary.get("target_table"), + "preflight_id": writer_summary.get("preflight_id"), + "payload_row_count": _safe_int(writer_summary.get("payload_row_count")), + "campaign_candidate_count": _safe_int( + writer_summary.get("campaign_candidate_count") + ), + "product_candidate_count": _safe_int( + writer_summary.get("product_candidate_count") + ), + "candidate_keys": sorted( + row.get("candidate_key") for row in rows if row.get("candidate_key") + ), + "dedupe_keys": sorted(row.get("dedupe_key") for row in rows if row.get("dedupe_key")), + "side_effects_clear": side_effects_clear, + "blocked_reasons": preflight.get("blocked_reasons", []), + } + + +def _sample_cli_review_package(): + preflight_preview = build_mcp_fetch_candidate_queue_writer_preflight_preview() + preflight_package = preflight_preview["sample_writer_preflight_package"] + preflight_result = build_mcp_fetch_candidate_queue_writer_preflight_preview( + queue_review_package=preflight_package["queue_review_package"], + queue_review_result=preflight_package["queue_review_result"], + writer_preflight=preflight_package["writer_preflight"], + ) + preflight = _preflight_summary(preflight_result) + return { + "writer_preflight_package": preflight_package, + "writer_preflight_result": preflight_result, + "writer_cli_review": { + "review_id": "market-intel-candidate-writer-cli-review-sample", + "review_mode": "candidate_queue_writer_cli_review_preview", + "command_mode": "manual_shell_review_only", + "script_path": SCRIPT_PATH, + "target_table": TARGET_TABLE, + "preflight_id": preflight["preflight_id"], + "expected_payload_row_count": preflight["payload_row_count"], + "expected_candidate_keys": preflight["candidate_keys"], + "expected_dedupe_keys": preflight["dedupe_keys"], + "command_argv_preview": [ + "python3", + SCRIPT_PATH, + "--sample-json", + "", + "--read-only-preflight", + ], + "operator_confirmed_no_api_cli_execution": True, + "operator_confirmed_no_database_write": True, + "operator_confirmed_no_external_network": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_persistence": True, + "operator_confirmed_no_approval_token_in_payload": True, + "operator_confirmed_no_secret_payload": True, + "dry_run_first_required": True, + "approval_token_shell_only": True, + "api_execution_allowed": False, + "real_write_allowed": False, + }, + } + + +def _cli_review_summary(cli_review): + cli_review = _as_dict(cli_review) + command_argv = [ + _safe_text(item, 200) for item in _as_list(cli_review.get("command_argv_preview")) + ] + command_argv = [item for item in command_argv if item] + candidate_keys = sorted( + key for key in _as_list(cli_review.get("expected_candidate_keys")) if key + ) + dedupe_keys = sorted( + key for key in _as_list(cli_review.get("expected_dedupe_keys")) if key + ) + operator_boundaries_confirmed = bool( + cli_review.get("operator_confirmed_no_api_cli_execution") + and cli_review.get("operator_confirmed_no_database_write") + and cli_review.get("operator_confirmed_no_external_network") + and cli_review.get("operator_confirmed_no_scheduler_attach") + and cli_review.get("operator_confirmed_no_persistence") + and cli_review.get("operator_confirmed_no_approval_token_in_payload") + and cli_review.get("operator_confirmed_no_secret_payload") + ) + return { + "provided_keys": sorted(cli_review.keys()), + "review_id": _safe_text(cli_review.get("review_id"), 160), + "review_mode": _safe_text(cli_review.get("review_mode"), 120), + "command_mode": _safe_text(cli_review.get("command_mode"), 120), + "script_path": _safe_text(cli_review.get("script_path"), 240), + "target_table": _safe_text(cli_review.get("target_table"), 160), + "preflight_id": _safe_text(cli_review.get("preflight_id"), 160), + "expected_payload_row_count": _safe_int( + cli_review.get("expected_payload_row_count") + ), + "expected_candidate_keys": candidate_keys, + "expected_dedupe_keys": dedupe_keys, + "command_argv_preview": command_argv, + "required_safe_flags_present": all( + flag in command_argv for flag in REQUIRED_SAFE_FLAGS + ), + "forbidden_command_flags_absent": not any( + flag in command_argv for flag in FORBIDDEN_COMMAND_FLAGS + ), + "command_invokes_expected_script": bool( + SCRIPT_PATH in command_argv and command_argv[:1] in (["python"], ["python3"]) + ), + "operator_boundaries_confirmed": operator_boundaries_confirmed, + "dry_run_first_required": bool(cli_review.get("dry_run_first_required")), + "approval_token_shell_only": bool(cli_review.get("approval_token_shell_only")), + "api_execution_allowed": bool(cli_review.get("api_execution_allowed")), + "real_write_allowed": bool(cli_review.get("real_write_allowed")), + "candidate_keys_unique": bool( + candidate_keys and len(set(candidate_keys)) == len(candidate_keys) + ), + "dedupe_keys_unique": bool( + dedupe_keys and len(set(dedupe_keys)) == len(dedupe_keys) + ), + "raw_payload_submitted_to_api": _contains_forbidden_key( + cli_review, + FORBIDDEN_RAW_PAYLOAD_KEYS, + ), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + cli_review, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_side_effects(cli_review), + } + + +def _review_gates( + *, + preflight_received, + cli_review_received, + cli_review_valid_object, + preflight, + cli_review, +): + preflight_candidate_keys = set(preflight["candidate_keys"]) + review_candidate_keys = set(cli_review["expected_candidate_keys"]) + preflight_dedupe_keys = set(preflight["dedupe_keys"]) + review_dedupe_keys = set(cli_review["expected_dedupe_keys"]) + return [ + { + "key": "writer_preflight_payload_or_result_received", + "label": "已提供 writer preflight package 或已審核結果", + "passed": preflight_received, + }, + { + "key": "writer_preflight_accepted", + "label": "writer preflight gate 必須已通過", + "passed": preflight["accepted"], + }, + { + "key": "writer_preflight_ready_for_cli_review", + "label": "writer preflight 只放行到 CLI review", + "passed": preflight["ready_for_candidate_queue_writer_cli_review"], + }, + { + "key": "writer_preflight_side_effect_free", + "label": "writer preflight 未顯示 API 執行、寫 DB 或掛 scheduler", + "passed": preflight["side_effects_clear"], + }, + { + "key": "writer_cli_review_payload_received", + "label": "已提供 writer CLI review 草案", + "passed": cli_review_received, + }, + { + "key": "writer_cli_review_valid_object", + "label": "writer CLI review payload 必須是 JSON object", + "passed": cli_review_valid_object, + }, + { + "key": "writer_cli_review_identity_recorded", + "label": "writer CLI review 必須記錄 review_id", + "passed": bool(cli_review["review_id"]), + }, + { + "key": "writer_cli_review_mode_preview_only", + "label": "writer CLI review 必須維持 preview mode", + "passed": cli_review["review_mode"] in SAFE_REVIEW_MODES, + }, + { + "key": "writer_cli_command_mode_manual_shell_only", + "label": "command mode 必須是 manual_shell_review_only", + "passed": cli_review["command_mode"] in SAFE_COMMAND_MODES, + }, + { + "key": "writer_cli_script_path_safe", + "label": "script path 必須是候選 queue writer CLI", + "passed": cli_review["script_path"] == SCRIPT_PATH, + }, + { + "key": "writer_cli_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": cli_review["target_table"] == TARGET_TABLE, + }, + { + "key": "writer_cli_preflight_id_matches", + "label": "CLI review preflight_id 必須對齊 writer preflight", + "passed": bool( + cli_review["preflight_id"] + and cli_review["preflight_id"] == preflight["preflight_id"] + ), + }, + { + "key": "writer_cli_payload_count_matches_preflight", + "label": "CLI review row count 必須對齊 writer preflight", + "passed": bool( + 0 < cli_review["expected_payload_row_count"] <= MAX_CLI_REVIEW_ITEMS + and cli_review["expected_payload_row_count"] + == preflight["payload_row_count"] + ), + }, + { + "key": "writer_cli_candidate_keys_match_preflight", + "label": "CLI review candidate keys 必須完全對齊 writer preflight", + "passed": bool( + preflight_candidate_keys + and review_candidate_keys == preflight_candidate_keys + and cli_review["candidate_keys_unique"] + ), + }, + { + "key": "writer_cli_dedupe_keys_match_preflight", + "label": "CLI review dedupe keys 必須完全對齊 writer preflight", + "passed": bool( + preflight_dedupe_keys + and review_dedupe_keys == preflight_dedupe_keys + and cli_review["dedupe_keys_unique"] + ), + }, + { + "key": "writer_cli_command_invokes_expected_script", + "label": "command argv 必須只預覽候選 queue writer script", + "passed": cli_review["command_invokes_expected_script"], + }, + { + "key": "writer_cli_required_safe_flags_present", + "label": "command argv 必須包含 sample-json 與 read-only preflight", + "passed": cli_review["required_safe_flags_present"], + }, + { + "key": "writer_cli_forbidden_write_flags_absent", + "label": "command argv 不得包含 execute/apply/approval-token", + "passed": cli_review["forbidden_command_flags_absent"], + }, + { + "key": "writer_cli_operator_boundaries_confirmed", + "label": "操作員確認 API 不執行 CLI、不讀 token、不寫 DB、不保存、不掛排程", + "passed": cli_review["operator_boundaries_confirmed"], + }, + { + "key": "writer_cli_dry_run_first_required", + "label": "正式流程必須先 dry-run / read-only preflight", + "passed": cli_review["dry_run_first_required"], + }, + { + "key": "writer_cli_approval_token_shell_only", + "label": "approval token 只能在 shell 提供，不得進 API payload", + "passed": cli_review["approval_token_shell_only"], + }, + { + "key": "writer_cli_no_api_execution_or_real_write", + "label": "API review payload 不得允許 CLI 執行或 real write", + "passed": bool( + not cli_review["api_execution_allowed"] + and not cli_review["real_write_allowed"] + ), + }, + { + "key": "writer_cli_no_raw_payload", + "label": "writer CLI review payload 不得回貼 raw HTML/body/snapshot", + "passed": not cli_review["raw_payload_submitted_to_api"], + }, + { + "key": "writer_cli_no_secret_or_token_key", + "label": "writer CLI review payload 不得包含 secret、cookie、password 或 token key", + "passed": not cli_review["secret_or_token_submitted_to_api"], + }, + { + "key": "writer_cli_side_effect_free", + "label": "writer CLI review payload 不得要求 API 執行、寫檔、寫 DB 或掛 scheduler", + "passed": not cli_review["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_queue_writer_cli_review_preview( + *, + writer_preflight_package=None, + writer_preflight_result=None, + writer_cli_review=None, + phase=None, +): + """建立 fetch candidate queue writer CLI review；不執行 CLI 或寫入。""" + writer_preflight_package = _as_dict(writer_preflight_package) + preflight_result_received = bool( + isinstance(writer_preflight_result, dict) and writer_preflight_result + ) + cli_review_valid_object = ( + isinstance(writer_cli_review, dict) if writer_cli_review is not None else True + ) + cli_review_payload = _as_dict(writer_cli_review) + preflight_data = _preflight_from_inputs( + writer_preflight_package, + writer_preflight_result, + phase, + ) + preflight_received = bool( + writer_preflight_package or preflight_result_received + ) + payload_received = bool( + preflight_received or cli_review_payload or writer_cli_review is not None + ) + cli_review_received = bool(cli_review_payload) + preflight = _preflight_summary(preflight_data) + cli_review = _cli_review_summary(cli_review_payload) + gates = _review_gates( + preflight_received=preflight_received, + cli_review_received=cli_review_received, + cli_review_valid_object=cli_review_valid_object, + preflight=preflight, + cli_review=cli_review, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_cli_review" + if payload_received + else "mcp_fetch_candidate_queue_writer_cli_review_preview" + ), + "phase": phase, + "writer_cli_review_payload_received": payload_received, + "writer_preflight_received": preflight_received, + "writer_cli_review_received": cli_review_received, + "writer_cli_review_valid_object": cli_review_valid_object, + "writer_preflight_accepted": preflight["accepted"], + "mcp_fetch_candidate_queue_writer_cli_review_accepted": accepted, + "candidate_queue_writer_cli_review_ready": accepted, + "ready_for_candidate_queue_writer_run_package_review": accepted, + "ready_for_api_database_write": False, + "ready_for_real_write": False, + "ready_for_scheduler_attach": False, + "network_request_allowed": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "cli_executed": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + "payload_row_count": cli_review["expected_payload_row_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "writer_preflight_summary": preflight, + "writer_cli_review_summary": cli_review, + "sample_writer_cli_review_package": _sample_cli_review_package(), + "next_operator_steps": [ + "CLI review 通過後，只代表可整理 operator run package，不代表可執行 CLI", + "真正 --execute、--apply-real-write 與 approval token 必須留在人工 shell gate", + "API/UI 仍不得讀 token、不得執行 CLI、不得開 DB、不得寫 queue", + ], + "payload_persisted": False, + "cli_review_persisted": False, + "package_artifact_created": False, + "api_writes_file": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index b663c49..78b2bd9 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" +MARKET_INTEL_PHASE = "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 0d718ec..7d7d4c5 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -864,6 +864,32 @@ +
+
+
+

MCP / WRITER CLI REVIEW

+

MCP Candidate Queue Writer CLI Review

+
+ +
+
+ loading +
+
+
讀取 MCP Writer CLI Review 中...
+
+
+ +
+ +
+
+
+
@@ -1380,6 +1406,7 @@ const mcpFetchCandidateHandoffReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review]'); const mcpFetchCandidateQueueReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-review]'); const mcpFetchCandidateQueueWriterPreflightRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight]'); + const mcpFetchCandidateQueueWriterCliReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1396,7 +1423,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1515,6 +1542,12 @@ const mcpFetchCandidateQueueWriterPreflightReview = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-review]') : null; const mcpFetchCandidateQueueWriterPreflightRefresh = mcpFetchCandidateQueueWriterPreflightRoot ? mcpFetchCandidateQueueWriterPreflightRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight-refresh]') : null; const mcpFetchCandidateQueueWriterPreflightEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_preflight') }}"; + const mcpFetchCandidateQueueWriterCliReviewMeta = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-meta]') : null; + const mcpFetchCandidateQueueWriterCliReviewBody = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-body]') : null; + const mcpFetchCandidateQueueWriterCliReviewInput = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-input]') : null; + const mcpFetchCandidateQueueWriterCliReviewReview = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-review]') : null; + const mcpFetchCandidateQueueWriterCliReviewRefresh = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-refresh]') : null; + const mcpFetchCandidateQueueWriterCliReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_cli_review') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -3981,6 +4014,134 @@ } }; + const renderMcpFetchCandidateQueueWriterCliReviewMeta = data => { + mcpFetchCandidateQueueWriterCliReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_cli_review_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || 0}`, + `cli=${data.api_executes_cli ? 'exec' : 'blocked'}`, + `db=${data.api_writes_database ? 'write' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterCliReviewBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const preflight = data.writer_preflight_summary || {}; + const review = data.writer_cli_review_summary || {}; + const argv = review.command_argv_preview || []; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterCliReviewBody.innerHTML = ` +
此 CLI review 只審核人工 shell writer 草案；API 不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

CLI REVIEW GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 CLI review gates。
' + }
+
+
+

PREFLIGHT LINK

+
+ ${renderCheck('writer_preflight', `${preflight.accepted ? 'accepted' : 'pending'} / rows=${preflight.payload_row_count || 0}`, preflight.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('preflight_id', preflight.preflight_id || 'missing', preflight.preflight_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('preflight_boundary', 'no CLI / no DB / no scheduler', preflight.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

COMMAND REVIEW

+
+ ${renderCheck('script_path', review.script_path || 'missing', review.script_path === 'scripts/market_intel_candidate_queue_writer.py' ? 'READY' : 'BLOCK')} + ${renderCheck('command_mode', review.command_mode || 'missing', review.command_mode === 'manual_shell_review_only' ? 'MANUAL' : 'BLOCK')} + ${renderCheck('safe_flags', argv.join(' '), review.required_safe_flags_present ? 'READY' : 'BLOCK')} + ${renderCheck('forbidden_flags', '--execute / --apply-real-write / --approval-token', review.forbidden_command_flags_absent ? 'ABSENT' : 'BLOCK')} +
+
+
+

PAYLOAD CONTRACT

+
+ ${renderCheck('target_table', review.target_table || 'missing', review.target_table === 'market_alert_review_queue' ? 'TARGET' : 'BLOCK')} + ${renderCheck('row_count', `${review.expected_payload_row_count || 0}`, review.expected_payload_row_count === preflight.payload_row_count ? 'MATCH' : 'BLOCK')} + ${renderCheck('candidate_keys', `${(review.expected_candidate_keys || []).length}`, review.candidate_keys_unique ? 'UNIQUE' : 'BLOCK')} + ${renderCheck('dedupe_keys', `${(review.expected_dedupe_keys || []).length}`, review.dedupe_keys_unique ? 'UNIQUE' : 'BLOCK')} +
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck( + 'api_boundary', + 'no CLI / no token / no DB / no queue write / no scheduler', + data.api_executes_cli || data.api_reads_approval_token || data.api_writes_database ? 'BLOCK' : 'CLOSED' + )} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterCliReviewInput && !mcpFetchCandidateQueueWriterCliReviewInput.value.trim() && data.sample_writer_cli_review_package) { + mcpFetchCandidateQueueWriterCliReviewInput.value = JSON.stringify(data.sample_writer_cli_review_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterCliReview = async () => { + if (!mcpFetchCandidateQueueWriterCliReviewMeta || !mcpFetchCandidateQueueWriterCliReviewBody) return; + mcpFetchCandidateQueueWriterCliReviewBody.innerHTML = '
讀取 MCP Writer CLI Review 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterCliReviewEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterCliReviewMeta(data); + renderMcpFetchCandidateQueueWriterCliReviewBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterCliReviewMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterCliReviewBody.innerHTML = `
MCP Writer CLI Review 讀取失敗：${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterCliReview = async () => { + if (!mcpFetchCandidateQueueWriterCliReviewMeta || !mcpFetchCandidateQueueWriterCliReviewBody || !mcpFetchCandidateQueueWriterCliReviewInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterCliReviewInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterCliReviewMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterCliReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterCliReviewBody.innerHTML = '
審核 MCP Writer CLI Review 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterCliReviewEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_cli_review_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterCliReviewMeta(data); + renderMcpFetchCandidateQueueWriterCliReviewBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterCliReviewMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterCliReviewBody.innerHTML = `
MCP Writer CLI Review 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -13456,6 +13617,12 @@ if (mcpFetchCandidateQueueWriterPreflightReview) { mcpFetchCandidateQueueWriterPreflightReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterPreflight); } + if (mcpFetchCandidateQueueWriterCliReviewRefresh) { + mcpFetchCandidateQueueWriterCliReviewRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterCliReview); + } + if (mcpFetchCandidateQueueWriterCliReviewReview) { + mcpFetchCandidateQueueWriterCliReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterCliReview); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -13722,6 +13889,7 @@ loadMcpFetchCandidateHandoffReview(); loadMcpFetchCandidateQueueReview(); loadMcpFetchCandidateQueueWriterPreflight(); + loadMcpFetchCandidateQueueWriterCliReview(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 2ba1a01..fd851a8 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -41,6 +41,9 @@ from services.market_intel.mcp_fetch_candidate_queue_review import ( from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( build_mcp_fetch_candidate_queue_writer_preflight_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( + build_mcp_fetch_candidate_queue_writer_cli_review_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1049,6 +1052,31 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-preflight-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_cli_review" + in template + ) + assert "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review" in template + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-preflight" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-command" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-payload" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1519,7 +1547,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert bridge["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1677,7 +1705,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert contract["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1810,7 +1838,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1823,7 +1851,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert gate["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1893,7 +1921,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1907,7 +1935,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert audit["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -1981,7 +2009,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -1998,11 +2026,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert evidence["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2027,7 +2055,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2085,12 +2113,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2099,11 +2127,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert receipt["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2131,7 +2159,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2196,12 +2224,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2210,11 +2238,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert promotion["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2242,7 +2270,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2302,12 +2330,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2316,11 +2344,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2348,7 +2376,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2410,12 +2438,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2426,11 +2454,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2460,7 +2488,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2538,13 +2566,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2556,11 +2584,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert package["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2592,7 +2620,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2667,13 +2695,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2687,11 +2715,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert readiness["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2726,11 +2754,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert readiness["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2806,13 +2834,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2826,11 +2854,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert receipt["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -2867,11 +2895,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert receipt["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -2950,13 +2978,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -2972,11 +3000,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert parser["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3015,11 +3043,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert parser["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3104,13 +3132,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3126,11 +3154,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3169,11 +3197,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3263,13 +3291,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3286,11 +3314,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3327,11 +3355,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3422,13 +3450,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3444,13 +3472,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3488,13 +3516,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight", + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3598,7 +3626,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3607,7 +3635,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3621,11 +3649,186 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["api_uses_external_network"] is False +def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): + review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + ) + + assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" + assert ( + review["phase"] + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + ) + assert review["writer_cli_review_payload_received"] is False + assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False + assert review["candidate_queue_writer_cli_review_ready"] is False + assert review["ready_for_candidate_queue_writer_run_package_review"] is False + assert review["ready_for_api_database_write"] is False + assert review["ready_for_real_write"] is False + assert review["ready_for_scheduler_attach"] is False + assert review["network_request_allowed"] is False + assert review["api_executes_cli"] is False + assert review["api_reads_approval_token"] is False + assert review["api_opens_database_connection"] is False + assert review["api_writes_database"] is False + assert review["cli_executed"] is False + assert review["payload_persisted"] is False + assert review["cli_review_persisted"] is False + assert review["package_artifact_created"] is False + assert review["file_written"] is False + assert review["database_write_executed"] is False + assert review["scheduler_attached"] is False + assert "writer_preflight_payload_or_result_received" in review["blocked_reasons"] + assert "writer_cli_review_payload_received" in review["blocked_reasons"] + assert "writer_preflight_package" in review["sample_writer_cli_review_package"] + assert "writer_cli_review" in review["sample_writer_cli_review_package"] + + +def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): + sample = ( + build_mcp_fetch_candidate_queue_writer_cli_review_preview() + ["sample_writer_cli_review_package"] + ) + review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( + writer_preflight_package=sample["writer_preflight_package"], + writer_preflight_result=sample["writer_preflight_result"], + writer_cli_review=sample["writer_cli_review"], + phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + ) + + assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" + assert ( + review["phase"] + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + ) + assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True + assert review["candidate_queue_writer_cli_review_ready"] is True + assert review["ready_for_candidate_queue_writer_run_package_review"] is True + assert review["ready_for_api_database_write"] is False + assert review["ready_for_real_write"] is False + assert review["blocked_reasons"] == [] + assert review["passed_gate_count"] == review["gate_count"] + assert review["writer_preflight_accepted"] is True + summary = review["writer_cli_review_summary"] + assert summary["script_path"] == "scripts/market_intel_candidate_queue_writer.py" + assert summary["target_table"] == "market_alert_review_queue" + assert summary["command_mode"] == "manual_shell_review_only" + assert summary["required_safe_flags_present"] is True + assert summary["forbidden_command_flags_absent"] is True + assert summary["candidate_keys_unique"] is True + assert summary["dedupe_keys_unique"] is True + assert summary["raw_payload_submitted_to_api"] is False + assert summary["secret_or_token_submitted_to_api"] is False + assert summary["blocked_side_effects"] == [] + assert review["network_request_allowed"] is False + assert review["api_executes_cli"] is False + assert review["api_reads_approval_token"] is False + assert review["cli_executed"] is False + assert review["api_writes_file"] is False + assert review["candidate_queue_persisted"] is False + assert review["database_write_executed"] is False + assert review["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_cli_review_blocks_unsafe_review(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_cli_review_preview() + ["sample_writer_cli_review_package"] + ) + ) + cli_review = sample["writer_cli_review"] + cli_review["script_path"] = "scripts/unsafe.py" + cli_review["target_table"] = "market_campaign_products" + cli_review["approval_token"] = "do-not-submit" + cli_review["raw_html"] = "raw" + cli_review["api_executes_cli"] = True + cli_review["api_execution_allowed"] = True + cli_review["real_write_allowed"] = True + cli_review["operator_confirmed_no_api_cli_execution"] = False + cli_review["command_argv_preview"].extend( + ["--execute", "--apply-real-write", "--approval-token", "secret"] + ) + cli_review["expected_candidate_keys"].pop() + + review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( + writer_preflight_package=sample["writer_preflight_package"], + writer_preflight_result=sample["writer_preflight_result"], + writer_cli_review=cli_review, + ) + + assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False + assert review["writer_preflight_accepted"] is True + assert "writer_cli_script_path_safe" in review["blocked_reasons"] + assert "writer_cli_target_table_safe" in review["blocked_reasons"] + assert "writer_cli_candidate_keys_match_preflight" in review["blocked_reasons"] + assert "writer_cli_forbidden_write_flags_absent" in review["blocked_reasons"] + assert "writer_cli_operator_boundaries_confirmed" in review["blocked_reasons"] + assert "writer_cli_no_api_execution_or_real_write" in review["blocked_reasons"] + assert "writer_cli_no_raw_payload" in review["blocked_reasons"] + assert "writer_cli_no_secret_or_token_key" in review["blocked_reasons"] + assert "writer_cli_side_effect_free" in review["blocked_reasons"] + assert review["api_executes_cli"] is False + assert review["api_reads_approval_token"] is False + assert review["api_writes_database"] is False + assert review["candidate_queue_persisted"] is False + assert review["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_cli_review_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review", + json={"writer_cli_review_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" + assert ( + get_data["phase"] + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" + assert ( + post_data["phase"] + == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + ) + assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True + assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -3673,7 +3876,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -3684,7 +3887,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert acceptance["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -3726,7 +3929,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -3738,7 +3941,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -3849,7 +4052,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -3888,7 +4091,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -3950,7 +4153,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -4030,7 +4233,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -4094,7 +4297,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -4153,7 +4356,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert queue_draft["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -4227,7 +4430,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -4290,7 +4493,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert approval["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -4368,7 +4571,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -4431,7 +4634,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert transaction["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -4511,7 +4714,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -10222,7 +10425,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10297,7 +10500,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -10569,7 +10772,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10857,7 +11060,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -11167,7 +11370,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -11470,7 +11673,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -11729,7 +11932,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -12002,7 +12205,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -12250,7 +12453,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -12480,7 +12683,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -12717,7 +12920,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -12959,7 +13162,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -13235,7 +13438,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -13512,7 +13715,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -13791,7 +13994,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -14120,7 +14323,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -14382,7 +14585,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -14646,7 +14849,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -14916,7 +15119,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -15204,7 +15407,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -15491,7 +15694,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -15577,7 +15780,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15634,7 +15837,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15723,7 +15926,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15777,7 +15980,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -15833,7 +16036,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -15899,7 +16102,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -16201,7 +16404,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -16249,7 +16452,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -16298,7 +16501,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -16356,7 +16559,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -16422,7 +16625,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -16493,7 +16696,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -16569,7 +16772,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -16651,7 +16854,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -16737,7 +16940,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -16820,7 +17023,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16903,7 +17106,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -16989,7 +17192,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -17080,7 +17283,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -17190,7 +17393,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17276,7 +17479,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17333,7 +17536,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17386,7 +17589,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17439,7 +17642,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17500,7 +17703,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17569,7 +17772,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17641,7 +17844,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -17714,7 +17917,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -17785,7 +17988,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -17850,7 +18053,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -17921,7 +18124,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -17994,7 +18197,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -18071,7 +18274,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -18148,7 +18351,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -18225,7 +18428,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -18299,7 +18502,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -18378,7 +18581,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -18465,7 +18668,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -18546,7 +18749,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -18628,7 +18831,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -18711,7 +18914,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -18736,7 +18939,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -18774,7 +18977,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -18785,7 +18988,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -18821,7 +19024,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -18832,7 +19035,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -18873,7 +19076,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -18884,7 +19087,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -18932,7 +19135,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -18944,7 +19147,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -18990,7 +19193,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -19003,7 +19206,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -19088,7 +19291,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -19166,7 +19369,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -19181,7 +19384,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert readiness["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -19586,6 +19789,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_cli_review_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -24006,7 +24215,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert drill["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -24121,7 +24330,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -24133,7 +24342,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -24248,7 +24457,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -24261,7 +24470,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert smoke["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -24323,7 +24532,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -24336,7 +24545,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert inventory["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -24480,7 +24689,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -24716,7 +24925,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -24745,7 +24954,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_128_market_intel_mcp_fetch_candidate_queue_writer_preflight" + assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False