From 8bffd0307d960b9ccfcd2fe72270f024d74160f8 Mon Sep 17 00:00:00 2001 From: OoO Date: Thu, 21 May 2026 11:16:10 +0800 Subject: [PATCH] [V10.357] add market intel MCP completion audit --- TODO_NEXT_STEPS.txt | 1 + config.py | 2 +- docs/memory/history_logs.md | 4 + routes/market_intel_routes.py | 6 + services/market_intel/deployment_readiness.py | 13 +- services/market_intel/mcp_completion_audit.py | 319 ++++++++++++++++++ services/market_intel/phase.py | 2 +- services/market_intel/service.py | 12 +- templates/market_intel/disabled.html | 128 ++++++- tests/test_market_intel_skeleton.py | 319 ++++++++++++------ 10 files changed, 690 insertions(+), 116 deletions(-) create mode 100644 services/market_intel/mcp_completion_audit.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index d3ea833..5a44349 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.357 補市場情報 MCP 完整度稽核：新增 `mcp_completion_audit` read-only builder、GET endpoint、UI 面板與 deployment readiness smoke target，彙整外部 MCP design/runtime、內部 tool contract/runtime、activation runbook 與 fetch gate 狀態；API/UI 不啟動 MCP、不打 health、不執行 docker/SSH、不開 DB、不寫檔、不抓外站、不掛 scheduler。 - V10.356 補市場情報 candidate queue review AI summary Telegram dispatch report catalog record final closeout gate：新增 read-only report catalog record final closeout builder、POST endpoint、UI 按鈕與 deployment readiness smoke target，在 archive summary gate 後覆核 catalog record identity、artifact traceability、sections、DB commit/post-write smoke、pipeline complete 與無後續 follow-up；API/UI 不讀 approval/Telegram token、不呼叫 LLM、不產報表、不派送 Telegram、不開 DB、不寫檔、不執行 CLI、不寫 catalog record、不 commit、不更新 review_state、不掛 scheduler。 - V10.355 補市場情報 candidate queue review AI summary Telegram dispatch report catalog record archive summary gate：新增 read-only report catalog record archive summary builder、POST endpoint、UI 按鈕與 deployment readiness smoke target，在 archive gate 後整理 catalog record identity、artifact traceability、DB commit/post-write smoke、archive manifest/retention policy 與後續 final closeout separate gate；API/UI 不讀 approval/Telegram token、不呼叫 LLM、不產報表、不派送 Telegram、不開 DB、不寫檔、不執行 CLI、不寫 catalog record、不 commit、不更新 review_state、不掛 scheduler。 - V10.354 補市場情報 candidate queue review AI summary Telegram dispatch report catalog record archive gate：新增 read-only report catalog record archive builder、POST endpoint、UI 按鈕與 deployment readiness smoke target，在 closeout gate 後審核 closeout/commit/run receipt/writer output/post-write smoke/backup 封存證據、archive manifest/retention policy 與後續 archive summary separate gate；API/UI 不讀 approval/Telegram token、不呼叫 LLM、不產報表、不派送 Telegram、不開 DB、不寫檔、不執行 CLI、不寫 catalog record、不 commit、不更新 review_state、不掛 scheduler。 diff --git a/config.py b/config.py index 62edb28..a8bff74 100644 --- a/config.py +++ b/config.py @@ -323,7 +323,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.356" +SYSTEM_VERSION = "V10.357" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 026b4a1..0c5b90c 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -12,6 +12,10 @@ ## 📅 詳細更新日誌 (考古存檔) +### 2026-05-21：市場情報 MCP 完整度稽核 +- **V10.357 MCP completion audit**: 新增 `mcp_completion_audit` read-only builder、GET endpoint、UI 面板與 deployment readiness smoke target，彙整外部 MCP design/runtime、內部 tool contract/runtime、activation runbook 與 fetch gate 狀態。 +- **只讀安全邊界**: 本階段只做完整度稽核，不啟動 MCP、不打 health、不執行 docker/SSH、不開 DB、不寫檔、不抓外站、不掛 scheduler；外部 MCP runtime complete 仍需 operator 依 runbook 啟用與 health 驗證。 + ### 2026-05-21：市場情報 Telegram dispatch report catalog record final closeout gate - **V10.356 report catalog record final closeout gate**: 新增 `candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout` service、POST endpoint、UI 按鈕與 deployment readiness smoke target，在 archive summary gate 後覆核 catalog record identity、artifact traceability、sections、DB commit/post-write smoke、pipeline complete 與無後續 follow-up。 - **只讀安全邊界**: 本階段是 catalog record pipeline terminal preview；API/UI 不讀 approval/Telegram token、不呼叫 LLM、不產報表、不派送 Telegram、不開 DB、不寫檔、不執行 CLI、不寫 catalog record、不 commit、不更新 `review_state`、不掛 scheduler。 diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index 4881174..547c26a 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -160,6 +160,12 @@ def market_intel_mcp_fetch_gate(): ) +@market_intel_bp.route("/api/market_intel/mcp_completion_audit") +@login_required +def market_intel_mcp_completion_audit(): + return jsonify(_service().build_mcp_completion_audit()) + + @market_intel_bp.route("/api/market_intel/scheduler_plan") @login_required def market_intel_scheduler_plan(): diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 5b15815..3bd36ba 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -111,7 +111,7 @@ BLOCKED_RUN_REVIEW_KEYS = ( "writes_executed", "would_write_database", ) -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/mcp_completion_audit", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") PRODUCTION_SMOKE_TARGETS = ( PRODUCTION_SMOKE_TARGETS[:-1] + ( @@ -146,6 +146,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s mcp_deploy_preflight = service.build_mcp_deploy_preflight() mcp_activation_runbook = service.build_mcp_activation_runbook() mcp_fetch_gate = service.build_mcp_fetch_gate() + mcp_completion_audit = service.build_mcp_completion_audit() scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -361,6 +362,15 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_fetch_gate["network_request_allowed"] and not mcp_fetch_gate["external_network_executed"] ), + "mcp_completion_audit_preview_safe": bool( + mcp_completion_audit["mode"] == "mcp_completion_audit_preview" + and mcp_completion_audit["audit_preview_safe"] + and not mcp_completion_audit["api_executes_health_check"] + and not mcp_completion_audit["api_executes_docker"] + and not mcp_completion_audit["api_opens_database_connection"] + and not mcp_completion_audit["api_writes_database"] + and not mcp_completion_audit["api_uses_external_network"] + ), "scheduler_plan_preview_safe": bool( scheduler_plan["mode"] == "scheduler_attach_plan_preview" and not scheduler_plan["scheduler_registration_executed"] @@ -791,6 +801,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_deploy_preflight": mcp_deploy_preflight, "mcp_activation_runbook": mcp_activation_runbook, "mcp_fetch_gate": mcp_fetch_gate, + "mcp_completion_audit": mcp_completion_audit, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_completion_audit.py b/services/market_intel/mcp_completion_audit.py new file mode 100644 index 0000000..5c5bd3e --- /dev/null +++ b/services/market_intel/mcp_completion_audit.py @@ -0,0 +1,319 @@ +"""市場情報 MCP 完整度稽核 preview。 + +本模組只彙整既有 MCP readiness、tool contract、deploy preflight、activation +runbook 與 fetch gate；不呼叫 MCP server、不執行 docker/SSH、不連 DB、不寫入。 +""" + +from services.market_intel.mcp_activation_runbook import ( + build_mcp_activation_runbook_preview, +) +from services.market_intel.mcp_contract import build_mcp_tool_contract_preview +from services.market_intel.mcp_deploy_preflight import build_mcp_deploy_preflight_plan +from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview +from services.market_intel.mcp_readiness import ( + EXPECTED_EXTERNAL_SERVERS, + build_mcp_readiness_plan, +) + + +def _blocked_reasons(gates): + return [item["key"] for item in gates if not item["passed"]] + + +def _none_executed(payload, keys): + return all(not payload.get(key) for key in keys) + + +def build_mcp_completion_audit_preview( + *, + runtime_status, + readiness=None, + tool_contract=None, + deploy_preflight=None, + activation_runbook=None, + fetch_gate=None, +): + """建立 MCP 外部/內部完整度稽核；預設全程 read-only planned preview。""" + readiness = readiness or build_mcp_readiness_plan(execute_requested=False) + tool_contract = tool_contract or build_mcp_tool_contract_preview() + deploy_preflight = deploy_preflight or build_mcp_deploy_preflight_plan() + activation_runbook = activation_runbook or build_mcp_activation_runbook_preview( + preflight=deploy_preflight, + readiness=readiness, + ) + fetch_gate = fetch_gate or build_mcp_fetch_gate_preview( + runtime_status, + fetch_requested=False, + execute_readiness=False, + readiness=readiness, + ) + + external_design_checks = { + "expected_servers_declared": set(EXPECTED_EXTERNAL_SERVERS) + <= {item.get("server") for item in readiness.get("server_statuses", [])}, + "compose_file_present": bool( + deploy_preflight.get("checks", {}).get("compose_file_present") + ), + "expected_services_declared": bool( + deploy_preflight.get("checks", {}).get("all_expected_services_declared") + ), + "expected_containers_declared": bool( + deploy_preflight.get("checks", {}).get("all_expected_containers_declared") + ), + "localhost_ports_only": bool( + deploy_preflight.get("checks", {}).get( + "all_public_mcp_ports_localhost_only" + ) + ), + "readonly_postgres_design": bool( + deploy_preflight.get("checks", {}).get("postgres_readonly_role_required") + and deploy_preflight.get("checks", {}).get( + "postgres_allowed_tables_limited" + ) + ), + "readonly_filesystem_mounts": bool( + deploy_preflight.get("checks", {}).get("filesystem_mounts_read_only") + ), + } + external_design_complete = all(external_design_checks.values()) + external_runtime_complete = bool(readiness.get("external_mcp_complete")) + internal_contract_complete = bool(tool_contract.get("contract_ready")) + internal_runtime_complete = bool(readiness.get("internal_mcp_complete")) + market_intel_mcp_integrated = bool(readiness.get("market_intel_mcp_integrated")) + activation_runbook_present = bool( + activation_runbook.get("mode") == "mcp_activation_runbook_preview" + and activation_runbook.get("stages") + ) + fetch_gate_present = bool(fetch_gate.get("mode") == "mcp_fetch_gate_planned") + preview_side_effect_free = bool( + _none_executed( + readiness, + ( + "database_session_created", + "database_write_executed", + "database_commit_executed", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ), + ) + and _none_executed( + tool_contract, + ( + "database_session_created", + "database_write_executed", + "database_commit_executed", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ), + ) + and _none_executed( + deploy_preflight, + ( + "deployment_actions_executed", + "docker_command_executed", + "ssh_command_executed", + "database_session_created", + "database_write_executed", + "database_commit_executed", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ), + ) + and _none_executed( + activation_runbook, + ( + "deployment_actions_executed", + "docker_command_executed", + "ssh_command_executed", + "database_session_created", + "database_write_executed", + "database_commit_executed", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ), + ) + and _none_executed( + fetch_gate, + ( + "network_request_allowed", + "database_session_created", + "database_write_executed", + "database_commit_executed", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ), + ) + ) + + gates = [ + { + "key": "external_mcp_design_complete", + "passed": external_design_complete, + "label": "外部 MCP compose、localhost port、唯讀邊界與 server 清單已定義", + }, + { + "key": "external_mcp_runtime_complete", + "passed": external_runtime_complete, + "label": "外部 MCP health 已執行且 router 已啟用", + }, + { + "key": "internal_mcp_contract_complete", + "passed": internal_contract_complete, + "label": "market_intel 內部 MCP tool contract 已被 router 白名單覆蓋", + }, + { + "key": "internal_mcp_runtime_complete", + "passed": internal_runtime_complete, + "label": "mcp_calls telemetry / read-only 查詢鏈路已在執行態確認", + }, + { + "key": "market_intel_mcp_integrated", + "passed": market_intel_mcp_integrated, + "label": "市場情報呼叫端已納入 MCP registry", + }, + { + "key": "activation_runbook_present", + "passed": activation_runbook_present, + "label": "外部 MCP 啟用順序、health gate 與 fallback 已建立", + }, + { + "key": "manual_fetch_gate_present", + "passed": fetch_gate_present, + "label": "人工 fetch 安全閘門已建立且預設關閉", + }, + { + "key": "preview_side_effect_free", + "passed": preview_side_effect_free, + "label": "本 API 不啟動 MCP、不連 DB、不寫入、不抓外站", + }, + ] + passed_gate_count = sum(1 for item in gates if item["passed"]) + + return { + "mode": "mcp_completion_audit_preview", + "audit_ready_for_operator_review": True, + "audit_preview_safe": preview_side_effect_free, + "overall_mcp_completion_percent": round(passed_gate_count / len(gates) * 100), + "external_mcp_complete": external_runtime_complete, + "external_mcp_design_complete": external_design_complete, + "external_mcp_runtime_complete": external_runtime_complete, + "internal_mcp_complete": internal_runtime_complete, + "internal_mcp_contract_complete": internal_contract_complete, + "internal_mcp_runtime_complete": internal_runtime_complete, + "market_intel_mcp_integrated": market_intel_mcp_integrated, + "ready_for_external_mcp_activation": bool( + activation_runbook.get("ready_for_operator_activation") + ), + "ready_for_internal_mcp_use": bool( + internal_contract_complete and market_intel_mcp_integrated + ), + "ready_for_manual_fetch": bool(fetch_gate.get("manual_fetch_gate_open")), + "gates": gates, + "blocked_reasons": _blocked_reasons(gates), + "external_mcp_summary": { + "expected_servers": list(EXPECTED_EXTERNAL_SERVERS), + "configured_servers": [ + item["server"] + for item in readiness.get("server_statuses", []) + if item.get("configured") + ], + "health_checked": bool(readiness.get("execute_requested")), + "router_enabled": bool(readiness.get("router_enabled")), + "design_checks": external_design_checks, + "runtime_blocked_reasons": readiness.get("blocked_reasons", []), + }, + "internal_mcp_summary": { + "caller": tool_contract.get("caller"), + "tool_count": int(tool_contract.get("tool_count") or 0), + "expected_tool_names": tool_contract.get("expected_tool_names", []), + "contract_ready": internal_contract_complete, + "telemetry_mode": readiness.get("telemetry", {}).get("mode"), + "telemetry_table_exists": bool( + readiness.get("telemetry", {}).get("table_exists") + ), + "read_only_query_executed": bool( + readiness.get("telemetry", {}).get("read_only_query_executed") + ), + }, + "activation_summary": { + "mode": activation_runbook.get("mode"), + "ready_for_operator_activation": bool( + activation_runbook.get("ready_for_operator_activation") + ), + "stage_count": len(activation_runbook.get("stages", [])), + "blocked_reasons": activation_runbook.get("blocked_reasons", []), + "fallback_count": len(activation_runbook.get("fallback_plan", [])), + }, + "fetch_gate_summary": { + "mode": fetch_gate.get("mode"), + "manual_fetch_gate_open": bool(fetch_gate.get("manual_fetch_gate_open")), + "network_request_allowed": bool(fetch_gate.get("network_request_allowed")), + "blocked_reasons": fetch_gate.get("blocked_reasons", []), + }, + "next_operator_steps": [ + "補齊外部 MCP 必要 env 後，再由操作員依 runbook 啟動 docker-compose.mcp.yml", + "四個 localhost health endpoint 全部 200 後，才允許開 MCP_ROUTER_ENABLED", + "router 開啟後以 execute=true 跑 read-only MCP readiness smoke", + "人工 fetch 仍需先通過 MCP fetch gate，且不得寫 DB 或掛 scheduler", + ], + "mcp_readiness": readiness, + "mcp_tool_contract": tool_contract, + "mcp_deploy_preflight": deploy_preflight, + "mcp_activation_runbook": activation_runbook, + "mcp_fetch_gate": fetch_gate, + "api_executes_health_check": False, + "api_executes_docker": False, + "api_executes_ssh": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "database_session_created": False, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + } + + +def build_mcp_completion_audit_for_runtime(*, runtime_status, phase): + """以 service runtime 狀態組裝完整度稽核，並在子 payload 標記 phase。""" + readiness = build_mcp_readiness_plan(execute_requested=False) + readiness["phase"] = phase + tool_contract = build_mcp_tool_contract_preview() + tool_contract["phase"] = phase + deploy_preflight = build_mcp_deploy_preflight_plan() + deploy_preflight["phase"] = phase + activation_runbook = build_mcp_activation_runbook_preview( + preflight=deploy_preflight, + readiness=readiness, + ) + activation_runbook["phase"] = phase + fetch_gate = build_mcp_fetch_gate_preview( + runtime_status, + fetch_requested=False, + execute_readiness=False, + readiness=readiness, + ) + fetch_gate["phase"] = phase + audit = build_mcp_completion_audit_preview( + runtime_status=runtime_status, + readiness=readiness, + tool_contract=tool_contract, + deploy_preflight=deploy_preflight, + activation_runbook=activation_runbook, + fetch_gate=fetch_gate, + ) + audit["phase"] = phase + return audit diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 504ebe5..1afd5e0 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" +MARKET_INTEL_PHASE = "phase_116_market_intel_mcp_completion_audit" diff --git a/services/market_intel/service.py b/services/market_intel/service.py index 0552919..fe894d0 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -26,6 +26,7 @@ from services.market_intel.legacy_source_bridge import build_legacy_source_bridg from services.market_intel.live_db_inventory import build_live_db_inventory_preview from services.market_intel.match_review_plan import build_match_review_plan_preview from services.market_intel.mcp_activation_runbook import build_mcp_activation_runbook_preview +from services.market_intel.mcp_completion_audit import build_mcp_completion_audit_for_runtime from services.market_intel.mcp_contract import build_mcp_tool_contract_preview from services.market_intel.mcp_deploy_preflight import build_mcp_deploy_preflight_plan from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview @@ -384,7 +385,6 @@ class MarketIntelService: database_url=None, database_type=None, ): - """回報市場情報 MCP 整合就緒度；預設不連 MCP server、不查 DB。""" readiness = build_mcp_readiness_plan( execute_requested=execute_requested, timeout_sec=timeout_sec, @@ -396,19 +396,16 @@ class MarketIntelService: return readiness def build_mcp_tool_contract(self): - """回報市場情報內部 MCP tool contract；不呼叫 MCP、不查 DB。""" contract = build_mcp_tool_contract_preview() contract["phase"] = self.phase return contract def build_mcp_deploy_preflight(self): - """回報外部 MCP stack 部署前檢查；不執行 docker/SSH/DB。""" preflight = build_mcp_deploy_preflight_plan() preflight["phase"] = self.phase return preflight def build_mcp_activation_runbook(self): - """回報 MCP 啟用順序與 gate；不執行任何啟用動作。""" preflight = self.build_mcp_deploy_preflight() readiness = self.build_mcp_readiness() runbook = build_mcp_activation_runbook_preview( @@ -419,7 +416,6 @@ class MarketIntelService: return runbook def build_mcp_fetch_gate(self, *, fetch_requested=False, execute_readiness=False): - """回報人工 fetch 前的 MCP gate；不抓電商頁、不寫 DB。""" gate = build_mcp_fetch_gate_preview( self.get_runtime_status(), fetch_requested=fetch_requested, @@ -428,6 +424,12 @@ class MarketIntelService: gate["phase"] = self.phase return gate + def build_mcp_completion_audit(self): + return build_mcp_completion_audit_for_runtime( + runtime_status=self.get_runtime_status(), + phase=self.phase, + ) + def build_scheduler_plan(self): """回報市場情報排程掛載計畫；不註冊 job、不啟動 crawler。""" plan = build_scheduler_attach_plan( diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index f17199a..e67cc86 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -534,6 +534,24 @@ +
+
+
+

MCP / COMPLETION AUDIT

+

MCP 完整度稽核

+
+ +
+
+ loading +
+
+
讀取 MCP 完整度稽核中...
+
+
+
@@ -1037,6 +1055,7 @@ const mcpPreflightRoot = document.querySelector('[data-market-intel-mcp-preflight]'); const mcpActivationRoot = document.querySelector('[data-market-intel-mcp-activation]'); const mcpFetchGateRoot = document.querySelector('[data-market-intel-mcp-fetch-gate]'); + const mcpCompletionRoot = document.querySelector('[data-market-intel-mcp-completion]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1053,7 +1072,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1096,6 +1115,10 @@ const mcpFetchGateBody = mcpFetchGateRoot ? mcpFetchGateRoot.querySelector('[data-market-intel-mcp-fetch-gate-body]') : null; const mcpFetchGateRefresh = mcpFetchGateRoot ? mcpFetchGateRoot.querySelector('[data-market-intel-mcp-fetch-gate-refresh]') : null; const mcpFetchGateEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_gate') }}?fetch=false&execute=false"; + const mcpCompletionMeta = mcpCompletionRoot ? mcpCompletionRoot.querySelector('[data-market-intel-mcp-completion-meta]') : null; + const mcpCompletionBody = mcpCompletionRoot ? mcpCompletionRoot.querySelector('[data-market-intel-mcp-completion-body]') : null; + const mcpCompletionRefresh = mcpCompletionRoot ? mcpCompletionRoot.querySelector('[data-market-intel-mcp-completion-refresh]') : null; + const mcpCompletionEndpoint = "{{ url_for('market_intel.market_intel_mcp_completion_audit') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -1984,6 +2007,105 @@ } }; + const renderMcpCompletionMeta = data => { + mcpCompletionMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `progress=${data.overall_mcp_completion_percent || 0}%`, + `external=${data.external_mcp_runtime_complete ? 'runtime' : data.external_mcp_design_complete ? 'design' : 'pending'}`, + `internal=${data.internal_mcp_contract_complete ? 'contract' : 'pending'}`, + `fetch=${data.ready_for_manual_fetch ? 'open' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpCompletionBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const external = data.external_mcp_summary || {}; + const internal = data.internal_mcp_summary || {}; + const activation = data.activation_summary || {}; + const fetchGate = data.fetch_gate_summary || {}; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + + mcpCompletionBody.innerHTML = ` +
這份稽核只彙整 MCP 外部 stack、內部 tool contract、啟用 runbook 與 fetch gate；不啟動 MCP、不打 health、不連 DB、不抓外站。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

COMPLETION GATES

+
${ + gates.length + ? gates.map(item => renderCheck( + item.key, + item.label, + item.passed ? 'PASS' : 'BLOCK' + )).join('') + : '
尚未提供完整度 gate。
' + }
+
+
+

MCP SUMMARY

+
+ ${renderCheck( + 'external_mcp', + `${(external.expected_servers || []).join(' / ')} / router=${external.router_enabled ? 'on' : 'off'} / health=${external.health_checked ? 'checked' : 'planned'}`, + data.external_mcp_runtime_complete ? 'RUNTIME READY' : data.external_mcp_design_complete ? 'DESIGN READY' : 'PENDING' + )} + ${renderCheck( + 'internal_mcp', + `${internal.caller || 'market_intel'} / tools=${internal.tool_count || 0} / telemetry=${internal.telemetry_mode || 'unknown'}`, + data.internal_mcp_contract_complete ? 'CONTRACT READY' : 'PENDING' + )} + ${renderCheck( + 'activation', + `${activation.stage_count || 0} stages / fallback=${activation.fallback_count || 0}`, + activation.ready_for_operator_activation ? 'READY' : 'BLOCKED' + )} + ${renderCheck( + 'fetch_gate', + `${fetchGate.mode || 'unknown'} / network=${fetchGate.network_request_allowed ? 'allow' : 'block'}`, + fetchGate.manual_fetch_gate_open ? 'OPEN' : 'CLOSED' + )} +
+
+
+

NEXT OPERATOR STEPS

+
${ + steps.length + ? steps.map((item, index) => renderCheck( + `step_${index + 1}`, + item, + 'MANUAL' + )).join('') + : '
尚未提供後續步驟。
' + }
+
+
+ `; + }; + + const loadMcpCompletion = async () => { + if (!mcpCompletionMeta || !mcpCompletionBody) return; + mcpCompletionBody.innerHTML = '
讀取 MCP 完整度稽核中...
'; + try { + const response = await fetch(mcpCompletionEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpCompletionMeta(data); + renderMcpCompletionBody(data); + } catch (error) { + mcpCompletionMeta.innerHTML = 'error'; + mcpCompletionBody.innerHTML = `
MCP 完整度稽核讀取失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -11384,6 +11506,9 @@ if (mcpFetchGateRefresh) { mcpFetchGateRefresh.addEventListener('click', loadMcpFetchGate); } + if (mcpCompletionRefresh) { + mcpCompletionRefresh.addEventListener('click', loadMcpCompletion); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -11637,6 +11762,7 @@ loadMcpPreflight(); loadMcpActivation(); loadMcpFetchGate(); + loadMcpCompletion(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 2c62328..98eeaba 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -15,6 +15,7 @@ from services.market_intel.candidate_preview import build_candidate_preview_from from services.market_intel.discovery_runner import ManualDiscoveryRunner from services.market_intel.html_diagnostics import parse_html_diagnostics from services.market_intel.mcp_activation_runbook import build_mcp_activation_runbook_preview +from services.market_intel.mcp_completion_audit import build_mcp_completion_audit_preview from services.market_intel.mcp_contract import build_mcp_tool_contract_preview from services.market_intel.mcp_deploy_preflight import build_mcp_deploy_preflight_plan from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview @@ -937,6 +938,8 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "market_intel.market_intel_mcp_deploy_preflight" in template assert "market_intel.market_intel_mcp_activation_runbook" in template assert "market_intel.market_intel_mcp_fetch_gate" in template + assert "market_intel.market_intel_mcp_completion_audit" in template + assert "data-market-intel-mcp-completion" in template assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1407,7 +1410,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert bridge["phase"] == "phase_116_market_intel_mcp_completion_audit" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1565,7 +1568,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert contract["phase"] == "phase_116_market_intel_mcp_completion_audit" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1698,7 +1701,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1711,7 +1714,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert gate["phase"] == "phase_116_market_intel_mcp_completion_audit" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1781,7 +1784,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1789,11 +1792,106 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert data["scheduler_attached"] is False +def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch): + monkeypatch.delenv("MCP_ROUTER_ENABLED", raising=False) + + audit = MarketIntelService().build_mcp_completion_audit() + + assert audit["mode"] == "mcp_completion_audit_preview" + assert audit["phase"] == "phase_116_market_intel_mcp_completion_audit" + assert audit["audit_ready_for_operator_review"] is True + assert audit["audit_preview_safe"] is True + assert audit["external_mcp_runtime_complete"] is False + assert audit["internal_mcp_contract_complete"] is True + assert audit["internal_mcp_runtime_complete"] is False + assert audit["market_intel_mcp_integrated"] is True + assert audit["ready_for_internal_mcp_use"] is True + assert audit["ready_for_external_mcp_activation"] is False + assert audit["ready_for_manual_fetch"] is False + assert audit["api_executes_health_check"] is False + assert audit["api_executes_docker"] is False + assert audit["api_opens_database_connection"] is False + assert audit["api_writes_database"] is False + assert audit["api_uses_external_network"] is False + assert audit["database_session_created"] is False + assert audit["database_write_executed"] is False + assert audit["database_commit_executed"] is False + assert audit["external_network_executed"] is False + assert audit["scheduler_attached"] is False + assert audit["writes_executed"] is False + assert audit["would_write_database"] is False + assert audit["external_mcp_summary"]["expected_servers"] == [ + "postgres", + "omnisearch", + "firecrawl", + "filesystem", + ] + assert audit["external_mcp_summary"]["health_checked"] is False + assert audit["internal_mcp_summary"]["tool_count"] == 3 + assert audit["internal_mcp_summary"]["contract_ready"] is True + assert "external_mcp_runtime_complete" in audit["blocked_reasons"] + assert "internal_mcp_runtime_complete" in audit["blocked_reasons"] + assert "preview_side_effect_free" not in audit["blocked_reasons"] + + +def test_mcp_completion_audit_detects_missing_internal_contract(): + class RuntimeStatus: + enabled = False + crawler_enabled = False + database_write_allowed = False + scheduler_attached = False + + readiness = build_mcp_readiness_plan() + contract = build_mcp_tool_contract_preview(tool_registry={}) + audit = build_mcp_completion_audit_preview( + runtime_status=RuntimeStatus(), + readiness=readiness, + tool_contract=contract, + ) + + assert audit["mode"] == "mcp_completion_audit_preview" + assert audit["internal_mcp_contract_complete"] is False + assert audit["ready_for_internal_mcp_use"] is False + assert "internal_mcp_contract_complete" in audit["blocked_reasons"] + assert audit["audit_preview_safe"] is True + assert audit["api_writes_database"] is False + + +def test_mcp_completion_audit_route_is_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.get("/api/market_intel/mcp_completion_audit") + data = response.get_json() + + assert response.status_code == 200 + assert data["mode"] == "mcp_completion_audit_preview" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" + assert data["audit_preview_safe"] is True + assert data["external_mcp_runtime_complete"] is False + assert data["internal_mcp_contract_complete"] is True + assert data["ready_for_manual_fetch"] is False + assert data["api_executes_health_check"] is False + assert data["api_executes_docker"] is False + assert data["api_opens_database_connection"] is False + assert data["api_writes_database"] is False + assert data["api_uses_external_network"] is False + assert data["external_network_executed"] is False + assert data["database_write_executed"] is False + assert data["scheduler_attached"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1841,7 +1939,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1852,7 +1950,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert acceptance["phase"] == "phase_116_market_intel_mcp_completion_audit" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1894,7 +1992,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1906,7 +2004,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert review["phase"] == "phase_116_market_intel_mcp_completion_audit" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -2017,7 +2115,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -2056,7 +2154,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert review["phase"] == "phase_116_market_intel_mcp_completion_audit" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -2118,7 +2216,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -2198,7 +2296,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert handoff["phase"] == "phase_116_market_intel_mcp_completion_audit" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -2262,7 +2360,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -2321,7 +2419,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert queue_draft["phase"] == "phase_116_market_intel_mcp_completion_audit" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2395,7 +2493,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -2458,7 +2556,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert approval["phase"] == "phase_116_market_intel_mcp_completion_audit" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2536,7 +2634,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2599,7 +2697,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert transaction["phase"] == "phase_116_market_intel_mcp_completion_audit" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2679,7 +2777,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -8390,7 +8488,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -8465,7 +8563,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -8737,7 +8835,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9025,7 +9123,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -9335,7 +9433,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -9638,7 +9736,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -9897,7 +9995,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -10170,7 +10268,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -10418,7 +10516,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -10648,7 +10746,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -10885,7 +10983,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -11127,7 +11225,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -11403,7 +11501,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -11680,7 +11778,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -11959,7 +12057,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -12288,7 +12386,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -12550,7 +12648,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -12814,7 +12912,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -13084,7 +13182,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -13372,7 +13470,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -13659,7 +13757,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -13745,7 +13843,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -13802,7 +13900,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -13891,7 +13989,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -13945,7 +14043,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -14001,7 +14099,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -14067,7 +14165,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -14369,7 +14467,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -14417,7 +14515,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -14466,7 +14564,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -14524,7 +14622,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -14590,7 +14688,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -14661,7 +14759,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -14737,7 +14835,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -14819,7 +14917,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -14905,7 +15003,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -14988,7 +15086,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15071,7 +15169,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -15157,7 +15255,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -15248,7 +15346,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -15358,7 +15456,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -15444,7 +15542,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -15501,7 +15599,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -15554,7 +15652,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -15607,7 +15705,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -15668,7 +15766,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -15737,7 +15835,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -15809,7 +15907,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -15882,7 +15980,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -15953,7 +16051,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -16018,7 +16116,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -16089,7 +16187,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -16162,7 +16260,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -16239,7 +16337,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -16316,7 +16414,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -16393,7 +16491,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -16467,7 +16565,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -16546,7 +16644,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -16633,7 +16731,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -16714,7 +16812,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -16796,7 +16894,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + "phase_116_market_intel_mcp_completion_audit" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -16879,7 +16977,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -16904,7 +17002,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -16942,7 +17040,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -16953,7 +17051,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -16989,7 +17087,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -17000,7 +17098,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -17041,7 +17139,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -17052,7 +17150,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -17100,7 +17198,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -17112,7 +17210,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -17158,7 +17256,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -17171,7 +17269,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert plan["phase"] == "phase_116_market_intel_mcp_completion_audit" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -17256,7 +17354,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -17334,7 +17432,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -17349,7 +17447,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert readiness["phase"] == "phase_116_market_intel_mcp_completion_audit" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -17736,6 +17834,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["mcp_deploy_preflight_preview_safe"] is True assert readiness["checks"]["mcp_activation_runbook_preview_safe"] is True assert readiness["checks"]["mcp_fetch_gate_preview_safe"] is True + assert readiness["checks"]["mcp_completion_audit_preview_safe"] is True assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -18106,6 +18205,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/mcp_deploy_preflight" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_activation_runbook" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_fetch_gate" in readiness["production_smoke_targets"] + assert "/api/market_intel/mcp_completion_audit" in readiness["production_smoke_targets"] assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -18437,6 +18537,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["mcp_activation_runbook"]["docker_command_executed"] is False assert readiness["mcp_fetch_gate"]["network_request_allowed"] is False assert readiness["mcp_fetch_gate"]["external_network_executed"] is False + assert readiness["mcp_completion_audit"]["mode"] == "mcp_completion_audit_preview" + assert readiness["mcp_completion_audit"]["audit_preview_safe"] is True + assert readiness["mcp_completion_audit"]["api_writes_database"] is False + assert readiness["mcp_completion_audit"]["api_uses_external_network"] is False + assert readiness["mcp_completion_audit"]["ready_for_manual_fetch"] is False assert readiness["manual_sample_plan"]["mode"] == "manual_sample_fetch_plan_preview" assert readiness["manual_sample_plan"]["sample_fetch_executed"] is False assert readiness["manual_sample_plan"]["external_network_executed"] is False @@ -22056,7 +22161,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert drill["phase"] == "phase_116_market_intel_mcp_completion_audit" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -22171,7 +22276,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -22183,7 +22288,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert review["phase"] == "phase_116_market_intel_mcp_completion_audit" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -22298,7 +22403,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -22311,7 +22416,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert smoke["phase"] == "phase_116_market_intel_mcp_completion_audit" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -22373,7 +22478,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -22386,7 +22491,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert inventory["phase"] == "phase_116_market_intel_mcp_completion_audit" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -22530,7 +22635,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -22766,7 +22871,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -22795,7 +22900,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_115_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout" + assert data["phase"] == "phase_116_market_intel_mcp_completion_audit" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False