diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 9784a3d..90abd07 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -167,6 +167,7 @@ - Phase 82 candidate queue review AI summary output receipt：新增 `services/market_intel/candidate_queue_review_ai_summary_output_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt` 與 UI receipt 按鈕，在 run package 後驗收人工 Ollama 摘要輸出的 schema、evidence_refs 與 model_route；API/UI 不呼叫 LLM、不派送 Telegram、不寫 receipt、不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不 commit、不掛 scheduler；版本同步至 V10.285。 - Phase 83 candidate queue review AI summary persistence preflight：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_preflight.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight` 與 UI preflight 按鈕，在 output receipt 後整理 future CLI-only `market_alert_review_queue.metadata_json.ai_summary_review` persistence contract、payload hash 與 metadata patch preview；API/UI 不呼叫 LLM、不派送 Telegram、不寫 preflight、不寫 summary record、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不 commit、不掛 scheduler；版本同步至 V10.286。 - Phase 84 candidate queue review AI summary persistence transaction：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_transaction.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction` 與 UI transaction 按鈕，在 persistence preflight 後產生 future CLI-only `metadata_json` UPDATE statement preview、parameter preview 與 rollback plan；API/UI 不開 DB、不執行 SQL、不寫 transaction、不寫 summary record、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；版本同步至 V10.287。 + - Phase 85 candidate queue review AI summary persistence writer preflight：新增 `services/market_intel/candidate_queue_review_ai_summary_persistence_writer_preflight.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight` 與 UI writer preflight 按鈕，在 transaction preview 後檢查 CLI-only writer contract、metadata_json backup requirement、post-write smoke requirement 與 artifact path gate；API/UI 不開 DB、不執行 SQL、不寫 preflight、不寫 summary record、不寫 metadata_json、不讀 token、不執行 CLI、不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；版本同步至 V10.290。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/config.py b/config.py index 378419a..b997d14 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.289" +SYSTEM_VERSION = "V10.290" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index baeb542..5edeaf8 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -210,6 +210,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review AI summary output receipt：`services.market_intel.candidate_queue_review_ai_summary_output_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt` 在 run package 後驗收人工 Ollama 摘要輸出的 schema、`evidence_refs` 與 `model_route`。此 receipt gate 不產生 AI 摘要；API/UI 不呼叫 LLM、不派送 Telegram、不寫檔、不讀 approval token、不執行 CLI、不更新 `review_state`、不寫 DB、不 commit、不掛 scheduler；摘要持久化與 Telegram 派送必須另開後續 gate。 - 2026-05-19 追加 candidate queue review AI summary persistence preflight：`services.market_intel.candidate_queue_review_ai_summary_persistence_preflight` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight` 在 output receipt 後整理未來 CLI-only `market_alert_review_queue.metadata_json.ai_summary_review` persistence contract、payload hash 與 metadata patch preview。此 preflight 不產生 transaction、不寫 summary record、不寫 `metadata_json`、不呼叫 LLM、不派送 Telegram、不讀 approval token、不執行 CLI、不更新 `review_state`、不寫 DB、不 commit、不掛 scheduler；真正持久化與 Telegram dispatch 必須另開後續 gate。 - 2026-05-19 追加 candidate queue review AI summary persistence transaction：`services.market_intel.candidate_queue_review_ai_summary_persistence_transaction` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction` 在 persistence preflight 後產生未來 CLI-only `metadata_json` UPDATE statement preview、parameter preview 與 rollback plan。此 transaction gate 不開 DB、不執行 SQL、不寫 transaction、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須另開 CLI writer gate 與 post-write smoke。 +- 2026-05-19 追加 candidate queue review AI summary persistence writer preflight：`services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight` 在 transaction preview 後檢查 CLI-only writer contract、`metadata_json` backup requirement、post-write smoke requirement 與 artifact path gate。此 writer preflight 不開 DB、不執行 SQL、不寫 preflight、不寫 summary record、不寫 `metadata_json`、不讀 approval token、不執行 CLI、不更新 `review_state`、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler；真正寫入必須另開 CLI run package、operator readiness、receipt 與 post-write smoke。 ### Phase 4：Coupang / Shopee Adapter diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index bcc3699..76f5789 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -16,6 +16,7 @@ - 2026-05-19 追記：同步背景 V10.276 ElephantAlpha 更新後的 `services/elephant_alpha_autonomous_engine.py` 行數；此處只更新 inventory，不變更 AI engine 行為。 - 2026-05-19 追記：同步背景 V10.281/V10.282 dashboard 與 Code Review pipeline 更新後的行數；此處只更新 inventory，不變更 dashboard 或 code review 行為。 - 2026-05-19 追記：同步背景 PChome identity 價格刷新與競品風險查詢更新後的 `services/competitor_price_feeder.py` 行數；此處只更新 inventory，不變更 feeder 行為。 +- 2026-05-19 追記：同步背景 Telegram 模板擴充後的 `services/telegram_templates.py` 行數；此處只更新 inventory，不變更 Telegram 格式化行為。 ## 達到或超過 800 行檔案清單 @@ -40,6 +41,7 @@ | 966 | `services/trend_crawler.py` | P2 crawler service | source adapters / parser / persistence | | 942 | `services/learning_pipeline.py` | P2 RAG learning pipeline | distiller / promotion gate / persistence / telemetry | | 940 | `services/import_service.py` | P2 import service | validators / import writers / report builders | +| 933 | `services/telegram_templates.py` | P2 Telegram templates | alert template groups / channel-specific formatting / reusable render helpers | | 867 | `services/token_report_service.py` | P2 token report service | query / aggregation / chart payload / notification formatting | | 865 | `routes/daily_sales_routes.py` | P2 Daily Sales Blueprint | route glue / export helpers / daily query and formatting service | | 844 | `services/ollama_service.py` | P2 Ollama client | host health / request client / fallback policy / response parsing | diff --git a/routes/README.md b/routes/README.md index 30bf074..4b286eb 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,9 +19,9 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 84 candidate queue review AI summary persistence transaction 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 85 candidate queue review AI summary persistence writer preflight 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` | -| `market_intel_review_post_routes.py` | 市場情報 review_state closeout 後只讀延伸 API（掛在 `market_intel_review_bp`） | `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive`, `/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction` | +| `market_intel_review_post_routes.py` | 市場情報 review_state closeout 後只讀延伸 API（掛在 `market_intel_review_bp`） | `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive`, `/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_post_routes.py b/routes/market_intel_review_post_routes.py index ac34ed9..a583ffe 100644 --- a/routes/market_intel_review_post_routes.py +++ b/routes/market_intel_review_post_routes.py @@ -23,6 +23,9 @@ from services.market_intel.candidate_queue_review_ai_summary_persistence_preflig from services.market_intel.candidate_queue_review_ai_summary_persistence_transaction import ( build_candidate_queue_review_ai_summary_persistence_transaction, ) +from services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight import ( + build_candidate_queue_review_ai_summary_persistence_writer_preflight, +) from services.market_intel.candidate_queue_review_ai_summary_run_package import ( build_candidate_queue_review_ai_summary_run_package, ) @@ -336,6 +339,58 @@ def _build_review_ai_summary_persistence_preflight_stack( ) +def _build_review_ai_summary_persistence_transaction_stack( + *, + service, + sample_result, + payload_error, + operator_evidence, + writer_output, + smoke_result, + limit, + execute_requested, +): + ( + transaction, + receipt, + closeout, + inventory, + archive, + archive_summary, + ai_summary_preflight, + ai_summary_run_package, + ai_summary_output_receipt, + ai_summary_persistence_preflight, + ) = _build_review_ai_summary_persistence_preflight_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + smoke_result=smoke_result, + limit=limit, + execute_requested=execute_requested, + ) + ai_summary_persistence_transaction = build_candidate_queue_review_ai_summary_persistence_transaction( + ai_summary_persistence_preflight=ai_summary_persistence_preflight, + operator_evidence=operator_evidence, + execute_requested=execute_requested, + ) + return ( + transaction, + receipt, + closeout, + inventory, + archive, + archive_summary, + ai_summary_preflight, + ai_summary_run_package, + ai_summary_output_receipt, + ai_summary_persistence_preflight, + ai_summary_persistence_transaction, + ) + + @market_intel_review_bp.route( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_post_closeout_inventory", @@ -561,7 +616,8 @@ def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_tra ai_summary_run_package, ai_summary_output_receipt, ai_summary_persistence_preflight, - ) = _build_review_ai_summary_persistence_preflight_stack( + ai_summary_persistence_transaction, + ) = _build_review_ai_summary_persistence_transaction_stack( service=service, sample_result=sample_result, payload_error=payload_error, @@ -571,10 +627,51 @@ def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_tra limit=limit, execute_requested=execute_requested, ) - data = build_candidate_queue_review_ai_summary_persistence_transaction( - ai_summary_persistence_preflight=ai_summary_persistence_preflight, + data = ai_summary_persistence_transaction + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_writer_preflight", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_writer_preflight(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + apply_real_write = request.args.get("apply_real_write", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + ( + transaction, + receipt, + closeout, + inventory, + archive, + archive_summary, + ai_summary_preflight, + ai_summary_run_package, + ai_summary_output_receipt, + ai_summary_persistence_preflight, + ai_summary_persistence_transaction, + ) = _build_review_ai_summary_persistence_transaction_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + smoke_result=smoke_result, + limit=limit, + execute_requested=execute_requested, + ) + data = build_candidate_queue_review_ai_summary_persistence_writer_preflight( + ai_summary_persistence_transaction=ai_summary_persistence_transaction, operator_evidence=operator_evidence, execute_requested=execute_requested, + apply_real_write=apply_real_write, ) data["phase"] = service.phase return jsonify(data), 400 if payload_error else 200 diff --git a/services/market_intel/candidate_queue_review_ai_summary_persistence_writer_preflight.py b/services/market_intel/candidate_queue_review_ai_summary_persistence_writer_preflight.py new file mode 100644 index 0000000..4af7df0 --- /dev/null +++ b/services/market_intel/candidate_queue_review_ai_summary_persistence_writer_preflight.py @@ -0,0 +1,427 @@ +"""候選審核 queue AI summary persistence writer preflight。 + +本模組只檢查 metadata_json persistence writer 的 CLI-only 前置條件； +不開 DB connection、不執行 SQL、不讀 approval token、不執行 CLI、不寫檔、 +不更新 review_state、不派送 Telegram、不呼叫 LLM、不 commit、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +TARGET_TABLE = "market_alert_review_queue" +TARGET_COLUMN = "metadata_json" +SUMMARY_METADATA_KEY = "ai_summary_review" +TARGET_OPERATION = "persist_ai_summary_metadata_json" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_text(value, limit=300): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _side_effects_clear(*payloads): + blocked_keys = ( + "ready_for_api_database_write", + "ready_for_telegram_dispatch", + "ready_for_scheduler_attach", + "api_executes_cli", + "api_executes_llm", + "api_reads_approval_token", + "api_writes_file", + "api_writes_database", + "api_updates_review_state", + "summary_persistence_writer_preflight_file_written", + "writer_preflight_file_written", + "summary_persistence_transaction_file_written", + "summary_file_written", + "summary_record_written", + "summary_persistence_record_written", + "metadata_patch_written", + "transaction_file_written", + "database_connection_opened", + "database_session_created", + "explicit_transaction_opened", + "transaction_opened", + "transaction_committed", + "database_write_executed", + "database_commit_executed", + "review_state_update_executed", + "llm_call_executed", + "ollama_call_executed", + "gemini_call_executed", + "telegram_dispatched", + "external_network_executed", + "scheduler_attached", + "writes_executed", + "would_write_database", + ) + return all( + not _as_dict(payload).get(key) + for payload in payloads + for key in blocked_keys + ) + + +def _operator_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "operator_confirmed_ai_summary_persistence_writer_preflight": bool( + operator_evidence.get( + "operator_confirmed_ai_summary_persistence_writer_preflight" + ) + or operator_evidence.get("operator_confirmed_summary_persistence_writer_preflight") + ), + "operator_confirmed_summary_persistence_is_cli_only": bool( + operator_evidence.get("operator_confirmed_summary_persistence_is_cli_only") + or operator_evidence.get("operator_confirmed_persistence_requires_cli") + ), + "operator_confirmed_metadata_json_backup_required": bool( + operator_evidence.get("operator_confirmed_metadata_json_backup_required") + or operator_evidence.get("operator_confirmed_backup_before_write") + ), + "operator_confirmed_postwrite_smoke_required": bool( + operator_evidence.get("operator_confirmed_postwrite_smoke_required") + or operator_evidence.get("operator_confirmed_summary_postwrite_smoke_required") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "operator_confirmed_no_telegram_dispatch": bool( + operator_evidence.get("operator_confirmed_no_telegram_dispatch") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "ai_summary_persistence_transaction_artifact_path": _safe_text( + operator_evidence.get("ai_summary_persistence_transaction_artifact_path") + or operator_evidence.get("summary_persistence_transaction_artifact_path") + ), + "metadata_json_backup_artifact_path": _safe_text( + operator_evidence.get("metadata_json_backup_artifact_path") + or operator_evidence.get("summary_metadata_backup_artifact_path") + ), + "postwrite_smoke_plan_path": _safe_text( + operator_evidence.get("postwrite_smoke_plan_path") + or operator_evidence.get("summary_persistence_postwrite_smoke_plan_path") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _statement_payloads(transaction): + payloads = [] + for statement in _as_list(transaction.get("statements")): + statement = _as_dict(statement) + where = _as_dict(statement.get("where")) + parameters = _as_dict(statement.get("parameter_preview")) + payloads.append( + { + "statement_type": statement.get("statement_type") or "UPDATE", + "table": statement.get("table"), + "target_column": statement.get("target_column"), + "dedupe_key": where.get("dedupe_key") or parameters.get("dedupe_key"), + "metadata_key": parameters.get("metadata_key"), + "payload_hash": parameters.get("payload_hash"), + "execute_in_api": bool(statement.get("execute_in_api")), + "requires_existing_metadata_merge": bool( + statement.get("requires_existing_metadata_merge") + ), + } + ) + return payloads + + +def _invalid_statements(payloads): + invalid = [] + for payload in payloads: + missing_fields = [ + key + for key in ("table", "target_column", "dedupe_key", "payload_hash") + if not payload.get(key) + ] + invalid_target = bool( + payload.get("table") != TARGET_TABLE + or payload.get("target_column") != TARGET_COLUMN + or payload.get("metadata_key") != SUMMARY_METADATA_KEY + ) + invalid_execution = bool(payload.get("execute_in_api")) + if missing_fields or invalid_target or invalid_execution: + invalid.append( + { + "dedupe_key": payload.get("dedupe_key"), + "missing_fields": missing_fields, + "target_invalid": invalid_target, + "execution_invalid": invalid_execution, + } + ) + return invalid + + +def _transaction_summary(ai_summary_persistence_transaction): + transaction = _as_dict(ai_summary_persistence_transaction) + summary = _as_dict(transaction.get("transaction_summary")) + statement_payloads = _statement_payloads(transaction) + invalid = _invalid_statements(statement_payloads) + rollback_plan = _as_list(transaction.get("rollback_plan")) + return { + "provided": bool(transaction), + "mode": transaction.get("mode"), + "summary_persistence_transaction_ready": bool( + transaction.get("summary_persistence_transaction_ready") + ), + "ready_for_summary_persistence_writer_gate": bool( + transaction.get("ready_for_summary_persistence_writer_gate") + ), + "statement_count": int(transaction.get("statement_count") or 0), + "summary_payload_hash": transaction.get("summary_payload_hash"), + "expected_dedupe_keys": _as_list(transaction.get("expected_dedupe_keys")), + "transaction_summary": summary, + "statement_payloads": statement_payloads, + "invalid_statements": invalid, + "rollback_plan": rollback_plan, + "blocked_reasons": _as_list(transaction.get("blocked_reasons")), + "safe_boundaries": _as_list(transaction.get("safe_boundaries")), + "side_effects_clear": _side_effects_clear(transaction), + } + + +def _preflight_gates(*, transaction, operator, apply_real_write): + summary = transaction["transaction_summary"] + statements = transaction["statement_payloads"] + return [ + { + "key": "summary_persistence_transaction_ready", + "label": "summary persistence transaction preview 必須已通過", + "passed": bool( + transaction["mode"] + == "candidate_queue_review_ai_summary_persistence_transaction_preview" + and transaction["summary_persistence_transaction_ready"] + and transaction["ready_for_summary_persistence_writer_gate"] + ), + }, + { + "key": "summary_persistence_update_statements_valid", + "label": "UPDATE preview 必須指向 metadata_json.ai_summary_review 且禁止 API 執行", + "passed": bool( + statements + and not transaction["invalid_statements"] + and len(statements) == transaction["statement_count"] + ), + }, + { + "key": "summary_persistence_cli_contract_ready", + "label": "transaction summary 必須標示 CLI-only 且 API write disabled", + "passed": bool( + summary.get("manual_cli_required") + and summary.get("api_write_allowed") is False + ), + }, + { + "key": "summary_persistence_rollback_plan_ready", + "label": "正式寫入前必須有 metadata_json backup 與還原計畫", + "passed": bool(len(transaction["rollback_plan"]) >= 3), + }, + { + "key": "operator_confirmed_summary_persistence_writer_preflight", + "label": "操作員確認本步只做 CLI writer preflight，不由 API 寫入", + "passed": bool( + operator["operator_confirmed_ai_summary_persistence_writer_preflight"] + and operator["operator_confirmed_summary_persistence_is_cli_only"] + and operator["operator_confirmed_metadata_json_backup_required"] + and operator["operator_confirmed_postwrite_smoke_required"] + and operator["operator_confirmed_no_api_db_write"] + and operator["operator_confirmed_no_telegram_dispatch"] + and operator["operator_confirmed_no_scheduler_attach"] + ), + }, + { + "key": "summary_persistence_writer_artifacts_recorded", + "label": "transaction、metadata backup 與 postwrite smoke plan artifact path 必須齊備", + "passed": bool( + operator["ai_summary_persistence_transaction_artifact_path"] + and operator["metadata_json_backup_artifact_path"] + and operator["postwrite_smoke_plan_path"] + ), + }, + { + "key": "summary_persistence_writer_preflight_no_approval_token_submitted_to_api", + "label": "payload 不得包含一次性 approval token key", + "passed": not operator["approval_token_submitted_to_api"], + }, + { + "key": "summary_persistence_writer_preflight_apply_real_write_not_requested_from_api", + "label": "API/UI preflight 不接受 apply_real_write", + "passed": not apply_real_write, + }, + { + "key": "summary_persistence_writer_preflight_has_no_side_effects", + "label": "writer preflight 不得開 DB、寫檔、呼叫 LLM、派 Telegram 或掛 scheduler", + "passed": transaction["side_effects_clear"], + }, + ] + + +def build_candidate_queue_review_ai_summary_persistence_writer_preflight( + *, + ai_summary_persistence_transaction, + operator_evidence=None, + execute_requested=False, + apply_real_write=False, +): + """建立 AI summary persistence writer preflight；不執行 SQL 或副作用。""" + transaction = _transaction_summary(ai_summary_persistence_transaction) + operator = _operator_summary(operator_evidence) + gates = _preflight_gates( + transaction=transaction, + operator=operator, + apply_real_write=bool(apply_real_write), + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + preflight_ready = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_ai_summary_persistence_writer_preflight_preview", + "target_table": TARGET_TABLE, + "target_column": TARGET_COLUMN, + "target_operation": TARGET_OPERATION, + "execute_requested": bool(execute_requested), + "apply_real_write_requested": bool(apply_real_write), + "summary_persistence_writer_preflight_ready": preflight_ready, + "ready_for_summary_persistence_run_package": preflight_ready, + "ready_for_summary_persistence_cli_run": False, + "ready_for_real_write": False, + "ready_for_api_database_write": False, + "ready_for_telegram_dispatch": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_executes_llm": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "summary_persistence_writer_preflight_file_written": False, + "writer_preflight_file_written": False, + "summary_persistence_transaction_file_written": False, + "summary_file_written": False, + "summary_record_written": False, + "summary_persistence_record_written": False, + "metadata_patch_written": False, + "transaction_file_written": False, + "ai_summary_generated": False, + "llm_call_executed": False, + "ollama_call_executed": False, + "gemini_call_executed": False, + "telegram_dispatched": False, + "review_state_update_executed": False, + "read_only_query_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "statement_count": transaction["statement_count"], + "invalid_statement_count": len(transaction["invalid_statements"]), + "statement_payloads": transaction["statement_payloads"], + "invalid_statements": transaction["invalid_statements"], + "expected_dedupe_keys": transaction["expected_dedupe_keys"], + "summary_payload_hash": transaction["summary_payload_hash"], + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_ai_summary_persistence_writer_preflight": operator, + "transaction_preview_summary": { + "mode": transaction["mode"], + "transaction_ready": transaction["summary_persistence_transaction_ready"], + "writer_gate_ready": transaction["ready_for_summary_persistence_writer_gate"], + "statement_count": transaction["statement_count"], + "manual_cli_required": bool( + transaction["transaction_summary"].get("manual_cli_required") + ), + "api_write_allowed": False, + }, + "writer_preflight_contract": { + "target_table": TARGET_TABLE, + "target_column": TARGET_COLUMN, + "target_json_path": [SUMMARY_METADATA_KEY], + "operation": "metadata_json_merge", + "lookup": "dedupe_key", + "approval_env_var": APPROVAL_ENV_VAR, + "manual_cli_required": True, + "api_write_allowed": False, + "requires_metadata_json_backup": True, + "requires_postwrite_smoke": True, + }, + "next_operator_steps": [ + "保存 transaction preview artifact", + "CLI 寫入前先備份目標 dedupe_key 的 metadata_json", + "只在 operator shell 注入一次性 approval token", + "後續 run package 必須產生 CLI 命令與 payload manifest", + "正式寫入後立即跑 post-write smoke，且 Telegram dispatch 另開 gate", + ], + "safe_boundaries": [ + "do_not_open_database_from_ai_summary_persistence_writer_preflight", + "do_not_execute_sql_from_ai_summary_persistence_writer_preflight", + "do_not_write_metadata_json_from_ai_summary_persistence_writer_preflight", + "do_not_write_summary_writer_preflight_file_from_api", + "do_not_read_approval_token_from_ai_summary_persistence_writer_preflight", + "do_not_execute_cli_from_ai_summary_persistence_writer_preflight", + "do_not_call_llm_from_ai_summary_persistence_writer_preflight", + "do_not_dispatch_telegram_from_ai_summary_persistence_writer_preflight", + "do_not_attach_scheduler_from_ai_summary_persistence_writer_preflight", + "future_summary_persistence_write_must_use_cli_only_gate", + "metadata_json_backup_required_before_summary_persistence_write", + "summary_persistence_postwrite_smoke_required", + "ai_summary_persistence_writer_preflight_preview_only", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index a33161b..d011ff1 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -31,6 +31,7 @@ from services.market_intel.candidate_queue_review_ai_summary_preflight import bu from services.market_intel.candidate_queue_review_ai_summary_output_receipt import build_candidate_queue_review_ai_summary_output_receipt from services.market_intel.candidate_queue_review_ai_summary_persistence_preflight import build_candidate_queue_review_ai_summary_persistence_preflight from services.market_intel.candidate_queue_review_ai_summary_persistence_transaction import build_candidate_queue_review_ai_summary_persistence_transaction +from services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight import build_candidate_queue_review_ai_summary_persistence_writer_preflight from services.market_intel.candidate_queue_review_ai_summary_run_package import build_candidate_queue_review_ai_summary_run_package @@ -55,9 +56,11 @@ BLOCKED_RUN_REVIEW_KEYS = ( "summary_receipt_file_written", "summary_persistence_preflight_file_written", "summary_persistence_transaction_file_written", + "summary_persistence_writer_preflight_file_written", "summary_persistence_record_written", "metadata_patch_written", "transaction_file_written", + "writer_preflight_file_written", "ai_summary_generated", "llm_call_executed", "ollama_call_executed", @@ -76,7 +79,7 @@ BLOCKED_RUN_REVIEW_KEYS = ( "writes_executed", "would_write_database", ) -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_archive_summary", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_output_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_ai_summary_persistence_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -234,12 +237,9 @@ def build_deployment_readiness_preview( candidate_queue_review_ai_summary_output_receipt = build_candidate_queue_review_ai_summary_output_receipt( ai_summary_run_package=candidate_queue_review_ai_summary_run_package, ) - candidate_queue_review_ai_summary_persistence_preflight = build_candidate_queue_review_ai_summary_persistence_preflight( - ai_summary_output_receipt=candidate_queue_review_ai_summary_output_receipt, - ) - candidate_queue_review_ai_summary_persistence_transaction = build_candidate_queue_review_ai_summary_persistence_transaction( - ai_summary_persistence_preflight=candidate_queue_review_ai_summary_persistence_preflight, - ) + candidate_queue_review_ai_summary_persistence_preflight = build_candidate_queue_review_ai_summary_persistence_preflight(ai_summary_output_receipt=candidate_queue_review_ai_summary_output_receipt) + candidate_queue_review_ai_summary_persistence_transaction = build_candidate_queue_review_ai_summary_persistence_transaction(ai_summary_persistence_preflight=candidate_queue_review_ai_summary_persistence_preflight) + candidate_queue_review_ai_summary_persistence_writer_preflight = build_candidate_queue_review_ai_summary_persistence_writer_preflight(ai_summary_persistence_transaction=candidate_queue_review_ai_summary_persistence_transaction) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -526,18 +526,10 @@ def build_deployment_readiness_preview( candidate_queue_review_ai_summary_run_package, "candidate_queue_review_ai_summary_run_package_preview", ), - "candidate_queue_review_ai_summary_output_receipt_preview_safe": _run_review_preview_safe( - candidate_queue_review_ai_summary_output_receipt, - "candidate_queue_review_ai_summary_output_receipt_preview", - ), - "candidate_queue_review_ai_summary_persistence_preflight_preview_safe": _run_review_preview_safe( - candidate_queue_review_ai_summary_persistence_preflight, - "candidate_queue_review_ai_summary_persistence_preflight_preview", - ), - "candidate_queue_review_ai_summary_persistence_transaction_preview_safe": _run_review_preview_safe( - candidate_queue_review_ai_summary_persistence_transaction, - "candidate_queue_review_ai_summary_persistence_transaction_preview", - ), + "candidate_queue_review_ai_summary_output_receipt_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_output_receipt, "candidate_queue_review_ai_summary_output_receipt_preview"), + "candidate_queue_review_ai_summary_persistence_preflight_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_preflight, "candidate_queue_review_ai_summary_persistence_preflight_preview"), + "candidate_queue_review_ai_summary_persistence_transaction_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_transaction, "candidate_queue_review_ai_summary_persistence_transaction_preview"), + "candidate_queue_review_ai_summary_persistence_writer_preflight_preview_safe": _run_review_preview_safe(candidate_queue_review_ai_summary_persistence_writer_preflight, "candidate_queue_review_ai_summary_persistence_writer_preflight_preview"), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -789,6 +781,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_ai_summary_output_receipt": candidate_queue_review_ai_summary_output_receipt, "candidate_queue_review_ai_summary_persistence_preflight": candidate_queue_review_ai_summary_persistence_preflight, "candidate_queue_review_ai_summary_persistence_transaction": candidate_queue_review_ai_summary_persistence_transaction, + "candidate_queue_review_ai_summary_persistence_writer_preflight": candidate_queue_review_ai_summary_persistence_writer_preflight, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 7cfb4e5..2e50ec9 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_84_candidate_queue_review_ai_summary_persistence_transaction" +MARKET_INTEL_PHASE = "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 986a1c5..61838ab 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -691,6 +691,9 @@ + @@ -1049,6 +1052,7 @@ const sampleCandidateQueueReviewAiSummaryOutputReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-output-receipt]') : null; const sampleCandidateQueueReviewAiSummaryPersistencePreflight = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-preflight]') : null; const sampleCandidateQueueReviewAiSummaryPersistenceTransaction = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-transaction]') : null; + const sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflight = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-ai-summary-persistence-writer-preflight]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1084,6 +1088,7 @@ const sampleCandidateQueueReviewAiSummaryOutputReceiptEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_output_receipt') }}"; const sampleCandidateQueueReviewAiSummaryPersistencePreflightEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_preflight') }}"; const sampleCandidateQueueReviewAiSummaryPersistenceTransactionEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_transaction') }}"; + const sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflightEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_writer_preflight') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -5295,6 +5300,123 @@ } }; + const renderCandidateQueueReviewAiSummaryPersistenceWriterPreflight = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const contract = data.writer_preflight_contract || {}; + const statements = data.statement_payloads || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `preflight=${data.summary_persistence_writer_preflight_ready ? 'ready' : 'blocked'}`, + `run_package=${data.ready_for_summary_persistence_run_package ? 'ready' : 'blocked'}`, + `statements=${data.statement_count || 0}`, + `db=${data.database_write_executed ? 'written' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只檢查 AI summary persistence writer preflight；正式 metadata_json 寫入仍需未來 CLI-only run package。API/UI 不讀 token、不執行 CLI、不開 DB、不寫檔、不派送 Telegram。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

WRITER PREFLIGHT GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 writer preflight gate。
' + }
+
+
+

WRITER CONTRACT

+
+ ${[ + ['target_table', contract.target_table || 'missing'], + ['target_column', contract.target_column || 'missing'], + ['json_path', (contract.target_json_path || []).join('.') || 'missing'], + ['manual_cli_required', contract.manual_cli_required], + ['api_write_allowed', contract.api_write_allowed], + ['backup_required', contract.requires_metadata_json_backup], + ['postwrite_smoke', contract.requires_postwrite_smoke] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

STATEMENT PAYLOADS

+
${ + statements.map(item => ` +
+
+ ${escapeHtml(item.statement_type || 'UPDATE')} + ${escapeHtml(item.dedupe_key || 'missing')} +
+ ${item.execute_in_api ? 'WRITE' : 'CLI'} +
+ `).join('') || '
尚未載入 statement payload。
' + }
+
+
+

NO-SIDE-EFFECTS

+
+ ${[ + ['api_executes_cli', data.api_executes_cli], + ['api_reads_approval_token', data.api_reads_approval_token], + ['api_writes_database', data.api_writes_database], + ['summary_persistence_writer_preflight_file_written', data.summary_persistence_writer_preflight_file_written], + ['database_connection_opened', data.database_connection_opened], + ['database_write_executed', data.database_write_executed], + ['telegram_dispatched', data.telegram_dispatched], + ['scheduler_attached', data.scheduler_attached] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueReviewAiSummaryPersistenceWriterPreflight = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue review AI summary persistence writer preflight 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflightEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewAiSummaryPersistenceWriterPreflight(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review AI summary persistence writer preflight 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -7001,6 +7123,9 @@ if (sampleCandidateQueueReviewAiSummaryPersistenceTransaction) { sampleCandidateQueueReviewAiSummaryPersistenceTransaction.addEventListener('click', loadCandidateQueueReviewAiSummaryPersistenceTransaction); } + if (sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflight) { + sampleCandidateQueueReviewAiSummaryPersistenceWriterPreflight.addEventListener('click', loadCandidateQueueReviewAiSummaryPersistenceWriterPreflight); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 07b579e..8ae539f 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -1059,6 +1059,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_transaction" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_ai_summary_persistence_writer_preflight" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -1123,6 +1127,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-ai-summary-persistence-transaction" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-ai-summary-persistence-writer-preflight" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -1159,7 +1167,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert bridge["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1317,7 +1325,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert contract["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1450,7 +1458,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1463,7 +1471,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert gate["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1533,7 +1541,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1545,7 +1553,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1593,7 +1601,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1604,7 +1612,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert acceptance["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1646,7 +1654,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1658,7 +1666,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert review["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1769,7 +1777,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1808,7 +1816,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert review["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1870,7 +1878,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1950,7 +1958,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert handoff["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -2014,7 +2022,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -2073,7 +2081,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert queue_draft["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2147,7 +2155,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -2210,7 +2218,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert approval["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2288,7 +2296,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2351,7 +2359,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert transaction["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2431,7 +2439,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -6148,6 +6156,150 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_previews_upda ) +def test_candidate_queue_review_ai_summary_persistence_writer_preflight_gates_cli_only_write(): + from services.market_intel.candidate_queue_review_ai_summary_persistence_writer_preflight import ( + build_candidate_queue_review_ai_summary_persistence_writer_preflight, + ) + + expected_key = "market-alert-review:sample-batch:sku-001" + transaction = { + "mode": "candidate_queue_review_ai_summary_persistence_transaction_preview", + "summary_persistence_transaction_ready": True, + "ready_for_summary_persistence_writer_gate": True, + "statement_count": 1, + "expected_dedupe_keys": [expected_key], + "summary_payload_hash": "f" * 64, + "transaction_summary": { + "target_table": "market_alert_review_queue", + "target_column": "metadata_json", + "statement_count": 1, + "metadata_key": "ai_summary_review", + "payload_hash": "f" * 64, + "manual_cli_required": True, + "api_write_allowed": False, + }, + "statements": [ + { + "statement_type": "UPDATE", + "table": "market_alert_review_queue", + "target_column": "metadata_json", + "where": {"dedupe_key": expected_key}, + "parameter_preview": { + "dedupe_key": expected_key, + "metadata_key": "ai_summary_review", + "payload_hash": "f" * 64, + }, + "requires_existing_metadata_merge": True, + "execute_in_api": False, + } + ], + "rollback_plan": [ + {"key": "backup_metadata_json_before_update"}, + {"key": "restore_metadata_json_by_dedupe_key"}, + {"key": "do_not_change_review_state"}, + ], + "database_connection_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "llm_call_executed": False, + "telegram_dispatched": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + } + operator_evidence = { + "ai_summary_persistence_transaction_artifact_path": ( + "artifacts/market_intel/ai-summary-persistence-transaction.json" + ), + "metadata_json_backup_artifact_path": ( + "artifacts/market_intel/metadata-json-backup.json" + ), + "postwrite_smoke_plan_path": ( + "artifacts/market_intel/summary-persistence-postwrite-smoke.json" + ), + "operator_confirmed_ai_summary_persistence_writer_preflight": True, + "operator_confirmed_summary_persistence_is_cli_only": True, + "operator_confirmed_metadata_json_backup_required": True, + "operator_confirmed_postwrite_smoke_required": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_no_telegram_dispatch": True, + "operator_confirmed_no_scheduler_attach": True, + } + preflight = build_candidate_queue_review_ai_summary_persistence_writer_preflight( + ai_summary_persistence_transaction=transaction, + operator_evidence=operator_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_ai_summary_persistence_writer_preflight( + ai_summary_persistence_transaction=transaction, + operator_evidence={ + **operator_evidence, + "approval_token": TEST_APPROVAL_TOKEN, + }, + execute_requested=True, + ) + apply_write = build_candidate_queue_review_ai_summary_persistence_writer_preflight( + ai_summary_persistence_transaction=transaction, + operator_evidence=operator_evidence, + execute_requested=True, + apply_real_write=True, + ) + + assert preflight["mode"] == ( + "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" + ) + assert preflight["target_operation"] == "persist_ai_summary_metadata_json" + assert preflight["summary_persistence_writer_preflight_ready"] is True + assert preflight["ready_for_summary_persistence_run_package"] is True + assert preflight["ready_for_summary_persistence_cli_run"] is False + assert preflight["ready_for_real_write"] is False + assert preflight["ready_for_api_database_write"] is False + assert preflight["ready_for_telegram_dispatch"] is False + assert preflight["api_executes_cli"] is False + assert preflight["api_reads_approval_token"] is False + assert preflight["api_writes_file"] is False + assert preflight["api_writes_database"] is False + assert preflight["summary_persistence_writer_preflight_file_written"] is False + assert preflight["writer_preflight_file_written"] is False + assert preflight["metadata_patch_written"] is False + assert preflight["database_connection_opened"] is False + assert preflight["database_write_executed"] is False + assert preflight["database_commit_executed"] is False + assert preflight["llm_call_executed"] is False + assert preflight["telegram_dispatched"] is False + assert preflight["scheduler_attached"] is False + assert preflight["writes_executed"] is False + assert preflight["would_write_database"] is False + assert preflight["blocked_reasons"] == [] + assert preflight["statement_count"] == 1 + assert preflight["invalid_statement_count"] == 0 + assert preflight["statement_payloads"][0]["dedupe_key"] == expected_key + assert preflight["writer_preflight_contract"]["api_write_allowed"] is False + assert preflight["writer_preflight_contract"]["manual_cli_required"] is True + assert preflight["writer_preflight_contract"]["requires_metadata_json_backup"] is True + assert preflight["writer_preflight_contract"]["requires_postwrite_smoke"] is True + assert "future_summary_persistence_write_must_use_cli_only_gate" in preflight[ + "safe_boundaries" + ] + assert token_leak["summary_persistence_writer_preflight_ready"] is False + assert token_leak["operator_ai_summary_persistence_writer_preflight"][ + "approval_token_submitted_to_api" + ] is True + assert ( + "summary_persistence_writer_preflight_no_approval_token_submitted_to_api" + in token_leak["blocked_reasons"] + ) + assert ( + "summary_persistence_writer_preflight_apply_real_write_not_requested_from_api" + in apply_write["blocked_reasons"] + ) + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6190,7 +6342,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6247,7 +6399,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -6336,7 +6488,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6390,7 +6542,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -6446,7 +6598,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -6512,7 +6664,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -6814,7 +6966,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -6862,7 +7014,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -6911,7 +7063,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -6969,7 +7121,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -7035,7 +7187,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -7106,7 +7258,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -7182,7 +7334,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -7264,7 +7416,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -7350,7 +7502,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -7433,7 +7585,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -7516,7 +7668,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -7602,7 +7754,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -7693,7 +7845,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -7803,7 +7955,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -7889,7 +8041,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -7946,7 +8098,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -7999,7 +8151,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -8052,7 +8204,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8113,7 +8265,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8182,7 +8334,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -8254,7 +8406,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -8327,7 +8479,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -8398,7 +8550,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -8432,6 +8584,77 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_writer_preflight" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_writer_preflight" + "?execute=true&apply_real_write=true", + json={"sample_result": {}}, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" + ) + assert data["phase"] == ( + "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" + ) + assert data["summary_persistence_writer_preflight_ready"] is False + assert data["ready_for_summary_persistence_run_package"] is False + assert data["ready_for_summary_persistence_cli_run"] is False + assert data["ready_for_real_write"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_telegram_dispatch"] is False + assert data["api_executes_llm"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["summary_persistence_writer_preflight_file_written"] is False + assert data["writer_preflight_file_written"] is False + assert data["summary_persistence_record_written"] is False + assert data["metadata_patch_written"] is False + assert data["transaction_file_written"] is False + assert data["ai_summary_generated"] is False + assert data["llm_call_executed"] is False + assert data["telegram_dispatched"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["scheduler_attached"] is False + assert data["statement_count"] == 0 + assert "summary_persistence_transaction_ready" in data["blocked_reasons"] + assert "summary_persistence_update_statements_valid" in data["blocked_reasons"] + assert ( + "summary_persistence_writer_preflight_apply_real_write_not_requested_from_api" + in data["blocked_reasons"] + ) + assert "do_not_open_database_from_ai_summary_persistence_writer_preflight" in data[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -8460,7 +8683,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -8485,7 +8708,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -8523,7 +8746,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -8534,7 +8757,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -8570,7 +8793,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -8581,7 +8804,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -8622,7 +8845,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -8633,7 +8856,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -8681,7 +8904,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -8693,7 +8916,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -8739,7 +8962,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -8752,7 +8975,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert plan["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -8837,7 +9060,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -8915,7 +9138,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -8930,7 +9153,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert readiness["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -9466,6 +9689,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_ai_summary_persistence_writer_preflight_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -9635,6 +9864,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_ai_summary_persistence_transaction" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_ai_summary_persistence_writer_preflight" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -11436,6 +11670,84 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "mode" + ] + == "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "summary_persistence_writer_preflight_ready" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "ready_for_summary_persistence_run_package" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "ready_for_summary_persistence_cli_run" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "statement_count" + ] + == 0 + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "api_executes_llm" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "summary_persistence_writer_preflight_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "writer_preflight_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "metadata_patch_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "telegram_dispatched" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "database_connection_opened" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_ai_summary_persistence_writer_preflight"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -11586,7 +11898,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert drill["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -11701,7 +12013,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -11713,7 +12025,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert review["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -11828,7 +12140,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -11841,7 +12153,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert smoke["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -11903,7 +12215,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -11916,7 +12228,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert inventory["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -12060,7 +12372,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -12287,7 +12599,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -12316,7 +12628,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_84_candidate_queue_review_ai_summary_persistence_transaction" + assert data["phase"] == "phase_85_candidate_queue_review_ai_summary_persistence_writer_preflight" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False