From 72ded9e1e5ba3f78a4b4f4397d0dbd56e0074f4a Mon Sep 17 00:00:00 2001 From: OoO Date: Sun, 31 May 2026 18:56:13 +0800 Subject: [PATCH] =?UTF-8?q?V10.507=20=E6=8E=A5=E5=85=A5=20Webcrumbs=20?= =?UTF-8?q?=E4=B8=A6=E6=94=B6=E6=96=82=20writer=20approval=20gate?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .env.example | 16 + AGENTS.md | 1 + TODO_NEXT_STEPS.txt | 2 + app.py | 19 +- config.py | 45 +- ...s-platform-market-campaign-intelligence.md | 1 + .../ADR-037-webcrumbs-shared-ui-runtime.md | 44 + docs/adr/README.md | 1 + docs/guides/webcrumbs_shared_runtime.md | 64 ++ .../code_modularization_inventory_20260430.md | 3 +- .../current_execution_queue_20260524.md | 1 + docs/memory/history_logs.md | 4 + routes/market_intel_mcp_review_routes.py | 64 ++ routes/market_intel_routes.py | 1 + routes/system_public_routes.py | 52 +- services/market_intel/deployment_readiness.py | 96 +++ ...e_queue_writer_review_decision_approval.py | 560 +++++++++++++ ...e_writer_review_decision_approval_gates.py | 257 ++++++ ..._writer_review_decision_approval_sample.py | 140 ++++ services/market_intel/phase.py | 2 +- templates/components/_ewoooc_shell.html | 5 + templates/ewoooc_base.html | 12 +- templates/market_intel/disabled.html | 177 +++- tests/test_external_tool_entrypoints.py | 3 + tests/test_frontend_v2_assets.py | 5 + tests/test_market_intel_skeleton.py | 760 ++++++++++++------ 26 files changed, 2100 insertions(+), 235 deletions(-) create mode 100644 docs/adr/ADR-037-webcrumbs-shared-ui-runtime.md create mode 100644 docs/guides/webcrumbs_shared_runtime.md create mode 100644 routes/market_intel_mcp_review_routes.py create mode 100644 services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval.py create mode 100644 services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval_gates.py create mode 100644 services/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval_sample.py diff --git a/.env.example b/.env.example index cda8b80..3a37b15 100644 --- a/.env.example +++ b/.env.example @@ -47,6 +47,22 @@ EMAIL_RECEIVER=receiver_email@gmail.com PUBLIC_URL=http://your_server_ip:port NGROK_AUTH_TOKEN=your_ngrok_auth_token +# ========================================== +# Webcrumbs 共用 UI Runtime +# ========================================== +# [預設 true] 啟用 momo-pro 全站 shell 載入自架 Webcrumbs runtime +WEBCRUMBS_ENABLED=true +# [預設] 110 Gateway / Nginx 上的共用 Webcrumbs 入口 +WEBCRUMBS_BASE_URL=https://webcrumbs.wooo.work +# [預設 @v0.1.5] 生產環境必須固定版本,不使用官方 @latest +WEBCRUMBS_RUNTIME_VERSION=@v0.1.5 +# [預設 /runtime/@v0.1.5] 若部署成 CDN 相容根路徑,可改為 /@v0.1.5 +WEBCRUMBS_RUNTIME_PATH=/runtime/@v0.1.5 +# [選填] 若實際 runtime URL 與 BASE_URL + RUNTIME_PATH 不同,用此欄位直接覆寫 +WEBCRUMBS_RUNTIME_URL= +# [預設] momo-pro 專用 plugin namespace;各 plugin 應使用版本化子目錄 +WEBCRUMBS_PLUGIN_BASE_URL=https://webcrumbs.wooo.work/plugins/momo-pro + # ========================================== # Image / Release Tag(docker-compose*.yml) # ========================================== diff --git a/AGENTS.md b/AGENTS.md index 20534ae..462f594 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -140,6 +140,7 @@ - AI 觀測台 UI 治理: `docs/guides/observability_ui_governance.md` - AI 自動化 Session SOP: `docs/guides/ai_automation_session_sop.md` - Browse.sh 爬蟲診斷手冊: `docs/guides/browse_sh_crawler_playbook.md` +- Webcrumbs 共用 UI Runtime: `docs/guides/webcrumbs_shared_runtime.md` - AI 競價情報 SOT: `docs/AI_INTELLIGENCE_MODULE_SOT.md` - Agent 角色矩陣: `docs/guides/codex_agent_roles.md` - ADR 索引: `docs/adr/README.md` diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 0c2bc51..88067db 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,8 @@ ================================================================================ 【已完成】 + - V10.507 接入 Webcrumbs 共用 UI Runtime:新增 `WEBCRUMBS_*` 環境設定與 `/webcrumbs` 診斷入口,`ewoooc_base.html` 會在 runtime 啟用且 URL 有效時載入自架 Webcrumbs script;側欄新增 Webcrumbs 入口,並補 `docs/guides/webcrumbs_shared_runtime.md` 作為跨專案接入手冊。生產仍需固定版本與自架 plugin URI,不使用官方 `@latest`。 + - V10.506 新增市場情報 MCP Fetch Candidate Queue Writer Review Decision Approval 安全預覽 gate:只審核 review decision 通過後由操作員貼回的人工 approval 摘要,確認 approval identity、row count、dedupe keys、approved decision、evidence refs、exact identity / variant / overwrite guard 與 operator boundary;API 不讀 token、不執行 CLI、不開 DB、不寫 approval/decision/match、不更新 review_state、不補 queue、不掛 scheduler,只放行到後續人工 approval writer preflight 設計。 - V10.505 新增市場情報 MCP Fetch Candidate Queue Writer Review Decision 安全預覽 gate:只審核 review inventory 通過後由操作員貼回的人工 candidate queue review decision 摘要,確認 decision identity、target table、row count、dedupe keys、`needs_review` 現態、允許決策集合、evidence refs、matched row exact-identity/variant/overwrite guard、operator confirmation 與 forbidden API actions;API 不讀 token、不執行 CLI、不開 DB、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler。UI 同步新增 Decision gates / Inventory link / Decision summary / Decision rows / Boundary next 預覽區。 - V10.504 新增市場情報 MCP Fetch Candidate Queue Writer Review Inventory 安全預覽 gate:只審核 writer review handoff 通過後由操作員貼回的 read-only candidate queue inventory 摘要,確認 handoff identity、target table、row count、dedupe keys、review_state、artifact paths、read-only query result、missing/duplicate rows、operator confirmation 與 forbidden API actions;API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不做 inventory query、不掛 scheduler。主 gate 拆為 inventory / gates / sample 三檔,避免單檔膨脹。 - V10.503 新增市場情報 MCP Fetch Candidate Queue Writer Review Handoff 安全預覽 gate:只審核 post-closeout inventory review 通過後的人工 candidate queue review 交接包,確認 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmation;API 不讀 token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler。 diff --git a/app.py b/app.py index 2b6d19f..09eae9c 100644 --- a/app.py +++ b/app.py @@ -58,7 +58,15 @@ except ImportError as e: # ================= 🔧 3. 系統核心配置 ================= # 從 config.py 匯入必要的設定 -from config import SYSTEM_VERSION, validate_critical_config +from config import ( + SYSTEM_VERSION, + WEBCRUMBS_BASE_URL, + WEBCRUMBS_ENABLED, + WEBCRUMBS_PLUGIN_BASE_URL, + WEBCRUMBS_RUNTIME_URL, + WEBCRUMBS_RUNTIME_VERSION, + validate_critical_config, +) sys_log = SystemLogger("Web_Server").get_logger() @@ -434,9 +442,16 @@ def inject_global_vars(): 'metabase_url': '/metabase', 'grist_url': '/grist', 'datetime_now': datetime.now(TAIPEI_TZ).strftime('%Y-%m-%d %H:%M:%S'), + 'webcrumbs_config': { + 'enabled': WEBCRUMBS_ENABLED, + 'base_url': WEBCRUMBS_BASE_URL, + 'runtime_url': WEBCRUMBS_RUNTIME_URL, + 'runtime_version': WEBCRUMBS_RUNTIME_VERSION, + 'plugin_base_url': WEBCRUMBS_PLUGIN_BASE_URL, + }, } -sys_log.info("[Template] ✅ 全域模板變數已注入 (metabase_url, grist_url)") +sys_log.info("[Template] ✅ 全域模板變數已注入 (metabase_url, grist_url, webcrumbs_config)") # ================= 🛠️ V9.72: 分類設定管理核心 ================= CATEGORIES_JSON_PATH = os.path.join(BASE_DIR, 'data', 'categories.json') diff --git a/config.py b/config.py index 541a221..1feca64 100644 --- a/config.py +++ b/config.py @@ -1,6 +1,7 @@ import os import json import sys +from urllib.parse import urlparse from dotenv import load_dotenv # 載入 .env 環境變數 @@ -111,6 +112,46 @@ EMAIL_RECEIVER = os.getenv('EMAIL_RECEIVER', '') # ========================================== PUBLIC_URL = os.getenv('PUBLIC_URL', 'https://mo.wooo.work') + +def _env_bool(name: str, default: str = 'false') -> bool: + return os.getenv(name, default).strip().lower() in {'1', 'true', 'yes', 'on'} + + +def _safe_public_http_url(value: str) -> str: + """只接受公開 http(s) URL,避免模板把 javascript/data URI 輸出成 script src。""" + candidate = (value or '').strip().rstrip('/') + if not candidate: + return '' + parsed = urlparse(candidate) + if parsed.scheme not in {'http', 'https'} or not parsed.netloc: + return '' + return candidate + + +# Webcrumbs 共用 microfrontend runtime。 +# 預設接 110 Gateway 上的內部部署;實際路徑不同時可用 WEBCRUMBS_RUNTIME_URL 直接覆寫。 +WEBCRUMBS_ENABLED = _env_bool('WEBCRUMBS_ENABLED', 'true') +WEBCRUMBS_BASE_URL = _safe_public_http_url( + os.getenv('WEBCRUMBS_BASE_URL', 'https://webcrumbs.wooo.work') +) +WEBCRUMBS_RUNTIME_VERSION = os.getenv('WEBCRUMBS_RUNTIME_VERSION', '@v0.1.5').strip().strip('/') +WEBCRUMBS_RUNTIME_PATH = os.getenv( + 'WEBCRUMBS_RUNTIME_PATH', + f'/runtime/{WEBCRUMBS_RUNTIME_VERSION}' if WEBCRUMBS_RUNTIME_VERSION else '/runtime/@v0.1.5', +).strip() +_webcrumbs_runtime_url = os.getenv('WEBCRUMBS_RUNTIME_URL', '').strip() +WEBCRUMBS_RUNTIME_URL = _safe_public_http_url(_webcrumbs_runtime_url) +if not WEBCRUMBS_RUNTIME_URL and WEBCRUMBS_BASE_URL: + WEBCRUMBS_RUNTIME_URL = _safe_public_http_url( + f"{WEBCRUMBS_BASE_URL}/{WEBCRUMBS_RUNTIME_PATH.lstrip('/')}" + ) +WEBCRUMBS_PLUGIN_BASE_URL = _safe_public_http_url( + os.getenv( + 'WEBCRUMBS_PLUGIN_BASE_URL', + f'{WEBCRUMBS_BASE_URL}/plugins/momo-pro' if WEBCRUMBS_BASE_URL else '', + ) +) + # ========================================== # 市場情報模組設定(預設全部關閉) # ========================================== @@ -350,7 +391,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.505" +SYSTEM_VERSION = "V10.507" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 @@ -361,4 +402,6 @@ def validate_critical_config(): for var in optional_vars: if not os.getenv(var): warnings.append(f"[Config] 選用設定 {var} 未設,部分功能可能停用") + if WEBCRUMBS_ENABLED and not WEBCRUMBS_RUNTIME_URL: + warnings.append("[Config] WEBCRUMBS_ENABLED=true 但 WEBCRUMBS_RUNTIME_URL 無效,Webcrumbs runtime 將不會載入") return warnings diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 93bcc4d..231af33 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -176,6 +176,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate queue writer review handoff gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_handoff` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_handoff` 在 post-closeout inventory review 通過後審核 operator candidate queue review handoff 摘要,檢查 inventory linkage、handoff identity、target table、row count、artifact paths、review contract、forbidden API actions 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不掛 scheduler,只放行到人工 candidate queue review。 - 2026-05-31 追加 MCP fetch candidate queue writer review inventory gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory_gates`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory_sample` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_inventory` 在 writer review handoff 通過後審核 operator read-only candidate queue inventory 摘要,檢查 handoff identity、target table、row count、dedupe keys、review_state、artifact paths、read-only query result、missing/duplicate rows 與 operator confirmations;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不更新 review_state、不做 inventory query、不掛 scheduler,只放行到後續人工 candidate queue review。 - 2026-05-31 追加 MCP fetch candidate queue writer review decision gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_gates`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_sample` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision` 在 review inventory 通過後審核 operator candidate queue review decision 摘要,檢查 decision identity、target table、row count、dedupe keys、`needs_review` 現態、允許決策集合、evidence refs、matched row exact-identity/variant/overwrite guard、operator confirmations 與 forbidden API actions;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler,只放行到 decision approval / writer preflight 設計。 +- 2026-05-31 追加 MCP fetch candidate queue writer review decision approval gate:`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_approval`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_approval_gates`、`services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_approval_sample` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval` 在 review decision 通過後只審核 operator human approval 摘要,確認 decision linkage、approval identity、target table、row count、dedupe keys、`approved_for_writer_preflight` approval result、decision/approval evidence refs、artifact paths、matched row exact-identity/variant/overwrite guard、operator confirmations 與 forbidden API actions;API/UI 不讀 approval token、不執行 CLI、不開 DB、不寫 approval record、不寫 decision record、不更新 review_state、不寫 match result、不補 queue、不掛 scheduler,只放行到後續 writer preflight 設計。此 endpoint 已拆入 `routes.market_intel_mcp_review_routes`,避免 `routes.market_intel_mcp_run_routes` 超過 800 行治理門檻。 - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/adr/ADR-037-webcrumbs-shared-ui-runtime.md b/docs/adr/ADR-037-webcrumbs-shared-ui-runtime.md new file mode 100644 index 0000000..d87070b --- /dev/null +++ b/docs/adr/ADR-037-webcrumbs-shared-ui-runtime.md @@ -0,0 +1,44 @@ +# ADR-037: Webcrumbs 共用 UI Runtime 接入 + +Status: Accepted +Date: 2026-05-31 + +## Context + +momo-pro 的前端已進入 V2/V3 視覺治理階段,後續會需要更穩定的跨頁 UI 元件、microfrontend/plugin loader 與跨專案視覺實驗入口。Webcrumbs 可作為共用 UI runtime,但若各專案各自引用官方 CDN、使用 `@latest`,或把上游 repo 整包放進 momo-pro,會造成供應鏈、版本漂移、授權與生產可控性風險。 + +本專案目前仍以 Flask/Jinja 為正式 runtime,不能因導入外部 UI runtime 而繞過既有登入、CSRF、health check、部署與真實資料不退化紅線。 + +## Decision + +Webcrumbs 在 momo-pro 中只作為「自架、固定版本、可診斷」的共用 UI runtime/plugin loader,不作為主前端框架替代品。 + +採用以下規則: + +1. runtime 由 `WEBCRUMBS_*` 環境變數設定,預設指向 `https://webcrumbs.wooo.work/runtime/@v0.1.5`。 +2. `ewoooc_base.html` 只在 `WEBCRUMBS_ENABLED=true` 且 runtime URL 通過 http(s) 檢查時輸出 script。 +3. 新增 `/webcrumbs` 診斷入口,只顯示 runtime URL、版本與 plugin base 狀態,不連到外部官方站作為正式入口。 +4. Webcrumbs plugin 必須使用自架且版本化 URI,例如 `https://webcrumbs.wooo.work/plugins/momo-pro///`。 +5. 禁止在生產使用官方 `@latest`、`app.webcrumbs.ai` 或未固定版本的官方 CDN。 +6. 不把 Webcrumbs 上游 repo 整包納入 momo-pro 主服務;若修改 runtime 本體,需另外處理 AGPL-3.0 授權義務。 + +## Alternatives Considered + +### A. 每個頁面自行引用官方 Webcrumbs CDN + +拒絕。版本不可控,且容易讓正式頁面受外部服務可用性與上游 breaking change 影響。 + +### B. 把 Webcrumbs repo vendoring 到 momo-pro + +拒絕。這會增加主服務體積、授權治理與升級成本,也會讓 UI runtime 與業務後端部署生命週期綁死。 + +### C. 暫不接任何 runtime,只保留純 Jinja/CSS + +保留作為 fallback,但不足以支援後續跨專案 microfrontend/plugin 化需求。導入 Webcrumbs 時仍維持現有 Jinja 頁面為主,不強制改寫。 + +## Consequences + +- momo-pro 可在不替換 Flask/Jinja 的前提下,逐步嵌入自架 UI plugin。 +- 生產部署需同步管理 `WEBCRUMBS_*` 變數與 110 Gateway runtime 路徑。 +- 後續任何 Webcrumbs plugin 上線前,仍需通過真實資料、權限、RWD、效能與 fallback 檢查。 +- 若 runtime URL 無效,系統只會跳過 script 載入並在 config warning / `/webcrumbs` 顯示狀態,不應阻斷主站。 diff --git a/docs/adr/README.md b/docs/adr/README.md index 097afe0..e9f9337 100644 --- a/docs/adr/README.md +++ b/docs/adr/README.md @@ -58,6 +58,7 @@ | [034](ADR-034-dynamic-model-router.md) | Caller × Context 動態 Model Router(短文 gemma3 / 複雜 SKU qwen3:14b / 重構 coder:32b) | Accepted | 2026-05-04 | | [035](ADR-035-cross-platform-market-campaign-intelligence.md) | 跨平台市場活動情報系統 | Accepted | 2026-05-06 | | [036](ADR-036-fastapi-strangler-not-frontend-prerequisite.md) | FastAPI Strangler Migration,不作為前端 V3 前置條件 | Accepted | 2026-05-12 | +| [037](ADR-037-webcrumbs-shared-ui-runtime.md) | Webcrumbs 共用 UI Runtime 接入 | Accepted | 2026-05-31 | ## 規範 diff --git a/docs/guides/webcrumbs_shared_runtime.md b/docs/guides/webcrumbs_shared_runtime.md new file mode 100644 index 0000000..57cfbbe --- /dev/null +++ b/docs/guides/webcrumbs_shared_runtime.md @@ -0,0 +1,64 @@ +# Webcrumbs 共用 UI Runtime 接入手冊 + +> 目的:讓 momo-pro 與其他專案共用同一套自架 Webcrumbs microfrontend runtime,避免每個專案各自引用官方 CDN 或複製 runtime。 + +## 定位 + +- Webcrumbs 在本專案只作為 microfrontend/plugin loader。 +- 不把 Webcrumbs 上游 repo 整包放進 momo-pro 主服務。 +- 不依賴官方 `app.webcrumbs.ai` 或官方 `cdn.webcrumbs.dev/@latest`。 +- 生產環境必須走自架 runtime,並固定版本。 + +## momo-pro 設定 + +`.env` 建議值: + +```env +WEBCRUMBS_ENABLED=true +WEBCRUMBS_BASE_URL=https://webcrumbs.wooo.work +WEBCRUMBS_RUNTIME_VERSION=@v0.1.5 +WEBCRUMBS_RUNTIME_PATH=/runtime/@v0.1.5 +WEBCRUMBS_RUNTIME_URL= +WEBCRUMBS_PLUGIN_BASE_URL=https://webcrumbs.wooo.work/plugins/momo-pro +``` + +若實際部署成 CDN 相容路徑,例如 `https://webcrumbs.wooo.work/@v0.1.5`,請改用: + +```env +WEBCRUMBS_RUNTIME_PATH=/@v0.1.5 +``` + +若部署路徑完全不同,直接設定: + +```env +WEBCRUMBS_RUNTIME_URL=https://webcrumbs.wooo.work/custom/runtime.js +``` + +## 頁面嵌入方式 + +全站 runtime 由 `templates/ewoooc_base.html` 載入。頁面只需要放 plugin tag: + +```html + +``` + +Plugin 目錄至少應提供: + +```text +bundle.js +style.css +``` + +## 治理規則 + +- Plugin URI 必須使用自架 domain。 +- Plugin 目錄必須版本化,不使用浮動 `latest`。 +- Plugin 不得包含 secret、token、內部 API key。 +- Plugin 若需要正式資料,必須讀 momo-pro 既有 API,不得自行打 DB。 +- 修改 Webcrumbs runtime 本體時需注意 AGPL-3.0 授權義務。 + +## 驗收 + +- `/webcrumbs` 顯示 runtime URL、版本與 plugin base。 +- `ewoooc_base.html` 在 `WEBCRUMBS_ENABLED=true` 且 runtime URL 有效時輸出 ` + {% set _webcrumbs = webcrumbs_config|default({}) %} + {% if _webcrumbs.enabled and _webcrumbs.runtime_url %} + + {% endif %} + {% if active_page|default('') in [ 'obs_overview', 'obs_agent_orchestration', 'obs_business_intel', 'obs_host_health', 'obs_ai_calls', 'obs_budget', diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index ef2b5bb..59a2bd7 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -1098,6 +1098,32 @@ +
+
+
+

MCP / DECISION APPROVAL

+

MCP Candidate Queue Writer Review Decision Approval

+
+ +
+
+ loading +
+
+
讀取 MCP Writer Review Decision Approval 中...
+
+
+ +
+ +
+
+
+
@@ -1623,6 +1649,7 @@ const mcpFetchCandidateQueueWriterReviewHandoffRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-handoff]'); const mcpFetchCandidateQueueWriterReviewInventoryRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-inventory]'); const mcpFetchCandidateQueueWriterReviewDecisionRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision]'); + const mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1639,7 +1666,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot && !mcpFetchCandidateQueueWriterReviewHandoffRoot && !mcpFetchCandidateQueueWriterReviewInventoryRoot && !mcpFetchCandidateQueueWriterReviewDecisionRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !mcpFetchCandidateQueueWriterPostCloseoutInventoryReviewRoot && !mcpFetchCandidateQueueWriterReviewHandoffRoot && !mcpFetchCandidateQueueWriterReviewInventoryRoot && !mcpFetchCandidateQueueWriterReviewDecisionRoot && !mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1812,6 +1839,12 @@ const mcpFetchCandidateQueueWriterReviewDecisionReview = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-review]') : null; const mcpFetchCandidateQueueWriterReviewDecisionRefresh = mcpFetchCandidateQueueWriterReviewDecisionRoot ? mcpFetchCandidateQueueWriterReviewDecisionRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-refresh]') : null; const mcpFetchCandidateQueueWriterReviewDecisionEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_decision') }}"; + const mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta = mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot ? mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-meta]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionApprovalBody = mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot ? mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-body]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionApprovalInput = mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot ? mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-input]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionApprovalReview = mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot ? mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-review]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionApprovalRefresh = mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot ? mcpFetchCandidateQueueWriterReviewDecisionApprovalRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-refresh]') : null; + const mcpFetchCandidateQueueWriterReviewDecisionApprovalEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -5431,6 +5464,141 @@ } }; + const renderMcpFetchCandidateQueueWriterReviewDecisionApprovalMeta = data => { + const approvalRows = data.approval_rows || data.operator_review_decision_approval_summary?.approved_rows || []; + mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_review_decision_approval_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || data.operator_review_decision_approval_summary?.approved_row_count || approvalRows.length || 0}`, + `preflight=${data.ready_for_candidate_queue_review_decision_writer_preflight ? 'ready' : 'blocked'}`, + `write=${data.api_writes_approval_record || data.api_updates_review_state ? 'api' : 'manual'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterReviewDecisionApprovalBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const decision = data.writer_review_decision_summary || {}; + const approval = data.operator_review_decision_approval_summary || {}; + const rows = data.approval_rows || approval.approved_rows || []; + const contract = data.approval_contract || {}; + const allowedApprovals = contract.allowed_next_states || []; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterReviewDecisionApprovalBody.innerHTML = ` +
此 decision approval 只審核人工批准摘要;API 不寫 approval record、不寫 decision record、不寫 match result、不更新 review_state、不補 queue、不讀 token、不執行 CLI、不開 DB、不掛 scheduler。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

APPROVAL GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 approval gates。
' + }
+
+
+

DECISION LINK

+
+ ${renderCheck('review_decision', `${decision.accepted ? 'accepted' : 'pending'} / rows=${decision.decision_row_count || 0}`, decision.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('review_decision_id', decision.review_decision_id || 'missing', decision.review_decision_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('target_table', decision.target_table || 'missing', decision.target_table === 'market_alert_review_queue' ? 'SAFE' : 'BLOCK')} + ${renderCheck('api_boundary', 'no DB / no decision write / no match write / no review_state update / no scheduler', decision.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

APPROVAL SUMMARY

+
+ ${renderCheck('approval_id', approval.approval_id || 'missing', approval.approval_id ? 'RECORDED' : 'BLOCK')} + ${renderCheck('approval_scope', approval.approval_scope || 'missing', approval.approval_scope === 'candidate_queue_review_decision_approval' ? 'SAFE' : 'BLOCK')} + ${renderCheck('approval_mode', approval.approval_mode || 'missing', approval.approval_mode === 'human_approval_only' ? 'MANUAL' : 'BLOCK')} + ${renderCheck('row_count', `${approval.approved_row_count || 0}/${decision.decision_row_count || 0}`, approval.approved_row_count === decision.decision_row_count ? 'MATCH' : 'BLOCK')} + ${renderCheck('artifact_path', approval.approval_artifact_path || 'missing', approval.approval_artifact_path_safe ? 'SAFE' : 'BLOCK')} + ${renderCheck('operator_boundaries', 'manual approval only / no API DB write/file/CLI/review_state/match/scheduler', approval.review_decision_checked && approval.approval_is_human_only && approval.manual_record_required && approval.no_api_cli_execution && approval.no_api_database_write && approval.no_api_review_state_update && approval.no_api_match_write && approval.no_api_queue_insert && approval.no_api_file_write && approval.no_scheduler_attach ? 'CONFIRMED' : 'BLOCK')} +
+
+
+

APPROVAL ROWS

+
${ + rows.length + ? rows.map((row, index) => renderCheck( + row.dedupe_key || `row_${index + 1}`, + `${row.current_review_state || 'missing'} -> ${row.approved_review_decision || 'missing'} / ${row.approval_bucket || 'missing'}`, + allowedApprovals.includes(row.approved_review_decision) && row.evidence_ref_safe && row.approval_notes_present && row.false_positive_guard_passed && row.variant_conflict_checked && row.overwrite_protection_checked ? 'READY' : 'BLOCK' + )).join('') + : '
尚未提供 approval rows。
' + }
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck('allowed_approvals', allowedApprovals.join(' / ') || 'missing', allowedApprovals.length ? 'LOCKED' : 'BLOCK')} + ${renderCheck('next_gate', contract.next_gate || 'missing', contract.next_gate === 'candidate_queue_review_decision_writer_preflight' ? 'PREFLIGHT' : 'BLOCK')} + ${renderCheck('api_side_effects', 'no approval record / no decision record / no match write / no review_state update / no scheduler', data.api_writes_approval_record || data.api_writes_decision_record || data.api_writes_match_result || data.api_updates_review_state || data.api_writes_database || data.scheduler_attached ? 'BLOCK' : 'CLOSED')} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterReviewDecisionApprovalInput && !mcpFetchCandidateQueueWriterReviewDecisionApprovalInput.value.trim() && data.sample_writer_review_decision_approval_package) { + mcpFetchCandidateQueueWriterReviewDecisionApprovalInput.value = JSON.stringify(data.sample_writer_review_decision_approval_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterReviewDecisionApproval = async () => { + if (!mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta || !mcpFetchCandidateQueueWriterReviewDecisionApprovalBody) return; + mcpFetchCandidateQueueWriterReviewDecisionApprovalBody.innerHTML = '
讀取 MCP Writer Review Decision Approval 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterReviewDecisionApprovalEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterReviewDecisionApprovalMeta(data); + renderMcpFetchCandidateQueueWriterReviewDecisionApprovalBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterReviewDecisionApprovalBody.innerHTML = `
MCP Writer Review Decision Approval 讀取失敗:${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterReviewDecisionApproval = async () => { + if (!mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta || !mcpFetchCandidateQueueWriterReviewDecisionApprovalBody || !mcpFetchCandidateQueueWriterReviewDecisionApprovalInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterReviewDecisionApprovalInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterReviewDecisionApprovalBody.innerHTML = `
JSON 格式錯誤:${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterReviewDecisionApprovalBody.innerHTML = '
審核 MCP Writer Review Decision Approval 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterReviewDecisionApprovalEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_review_decision_approval_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterReviewDecisionApprovalMeta(data); + renderMcpFetchCandidateQueueWriterReviewDecisionApprovalBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterReviewDecisionApprovalMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterReviewDecisionApprovalBody.innerHTML = `
MCP Writer Review Decision Approval 審核失敗:${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -14960,6 +15128,12 @@ if (mcpFetchCandidateQueueWriterReviewDecisionReview) { mcpFetchCandidateQueueWriterReviewDecisionReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterReviewDecision); } + if (mcpFetchCandidateQueueWriterReviewDecisionApprovalRefresh) { + mcpFetchCandidateQueueWriterReviewDecisionApprovalRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterReviewDecisionApproval); + } + if (mcpFetchCandidateQueueWriterReviewDecisionApprovalReview) { + mcpFetchCandidateQueueWriterReviewDecisionApprovalReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterReviewDecisionApproval); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -15235,6 +15409,7 @@ loadMcpFetchCandidateQueueWriterReviewHandoff(); loadMcpFetchCandidateQueueWriterReviewInventory(); loadMcpFetchCandidateQueueWriterReviewDecision(); + loadMcpFetchCandidateQueueWriterReviewDecisionApproval(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_external_tool_entrypoints.py b/tests/test_external_tool_entrypoints.py index 1c09d6a..f81ed2c 100644 --- a/tests/test_external_tool_entrypoints.py +++ b/tests/test_external_tool_entrypoints.py @@ -15,6 +15,7 @@ def test_metabase_and_grist_navigation_stays_inside_momo_pro(): assert "'metabase_url': '/metabase'" in app_source assert "'grist_url': '/grist'" in app_source assert "['sales', 'daily_sales', 'monthly', 'growth', 'metabase', 'grist']" in shell + assert 'href="/webcrumbs"' in shell assert "GRIST_URL=https://mo.wooo.work/grist" in env_example assert "APP_HOME_URL=${GRIST_APP_HOME_URL:-https://mo.wooo.work/grist}" in compose @@ -35,6 +36,8 @@ def test_external_tool_bridge_pages_are_diagnostic_not_blank(): assert "external-tool-checks" in template assert "external-tool-diagnostics" in template assert "external-tool-action-grid" in template + assert "def webcrumbs_status()" in route_source + assert "Webcrumbs 共用 UI Runtime" in route_source assert "尚未接入 proxy" in route_source assert "已由入口攔截" in route_source assert "AwoooI" not in route_source diff --git a/tests/test_frontend_v2_assets.py b/tests/test_frontend_v2_assets.py index 06b0b20..bc44440 100644 --- a/tests/test_frontend_v2_assets.py +++ b/tests/test_frontend_v2_assets.py @@ -22,11 +22,16 @@ def test_frontend_v2_shell_assets_exist_and_are_indexed(): def test_frontend_v2_shell_uses_real_runtime_context(): shell = (ROOT / "templates/components/_ewoooc_shell.html").read_text(encoding="utf-8") base = (ROOT / "templates/ewoooc_base.html").read_text(encoding="utf-8") + app_source = (ROOT / "app.py").read_text(encoding="utf-8") + config_source = (ROOT / "config.py").read_text(encoding="utf-8") assert "scheduler_stats" in shell assert "session.get('username')" in shell assert "next_run|default(None)" in shell assert "components/_ewoooc_shell.html" in base + assert "'webcrumbs_config': {" in app_source + assert "WEBCRUMBS_RUNTIME_URL" in config_source + assert "data-webcrumbs-runtime" in base assert 'name="ui" value="v2"' not in base forbidden_markers = [ diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index bfabab1..a6fba29 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -68,6 +68,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_review_inventory imp from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision import ( build_mcp_fetch_candidate_queue_writer_review_decision_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_review_decision_approval import ( + build_mcp_fetch_candidate_queue_writer_review_decision_approval_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1325,6 +1328,34 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-decision" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-approval" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-rows" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-review-decision-approval-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1795,7 +1826,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert bridge["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1953,7 +1984,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert contract["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -2086,7 +2117,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -2099,7 +2130,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert gate["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -2169,7 +2200,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -2183,7 +2214,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert audit["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -2257,7 +2288,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -2274,11 +2305,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert evidence["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2303,7 +2334,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2361,12 +2392,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2375,11 +2406,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert receipt["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2407,7 +2438,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2472,12 +2503,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2486,11 +2517,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert promotion["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2518,7 +2549,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2578,12 +2609,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2592,11 +2623,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert handoff["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2624,7 +2655,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2686,12 +2717,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2702,11 +2733,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert review["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2736,7 +2767,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2814,13 +2845,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2832,11 +2863,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert package["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2868,7 +2899,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2943,13 +2974,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2963,11 +2994,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert readiness["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -3002,11 +3033,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert readiness["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -3082,13 +3113,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -3102,11 +3133,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert receipt["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -3143,11 +3174,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert receipt["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -3226,13 +3257,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3248,11 +3279,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert parser["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3291,11 +3322,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert parser["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3380,13 +3411,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3402,11 +3433,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert handoff["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3445,11 +3476,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert handoff["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3539,13 +3570,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3562,11 +3593,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert review["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3603,11 +3634,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert review["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3698,13 +3729,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert get_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert post_data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3720,13 +3751,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3764,13 +3795,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3874,7 +3905,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3883,7 +3914,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3899,13 +3930,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( review["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert review["writer_cli_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False @@ -3941,13 +3972,13 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): writer_preflight_package=sample["writer_preflight_package"], writer_preflight_result=sample["writer_preflight_result"], writer_cli_review=sample["writer_cli_review"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( review["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert review["candidate_queue_writer_cli_review_ready"] is True @@ -4048,7 +4079,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4057,7 +4088,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True @@ -4074,7 +4105,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == ( @@ -4082,7 +4113,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_wit ) assert ( review["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert review["writer_run_package_review_payload_received"] is False assert ( @@ -4132,13 +4163,13 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_accepts_sample_revi writer_cli_review_package=sample["writer_cli_review_package"], writer_cli_review_result=sample["writer_cli_review_result"], writer_run_package_review=sample["writer_run_package_review"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_run_package_review" assert ( review["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4262,7 +4293,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4274,7 +4305,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4294,7 +4325,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert readiness["mode"] == ( @@ -4302,7 +4333,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_ ) assert ( readiness["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert readiness["writer_run_readiness_payload_received"] is False assert ( @@ -4348,13 +4379,13 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_accepts_sample_review(): ], writer_run_package_review_result=sample["writer_run_package_review_result"], operator_readiness=sample["operator_readiness"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert readiness["mode"] == "mcp_fetch_candidate_queue_writer_run_readiness_review" assert ( readiness["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4470,7 +4501,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4482,7 +4513,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4502,7 +4533,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_without_payload(): receipt = build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert receipt["mode"] == ( @@ -4510,7 +4541,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_wit ) assert ( receipt["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert receipt["writer_run_receipt_review_payload_received"] is False assert ( @@ -4555,13 +4586,13 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_accepts_sample_revi writer_run_readiness_package=sample["writer_run_readiness_package"], writer_run_readiness_result=sample["writer_run_readiness_result"], writer_run_receipt=sample["writer_run_receipt"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert receipt["mode"] == "mcp_fetch_candidate_queue_writer_run_receipt_review" assert ( receipt["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( receipt["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4693,7 +4724,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4705,7 +4736,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4725,7 +4756,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_without_payload(): closeout = build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert closeout["mode"] == ( @@ -4733,7 +4764,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_wi ) assert ( closeout["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert closeout["writer_run_closeout_review_payload_received"] is False assert ( @@ -4786,13 +4817,13 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_accepts_sample_rev ], writer_run_receipt_review_result=sample["writer_run_receipt_review_result"], operator_closeout=sample["operator_closeout"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert closeout["mode"] == "mcp_fetch_candidate_queue_writer_run_closeout_review" assert ( closeout["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( closeout["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] @@ -4933,7 +4964,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4945,7 +4976,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post ) assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] @@ -4969,7 +5000,7 @@ def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview_is_safe_without_payload(): inventory = ( build_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) ) @@ -4978,7 +5009,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_preview ) assert ( inventory["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert inventory["post_closeout_inventory_review_payload_received"] is False assert ( @@ -5034,7 +5065,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepts "writer_run_closeout_review_result" ], operator_inventory=sample["operator_inventory"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) ) @@ -5044,7 +5075,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_accepts ) assert ( inventory["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( inventory[ @@ -5194,7 +5225,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5207,7 +5238,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g ) assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data[ @@ -5230,7 +5261,7 @@ def test_mcp_fetch_candidate_queue_writer_post_closeout_inventory_review_route_g def test_mcp_fetch_candidate_queue_writer_review_handoff_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_queue_writer_review_handoff_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert handoff["mode"] == ( @@ -5238,7 +5269,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_preview_is_safe_without ) assert ( handoff["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert handoff["review_handoff_payload_received"] is False assert ( @@ -5286,13 +5317,13 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_accepts_sample_review() "writer_post_closeout_inventory_review_result" ], operator_handoff=sample["operator_handoff"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert handoff["mode"] == "mcp_fetch_candidate_queue_writer_review_handoff" assert ( handoff["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( handoff["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] @@ -5450,7 +5481,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_prev ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5460,7 +5491,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_prev assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_handoff" assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_handoff_accepted"] @@ -5483,7 +5514,7 @@ def test_mcp_fetch_candidate_queue_writer_review_handoff_route_get_and_post_prev def test_mcp_fetch_candidate_queue_writer_review_inventory_preview_is_safe_without_payload(): inventory = build_mcp_fetch_candidate_queue_writer_review_inventory_preview( - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert inventory["mode"] == ( @@ -5491,7 +5522,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_preview_is_safe_witho ) assert ( inventory["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert inventory["review_inventory_payload_received"] is False assert ( @@ -5535,13 +5566,13 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_accepts_sample_invent writer_review_handoff_package=sample["writer_review_handoff_package"], writer_review_handoff_result=sample["writer_review_handoff_result"], operator_review_inventory=sample["operator_review_inventory"], - phase="phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision", + phase="phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval", ) assert inventory["mode"] == "mcp_fetch_candidate_queue_writer_review_inventory" assert ( inventory["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( inventory["mcp_fetch_candidate_queue_writer_review_inventory_accepted"] @@ -5677,7 +5708,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5687,7 +5718,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_inventory" assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_inventory_accepted"] @@ -5864,7 +5895,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -5874,7 +5905,7 @@ def test_mcp_fetch_candidate_queue_writer_review_inventory_route_get_and_post_pr assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_inventory" assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_inventory_accepted"] @@ -6117,7 +6148,7 @@ def test_mcp_fetch_candidate_queue_writer_review_decision_route_get_and_post_pre ) assert ( get_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -6127,7 +6158,7 @@ def test_mcp_fetch_candidate_queue_writer_review_decision_route_get_and_post_pre assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_review_decision" assert ( post_data["phase"] - == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert ( post_data["mcp_fetch_candidate_queue_writer_review_decision_accepted"] @@ -6149,11 +6180,276 @@ def test_mcp_fetch_candidate_queue_writer_review_decision_route_get_and_post_pre assert post_data["api_opens_database_connection"] is False +def test_mcp_fetch_candidate_queue_writer_review_decision_approval_preview_is_safe_without_payload(): + approval = ( + build_mcp_fetch_candidate_queue_writer_review_decision_approval_preview( + phase="phase-test" + ) + ) + + assert approval["mode"] == ( + "mcp_fetch_candidate_queue_writer_review_decision_approval_preview" + ) + assert approval["phase"] == "phase-test" + assert ( + approval[ + "mcp_fetch_candidate_queue_writer_review_decision_approval_accepted" + ] + is False + ) + assert approval["candidate_queue_writer_review_decision_approval_ready"] is False + assert approval["ready_for_candidate_queue_review_decision_writer_preflight"] is False + assert approval["ready_for_candidate_queue_review_state_writer"] is False + assert approval["ready_for_api_review_state_update"] is False + assert approval["ready_for_api_database_write"] is False + assert approval["api_executes_cli"] is False + assert approval["api_reads_approval_token"] is False + assert approval["api_opens_database_connection"] is False + assert approval["api_writes_database"] is False + assert approval["api_updates_review_state"] is False + assert approval["approval_record_written"] is False + assert approval["candidate_review_state_updated"] is False + assert approval["scheduler_attached"] is False + assert ( + "candidate_queue_review_decision_payload_or_result_received" + in approval["blocked_reasons"] + ) + assert "candidate_queue_review_decision_approval_payload_received" in approval[ + "blocked_reasons" + ] + assert ( + "operator_review_decision_approval" + in approval["sample_writer_review_decision_approval_package"] + ) + + +def test_mcp_fetch_candidate_queue_writer_review_decision_approval_accepts_sample_approval(): + sample = build_mcp_fetch_candidate_queue_writer_review_decision_approval_preview()[ + "sample_writer_review_decision_approval_package" + ] + approval = build_mcp_fetch_candidate_queue_writer_review_decision_approval_preview( + writer_review_decision_package=sample["writer_review_decision_package"], + writer_review_decision_result=sample["writer_review_decision_result"], + operator_review_decision_approval=sample[ + "operator_review_decision_approval" + ], + phase="phase-test", + ) + + assert ( + approval["mode"] + == "mcp_fetch_candidate_queue_writer_review_decision_approval" + ) + assert approval["phase"] == "phase-test" + assert ( + approval[ + "mcp_fetch_candidate_queue_writer_review_decision_approval_accepted" + ] + is True + ) + assert approval["writer_review_decision_accepted"] is True + assert approval["candidate_queue_writer_review_decision_approval_ready"] is True + assert approval["ready_for_candidate_queue_review_decision_writer_preflight"] is True + assert approval["ready_for_candidate_queue_review_state_writer"] is False + assert approval["ready_for_api_review_state_update"] is False + assert approval["ready_for_api_database_write"] is False + assert approval["blocked_reasons"] == [] + assert approval["passed_gate_count"] == approval["gate_count"] + decision = approval["writer_review_decision_summary"] + summary = approval["operator_review_decision_approval_summary"] + assert summary["approval_id"] + assert summary["target_table"] == "market_alert_review_queue" + assert summary["review_decision_id"] == decision["review_decision_id"] + assert summary["review_inventory_id"] == decision["review_inventory_id"] + assert summary["handoff_id"] == decision["handoff_id"] + assert summary["inventory_review_id"] == decision["inventory_review_id"] + assert summary["run_package_id"] == decision["run_package_id"] + assert summary["receipt_id"] == decision["receipt_id"] + assert summary["approved_row_count"] == decision["decision_row_count"] + assert len(summary["expected_dedupe_keys"]) == decision["decision_row_count"] + assert summary["approval_scope"] == "candidate_queue_review_decision_approval" + assert summary["approval_mode"] == "human_approval_only" + assert all( + row["approved_review_decision"] + in { + "matched", + "low_score", + "identity_veto", + "unit_comparable", + "fresh_search_required", + "deferred", + } + for row in approval["approved_rows"] + ) + assert summary["secret_or_token_submitted_to_api"] is False + assert approval["network_request_allowed"] is False + assert approval["api_executes_cli"] is False + assert approval["api_reads_approval_token"] is False + assert approval["api_writes_file"] is False + assert approval["api_writes_database"] is False + assert approval["api_updates_review_state"] is False + assert approval["api_writes_decision_record"] is False + assert approval["api_writes_match_result"] is False + assert approval["candidate_queue_persisted"] is False + assert approval["candidate_review_state_updated"] is False + assert approval["database_write_executed"] is False + assert approval["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_review_decision_approval_blocks_unsafe_approval(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_review_decision_approval_preview()[ + "sample_writer_review_decision_approval_package" + ] + ) + ) + approval_payload = sample["operator_review_decision_approval"] + approval_payload["review_decision_id"] = "wrong-decision" + approval_payload["target_table"] = "market_product_matches" + approval_payload["approval_scope"] = "auto_review_state_update" + approval_payload["approved_row_count"] = 999 + approval_payload["expected_approved_row_count"] = 999 + approval_payload["approval_token"] = TEST_APPROVAL_TOKEN + approval_payload["api_execution_allowed"] = True + approval_payload["real_write_allowed_by_api"] = True + approval_payload["api_candidate_review_allowed"] = True + approval_payload["api_updates_review_state"] = True + approval_payload["api_writes_match_result"] = True + approval_payload["decision_approval_persisted"] = True + approval_payload["approved_rows"][0][ + "approved_review_decision" + ] = "approved_for_api_write" + approval_payload["approved_rows"][0]["approval_notes"] = "" + approval_payload["approved_rows"][0]["evidence_ref"] = "/tmp/unsafe.json" + approval_payload["approved_rows"][0]["false_positive_guard_passed"] = False + approval_payload["operator_confirmations"]["approval_is_human_only"] = False + approval_payload["operator_confirmations"]["no_api_review_state_update"] = False + + approval = build_mcp_fetch_candidate_queue_writer_review_decision_approval_preview( + writer_review_decision_package=sample["writer_review_decision_package"], + writer_review_decision_result=sample["writer_review_decision_result"], + operator_review_decision_approval=approval_payload, + ) + + assert ( + approval[ + "mcp_fetch_candidate_queue_writer_review_decision_approval_accepted" + ] + is False + ) + assert approval["writer_review_decision_accepted"] is True + assert "candidate_queue_review_decision_approval_identity_matches_decision" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_target_table_safe" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_scope_safe" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_row_count_matches_decision" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_values_allowed" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_row_evidence_complete" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_operator_boundaries_confirmed" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_no_api_execution_or_real_write" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_no_secret_or_token_key" in approval[ + "blocked_reasons" + ] + assert "candidate_queue_review_decision_approval_side_effect_free" in approval[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + approval, + ensure_ascii=False, + sort_keys=True, + ) + assert approval["api_executes_cli"] is False + assert approval["api_reads_approval_token"] is False + assert approval["api_writes_database"] is False + assert approval["api_updates_review_state"] is False + assert approval["candidate_review_state_updated"] is False + assert approval["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_review_decision_approval_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_review_decision_approval_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval", + json={"writer_review_decision_approval_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == ( + "mcp_fetch_candidate_queue_writer_review_decision_approval_preview" + ) + assert ( + get_data["phase"] + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_updates_review_state"] is False + assert post_response.status_code == 200 + assert ( + post_data["mode"] + == "mcp_fetch_candidate_queue_writer_review_decision_approval" + ) + assert ( + post_data["phase"] + == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" + ) + assert ( + post_data[ + "mcp_fetch_candidate_queue_writer_review_decision_approval_accepted" + ] + is True + ) + assert post_data["ready_for_candidate_queue_review_decision_writer_preflight"] is True + assert post_data["ready_for_api_review_state_update"] is False + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["api_updates_review_state"] is False + assert post_data["approval_record_written"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["candidate_review_state_updated"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -6201,7 +6497,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -6212,7 +6508,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert acceptance["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -6254,7 +6550,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -6266,7 +6562,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert review["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -6377,7 +6673,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -6416,7 +6712,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert review["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -6478,7 +6774,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -6558,7 +6854,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert handoff["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -6622,7 +6918,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -6681,7 +6977,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert queue_draft["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -6755,7 +7051,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -6818,7 +7114,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert approval["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -6896,7 +7192,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -6959,7 +7255,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert transaction["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -7039,7 +7335,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -12750,7 +13046,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -12825,7 +13121,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -13097,7 +13393,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -13385,7 +13681,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -13695,7 +13991,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -13998,7 +14294,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -14257,7 +14553,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -14530,7 +14826,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -14778,7 +15074,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -15008,7 +15304,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -15245,7 +15541,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -15487,7 +15783,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -15763,7 +16059,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -16040,7 +16336,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -16319,7 +16615,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -16648,7 +16944,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -16910,7 +17206,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -17174,7 +17470,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -17444,7 +17740,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -17732,7 +18028,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -18019,7 +18315,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -18105,7 +18401,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -18162,7 +18458,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -18251,7 +18547,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -18305,7 +18601,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -18361,7 +18657,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -18427,7 +18723,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -18729,7 +19025,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -18777,7 +19073,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -18826,7 +19122,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -18884,7 +19180,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -18950,7 +19246,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -19021,7 +19317,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -19097,7 +19393,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -19179,7 +19475,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -19265,7 +19561,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -19348,7 +19644,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -19431,7 +19727,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -19517,7 +19813,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -19608,7 +19904,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -19718,7 +20014,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -19804,7 +20100,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -19861,7 +20157,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -19914,7 +20210,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -19967,7 +20263,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -20028,7 +20324,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -20097,7 +20393,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -20169,7 +20465,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -20242,7 +20538,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -20313,7 +20609,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -20378,7 +20674,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -20449,7 +20745,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -20522,7 +20818,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -20599,7 +20895,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -20676,7 +20972,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -20753,7 +21049,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -20827,7 +21123,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -20906,7 +21202,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -20993,7 +21289,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -21074,7 +21370,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -21156,7 +21452,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -21239,7 +21535,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -21264,7 +21560,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -21302,7 +21598,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -21313,7 +21609,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -21349,7 +21645,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -21360,7 +21656,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -21401,7 +21697,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -21412,7 +21708,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -21460,7 +21756,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -21472,7 +21768,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -21518,7 +21814,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -21531,7 +21827,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert plan["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -21616,7 +21912,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -21694,7 +21990,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -21709,7 +22005,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert readiness["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -22168,6 +22464,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_review_decision_approval_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -22563,6 +22865,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/mcp_fetch_candidate_queue_writer_review_decision_approval" + in readiness["production_smoke_targets"] + ) assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -26604,7 +26910,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert drill["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -26719,7 +27025,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -26731,7 +27037,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert review["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -26846,7 +27152,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -26859,7 +27165,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert smoke["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -26921,7 +27227,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -26934,7 +27240,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert inventory["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -27078,7 +27384,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -27314,7 +27620,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -27343,7 +27649,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_137_market_intel_mcp_fetch_candidate_queue_writer_review_decision" + assert data["phase"] == "phase_138_market_intel_mcp_fetch_candidate_queue_writer_review_decision_approval" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False