From 64b4ec39ece6fcdd844bbb0154a600a3ce14a935 Mon Sep 17 00:00:00 2001 From: OoO Date: Sun, 31 May 2026 14:44:43 +0800 Subject: [PATCH] V10.498 add market intel queue writer run readiness gate --- TODO_NEXT_STEPS.txt | 1 + config.py | 2 +- ...s-platform-market-campaign-intelligence.md | 1 + .../code_modularization_inventory_20260430.md | 1 + .../current_execution_queue_20260524.md | 1 + docs/memory/history_logs.md | 1 + routes/market_intel_mcp_run_routes.py | 51 ++ services/market_intel/deployment_readiness.py | 63 ++ ...ch_candidate_queue_writer_run_readiness.py | 639 ++++++++++++++++++ services/market_intel/phase.py | 2 +- templates/market_intel/disabled.html | 169 ++++- tests/test_market_intel_skeleton.py | 619 ++++++++++++----- 12 files changed, 1360 insertions(+), 190 deletions(-) create mode 100644 services/market_intel/mcp_fetch_candidate_queue_writer_run_readiness.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index afc1930..e756411 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.498 新增市場情報 MCP Fetch Candidate Queue Writer Run Readiness 安全預覽 gate：只審核 run package review 後的操作員 readiness 證據，確認 run readiness artifact、reviewed sample、備份、read-only preflight 與 post-write smoke 路徑安全，以及 CLI-only / approval token shell-only 邊界；API 不產檔、不讀 token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler。 - V10.497 新增市場情報 MCP Fetch Candidate Queue Writer Run Package Review 安全預覽 gate：只審核 CLI review 通過後的 operator run package 草案，要求 package id、artifact manifest、operator shell command sequence、candidate/dedupe keys 與 CLI review 對齊；API 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - V10.496 新增市場情報 MCP Fetch Candidate Queue Writer CLI Review 安全預覽 gate：只審核 writer preflight 後的 CLI review 草案，確認 script path、target table、preflight id、payload row count、candidate/dedupe keys 與 command argv；禁止 API 執行 CLI、禁止 `--execute` / `--apply-real-write` / `--approval-token` 進 payload，API 不讀 token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - V10.495 新增市場情報 MCP Fetch Candidate Queue Writer Preflight 安全預覽 gate：只審核 queue review 後的 writer preflight 草案，確認 target_table、write_mode、dedupe strategy、insert columns、payload rows 與候選 key 對齊；API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 diff --git a/config.py b/config.py index bce5074..60edd19 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.497" +SYSTEM_VERSION = "V10.498" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 9470a92..f6313af 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -169,6 +169,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate queue writer preflight gate：`services.market_intel.mcp_fetch_candidate_queue_writer_preflight` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 在 queue review 通過後審核 writer preflight 草案，檢查 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows、候選 key 對齊、小批次上限、操作員無寫入/無連外/無 CLI/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不掛 scheduler，只放行到 CLI writer review。 - 2026-05-31 追加 MCP fetch candidate queue writer CLI review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_cli_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review` 在 writer preflight 通過後審核 CLI review 草案，檢查 script path、target table、preflight id、payload row count、candidate/dedupe keys、`--sample-json`、`--read-only-preflight` 與 forbidden flags；API/UI 不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler，只放行到 operator run package review。 - 2026-05-31 追加 MCP fetch candidate queue writer run package review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review` 在 CLI review 通過後審核 operator run package 草案，檢查 package identity、artifact manifest、operator shell command sequence、candidate/dedupe keys、CLI review id 與 preflight id；API/UI 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 +- 2026-05-31 追加 MCP fetch candidate queue writer run readiness gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness` 在 run package review 通過後審核 operator readiness 證據，檢查 run readiness artifact、reviewed sample、備份、read-only preflight、post-write smoke 路徑、操作員覆核確認、CLI-only 與 approval token shell-only 邊界；API/UI 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到後續 run receipt review。 - 2026-05-18 追加 scheduler attach plan preview：`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB；排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview：`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP；價格只能作為輔助訊號，不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview：`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB；高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 13ac918..2a1372d 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -47,6 +47,7 @@ - 2026-05-31 追記：`services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py` 目前 628 行，略過 600 行提醒門檻；暫不拆分的理由是 gate 條件、sample payload 與 side-effect blocklist 需留在單一 preview module 便於審核，下一個 writer CLI review gate 若共用相同常數再抽 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer CLI review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_cli_review.py` 為 591 行，仍低於 600 行提醒門檻。 - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run package review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py` 為 660 行，略過 600 行提醒門檻。暫不拆分的理由是 run package gate 需要把 CLI review linkage、artifact manifest、operator shell command sequence 與 side-effect blocklist 放在單一 preview module 便於安全審核；若下一段 run readiness review 重複相同 policy，應抽出 writer policy helper。 +- 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run readiness gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_readiness.py` 為 640 行，略過 600 行提醒門檻。暫不拆分的理由是 readiness gate 需同時審核上一段 run package review linkage、operator artifact path policy、CLI-only/token-only confirmation 與 side-effect blocklist；若後續 run receipt gate 再重複 policy，應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-24 追記：同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數；此處只更新 inventory，不變更 Code Review 行為。 - 2026-05-21 追記：同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 - 2026-05-21 追記：同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index 828d6a3..64c45b2 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -93,6 +93,7 @@ - 2026-05-31 起，`V10.495` 新增市場情報 MCP Fetch Candidate Queue Writer Preflight gate：在 queue review 通過後只審核 writer preflight 草案，要求 target table、write mode、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊；仍不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - 2026-05-31 起，`V10.496` 新增市場情報 MCP Fetch Candidate Queue Writer CLI Review gate：在 writer preflight 通過後只審核 CLI review 草案，要求 script path、target table、preflight id、row count、candidate/dedupe keys 與 read-only command argv 對齊；仍不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - 2026-05-31 起，`V10.497` 新增市場情報 MCP Fetch Candidate Queue Writer Run Package Review gate：在 CLI review 通過後只審核 operator run package 草案，要求 artifact manifest、operator shell command sequence、package identity、candidate/dedupe keys 與 CLI review 對齊；仍不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 +- 2026-05-31 起，`V10.498` 新增市場情報 MCP Fetch Candidate Queue Writer Run Readiness gate：在 run package review 通過後只審核 operator readiness 證據，要求 run readiness artifact、reviewed sample、備份、read-only preflight 與 post-write smoke 路徑安全，並確認 CLI-only、approval token shell-only、無 API/DB/file/scheduler 副作用；仍不產檔、不讀 token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到後續 run receipt review。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index c3dc3f2..b8faff2 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24：PChome 近門檻身份回收第二輪 +- **V10.498 市場情報 MCP Fetch Candidate Queue Writer Run Readiness gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness` 與 UI preview，只審核 run package review 後的 operator readiness 證據；要求 run readiness artifact、reviewed sample、備份、read-only preflight 與 post-write smoke 路徑安全，並確認 CLI-only、approval token shell-only、無 API/DB/file/scheduler 副作用。API 不產檔、不讀 token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到後續 run receipt review。 - **V10.497 市場情報 MCP Fetch Candidate Queue Writer Run Package Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review` 與 UI preview，只審核 CLI review 後的 operator run package 草案；要求 package identity、artifact manifest、operator shell command sequence、candidate/dedupe keys 與 CLI review 完全對齊，且 API 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - **V10.496 市場情報 MCP Fetch Candidate Queue Writer CLI Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review` 與 UI preview，只審核 writer preflight 後的 CLI review 草案；要求 script path、target table、preflight id、payload row count、candidate/dedupe keys 與 command argv 完全對齊，並禁止 `--execute`、`--apply-real-write`、`--approval-token` 進 API payload，且 API 不執行 CLI、不讀 token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - **V10.495 市場情報 MCP Fetch Candidate Queue Writer Preflight gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 與 UI preview，只審核 queue review 後的 writer preflight 草案；要求 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊，且 API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index 4228da2..dd985f9 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -34,6 +34,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( build_mcp_fetch_candidate_queue_writer_run_package_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -398,3 +401,51 @@ def market_intel_mcp_fetch_candidate_queue_writer_run_package_review(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_run_readiness(): + writer_run_package_review_package = {} + writer_run_package_review_result = None + operator_readiness = {} + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_run_readiness_package") + or payload.get("candidate_queue_writer_run_readiness") + or payload.get("writer_run_readiness") + or payload.get("run_readiness") + or payload + ) + writer_run_package_review_package = ( + package.get("writer_run_package_review_package") + or package.get("candidate_queue_writer_run_package_review") + or package.get("writer_run_package_review") + or package.get("run_package_review_package") + or {} + ) + writer_run_package_review_result = ( + package.get("writer_run_package_review_result") + or package.get("mcp_fetch_candidate_queue_writer_run_package_review") + ) + operator_readiness = ( + package.get("operator_readiness") + or package.get("writer_run_readiness") + or package.get("candidate_queue_writer_run_readiness") + or package.get("readiness_payload") + or {} + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview( + writer_run_package_review_package=writer_run_package_review_package, + writer_run_package_review_result=writer_run_package_review_result, + operator_readiness=operator_readiness, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 686b034..9e08590 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -90,6 +90,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( build_mcp_fetch_candidate_queue_writer_run_package_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -237,6 +240,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -301,6 +309,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_run_readiness = ( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -918,6 +931,55 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "scheduler_attached" ] ), + "mcp_fetch_candidate_queue_writer_run_readiness_preview_safe": bool( + mcp_fetch_candidate_queue_writer_run_readiness["mode"] + == "mcp_fetch_candidate_queue_writer_run_readiness_preview" + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "payload_persisted" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "run_readiness_persisted" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "run_readiness_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "run_readiness_file_written" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "package_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "api_writes_file" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "api_executes_cli" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "api_reads_approval_token" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "api_writes_database" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "api_uses_external_network" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "cli_executed" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "file_written" + ] + and not mcp_fetch_candidate_queue_writer_run_readiness[ + "scheduler_attached" + ] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1240,6 +1302,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_candidate_queue_writer_preflight": mcp_fetch_candidate_queue_writer_preflight, "mcp_fetch_candidate_queue_writer_cli_review": mcp_fetch_candidate_queue_writer_cli_review, "mcp_fetch_candidate_queue_writer_run_package_review": mcp_fetch_candidate_queue_writer_run_package_review, + "mcp_fetch_candidate_queue_writer_run_readiness": mcp_fetch_candidate_queue_writer_run_readiness, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_run_readiness.py b/services/market_intel/mcp_fetch_candidate_queue_writer_run_readiness.py new file mode 100644 index 0000000..cf6ae26 --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_run_readiness.py @@ -0,0 +1,639 @@ +"""市場情報 MCP fetch candidate queue writer run readiness preview。 + +本模組只審核 run package review 後的 operator readiness 證據；API/UI +不建立 artifact、不寫檔、不執行 CLI、不讀 approval token、不開 DB、不寫 +queue、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE +from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview, +) + + +MAX_READY_PAYLOAD_ROWS = 80 +ARTIFACT_PREFIX = "artifacts/market_intel/" +BACKUP_PREFIX = "scripts/tools/backups/" + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "secret", + "session_cookie", + "token", +) + +SAFE_SECRET_METADATA_KEYS = { + "approval_token_shell_only_required", + "no_approval_token_payload", + "operator_confirmed_no_approval_token_payload", + "operator_confirmed_one_time_token_shell_only", + "one_time_token_shell_only_confirmed", +} + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_cli_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_execution_allowed", + "api_executed_cli", + "api_executes", + "api_executes_cli", + "api_opens_database_connection", + "api_reads_approval_token", + "api_uses_external_network", + "api_writes_database", + "api_writes_file", + "apply_real_write", + "attach_scheduler", + "candidate_queue_created", + "candidate_queue_persisted", + "candidate_review_state_updated", + "cli_executed", + "command_executed", + "database_commit_executed", + "database_connection_opened", + "database_session_created", + "database_write_executed", + "execute_requested", + "executes_now", + "external_network_executed", + "file_written", + "network_request_allowed", + "opens_database_connection", + "package_artifact_created", + "payload_persisted", + "ready_for_api_database_write", + "ready_for_real_write", + "real_write_allowed", + "review_state_update_executed", + "run_readiness_artifact_created", + "run_readiness_file_written", + "run_readiness_persisted", + "scheduler_attach", + "scheduler_attached", + "write_database", + "writes_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _safe_path(value, *, prefixes, suffixes): + if not isinstance(value, str): + return False + normalized = value.strip().replace("\\", "/") + if not normalized or normalized.startswith("/"): + return False + parts = [part for part in normalized.split("/") if part] + if any(part in (".", "..") for part in parts): + return False + return normalized.startswith(prefixes) and normalized.endswith(suffixes) + + +def _contains_forbidden_key(value, forbidden_keys, *, safe_keys=None): + safe_keys = safe_keys or set() + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in safe_keys and isinstance(nested, bool): + continue + if any(forbidden_key in normalized_key for forbidden_key in forbidden_keys): + return True + if _contains_forbidden_key(nested, forbidden_keys, safe_keys=safe_keys): + return True + elif isinstance(value, list): + return any( + _contains_forbidden_key(item, forbidden_keys, safe_keys=safe_keys) + for item in value + ) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _run_package_review_from_inputs(review_package, review_result, phase): + if isinstance(review_result, dict) and review_result: + return review_result + + review_package = _as_dict(review_package) + return build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + writer_cli_review_package=( + review_package.get("writer_cli_review_package") + or review_package.get("candidate_queue_writer_cli_review") + or review_package.get("writer_cli_review") + or review_package.get("cli_review_package") + or {} + ), + writer_cli_review_result=( + review_package.get("writer_cli_review_result") + or review_package.get("mcp_fetch_candidate_queue_writer_cli_review") + ), + writer_run_package_review=( + review_package.get("writer_run_package_review") + or review_package.get("candidate_queue_writer_run_package_review") + or review_package.get("run_package_review") + or review_package.get("package_review") + or review_package.get("review_payload") + ), + phase=phase, + ) + + +def _sample_run_readiness_package(): + review_preview = build_mcp_fetch_candidate_queue_writer_run_package_review_preview() + review_package = review_preview["sample_writer_run_package_review_package"] + review_result = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + writer_cli_review_package=review_package["writer_cli_review_package"], + writer_cli_review_result=review_package["writer_cli_review_result"], + writer_run_package_review=review_package["writer_run_package_review"], + ) + operator_readiness = { + "run_readiness_artifact_path": ( + ARTIFACT_PREFIX + "candidate-queue-writer-run-readiness-sample.json" + ), + "reviewed_sample_json_path": ( + ARTIFACT_PREFIX + "candidate-queue-reviewed-sample.json" + ), + "backup_artifact_path": BACKUP_PREFIX + "momo_pro_system_backup_sample.zip", + "read_only_preflight_output_path": ( + ARTIFACT_PREFIX + "candidate-queue-writer-preflight-sample.json" + ), + "postwrite_smoke_plan_path": ( + ARTIFACT_PREFIX + "candidate-queue-writer-postwrite-smoke-plan.json" + ), + "run_package_reviewed": True, + "artifact_manifest_reviewed": True, + "command_bundle_reviewed": True, + "payload_count_reviewed": True, + "target_table_reviewed": True, + "backup_artifact_reviewed": True, + "read_only_preflight_reviewed": True, + "postwrite_smoke_required": True, + "one_time_token_shell_only_confirmed": True, + "operator_confirmed_no_approval_token_payload": True, + "operator_confirmed_no_api_cli_execution": True, + "operator_confirmed_no_api_database_write": True, + "operator_confirmed_no_api_file_write": True, + "operator_confirmed_no_external_network": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_persistence": True, + "api_execution_allowed": False, + "real_write_allowed": False, + } + return { + "writer_run_package_review_package": review_package, + "writer_run_package_review_result": review_result, + "operator_readiness": operator_readiness, + } + + +def _run_package_review_summary(review_result): + review_result = _as_dict(review_result) + package = _as_dict(review_result.get("writer_run_package_review_summary")) + required_artifacts = [ + item for item in _as_list(package.get("required_artifacts")) + if isinstance(item, dict) + ] + command_bundle = [ + item for item in _as_list(package.get("command_bundle")) + if isinstance(item, dict) + ] + side_effects_clear = bool( + not review_result.get("network_request_allowed") + and not review_result.get("api_executes_cli") + and not review_result.get("api_reads_approval_token") + and not review_result.get("api_opens_database_connection") + and not review_result.get("api_writes_database") + and not review_result.get("api_uses_external_network") + and not review_result.get("database_write_executed") + and not review_result.get("cli_executed") + and not review_result.get("file_written") + and not review_result.get("scheduler_attached") + and not review_result.get("candidate_queue_created") + and not review_result.get("candidate_queue_persisted") + and not package.get("blocked_side_effects") + ) + return { + "mode": review_result.get("mode"), + "accepted": bool( + review_result.get( + "mcp_fetch_candidate_queue_writer_run_package_review_accepted" + ) + ), + "ready_for_run_readiness_review": bool( + review_result.get("ready_for_candidate_queue_writer_run_readiness_review") + ), + "run_package_id": _safe_text(package.get("run_package_id"), 160), + "package_mode": _safe_text(package.get("package_mode"), 160), + "target_table": _safe_text(package.get("target_table"), 160), + "payload_row_count": _safe_int(package.get("expected_payload_row_count")), + "candidate_keys": sorted( + key for key in _as_list(package.get("expected_candidate_keys")) if key + ), + "dedupe_keys": sorted( + key for key in _as_list(package.get("expected_dedupe_keys")) if key + ), + "required_artifact_count": len(required_artifacts), + "command_count": len(command_bundle), + "artifacts_operator_created": bool( + package.get("artifacts_operator_created") + ), + "command_bundle_api_safe": bool(package.get("command_bundle_api_safe")), + "operator_boundaries_confirmed": bool( + package.get("operator_boundaries_confirmed") + ), + "promotion_next_gate": _safe_text(package.get("promotion_next_gate"), 160), + "side_effects_clear": side_effects_clear, + "blocked_reasons": review_result.get("blocked_reasons", []), + "required_artifacts": required_artifacts, + "command_bundle": command_bundle, + } + + +def _operator_summary(operator_readiness): + operator_readiness = _as_dict(operator_readiness) + artifact_paths = { + "run_readiness_artifact_path": _safe_text( + operator_readiness.get("run_readiness_artifact_path") + ), + "reviewed_sample_json_path": _safe_text( + operator_readiness.get("reviewed_sample_json_path") + ), + "backup_artifact_path": _safe_text( + operator_readiness.get("backup_artifact_path") + ), + "read_only_preflight_output_path": _safe_text( + operator_readiness.get("read_only_preflight_output_path") + or operator_readiness.get("preflight_artifact_path") + ), + "postwrite_smoke_plan_path": _safe_text( + operator_readiness.get("postwrite_smoke_plan_path") + or operator_readiness.get("postwrite_smoke_artifact_path") + ), + } + confirmations = { + "run_package_reviewed": bool(operator_readiness.get("run_package_reviewed")), + "artifact_manifest_reviewed": bool( + operator_readiness.get("artifact_manifest_reviewed") + ), + "command_bundle_reviewed": bool( + operator_readiness.get("command_bundle_reviewed") + ), + "payload_count_reviewed": bool( + operator_readiness.get("payload_count_reviewed") + ), + "target_table_reviewed": bool( + operator_readiness.get("target_table_reviewed") + ), + "backup_artifact_reviewed": bool( + operator_readiness.get("backup_artifact_reviewed") + ), + "read_only_preflight_reviewed": bool( + operator_readiness.get("read_only_preflight_reviewed") + ), + "postwrite_smoke_required": bool( + operator_readiness.get("postwrite_smoke_required") + ), + "one_time_token_shell_only_confirmed": bool( + operator_readiness.get("one_time_token_shell_only_confirmed") + or operator_readiness.get("operator_confirmed_one_time_token_shell_only") + ), + "operator_confirmed_no_approval_token_payload": bool( + operator_readiness.get("operator_confirmed_no_approval_token_payload") + ), + "operator_confirmed_no_api_cli_execution": bool( + operator_readiness.get("operator_confirmed_no_api_cli_execution") + ), + "operator_confirmed_no_api_database_write": bool( + operator_readiness.get("operator_confirmed_no_api_database_write") + ), + "operator_confirmed_no_api_file_write": bool( + operator_readiness.get("operator_confirmed_no_api_file_write") + ), + "operator_confirmed_no_external_network": bool( + operator_readiness.get("operator_confirmed_no_external_network") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_readiness.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_persistence": bool( + operator_readiness.get("operator_confirmed_no_persistence") + ), + } + return { + "provided_keys": sorted(operator_readiness.keys()), + **artifact_paths, + "run_readiness_artifact_path_safe": _safe_path( + artifact_paths["run_readiness_artifact_path"], + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "reviewed_sample_json_path_safe": _safe_path( + artifact_paths["reviewed_sample_json_path"], + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "backup_artifact_path_safe": _safe_path( + artifact_paths["backup_artifact_path"], + prefixes=(BACKUP_PREFIX,), + suffixes=(".zip", ".tar.gz"), + ), + "read_only_preflight_output_path_safe": _safe_path( + artifact_paths["read_only_preflight_output_path"], + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "postwrite_smoke_plan_path_safe": _safe_path( + artifact_paths["postwrite_smoke_plan_path"], + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + **confirmations, + "api_execution_allowed": bool(operator_readiness.get("api_execution_allowed")), + "real_write_allowed": bool(operator_readiness.get("real_write_allowed")), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + operator_readiness, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_side_effects(operator_readiness), + } + + +def _readiness_gates(*, review_received, package, operator): + operator_reviewed_package = bool( + operator["run_package_reviewed"] + and operator["artifact_manifest_reviewed"] + and operator["command_bundle_reviewed"] + and operator["payload_count_reviewed"] + and operator["target_table_reviewed"] + ) + operator_reviewed_artifacts = bool( + operator["backup_artifact_reviewed"] + and operator["read_only_preflight_reviewed"] + and operator["postwrite_smoke_required"] + ) + operator_confirmed_boundaries = bool( + operator["one_time_token_shell_only_confirmed"] + and operator["operator_confirmed_no_approval_token_payload"] + and operator["operator_confirmed_no_api_cli_execution"] + and operator["operator_confirmed_no_api_database_write"] + and operator["operator_confirmed_no_api_file_write"] + and operator["operator_confirmed_no_external_network"] + and operator["operator_confirmed_no_scheduler_attach"] + and operator["operator_confirmed_no_persistence"] + ) + return [ + { + "key": "writer_run_package_review_payload_or_result_received", + "label": "已提供 writer run package review package 或已審核結果", + "passed": review_received, + }, + { + "key": "writer_run_package_review_accepted", + "label": "writer run package review gate 必須已通過", + "passed": package["accepted"], + }, + { + "key": "writer_run_package_review_ready_for_run_readiness", + "label": "run package review 只放行到 run readiness review", + "passed": package["ready_for_run_readiness_review"], + }, + { + "key": "writer_run_package_review_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": package["target_table"] == TARGET_TABLE, + }, + { + "key": "writer_run_package_review_payload_small_batch", + "label": "payload row count 必須介於 1 與安全上限", + "passed": bool(0 < package["payload_row_count"] <= MAX_READY_PAYLOAD_ROWS), + }, + { + "key": "writer_run_package_review_artifact_manifest_available", + "label": "run package 必須包含操作員 artifact manifest", + "passed": bool( + package["required_artifact_count"] >= 3 + and package["artifacts_operator_created"] + ), + }, + { + "key": "writer_run_package_review_command_bundle_available", + "label": "run package 必須包含 API-safe command bundle", + "passed": bool(package["command_count"] >= 3 and package["command_bundle_api_safe"]), + }, + { + "key": "writer_run_package_review_side_effect_free", + "label": "run package review 未顯示 API 執行、寫 DB 或掛 scheduler", + "passed": package["side_effects_clear"], + }, + { + "key": "operator_readiness_received", + "label": "已提供操作員 readiness 證據", + "passed": bool(operator["provided_keys"]), + }, + { + "key": "run_readiness_artifact_path_safe", + "label": "run readiness artifact path 必須在 market intel artifact 目錄", + "passed": operator["run_readiness_artifact_path_safe"], + }, + { + "key": "reviewed_sample_json_path_safe", + "label": "reviewed sample JSON path 必須在 market intel artifact 目錄", + "passed": operator["reviewed_sample_json_path_safe"], + }, + { + "key": "backup_artifact_path_safe", + "label": "備份 artifact path 必須在 scripts/tools/backups 目錄", + "passed": operator["backup_artifact_path_safe"], + }, + { + "key": "read_only_preflight_output_path_safe", + "label": "read-only preflight output path 必須在 market intel artifact 目錄", + "passed": operator["read_only_preflight_output_path_safe"], + }, + { + "key": "postwrite_smoke_plan_path_safe", + "label": "post-write smoke plan path 必須在 market intel artifact 目錄", + "passed": operator["postwrite_smoke_plan_path_safe"], + }, + { + "key": "operator_confirmed_package_review", + "label": "操作員已覆核 run package、artifact manifest、command bundle 與 payload", + "passed": operator_reviewed_package, + }, + { + "key": "operator_confirmed_artifacts_and_preflight", + "label": "操作員已確認備份、read-only preflight 與 post-write smoke", + "passed": operator_reviewed_artifacts, + }, + { + "key": "operator_confirmed_shell_only_boundaries", + "label": "操作員確認 CLI-only、token shell-only、無 API/DB/scheduler 副作用", + "passed": operator_confirmed_boundaries, + }, + { + "key": "operator_readiness_no_api_execution_or_real_write", + "label": "readiness payload 不得允許 API execution 或 real write", + "passed": bool( + not operator["api_execution_allowed"] + and not operator["real_write_allowed"] + ), + }, + { + "key": "secret_or_token_not_submitted_to_api", + "label": "readiness payload 不得包含 secret、cookie、password 或 token key", + "passed": not operator["secret_or_token_submitted_to_api"], + }, + { + "key": "operator_readiness_side_effect_free", + "label": "readiness payload 不得要求 API 寫檔、執行、寫 DB 或掛 scheduler", + "passed": not operator["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_queue_writer_run_readiness_preview( + *, + writer_run_package_review_package=None, + writer_run_package_review_result=None, + operator_readiness=None, + phase=None, +): + """建立 fetch candidate queue writer run readiness review；不執行寫入。""" + writer_run_package_review_package = _as_dict(writer_run_package_review_package) + review_result_received = bool( + isinstance(writer_run_package_review_result, dict) + and writer_run_package_review_result + ) + operator_readiness = _as_dict(operator_readiness) + review_result = _run_package_review_from_inputs( + writer_run_package_review_package, + writer_run_package_review_result, + phase, + ) + review_received = bool( + writer_run_package_review_package or review_result_received + ) + payload_received = bool(review_received or operator_readiness) + package = _run_package_review_summary(review_result) + operator = _operator_summary(operator_readiness) + gates = _readiness_gates( + review_received=review_received, + package=package, + operator=operator, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_run_readiness_review" + if payload_received + else "mcp_fetch_candidate_queue_writer_run_readiness_preview" + ), + "phase": phase, + "writer_run_readiness_payload_received": payload_received, + "writer_run_package_review_received": review_received, + "operator_readiness_received": bool(operator["provided_keys"]), + "writer_run_package_review_accepted": package["accepted"], + "mcp_fetch_candidate_queue_writer_run_readiness_accepted": accepted, + "candidate_queue_writer_run_readiness_ready": accepted, + "ready_for_candidate_queue_writer_operator_run": accepted, + "ready_for_candidate_queue_writer_run_receipt_review": accepted, + "ready_for_api_database_write": False, + "ready_for_real_write": False, + "ready_for_scheduler_attach": False, + "network_request_allowed": False, + "operator_shell_database_write_required": accepted, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_writes_file": False, + "api_uses_external_network": False, + "payload_row_count": package["payload_row_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "writer_run_package_review_summary": package, + "operator_readiness_summary": operator, + "sample_writer_run_readiness_package": _sample_run_readiness_package(), + "next_operator_steps": [ + "Run readiness 通過後，操作員才可在 shell 依 run package 執行 writer CLI", + "一次性 approval token 只能在 shell 注入，不得提交給 API/UI", + "CLI 寫入後必須保存 writer output，再回貼到下一個 run receipt review gate", + "API/UI 仍不得建立 artifact、寫檔、執行 CLI、讀 token、開 DB 或寫 queue", + ], + "payload_persisted": False, + "run_readiness_persisted": False, + "run_readiness_artifact_created": False, + "run_readiness_file_written": False, + "run_receipt_file_written": False, + "package_artifact_created": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "cli_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index d29c680..ef1709f 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" +MARKET_INTEL_PHASE = "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 81ad3f3..9e412cf 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -916,6 +916,32 @@ +
+
+
+

MCP / WRITER RUN READINESS

+

MCP Candidate Queue Writer Run Readiness

+
+ +
+
+ loading +
+
+
讀取 MCP Writer Run Readiness 中...
+
+
+ +
+ +
+
+
+
@@ -1434,6 +1460,7 @@ const mcpFetchCandidateQueueWriterPreflightRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight]'); const mcpFetchCandidateQueueWriterCliReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review]'); const mcpFetchCandidateQueueWriterRunPackageReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review]'); + const mcpFetchCandidateQueueWriterRunReadinessRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1450,7 +1477,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1581,6 +1608,12 @@ const mcpFetchCandidateQueueWriterRunPackageReviewReview = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-review]') : null; const mcpFetchCandidateQueueWriterRunPackageReviewRefresh = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-refresh]') : null; const mcpFetchCandidateQueueWriterRunPackageReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_package_review') }}"; + const mcpFetchCandidateQueueWriterRunReadinessMeta = mcpFetchCandidateQueueWriterRunReadinessRoot ? mcpFetchCandidateQueueWriterRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-meta]') : null; + const mcpFetchCandidateQueueWriterRunReadinessBody = mcpFetchCandidateQueueWriterRunReadinessRoot ? mcpFetchCandidateQueueWriterRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-body]') : null; + const mcpFetchCandidateQueueWriterRunReadinessInput = mcpFetchCandidateQueueWriterRunReadinessRoot ? mcpFetchCandidateQueueWriterRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-input]') : null; + const mcpFetchCandidateQueueWriterRunReadinessReview = mcpFetchCandidateQueueWriterRunReadinessRoot ? mcpFetchCandidateQueueWriterRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-review]') : null; + const mcpFetchCandidateQueueWriterRunReadinessRefresh = mcpFetchCandidateQueueWriterRunReadinessRoot ? mcpFetchCandidateQueueWriterRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-refresh]') : null; + const mcpFetchCandidateQueueWriterRunReadinessEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_readiness') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -4300,6 +4333,133 @@ } }; + const renderMcpFetchCandidateQueueWriterRunReadinessMeta = data => { + mcpFetchCandidateQueueWriterRunReadinessMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_run_readiness_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || 0}`, + `operator=${data.ready_for_candidate_queue_writer_operator_run ? 'ready' : 'blocked'}`, + `db=${data.api_writes_database ? 'write' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterRunReadinessBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const pkg = data.writer_run_package_review_summary || {}; + const operator = data.operator_readiness_summary || {}; + const artifacts = [ + ['run_readiness_artifact_path', operator.run_readiness_artifact_path, operator.run_readiness_artifact_path_safe], + ['reviewed_sample_json_path', operator.reviewed_sample_json_path, operator.reviewed_sample_json_path_safe], + ['backup_artifact_path', operator.backup_artifact_path, operator.backup_artifact_path_safe], + ['read_only_preflight_output_path', operator.read_only_preflight_output_path, operator.read_only_preflight_output_path_safe], + ['postwrite_smoke_plan_path', operator.postwrite_smoke_plan_path, operator.postwrite_smoke_plan_path_safe] + ]; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterRunReadinessBody.innerHTML = ` +
此 run readiness 只審核操作員準備證據；API 不建立 artifact、不寫檔、不執行 CLI、不讀 approval token、不開 DB、不寫 queue、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

READINESS GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 readiness gates。
' + }
+
+
+

RUN PACKAGE REVIEW

+
+ ${renderCheck('run_package_review', `${pkg.accepted ? 'accepted' : 'pending'} / rows=${pkg.payload_row_count || 0}`, pkg.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('target_table', pkg.target_table || 'missing', pkg.target_table === 'market_alert_review_queue' ? 'SAFE' : 'BLOCK')} + ${renderCheck('api_boundary', 'no CLI / no token / no DB / no scheduler', pkg.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

OPERATOR CONFIRMATIONS

+
+ ${renderCheck('run_package_reviewed', 'package / manifest / command / payload / table', operator.run_package_reviewed && operator.artifact_manifest_reviewed && operator.command_bundle_reviewed && operator.payload_count_reviewed && operator.target_table_reviewed ? 'CONFIRMED' : 'BLOCK')} + ${renderCheck('preflight_and_backup', 'backup / read-only preflight / post-write smoke', operator.backup_artifact_reviewed && operator.read_only_preflight_reviewed && operator.postwrite_smoke_required ? 'CONFIRMED' : 'BLOCK')} + ${renderCheck('shell_only_boundaries', 'token shell-only, no API CLI/DB/file/scheduler', operator.one_time_token_shell_only_confirmed && operator.operator_confirmed_no_api_cli_execution && operator.operator_confirmed_no_api_database_write && operator.operator_confirmed_no_scheduler_attach ? 'CLOSED' : 'BLOCK')} +
+
+
+

ARTIFACT PATHS

+
+ ${artifacts.map(item => renderCheck(item[0], item[1] || 'missing', item[2] ? 'SAFE' : 'BLOCK')).join('')} +
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck('operator_run', data.ready_for_candidate_queue_writer_operator_run ? 'shell writer CLI allowed after this gate' : 'blocked', data.ready_for_candidate_queue_writer_operator_run ? 'READY' : 'BLOCK')} + ${renderCheck('api_side_effects', 'no artifact / no file / no CLI / no token / no DB / no queue', data.run_readiness_artifact_created || data.api_executes_cli || data.api_reads_approval_token || data.api_writes_database || data.api_writes_file ? 'BLOCK' : 'CLOSED')} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterRunReadinessInput && !mcpFetchCandidateQueueWriterRunReadinessInput.value.trim() && data.sample_writer_run_readiness_package) { + mcpFetchCandidateQueueWriterRunReadinessInput.value = JSON.stringify(data.sample_writer_run_readiness_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterRunReadiness = async () => { + if (!mcpFetchCandidateQueueWriterRunReadinessMeta || !mcpFetchCandidateQueueWriterRunReadinessBody) return; + mcpFetchCandidateQueueWriterRunReadinessBody.innerHTML = '
讀取 MCP Writer Run Readiness 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterRunReadinessEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterRunReadinessMeta(data); + renderMcpFetchCandidateQueueWriterRunReadinessBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterRunReadinessMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterRunReadinessBody.innerHTML = `
MCP Writer Run Readiness 讀取失敗：${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterRunReadiness = async () => { + if (!mcpFetchCandidateQueueWriterRunReadinessMeta || !mcpFetchCandidateQueueWriterRunReadinessBody || !mcpFetchCandidateQueueWriterRunReadinessInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterRunReadinessInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterRunReadinessMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterRunReadinessBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterRunReadinessBody.innerHTML = '
審核 MCP Writer Run Readiness 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterRunReadinessEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_run_readiness_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterRunReadinessMeta(data); + renderMcpFetchCandidateQueueWriterRunReadinessBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterRunReadinessMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterRunReadinessBody.innerHTML = `
MCP Writer Run Readiness 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -13787,6 +13947,12 @@ if (mcpFetchCandidateQueueWriterRunPackageReviewReview) { mcpFetchCandidateQueueWriterRunPackageReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterRunPackageReview); } + if (mcpFetchCandidateQueueWriterRunReadinessRefresh) { + mcpFetchCandidateQueueWriterRunReadinessRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterRunReadiness); + } + if (mcpFetchCandidateQueueWriterRunReadinessReview) { + mcpFetchCandidateQueueWriterRunReadinessReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterRunReadiness); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -14055,6 +14221,7 @@ loadMcpFetchCandidateQueueWriterPreflight(); loadMcpFetchCandidateQueueWriterCliReview(); loadMcpFetchCandidateQueueWriterRunPackageReview(); + loadMcpFetchCandidateQueueWriterRunReadiness(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 3c5b987..19e4459 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -47,6 +47,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( build_mcp_fetch_candidate_queue_writer_run_package_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1108,6 +1111,34 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_readiness" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-package" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-operator" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-artifacts" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1578,7 +1609,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert bridge["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1736,7 +1767,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert contract["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1869,7 +1900,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1882,7 +1913,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert gate["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1952,7 +1983,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1966,7 +1997,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert audit["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -2040,7 +2071,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -2057,11 +2088,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert evidence["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2086,7 +2117,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2144,12 +2175,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2158,11 +2189,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert receipt["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2190,7 +2221,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2255,12 +2286,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2269,11 +2300,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert promotion["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2301,7 +2332,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2361,12 +2392,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2375,11 +2406,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert handoff["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2407,7 +2438,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2469,12 +2500,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2485,11 +2516,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert review["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2519,7 +2550,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2597,13 +2628,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2615,11 +2646,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert package["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2651,7 +2682,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2726,13 +2757,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2746,11 +2777,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert readiness["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2785,11 +2816,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert readiness["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2865,13 +2896,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2885,11 +2916,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert receipt["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -2926,11 +2957,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert receipt["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -3009,13 +3040,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3031,11 +3062,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert parser["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3074,11 +3105,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert parser["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3163,13 +3194,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3185,11 +3216,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert handoff["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3228,11 +3259,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert handoff["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3322,13 +3353,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3345,11 +3376,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert review["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3386,11 +3417,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert review["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3481,13 +3512,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert get_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert post_data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3503,13 +3534,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3547,13 +3578,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3657,7 +3688,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3666,7 +3697,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3682,13 +3713,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( review["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert review["writer_cli_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False @@ -3724,13 +3755,13 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): writer_preflight_package=sample["writer_preflight_package"], writer_preflight_result=sample["writer_preflight_result"], writer_cli_review=sample["writer_cli_review"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( review["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert review["candidate_queue_writer_cli_review_ready"] is True @@ -3831,7 +3862,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( get_data["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -3840,7 +3871,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( post_data["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True @@ -3857,7 +3888,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == ( @@ -3865,7 +3896,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_wit ) assert ( review["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert review["writer_run_package_review_payload_received"] is False assert ( @@ -3915,13 +3946,13 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_accepts_sample_revi writer_cli_review_package=sample["writer_cli_review_package"], writer_cli_review_result=sample["writer_cli_review_result"], writer_run_package_review=sample["writer_run_package_review"], - phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_run_package_review" assert ( review["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert ( review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4045,7 +4076,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4057,7 +4088,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4075,11 +4106,219 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ assert post_data["api_opens_database_connection"] is False +def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_payload(): + readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", + ) + + assert readiness["mode"] == ( + "mcp_fetch_candidate_queue_writer_run_readiness_preview" + ) + assert ( + readiness["phase"] + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" + ) + assert readiness["writer_run_readiness_payload_received"] is False + assert ( + readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] + is False + ) + assert readiness["candidate_queue_writer_run_readiness_ready"] is False + assert readiness["ready_for_candidate_queue_writer_operator_run"] is False + assert readiness["ready_for_api_database_write"] is False + assert readiness["ready_for_real_write"] is False + assert readiness["ready_for_scheduler_attach"] is False + assert readiness["network_request_allowed"] is False + assert readiness["api_executes_cli"] is False + assert readiness["api_reads_approval_token"] is False + assert readiness["api_writes_database"] is False + assert readiness["payload_persisted"] is False + assert readiness["run_readiness_persisted"] is False + assert readiness["run_readiness_artifact_created"] is False + assert readiness["run_readiness_file_written"] is False + assert readiness["package_artifact_created"] is False + assert readiness["database_write_executed"] is False + assert readiness["scheduler_attached"] is False + assert ( + "writer_run_package_review_payload_or_result_received" + in readiness["blocked_reasons"] + ) + assert "operator_readiness_received" in readiness["blocked_reasons"] + assert ( + "writer_run_package_review_package" + in readiness["sample_writer_run_readiness_package"] + ) + assert "operator_readiness" in readiness["sample_writer_run_readiness_package"] + + +def test_mcp_fetch_candidate_queue_writer_run_readiness_accepts_sample_review(): + sample = ( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview() + ["sample_writer_run_readiness_package"] + ) + readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( + writer_run_package_review_package=sample[ + "writer_run_package_review_package" + ], + writer_run_package_review_result=sample["writer_run_package_review_result"], + operator_readiness=sample["operator_readiness"], + phase="phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review", + ) + + assert readiness["mode"] == "mcp_fetch_candidate_queue_writer_run_readiness_review" + assert ( + readiness["phase"] + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" + ) + assert ( + readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] + is True + ) + assert readiness["candidate_queue_writer_run_readiness_ready"] is True + assert readiness["ready_for_candidate_queue_writer_operator_run"] is True + assert readiness["ready_for_candidate_queue_writer_run_receipt_review"] is True + assert readiness["ready_for_api_database_write"] is False + assert readiness["ready_for_real_write"] is False + assert readiness["blocked_reasons"] == [] + assert readiness["passed_gate_count"] == readiness["gate_count"] + assert readiness["writer_run_package_review_accepted"] is True + package = readiness["writer_run_package_review_summary"] + assert package["target_table"] == "market_alert_review_queue" + assert package["payload_row_count"] > 0 + assert package["side_effects_clear"] is True + operator = readiness["operator_readiness_summary"] + assert operator["run_readiness_artifact_path_safe"] is True + assert operator["reviewed_sample_json_path_safe"] is True + assert operator["backup_artifact_path_safe"] is True + assert operator["read_only_preflight_output_path_safe"] is True + assert operator["postwrite_smoke_plan_path_safe"] is True + assert operator["one_time_token_shell_only_confirmed"] is True + assert operator["secret_or_token_submitted_to_api"] is False + assert readiness["network_request_allowed"] is False + assert readiness["api_executes_cli"] is False + assert readiness["api_reads_approval_token"] is False + assert readiness["api_writes_file"] is False + assert readiness["candidate_queue_persisted"] is False + assert readiness["database_write_executed"] is False + assert readiness["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_run_readiness_blocks_unsafe_review(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_run_readiness_preview() + ["sample_writer_run_readiness_package"] + ) + ) + operator = sample["operator_readiness"] + operator["run_readiness_artifact_path"] = "/tmp/unsafe.json" + operator["backup_artifact_path"] = "../unsafe.zip" + operator["approval_token"] = "do-not-submit" + operator["api_executes_cli"] = True + operator["api_execution_allowed"] = True + operator["real_write_allowed"] = True + operator["operator_confirmed_no_api_cli_execution"] = False + operator["operator_confirmed_no_api_database_write"] = False + sample["writer_run_package_review_result"]["api_executes_cli"] = True + + readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( + writer_run_package_review_package=sample[ + "writer_run_package_review_package" + ], + writer_run_package_review_result=sample["writer_run_package_review_result"], + operator_readiness=operator, + ) + + assert ( + readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] + is False + ) + assert readiness["writer_run_package_review_accepted"] is True + assert ( + "writer_run_package_review_side_effect_free" + in readiness["blocked_reasons"] + ) + assert "run_readiness_artifact_path_safe" in readiness["blocked_reasons"] + assert "backup_artifact_path_safe" in readiness["blocked_reasons"] + assert ( + "operator_confirmed_shell_only_boundaries" + in readiness["blocked_reasons"] + ) + assert ( + "operator_readiness_no_api_execution_or_real_write" + in readiness["blocked_reasons"] + ) + assert "secret_or_token_not_submitted_to_api" in readiness["blocked_reasons"] + assert "operator_readiness_side_effect_free" in readiness["blocked_reasons"] + assert readiness["api_executes_cli"] is False + assert readiness["api_reads_approval_token"] is False + assert readiness["api_writes_database"] is False + assert readiness["candidate_queue_persisted"] is False + assert readiness["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_run_readiness_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness", + json={"writer_run_readiness_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == ( + "mcp_fetch_candidate_queue_writer_run_readiness_preview" + ) + assert ( + get_data["phase"] + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert post_response.status_code == 200 + assert ( + post_data["mode"] + == "mcp_fetch_candidate_queue_writer_run_readiness_review" + ) + assert ( + post_data["phase"] + == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" + ) + assert ( + post_data["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] + is True + ) + assert post_data["ready_for_candidate_queue_writer_operator_run"] is True + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -4127,7 +4366,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -4138,7 +4377,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert acceptance["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -4180,7 +4419,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -4192,7 +4431,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert review["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -4303,7 +4542,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -4342,7 +4581,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert review["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -4404,7 +4643,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -4484,7 +4723,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert handoff["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -4548,7 +4787,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -4607,7 +4846,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert queue_draft["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -4681,7 +4920,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -4744,7 +4983,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert approval["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -4822,7 +5061,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -4885,7 +5124,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert transaction["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -4965,7 +5204,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -10676,7 +10915,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10751,7 +10990,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -11023,7 +11262,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -11311,7 +11550,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -11621,7 +11860,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -11924,7 +12163,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -12183,7 +12422,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -12456,7 +12695,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -12704,7 +12943,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -12934,7 +13173,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -13171,7 +13410,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -13413,7 +13652,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -13689,7 +13928,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -13966,7 +14205,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -14245,7 +14484,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -14574,7 +14813,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -14836,7 +15075,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -15100,7 +15339,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -15370,7 +15609,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -15658,7 +15897,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -15945,7 +16184,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -16031,7 +16270,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16088,7 +16327,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -16177,7 +16416,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16231,7 +16470,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -16287,7 +16526,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -16353,7 +16592,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -16655,7 +16894,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -16703,7 +16942,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -16752,7 +16991,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -16810,7 +17049,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -16876,7 +17115,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -16947,7 +17186,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -17023,7 +17262,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -17105,7 +17344,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -17191,7 +17430,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -17274,7 +17513,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -17357,7 +17596,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -17443,7 +17682,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -17534,7 +17773,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -17644,7 +17883,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17730,7 +17969,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17787,7 +18026,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17840,7 +18079,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17893,7 +18132,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17954,7 +18193,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -18023,7 +18262,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -18095,7 +18334,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -18168,7 +18407,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -18239,7 +18478,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -18304,7 +18543,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -18375,7 +18614,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -18448,7 +18687,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -18525,7 +18764,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -18602,7 +18841,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -18679,7 +18918,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -18753,7 +18992,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -18832,7 +19071,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -18919,7 +19158,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -19000,7 +19239,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -19082,7 +19321,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -19165,7 +19404,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -19190,7 +19429,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -19228,7 +19467,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -19239,7 +19478,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -19275,7 +19514,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -19286,7 +19525,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -19327,7 +19566,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -19338,7 +19577,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -19386,7 +19625,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -19398,7 +19637,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -19444,7 +19683,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -19457,7 +19696,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert plan["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -19542,7 +19781,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -19620,7 +19859,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -19635,7 +19874,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert readiness["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -20052,6 +20291,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_run_readiness_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -24476,7 +24721,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert drill["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -24591,7 +24836,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -24603,7 +24848,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert review["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -24718,7 +24963,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -24731,7 +24976,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert smoke["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -24793,7 +25038,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -24806,7 +25051,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert inventory["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -24950,7 +25195,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -25186,7 +25431,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -25215,7 +25460,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + assert data["phase"] == "phase_131_market_intel_mcp_fetch_candidate_queue_writer_run_readiness_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False