diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 41c7716..5d5a860 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -148,6 +148,7 @@ - Phase 72 candidate queue review decision writer operator drill：新增 `services/market_intel/candidate_queue_review_decision_writer_operator_drill.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` 與 UI drill 按鈕，將 review_state CLI 更新前後的 transaction JSON、備份、preflight、CLI writer、post-write smoke 與 rollback plan 組成可稽核操作順序；API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.261。 - Phase 73 candidate queue review decision writer run package：新增 `services/market_intel/candidate_queue_review_decision_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 與 UI package 按鈕，將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 run package；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.262。 - Phase 74 candidate queue review decision writer run readiness：新增 `services/market_intel/candidate_queue_review_decision_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 與 UI readiness 按鈕，檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.264。 + - Phase 75 candidate queue review decision writer run receipt：新增 `services/market_intel/candidate_queue_review_decision_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 與 UI receipt 按鈕，審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.266。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/config.py b/config.py index e20bc46..7441755 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.265" +SYSTEM_VERSION = "V10.266" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 6ebf067..b086cb0 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -200,6 +200,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review decision writer operator drill：`services.market_intel.candidate_queue_review_decision_writer_operator_drill` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` 整理 review_state CLI 更新前後的操作員順序、preflight、post-write smoke、gate 與 rollback plan。此 drill 只輸出可稽核操作計畫；API/UI 不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run package：`services.market_intel.candidate_queue_review_decision_writer_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 package。此 package 只輸出預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run readiness：`services.market_intel.candidate_queue_review_decision_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備。此 readiness 只輸出操作員 gate 預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue review decision writer run receipt：`services.market_intel.candidate_queue_review_decision_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 1b51ef5..0c434da 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,8 +19,8 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 74 candidate queue review decision writer run readiness 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | -| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 75 candidate queue review decision writer run receipt 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py index 5a2d37b..cc8ca42 100644 --- a/routes/market_intel_review_routes.py +++ b/routes/market_intel_review_routes.py @@ -39,6 +39,9 @@ from services.market_intel.candidate_queue_review_decision_writer_run_package im from services.market_intel.candidate_queue_review_decision_writer_run_readiness import ( build_candidate_queue_review_decision_writer_run_readiness, ) +from services.market_intel.candidate_queue_review_decision_writer_run_receipt import ( + build_candidate_queue_review_decision_writer_run_receipt, +) from services.market_intel.candidate_queue_writer_cli import ( build_candidate_queue_writer_cli_plan, ) @@ -655,3 +658,79 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_run_readin ) data["phase"] = service.phase return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_receipt", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt(): + service = MarketIntelService() + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction = _build_review_decision_transaction_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + limit=limit, + execute_requested=False, + ) + writer_status = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + operator_evidence=operator_evidence, + execute_requested=False, + apply_real_write=False, + approval_token=None, + approval_token_secret=None, + backup_verified=False, + review_inventory_smoke_passed=False, + ) + writer_preflight = build_candidate_queue_review_decision_writer_preflight( + writer_status=writer_status, + transaction_preview=transaction, + operator_evidence=operator_evidence, + execute_requested=False, + apply_real_write=False, + ) + postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + operator_drill = build_candidate_queue_review_decision_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_evidence=operator_evidence, + ) + run_package = build_candidate_queue_review_decision_writer_run_package( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + run_readiness = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + data = build_candidate_queue_review_decision_writer_run_receipt( + transaction_preview=transaction, + run_readiness=run_readiness, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + operator_evidence=operator_evidence, + ) + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 diff --git a/services/market_intel/candidate_queue_review_decision_writer_run_receipt.py b/services/market_intel/candidate_queue_review_decision_writer_run_receipt.py new file mode 100644 index 0000000..0837d15 --- /dev/null +++ b/services/market_intel/candidate_queue_review_decision_writer_run_receipt.py @@ -0,0 +1,437 @@ +"""候選審核 queue review_state writer operator run receipt preview。 + +本模組只審核 CLI 更新 review_state 後由操作員貼回的 writer output 與 +post-write smoke 結果；不讀 approval token、不執行 CLI、不開 DB +connection、不更新 review_state、不 commit、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +EXPECTED_WRITER_MODE = "candidate_queue_review_decision_writer_cli_executed" +EXPECTED_SMOKE_MODE = "candidate_queue_review_decision_writer_postwrite_smoke_read_only" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _expected_updates_from_transaction(transaction_preview): + updates = [] + for statement in _as_list(_as_dict(transaction_preview).get("statements")): + statement = _as_dict(statement) + lookup = _as_dict(statement.get("lookup")) + parameter_preview = _as_dict(statement.get("parameter_preview")) + dedupe_key = lookup.get("dedupe_key") or parameter_preview.get("dedupe_key") + next_state = ( + parameter_preview.get("next_review_state") + or statement.get("next_review_state") + ) + current_state = ( + parameter_preview.get("expected_current_review_state") + or statement.get("expected_current_review_state") + ) + if dedupe_key: + updates.append( + { + "dedupe_key": str(dedupe_key), + "expected_current_review_state": current_state, + "expected_review_state": next_state, + "idempotency_key": statement.get("idempotency_key"), + "parameter_payload_hash": statement.get( + "parameter_payload_hash" + ), + } + ) + return updates + + +def _keys_from_writer_output(writer_output): + writer_output = _as_dict(writer_output) + execution_result = _as_dict(writer_output.get("execution_result")) + affected = ( + writer_output.get("affected_dedupe_keys") + or writer_output.get("updated_dedupe_keys") + or execution_result.get("affected_dedupe_keys") + or execution_result.get("updated_dedupe_keys") + or [] + ) + skipped = ( + writer_output.get("skipped_dedupe_keys") + or execution_result.get("skipped_dedupe_keys") + or [] + ) + return { + "affected": sorted(set(str(key) for key in _as_list(affected) if key)), + "skipped": sorted(set(str(key) for key in _as_list(skipped) if key)), + } + + +def _keys_match_expected(expected_keys, observed_keys): + if not expected_keys: + return False + return set(expected_keys).issubset(set(observed_keys)) + + +def _operator_evidence_summary(operator_evidence): + return { + "provided_keys": sorted(operator_evidence.keys()), + "writer_output_json_path_recorded": _has_text( + operator_evidence.get("review_state_writer_output_json_path") + or operator_evidence.get("writer_output_json_path") + ), + "postwrite_smoke_json_path_recorded": _has_text( + operator_evidence.get("review_state_postwrite_smoke_json_path") + or operator_evidence.get("postwrite_smoke_json_path") + ), + "operator_confirmed_no_token_in_artifacts": bool( + operator_evidence.get("operator_confirmed_no_token_in_artifacts") + ), + "receipt_notes_recorded": _has_text(operator_evidence.get("receipt_notes")), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _writer_summary(writer_output, expected_keys): + writer_output = _as_dict(writer_output) + writer_keys = _keys_from_writer_output(writer_output) + observed_keys = sorted(set(writer_keys["affected"] + writer_keys["skipped"])) + return { + "provided": bool(writer_output), + "mode": writer_output.get("mode"), + "exit_code": writer_output.get("exit_code"), + "writes_executed": bool(writer_output.get("writes_executed")), + "would_write_database": bool(writer_output.get("would_write_database")), + "database_connection_opened": bool( + writer_output.get("database_connection_opened") + ), + "explicit_transaction_opened": bool( + writer_output.get("explicit_transaction_opened") + ), + "database_write_executed": bool(writer_output.get("database_write_executed")), + "database_commit_executed": bool(writer_output.get("database_commit_executed")), + "database_rollback_executed": bool( + writer_output.get("database_rollback_executed") + ), + "external_network_executed": bool(writer_output.get("external_network_executed")), + "scheduler_attached": bool(writer_output.get("scheduler_attached")), + "api_updates_review_state": bool(writer_output.get("api_updates_review_state")), + "review_state_update_executed": bool( + writer_output.get("review_state_update_executed") + ), + "updated_count": _safe_int( + writer_output.get("updated_count") + or writer_output.get("affected_count") + or writer_output.get("inserted_count") + ), + "skipped_count": _safe_int(writer_output.get("skipped_count")), + "affected_dedupe_keys": writer_keys["affected"], + "skipped_dedupe_keys": writer_keys["skipped"], + "observed_dedupe_keys": observed_keys, + "dedupe_keys_match_expected": _keys_match_expected(expected_keys, observed_keys), + "approval_token_key_detected": _contains_forbidden_token_key(writer_output), + } + + +def _smoke_summary(postwrite_smoke_result, expected_keys): + postwrite_smoke_result = _as_dict(postwrite_smoke_result) + found_keys = sorted( + set( + str(key) + for key in _as_list(postwrite_smoke_result.get("found_dedupe_keys")) + if key + ) + ) + missing_keys = sorted( + set( + str(key) + for key in _as_list(postwrite_smoke_result.get("missing_dedupe_keys")) + if key + ) + ) + return { + "provided": bool(postwrite_smoke_result), + "mode": postwrite_smoke_result.get("mode"), + "postwrite_smoke_passed": bool( + postwrite_smoke_result.get("postwrite_smoke_passed") + ), + "review_state_update_verified": bool( + postwrite_smoke_result.get("review_state_update_verified") + ), + "ready_for_operator_review": bool( + postwrite_smoke_result.get("ready_for_operator_review") + ), + "read_only_query_executed": bool( + postwrite_smoke_result.get("read_only_query_executed") + ), + "database_connection_opened": bool( + postwrite_smoke_result.get("database_connection_opened") + ), + "database_write_executed": bool( + postwrite_smoke_result.get("database_write_executed") + ), + "database_commit_executed": bool( + postwrite_smoke_result.get("database_commit_executed") + ), + "external_network_executed": bool( + postwrite_smoke_result.get("external_network_executed") + ), + "scheduler_attached": bool(postwrite_smoke_result.get("scheduler_attached")), + "expected_dedupe_key_count": _safe_int( + postwrite_smoke_result.get("expected_dedupe_key_count") + ), + "found_count": _safe_int(postwrite_smoke_result.get("found_count")), + "missing_count": _safe_int(postwrite_smoke_result.get("missing_count")), + "state_mismatch_count": _safe_int( + postwrite_smoke_result.get("state_mismatch_count") + ), + "found_dedupe_keys": found_keys, + "missing_dedupe_keys": missing_keys, + "state_mismatches": _as_list(postwrite_smoke_result.get("state_mismatches")), + "dedupe_keys_match_expected": _keys_match_expected(expected_keys, found_keys) + and not missing_keys, + "approval_token_key_detected": _contains_forbidden_token_key( + postwrite_smoke_result + ), + } + + +def _receipt_gates( + *, + expected_keys, + run_readiness, + writer_summary, + smoke_summary, + evidence_summary, +): + return [ + { + "key": "run_readiness_passed_before_cli", + "label": "CLI 更新前 run readiness 必須已通過", + "passed": bool(run_readiness.get("ready_for_cli_operator_run")), + }, + { + "key": "expected_dedupe_keys_present", + "label": "review_state transaction preview 必須有 dedupe key", + "passed": bool(expected_keys), + }, + { + "key": "writer_output_provided", + "label": "操作員需貼回 CLI review_state writer output", + "passed": writer_summary["provided"], + }, + { + "key": "writer_output_executed_and_committed", + "label": "writer output 必須顯示 CLI 已更新 review_state 並 commit", + "passed": bool( + writer_summary["mode"] == EXPECTED_WRITER_MODE + and writer_summary["writes_executed"] + and writer_summary["review_state_update_executed"] + and writer_summary["database_write_executed"] + and writer_summary["database_commit_executed"] + ), + }, + { + "key": "writer_output_dedupe_keys_match_expected", + "label": "writer output 的 affected/skipped dedupe key 必須符合 transaction preview", + "passed": writer_summary["dedupe_keys_match_expected"], + }, + { + "key": "writer_output_safe_runtime_boundaries", + "label": "writer output 不得顯示 scheduler、外部網路或 rollback error", + "passed": bool( + not writer_summary["scheduler_attached"] + and not writer_summary["external_network_executed"] + and not writer_summary["database_rollback_executed"] + and not writer_summary["api_updates_review_state"] + ), + }, + { + "key": "writer_output_no_approval_token_key", + "label": "writer output 不得包含 approval token key", + "passed": not writer_summary["approval_token_key_detected"], + }, + { + "key": "postwrite_smoke_result_provided", + "label": "操作員需貼回 review_state post-write smoke 結果", + "passed": smoke_summary["provided"], + }, + { + "key": "postwrite_smoke_read_only_passed", + "label": "post-write smoke 必須是只讀查詢且通過", + "passed": bool( + smoke_summary["mode"] == EXPECTED_SMOKE_MODE + and smoke_summary["read_only_query_executed"] + and smoke_summary["postwrite_smoke_passed"] + and smoke_summary["review_state_update_verified"] + ), + }, + { + "key": "postwrite_smoke_no_database_write", + "label": "post-write smoke 不得寫 DB 或 commit", + "passed": bool( + not smoke_summary["database_write_executed"] + and not smoke_summary["database_commit_executed"] + ), + }, + { + "key": "postwrite_smoke_dedupe_keys_match_expected", + "label": "post-write smoke 找到的 queue row 必須符合 transaction preview", + "passed": smoke_summary["dedupe_keys_match_expected"], + }, + { + "key": "postwrite_smoke_no_state_mismatch", + "label": "post-write smoke 不得出現 review_state mismatch", + "passed": bool(not smoke_summary["state_mismatch_count"]), + }, + { + "key": "postwrite_smoke_no_approval_token_key", + "label": "post-write smoke 結果不得包含 approval token key", + "passed": not smoke_summary["approval_token_key_detected"], + }, + { + "key": "receipt_artifact_paths_recorded", + "label": "操作員需記錄 writer output 與 post-write smoke artifact 路徑", + "passed": bool( + evidence_summary["writer_output_json_path_recorded"] + and evidence_summary["postwrite_smoke_json_path_recorded"] + ), + }, + { + "key": "operator_confirmed_no_token_in_artifacts", + "label": "操作員確認 artifact 不含一次性 token", + "passed": bool( + evidence_summary["operator_confirmed_no_token_in_artifacts"] + and not evidence_summary["approval_token_submitted_to_api"] + ), + }, + ] + + +def build_candidate_queue_review_decision_writer_run_receipt( + *, + transaction_preview, + run_readiness, + writer_output=None, + postwrite_smoke_result=None, + operator_evidence=None, +): + """建立 review_state CLI 更新後 receipt review；不執行任何副作用。""" + expected_updates = _expected_updates_from_transaction(transaction_preview) + expected_keys = sorted({item["dedupe_key"] for item in expected_updates}) + operator_evidence = _as_dict(operator_evidence) + evidence_summary = _operator_evidence_summary(operator_evidence) + writer_summary = _writer_summary(writer_output, expected_keys) + smoke_summary = _smoke_summary(postwrite_smoke_result, expected_keys) + gates = _receipt_gates( + expected_keys=expected_keys, + run_readiness=_as_dict(run_readiness), + writer_summary=writer_summary, + smoke_summary=smoke_summary, + evidence_summary=evidence_summary, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + receipt_passed = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_decision_writer_run_receipt_preview", + "target_table": "market_alert_review_queue", + "target_operation": "update_review_state", + "receipt_reviewed": True, + "receipt_passed": receipt_passed, + "ready_for_next_manual_phase": receipt_passed, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "approval_record_written": False, + "decision_record_written": False, + "review_state_update_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "expected_dedupe_keys": expected_keys, + "expected_review_state_updates": expected_updates, + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_evidence_summary": evidence_summary, + "writer_output_summary": writer_summary, + "postwrite_smoke_summary": smoke_summary, + "next_operator_steps": [ + "保存 review_state writer output 與 post-write smoke artifact", + "人工確認每個 dedupe_key 的 review_state 已符合 transaction preview", + "只在 receipt 通過後才進入 review_state closeout 與後續 read-only inventory", + "不得從 UI/API 補寫、重跑 CLI 或自動掛 scheduler", + ], + "safe_boundaries": [ + "do_not_execute_review_state_writer_from_receipt_api", + "do_not_read_approval_token_from_receipt_api", + "do_not_echo_operator_receipt_payload", + "do_not_open_database_connection_from_review_state_receipt", + "do_not_update_review_state_from_review_state_receipt", + "do_not_commit_review_state_receipt", + "do_not_attach_scheduler_from_review_state_receipt", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 0a60d58..5a02ae9 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -22,10 +22,11 @@ from services.market_intel.candidate_queue_review_decision_writer_postwrite_smok from services.market_intel.candidate_queue_review_decision_writer_operator_drill import build_candidate_queue_review_decision_writer_operator_drill from services.market_intel.candidate_queue_review_decision_writer_run_package import build_candidate_queue_review_decision_writer_run_package from services.market_intel.candidate_queue_review_decision_writer_run_readiness import build_candidate_queue_review_decision_writer_run_readiness +from services.market_intel.candidate_queue_review_decision_writer_run_receipt import build_candidate_queue_review_decision_writer_run_receipt BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database") -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -150,6 +151,10 @@ def build_deployment_readiness_preview( operator_drill=candidate_queue_review_decision_writer_operator_drill, run_package=candidate_queue_review_decision_writer_run_package, ) + candidate_queue_review_decision_writer_run_receipt = build_candidate_queue_review_decision_writer_run_receipt( + transaction_preview=candidate_queue_review_decision_transaction, + run_readiness=candidate_queue_review_decision_writer_run_readiness, + ) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -408,6 +413,10 @@ def build_deployment_readiness_preview( candidate_queue_review_decision_writer_run_readiness, "candidate_queue_review_decision_writer_run_readiness_preview", ), + "candidate_queue_review_decision_writer_run_receipt_preview_safe": _run_review_preview_safe( + candidate_queue_review_decision_writer_run_receipt, + "candidate_queue_review_decision_writer_run_receipt_preview", + ), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -649,6 +658,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_decision_writer_operator_drill": candidate_queue_review_decision_writer_operator_drill, "candidate_queue_review_decision_writer_run_package": candidate_queue_review_decision_writer_run_package, "candidate_queue_review_decision_writer_run_readiness": candidate_queue_review_decision_writer_run_readiness, + "candidate_queue_review_decision_writer_run_receipt": candidate_queue_review_decision_writer_run_receipt, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index fbb95f2..d00b1a9 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_74_candidate_queue_review_decision_writer_run_readiness" +MARKET_INTEL_PHASE = "phase_75_candidate_queue_review_decision_writer_run_receipt" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index d1815ff..90e8edb 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -661,6 +661,9 @@ + @@ -1009,6 +1012,7 @@ const sampleCandidateQueueReviewDecisionRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-package]') : null; const sampleCandidateQueueReviewDecisionRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-readiness]') : null; const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null; + const sampleCandidateQueueReviewDecisionRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-receipt]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1034,6 +1038,7 @@ const sampleCandidateQueueReviewDecisionRunPackageEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_package') }}"; const sampleCandidateQueueReviewDecisionRunReadinessEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness') }}"; const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}"; + const sampleCandidateQueueReviewDecisionRunReceiptEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -4207,6 +4212,107 @@ } }; + const renderCandidateQueueReviewDecisionRunReceipt = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const writer = data.writer_output_summary || {}; + const smoke = data.postwrite_smoke_summary || {}; + const evidence = data.operator_evidence_summary || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `receipt=${data.receipt_passed ? 'pass' : 'blocked'}`, + `writer=${writer.mode || 'missing'}`, + `smoke=${smoke.postwrite_smoke_passed ? 'pass' : 'blocked'}`, + `api_update=${data.ready_for_api_review_state_update ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只審核 review_state CLI 更新後的 writer output 與 post-write smoke receipt；API/UI 不讀 token、不執行 CLI、不連 DB、不補更新 review_state。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
expected=${escapeHtml((data.expected_dedupe_keys || []).join(', ') || 'none')} / writer=${escapeHtml((writer.observed_dedupe_keys || []).join(', ') || 'none')} / smoke=${escapeHtml((smoke.found_dedupe_keys || []).join(', ') || 'none')}
+
+
+

RECEIPT GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 receipt gate。
' + }
+
+
+

WRITER / SMOKE

+
+ ${[ + ['writer_committed', writer.database_commit_executed], + ['writer_review_state_update', writer.review_state_update_executed], + ['writer_dedupe_match', writer.dedupe_keys_match_expected], + ['writer_token_key_detected', writer.approval_token_key_detected], + ['smoke_read_only', smoke.read_only_query_executed], + ['smoke_verified', smoke.review_state_update_verified], + ['smoke_state_mismatch', smoke.state_mismatch_count || 0] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

ARTIFACT EVIDENCE

+
+ ${[ + ['writer_output_json_path_recorded', evidence.writer_output_json_path_recorded], + ['postwrite_smoke_json_path_recorded', evidence.postwrite_smoke_json_path_recorded], + ['operator_confirmed_no_token_in_artifacts', evidence.operator_confirmed_no_token_in_artifacts], + ['approval_token_submitted_to_api', evidence.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueReviewDecisionRunReceipt = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
審核 queue review decision writer run receipt 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewDecisionRunReceiptEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewDecisionRunReceipt(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review decision writer run receipt 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -5883,6 +5989,9 @@ if (sampleCandidateQueueReviewDecisionWriter) { sampleCandidateQueueReviewDecisionWriter.addEventListener('click', loadCandidateQueueReviewDecisionWriter); } + if (sampleCandidateQueueReviewDecisionRunReceipt) { + sampleCandidateQueueReviewDecisionRunReceipt.addEventListener('click', loadCandidateQueueReviewDecisionRunReceipt); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 9acabf6..f4a6b0c 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -856,6 +856,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -880,6 +884,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-decision-run-readiness" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-decision-run-receipt" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -916,7 +924,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert bridge["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1074,7 +1082,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert contract["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1207,7 +1215,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1220,7 +1228,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert gate["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1290,7 +1298,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1302,7 +1310,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1350,7 +1358,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1361,7 +1369,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert acceptance["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1403,7 +1411,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1415,7 +1423,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert review["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1526,7 +1534,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1565,7 +1573,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert review["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1627,7 +1635,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1707,7 +1715,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert handoff["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1771,7 +1779,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1830,7 +1838,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert queue_draft["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1904,7 +1912,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1967,7 +1975,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert approval["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2045,7 +2053,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2108,7 +2116,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert transaction["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2188,7 +2196,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -4419,6 +4427,189 @@ def test_candidate_queue_review_decision_writer_run_readiness_preview_checks_ope ) +def test_candidate_queue_review_decision_writer_run_receipt_preview_reviews_operator_artifacts(): + from services.market_intel.candidate_queue_review_decision_writer_cli import ( + build_candidate_queue_review_decision_writer_cli_plan, + ) + from services.market_intel.candidate_queue_review_decision_writer_preflight import ( + build_candidate_queue_review_decision_writer_preflight, + ) + from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import ( + build_candidate_queue_review_decision_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_review_decision_writer_operator_drill import ( + build_candidate_queue_review_decision_writer_operator_drill, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_package import ( + build_candidate_queue_review_decision_writer_run_package, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_readiness import ( + build_candidate_queue_review_decision_writer_run_readiness, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_receipt import ( + build_candidate_queue_review_decision_writer_run_receipt, + ) + + transaction, operator_evidence = _build_ready_review_decision_transaction() + expected_key = transaction["statements"][0]["lookup"]["dedupe_key"] + operator_evidence = { + **operator_evidence, + "operator_confirmed_manual_shell_window": True, + "operator_confirmed_post_update_inventory_planned": True, + "operator_drill_notes": "review_state shell drill reviewed", + } + writer_status = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + operator_evidence=operator_evidence, + ) + preflight = build_candidate_queue_review_decision_writer_preflight( + writer_status=writer_status, + transaction_preview=transaction, + operator_evidence=operator_evidence, + ) + smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + drill = build_candidate_queue_review_decision_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_evidence=operator_evidence, + ) + package = build_candidate_queue_review_decision_writer_run_package( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + ) + receipt_evidence = { + **operator_evidence, + "review_state_transaction_json_path": ( + "artifacts/market_intel/review-state-transaction.json" + ), + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": ( + "artifacts/market_intel/review-state-preflight.json" + ), + "operator_confirmed_review_state_preflight_only": True, + "operator_acknowledged_shell_only_token": True, + "review_state_writer_output_json_path": ( + "artifacts/market_intel/review-state-writer-output.json" + ), + "review_state_postwrite_smoke_json_path": ( + "artifacts/market_intel/review-state-postwrite-smoke.json" + ), + "operator_confirmed_no_token_in_artifacts": True, + "receipt_notes": "review_state receipt reviewed", + } + readiness = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + run_package=package, + operator_evidence=receipt_evidence, + ) + writer_output = { + "mode": "candidate_queue_review_decision_writer_cli_executed", + "exit_code": 0, + "approval_token_present": True, + "approval_token_valid": True, + "approval_token_secret_configured": True, + "approval_env_var": "MARKET_INTEL_QUEUE_WRITE_APPROVAL", + "writes_executed": True, + "would_write_database": True, + "database_connection_opened": True, + "explicit_transaction_opened": True, + "database_write_executed": True, + "database_commit_executed": True, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "api_updates_review_state": False, + "review_state_update_executed": True, + "updated_count": 1, + "skipped_count": 0, + "affected_dedupe_keys": [expected_key], + "skipped_dedupe_keys": [], + } + postwrite_smoke_result = { + "mode": "candidate_queue_review_decision_writer_postwrite_smoke_read_only", + "postwrite_smoke_passed": True, + "review_state_update_verified": True, + "ready_for_operator_review": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": 1, + "found_count": 1, + "missing_count": 0, + "state_mismatch_count": 0, + "found_dedupe_keys": [expected_key], + "missing_dedupe_keys": [], + "state_mismatches": [], + } + receipt = build_candidate_queue_review_decision_writer_run_receipt( + transaction_preview=transaction, + run_readiness=readiness, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=receipt_evidence, + ) + token_leak = build_candidate_queue_review_decision_writer_run_receipt( + transaction_preview=transaction, + run_readiness=readiness, + writer_output={**writer_output, "approval_token": TEST_APPROVAL_TOKEN}, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=receipt_evidence, + ) + + assert receipt["mode"] == ( + "candidate_queue_review_decision_writer_run_receipt_preview" + ) + assert receipt["target_operation"] == "update_review_state" + assert receipt["receipt_passed"] is True + assert receipt["ready_for_next_manual_phase"] is True + assert receipt["ready_for_api_review_state_update"] is False + assert receipt["ready_for_api_database_write"] is False + assert receipt["ready_for_scheduler_attach"] is False + assert receipt["api_executes_cli"] is False + assert receipt["api_reads_approval_token"] is False + assert receipt["api_writes_file"] is False + assert receipt["api_updates_review_state"] is False + assert receipt["review_state_update_executed"] is False + assert receipt["database_connection_opened"] is False + assert receipt["database_write_executed"] is False + assert receipt["database_commit_executed"] is False + assert receipt["scheduler_attached"] is False + assert receipt["writer_output_summary"]["review_state_update_executed"] is True + assert receipt["writer_output_summary"]["dedupe_keys_match_expected"] is True + assert receipt["postwrite_smoke_summary"]["dedupe_keys_match_expected"] is True + assert receipt["postwrite_smoke_summary"]["review_state_update_verified"] is True + assert receipt["operator_evidence_summary"][ + "writer_output_json_path_recorded" + ] is True + assert receipt["blocked_reasons"] == [] + assert token_leak["receipt_passed"] is False + assert token_leak["writer_output_summary"]["approval_token_key_detected"] is True + assert "writer_output_no_approval_token_key" in token_leak["blocked_reasons"] + assert "do_not_update_review_state_from_review_state_receipt" in receipt[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -4461,7 +4652,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4518,7 +4709,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -4607,7 +4798,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4661,7 +4852,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -4717,7 +4908,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -4783,7 +4974,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -5085,7 +5276,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -5133,7 +5324,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -5182,7 +5373,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -5240,7 +5431,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -5306,7 +5497,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -5377,7 +5568,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -5453,7 +5644,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -5535,7 +5726,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -5621,7 +5812,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -5704,7 +5895,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -5787,7 +5978,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -5873,7 +6064,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -5964,7 +6155,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_74_candidate_queue_review_decision_writer_run_readiness" + "phase_75_candidate_queue_review_decision_writer_run_receipt" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -5988,6 +6179,116 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-review-decision-run-receipt-route" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_receipt" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_receipt" + "?execute=true&apply_real_write=true", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": { + **fixture["operator_evidence"], + "review_state_transaction_json_path": ( + "artifacts/market_intel/review-state-transaction.json" + ), + "operator_confirmed_review_state_preflight_only": True, + "operator_acknowledged_shell_only_token": True, + "review_state_writer_output_json_path": ( + "artifacts/market_intel/review-state-writer-output.json" + ), + "review_state_postwrite_smoke_json_path": ( + "artifacts/market_intel/review-state-postwrite-smoke.json" + ), + "operator_confirmed_no_token_in_artifacts": True, + "receipt_notes": "review_state receipt reviewed", + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_inventory_read_only": True, + "reviewer_id": "operator-a", + "proposed_review_decision": "confirmed", + "decision_notes": "manual review only", + "operator_confirmed_manual_decision_only": True, + "decision_approval_notes": "cli-only approval gate", + "operator_confirmed_decision_payload_reviewed": True, + "operator_confirmed_decision_apply_requires_cli": True, + "operator_confirmed_review_state_update_is_not_api": True, + "decision_transaction_notes": "shell-only transaction preview", + "operator_confirmed_transaction_payload_reviewed": True, + "operator_confirmed_cli_only_transaction": True, + "operator_confirmed_manual_shell_window": True, + "operator_confirmed_post_update_inventory_planned": True, + "operator_drill_notes": "manual shell drill reviewed", + }, + "writer_output": { + **fixture["writer_output"], + "mode": "candidate_queue_review_decision_writer_cli_executed", + "review_state_update_executed": True, + "api_updates_review_state": False, + }, + "postwrite_smoke_result": { + **fixture["postwrite_smoke_result"], + "mode": ( + "candidate_queue_review_decision_writer_postwrite_smoke_read_only" + ), + "review_state_update_verified": True, + "state_mismatch_count": 0, + "state_mismatches": [], + }, + }, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_decision_writer_run_receipt_preview" + ) + assert data["phase"] == ( + "phase_75_candidate_queue_review_decision_writer_run_receipt" + ) + assert data["receipt_passed"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_writes_file"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["scheduler_attached"] is False + assert data["expected_dedupe_keys"] == [] + assert "expected_dedupe_keys_present" in data["blocked_reasons"] + assert "do_not_execute_review_state_writer_from_receipt_api" in data[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6016,7 +6317,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -6041,7 +6342,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -6079,7 +6380,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -6090,7 +6391,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -6126,7 +6427,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -6137,7 +6438,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -6178,7 +6479,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -6189,7 +6490,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -6237,7 +6538,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -6249,7 +6550,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -6295,7 +6596,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -6308,7 +6609,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -6393,7 +6694,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -6471,7 +6772,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -6486,7 +6787,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert readiness["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -6962,6 +7263,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_decision_writer_run_receipt_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -7081,6 +7388,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_decision_writer_run_readiness" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_receipt" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -8120,6 +8432,58 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"]["mode"] + == "candidate_queue_review_decision_writer_run_receipt_preview" + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "ready_for_api_review_state_update" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "api_executes_cli" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "api_reads_approval_token" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "api_updates_review_state" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "review_state_update_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_receipt"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -8270,7 +8634,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert drill["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -8385,7 +8749,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -8397,7 +8761,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert review["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -8512,7 +8876,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -8525,7 +8889,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert smoke["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -8587,7 +8951,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -8600,7 +8964,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert inventory["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -8744,7 +9108,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -8971,7 +9335,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -9000,7 +9364,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" + assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False