@@ -689,9 +707,10 @@
const opportunityAlertRoot = document.querySelector('[data-market-intel-opportunity-alert]');
const migrationRoot = document.querySelector('[data-market-intel-migration]');
const migrationDrillRoot = document.querySelector('[data-market-intel-migration-drill]');
+ const catalogReviewRoot = document.querySelector('[data-market-intel-catalog-review]');
const approvalRoot = document.querySelector('[data-market-intel-approval]');
const deployRoot = document.querySelector('[data-market-intel-deploy]');
- if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !approvalRoot && !deployRoot) return;
+ if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !approvalRoot && !deployRoot) return;
const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null;
const body = root ? root.querySelector('[data-market-intel-preview-body]') : null;
@@ -765,6 +784,10 @@
const migrationDrillBody = migrationDrillRoot ? migrationDrillRoot.querySelector('[data-market-intel-migration-drill-body]') : null;
const migrationDrillRefresh = migrationDrillRoot ? migrationDrillRoot.querySelector('[data-market-intel-migration-drill-refresh]') : null;
const migrationDrillEndpoint = "{{ url_for('market_intel.market_intel_migration_apply_drill') }}?execute=false";
+ const catalogReviewMeta = catalogReviewRoot ? catalogReviewRoot.querySelector('[data-market-intel-catalog-review-meta]') : null;
+ const catalogReviewBody = catalogReviewRoot ? catalogReviewRoot.querySelector('[data-market-intel-catalog-review-body]') : null;
+ const catalogReviewRefresh = catalogReviewRoot ? catalogReviewRoot.querySelector('[data-market-intel-catalog-review-refresh]') : null;
+ const catalogReviewEndpoint = "{{ url_for('market_intel.market_intel_migration_catalog_review') }}?execute=false";
const approvalMeta = approvalRoot ? approvalRoot.querySelector('[data-market-intel-approval-meta]') : null;
const approvalBody = approvalRoot ? approvalRoot.querySelector('[data-market-intel-approval-body]') : null;
const approvalRefresh = approvalRoot ? approvalRoot.querySelector('[data-market-intel-approval-refresh]') : null;
@@ -2433,6 +2456,109 @@
}
};
+ const renderCatalogReviewMeta = data => {
+ catalogReviewMeta.innerHTML = [
+ `mode=${data.mode || 'unknown'}`,
+ `catalog=${data.catalog_state || 'unknown'}`,
+ `risk=${data.risk_level || 'info'}`,
+ `tables=${data.table_catalog ? `${data.table_catalog.existing_count || 0}/${data.table_catalog.expected_count || 0}` : '0/0'}`,
+ `apply=${data.apply_path || 'blocked'}`
+ ].map(item => `
${escapeHtml(item)}`).join('');
+ };
+
+ const renderCatalogReviewBody = data => {
+ const blockers = (data.blocked_reasons || []).join(' / ');
+ const checks = Object.entries(data.safe_checks || {});
+ const tableCatalog = data.table_catalog || {};
+ const seedCatalog = data.seed_catalog || {};
+ const findings = data.findings || [];
+ const nextSteps = data.operator_next_steps || [];
+ const probeTargets = data.manual_probe_targets || [];
+ const renderCheck = ([name, passed]) => `
+
+
+ ${escapeHtml(name)}
+
+
${passed ? 'PASS' : 'BLOCK'}
+
+ `;
+ const renderNamedItem = item => `
+
+
+ ${escapeHtml(item.key || item.label || 'item')}
+ ${escapeHtml(item.label || item.key || '')}
+
+
${escapeHtml(item.status || item.severity || 'review').toUpperCase()}
+
+ `;
+ catalogReviewBody.innerHTML = `
+
此卡只判讀正式 DB catalog 與 platform seed diff 的只讀結果；API 不執行 migration、不寫 DB、不跑 rollback、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
tables=${escapeHtml(tableCatalog.existing_count || 0)}/${escapeHtml(tableCatalog.expected_count || 0)} / missing=${escapeHtml(tableCatalog.missing_count || 0)} / seed_missing=${escapeHtml((seedCatalog.missing_codes || []).length)} / seed_changed=${escapeHtml((seedCatalog.changed_codes || []).length)}
+
+
+
SAFE CHECKS
+
${
+ checks.length
+ ? checks.map(renderCheck).join('')
+ : '
尚未提供 safety checks。
'
+ }
+
+
+
CATALOG FINDINGS
+
${
+ findings.length
+ ? findings.map(renderNamedItem).join('')
+ : '
尚未提供 catalog finding。
'
+ }
+
+
+
TABLE STATUS
+
${
+ (tableCatalog.table_statuses || []).slice(0, 8).map(item => `
+
+
+ ${escapeHtml(item.table)}
+
+
${item.exists ? 'EXISTS' : 'MISSING'}
+
+ `).join('') || '
尚未提供 table status。
'
+ }
+
+
+
NEXT STEPS
+
${
+ nextSteps.length
+ ? nextSteps.map(renderNamedItem).join('')
+ : '
尚未提供下一步。
'
+ }
+
+
+
READ-ONLY PROBES
+
${
+ probeTargets.length
+ ? probeTargets.map(item => renderNamedItem({ key: item, label: item, status: 'manual' })).join('')
+ : '
尚未提供 probe targets。
'
+ }
+
+
+ `;
+ };
+
+ const loadCatalogReview = async () => {
+ if (!catalogReviewMeta || !catalogReviewBody) return;
+ catalogReviewBody.innerHTML = '
讀取正式 DB catalog 判讀中...
';
+ try {
+ const response = await fetch(catalogReviewEndpoint, { credentials: 'same-origin' });
+ if (!response.ok) throw new Error(`HTTP ${response.status}`);
+ const data = await response.json();
+ renderCatalogReviewMeta(data);
+ renderCatalogReviewBody(data);
+ } catch (error) {
+ catalogReviewMeta.innerHTML = '
error';
+ catalogReviewBody.innerHTML = `
正式 DB catalog 判讀讀取失敗：${escapeHtml(error.message)}
`;
+ }
+ };
+
const renderApprovalMeta = data => {
approvalMeta.innerHTML = [
`mode=${data.mode || 'unknown'}`,
@@ -2646,6 +2772,9 @@
if (migrationDrillRefresh) {
migrationDrillRefresh.addEventListener('click', loadMigrationDrill);
}
+ if (catalogReviewRefresh) {
+ catalogReviewRefresh.addEventListener('click', loadCatalogReview);
+ }
if (approvalRefresh) {
approvalRefresh.addEventListener('click', loadApproval);
}
@@ -2670,6 +2799,7 @@
loadOpportunityAlert();
loadMigration();
loadMigrationDrill();
+ loadCatalogReview();
loadApproval();
loadDeploy();
})();
diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py
index 70d002a..b20e01e 100644
--- a/tests/test_market_intel_skeleton.py
+++ b/tests/test_market_intel_skeleton.py
@@ -488,6 +488,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
assert "data-market-intel-migration-drill-checks" in template
assert "data-market-intel-migration-drill-preapply" in template
assert "data-market-intel-migration-drill-rollback" in template
+ assert "data-market-intel-catalog-review" in template
+ assert "data-market-intel-catalog-review-checks" in template
+ assert "data-market-intel-catalog-review-findings" in template
+ assert "data-market-intel-catalog-review-tables" in template
assert "data-market-intel-approval" in template
assert "data-market-intel-approval-gates" in template
assert "data-market-intel-deploy" in template
@@ -511,6 +515,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
assert "market_intel.market_intel_opportunity_alert_plan" in template
assert "market_intel.market_intel_migration_blueprint" in template
assert "market_intel.market_intel_migration_apply_drill" in template
+ assert "market_intel.market_intel_migration_catalog_review" in template
assert "market_intel.market_intel_write_approval_runbook" in template
assert "market_intel.market_intel_deployment_readiness" in template
assert "required_manual_steps" in template
@@ -535,7 +540,7 @@ def test_legacy_source_bridge_default_is_planned_only():
bridge = MarketIntelService().build_legacy_source_bridge()
assert bridge["mode"] == "legacy_source_bridge_planned"
- assert bridge["phase"] == "phase_43_migration_apply_drill_preview"
+ assert bridge["phase"] == "phase_44_migration_catalog_review_preview"
assert bridge["execute_requested"] is False
assert bridge["read_only_query_executed"] is False
assert bridge["database_connection_opened"] is False
@@ -693,7 +698,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
contract = MarketIntelService().build_mcp_tool_contract()
assert contract["mode"] == "mcp_tool_contract_preview"
- assert contract["phase"] == "phase_43_migration_apply_drill_preview"
+ assert contract["phase"] == "phase_44_migration_catalog_review_preview"
assert contract["caller"] == "market_intel"
assert contract["contract_ready"] is True
assert contract["blocked_reasons"] == []
@@ -826,7 +831,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_activation_runbook_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -839,7 +844,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
assert gate["mode"] == "mcp_fetch_gate_planned"
- assert gate["phase"] == "phase_43_migration_apply_drill_preview"
+ assert gate["phase"] == "phase_44_migration_catalog_review_preview"
assert gate["fetch_requested"] is True
assert gate["manual_fetch_gate_open"] is False
assert gate["network_request_allowed"] is False
@@ -909,7 +914,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_fetch_gate_planned"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["fetch_requested"] is False
assert data["network_request_allowed"] is False
assert data["external_network_executed"] is False
@@ -921,7 +926,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
plan = MarketIntelService().build_scheduler_plan()
assert plan["mode"] == "scheduler_attach_plan_preview"
- assert plan["phase"] == "phase_43_migration_apply_drill_preview"
+ assert plan["phase"] == "phase_44_migration_catalog_review_preview"
assert plan["ready_to_attach_scheduler"] is False
assert plan["scheduler_attached"] is False
assert plan["scheduler_registration_executed"] is False
@@ -959,7 +964,7 @@ def test_scheduler_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "scheduler_attach_plan_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["scheduler_registration_executed"] is False
assert data["crawler_job_started"] is False
assert data["external_network_executed"] is False
@@ -970,7 +975,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
plan = MarketIntelService().build_match_review_plan()
assert plan["mode"] == "match_review_plan_preview"
- assert plan["phase"] == "phase_43_migration_apply_drill_preview"
+ assert plan["phase"] == "phase_44_migration_catalog_review_preview"
assert plan["ready_for_review_queue"] is False
assert plan["review_queue_created"] is False
assert plan["auto_match_executed"] is False
@@ -1006,7 +1011,7 @@ def test_match_review_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "match_review_plan_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["review_queue_created"] is False
assert data["auto_confirm_executed"] is False
assert data["external_network_executed"] is False
@@ -1017,7 +1022,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
plan = MarketIntelService().build_opportunity_plan()
assert plan["mode"] == "opportunity_plan_preview"
- assert plan["phase"] == "phase_43_migration_apply_drill_preview"
+ assert plan["phase"] == "phase_44_migration_catalog_review_preview"
assert plan["ready_for_opportunity_queue"] is False
assert plan["opportunity_queue_created"] is False
assert plan["threat_alert_dispatched"] is False
@@ -1058,7 +1063,7 @@ def test_opportunity_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_plan_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["opportunity_queue_created"] is False
assert data["threat_alert_dispatched"] is False
assert data["ai_summary_generated"] is False
@@ -1069,7 +1074,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
plan = MarketIntelService().build_opportunity_scoring_plan()
assert plan["mode"] == "opportunity_scoring_plan_preview"
- assert plan["phase"] == "phase_43_migration_apply_drill_preview"
+ assert plan["phase"] == "phase_44_migration_catalog_review_preview"
assert plan["ready_for_scoring_job"] is False
assert plan["scoring_job_created"] is False
assert plan["score_calculation_executed"] is False
@@ -1117,7 +1122,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_scoring_plan_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["scoring_job_created"] is False
assert data["score_calculation_executed"] is False
assert data["sample_scores_generated"] is False
@@ -1129,7 +1134,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
plan = MarketIntelService().build_opportunity_evidence_plan()
assert plan["mode"] == "opportunity_evidence_plan_preview"
- assert plan["phase"] == "phase_43_migration_apply_drill_preview"
+ assert plan["phase"] == "phase_44_migration_catalog_review_preview"
assert plan["ready_for_evidence_bundle"] is False
assert plan["evidence_bundle_created"] is False
assert plan["evidence_query_executed"] is False
@@ -1175,7 +1180,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_evidence_plan_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["evidence_bundle_created"] is False
assert data["evidence_query_executed"] is False
assert data["sample_evidence_generated"] is False
@@ -1188,7 +1193,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
plan = MarketIntelService().build_opportunity_alert_plan()
assert plan["mode"] == "opportunity_alert_plan_preview"
- assert plan["phase"] == "phase_43_migration_apply_drill_preview"
+ assert plan["phase"] == "phase_44_migration_catalog_review_preview"
assert plan["ready_for_alert_candidates"] is False
assert plan["alert_candidate_created"] is False
assert plan["alert_queue_created"] is False
@@ -1273,7 +1278,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_alert_plan_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["alert_candidate_created"] is False
assert data["alert_queue_created"] is False
assert data["review_queue_created"] is False
@@ -1351,7 +1356,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_external_deploy_preflight_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -1366,7 +1371,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
readiness = MarketIntelService().build_mcp_readiness()
assert readiness["mode"] == "mcp_readiness_planned"
- assert readiness["phase"] == "phase_43_migration_apply_drill_preview"
+ assert readiness["phase"] == "phase_44_migration_catalog_review_preview"
assert readiness["execute_requested"] is False
assert readiness["router_enabled"] is False
assert readiness["external_mcp_complete"] is False
@@ -1760,6 +1765,7 @@ def test_deployment_readiness_reports_app_only_release_gate():
assert readiness["checks"]["opportunity_evidence_plan_preview_safe"] is True
assert readiness["checks"]["opportunity_alert_plan_preview_safe"] is True
assert readiness["checks"]["migration_apply_drill_preview_safe"] is True
+ assert readiness["checks"]["migration_catalog_review_preview_safe"] is True
assert readiness["checks"]["writer_plan_dry_run_only"] is True
assert readiness["writer_plan_summary"]["writes_executed"] is False
assert "readiness_checks_not_all_passed" not in readiness["blocked_reasons"]
@@ -1787,6 +1793,7 @@ def test_deployment_readiness_reports_app_only_release_gate():
assert "/api/market_intel/opportunity_evidence_plan" in readiness["production_smoke_targets"]
assert "/api/market_intel/opportunity_alert_plan" in readiness["production_smoke_targets"]
assert "/api/market_intel/migration_apply_drill" in readiness["production_smoke_targets"]
+ assert "/api/market_intel/migration_catalog_review" in readiness["production_smoke_targets"]
assert readiness["write_approval_runbook"]["ready_for_real_write"] is False
assert readiness["write_approval_runbook"]["writes_executed"] is False
assert readiness["migration_blueprint"]["migration_executed"] is False
@@ -1797,6 +1804,11 @@ def test_deployment_readiness_reports_app_only_release_gate():
assert readiness["migration_apply_drill"]["rollback_executed"] is False
assert readiness["migration_apply_drill"]["database_write_executed"] is False
assert readiness["migration_apply_drill"]["api_executes_migration"] is False
+ assert readiness["migration_catalog_review"]["mode"] == "migration_catalog_review_preview"
+ assert readiness["migration_catalog_review"]["catalog_state"] == "planned_no_probe"
+ assert readiness["migration_catalog_review"]["migration_executed"] is False
+ assert readiness["migration_catalog_review"]["database_write_executed"] is False
+ assert readiness["migration_catalog_review"]["api_executes_migration"] is False
assert readiness["schema_db_probe"]["read_only_query_executed"] is False
assert readiness["platform_seed_db_diff"]["read_only_query_executed"] is False
assert readiness["legacy_source_bridge"]["read_only_query_executed"] is False
@@ -1914,7 +1926,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only():
drill = MarketIntelService().build_migration_apply_drill()
assert drill["mode"] == "migration_apply_drill_preview"
- assert drill["phase"] == "phase_43_migration_apply_drill_preview"
+ assert drill["phase"] == "phase_44_migration_catalog_review_preview"
assert drill["execute_requested"] is False
assert drill["schema_state"] == "planned_no_db_probe"
assert drill["drill_ready_for_operator_review"] is True
@@ -2029,7 +2041,7 @@ def test_migration_apply_drill_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_apply_drill_preview"
- assert data["phase"] == "phase_43_migration_apply_drill_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
assert data["execute_requested"] is False
assert data["migration_executed"] is False
assert data["rollback_executed"] is False
@@ -2037,6 +2049,134 @@ def test_migration_apply_drill_route_is_preview_only():
assert data["api_executes_migration"] is False
+def test_migration_catalog_review_planned_is_safe_and_diagnostic():
+ review = MarketIntelService().build_migration_catalog_review()
+
+ assert review["mode"] == "migration_catalog_review_preview"
+ assert review["phase"] == "phase_44_migration_catalog_review_preview"
+ assert review["execute_requested"] is False
+ assert review["catalog_state"] == "planned_no_probe"
+ assert review["seed_state"] == "planned_no_probe"
+ assert review["risk_level"] == "info"
+ assert review["apply_path"] == "run_execute_true_read_only_probe_first"
+ assert review["review_ready"] is True
+ assert review["ready_for_manual_migration_review"] is False
+ assert review["ready_to_apply_migration"] is False
+ assert review["read_only_query_executed"] is False
+ assert review["database_connection_opened"] is False
+ assert review["database_session_created"] is False
+ assert review["database_write_executed"] is False
+ assert review["database_commit_executed"] is False
+ assert review["migration_executed"] is False
+ assert review["rollback_executed"] is False
+ assert review["api_executes_migration"] is False
+ assert review["table_catalog"]["expected_count"] == 8
+ assert review["table_catalog"]["existing_count"] == 0
+ assert review["table_catalog"]["missing_count"] == 8
+ assert "execute_false_planned_only" in review["blocked_reasons"]
+ assert "migration_not_executed_by_catalog_review" in review["blocked_reasons"]
+ assert {item["key"] for item in review["findings"]} >= {
+ "catalog_probe_not_executed",
+ "seed_diff_not_executed",
+ }
+
+
+def test_migration_catalog_review_sqlite_read_only_detects_partial_schema():
+ service = MarketIntelService()
+ seed_rows = service.build_platform_seed_plan()["seeds"]
+ engine = create_engine("sqlite:///:memory:")
+ with engine.begin() as conn:
+ conn.execute(
+ text(
+ """
+ CREATE TABLE market_platforms (
+ code TEXT PRIMARY KEY,
+ name TEXT,
+ base_url TEXT,
+ enabled BOOLEAN,
+ crawl_policy_json TEXT
+ )
+ """
+ )
+ )
+ for seed in seed_rows:
+ conn.execute(
+ text(
+ """
+ INSERT INTO market_platforms
+ (code, name, base_url, enabled, crawl_policy_json)
+ VALUES
+ (:code, :name, :base_url, :enabled, :crawl_policy_json)
+ """
+ ),
+ {
+ "code": seed["code"],
+ "name": seed["name"],
+ "base_url": seed["base_url"],
+ "enabled": seed["enabled"],
+ "crawl_policy_json": json.dumps(
+ seed["crawl_policy_json"],
+ ensure_ascii=False,
+ sort_keys=True,
+ ),
+ },
+ )
+
+ review = service.build_migration_catalog_review(
+ execute_requested=True,
+ schema_engine=engine,
+ seed_diff_engine=engine,
+ database_type="sqlite",
+ )
+
+ assert review["mode"] == "migration_catalog_review_preview"
+ assert review["execute_requested"] is True
+ assert review["read_only_query_executed"] is True
+ assert review["database_connection_opened"] is True
+ assert review["catalog_state"] == "partial_schema"
+ assert review["seed_state"] == "ready"
+ assert review["risk_level"] == "high"
+ assert review["apply_path"] == "blocked_until_partial_schema_reviewed"
+ assert review["ready_for_manual_migration_review"] is False
+ assert review["table_catalog"]["expected_count"] == 8
+ assert review["table_catalog"]["existing_count"] == 1
+ assert review["table_catalog"]["missing_count"] == 7
+ assert review["seed_catalog"]["seed_rows_ready"] is True
+ assert "partial_schema_requires_manual_reconciliation" in review["blocked_reasons"]
+ assert review["database_session_created"] is False
+ assert review["database_write_executed"] is False
+ assert review["database_commit_executed"] is False
+ assert review["migration_executed"] is False
+ assert {item["key"] for item in review["findings"]} >= {
+ "partial_market_schema_detected",
+ "platform_seed_ready",
+ }
+
+
+def test_migration_catalog_review_route_is_preview_only():
+ from routes.market_intel_routes import market_intel_bp
+
+ app = Flask(__name__)
+ app.secret_key = "test-secret"
+ app.register_blueprint(market_intel_bp)
+ client = app.test_client()
+ with client.session_transaction() as session:
+ session["logged_in"] = True
+
+ response = client.get("/api/market_intel/migration_catalog_review?execute=false")
+ data = response.get_json()
+
+ assert response.status_code == 200
+ assert data["mode"] == "migration_catalog_review_preview"
+ assert data["phase"] == "phase_44_migration_catalog_review_preview"
+ assert data["execute_requested"] is False
+ assert data["catalog_state"] == "planned_no_probe"
+ assert data["migration_executed"] is False
+ assert data["rollback_executed"] is False
+ assert data["database_write_executed"] is False
+ assert data["api_executes_migration"] is False
+
+
def test_seed_writer_cli_status_blocks_real_write():
status = MarketIntelService().build_seed_writer_cli_status(
platform_code="all",