From 2e8f57dfbeeace5aae718d190b1acf0a66b69705 Mon Sep 17 00:00:00 2001 From: OoO Date: Sun, 31 May 2026 15:52:56 +0800 Subject: [PATCH] V10.500 add market intel queue writer run closeout review gate --- TODO_NEXT_STEPS.txt | 1 + config.py | 2 +- ...s-platform-market-campaign-intelligence.md | 1 + .../code_modularization_inventory_20260430.md | 3 +- .../current_execution_queue_20260524.md | 1 + docs/memory/history_logs.md | 1 + routes/market_intel_mcp_run_routes.py | 51 ++ services/market_intel/deployment_readiness.py | 66 ++ ...didate_queue_writer_run_closeout_review.py | 651 +++++++++++++++++ services/market_intel/phase.py | 2 +- templates/market_intel/disabled.html | 171 ++++- tests/test_market_intel_skeleton.py | 678 +++++++++++++----- 12 files changed, 1425 insertions(+), 203 deletions(-) create mode 100644 services/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index d6786d7..d3a42d1 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.500 新增市場情報 MCP Fetch Candidate Queue Writer Run Closeout Review 安全預覽 gate：只審核 receipt review 通過後的 operator closeout 摘要，確認 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmation；API 不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler。 - V10.499 新增市場情報 MCP Fetch Candidate Queue Writer Run Receipt Review 安全預覽 gate：只審核操作員 shell writer run 後貼回的 receipt 摘要，確認 readiness linkage、run package id、候選/dedupe keys、writer output、post-write smoke、backup path 與 operator confirmation；API 不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-write query、不掛 scheduler。 - V10.498 新增市場情報 MCP Fetch Candidate Queue Writer Run Readiness 安全預覽 gate：只審核 run package review 後的操作員 readiness 證據，確認 run readiness artifact、reviewed sample、備份、read-only preflight 與 post-write smoke 路徑安全，以及 CLI-only / approval token shell-only 邊界；API 不產檔、不讀 token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler。 - V10.497 新增市場情報 MCP Fetch Candidate Queue Writer Run Package Review 安全預覽 gate：只審核 CLI review 通過後的 operator run package 草案，要求 package id、artifact manifest、operator shell command sequence、candidate/dedupe keys 與 CLI review 對齊；API 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 diff --git a/config.py b/config.py index 3d73337..da4e655 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.499" +SYSTEM_VERSION = "V10.500" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index c846181..0e35c57 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -171,6 +171,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate queue writer run package review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review` 在 CLI review 通過後審核 operator run package 草案，檢查 package identity、artifact manifest、operator shell command sequence、candidate/dedupe keys、CLI review id 與 preflight id；API/UI 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - 2026-05-31 追加 MCP fetch candidate queue writer run readiness gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness` 在 run package review 通過後審核 operator readiness 證據，檢查 run readiness artifact、reviewed sample、備份、read-only preflight、post-write smoke 路徑、操作員覆核確認、CLI-only 與 approval token shell-only 邊界；API/UI 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到後續 run receipt review。 - 2026-05-31 追加 MCP fetch candidate queue writer run receipt review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_receipt_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_receipt_review` 在 run readiness 通過後審核 operator shell writer run 的 receipt 摘要，檢查 readiness linkage、run package id、候選/dedupe keys、writer output artifact、post-write smoke artifact、backup path、operator confirmations 與 token redaction；API/UI 不讀 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 post-write query、不掛 scheduler，只放行到 closeout review。 +- 2026-05-31 追加 MCP fetch candidate queue writer run closeout review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review` 在 receipt review 通過後審核 operator closeout 摘要，檢查 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmations；API/UI 不讀 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler，只放行到 read-only post-closeout inventory review。 - 2026-05-18 追加 scheduler attach plan preview：`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB；排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview：`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP；價格只能作為輔助訊號，不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview：`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB；高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 927bcab..b7feea1 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -49,6 +49,7 @@ - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run package review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py` 為 660 行，略過 600 行提醒門檻。暫不拆分的理由是 run package gate 需要把 CLI review linkage、artifact manifest、operator shell command sequence 與 side-effect blocklist 放在單一 preview module 便於安全審核；若下一段 run readiness review 重複相同 policy，應抽出 writer policy helper。 - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run readiness gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_readiness.py` 為 640 行，略過 600 行提醒門檻。暫不拆分的理由是 readiness gate 需同時審核上一段 run package review linkage、operator artifact path policy、CLI-only/token-only confirmation 與 side-effect blocklist；若後續 run receipt gate 再重複 policy，應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run receipt review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_receipt_review.py` 為 688 行，略過 600 行提醒門檻。暫不拆分的理由是 receipt gate 需同時審核 readiness linkage、receipt identity、artifact path policy、operator confirmation、token redaction 與 side-effect blocklist；若下一段 closeout gate 重複相同 path/side-effect policy，應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 +- 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run closeout review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review.py` 為 651 行，略過 600 行提醒門檻。暫不拆分的理由是 closeout gate 需同時審核 receipt review linkage、artifact manifest preservation、rollback note、read-only inventory next-step 與 side-effect blocklist；若下一段 post-closeout inventory gate 重複 path/side-effect policy，應抽出 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-24 追記：同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數；此處只更新 inventory，不變更 Code Review 行為。 - 2026-05-21 追記：同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 - 2026-05-21 追記：同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 @@ -101,7 +102,7 @@ | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | | 917 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 1446 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 1512 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index ceeb03a..16f8427 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -95,6 +95,7 @@ - 2026-05-31 起，`V10.497` 新增市場情報 MCP Fetch Candidate Queue Writer Run Package Review gate：在 CLI review 通過後只審核 operator run package 草案，要求 artifact manifest、operator shell command sequence、package identity、candidate/dedupe keys 與 CLI review 對齊；仍不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - 2026-05-31 起，`V10.498` 新增市場情報 MCP Fetch Candidate Queue Writer Run Readiness gate：在 run package review 通過後只審核 operator readiness 證據，要求 run readiness artifact、reviewed sample、備份、read-only preflight 與 post-write smoke 路徑安全，並確認 CLI-only、approval token shell-only、無 API/DB/file/scheduler 副作用；仍不產檔、不讀 token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到後續 run receipt review。 - 2026-05-31 起，`V10.499` 新增市場情報 MCP Fetch Candidate Queue Writer Run Receipt Review gate：在 run readiness 通過後只審核操作員 shell writer run 的 receipt 摘要，要求 readiness linkage、run package id、候選/dedupe keys、writer output、post-write smoke、backup path 與 operator confirmation 對齊；仍不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-write query、不掛 scheduler，只放行到 closeout review。 +- 2026-05-31 起，`V10.500` 新增市場情報 MCP Fetch Candidate Queue Writer Run Closeout Review gate：在 receipt review 通過後只審核 operator closeout 摘要，要求 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmation 對齊；仍不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler，只放行到 read-only post-closeout inventory review。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 044e3f9..2fc4417 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24：PChome 近門檻身份回收第二輪 +- **V10.500 市場情報 MCP Fetch Candidate Queue Writer Run Closeout Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review` 與 UI preview，只審核 receipt review 通過後的 operator closeout 摘要；要求 receipt linkage、closeout artifact、receipt review artifact、post-closeout inventory plan、writer output / post-write smoke / backup manifest、rollback note 與 operator confirmation 對齊，且 API 不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler，只放行到 read-only post-closeout inventory review。 - **V10.499 市場情報 MCP Fetch Candidate Queue Writer Run Receipt Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_receipt_review` 與 UI preview，只審核操作員 shell writer run 後貼回的 receipt 摘要；要求 readiness linkage、run package id、候選/dedupe keys、writer output、post-write smoke、backup path 與 operator confirmation 對齊，且 API 不讀 receipt 原文、不讀 token、不執行 CLI、不開 DB、不寫 queue、不做 post-write query、不掛 scheduler，只放行到 closeout review。 - **V10.498 市場情報 MCP Fetch Candidate Queue Writer Run Readiness gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_readiness` 與 UI preview，只審核 run package review 後的 operator readiness 證據；要求 run readiness artifact、reviewed sample、備份、read-only preflight 與 post-write smoke 路徑安全，並確認 CLI-only、approval token shell-only、無 API/DB/file/scheduler 副作用。API 不產檔、不讀 token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到後續 run receipt review。 - **V10.497 市場情報 MCP Fetch Candidate Queue Writer Run Package Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review` 與 UI preview，只審核 CLI review 後的 operator run package 草案；要求 package identity、artifact manifest、operator shell command sequence、candidate/dedupe keys 與 CLI review 完全對齊，且 API 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index b80be2e..c527baf 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -40,6 +40,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import from services.market_intel.mcp_fetch_candidate_queue_writer_run_receipt_review import ( build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review import ( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -500,3 +503,51 @@ def market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review(): + writer_run_receipt_review_package = {} + writer_run_receipt_review_result = None + operator_closeout = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_run_closeout_review_package") + or payload.get("candidate_queue_writer_run_closeout_review") + or payload.get("writer_run_closeout") + or payload.get("run_closeout_review") + or payload + ) + writer_run_receipt_review_package = ( + package.get("writer_run_receipt_review_package") + or package.get("candidate_queue_writer_run_receipt_review") + or package.get("writer_run_receipt_review") + or package.get("run_receipt_review_package") + or {} + ) + writer_run_receipt_review_result = ( + package.get("writer_run_receipt_review_result") + or package.get("mcp_fetch_candidate_queue_writer_run_receipt_review") + ) + operator_closeout = ( + package.get("operator_closeout") + or package.get("writer_run_closeout") + or package.get("candidate_queue_writer_run_closeout") + or package.get("closeout_payload") + or package.get("closeout") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( + writer_run_receipt_review_package=writer_run_receipt_review_package, + writer_run_receipt_review_result=writer_run_receipt_review_result, + operator_closeout=operator_closeout, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 1eed407..82cf1d7 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -96,6 +96,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import from services.market_intel.mcp_fetch_candidate_queue_writer_run_receipt_review import ( build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review import ( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -253,6 +256,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_candidate_queue_writer_run_receipt_review",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -327,6 +335,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_run_closeout_review = ( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -1045,6 +1058,58 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "scheduler_attached" ] ), + "mcp_fetch_candidate_queue_writer_run_closeout_review_preview_safe": bool( + mcp_fetch_candidate_queue_writer_run_closeout_review["mode"] + == "mcp_fetch_candidate_queue_writer_run_closeout_review_preview" + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "payload_persisted" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "run_closeout_persisted" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "run_closeout_file_written" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "closeout_file_written" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "package_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "api_writes_file" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "api_executes_cli" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "api_reads_approval_token" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "api_writes_database" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "api_uses_external_network" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "post_closeout_query_executed_by_api" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "cli_executed" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "file_written" + ] + and not mcp_fetch_candidate_queue_writer_run_closeout_review[ + "scheduler_attached" + ] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1369,6 +1434,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_candidate_queue_writer_run_package_review": mcp_fetch_candidate_queue_writer_run_package_review, "mcp_fetch_candidate_queue_writer_run_readiness": mcp_fetch_candidate_queue_writer_run_readiness, "mcp_fetch_candidate_queue_writer_run_receipt_review": mcp_fetch_candidate_queue_writer_run_receipt_review, + "mcp_fetch_candidate_queue_writer_run_closeout_review": mcp_fetch_candidate_queue_writer_run_closeout_review, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review.py b/services/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review.py new file mode 100644 index 0000000..966872b --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review.py @@ -0,0 +1,651 @@ +"""市場情報 MCP fetch candidate queue writer run closeout review preview。 + +本模組只審核 operator shell writer run receipt review 之後的 closeout 摘要； +API/UI 不讀 receipt 原文、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、 +不做 post-closeout query、不掛 scheduler。 +""" + +from copy import deepcopy + +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE +from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import ( + ARTIFACT_PREFIX, + BACKUP_PREFIX, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_receipt_review import ( + build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview, +) + + +_SAMPLE_RUN_CLOSEOUT_REVIEW_PACKAGE = None + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "secret", + "session_cookie", + "token", +) + +SAFE_SECRET_METADATA_KEYS = { + "no_approval_token_payload", + "operator_confirmed_no_approval_token_payload", + "token_not_logged", +} + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_cli_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_execution_allowed", + "api_executed_cli", + "api_executes", + "api_executes_cli", + "api_opens_database_connection", + "api_reads_approval_token", + "api_uses_external_network", + "api_writes_database", + "api_writes_file", + "apply_real_write", + "attach_scheduler", + "candidate_queue_created_by_api", + "candidate_queue_persisted_by_api", + "candidate_review_state_updated", + "cli_executed_by_api", + "closeout_file_written", + "closeout_persisted", + "command_executed_by_api", + "database_commit_executed", + "database_connection_opened", + "database_session_created", + "database_write_executed_by_api", + "execute_requested", + "external_network_executed_by_api", + "file_written", + "network_request_allowed", + "opens_database_connection", + "package_artifact_created", + "payload_persisted", + "post_closeout_query_executed_by_api", + "ready_for_api_database_write", + "ready_for_real_write", + "real_write_allowed_by_api", + "review_state_update_executed", + "run_closeout_file_written", + "run_closeout_persisted", + "scheduler_attach", + "scheduler_attached", + "write_database", + "writes_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _safe_path(value, *, prefixes, suffixes): + if not isinstance(value, str): + return False + normalized = value.strip().replace("\\", "/") + if not normalized or normalized.startswith("/"): + return False + parts = [part for part in normalized.split("/") if part] + if any(part in (".", "..") for part in parts): + return False + return normalized.startswith(prefixes) and normalized.endswith(suffixes) + + +def _contains_forbidden_key(value, forbidden_keys, *, safe_keys=None): + safe_keys = safe_keys or set() + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in safe_keys and isinstance(nested, bool): + continue + if any(forbidden_key in normalized_key for forbidden_key in forbidden_keys): + return True + if _contains_forbidden_key(nested, forbidden_keys, safe_keys=safe_keys): + return True + elif isinstance(value, list): + return any( + _contains_forbidden_key(item, forbidden_keys, safe_keys=safe_keys) + for item in value + ) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _receipt_review_from_inputs(receipt_package, receipt_result, phase): + if isinstance(receipt_result, dict) and receipt_result: + return receipt_result + + receipt_package = _as_dict(receipt_package) + return build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview( + writer_run_readiness_package=( + receipt_package.get("writer_run_readiness_package") + or receipt_package.get("candidate_queue_writer_run_readiness") + or receipt_package.get("writer_run_readiness") + or receipt_package.get("run_readiness_package") + or {} + ), + writer_run_readiness_result=( + receipt_package.get("writer_run_readiness_result") + or receipt_package.get("mcp_fetch_candidate_queue_writer_run_readiness") + ), + writer_run_receipt=( + receipt_package.get("writer_run_receipt") + or receipt_package.get("candidate_queue_writer_run_receipt") + or receipt_package.get("run_receipt") + or receipt_package.get("receipt_payload") + or receipt_package.get("receipt") + ), + phase=phase, + ) + + +def _sample_run_closeout_review_package(): + global _SAMPLE_RUN_CLOSEOUT_REVIEW_PACKAGE + if _SAMPLE_RUN_CLOSEOUT_REVIEW_PACKAGE is not None: + return deepcopy(_SAMPLE_RUN_CLOSEOUT_REVIEW_PACKAGE) + + receipt_package = ( + build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview()[ + "sample_writer_run_receipt_review_package" + ] + ) + receipt_result = build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview( + writer_run_readiness_package=receipt_package["writer_run_readiness_package"], + writer_run_readiness_result=receipt_package["writer_run_readiness_result"], + writer_run_receipt=receipt_package["writer_run_receipt"], + ) + receipt = _receipt_review_summary(receipt_result) + operator_closeout = { + "closeout_id": "market-intel-candidate-writer-run-closeout-sample", + "run_package_id": receipt["run_package_id"], + "receipt_id": receipt["receipt_id"], + "target_table": TARGET_TABLE, + "payload_row_count": receipt["payload_row_count"], + "closeout_artifact_path": ( + ARTIFACT_PREFIX + "candidate-queue-writer-run-closeout-sample.json" + ), + "receipt_review_artifact_path": ( + ARTIFACT_PREFIX + + "candidate-queue-writer-run-receipt-review-sample.json" + ), + "post_closeout_inventory_plan_path": ( + ARTIFACT_PREFIX + "candidate-queue-post-closeout-inventory-plan.json" + ), + "rollback_note": "No API rollback executed; operator keeps DB backup path.", + "closeout_notes": "Receipt accepted; next step is read-only live inventory.", + "artifact_manifest": { + "writer_output_path": receipt["writer_output_path"], + "postwrite_smoke_result_path": receipt["postwrite_smoke_result_path"], + "backup_artifact_path": receipt["backup_artifact_path"], + }, + "operator_confirmations": { + "receipt_reviewed": True, + "artifacts_preserved": True, + "rollback_note_recorded": True, + "post_closeout_inventory_read_only": True, + "no_approval_token_payload": True, + "no_api_cli_execution": True, + "no_api_database_write": True, + "no_api_file_write": True, + "no_post_closeout_query_by_api": True, + "no_scheduler_attach": True, + }, + "api_execution_allowed": False, + "real_write_allowed_by_api": False, + } + _SAMPLE_RUN_CLOSEOUT_REVIEW_PACKAGE = { + "writer_run_receipt_review_package": receipt_package, + "writer_run_receipt_review_result": receipt_result, + "operator_closeout": operator_closeout, + } + return deepcopy(_SAMPLE_RUN_CLOSEOUT_REVIEW_PACKAGE) + + +def _receipt_review_summary(receipt_result): + receipt_result = _as_dict(receipt_result) + receipt = _as_dict(receipt_result.get("writer_run_receipt_summary")) + side_effects_clear = bool( + not receipt_result.get("payload_persisted") + and not receipt_result.get("run_receipt_review_persisted") + and not receipt_result.get("run_receipt_persisted") + and not receipt_result.get("run_receipt_file_written") + and not receipt_result.get("receipt_file_written") + and not receipt_result.get("package_artifact_created") + and not receipt_result.get("network_request_allowed") + and not receipt_result.get("api_executes_cli") + and not receipt_result.get("api_reads_approval_token") + and not receipt_result.get("api_opens_database_connection") + and not receipt_result.get("api_writes_database") + and not receipt_result.get("api_writes_file") + and not receipt_result.get("api_uses_external_network") + and not receipt_result.get("postwrite_query_executed_by_api") + and not receipt_result.get("database_write_executed") + and not receipt_result.get("cli_executed") + and not receipt_result.get("file_written") + and not receipt_result.get("scheduler_attached") + and not receipt_result.get("candidate_queue_created") + and not receipt_result.get("candidate_queue_persisted") + ) + return { + "mode": receipt_result.get("mode"), + "accepted": bool( + receipt_result.get( + "mcp_fetch_candidate_queue_writer_run_receipt_review_accepted" + ) + ), + "ready_for_closeout_review": bool( + receipt_result.get("ready_for_candidate_queue_writer_run_closeout_review") + ), + "run_package_id": _safe_text(receipt.get("run_package_id"), 160), + "receipt_id": _safe_text(receipt.get("receipt_id"), 160), + "target_table": _safe_text(receipt.get("target_table"), 160), + "payload_row_count": _safe_int(receipt.get("payload_row_count")), + "writer_output_path": _safe_text(receipt.get("writer_output_path")), + "postwrite_smoke_result_path": _safe_text( + receipt.get("postwrite_smoke_result_path") + ), + "backup_artifact_path": _safe_text(receipt.get("backup_artifact_path")), + "postwrite_smoke_read_only_by_operator": bool( + receipt.get("postwrite_smoke_read_only_by_operator") + ), + "postwrite_smoke_expected_rows_found": bool( + receipt.get("postwrite_smoke_expected_rows_found") + ), + "postwrite_smoke_row_count_matches_payload": bool( + receipt.get("postwrite_smoke_row_count_matches_payload") + ), + "side_effects_clear": side_effects_clear, + "blocked_reasons": receipt_result.get("blocked_reasons", []), + } + + +def _operator_closeout_summary(operator_closeout): + operator_closeout = _as_dict(operator_closeout) + manifest = _as_dict(operator_closeout.get("artifact_manifest")) + confirmations = _as_dict(operator_closeout.get("operator_confirmations")) + return { + "provided_keys": sorted(operator_closeout.keys()), + "closeout_id": _safe_text(operator_closeout.get("closeout_id"), 160), + "run_package_id": _safe_text(operator_closeout.get("run_package_id"), 160), + "receipt_id": _safe_text(operator_closeout.get("receipt_id"), 160), + "target_table": _safe_text(operator_closeout.get("target_table"), 160), + "payload_row_count": _safe_int(operator_closeout.get("payload_row_count")), + "closeout_artifact_path": _safe_text( + operator_closeout.get("closeout_artifact_path") + ), + "receipt_review_artifact_path": _safe_text( + operator_closeout.get("receipt_review_artifact_path") + ), + "post_closeout_inventory_plan_path": _safe_text( + operator_closeout.get("post_closeout_inventory_plan_path") + ), + "closeout_artifact_path_safe": _safe_path( + operator_closeout.get("closeout_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "receipt_review_artifact_path_safe": _safe_path( + operator_closeout.get("receipt_review_artifact_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "post_closeout_inventory_plan_path_safe": _safe_path( + operator_closeout.get("post_closeout_inventory_plan_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "manifest_writer_output_path": _safe_text(manifest.get("writer_output_path")), + "manifest_postwrite_smoke_result_path": _safe_text( + manifest.get("postwrite_smoke_result_path") + ), + "manifest_backup_artifact_path": _safe_text( + manifest.get("backup_artifact_path") + ), + "manifest_writer_output_path_safe": _safe_path( + manifest.get("writer_output_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "manifest_postwrite_smoke_result_path_safe": _safe_path( + manifest.get("postwrite_smoke_result_path"), + prefixes=(ARTIFACT_PREFIX,), + suffixes=(".json",), + ), + "manifest_backup_artifact_path_safe": _safe_path( + manifest.get("backup_artifact_path"), + prefixes=(BACKUP_PREFIX,), + suffixes=(".zip", ".tar.gz"), + ), + "rollback_note_recorded": bool(_safe_text(operator_closeout.get("rollback_note"))), + "closeout_notes_recorded": bool(_safe_text(operator_closeout.get("closeout_notes"))), + "receipt_reviewed": bool(confirmations.get("receipt_reviewed")), + "artifacts_preserved": bool(confirmations.get("artifacts_preserved")), + "operator_rollback_note_recorded": bool( + confirmations.get("rollback_note_recorded") + ), + "post_closeout_inventory_read_only": bool( + confirmations.get("post_closeout_inventory_read_only") + ), + "no_approval_token_payload": bool( + confirmations.get("no_approval_token_payload") + ), + "no_api_cli_execution": bool(confirmations.get("no_api_cli_execution")), + "no_api_database_write": bool(confirmations.get("no_api_database_write")), + "no_api_file_write": bool(confirmations.get("no_api_file_write")), + "no_post_closeout_query_by_api": bool( + confirmations.get("no_post_closeout_query_by_api") + ), + "no_scheduler_attach": bool(confirmations.get("no_scheduler_attach")), + "api_execution_allowed": bool(operator_closeout.get("api_execution_allowed")), + "real_write_allowed_by_api": bool( + operator_closeout.get("real_write_allowed_by_api") + ), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + operator_closeout, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_side_effects(operator_closeout), + } + + +def _closeout_gates(*, receipt_received, closeout_received, receipt, closeout): + artifact_manifest_matches = bool( + closeout["manifest_writer_output_path"] + and closeout["manifest_writer_output_path"] == receipt["writer_output_path"] + and closeout["manifest_postwrite_smoke_result_path"] + == receipt["postwrite_smoke_result_path"] + and closeout["manifest_backup_artifact_path"] == receipt["backup_artifact_path"] + ) + artifact_manifest_paths_safe = bool( + closeout["manifest_writer_output_path_safe"] + and closeout["manifest_postwrite_smoke_result_path_safe"] + and closeout["manifest_backup_artifact_path_safe"] + ) + operator_confirmed_boundaries = bool( + closeout["receipt_reviewed"] + and closeout["artifacts_preserved"] + and closeout["operator_rollback_note_recorded"] + and closeout["post_closeout_inventory_read_only"] + and closeout["no_approval_token_payload"] + and closeout["no_api_cli_execution"] + and closeout["no_api_database_write"] + and closeout["no_api_file_write"] + and closeout["no_post_closeout_query_by_api"] + and closeout["no_scheduler_attach"] + ) + return [ + { + "key": "writer_run_receipt_review_payload_or_result_received", + "label": "已提供 writer run receipt review package 或已審核結果", + "passed": receipt_received, + }, + { + "key": "writer_run_receipt_review_accepted", + "label": "writer run receipt review gate 必須已通過", + "passed": receipt["accepted"], + }, + { + "key": "writer_run_receipt_review_ready_for_closeout", + "label": "receipt review 必須只放行到 closeout review", + "passed": receipt["ready_for_closeout_review"], + }, + { + "key": "writer_run_receipt_review_side_effect_free", + "label": "receipt review 未顯示 API 執行、寫 DB、寫檔或掛 scheduler", + "passed": receipt["side_effects_clear"], + }, + { + "key": "writer_run_receipt_review_identity_recorded", + "label": "receipt review 必須保留 run_package_id 與 receipt_id", + "passed": bool(receipt["run_package_id"] and receipt["receipt_id"]), + }, + { + "key": "writer_run_receipt_review_postwrite_smoke_passed", + "label": "receipt review 的 post-write smoke 必須是操作員只讀且 row count 對齊", + "passed": bool( + receipt["postwrite_smoke_read_only_by_operator"] + and receipt["postwrite_smoke_expected_rows_found"] + and receipt["postwrite_smoke_row_count_matches_payload"] + ), + }, + { + "key": "writer_run_closeout_payload_received", + "label": "已提供 operator closeout 摘要", + "passed": closeout_received, + }, + { + "key": "writer_run_closeout_identity_recorded", + "label": "closeout 必須記錄 closeout_id、run_package_id 與 receipt_id", + "passed": bool( + closeout["closeout_id"] + and closeout["run_package_id"] + and closeout["receipt_id"] + ), + }, + { + "key": "writer_run_closeout_identity_matches_receipt", + "label": "closeout run_package_id / receipt_id 必須對齊 receipt review", + "passed": bool( + closeout["run_package_id"] == receipt["run_package_id"] + and closeout["receipt_id"] == receipt["receipt_id"] + ), + }, + { + "key": "writer_run_closeout_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": closeout["target_table"] == TARGET_TABLE, + }, + { + "key": "writer_run_closeout_payload_count_matches_receipt", + "label": "closeout row count 必須對齊 receipt review", + "passed": bool( + closeout["payload_row_count"] + and closeout["payload_row_count"] == receipt["payload_row_count"] + ), + }, + { + "key": "writer_run_closeout_artifact_paths_safe", + "label": "closeout、receipt review 與 post-closeout inventory plan paths 必須安全", + "passed": bool( + closeout["closeout_artifact_path_safe"] + and closeout["receipt_review_artifact_path_safe"] + and closeout["post_closeout_inventory_plan_path_safe"] + ), + }, + { + "key": "writer_run_closeout_artifact_manifest_preserved", + "label": "closeout artifact manifest 必須保留 writer output、post-write smoke 與 backup path", + "passed": bool(artifact_manifest_matches and artifact_manifest_paths_safe), + }, + { + "key": "writer_run_closeout_notes_recorded", + "label": "closeout 必須記錄 closeout notes 與 rollback note", + "passed": bool( + closeout["closeout_notes_recorded"] + and closeout["rollback_note_recorded"] + ), + }, + { + "key": "writer_run_closeout_operator_boundaries_confirmed", + "label": "操作員確認 artifact 保存、只讀 inventory、無 API DB/CLI/file/scheduler", + "passed": operator_confirmed_boundaries, + }, + { + "key": "writer_run_closeout_no_api_execution_or_real_write", + "label": "closeout payload 不得允許 API execution 或 real write", + "passed": bool( + not closeout["api_execution_allowed"] + and not closeout["real_write_allowed_by_api"] + ), + }, + { + "key": "writer_run_closeout_no_secret_or_token_key", + "label": "closeout payload 不得包含 secret、cookie、password 或 token key", + "passed": not closeout["secret_or_token_submitted_to_api"], + }, + { + "key": "writer_run_closeout_side_effect_free", + "label": "closeout payload 不得要求 API 寫檔、執行、寫 DB 或掛 scheduler", + "passed": not closeout["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( + *, + writer_run_receipt_review_package=None, + writer_run_receipt_review_result=None, + operator_closeout=None, + phase=None, +): + """建立 fetch candidate queue writer run closeout review；不執行查詢或寫入。""" + writer_run_receipt_review_package = _as_dict(writer_run_receipt_review_package) + receipt_result_received = bool( + isinstance(writer_run_receipt_review_result, dict) + and writer_run_receipt_review_result + ) + closeout_valid_object = ( + isinstance(operator_closeout, dict) if operator_closeout is not None else True + ) + closeout_payload = _as_dict(operator_closeout) + receipt_result = _receipt_review_from_inputs( + writer_run_receipt_review_package, + writer_run_receipt_review_result, + phase, + ) + receipt_received = bool( + writer_run_receipt_review_package or receipt_result_received + ) + payload_received = bool( + receipt_received or closeout_payload or operator_closeout is not None + ) + closeout_received = bool(closeout_payload) + receipt = _receipt_review_summary(receipt_result) + closeout = _operator_closeout_summary(closeout_payload) + gates = _closeout_gates( + receipt_received=receipt_received, + closeout_received=closeout_received and closeout_valid_object, + receipt=receipt, + closeout=closeout, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + if not closeout_valid_object: + blocked_reasons.append("operator_closeout_payload_valid_object") + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_run_closeout_review" + if payload_received + else "mcp_fetch_candidate_queue_writer_run_closeout_review_preview" + ), + "phase": phase, + "writer_run_closeout_review_payload_received": payload_received, + "writer_run_receipt_review_received": receipt_received, + "operator_closeout_received": closeout_received, + "operator_closeout_valid_object": closeout_valid_object, + "writer_run_receipt_review_accepted": receipt["accepted"], + "mcp_fetch_candidate_queue_writer_run_closeout_review_accepted": accepted, + "candidate_queue_writer_run_closeout_review_ready": accepted, + "ready_for_candidate_queue_post_closeout_inventory_review": accepted, + "ready_for_api_database_write": False, + "ready_for_real_write": False, + "ready_for_scheduler_attach": False, + "network_request_allowed": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_writes_file": False, + "api_uses_external_network": False, + "post_closeout_query_executed_by_api": False, + "payload_row_count": closeout["payload_row_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "writer_run_receipt_review_summary": receipt, + "operator_closeout_summary": closeout, + "sample_writer_run_closeout_review_package": ( + _sample_run_closeout_review_package() + ), + "next_operator_steps": [ + "Closeout review 通過後，只代表可進入 post-closeout live inventory read-only review", + "API/UI 仍不得回放 receipt 原文、執行 CLI、讀 token、開 DB 或寫 queue", + "後續 live inventory 必須只讀確認 queue row，不得在 UI/API 補寫資料或掛 scheduler", + ], + "payload_persisted": False, + "run_closeout_review_persisted": False, + "run_closeout_persisted": False, + "run_closeout_file_written": False, + "closeout_file_written": False, + "package_artifact_created": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "cli_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 22dded7..0839610 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" +MARKET_INTEL_PHASE = "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index bff79dd..4394ca3 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -968,6 +968,32 @@ +
+
+
+

MCP / WRITER RUN CLOSEOUT

+

MCP Candidate Queue Writer Run Closeout Review

+
+ +
+
+ loading +
+
+
讀取 MCP Writer Run Closeout Review 中...
+
+
+ +
+ +
+
+
+
@@ -1488,6 +1514,7 @@ const mcpFetchCandidateQueueWriterRunPackageReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review]'); const mcpFetchCandidateQueueWriterRunReadinessRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-readiness]'); const mcpFetchCandidateQueueWriterRunReceiptReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-receipt-review]'); + const mcpFetchCandidateQueueWriterRunCloseoutReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1504,7 +1531,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !mcpFetchCandidateQueueWriterRunReadinessRoot && !mcpFetchCandidateQueueWriterRunReceiptReviewRoot && !mcpFetchCandidateQueueWriterRunCloseoutReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1647,6 +1674,12 @@ const mcpFetchCandidateQueueWriterRunReceiptReviewReview = mcpFetchCandidateQueueWriterRunReceiptReviewRoot ? mcpFetchCandidateQueueWriterRunReceiptReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-receipt-review-review]') : null; const mcpFetchCandidateQueueWriterRunReceiptReviewRefresh = mcpFetchCandidateQueueWriterRunReceiptReviewRoot ? mcpFetchCandidateQueueWriterRunReceiptReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-receipt-review-refresh]') : null; const mcpFetchCandidateQueueWriterRunReceiptReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review') }}"; + const mcpFetchCandidateQueueWriterRunCloseoutReviewMeta = mcpFetchCandidateQueueWriterRunCloseoutReviewRoot ? mcpFetchCandidateQueueWriterRunCloseoutReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-meta]') : null; + const mcpFetchCandidateQueueWriterRunCloseoutReviewBody = mcpFetchCandidateQueueWriterRunCloseoutReviewRoot ? mcpFetchCandidateQueueWriterRunCloseoutReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-body]') : null; + const mcpFetchCandidateQueueWriterRunCloseoutReviewInput = mcpFetchCandidateQueueWriterRunCloseoutReviewRoot ? mcpFetchCandidateQueueWriterRunCloseoutReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-input]') : null; + const mcpFetchCandidateQueueWriterRunCloseoutReviewReview = mcpFetchCandidateQueueWriterRunCloseoutReviewRoot ? mcpFetchCandidateQueueWriterRunCloseoutReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-review]') : null; + const mcpFetchCandidateQueueWriterRunCloseoutReviewRefresh = mcpFetchCandidateQueueWriterRunCloseoutReviewRoot ? mcpFetchCandidateQueueWriterRunCloseoutReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-refresh]') : null; + const mcpFetchCandidateQueueWriterRunCloseoutReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -4618,6 +4651,135 @@ } }; + const renderMcpFetchCandidateQueueWriterRunCloseoutReviewMeta = data => { + mcpFetchCandidateQueueWriterRunCloseoutReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_run_closeout_review_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || 0}`, + `inventory=${data.ready_for_candidate_queue_post_closeout_inventory_review ? 'ready' : 'blocked'}`, + `db=${data.api_writes_database ? 'write' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterRunCloseoutReviewBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const receipt = data.writer_run_receipt_review_summary || {}; + const closeout = data.operator_closeout_summary || {}; + const artifacts = [ + ['closeout_artifact_path', closeout.closeout_artifact_path, closeout.closeout_artifact_path_safe], + ['receipt_review_artifact_path', closeout.receipt_review_artifact_path, closeout.receipt_review_artifact_path_safe], + ['post_closeout_inventory_plan_path', closeout.post_closeout_inventory_plan_path, closeout.post_closeout_inventory_plan_path_safe], + ['manifest_writer_output_path', closeout.manifest_writer_output_path, closeout.manifest_writer_output_path_safe], + ['manifest_postwrite_smoke_result_path', closeout.manifest_postwrite_smoke_result_path, closeout.manifest_postwrite_smoke_result_path_safe], + ['manifest_backup_artifact_path', closeout.manifest_backup_artifact_path, closeout.manifest_backup_artifact_path_safe] + ]; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterRunCloseoutReviewBody.innerHTML = ` +
此 run closeout review 只審核 receipt review 後的收尾摘要；API 不讀 receipt 原文、不執行 CLI、不讀 approval token、不開 DB、不寫 queue、不做 post-closeout query、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

CLOSEOUT GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 closeout gates。
' + }
+
+
+

RECEIPT REVIEW LINK

+
+ ${renderCheck('receipt_review', `${receipt.accepted ? 'accepted' : 'pending'} / rows=${receipt.payload_row_count || 0}`, receipt.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('receipt_id', receipt.receipt_id || 'missing', receipt.receipt_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('api_boundary', 'no CLI / no token / no DB / no scheduler', receipt.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

CLOSEOUT SUMMARY

+
+ ${renderCheck('closeout_id', closeout.closeout_id || 'missing', closeout.closeout_id ? 'RECORDED' : 'BLOCK')} + ${renderCheck('run_package_id', closeout.run_package_id || 'missing', closeout.run_package_id === receipt.run_package_id ? 'MATCH' : 'BLOCK')} + ${renderCheck('receipt_id', closeout.receipt_id || 'missing', closeout.receipt_id === receipt.receipt_id ? 'MATCH' : 'BLOCK')} + ${renderCheck('notes', 'closeout notes + rollback note', closeout.closeout_notes_recorded && closeout.rollback_note_recorded ? 'RECORDED' : 'BLOCK')} +
+
+
+

ARTIFACT TRACE

+
+ ${artifacts.map(item => renderCheck(item[0], item[1] || 'missing', item[2] ? 'SAFE' : 'BLOCK')).join('')} +
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck('operator_boundaries', 'artifact preserved, read-only inventory, no API DB/CLI/file/scheduler', closeout.receipt_reviewed && closeout.artifacts_preserved && closeout.post_closeout_inventory_read_only && closeout.no_api_database_write && closeout.no_scheduler_attach ? 'CONFIRMED' : 'BLOCK')} + ${renderCheck('api_side_effects', 'no closeout file / no CLI / no token / no DB / no queue', data.run_closeout_file_written || data.api_executes_cli || data.api_reads_approval_token || data.api_writes_database || data.post_closeout_query_executed_by_api ? 'BLOCK' : 'CLOSED')} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterRunCloseoutReviewInput && !mcpFetchCandidateQueueWriterRunCloseoutReviewInput.value.trim() && data.sample_writer_run_closeout_review_package) { + mcpFetchCandidateQueueWriterRunCloseoutReviewInput.value = JSON.stringify(data.sample_writer_run_closeout_review_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterRunCloseoutReview = async () => { + if (!mcpFetchCandidateQueueWriterRunCloseoutReviewMeta || !mcpFetchCandidateQueueWriterRunCloseoutReviewBody) return; + mcpFetchCandidateQueueWriterRunCloseoutReviewBody.innerHTML = '
讀取 MCP Writer Run Closeout Review 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterRunCloseoutReviewEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterRunCloseoutReviewMeta(data); + renderMcpFetchCandidateQueueWriterRunCloseoutReviewBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterRunCloseoutReviewMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterRunCloseoutReviewBody.innerHTML = `
MCP Writer Run Closeout Review 讀取失敗：${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterRunCloseoutReview = async () => { + if (!mcpFetchCandidateQueueWriterRunCloseoutReviewMeta || !mcpFetchCandidateQueueWriterRunCloseoutReviewBody || !mcpFetchCandidateQueueWriterRunCloseoutReviewInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterRunCloseoutReviewInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterRunCloseoutReviewMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterRunCloseoutReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterRunCloseoutReviewBody.innerHTML = '
審核 MCP Writer Run Closeout Review 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterRunCloseoutReviewEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_run_closeout_review_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterRunCloseoutReviewMeta(data); + renderMcpFetchCandidateQueueWriterRunCloseoutReviewBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterRunCloseoutReviewMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterRunCloseoutReviewBody.innerHTML = `
MCP Writer Run Closeout Review 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -14117,6 +14279,12 @@ if (mcpFetchCandidateQueueWriterRunReceiptReviewReview) { mcpFetchCandidateQueueWriterRunReceiptReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterRunReceiptReview); } + if (mcpFetchCandidateQueueWriterRunCloseoutReviewRefresh) { + mcpFetchCandidateQueueWriterRunCloseoutReviewRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterRunCloseoutReview); + } + if (mcpFetchCandidateQueueWriterRunCloseoutReviewReview) { + mcpFetchCandidateQueueWriterRunCloseoutReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterRunCloseoutReview); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -14387,6 +14555,7 @@ loadMcpFetchCandidateQueueWriterRunPackageReview(); loadMcpFetchCandidateQueueWriterRunReadiness(); loadMcpFetchCandidateQueueWriterRunReceiptReview(); + loadMcpFetchCandidateQueueWriterRunCloseoutReview(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index e8d408a..5147a41 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -53,6 +53,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_run_readiness import from services.market_intel.mcp_fetch_candidate_queue_writer_run_receipt_review import ( build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_closeout_review import ( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1170,6 +1173,34 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-run-receipt-review-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-receipt" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-closeout" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-artifacts" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-closeout-review-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1640,7 +1671,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert bridge["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1798,7 +1829,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert contract["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1931,7 +1962,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1944,7 +1975,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert gate["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -2014,7 +2045,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -2028,7 +2059,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert audit["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -2102,7 +2133,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -2119,11 +2150,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert evidence["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2148,7 +2179,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2206,12 +2237,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2220,11 +2251,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert receipt["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2252,7 +2283,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2317,12 +2348,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2331,11 +2362,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert promotion["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2363,7 +2394,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2423,12 +2454,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2437,11 +2468,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert handoff["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2469,7 +2500,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2531,12 +2562,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2547,11 +2578,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert review["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2581,7 +2612,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2659,13 +2690,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2677,11 +2708,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert package["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2713,7 +2744,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2788,13 +2819,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2808,11 +2839,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert readiness["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2847,11 +2878,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert readiness["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2927,13 +2958,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2947,11 +2978,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert receipt["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -2988,11 +3019,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert receipt["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -3071,13 +3102,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3093,11 +3124,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert parser["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3136,11 +3167,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert parser["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3225,13 +3256,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3247,11 +3278,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert handoff["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3290,11 +3321,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert handoff["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3384,13 +3415,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3407,11 +3438,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert review["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3448,11 +3479,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert review["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3543,13 +3574,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert get_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert post_data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3565,13 +3596,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3609,13 +3640,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3719,7 +3750,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3728,7 +3759,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3744,13 +3775,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( review["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert review["writer_cli_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False @@ -3786,13 +3817,13 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): writer_preflight_package=sample["writer_preflight_package"], writer_preflight_result=sample["writer_preflight_result"], writer_cli_review=sample["writer_cli_review"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( review["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert review["candidate_queue_writer_cli_review_ready"] is True @@ -3893,7 +3924,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( get_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -3902,7 +3933,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( post_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True @@ -3919,7 +3950,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == ( @@ -3927,7 +3958,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_wit ) assert ( review["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert review["writer_run_package_review_payload_received"] is False assert ( @@ -3977,13 +4008,13 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_accepts_sample_revi writer_cli_review_package=sample["writer_cli_review_package"], writer_cli_review_result=sample["writer_cli_review_result"], writer_run_package_review=sample["writer_run_package_review"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_run_package_review" assert ( review["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert ( review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4107,7 +4138,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4119,7 +4150,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] @@ -4139,7 +4170,7 @@ def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_candidate_queue_writer_run_readiness_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert readiness["mode"] == ( @@ -4147,7 +4178,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_preview_is_safe_without_ ) assert ( readiness["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert readiness["writer_run_readiness_payload_received"] is False assert ( @@ -4193,13 +4224,13 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_accepts_sample_review(): ], writer_run_package_review_result=sample["writer_run_package_review_result"], operator_readiness=sample["operator_readiness"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert readiness["mode"] == "mcp_fetch_candidate_queue_writer_run_readiness_review" assert ( readiness["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert ( readiness["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4315,7 +4346,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( get_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4327,7 +4358,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ ) assert ( post_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_readiness_accepted"] @@ -4347,7 +4378,7 @@ def test_mcp_fetch_candidate_queue_writer_run_readiness_route_get_and_post_previ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_without_payload(): receipt = build_mcp_fetch_candidate_queue_writer_run_receipt_review_preview( - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert receipt["mode"] == ( @@ -4355,7 +4386,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_preview_is_safe_wit ) assert ( receipt["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert receipt["writer_run_receipt_review_payload_received"] is False assert ( @@ -4400,13 +4431,13 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_accepts_sample_revi writer_run_readiness_package=sample["writer_run_readiness_package"], writer_run_readiness_result=sample["writer_run_readiness_result"], writer_run_receipt=sample["writer_run_receipt"], - phase="phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review", + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", ) assert receipt["mode"] == "mcp_fetch_candidate_queue_writer_run_receipt_review" assert ( receipt["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert ( receipt["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4538,7 +4569,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( get_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -4550,7 +4581,7 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ ) assert ( post_data["phase"] - == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert ( post_data["mcp_fetch_candidate_queue_writer_run_receipt_review_accepted"] @@ -4568,11 +4599,254 @@ def test_mcp_fetch_candidate_queue_writer_run_receipt_review_route_get_and_post_ assert post_data["api_opens_database_connection"] is False +def test_mcp_fetch_candidate_queue_writer_run_closeout_review_preview_is_safe_without_payload(): + closeout = build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", + ) + + assert closeout["mode"] == ( + "mcp_fetch_candidate_queue_writer_run_closeout_review_preview" + ) + assert ( + closeout["phase"] + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + assert closeout["writer_run_closeout_review_payload_received"] is False + assert ( + closeout["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] + is False + ) + assert closeout["candidate_queue_writer_run_closeout_review_ready"] is False + assert ( + closeout["ready_for_candidate_queue_post_closeout_inventory_review"] + is False + ) + assert closeout["ready_for_api_database_write"] is False + assert closeout["ready_for_real_write"] is False + assert closeout["ready_for_scheduler_attach"] is False + assert closeout["network_request_allowed"] is False + assert closeout["api_executes_cli"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_database"] is False + assert closeout["post_closeout_query_executed_by_api"] is False + assert closeout["payload_persisted"] is False + assert closeout["run_closeout_review_persisted"] is False + assert closeout["run_closeout_persisted"] is False + assert closeout["run_closeout_file_written"] is False + assert closeout["closeout_file_written"] is False + assert closeout["database_write_executed"] is False + assert closeout["scheduler_attached"] is False + assert ( + "writer_run_receipt_review_payload_or_result_received" + in closeout["blocked_reasons"] + ) + assert "writer_run_closeout_payload_received" in closeout["blocked_reasons"] + assert ( + "writer_run_receipt_review_package" + in closeout["sample_writer_run_closeout_review_package"] + ) + assert ( + "operator_closeout" + in closeout["sample_writer_run_closeout_review_package"] + ) + + +def test_mcp_fetch_candidate_queue_writer_run_closeout_review_accepts_sample_review(): + sample = ( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview() + ["sample_writer_run_closeout_review_package"] + ) + closeout = build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( + writer_run_receipt_review_package=sample[ + "writer_run_receipt_review_package" + ], + writer_run_receipt_review_result=sample["writer_run_receipt_review_result"], + operator_closeout=sample["operator_closeout"], + phase="phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review", + ) + + assert closeout["mode"] == "mcp_fetch_candidate_queue_writer_run_closeout_review" + assert ( + closeout["phase"] + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + assert ( + closeout["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] + is True + ) + assert closeout["candidate_queue_writer_run_closeout_review_ready"] is True + assert ( + closeout["ready_for_candidate_queue_post_closeout_inventory_review"] + is True + ) + assert closeout["ready_for_api_database_write"] is False + assert closeout["ready_for_real_write"] is False + assert closeout["blocked_reasons"] == [] + assert closeout["passed_gate_count"] == closeout["gate_count"] + assert closeout["writer_run_receipt_review_accepted"] is True + receipt = closeout["writer_run_receipt_review_summary"] + summary = closeout["operator_closeout_summary"] + assert receipt["target_table"] == "market_alert_review_queue" + assert summary["target_table"] == "market_alert_review_queue" + assert summary["run_package_id"] == receipt["run_package_id"] + assert summary["receipt_id"] == receipt["receipt_id"] + assert summary["payload_row_count"] == receipt["payload_row_count"] + assert summary["closeout_artifact_path_safe"] is True + assert summary["receipt_review_artifact_path_safe"] is True + assert summary["post_closeout_inventory_plan_path_safe"] is True + assert summary["manifest_writer_output_path"] == receipt["writer_output_path"] + assert summary["manifest_postwrite_smoke_result_path"] == ( + receipt["postwrite_smoke_result_path"] + ) + assert summary["manifest_backup_artifact_path"] == receipt["backup_artifact_path"] + assert summary["secret_or_token_submitted_to_api"] is False + assert closeout["network_request_allowed"] is False + assert closeout["api_executes_cli"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_file"] is False + assert closeout["candidate_queue_persisted"] is False + assert closeout["database_write_executed"] is False + assert closeout["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_run_closeout_review_blocks_unsafe_review(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview() + ["sample_writer_run_closeout_review_package"] + ) + ) + closeout_payload = sample["operator_closeout"] + closeout_payload["run_package_id"] = "wrong-package" + closeout_payload["receipt_id"] = "wrong-receipt" + closeout_payload["target_table"] = "market_campaign_products" + closeout_payload["closeout_artifact_path"] = "/tmp/unsafe.json" + closeout_payload["receipt_review_artifact_path"] = "../unsafe.json" + closeout_payload["post_closeout_inventory_plan_path"] = "../inventory.json" + closeout_payload["approval_token"] = "do-not-submit" + closeout_payload["api_execution_allowed"] = True + closeout_payload["real_write_allowed_by_api"] = True + closeout_payload["api_executes_cli"] = True + closeout_payload["database_write_executed_by_api"] = True + closeout_payload["post_closeout_query_executed_by_api"] = True + closeout_payload["artifact_manifest"]["writer_output_path"] = "../writer.json" + closeout_payload["artifact_manifest"]["postwrite_smoke_result_path"] = ( + "../smoke.json" + ) + closeout_payload["operator_confirmations"]["receipt_reviewed"] = False + closeout_payload["operator_confirmations"]["no_api_cli_execution"] = False + closeout_payload["rollback_note"] = "" + closeout_payload["closeout_notes"] = "" + + closeout = build_mcp_fetch_candidate_queue_writer_run_closeout_review_preview( + writer_run_receipt_review_package=sample[ + "writer_run_receipt_review_package" + ], + writer_run_receipt_review_result=sample["writer_run_receipt_review_result"], + operator_closeout=closeout_payload, + ) + + assert ( + closeout["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] + is False + ) + assert closeout["writer_run_receipt_review_accepted"] is True + assert ( + "writer_run_closeout_identity_matches_receipt" + in closeout["blocked_reasons"] + ) + assert "writer_run_closeout_target_table_safe" in closeout["blocked_reasons"] + assert ( + "writer_run_closeout_artifact_paths_safe" + in closeout["blocked_reasons"] + ) + assert ( + "writer_run_closeout_artifact_manifest_preserved" + in closeout["blocked_reasons"] + ) + assert "writer_run_closeout_notes_recorded" in closeout["blocked_reasons"] + assert ( + "writer_run_closeout_operator_boundaries_confirmed" + in closeout["blocked_reasons"] + ) + assert ( + "writer_run_closeout_no_api_execution_or_real_write" + in closeout["blocked_reasons"] + ) + assert "writer_run_closeout_no_secret_or_token_key" in closeout["blocked_reasons"] + assert "writer_run_closeout_side_effect_free" in closeout["blocked_reasons"] + assert closeout["api_executes_cli"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_database"] is False + assert closeout["candidate_queue_persisted"] is False + assert closeout["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_run_closeout_review_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_run_closeout_review_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_closeout_review", + json={"writer_run_closeout_review_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == ( + "mcp_fetch_candidate_queue_writer_run_closeout_review_preview" + ) + assert ( + get_data["phase"] + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert post_response.status_code == 200 + assert ( + post_data["mode"] + == "mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + assert ( + post_data["phase"] + == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" + ) + assert ( + post_data["mcp_fetch_candidate_queue_writer_run_closeout_review_accepted"] + is True + ) + assert ( + post_data["ready_for_candidate_queue_post_closeout_inventory_review"] + is True + ) + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -4620,7 +4894,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -4631,7 +4905,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert acceptance["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -4673,7 +4947,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -4685,7 +4959,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert review["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -4796,7 +5070,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -4835,7 +5109,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert review["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -4897,7 +5171,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -4977,7 +5251,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert handoff["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -5041,7 +5315,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -5100,7 +5374,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert queue_draft["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -5174,7 +5448,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -5237,7 +5511,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert approval["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -5315,7 +5589,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -5378,7 +5652,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert transaction["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -5458,7 +5732,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -11169,7 +11443,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -11244,7 +11518,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -11516,7 +11790,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -11804,7 +12078,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -12114,7 +12388,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -12417,7 +12691,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -12676,7 +12950,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -12949,7 +13223,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -13197,7 +13471,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -13427,7 +13701,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -13664,7 +13938,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -13906,7 +14180,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -14182,7 +14456,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -14459,7 +14733,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -14738,7 +15012,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -15067,7 +15341,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -15329,7 +15603,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -15593,7 +15867,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -15863,7 +16137,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -16151,7 +16425,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -16438,7 +16712,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -16524,7 +16798,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16581,7 +16855,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -16670,7 +16944,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16724,7 +16998,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -16780,7 +17054,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -16846,7 +17120,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -17148,7 +17422,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -17196,7 +17470,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -17245,7 +17519,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -17303,7 +17577,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -17369,7 +17643,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -17440,7 +17714,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -17516,7 +17790,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -17598,7 +17872,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -17684,7 +17958,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -17767,7 +18041,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -17850,7 +18124,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -17936,7 +18210,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -18027,7 +18301,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -18137,7 +18411,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -18223,7 +18497,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -18280,7 +18554,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -18333,7 +18607,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -18386,7 +18660,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -18447,7 +18721,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -18516,7 +18790,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -18588,7 +18862,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -18661,7 +18935,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -18732,7 +19006,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -18797,7 +19071,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -18868,7 +19142,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -18941,7 +19215,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -19018,7 +19292,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -19095,7 +19369,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -19172,7 +19446,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -19246,7 +19520,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -19325,7 +19599,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -19412,7 +19686,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -19493,7 +19767,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -19575,7 +19849,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -19658,7 +19932,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -19683,7 +19957,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -19721,7 +19995,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -19732,7 +20006,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -19768,7 +20042,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -19779,7 +20053,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -19820,7 +20094,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -19831,7 +20105,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -19879,7 +20153,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -19891,7 +20165,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -19937,7 +20211,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -19950,7 +20224,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert plan["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -20035,7 +20309,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -20113,7 +20387,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -20128,7 +20402,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert readiness["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -20557,6 +20831,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_run_closeout_review_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -24981,7 +25261,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert drill["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -25096,7 +25376,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -25108,7 +25388,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert review["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -25223,7 +25503,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -25236,7 +25516,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert smoke["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -25298,7 +25578,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -25311,7 +25591,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert inventory["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -25455,7 +25735,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -25691,7 +25971,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -25720,7 +26000,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_132_market_intel_mcp_fetch_candidate_queue_writer_run_receipt_review" + assert data["phase"] == "phase_133_market_intel_mcp_fetch_candidate_queue_writer_run_closeout_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False