diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index b9d9cc1..b059fad 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -152,6 +152,7 @@ - Phase 75 candidate queue review decision writer run receipt：新增 `services/market_intel/candidate_queue_review_decision_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 與 UI receipt 按鈕，審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.266。 - Phase 76 candidate queue review decision writer run closeout：新增 `services/market_intel/candidate_queue_review_decision_writer_run_closeout.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 與 UI closeout 按鈕，在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.268。 - Phase 77 candidate queue review decision post-closeout inventory：新增 `services/market_intel/candidate_queue_review_decision_post_closeout_inventory.py`、`routes/market_intel_review_post_routes.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory` 與 UI inventory 按鈕，在 review_state closeout 後整理 post-write smoke、live inventory、dedupe key 與 review_state 結果；API/UI 不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不 commit、不掛 scheduler；版本同步至 V10.270。 + - Phase 78 candidate queue review completion archive：新增 `services/market_intel/candidate_queue_review_completion_archive.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive` 與 UI archive 按鈕，在 post-closeout inventory 通過後整理 receipt、closeout、inventory、dedupe key、review_state row snapshot 與 artifact path manifest；API/UI 不寫檔、不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不 commit、不掛 scheduler；版本同步至 V10.273。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/config.py b/config.py index 7e78b41..1ebb88c 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.272" +SYSTEM_VERSION = "V10.273" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 6e7ffc7..cd613dd 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -203,6 +203,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review decision writer run receipt：`services.market_intel.candidate_queue_review_decision_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run closeout：`services.market_intel.candidate_queue_review_decision_writer_run_closeout` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要。此 closeout 只允許放行到後續人工/只讀檢查；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision post-closeout inventory：`services.market_intel.candidate_queue_review_decision_post_closeout_inventory`、`routes.market_intel_review_post_routes` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory` 在 review_state closeout 後整理 post-write smoke、live inventory、dedupe key 與 review_state 結果。此 inventory 只允許只讀驗證；API/UI 不讀 approval token、不執行 CLI、不更新 `review_state`、不寫 DB、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue review completion archive：`services.market_intel.candidate_queue_review_completion_archive` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive` 在 post-closeout inventory 後整理 receipt、closeout、inventory、dedupe key、review_state row snapshot 與 artifact path manifest。此 archive gate 只輸出封存預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不更新 `review_state`、不寫 DB、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 5fc8082..3d8c87e 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,9 +19,9 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 77 candidate queue review decision post-closeout inventory 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 78 candidate queue review completion archive 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` | -| `market_intel_review_post_routes.py` | 市場情報 review_state closeout 後只讀延伸 API（掛在 `market_intel_review_bp`） | `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory` | +| `market_intel_review_post_routes.py` | 市場情報 review_state closeout 後只讀延伸 API（掛在 `market_intel_review_bp`） | `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_post_routes.py b/routes/market_intel_review_post_routes.py index a6bc568..49508d8 100644 --- a/routes/market_intel_review_post_routes.py +++ b/routes/market_intel_review_post_routes.py @@ -11,6 +11,9 @@ from routes.market_intel_review_routes import ( market_intel_review_bp, ) from services.market_intel import MarketIntelService +from services.market_intel.candidate_queue_review_completion_archive import ( + build_candidate_queue_review_completion_archive, +) from services.market_intel.candidate_queue_review_decision_post_closeout_inventory import ( build_candidate_queue_review_decision_post_closeout_inventory, ) @@ -22,18 +25,17 @@ from services.market_intel.candidate_queue_review_decision_writer_run_closeout i ) -@market_intel_review_bp.route( - "/api/market_intel/manual_sample_review/" - "candidate_queue_review_decision_post_closeout_inventory", - methods=["POST"], -) -@login_required -def market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory(): - service = MarketIntelService() - execute_requested = request.args.get("execute", "false").lower() == "true" - sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( - _extract_run_payload() - ) +def _build_post_closeout_inventory_stack( + *, + service, + sample_result, + payload_error, + operator_evidence, + writer_output, + smoke_result, + limit, + execute_requested, +): transaction, receipt = _build_review_decision_writer_receipt_stack( service=service, sample_result=sample_result, @@ -56,7 +58,7 @@ def market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inv transaction_preview=transaction, execute_requested=read_only_allowed, ) - data = build_candidate_queue_review_decision_post_closeout_inventory( + inventory = build_candidate_queue_review_decision_post_closeout_inventory( transaction_preview=transaction, run_closeout=closeout, postwrite_smoke=postwrite_smoke, @@ -66,5 +68,65 @@ def market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inv operator_evidence=operator_evidence, execute_requested=execute_requested, ) + return transaction, receipt, closeout, inventory + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_post_closeout_inventory", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction, receipt, closeout, inventory = _build_post_closeout_inventory_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + smoke_result=smoke_result, + limit=limit, + execute_requested=execute_requested, + ) + data = inventory + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_completion_archive", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_completion_archive(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction, receipt, closeout, inventory = _build_post_closeout_inventory_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + smoke_result=smoke_result, + limit=limit, + execute_requested=execute_requested, + ) + data = build_candidate_queue_review_completion_archive( + transaction_preview=transaction, + run_receipt=receipt, + run_closeout=closeout, + post_closeout_inventory=inventory, + operator_evidence=operator_evidence, + execute_requested=execute_requested, + ) data["phase"] = service.phase return jsonify(data), 400 if payload_error else 200 diff --git a/services/market_intel/candidate_queue_review_completion_archive.py b/services/market_intel/candidate_queue_review_completion_archive.py new file mode 100644 index 0000000..131536f --- /dev/null +++ b/services/market_intel/candidate_queue_review_completion_archive.py @@ -0,0 +1,394 @@ +"""候選審核 queue completion archive 預覽。 + +本模組只整理 review_state closeout / inventory 後的封存摘要； +不讀 approval token、不執行 CLI、不寫檔、不寫 DB、不更新 review_state、 +不 commit、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +TARGET_TABLE = "market_alert_review_queue" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _safe_text(value, limit=300): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _side_effects_clear(*payloads): + blocked_keys = ( + "api_executes_cli", + "api_writes_file", + "api_writes_database", + "api_updates_review_state", + "archive_file_written", + "archive_record_written", + "archive_manifest_written", + "database_write_executed", + "database_commit_executed", + "migration_executed", + "external_network_executed", + "scheduler_attached", + "review_state_update_executed", + "writes_executed", + "would_write_database", + ) + return all( + not _as_dict(payload).get(key) + for payload in payloads + for key in blocked_keys + ) + + +def _operator_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "operator_confirmed_review_completion_archive": bool( + operator_evidence.get("operator_confirmed_review_completion_archive") + or operator_evidence.get("operator_confirmed_archive_ready") + ), + "operator_confirmed_archive_is_read_only": bool( + operator_evidence.get("operator_confirmed_archive_is_read_only") + or operator_evidence.get("operator_confirmed_post_closeout_inventory_read_only") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "review_completion_archive_path": _safe_text( + operator_evidence.get("review_completion_archive_path") + or operator_evidence.get("archive_artifact_path") + ), + "post_closeout_inventory_artifact_path": _safe_text( + operator_evidence.get("post_closeout_inventory_artifact_path") + or operator_evidence.get("inventory_artifact_path") + ), + "review_state_closeout_artifact_path": _safe_text( + operator_evidence.get("review_state_closeout_artifact_path") + or operator_evidence.get("closeout_artifact_path") + ), + "review_state_receipt_artifact_path": _safe_text( + operator_evidence.get("review_state_receipt_artifact_path") + or operator_evidence.get("receipt_artifact_path") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _inventory_summary(post_closeout_inventory): + post_closeout_inventory = _as_dict(post_closeout_inventory) + return { + "provided": bool(post_closeout_inventory), + "mode": post_closeout_inventory.get("mode"), + "post_closeout_inventory_ready": bool( + post_closeout_inventory.get("post_closeout_inventory_ready") + ), + "ready_for_review_completion_archive": bool( + post_closeout_inventory.get("ready_for_review_completion_archive") + ), + "read_only_query_executed": bool( + post_closeout_inventory.get("read_only_query_executed") + ), + "database_connection_opened": bool( + post_closeout_inventory.get("database_connection_opened") + ), + "database_write_executed": bool( + post_closeout_inventory.get("database_write_executed") + ), + "database_commit_executed": bool( + post_closeout_inventory.get("database_commit_executed") + ), + "review_state_update_executed": bool( + post_closeout_inventory.get("review_state_update_executed") + ), + "scheduler_attached": bool(post_closeout_inventory.get("scheduler_attached")), + "expected_dedupe_keys": sorted( + str(key) for key in _as_list(post_closeout_inventory.get("expected_dedupe_keys")) + ), + "found_dedupe_keys": sorted( + str(key) for key in _as_list(post_closeout_inventory.get("found_dedupe_keys")) + ), + "missing_dedupe_keys": sorted( + str(key) for key in _as_list(post_closeout_inventory.get("missing_dedupe_keys")) + ), + "state_mismatches": _as_list(post_closeout_inventory.get("state_mismatches")), + "row_summaries": _as_list(post_closeout_inventory.get("row_summaries")), + "blocked_reasons": _as_list(post_closeout_inventory.get("blocked_reasons")), + } + + +def _transaction_summary(transaction_preview): + transaction_preview = _as_dict(transaction_preview) + statements = _as_list(transaction_preview.get("statements")) + return { + "mode": transaction_preview.get("mode"), + "target_table": transaction_preview.get("target_table"), + "transaction_ready": bool(transaction_preview.get("transaction_ready")), + "statement_count": len(statements), + "statement_operations": sorted( + { + _as_dict(statement).get("operation") + for statement in statements + if _as_dict(statement).get("operation") + } + ), + } + + +def _artifact_manifest(transaction_preview, run_receipt, run_closeout, inventory, operator): + rows = inventory["row_summaries"] + evidence_bundle_ids = sorted( + { + str(_as_dict(row).get("evidence_bundle_id")) + for row in rows + if _as_dict(row).get("evidence_bundle_id") + } + ) + return { + "target_table": TARGET_TABLE, + "transaction": _transaction_summary(transaction_preview), + "receipt": { + "mode": _as_dict(run_receipt).get("mode"), + "receipt_passed": bool(_as_dict(run_receipt).get("receipt_passed")), + "expected_dedupe_key_count": len(_as_list(_as_dict(run_receipt).get("expected_dedupe_keys"))), + }, + "closeout": { + "mode": _as_dict(run_closeout).get("mode"), + "closeout_passed": bool(_as_dict(run_closeout).get("closeout_passed")), + "ready_for_review_inventory": bool( + _as_dict(run_closeout).get("ready_for_review_inventory") + ), + }, + "inventory": { + "mode": inventory["mode"], + "post_closeout_inventory_ready": inventory[ + "post_closeout_inventory_ready" + ], + "expected_dedupe_key_count": len(inventory["expected_dedupe_keys"]), + "found_dedupe_key_count": len(inventory["found_dedupe_keys"]), + "missing_dedupe_key_count": len(inventory["missing_dedupe_keys"]), + "row_summary_count": len(rows), + "state_mismatch_count": len(inventory["state_mismatches"]), + "evidence_bundle_ids": evidence_bundle_ids, + }, + "artifact_paths": { + "review_state_receipt_artifact_path": operator[ + "review_state_receipt_artifact_path" + ], + "review_state_closeout_artifact_path": operator[ + "review_state_closeout_artifact_path" + ], + "post_closeout_inventory_artifact_path": operator[ + "post_closeout_inventory_artifact_path" + ], + "review_completion_archive_path": operator[ + "review_completion_archive_path" + ], + }, + } + + +def _archive_gates(*, inventory, operator, manifest): + expected_keys = inventory["expected_dedupe_keys"] + found_keys = inventory["found_dedupe_keys"] + missing_keys = inventory["missing_dedupe_keys"] + state_mismatches = inventory["state_mismatches"] + rows = inventory["row_summaries"] + artifact_paths = manifest["artifact_paths"] + return [ + { + "key": "post_closeout_inventory_preview_provided", + "label": "必須提供 post-closeout inventory preview", + "passed": bool( + inventory["provided"] + and inventory["mode"] + == "candidate_queue_review_decision_post_closeout_inventory_preview" + ), + }, + { + "key": "post_closeout_inventory_ready", + "label": "post-closeout inventory 必須已通過", + "passed": bool( + inventory["post_closeout_inventory_ready"] + and inventory["ready_for_review_completion_archive"] + ), + }, + { + "key": "archive_dedupe_keys_complete", + "label": "expected / found dedupe key 必須一致且不可缺漏", + "passed": bool(expected_keys and expected_keys == found_keys and not missing_keys), + }, + { + "key": "archive_review_state_rows_present", + "label": "封存摘要必須包含 review_state row snapshot", + "passed": bool(rows), + }, + { + "key": "archive_review_state_mismatches_absent", + "label": "封存前不可存在 review_state mismatch", + "passed": not state_mismatches, + }, + { + "key": "operator_confirmed_review_completion_archive", + "label": "操作員確認本批 review 已可封存", + "passed": bool( + operator["operator_confirmed_review_completion_archive"] + and operator["operator_confirmed_archive_is_read_only"] + and operator["operator_confirmed_no_api_db_write"] + and operator["operator_confirmed_no_scheduler_attach"] + ), + }, + { + "key": "archive_artifact_paths_recorded", + "label": "receipt、closeout、inventory 與 archive artifact path 必須齊備", + "passed": all(artifact_paths.values()), + }, + { + "key": "archive_no_approval_token_submitted_to_api", + "label": "payload 不得包含一次性 approval token key", + "passed": not operator["approval_token_submitted_to_api"], + }, + { + "key": "archive_preview_has_no_side_effects", + "label": "archive gate 不得寫檔、寫 DB、更新 review_state 或掛 scheduler", + "passed": _side_effects_clear(inventory), + }, + ] + + +def build_candidate_queue_review_completion_archive( + *, + transaction_preview, + run_receipt, + run_closeout, + post_closeout_inventory, + operator_evidence=None, + execute_requested=False, +): + """建立 review completion archive 預覽；不執行任何副作用。""" + inventory = _inventory_summary(post_closeout_inventory) + operator = _operator_summary(operator_evidence) + manifest = _artifact_manifest( + transaction_preview, + run_receipt, + run_closeout, + inventory, + operator, + ) + gates = _archive_gates( + inventory=inventory, + operator=operator, + manifest=manifest, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + archive_ready = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_completion_archive_preview", + "target_table": TARGET_TABLE, + "target_operation": "archive_review_completion_evidence", + "execute_requested": bool(execute_requested), + "review_completion_archive_ready": archive_ready, + "archive_manifest_ready": archive_ready, + "ready_for_next_manual_phase": archive_ready, + "ready_for_ai_summary_review": archive_ready, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "approval_record_written": False, + "decision_record_written": False, + "archive_file_written": False, + "archive_record_written": False, + "archive_manifest_written": False, + "review_state_update_executed": False, + "read_only_query_executed": inventory["read_only_query_executed"], + "database_connection_opened": inventory["database_connection_opened"], + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "expected_dedupe_keys": inventory["expected_dedupe_keys"], + "found_dedupe_keys": inventory["found_dedupe_keys"], + "missing_dedupe_keys": inventory["missing_dedupe_keys"], + "state_mismatches": inventory["state_mismatches"], + "row_summary_count": len(inventory["row_summaries"]), + "archive_manifest": manifest, + "operator_archive_summary": operator, + "blocked_reasons": blocked_reasons, + "gates": gates, + "next_operator_steps": [ + "保存 review_state receipt、closeout、post-closeout inventory artifact", + "確認 archive manifest 只含摘要與 artifact path，不含 approval token", + "將本批 dedupe key 與 review_state 結果納入人工封存紀錄", + "若封存 gate 未通過，回到 post-closeout inventory 或 receipt 修正", + ], + "safe_boundaries": [ + "do_not_write_archive_file_from_api", + "do_not_insert_archive_record_from_api", + "do_not_update_review_state_from_archive_gate", + "do_not_read_approval_token_from_archive_gate", + "do_not_execute_cli_from_archive_gate", + "do_not_attach_scheduler_from_archive_gate", + "review_completion_archive_preview_only", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index e63497c..7e5b273 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -25,10 +25,11 @@ from services.market_intel.candidate_queue_review_decision_writer_run_readiness from services.market_intel.candidate_queue_review_decision_writer_run_receipt import build_candidate_queue_review_decision_writer_run_receipt from services.market_intel.candidate_queue_review_decision_writer_run_closeout import build_candidate_queue_review_decision_writer_run_closeout from services.market_intel.candidate_queue_review_decision_post_closeout_inventory import build_candidate_queue_review_decision_post_closeout_inventory +from services.market_intel.candidate_queue_review_completion_archive import build_candidate_queue_review_completion_archive BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database") -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_completion_archive", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -167,6 +168,12 @@ def build_deployment_readiness_preview( postwrite_smoke=candidate_queue_review_decision_writer_postwrite_smoke, live_db_inventory=live_db_inventory, ) + candidate_queue_review_completion_archive = build_candidate_queue_review_completion_archive( + transaction_preview=candidate_queue_review_decision_transaction, + run_receipt=candidate_queue_review_decision_writer_run_receipt, + run_closeout=candidate_queue_review_decision_writer_run_closeout, + post_closeout_inventory=candidate_queue_review_decision_post_closeout_inventory, + ) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -437,6 +444,10 @@ def build_deployment_readiness_preview( candidate_queue_review_decision_post_closeout_inventory, "candidate_queue_review_decision_post_closeout_inventory_preview", ), + "candidate_queue_review_completion_archive_preview_safe": _run_review_preview_safe( + candidate_queue_review_completion_archive, + "candidate_queue_review_completion_archive_preview", + ), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -681,6 +692,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_decision_writer_run_receipt": candidate_queue_review_decision_writer_run_receipt, "candidate_queue_review_decision_writer_run_closeout": candidate_queue_review_decision_writer_run_closeout, "candidate_queue_review_decision_post_closeout_inventory": candidate_queue_review_decision_post_closeout_inventory, + "candidate_queue_review_completion_archive": candidate_queue_review_completion_archive, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index bbf3197..f6a627c 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_77_candidate_queue_review_decision_post_closeout_inventory" +MARKET_INTEL_PHASE = "phase_78_candidate_queue_review_completion_archive" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 3465396..68845c8 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -670,6 +670,9 @@ + @@ -1021,6 +1024,7 @@ const sampleCandidateQueueReviewDecisionRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-receipt]') : null; const sampleCandidateQueueReviewDecisionRunCloseout = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-closeout]') : null; const sampleCandidateQueueReviewDecisionPostCloseoutInventory = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-post-closeout-inventory]') : null; + const sampleCandidateQueueReviewCompletionArchive = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-completion-archive]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1049,6 +1053,7 @@ const sampleCandidateQueueReviewDecisionRunReceiptEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt') }}"; const sampleCandidateQueueReviewDecisionRunCloseoutEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeout') }}"; const sampleCandidateQueueReviewDecisionPostCloseoutInventoryEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory') }}"; + const sampleCandidateQueueReviewCompletionArchiveEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_completion_archive') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -4521,6 +4526,103 @@ } }; + const renderCandidateQueueReviewCompletionArchive = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const manifest = data.archive_manifest || {}; + const inventory = manifest.inventory || {}; + const artifactPaths = manifest.artifact_paths || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `archive=${data.review_completion_archive_ready ? 'pass' : 'blocked'}`, + `manifest=${data.archive_manifest_ready ? 'ready' : 'draft'}`, + `rows=${data.row_summary_count || 0}`, + `api_write=${data.ready_for_api_database_write ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只整理 review completion archive manifest；API/UI 不寫檔、不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

ARCHIVE GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 archive gate。
' + }
+
+
+

MANIFEST

+
+ ${[ + ['expected_keys', inventory.expected_dedupe_key_count || 0], + ['found_keys', inventory.found_dedupe_key_count || 0], + ['missing_keys', inventory.missing_dedupe_key_count || 0], + ['row_snapshot', inventory.row_summary_count || 0], + ['state_mismatch', inventory.state_mismatch_count || 0], + ['archive_file_written', data.archive_file_written] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

ARTIFACT PATHS

+
+ ${Object.entries(artifactPaths).map(([key, value]) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(value || 'missing')} +
+ ${value ? 'SET' : 'MISS'} +
+ `).join('') || '
尚未提供 artifact path。
'} +
+
+
+ `; + }; + + const loadCandidateQueueReviewCompletionArchive = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
整理 queue review completion archive 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewCompletionArchiveEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewCompletionArchive(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review completion archive 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -6206,6 +6308,9 @@ if (sampleCandidateQueueReviewDecisionPostCloseoutInventory) { sampleCandidateQueueReviewDecisionPostCloseoutInventory.addEventListener('click', loadCandidateQueueReviewDecisionPostCloseoutInventory); } + if (sampleCandidateQueueReviewCompletionArchive) { + sampleCandidateQueueReviewCompletionArchive.addEventListener('click', loadCandidateQueueReviewCompletionArchive); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 33af234..b76b047 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -1031,6 +1031,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_completion_archive" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -1067,6 +1071,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-decision-post-closeout-inventory" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-completion-archive" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -1103,7 +1111,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert bridge["phase"] == "phase_78_candidate_queue_review_completion_archive" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1261,7 +1269,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert contract["phase"] == "phase_78_candidate_queue_review_completion_archive" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1394,7 +1402,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1407,7 +1415,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert gate["phase"] == "phase_78_candidate_queue_review_completion_archive" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1477,7 +1485,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1489,7 +1497,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1537,7 +1545,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1548,7 +1556,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert acceptance["phase"] == "phase_78_candidate_queue_review_completion_archive" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1590,7 +1598,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1602,7 +1610,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert review["phase"] == "phase_78_candidate_queue_review_completion_archive" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1713,7 +1721,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1752,7 +1760,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert review["phase"] == "phase_78_candidate_queue_review_completion_archive" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1814,7 +1822,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1894,7 +1902,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert handoff["phase"] == "phase_78_candidate_queue_review_completion_archive" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1958,7 +1966,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -2017,7 +2025,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert queue_draft["phase"] == "phase_78_candidate_queue_review_completion_archive" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2091,7 +2099,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -2154,7 +2162,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert approval["phase"] == "phase_78_candidate_queue_review_completion_archive" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2232,7 +2240,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2295,7 +2303,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert transaction["phase"] == "phase_78_candidate_queue_review_completion_archive" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2375,7 +2383,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -4983,6 +4991,136 @@ def test_candidate_queue_review_decision_post_closeout_inventory_is_read_only(): ) +def test_candidate_queue_review_completion_archive_is_preview_only(): + from services.market_intel.candidate_queue_review_completion_archive import ( + build_candidate_queue_review_completion_archive, + ) + from services.market_intel.candidate_queue_review_decision_post_closeout_inventory import ( + build_candidate_queue_review_decision_post_closeout_inventory, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_closeout import ( + build_candidate_queue_review_decision_writer_run_closeout, + ) + + fixture = _build_review_decision_writer_receipt_fixture( + "sample-batch-review-completion-archive" + ) + archive_evidence = { + **fixture["operator_evidence"], + "review_state_receipt_artifact_path": ( + "artifacts/market_intel/review-state-receipt.json" + ), + "review_state_closeout_artifact_path": ( + "artifacts/market_intel/review-state-closeout.json" + ), + "post_closeout_inventory_artifact_path": ( + "artifacts/market_intel/post-closeout-inventory.json" + ), + "review_completion_archive_path": ( + "artifacts/market_intel/review-completion-archive.json" + ), + "operator_confirmed_review_state_closeout_next": True, + "operator_confirmed_post_closeout_inventory_read_only": True, + "operator_confirmed_review_completion_archive": True, + "operator_confirmed_archive_is_read_only": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + } + closeout = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=fixture["receipt"], + operator_evidence=archive_evidence, + ) + live_inventory = { + "mode": "live_db_inventory_loaded", + "summary_ready": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "migration_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "total_rows": 1, + "table_statuses": [ + { + "table": "market_alert_review_queue", + "exists": True, + "row_count": 1, + "status": "loaded", + } + ], + } + inventory = build_candidate_queue_review_decision_post_closeout_inventory( + transaction_preview=fixture["transaction"], + run_closeout=closeout, + postwrite_smoke=fixture["postwrite_smoke_result"], + live_db_inventory=live_inventory, + operator_evidence=archive_evidence, + execute_requested=True, + ) + archive = build_candidate_queue_review_completion_archive( + transaction_preview=fixture["transaction"], + run_receipt=fixture["receipt"], + run_closeout=closeout, + post_closeout_inventory=inventory, + operator_evidence=archive_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_completion_archive( + transaction_preview=fixture["transaction"], + run_receipt=fixture["receipt"], + run_closeout=closeout, + post_closeout_inventory=inventory, + operator_evidence={ + **archive_evidence, + "approval_token": TEST_APPROVAL_TOKEN, + }, + execute_requested=True, + ) + + assert archive["mode"] == "candidate_queue_review_completion_archive_preview" + assert archive["target_operation"] == "archive_review_completion_evidence" + assert archive["review_completion_archive_ready"] is True + assert archive["archive_manifest_ready"] is True + assert archive["ready_for_api_review_state_update"] is False + assert archive["ready_for_api_database_write"] is False + assert archive["ready_for_scheduler_attach"] is False + assert archive["api_writes_file"] is False + assert archive["api_executes_cli"] is False + assert archive["api_reads_approval_token"] is False + assert archive["api_writes_database"] is False + assert archive["api_updates_review_state"] is False + assert archive["archive_file_written"] is False + assert archive["archive_record_written"] is False + assert archive["archive_manifest_written"] is False + assert archive["review_state_update_executed"] is False + assert archive["database_write_executed"] is False + assert archive["database_commit_executed"] is False + assert archive["scheduler_attached"] is False + assert archive["expected_dedupe_keys"] == fixture["receipt"][ + "expected_dedupe_keys" + ] + assert archive["found_dedupe_keys"] == fixture["receipt"][ + "expected_dedupe_keys" + ] + assert archive["row_summary_count"] == 1 + assert archive["blocked_reasons"] == [] + assert "review_completion_archive_preview_only" in archive["safe_boundaries"] + assert token_leak["review_completion_archive_ready"] is False + assert token_leak["operator_archive_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "archive_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -5025,7 +5163,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -5082,7 +5220,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -5171,7 +5309,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -5225,7 +5363,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -5281,7 +5419,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -5347,7 +5485,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -5649,7 +5787,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -5697,7 +5835,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -5746,7 +5884,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -5804,7 +5942,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -5870,7 +6008,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -5941,7 +6079,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -6017,7 +6155,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -6099,7 +6237,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -6185,7 +6323,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -6268,7 +6406,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6351,7 +6489,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -6437,7 +6575,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -6528,7 +6666,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_77_candidate_queue_review_decision_post_closeout_inventory" + "phase_78_candidate_queue_review_completion_archive" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -6638,7 +6776,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_77_candidate_queue_review_decision_post_closeout_inventory" + "phase_78_candidate_queue_review_completion_archive" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -6724,7 +6862,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_77_candidate_queue_review_decision_post_closeout_inventory" + "phase_78_candidate_queue_review_completion_archive" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -6781,7 +6919,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_77_candidate_queue_review_decision_post_closeout_inventory" + "phase_78_candidate_queue_review_completion_archive" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -6806,6 +6944,59 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_completion_archive" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_completion_archive" + "?execute=true&apply_real_write=true", + json={"sample_result": {}}, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_review_completion_archive_preview" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" + assert data["review_completion_archive_ready"] is False + assert data["archive_manifest_ready"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_writes_file"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["archive_file_written"] is False + assert data["archive_record_written"] is False + assert data["archive_manifest_written"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["read_only_query_executed"] is False + assert data["scheduler_attached"] is False + assert data["expected_dedupe_keys"] == [] + assert "post_closeout_inventory_ready" in data["blocked_reasons"] + assert "do_not_write_archive_file_from_api" in data["safe_boundaries"] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6834,7 +7025,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -6859,7 +7050,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -6897,7 +7088,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -6908,7 +7099,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -6944,7 +7135,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -6955,7 +7146,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -6996,7 +7187,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -7007,7 +7198,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -7055,7 +7246,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -7067,7 +7258,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -7113,7 +7304,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -7126,7 +7317,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert plan["phase"] == "phase_78_candidate_queue_review_completion_archive" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -7211,7 +7402,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -7289,7 +7480,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -7304,7 +7495,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert readiness["phase"] == "phase_78_candidate_queue_review_completion_archive" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -7798,6 +7989,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_completion_archive_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -7932,6 +8129,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_decision_post_closeout_inventory" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_completion_archive" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -9147,6 +9349,86 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_completion_archive"]["mode"] + == "candidate_queue_review_completion_archive_preview" + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "review_completion_archive_ready" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "archive_manifest_ready" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "ready_for_api_review_state_update" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"]["api_executes_cli"] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "api_reads_approval_token" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "api_updates_review_state" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "archive_file_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "archive_record_written" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "review_state_update_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "read_only_query_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_completion_archive"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -9297,7 +9579,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert drill["phase"] == "phase_78_candidate_queue_review_completion_archive" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -9412,7 +9694,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -9424,7 +9706,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert review["phase"] == "phase_78_candidate_queue_review_completion_archive" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -9539,7 +9821,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -9552,7 +9834,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert smoke["phase"] == "phase_78_candidate_queue_review_completion_archive" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -9614,7 +9896,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -9627,7 +9909,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert inventory["phase"] == "phase_78_candidate_queue_review_completion_archive" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -9771,7 +10053,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -9998,7 +10280,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -10027,7 +10309,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" + assert data["phase"] == "phase_78_candidate_queue_review_completion_archive" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False