diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 2161c8e..3933d15 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -128,6 +128,7 @@ - V10.238 補業績圖表 runtime QA 與分析 tabs 窄版修正：新增 `quick_review --sales-charts` 檢查 `/daily_sales`、`/growth_analysis` 的 Chart.js ready、可繪製資料集與 canvas 非空白；同時把分析報表 tabs 手機版改為自適應 grid，避免 Metabase/Grist 外部連結超出右側。 - Phase 60 candidate queue writer run package：新增 `services/market_intel/candidate_queue_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package` 與 UI run package 按鈕，整理正式 CLI 小流量寫入前的 payload manifest、required artifacts、command bundle、operator signoff 與 rollback plan；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.240。 - Phase 61 candidate queue writer run readiness：新增 `services/market_intel/candidate_queue_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness` 與 UI readiness 按鈕，檢查 reviewed sample 檔案路徑、備份路徑、preflight 輸出、migration live smoke、shell-only token acknowledgement 與禁止 token 進 API；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.245。 + - Phase 62 candidate queue writer run receipt：新增 `services/market_intel/candidate_queue_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt` 與 UI receipt 按鈕，審核 CLI 寫入後的 writer output、post-write smoke、dedupe key 一致性與 artifact 路徑；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler；版本同步至 V10.247。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 - Desktop UI QA：本機只註冊 `market_intel_bp` 的 Flask harness 載入 `/market_intel`，確認 Phase 15、候選預覽、writer preview、安全 flags、點陣暖紙視覺正常，console error 0。 - API QA：`/api/market_intel/schema_smoke` 通過 7 張表與 `market_platforms` 必要欄位檢查；`/api/market_intel/platform_seed_writer_plan` 回傳 4 筆 dry-run upsert preview，`writes_executed=false`，四平台皆 `blocked_dry_run_only`。 @@ -138,7 +139,7 @@ - 補 UI preview panel 真 390px 截圖 QA；本輪 in-app browser 不支援直接設定 viewport，且 data URL iframe QA 被瀏覽器安全策略阻擋，不做繞過。 - 正式端 seed writer token-hardening drift：優先白名單同步 main 的一次性環境 token 版本，避免 API 暴露固定 approval token hint。 - 正式推版前需實際執行 worktree scope review、`python backup_system.py`、commit/push 目標變更、讀 deployment SOP 與 ADR-011，且只跑 `/health` 與市場情報頁 smoke。 - - 下一步才可在明確批准且具備真實 reviewed sample JSON 後做正式 DB 的 queue writer CLI 小流量 operator run；先用 run readiness、run package、operator drill 與 post-write smoke 做順序與只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 + - 下一步才可在明確批准且具備真實 reviewed sample JSON 後做正式 DB 的 queue writer CLI 小流量 operator run；先用 run readiness、run package、operator drill、post-write smoke 與 run receipt 做順序與只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 - 市場情報 UI 後續頁面必須沿用 V2 暖紙、暖墨、等寬數字與點陣風格，禁止複製巨型分析頁 template 模式。 ================================================================================ diff --git a/config.py b/config.py index 53823f1..9a68fae 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.246" +SYSTEM_VERSION = "V10.247" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index e5a4609..2275419 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -187,6 +187,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue writer operator drill：`services.market_intel.candidate_queue_writer_operator_drill` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill` 組裝 reviewed sample、備份、read-only preflight、CLI writer、post-write smoke 的操作員順序與 gate。此 drill 只輸出可稽核操作計畫；API/UI 不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer run package：`services.market_intel.candidate_queue_writer_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package` 整理正式 CLI 小流量寫入前的 payload manifest、required artifacts、command bundle、operator signoff 與 rollback plan。此 package 只輸出可稽核證據包預覽；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer run readiness：`services.market_intel.candidate_queue_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness` 檢查正式 CLI 小流量寫入前的 reviewed sample 路徑、備份路徑、preflight 輸出、migration live smoke、shell-only token acknowledgement 與禁止 token 進 API。此 readiness 只輸出操作員證據缺口；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue writer run receipt：`services.market_intel.candidate_queue_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt` 審核 CLI 小流量寫入後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 131fdd9..a3105ff 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,7 +19,7 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 61 candidate queue writer run readiness | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 62 candidate queue writer run receipt | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index dd83abe..4707e76 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -27,6 +27,9 @@ from services.market_intel.candidate_queue_writer_run_package import ( from services.market_intel.candidate_queue_writer_run_readiness import ( build_candidate_queue_writer_run_readiness, ) +from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, +) TAIPEI_TZ = timezone(timedelta(hours=8)) @@ -412,123 +415,14 @@ def market_intel_manual_sample_candidate_queue_writer_postwrite_smoke(): return jsonify(data), status_code -@market_intel_bp.route( - "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", - methods=["POST"], -) -@login_required -def market_intel_manual_sample_candidate_queue_writer_operator_drill(): - payload = request.get_json(silent=True) - limit = request.args.get("limit", default=20, type=int) - service = _service() - payload_error = None - if not isinstance(payload, dict): - sample_result = None - payload_error = "invalid_json_object" - else: - sample_result = payload.get("sample_result", payload) - - transaction_preview = service.build_manual_sample_candidate_queue_transaction( - sample_result=sample_result, - payload_error=payload_error, - limit=limit, - ) - writer_preflight = build_candidate_queue_writer_preflight( - transaction_preview=transaction_preview, - execute_requested=False, - ) - writer_status = build_candidate_queue_writer_cli_plan( - transaction_preview=transaction_preview, - writer_preflight=writer_preflight, - approval_token=None, - approval_token_secret=None, - ) - postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( - transaction_preview=transaction_preview, - execute_requested=False, - ) - data = build_candidate_queue_writer_operator_drill( - transaction_preview=transaction_preview, - writer_preflight=writer_preflight, - writer_status=writer_status, - postwrite_smoke=postwrite_smoke, - ) - data["phase"] = service.phase - status_code = 400 if payload_error else 200 - return jsonify(data), status_code - - -@market_intel_bp.route( - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", - methods=["POST"], -) -@login_required -def market_intel_manual_sample_candidate_queue_writer_run_package(): - payload = request.get_json(silent=True) - limit = request.args.get("limit", default=20, type=int) - service = _service() - payload_error = None - if not isinstance(payload, dict): - sample_result = None - payload_error = "invalid_json_object" - else: - sample_result = payload.get("sample_result", payload) - - transaction_preview = service.build_manual_sample_candidate_queue_transaction( - sample_result=sample_result, - payload_error=payload_error, - limit=limit, - ) - writer_preflight = build_candidate_queue_writer_preflight( - transaction_preview=transaction_preview, - execute_requested=False, - ) - writer_status = build_candidate_queue_writer_cli_plan( - transaction_preview=transaction_preview, - writer_preflight=writer_preflight, - approval_token=None, - approval_token_secret=None, - ) - postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( - transaction_preview=transaction_preview, - execute_requested=False, - ) - operator_drill = build_candidate_queue_writer_operator_drill( - transaction_preview=transaction_preview, - writer_preflight=writer_preflight, - writer_status=writer_status, - postwrite_smoke=postwrite_smoke, - ) - data = build_candidate_queue_writer_run_package( - transaction_preview=transaction_preview, - writer_preflight=writer_preflight, - writer_status=writer_status, - postwrite_smoke=postwrite_smoke, - operator_drill=operator_drill, - ) - data["phase"] = service.phase - status_code = 400 if payload_error else 200 - return jsonify(data), status_code - - -@market_intel_bp.route( - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", - methods=["POST"], -) -@login_required -def market_intel_manual_sample_candidate_queue_writer_run_readiness(): - payload = request.get_json(silent=True) - limit = request.args.get("limit", default=20, type=int) - service = _service() - payload_error = None - operator_evidence = {} - if not isinstance(payload, dict): - sample_result = None - payload_error = "invalid_json_object" - else: - sample_result = payload.get("sample_result", payload) - operator_evidence = payload.get("operator_evidence", {}) - +def _build_candidate_queue_writer_stack( + *, + service, + sample_result, + payload_error, + limit, + operator_evidence=None, +): transaction_preview = service.build_manual_sample_candidate_queue_transaction( sample_result=sample_result, payload_error=payload_error, @@ -561,13 +455,147 @@ def market_intel_manual_sample_candidate_queue_writer_run_readiness(): postwrite_smoke=postwrite_smoke, operator_drill=operator_drill, ) - data = build_candidate_queue_writer_run_readiness( + run_readiness = build_candidate_queue_writer_run_readiness( transaction_preview=transaction_preview, writer_preflight=writer_preflight, writer_status=writer_status, postwrite_smoke=postwrite_smoke, operator_drill=operator_drill, run_package=run_package, + operator_evidence=operator_evidence or {}, + ) + return { + "transaction_preview": transaction_preview, + "writer_preflight": writer_preflight, + "writer_status": writer_status, + "postwrite_smoke": postwrite_smoke, + "operator_drill": operator_drill, + "run_package": run_package, + "run_readiness": run_readiness, + } + + +@market_intel_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_writer_operator_drill(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + service = _service() + payload_error = None + if not isinstance(payload, dict): + sample_result = None + payload_error = "invalid_json_object" + else: + sample_result = payload.get("sample_result", payload) + + stack = _build_candidate_queue_writer_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + ) + data = stack["operator_drill"] + data["phase"] = service.phase + status_code = 400 if payload_error else 200 + return jsonify(data), status_code + + +@market_intel_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_writer_run_package(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + service = _service() + payload_error = None + if not isinstance(payload, dict): + sample_result = None + payload_error = "invalid_json_object" + else: + sample_result = payload.get("sample_result", payload) + + stack = _build_candidate_queue_writer_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + ) + data = stack["run_package"] + data["phase"] = service.phase + status_code = 400 if payload_error else 200 + return jsonify(data), status_code + + +@market_intel_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_writer_run_readiness(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + service = _service() + payload_error = None + operator_evidence = {} + if not isinstance(payload, dict): + sample_result = None + payload_error = "invalid_json_object" + else: + sample_result = payload.get("sample_result", payload) + operator_evidence = payload.get("operator_evidence", {}) + + stack = _build_candidate_queue_writer_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + operator_evidence=operator_evidence, + ) + data = stack["run_readiness"] + data["phase"] = service.phase + status_code = 400 if payload_error else 200 + return jsonify(data), status_code + + +@market_intel_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_writer_run_receipt(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + service = _service() + payload_error = None + operator_evidence = {} + writer_output = {} + postwrite_smoke_result = {} + if not isinstance(payload, dict): + sample_result = None + payload_error = "invalid_json_object" + else: + sample_result = payload.get("sample_result", payload) + operator_evidence = payload.get("operator_evidence", {}) + writer_output = payload.get("writer_output", {}) + postwrite_smoke_result = payload.get("postwrite_smoke_result", {}) + + stack = _build_candidate_queue_writer_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + operator_evidence=operator_evidence, + ) + data = build_candidate_queue_writer_run_receipt( + transaction_preview=stack["transaction_preview"], + run_readiness=stack["run_readiness"], + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, operator_evidence=operator_evidence, ) data["phase"] = service.phase diff --git a/services/market_intel/candidate_queue_writer_run_receipt.py b/services/market_intel/candidate_queue_writer_run_receipt.py new file mode 100644 index 0000000..471f63e --- /dev/null +++ b/services/market_intel/candidate_queue_writer_run_receipt.py @@ -0,0 +1,378 @@ +"""候選審核 queue writer operator run receipt review preview。 + +本模組只審核 CLI 小流量寫入後由操作員貼回的 writer output 與 +post-write smoke 結果；不讀 approval token、不執行 CLI、不開 DB +connection、不寫 queue、不 commit、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _dedupe_keys_from_transaction(transaction_preview): + transaction_preview = _as_dict(transaction_preview) + keys = [] + for statement in transaction_preview.get("statements") or []: + lookup = _as_dict(statement.get("lookup")) + parameter_preview = _as_dict(statement.get("parameter_preview")) + dedupe_key = lookup.get("dedupe_key") or parameter_preview.get("dedupe_key") + if dedupe_key: + keys.append(str(dedupe_key)) + return sorted(set(keys)) + + +def _keys_from_writer_output(writer_output): + execution_result = _as_dict(writer_output.get("execution_result")) + affected = ( + writer_output.get("affected_dedupe_keys") + or execution_result.get("affected_dedupe_keys") + or [] + ) + skipped = ( + writer_output.get("skipped_dedupe_keys") + or execution_result.get("skipped_dedupe_keys") + or [] + ) + return { + "affected": sorted(set(str(key) for key in _as_list(affected) if key)), + "skipped": sorted(set(str(key) for key in _as_list(skipped) if key)), + } + + +def _keys_match_expected(expected_keys, observed_keys): + if not expected_keys: + return False + return set(expected_keys).issubset(set(observed_keys)) + + +def _operator_evidence_summary(operator_evidence): + return { + "provided_keys": sorted(operator_evidence.keys()), + "writer_output_json_path_recorded": _has_text( + operator_evidence.get("writer_output_json_path") + ), + "postwrite_smoke_json_path_recorded": _has_text( + operator_evidence.get("postwrite_smoke_json_path") + ), + "operator_confirmed_no_token_in_artifacts": bool( + operator_evidence.get("operator_confirmed_no_token_in_artifacts") + ), + "receipt_notes_recorded": _has_text(operator_evidence.get("receipt_notes")), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _writer_summary(writer_output, expected_keys): + writer_output = _as_dict(writer_output) + writer_keys = _keys_from_writer_output(writer_output) + observed_keys = sorted(set(writer_keys["affected"] + writer_keys["skipped"])) + return { + "provided": bool(writer_output), + "mode": writer_output.get("mode"), + "exit_code": writer_output.get("exit_code"), + "writes_executed": bool(writer_output.get("writes_executed")), + "would_write_database": bool(writer_output.get("would_write_database")), + "database_connection_opened": bool( + writer_output.get("database_connection_opened") + ), + "explicit_transaction_opened": bool( + writer_output.get("explicit_transaction_opened") + ), + "database_write_executed": bool(writer_output.get("database_write_executed")), + "database_commit_executed": bool(writer_output.get("database_commit_executed")), + "database_rollback_executed": bool( + writer_output.get("database_rollback_executed") + ), + "external_network_executed": bool(writer_output.get("external_network_executed")), + "scheduler_attached": bool(writer_output.get("scheduler_attached")), + "inserted_count": _safe_int(writer_output.get("inserted_count")), + "skipped_count": _safe_int(writer_output.get("skipped_count")), + "affected_dedupe_keys": writer_keys["affected"], + "skipped_dedupe_keys": writer_keys["skipped"], + "observed_dedupe_keys": observed_keys, + "dedupe_keys_match_expected": _keys_match_expected(expected_keys, observed_keys), + "approval_token_key_detected": _contains_forbidden_token_key(writer_output), + } + + +def _smoke_summary(postwrite_smoke_result, expected_keys): + postwrite_smoke_result = _as_dict(postwrite_smoke_result) + found_keys = sorted( + set( + str(key) + for key in _as_list(postwrite_smoke_result.get("found_dedupe_keys")) + if key + ) + ) + missing_keys = sorted( + set( + str(key) + for key in _as_list(postwrite_smoke_result.get("missing_dedupe_keys")) + if key + ) + ) + return { + "provided": bool(postwrite_smoke_result), + "mode": postwrite_smoke_result.get("mode"), + "postwrite_smoke_passed": bool( + postwrite_smoke_result.get("postwrite_smoke_passed") + ), + "ready_for_operator_review": bool( + postwrite_smoke_result.get("ready_for_operator_review") + ), + "read_only_query_executed": bool( + postwrite_smoke_result.get("read_only_query_executed") + ), + "database_connection_opened": bool( + postwrite_smoke_result.get("database_connection_opened") + ), + "database_write_executed": bool( + postwrite_smoke_result.get("database_write_executed") + ), + "database_commit_executed": bool( + postwrite_smoke_result.get("database_commit_executed") + ), + "external_network_executed": bool( + postwrite_smoke_result.get("external_network_executed") + ), + "scheduler_attached": bool(postwrite_smoke_result.get("scheduler_attached")), + "expected_dedupe_key_count": _safe_int( + postwrite_smoke_result.get("expected_dedupe_key_count") + ), + "found_count": _safe_int(postwrite_smoke_result.get("found_count")), + "missing_count": _safe_int(postwrite_smoke_result.get("missing_count")), + "found_dedupe_keys": found_keys, + "missing_dedupe_keys": missing_keys, + "dedupe_keys_match_expected": _keys_match_expected(expected_keys, found_keys) + and not missing_keys, + "approval_token_key_detected": _contains_forbidden_token_key( + postwrite_smoke_result + ), + } + + +def _receipt_gates( + *, + expected_keys, + run_readiness, + writer_summary, + smoke_summary, + evidence_summary, +): + return [ + { + "key": "run_readiness_passed_before_cli", + "label": "CLI 寫入前 run readiness 必須已通過", + "passed": bool(run_readiness.get("ready_for_cli_operator_run")), + }, + { + "key": "expected_dedupe_keys_present", + "label": "transaction preview 必須有 dedupe key", + "passed": bool(expected_keys), + }, + { + "key": "writer_output_provided", + "label": "操作員需貼回 CLI writer output", + "passed": writer_summary["provided"], + }, + { + "key": "writer_output_executed_and_committed", + "label": "writer output 必須顯示 CLI 已寫入並 commit", + "passed": bool( + writer_summary["mode"] == "candidate_queue_writer_cli_executed" + and writer_summary["writes_executed"] + and writer_summary["database_write_executed"] + and writer_summary["database_commit_executed"] + ), + }, + { + "key": "writer_output_dedupe_keys_match_expected", + "label": "writer output 的 affected/skipped dedupe key 必須符合 transaction preview", + "passed": writer_summary["dedupe_keys_match_expected"], + }, + { + "key": "writer_output_safe_runtime_boundaries", + "label": "writer output 不得顯示 scheduler、外部網路或 rollback error", + "passed": bool( + not writer_summary["scheduler_attached"] + and not writer_summary["external_network_executed"] + and not writer_summary["database_rollback_executed"] + ), + }, + { + "key": "writer_output_no_approval_token_key", + "label": "writer output 不得包含 approval token key", + "passed": not writer_summary["approval_token_key_detected"], + }, + { + "key": "postwrite_smoke_result_provided", + "label": "操作員需貼回 post-write smoke 結果", + "passed": smoke_summary["provided"], + }, + { + "key": "postwrite_smoke_read_only_passed", + "label": "post-write smoke 必須是只讀查詢且通過", + "passed": bool( + smoke_summary["mode"] == "candidate_queue_writer_postwrite_smoke_read_only" + and smoke_summary["read_only_query_executed"] + and smoke_summary["postwrite_smoke_passed"] + ), + }, + { + "key": "postwrite_smoke_no_database_write", + "label": "post-write smoke 不得寫 DB 或 commit", + "passed": bool( + not smoke_summary["database_write_executed"] + and not smoke_summary["database_commit_executed"] + ), + }, + { + "key": "postwrite_smoke_dedupe_keys_match_expected", + "label": "post-write smoke 找到的 queue row 必須符合 transaction preview", + "passed": smoke_summary["dedupe_keys_match_expected"], + }, + { + "key": "postwrite_smoke_no_approval_token_key", + "label": "post-write smoke 結果不得包含 approval token key", + "passed": not smoke_summary["approval_token_key_detected"], + }, + { + "key": "receipt_artifact_paths_recorded", + "label": "操作員需記錄 writer output 與 post-write smoke artifact 路徑", + "passed": bool( + evidence_summary["writer_output_json_path_recorded"] + and evidence_summary["postwrite_smoke_json_path_recorded"] + ), + }, + { + "key": "operator_confirmed_no_token_in_artifacts", + "label": "操作員確認 artifact 不含一次性 token", + "passed": bool( + evidence_summary["operator_confirmed_no_token_in_artifacts"] + and not evidence_summary["approval_token_submitted_to_api"] + ), + }, + ] + + +def build_candidate_queue_writer_run_receipt( + *, + transaction_preview, + run_readiness, + writer_output=None, + postwrite_smoke_result=None, + operator_evidence=None, +): + """建立 CLI 寫入後 receipt review；不執行任何副作用。""" + expected_keys = _dedupe_keys_from_transaction(transaction_preview) + operator_evidence = _as_dict(operator_evidence) + evidence_summary = _operator_evidence_summary(operator_evidence) + writer_summary = _writer_summary(writer_output, expected_keys) + smoke_summary = _smoke_summary(postwrite_smoke_result, expected_keys) + gates = _receipt_gates( + expected_keys=expected_keys, + run_readiness=_as_dict(run_readiness), + writer_summary=writer_summary, + smoke_summary=smoke_summary, + evidence_summary=evidence_summary, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + receipt_passed = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_writer_run_receipt_preview", + "target_table": "market_alert_review_queue", + "receipt_reviewed": True, + "receipt_passed": receipt_passed, + "ready_for_next_manual_review": receipt_passed, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "expected_dedupe_keys": expected_keys, + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_evidence_summary": evidence_summary, + "writer_output_summary": writer_summary, + "postwrite_smoke_summary": smoke_summary, + "next_operator_steps": [ + "保存 writer output 與 post-write smoke artifact", + "人工確認 queue row review_state 是否進入 needs_review", + "只在確認 receipt 通過後才進入下一個人工審核與 dashboard read-only inventory", + "不得從 UI/API 補寫、重跑 CLI 或自動掛 scheduler", + ], + "safe_boundaries": [ + "do_not_execute_cli_from_receipt_preview", + "do_not_read_approval_token_from_api", + "do_not_echo_operator_receipt_payload", + "do_not_open_database_connection_from_receipt_preview", + "do_not_write_queue_from_receipt_preview", + "do_not_attach_scheduler_from_receipt_preview", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index bd62711..a2cc575 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -3,24 +3,13 @@ 本模組只組裝 preview payload，不執行 git、部署、SSH、migration 或 DB write。 """ -from services.market_intel.candidate_queue_writer_cli import ( - build_candidate_queue_writer_cli_plan, -) -from services.market_intel.candidate_queue_writer_preflight import ( - build_candidate_queue_writer_preflight, -) -from services.market_intel.candidate_queue_writer_postwrite_smoke import ( - build_candidate_queue_writer_postwrite_smoke, -) -from services.market_intel.candidate_queue_writer_operator_drill import ( - build_candidate_queue_writer_operator_drill, -) -from services.market_intel.candidate_queue_writer_run_package import ( - build_candidate_queue_writer_run_package, -) -from services.market_intel.candidate_queue_writer_run_readiness import ( - build_candidate_queue_writer_run_readiness, -) +from services.market_intel.candidate_queue_writer_cli import build_candidate_queue_writer_cli_plan +from services.market_intel.candidate_queue_writer_preflight import build_candidate_queue_writer_preflight +from services.market_intel.candidate_queue_writer_postwrite_smoke import build_candidate_queue_writer_postwrite_smoke +from services.market_intel.candidate_queue_writer_operator_drill import build_candidate_queue_writer_operator_drill +from services.market_intel.candidate_queue_writer_run_package import build_candidate_queue_writer_run_package +from services.market_intel.candidate_queue_writer_run_readiness import build_candidate_queue_writer_run_readiness +from services.market_intel.candidate_queue_writer_run_receipt import build_candidate_queue_writer_run_receipt def build_deployment_readiness_preview( @@ -92,6 +81,10 @@ def build_deployment_readiness_preview( operator_drill=candidate_queue_writer_operator_drill, run_package=candidate_queue_writer_run_package, ) + candidate_queue_writer_run_receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=manual_sample_candidate_queue_transaction, + run_readiness=candidate_queue_writer_run_readiness, + ) match_review_plan = service.build_match_review_plan() opportunity_plan = service.build_opportunity_plan() opportunity_scoring_plan = service.build_opportunity_scoring_plan() @@ -311,6 +304,19 @@ def build_deployment_readiness_preview( and not candidate_queue_writer_run_readiness["database_commit_executed"] and not candidate_queue_writer_run_readiness["scheduler_attached"] ), + "candidate_queue_writer_run_receipt_preview_safe": bool( + candidate_queue_writer_run_receipt["mode"] + == "candidate_queue_writer_run_receipt_preview" + and not candidate_queue_writer_run_receipt["ready_for_api_database_write"] + and not candidate_queue_writer_run_receipt["ready_for_scheduler_attach"] + and not candidate_queue_writer_run_receipt["api_executes_cli"] + and not candidate_queue_writer_run_receipt["api_reads_approval_token"] + and not candidate_queue_writer_run_receipt["api_writes_file"] + and not candidate_queue_writer_run_receipt["database_connection_opened"] + and not candidate_queue_writer_run_receipt["database_write_executed"] + and not candidate_queue_writer_run_receipt["database_commit_executed"] + and not candidate_queue_writer_run_receipt["scheduler_attached"] + ), "match_review_plan_preview_safe": bool( match_review_plan["mode"] == "match_review_plan_preview" and not match_review_plan["review_queue_created"] @@ -529,6 +535,7 @@ def build_deployment_readiness_preview( "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", ], "status": status.to_dict(), "schema_smoke": schema_smoke, @@ -575,6 +582,7 @@ def build_deployment_readiness_preview( ), "candidate_queue_writer_run_package": candidate_queue_writer_run_package, "candidate_queue_writer_run_readiness": candidate_queue_writer_run_readiness, + "candidate_queue_writer_run_receipt": candidate_queue_writer_run_receipt, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, "opportunity_scoring_plan": opportunity_scoring_plan, diff --git a/services/market_intel/service.py b/services/market_intel/service.py index b946da5..c18de0d 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -108,7 +108,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務，先集中 feature gate 與安全狀態。""" - phase = "phase_61_candidate_queue_writer_run_readiness" + phase = "phase_62_candidate_queue_writer_run_receipt" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 7254ccd..5fe2925 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -606,6 +606,9 @@ + @@ -940,6 +943,7 @@ const sampleCandidateQueueOperatorDrill = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-operator-drill]') : null; const sampleCandidateQueueRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-package]') : null; const sampleCandidateQueueRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-readiness]') : null; + const sampleCandidateQueueRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-receipt]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -952,6 +956,7 @@ const sampleCandidateQueueOperatorDrillEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_operator_drill') }}"; const sampleCandidateQueueRunPackageEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_package') }}"; const sampleCandidateQueueRunReadinessEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_readiness') }}"; + const sampleCandidateQueueRunReceiptEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_receipt') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -2733,6 +2738,128 @@ } }; + const renderCandidateQueueRunReceipt = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const writer = data.writer_output_summary || {}; + const smoke = data.postwrite_smoke_summary || {}; + const evidence = data.operator_evidence_summary || {}; + const gates = data.gates || []; + const steps = data.next_operator_steps || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `receipt=${data.receipt_passed ? 'pass' : 'blocked'}`, + `writer=${writer.mode || 'missing'}`, + `smoke=${smoke.postwrite_smoke_passed ? 'pass' : 'blocked'}`, + `api_write=${data.ready_for_api_database_write ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只審核 CLI 寫入後的 writer output 與 post-write smoke receipt；API/UI 不讀 token、不執行 CLI、不連 DB、不補寫 queue。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
expected=${escapeHtml((data.expected_dedupe_keys || []).join(', ') || 'none')} / observed=${escapeHtml((writer.observed_dedupe_keys || []).join(', ') || 'none')} / found=${escapeHtml((smoke.found_dedupe_keys || []).join(', ') || 'none')}
+
+
+

RECEIPT GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 receipt gates。
' + }
+
+
+

WRITER / SMOKE

+
+ ${[ + ['writer_committed', writer.database_commit_executed], + ['writer_dedupe_match', writer.dedupe_keys_match_expected], + ['writer_token_key_detected', writer.approval_token_key_detected], + ['smoke_read_only', smoke.read_only_query_executed], + ['smoke_passed', smoke.postwrite_smoke_passed], + ['smoke_dedupe_match', smoke.dedupe_keys_match_expected] + ].map(([key, value]) => ` +
+
+ ${escapeHtml(key)} +
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+

ARTIFACT EVIDENCE

+
+ ${[ + ['writer_output_json_path_recorded', evidence.writer_output_json_path_recorded], + ['postwrite_smoke_json_path_recorded', evidence.postwrite_smoke_json_path_recorded], + ['operator_confirmed_no_token_in_artifacts', evidence.operator_confirmed_no_token_in_artifacts], + ['approval_token_submitted_to_api', evidence.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
+ ${escapeHtml(key)} +
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+

NEXT STEPS

+
${ + steps.map((item, index) => ` +
+
+ ${escapeHtml(`step_${index + 1}`)} + ${escapeHtml(item)} +
+ MANUAL +
+ `).join('') || '
尚未提供下一步。
' + }
+
+
+ `; + }; + + const loadCandidateQueueRunReceipt = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + + const body = parsed && parsed.sample_result + ? parsed + : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
審核 queue writer run receipt 中...
'; + try { + const response = await fetch(sampleCandidateQueueRunReceiptEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueRunReceipt(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue writer run receipt 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderSchedulerMeta = data => { schedulerMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -4257,6 +4384,9 @@ if (sampleCandidateQueueRunReadiness) { sampleCandidateQueueRunReadiness.addEventListener('click', loadCandidateQueueRunReadiness); } + if (sampleCandidateQueueRunReceipt) { + sampleCandidateQueueRunReceipt.addEventListener('click', loadCandidateQueueRunReceipt); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index b8d112b..020b6c3 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -28,6 +28,154 @@ from services.market_intel.schema_db_probe import build_schema_db_probe_plan TEST_APPROVAL_TOKEN = "test-market-intel-approval-token" +def _market_intel_sample_result(batch_id="sample-batch-receipt"): + return { + "batch_id": batch_id, + "platform_code": "momo", + "source_key": "homepage", + "source_url": "https://www.momoshop.com.tw/", + "status": "fetched", + "status_code": 200, + "content_length": 1700, + "page_hash": "b" * 64, + "title": "MOMO 活動", + "diagnostics": { + "link_count": 1, + "same_host_link_count": 1, + "campaign_link_candidates": [ + { + "confidence_band": "high", + "score": 94, + "url": "https://www.momoshop.com.tw/activity/sample", + "text": "品牌活動", + }, + ], + }, + } + + +def _build_candidate_queue_writer_receipt_fixture(batch_id="sample-batch-receipt"): + from services.market_intel.candidate_queue_writer_cli import ( + build_candidate_queue_writer_cli_plan, + ) + from services.market_intel.candidate_queue_writer_operator_drill import ( + build_candidate_queue_writer_operator_drill, + ) + from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_writer_preflight import ( + build_candidate_queue_writer_preflight, + ) + from services.market_intel.candidate_queue_writer_run_package import ( + build_candidate_queue_writer_run_package, + ) + from services.market_intel.candidate_queue_writer_run_readiness import ( + build_candidate_queue_writer_run_readiness, + ) + + service = MarketIntelService() + sample_result = _market_intel_sample_result(batch_id=batch_id) + transaction = service.build_manual_sample_candidate_queue_transaction( + sample_result=sample_result + ) + preflight = build_candidate_queue_writer_preflight( + transaction_preview=transaction, + execute_requested=False, + ) + writer_status = build_candidate_queue_writer_cli_plan( + transaction_preview=transaction, + writer_preflight=preflight, + ) + postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + operator_drill = build_candidate_queue_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + ) + run_package = build_candidate_queue_writer_run_package( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + operator_evidence = { + "reviewed_sample_json_path": "artifacts/market_intel/reviewed.json", + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": "artifacts/market_intel/preflight.json", + "migration_live_smoke_passed": True, + "operator_acknowledged_shell_only_token": True, + "writer_output_json_path": "artifacts/market_intel/writer-output.json", + "postwrite_smoke_json_path": "artifacts/market_intel/postwrite-smoke.json", + "operator_confirmed_no_token_in_artifacts": True, + "receipt_notes": "small-batch queue writer receipt reviewed", + } + run_readiness = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + expected_keys = sorted( + str(statement["lookup"]["dedupe_key"]) + for statement in transaction["statements"] + ) + writer_output = { + "mode": "candidate_queue_writer_cli_executed", + "exit_code": 0, + "approval_token_present": True, + "approval_token_valid": True, + "approval_token_secret_configured": True, + "approval_env_var": "MARKET_INTEL_QUEUE_WRITE_APPROVAL", + "writes_executed": True, + "would_write_database": True, + "database_connection_opened": True, + "explicit_transaction_opened": True, + "database_write_executed": True, + "database_commit_executed": True, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "inserted_count": len(expected_keys), + "skipped_count": 0, + "affected_dedupe_keys": expected_keys, + "skipped_dedupe_keys": [], + } + postwrite_smoke_result = { + "mode": "candidate_queue_writer_postwrite_smoke_read_only", + "postwrite_smoke_passed": True, + "ready_for_operator_review": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": len(expected_keys), + "found_count": len(expected_keys), + "missing_count": 0, + "found_dedupe_keys": expected_keys, + "missing_dedupe_keys": [], + } + return { + "sample_result": sample_result, + "transaction": transaction, + "run_readiness": run_readiness, + "operator_evidence": operator_evidence, + "writer_output": writer_output, + "postwrite_smoke_result": postwrite_smoke_result, + "expected_keys": expected_keys, + } + + def test_market_intel_defaults_are_safe(): service = MarketIntelService() status = service.get_runtime_status().to_dict() @@ -524,6 +672,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-sample-candidate-queue-transaction" in template assert "data-market-intel-sample-candidate-queue-writer" in template assert "data-market-intel-sample-candidate-queue-preflight" in template + assert "data-market-intel-sample-candidate-queue-run-receipt" in template assert "data-market-intel-approval" in template assert "data-market-intel-approval-gates" in template assert "data-market-intel-deploy" in template @@ -565,6 +714,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel.market_intel_manual_sample_candidate_queue_writer_run_readiness" in template ) + assert ( + "market_intel.market_intel_manual_sample_candidate_queue_writer_run_receipt" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -601,7 +754,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert bridge["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -759,7 +912,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert contract["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -892,7 +1045,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -905,7 +1058,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert gate["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -975,7 +1128,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -987,7 +1140,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1035,7 +1188,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1046,7 +1199,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert acceptance["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1088,7 +1241,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1100,7 +1253,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert review["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1211,7 +1364,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1250,7 +1403,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert review["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1312,7 +1465,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1392,7 +1545,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert handoff["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1456,7 +1609,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1515,7 +1668,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert queue_draft["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1589,7 +1742,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1652,7 +1805,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert approval["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -1730,7 +1883,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -1793,7 +1946,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert transaction["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -1873,7 +2026,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -2719,6 +2872,96 @@ def test_candidate_queue_writer_run_readiness_preview_checks_operator_evidence() assert "do_not_read_approval_token_from_api" in ready["safe_boundaries"] +def test_candidate_queue_writer_run_receipt_preview_checks_writer_and_smoke_artifacts(): + from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, + ) + + fixture = _build_candidate_queue_writer_receipt_fixture() + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output=fixture["writer_output"], + postwrite_smoke_result=fixture["postwrite_smoke_result"], + operator_evidence=fixture["operator_evidence"], + ) + token_leak = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output={ + **fixture["writer_output"], + "approval_token": TEST_APPROVAL_TOKEN, + }, + postwrite_smoke_result=fixture["postwrite_smoke_result"], + operator_evidence={ + **fixture["operator_evidence"], + "market_intel_queue_write_approval": TEST_APPROVAL_TOKEN, + }, + ) + malformed_receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output={ + "inserted_count": "not-a-number", + "affected_dedupe_keys": fixture["expected_keys"][0], + }, + postwrite_smoke_result={ + "found_count": "not-a-number", + "found_dedupe_keys": fixture["expected_keys"][0], + }, + operator_evidence=fixture["operator_evidence"], + ) + + assert receipt["mode"] == "candidate_queue_writer_run_receipt_preview" + assert receipt["receipt_passed"] is True + assert receipt["ready_for_next_manual_review"] is True + assert receipt["ready_for_api_database_write"] is False + assert receipt["ready_for_scheduler_attach"] is False + assert receipt["api_executes_cli"] is False + assert receipt["api_reads_approval_token"] is False + assert receipt["api_writes_file"] is False + assert receipt["api_writes_database"] is False + assert receipt["database_connection_opened"] is False + assert receipt["database_write_executed"] is False + assert receipt["database_commit_executed"] is False + assert receipt["scheduler_attached"] is False + assert receipt["expected_dedupe_keys"] == fixture["expected_keys"] + assert receipt["writer_output_summary"]["database_commit_executed"] is True + assert receipt["writer_output_summary"]["dedupe_keys_match_expected"] is True + assert receipt["postwrite_smoke_summary"]["read_only_query_executed"] is True + assert receipt["postwrite_smoke_summary"]["dedupe_keys_match_expected"] is True + assert receipt["operator_evidence_summary"][ + "writer_output_json_path_recorded" + ] is True + assert receipt["operator_evidence_summary"][ + "postwrite_smoke_json_path_recorded" + ] is True + assert receipt["operator_evidence_summary"][ + "operator_confirmed_no_token_in_artifacts" + ] is True + assert receipt["blocked_reasons"] == [] + assert "do_not_execute_cli_from_receipt_preview" in receipt["safe_boundaries"] + assert "do_not_read_approval_token_from_api" in receipt["safe_boundaries"] + assert token_leak["receipt_passed"] is False + assert token_leak["writer_output_summary"]["approval_token_key_detected"] is True + assert token_leak["operator_evidence_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "writer_output_no_approval_token_key" in token_leak["blocked_reasons"] + assert "operator_confirmed_no_token_in_artifacts" in token_leak["blocked_reasons"] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + assert malformed_receipt["receipt_passed"] is False + assert malformed_receipt["writer_output_summary"]["inserted_count"] == 0 + assert malformed_receipt["postwrite_smoke_summary"]["found_count"] == 0 + assert "writer_output_executed_and_committed" in malformed_receipt[ + "blocked_reasons" + ] + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -2761,7 +3004,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -2818,7 +3061,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -2907,7 +3150,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -2961,7 +3204,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -3017,7 +3260,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -3083,7 +3326,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -3099,11 +3342,290 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert data["blocked_reasons"] == [] +def test_candidate_queue_writer_run_receipt_preview_reviews_operator_artifacts(): + from services.market_intel.candidate_queue_writer_cli import ( + build_candidate_queue_writer_cli_plan, + ) + from services.market_intel.candidate_queue_writer_operator_drill import ( + build_candidate_queue_writer_operator_drill, + ) + from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_writer_preflight import ( + build_candidate_queue_writer_preflight, + ) + from services.market_intel.candidate_queue_writer_run_package import ( + build_candidate_queue_writer_run_package, + ) + from services.market_intel.candidate_queue_writer_run_readiness import ( + build_candidate_queue_writer_run_readiness, + ) + from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, + ) + + sample_result = _market_intel_sample_result("sample-batch-29") + transaction = MarketIntelService().build_manual_sample_candidate_queue_transaction( + sample_result=sample_result + ) + expected_key = transaction["statements"][0]["lookup"]["dedupe_key"] + preflight = build_candidate_queue_writer_preflight( + transaction_preview=transaction, + execute_requested=False, + ) + writer_status = build_candidate_queue_writer_cli_plan( + transaction_preview=transaction, + writer_preflight=preflight, + ) + postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + operator_drill = build_candidate_queue_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + ) + run_package = build_candidate_queue_writer_run_package( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + operator_evidence = { + "reviewed_sample_json_path": "artifacts/market_intel/reviewed.json", + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": "artifacts/market_intel/preflight.json", + "migration_live_smoke_passed": True, + "operator_acknowledged_shell_only_token": True, + "writer_output_json_path": "artifacts/market_intel/writer-output.json", + "postwrite_smoke_json_path": "artifacts/market_intel/postwrite-smoke.json", + "operator_confirmed_no_token_in_artifacts": True, + } + run_readiness = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + writer_output = { + "mode": "candidate_queue_writer_cli_executed", + "exit_code": 0, + "writes_executed": True, + "would_write_database": True, + "database_connection_opened": True, + "explicit_transaction_opened": True, + "database_write_executed": True, + "database_commit_executed": True, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "inserted_count": 1, + "skipped_count": 0, + "affected_dedupe_keys": [expected_key], + "skipped_dedupe_keys": [], + } + postwrite_smoke_result = { + "mode": "candidate_queue_writer_postwrite_smoke_read_only", + "postwrite_smoke_passed": True, + "ready_for_operator_review": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": 1, + "found_count": 1, + "missing_count": 0, + "found_dedupe_keys": [expected_key], + "missing_dedupe_keys": [], + } + + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=transaction, + run_readiness=run_readiness, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=operator_evidence, + ) + token_leak = build_candidate_queue_writer_run_receipt( + transaction_preview=transaction, + run_readiness=run_readiness, + writer_output={**writer_output, "approval_token": TEST_APPROVAL_TOKEN}, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=operator_evidence, + ) + + assert receipt["mode"] == "candidate_queue_writer_run_receipt_preview" + assert receipt["receipt_passed"] is True + assert receipt["ready_for_next_manual_review"] is True + assert receipt["ready_for_api_database_write"] is False + assert receipt["ready_for_scheduler_attach"] is False + assert receipt["api_executes_cli"] is False + assert receipt["api_reads_approval_token"] is False + assert receipt["api_writes_file"] is False + assert receipt["database_connection_opened"] is False + assert receipt["database_write_executed"] is False + assert receipt["database_commit_executed"] is False + assert receipt["scheduler_attached"] is False + assert receipt["writer_output_summary"]["dedupe_keys_match_expected"] is True + assert receipt["postwrite_smoke_summary"]["dedupe_keys_match_expected"] is True + assert receipt["operator_evidence_summary"]["writer_output_json_path_recorded"] is True + assert receipt["blocked_reasons"] == [] + assert token_leak["receipt_passed"] is False + assert token_leak["writer_output_summary"]["approval_token_key_detected"] is True + assert "writer_output_no_approval_token_key" in token_leak["blocked_reasons"] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + assert "do_not_echo_operator_receipt_payload" in receipt["safe_boundaries"] + + +def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_write(): + from routes.market_intel_routes import market_intel_bp + + sample_result = _market_intel_sample_result("sample-batch-30") + transaction = MarketIntelService().build_manual_sample_candidate_queue_transaction( + sample_result=sample_result + ) + expected_key = transaction["statements"][0]["lookup"]["dedupe_key"] + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_writer_run_receipt", + json={ + "sample_result": sample_result, + "operator_evidence": { + "reviewed_sample_json_path": "artifacts/market_intel/reviewed.json", + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": "artifacts/market_intel/preflight.json", + "migration_live_smoke_passed": True, + "operator_acknowledged_shell_only_token": True, + "writer_output_json_path": "artifacts/market_intel/writer-output.json", + "postwrite_smoke_json_path": "artifacts/market_intel/smoke.json", + "operator_confirmed_no_token_in_artifacts": True, + }, + "writer_output": { + "mode": "candidate_queue_writer_cli_executed", + "exit_code": 0, + "writes_executed": True, + "would_write_database": True, + "database_connection_opened": True, + "explicit_transaction_opened": True, + "database_write_executed": True, + "database_commit_executed": True, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "inserted_count": 1, + "skipped_count": 0, + "affected_dedupe_keys": [expected_key], + }, + "postwrite_smoke_result": { + "mode": "candidate_queue_writer_postwrite_smoke_read_only", + "postwrite_smoke_passed": True, + "ready_for_operator_review": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": 1, + "found_count": 1, + "missing_count": 0, + "found_dedupe_keys": [expected_key], + "missing_dedupe_keys": [], + }, + }, + ) + data = response.get_json() + + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_writer_run_receipt_preview" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["receipt_passed"] is True + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["blocked_reasons"] == [] + + +def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + batch_id="sample-batch-route-receipt" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_writer_run_receipt", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": fixture["operator_evidence"], + "writer_output": fixture["writer_output"], + "postwrite_smoke_result": fixture["postwrite_smoke_result"], + }, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_writer_run_receipt_preview" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["receipt_passed"] is True + assert data["ready_for_next_manual_review"] is True + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["api_writes_database"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["writer_output_summary"]["database_commit_executed"] is True + assert data["writer_output_summary"]["dedupe_keys_match_expected"] is True + assert data["postwrite_smoke_summary"]["postwrite_smoke_passed"] is True + assert data["postwrite_smoke_summary"]["dedupe_keys_match_expected"] is True + assert data["blocked_reasons"] == [] + assert TEST_APPROVAL_TOKEN not in payload + + def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -3141,7 +3663,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -3152,7 +3674,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -3188,7 +3710,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -3199,7 +3721,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -3240,7 +3762,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -3251,7 +3773,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -3299,7 +3821,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -3311,7 +3833,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -3357,7 +3879,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -3370,7 +3892,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -3455,7 +3977,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -3533,7 +4055,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -3548,7 +4070,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert readiness["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -3962,6 +4484,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["checks"]["candidate_queue_writer_run_readiness_preview_safe"] is True ) + assert ( + readiness["checks"]["candidate_queue_writer_run_receipt_preview_safe"] + is True + ) assert readiness["checks"]["match_review_plan_preview_safe"] is True assert readiness["checks"]["opportunity_plan_preview_safe"] is True assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True @@ -4020,6 +4546,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt" + in readiness["production_smoke_targets"] + ) assert readiness["write_approval_runbook"]["ready_for_real_write"] is False assert readiness["write_approval_runbook"]["writes_executed"] is False assert readiness["migration_blueprint"]["migration_executed"] is False @@ -4481,6 +5011,37 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["candidate_queue_writer_run_readiness"]["scheduler_attached"] is False ) + assert ( + readiness["candidate_queue_writer_run_receipt"]["mode"] + == "candidate_queue_writer_run_receipt_preview" + ) + assert ( + readiness["candidate_queue_writer_run_receipt"]["ready_for_api_database_write"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_receipt"]["ready_for_scheduler_attach"] + is False + ) + assert readiness["candidate_queue_writer_run_receipt"]["api_executes_cli"] is False + assert ( + readiness["candidate_queue_writer_run_receipt"]["api_reads_approval_token"] + is False + ) + assert readiness["candidate_queue_writer_run_receipt"]["api_writes_file"] is False + assert ( + readiness["candidate_queue_writer_run_receipt"]["database_connection_opened"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_receipt"]["database_write_executed"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_receipt"]["database_commit_executed"] + is False + ) + assert readiness["candidate_queue_writer_run_receipt"]["scheduler_attached"] is False assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False assert readiness["scheduler_plan"]["crawler_job_started"] is False assert readiness["scheduler_plan"]["database_write_executed"] is False @@ -4585,7 +5146,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert drill["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -4700,7 +5261,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -4712,7 +5273,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert review["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -4827,7 +5388,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -4840,7 +5401,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert smoke["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -4902,7 +5463,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -4915,7 +5476,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert inventory["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -5059,7 +5620,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -5286,7 +5847,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False