diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 7aa55e3..90c42f0 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -126,6 +126,7 @@ - Phase 59 candidate queue writer operator drill：新增 `services/market_intel/candidate_queue_writer_operator_drill.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill` 與 UI drill 按鈕，組裝 reviewed sample、備份、read-only preflight、CLI writer、post-write smoke 的操作員順序；API/UI 不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.237。 - V10.238 補業績圖表 runtime QA 與分析 tabs 窄版修正：新增 `quick_review --sales-charts` 檢查 `/daily_sales`、`/growth_analysis` 的 Chart.js ready、可繪製資料集與 canvas 非空白；同時把分析報表 tabs 手機版改為自適應 grid，避免 Metabase/Grist 外部連結超出右側。 - Phase 60 candidate queue writer run package：新增 `services/market_intel/candidate_queue_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package` 與 UI run package 按鈕，整理正式 CLI 小流量寫入前的 payload manifest、required artifacts、command bundle、operator signoff 與 rollback plan；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.240。 + - Phase 61 candidate queue writer run readiness：新增 `services/market_intel/candidate_queue_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness` 與 UI readiness 按鈕，檢查 reviewed sample 檔案路徑、備份路徑、preflight 輸出、migration live smoke、shell-only token acknowledgement 與禁止 token 進 API；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.245。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 - Desktop UI QA：本機只註冊 `market_intel_bp` 的 Flask harness 載入 `/market_intel`，確認 Phase 15、候選預覽、writer preview、安全 flags、點陣暖紙視覺正常，console error 0。 - API QA：`/api/market_intel/schema_smoke` 通過 7 張表與 `market_platforms` 必要欄位檢查；`/api/market_intel/platform_seed_writer_plan` 回傳 4 筆 dry-run upsert preview，`writes_executed=false`，四平台皆 `blocked_dry_run_only`。 @@ -136,7 +137,7 @@ - 補 UI preview panel 真 390px 截圖 QA；本輪 in-app browser 不支援直接設定 viewport，且 data URL iframe QA 被瀏覽器安全策略阻擋，不做繞過。 - 正式端 seed writer token-hardening drift：優先白名單同步 main 的一次性環境 token 版本，避免 API 暴露固定 approval token hint。 - 正式推版前需實際執行 worktree scope review、`python backup_system.py`、commit/push 目標變更、讀 deployment SOP 與 ADR-011，且只跑 `/health` 與市場情報頁 smoke。 - - 下一步才可在明確批准且具備真實 reviewed sample JSON 後做正式 DB 的 queue writer CLI 小流量 operator run；先用 run package、operator drill 與 post-write smoke 做順序與只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 + - 下一步才可在明確批准且具備真實 reviewed sample JSON 後做正式 DB 的 queue writer CLI 小流量 operator run；先用 run readiness、run package、operator drill 與 post-write smoke 做順序與只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 - 市場情報 UI 後續頁面必須沿用 V2 暖紙、暖墨、等寬數字與點陣風格，禁止複製巨型分析頁 template 模式。 ================================================================================ diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index fd5fd1c..e5a4609 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -186,6 +186,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue writer post-write smoke：`services.market_intel.candidate_queue_writer_postwrite_smoke` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke` 依 transaction preview dedupe key 只讀查詢 `market_alert_review_queue`，供 CLI 真寫入後確認 row 是否落地。UI 預設 `execute=false` 不連 DB；人工 smoke 即使 `execute=true` 也只讀查詢，不寫 DB、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer operator drill：`services.market_intel.candidate_queue_writer_operator_drill` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill` 組裝 reviewed sample、備份、read-only preflight、CLI writer、post-write smoke 的操作員順序與 gate。此 drill 只輸出可稽核操作計畫；API/UI 不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer run package：`services.market_intel.candidate_queue_writer_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package` 整理正式 CLI 小流量寫入前的 payload manifest、required artifacts、command bundle、operator signoff 與 rollback plan。此 package 只輸出可稽核證據包預覽；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue writer run readiness：`services.market_intel.candidate_queue_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness` 檢查正式 CLI 小流量寫入前的 reviewed sample 路徑、備份路徑、preflight 輸出、migration live smoke、shell-only token acknowledgement 與禁止 token 進 API。此 readiness 只輸出操作員證據缺口；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 87b4e34..131fdd9 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,7 +19,7 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 60 candidate queue writer run package | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 61 candidate queue writer run readiness | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index fa786fa..dd83abe 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -24,6 +24,9 @@ from services.market_intel.candidate_queue_writer_operator_drill import ( from services.market_intel.candidate_queue_writer_run_package import ( build_candidate_queue_writer_run_package, ) +from services.market_intel.candidate_queue_writer_run_readiness import ( + build_candidate_queue_writer_run_readiness, +) TAIPEI_TZ = timezone(timedelta(hours=8)) @@ -508,6 +511,70 @@ def market_intel_manual_sample_candidate_queue_writer_run_package(): return jsonify(data), status_code +@market_intel_bp.route( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_writer_run_readiness(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + service = _service() + payload_error = None + operator_evidence = {} + if not isinstance(payload, dict): + sample_result = None + payload_error = "invalid_json_object" + else: + sample_result = payload.get("sample_result", payload) + operator_evidence = payload.get("operator_evidence", {}) + + transaction_preview = service.build_manual_sample_candidate_queue_transaction( + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + ) + writer_preflight = build_candidate_queue_writer_preflight( + transaction_preview=transaction_preview, + execute_requested=False, + ) + writer_status = build_candidate_queue_writer_cli_plan( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + approval_token=None, + approval_token_secret=None, + ) + postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction_preview, + execute_requested=False, + ) + operator_drill = build_candidate_queue_writer_operator_drill( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + ) + run_package = build_candidate_queue_writer_run_package( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + data = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction_preview, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + data["phase"] = service.phase + status_code = 400 if payload_error else 200 + return jsonify(data), status_code + + @market_intel_bp.route("/api/market_intel/match_review_plan") @login_required def market_intel_match_review_plan(): diff --git a/services/market_intel/candidate_queue_writer_run_readiness.py b/services/market_intel/candidate_queue_writer_run_readiness.py new file mode 100644 index 0000000..9abc41d --- /dev/null +++ b/services/market_intel/candidate_queue_writer_run_readiness.py @@ -0,0 +1,225 @@ +"""候選審核 queue writer operator run readiness preview。 + +本模組只檢查正式 CLI 小流量寫入前的操作員證據是否齊備； +不讀 approval token、不執行 CLI、不開 DB connection、不寫 queue、不 commit、 +不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _payload_count(run_package): + manifest = _as_dict(run_package.get("payload_manifest")) + return int(manifest.get("payload_count") or 0) + + +def _artifact_summary(operator_evidence): + artifact_paths = { + "reviewed_sample_json_path": operator_evidence.get( + "reviewed_sample_json_path" + ), + "backup_artifact_path": operator_evidence.get("backup_artifact_path"), + "preflight_artifact_path": operator_evidence.get("preflight_artifact_path"), + } + return { + "provided_keys": sorted(operator_evidence.keys()), + "artifact_path_count": sum(1 for value in artifact_paths.values() if _has_text(value)), + "reviewed_sample_json_path_recorded": _has_text( + artifact_paths["reviewed_sample_json_path"] + ), + "backup_artifact_path_recorded": _has_text( + artifact_paths["backup_artifact_path"] + ), + "preflight_artifact_path_recorded": _has_text( + artifact_paths["preflight_artifact_path"] + ), + "migration_live_smoke_passed": bool( + operator_evidence.get("migration_live_smoke_passed") + ), + "operator_acknowledged_shell_only_token": bool( + operator_evidence.get("operator_acknowledged_shell_only_token") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _readiness_gates( + *, + run_package, + operator_drill, + postwrite_smoke, + operator_evidence, +): + artifact_summary = _artifact_summary(operator_evidence) + payload_count = _payload_count(run_package) + return [ + { + "key": "run_package_ready", + "label": "run package 已產生 reviewed payload manifest", + "passed": bool(run_package.get("package_ready")), + }, + { + "key": "payload_count_within_small_batch_limit", + "label": "首次 operator run 必須是 1 到 5 筆小流量", + "passed": 0 < payload_count <= 5, + }, + { + "key": "operator_drill_ready", + "label": "operator drill 已提供正式操作順序", + "passed": bool(operator_drill.get("operator_drill_ready")), + }, + { + "key": "reviewed_sample_json_path_recorded", + "label": "操作員已記錄 reviewed sample JSON 檔案路徑", + "passed": artifact_summary["reviewed_sample_json_path_recorded"], + }, + { + "key": "backup_artifact_path_recorded", + "label": "操作員已記錄最新備份檔路徑", + "passed": artifact_summary["backup_artifact_path_recorded"], + }, + { + "key": "preflight_artifact_path_recorded", + "label": "操作員已記錄 CLI read-only preflight 輸出路徑", + "passed": artifact_summary["preflight_artifact_path_recorded"], + }, + { + "key": "migration_live_smoke_passed", + "label": "操作員確認 migration live smoke 已通過", + "passed": artifact_summary["migration_live_smoke_passed"], + }, + { + "key": "operator_acknowledged_shell_only_token", + "label": "操作員確認一次性 token 只在 shell 提供", + "passed": artifact_summary["operator_acknowledged_shell_only_token"], + }, + { + "key": "approval_token_not_submitted_to_api", + "label": "payload 不得包含 approval token 或 token key", + "passed": not artifact_summary["approval_token_submitted_to_api"], + }, + { + "key": "postwrite_smoke_plan_available", + "label": "post-write smoke 已可在寫入後做只讀驗證", + "passed": bool(postwrite_smoke), + }, + ] + + +def build_candidate_queue_writer_run_readiness( + *, + transaction_preview, + writer_preflight, + writer_status, + postwrite_smoke, + operator_drill, + run_package, + operator_evidence=None, +): + """建立 operator run readiness preview；不執行任何副作用。""" + operator_evidence = _as_dict(operator_evidence) + artifact_summary = _artifact_summary(operator_evidence) + gates = _readiness_gates( + run_package=run_package, + operator_drill=operator_drill, + postwrite_smoke=postwrite_smoke, + operator_evidence=operator_evidence, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + ready_for_cli_operator_run = bool(not blocked_reasons) + manifest = _as_dict(run_package.get("payload_manifest")) + transaction_summary = _as_dict(transaction_preview.get("transaction_summary")) + + return { + "mode": "candidate_queue_writer_run_readiness_preview", + "target_table": "market_alert_review_queue", + "ready_for_cli_operator_run": ready_for_cli_operator_run, + "ready_for_api_database_write": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_evidence_summary": artifact_summary, + "run_package_summary": { + "mode": run_package.get("mode"), + "package_ready": bool(run_package.get("package_ready")), + "payload_count": int(manifest.get("payload_count") or 0), + "manifest_hash": manifest.get("manifest_hash"), + "required_artifact_count": len(run_package.get("required_artifacts") or []), + "command_count": len(run_package.get("command_bundle") or []), + }, + "writer_summary": { + "writer_status_mode": writer_status.get("mode"), + "writer_preflight_mode": writer_preflight.get("mode"), + "postwrite_smoke_mode": postwrite_smoke.get("mode"), + "transaction_statement_count": int( + transaction_summary.get("statement_count") or 0 + ), + }, + "cli_execution_boundary": { + "api_may_execute_cli": False, + "operator_shell_required": True, + "one_time_token_shell_only": True, + "requires_backup_verified": True, + "requires_migration_live_smoke": True, + "requires_postwrite_smoke_after_cli": True, + }, + "next_operator_steps": [ + "保存真實 reviewed sample JSON", + "執行並記錄最新備份檔路徑", + "執行 read-only preflight 並保存輸出", + "確認 migration live smoke 通過", + "只在 CLI shell 注入一次性 approval token", + "CLI 寫入後立即保存 writer output 與 post-write smoke 結果", + ], + "safe_boundaries": [ + "do_not_execute_cli_from_api", + "do_not_read_approval_token_from_api", + "do_not_create_run_artifacts_from_api", + "do_not_open_database_connection_from_run_readiness_preview", + "do_not_write_queue_from_run_readiness_preview", + "do_not_attach_scheduler_from_run_readiness", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index f04fd29..bd62711 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -18,6 +18,9 @@ from services.market_intel.candidate_queue_writer_operator_drill import ( from services.market_intel.candidate_queue_writer_run_package import ( build_candidate_queue_writer_run_package, ) +from services.market_intel.candidate_queue_writer_run_readiness import ( + build_candidate_queue_writer_run_readiness, +) def build_deployment_readiness_preview( @@ -81,6 +84,14 @@ def build_deployment_readiness_preview( postwrite_smoke=candidate_queue_writer_postwrite_smoke, operator_drill=candidate_queue_writer_operator_drill, ) + candidate_queue_writer_run_readiness = build_candidate_queue_writer_run_readiness( + transaction_preview=manual_sample_candidate_queue_transaction, + writer_preflight=candidate_queue_writer_preflight, + writer_status=candidate_queue_writer_cli_status, + postwrite_smoke=candidate_queue_writer_postwrite_smoke, + operator_drill=candidate_queue_writer_operator_drill, + run_package=candidate_queue_writer_run_package, + ) match_review_plan = service.build_match_review_plan() opportunity_plan = service.build_opportunity_plan() opportunity_scoring_plan = service.build_opportunity_scoring_plan() @@ -288,6 +299,18 @@ def build_deployment_readiness_preview( and not candidate_queue_writer_run_package["database_commit_executed"] and not candidate_queue_writer_run_package["scheduler_attached"] ), + "candidate_queue_writer_run_readiness_preview_safe": bool( + candidate_queue_writer_run_readiness["mode"] + == "candidate_queue_writer_run_readiness_preview" + and not candidate_queue_writer_run_readiness["ready_for_api_database_write"] + and not candidate_queue_writer_run_readiness["api_executes_cli"] + and not candidate_queue_writer_run_readiness["api_reads_approval_token"] + and not candidate_queue_writer_run_readiness["api_writes_file"] + and not candidate_queue_writer_run_readiness["database_connection_opened"] + and not candidate_queue_writer_run_readiness["database_write_executed"] + and not candidate_queue_writer_run_readiness["database_commit_executed"] + and not candidate_queue_writer_run_readiness["scheduler_attached"] + ), "match_review_plan_preview_safe": bool( match_review_plan["mode"] == "match_review_plan_preview" and not match_review_plan["review_queue_created"] @@ -505,6 +528,7 @@ def build_deployment_readiness_preview( "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", ], "status": status.to_dict(), "schema_smoke": schema_smoke, @@ -550,6 +574,7 @@ def build_deployment_readiness_preview( candidate_queue_writer_operator_drill ), "candidate_queue_writer_run_package": candidate_queue_writer_run_package, + "candidate_queue_writer_run_readiness": candidate_queue_writer_run_readiness, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, "opportunity_scoring_plan": opportunity_scoring_plan, diff --git a/services/market_intel/service.py b/services/market_intel/service.py index 0ec58df..b946da5 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -108,7 +108,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務，先集中 feature gate 與安全狀態。""" - phase = "phase_60_candidate_queue_writer_run_package" + phase = "phase_61_candidate_queue_writer_run_readiness" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 7658ce3..7254ccd 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -603,6 +603,9 @@ + @@ -936,6 +939,7 @@ const sampleCandidateQueuePostwriteSmoke = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-postwrite-smoke]') : null; const sampleCandidateQueueOperatorDrill = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-operator-drill]') : null; const sampleCandidateQueueRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-package]') : null; + const sampleCandidateQueueRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-readiness]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -947,6 +951,7 @@ const sampleCandidateQueuePostwriteSmokeEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_postwrite_smoke') }}"; const sampleCandidateQueueOperatorDrillEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_operator_drill') }}"; const sampleCandidateQueueRunPackageEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_package') }}"; + const sampleCandidateQueueRunReadinessEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_readiness') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -2624,6 +2629,110 @@ } }; + const renderCandidateQueueRunReadiness = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const evidence = data.operator_evidence_summary || {}; + const packageSummary = data.run_package_summary || {}; + const gates = data.gates || []; + const steps = data.next_operator_steps || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `cli_ready=${data.ready_for_cli_operator_run ? 'yes' : 'no'}`, + `api_write=${data.ready_for_api_database_write ? 'yes' : 'no'}`, + `payloads=${packageSummary.payload_count || 0}`, + `paths=${evidence.artifact_path_count || 0}`, + `token_api=${evidence.approval_token_submitted_to_api ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只檢查正式 CLI 小流量寫入前的操作員證據；API/UI 不讀 token、不執行 CLI、不產檔、不寫 DB。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
manifest=${escapeHtml((packageSummary.manifest_hash || '').slice(0, 16) || 'none')} / artifacts=${escapeHtml(packageSummary.required_artifact_count || 0)} / commands=${escapeHtml(packageSummary.command_count || 0)}
+
+
+

READINESS GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 readiness gates。
' + }
+
+
+

EVIDENCE SUMMARY

+
+ ${[ + ['reviewed_sample_json_path_recorded', evidence.reviewed_sample_json_path_recorded], + ['backup_artifact_path_recorded', evidence.backup_artifact_path_recorded], + ['preflight_artifact_path_recorded', evidence.preflight_artifact_path_recorded], + ['migration_live_smoke_passed', evidence.migration_live_smoke_passed], + ['operator_acknowledged_shell_only_token', evidence.operator_acknowledged_shell_only_token], + ['approval_token_submitted_to_api', evidence.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
+ ${escapeHtml(key)} +
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+

NEXT STEPS

+
${ + steps.map((item, index) => ` +
+
+ ${escapeHtml(`step_${index + 1}`)} + ${escapeHtml(item)} +
+ MANUAL +
+ `).join('') || '
尚未提供下一步。
' + }
+
+
+ `; + }; + + const loadCandidateQueueRunReadiness = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + + const body = parsed && parsed.sample_result + ? parsed + : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue writer run readiness 中...
'; + try { + const response = await fetch(sampleCandidateQueueRunReadinessEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueRunReadiness(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue writer run readiness 檢查失敗：${escapeHtml(error.message)}
`; + } + }; + const renderSchedulerMeta = data => { schedulerMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -4145,6 +4254,9 @@ if (sampleCandidateQueueRunPackage) { sampleCandidateQueueRunPackage.addEventListener('click', loadCandidateQueueRunPackage); } + if (sampleCandidateQueueRunReadiness) { + sampleCandidateQueueRunReadiness.addEventListener('click', loadCandidateQueueRunReadiness); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index b591e78..b8d112b 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -561,6 +561,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel.market_intel_manual_sample_candidate_queue_writer_run_package" in template ) + assert ( + "market_intel.market_intel_manual_sample_candidate_queue_writer_run_readiness" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -597,7 +601,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_60_candidate_queue_writer_run_package" + assert bridge["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -755,7 +759,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_60_candidate_queue_writer_run_package" + assert contract["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -888,7 +892,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -901,7 +905,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_60_candidate_queue_writer_run_package" + assert gate["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -971,7 +975,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -983,7 +987,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1031,7 +1035,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1042,7 +1046,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_60_candidate_queue_writer_run_package" + assert acceptance["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1084,7 +1088,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1096,7 +1100,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_60_candidate_queue_writer_run_package" + assert review["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1207,7 +1211,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1246,7 +1250,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_60_candidate_queue_writer_run_package" + assert review["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1308,7 +1312,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1388,7 +1392,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_60_candidate_queue_writer_run_package" + assert handoff["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1452,7 +1456,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1511,7 +1515,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_60_candidate_queue_writer_run_package" + assert queue_draft["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1585,7 +1589,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1648,7 +1652,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_60_candidate_queue_writer_run_package" + assert approval["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -1726,7 +1730,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -1789,7 +1793,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_60_candidate_queue_writer_run_package" + assert transaction["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -1869,7 +1873,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -2575,6 +2579,146 @@ def test_candidate_queue_writer_run_package_preview_is_safe(): assert "do_not_create_run_artifacts_from_api" in run_package["safe_boundaries"] +def test_candidate_queue_writer_run_readiness_preview_checks_operator_evidence(): + from services.market_intel.candidate_queue_writer_cli import ( + build_candidate_queue_writer_cli_plan, + ) + from services.market_intel.candidate_queue_writer_operator_drill import ( + build_candidate_queue_writer_operator_drill, + ) + from services.market_intel.candidate_queue_writer_postwrite_smoke import ( + build_candidate_queue_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_writer_preflight import ( + build_candidate_queue_writer_preflight, + ) + from services.market_intel.candidate_queue_writer_run_package import ( + build_candidate_queue_writer_run_package, + ) + from services.market_intel.candidate_queue_writer_run_readiness import ( + build_candidate_queue_writer_run_readiness, + ) + + sample_result = { + "batch_id": "sample-batch-27", + "platform_code": "momo", + "source_key": "homepage", + "source_url": "https://www.momoshop.com.tw/", + "status": "fetched", + "status_code": 200, + "content_length": 1700, + "page_hash": "9" * 64, + "title": "MOMO 活動", + "diagnostics": { + "link_count": 1, + "same_host_link_count": 1, + "campaign_link_candidates": [ + { + "confidence_band": "high", + "score": 94, + "url": "https://www.momoshop.com.tw/activity/sample", + "text": "品牌活動", + }, + ], + }, + } + transaction = MarketIntelService().build_manual_sample_candidate_queue_transaction( + sample_result=sample_result + ) + preflight = build_candidate_queue_writer_preflight( + transaction_preview=transaction, + execute_requested=False, + ) + writer_status = build_candidate_queue_writer_cli_plan( + transaction_preview=transaction, + writer_preflight=preflight, + ) + postwrite_smoke = build_candidate_queue_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + operator_drill = build_candidate_queue_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + ) + run_package = build_candidate_queue_writer_run_package( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + + missing = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + ) + ready = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence={ + "reviewed_sample_json_path": "artifacts/market_intel/reviewed.json", + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": "artifacts/market_intel/preflight.json", + "migration_live_smoke_passed": True, + "operator_acknowledged_shell_only_token": True, + }, + ) + token_leak = build_candidate_queue_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence={ + "reviewed_sample_json_path": "artifacts/market_intel/reviewed.json", + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": "artifacts/market_intel/preflight.json", + "migration_live_smoke_passed": True, + "operator_acknowledged_shell_only_token": True, + "approval_token": TEST_APPROVAL_TOKEN, + }, + ) + + assert missing["mode"] == "candidate_queue_writer_run_readiness_preview" + assert missing["ready_for_cli_operator_run"] is False + assert missing["ready_for_api_database_write"] is False + assert missing["api_executes_cli"] is False + assert missing["api_reads_approval_token"] is False + assert missing["api_writes_file"] is False + assert missing["database_connection_opened"] is False + assert missing["database_write_executed"] is False + assert missing["database_commit_executed"] is False + assert missing["scheduler_attached"] is False + assert "reviewed_sample_json_path_recorded" in missing["blocked_reasons"] + assert "backup_artifact_path_recorded" in missing["blocked_reasons"] + assert "operator_acknowledged_shell_only_token" in missing["blocked_reasons"] + assert ready["ready_for_cli_operator_run"] is True + assert ready["ready_for_api_database_write"] is False + assert ready["database_write_executed"] is False + assert ready["operator_evidence_summary"]["artifact_path_count"] == 3 + assert token_leak["ready_for_cli_operator_run"] is False + assert token_leak["operator_evidence_summary"]["approval_token_submitted_to_api"] is True + assert "approval_token_not_submitted_to_api" in token_leak["blocked_reasons"] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + assert "do_not_read_approval_token_from_api" in ready["safe_boundaries"] + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -2617,7 +2761,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -2674,7 +2818,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -2763,7 +2907,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -2817,7 +2961,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -2873,7 +3017,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -2889,11 +3033,77 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert "real_sample_payload_saved_by_operator" in data["blocked_reasons"] +def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_writer_run_readiness", + json={ + "sample_result": { + "batch_id": "sample-batch-28", + "platform_code": "momo", + "source_key": "homepage", + "source_url": "https://www.momoshop.com.tw/", + "status": "fetched", + "status_code": 200, + "content_length": 1700, + "page_hash": "a" * 64, + "title": "MOMO 活動", + "diagnostics": { + "link_count": 1, + "same_host_link_count": 1, + "campaign_link_candidates": [ + { + "confidence_band": "high", + "score": 94, + "url": "https://www.momoshop.com.tw/activity/sample", + "text": "品牌活動", + }, + ], + }, + }, + "operator_evidence": { + "reviewed_sample_json_path": "artifacts/market_intel/reviewed.json", + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": "artifacts/market_intel/preflight.json", + "migration_live_smoke_passed": True, + "operator_acknowledged_shell_only_token": True, + }, + }, + ) + data = response.get_json() + + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_writer_run_readiness_preview" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" + assert data["ready_for_cli_operator_run"] is True + assert data["ready_for_api_database_write"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["api_writes_database"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["run_package_summary"]["payload_count"] == 1 + assert data["operator_evidence_summary"]["artifact_path_count"] == 3 + assert data["blocked_reasons"] == [] + + def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -2931,7 +3141,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -2942,7 +3152,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -2978,7 +3188,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -2989,7 +3199,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -3030,7 +3240,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -3041,7 +3251,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -3089,7 +3299,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -3101,7 +3311,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -3147,7 +3357,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -3160,7 +3370,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_60_candidate_queue_writer_run_package" + assert plan["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -3245,7 +3455,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -3323,7 +3533,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -3338,7 +3548,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_60_candidate_queue_writer_run_package" + assert readiness["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -3748,6 +3958,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["checks"]["candidate_queue_writer_run_package_preview_safe"] is True ) + assert ( + readiness["checks"]["candidate_queue_writer_run_readiness_preview_safe"] + is True + ) assert readiness["checks"]["match_review_plan_preview_safe"] is True assert readiness["checks"]["opportunity_plan_preview_safe"] is True assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True @@ -3802,6 +4016,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness" + in readiness["production_smoke_targets"] + ) assert readiness["write_approval_runbook"]["ready_for_real_write"] is False assert readiness["write_approval_runbook"]["writes_executed"] is False assert readiness["migration_blueprint"]["migration_executed"] is False @@ -4220,6 +4438,49 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["candidate_queue_writer_run_package"]["scheduler_attached"] is False ) + assert ( + readiness["candidate_queue_writer_run_readiness"]["mode"] + == "candidate_queue_writer_run_readiness_preview" + ) + assert ( + readiness["candidate_queue_writer_run_readiness"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_run_readiness"]["api_executes_cli"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_readiness"][ + "api_reads_approval_token" + ] + is False + ) + assert readiness["candidate_queue_writer_run_readiness"]["api_writes_file"] is False + assert ( + readiness["candidate_queue_writer_run_readiness"][ + "database_connection_opened" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_run_readiness"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_run_readiness"][ + "database_commit_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_writer_run_readiness"]["scheduler_attached"] + is False + ) assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False assert readiness["scheduler_plan"]["crawler_job_started"] is False assert readiness["scheduler_plan"]["database_write_executed"] is False @@ -4324,7 +4585,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_60_candidate_queue_writer_run_package" + assert drill["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -4439,7 +4700,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -4451,7 +4712,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_60_candidate_queue_writer_run_package" + assert review["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -4566,7 +4827,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -4579,7 +4840,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_60_candidate_queue_writer_run_package" + assert smoke["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -4641,7 +4902,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -4654,7 +4915,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_60_candidate_queue_writer_run_package" + assert inventory["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -4798,7 +5059,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -5025,7 +5286,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_60_candidate_queue_writer_run_package" + assert data["phase"] == "phase_61_candidate_queue_writer_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False