diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 3933d15..964bcc4 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.249 收斂 `/observability/ppt_audit_history` 手機與平板第一屏密度：將 4 個產線訊號從 hero 內移出成獨立狀態列，手機版維持 2 欄狀態卡並降低 hero 卡片間距；本機 10 個 AI 觀測台頁面 rendered visual contract 全數通過，PPT 頁 hero 高度 desktop/tablet/mobile 為 214/361/398px。 - V10.246 強化 `/observability/ppt_audit_history` 視覺 QA runtime 可讀性：功能開關、轉檔器與視覺模型改成中文 checklist，Vision QA 狀態卡直接顯示 runtime 就緒資訊，DB 產出狀態統一為「已產出」。 - V10.245 重整 `/observability/ppt_audit_history` 首屏資訊階層：改成簡報操作摘要、最新可預覽簡報、下一步動作與自適應報表類型 segmented grid；產線覆蓋矩陣改為下方驗收明細，避免一進頁只看到大量「產線狀態」或類型按鈕右側溢出。 - V10.242 修正 `/metabase`、`/grist` 外部工具入口：全域導覽固定回 momo-pro 內部橋接頁，避免資料協作錯連其他專案站；入口頁補路由狀態、設定診斷與可用替代分析入口，降低空白頁誤判。 @@ -129,6 +130,8 @@ - Phase 60 candidate queue writer run package：新增 `services/market_intel/candidate_queue_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package` 與 UI run package 按鈕，整理正式 CLI 小流量寫入前的 payload manifest、required artifacts、command bundle、operator signoff 與 rollback plan；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.240。 - Phase 61 candidate queue writer run readiness：新增 `services/market_intel/candidate_queue_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness` 與 UI readiness 按鈕，檢查 reviewed sample 檔案路徑、備份路徑、preflight 輸出、migration live smoke、shell-only token acknowledgement 與禁止 token 進 API；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler；版本同步至 V10.245。 - Phase 62 candidate queue writer run receipt：新增 `services/market_intel/candidate_queue_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt` 與 UI receipt 按鈕，審核 CLI 寫入後的 writer output、post-write smoke、dedupe key 一致性與 artifact 路徑；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler；版本同步至 V10.247。 + - Phase 63 candidate queue writer run closeout：新增 `services/market_intel/candidate_queue_writer_run_closeout.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout` 與 UI closeout 按鈕，在 receipt 通過後檢查 closeout artifact、操作員人工 queue review/read-only inventory 確認與安全 promotion gate；API/UI 不回吐原始 receipt、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler；版本同步至 V10.248。 + - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 - Desktop UI QA：本機只註冊 `market_intel_bp` 的 Flask harness 載入 `/market_intel`，確認 Phase 15、候選預覽、writer preview、安全 flags、點陣暖紙視覺正常，console error 0。 - API QA：`/api/market_intel/schema_smoke` 通過 7 張表與 `market_platforms` 必要欄位檢查；`/api/market_intel/platform_seed_writer_plan` 回傳 4 筆 dry-run upsert preview，`writes_executed=false`，四平台皆 `blocked_dry_run_only`。 @@ -136,10 +139,9 @@ - 測試：新增 `tests/test_market_intel_skeleton.py`，確認預設 flags 全關、adapter 不允許 network/write/scheduler，手動 discovery / candidate preview 預設不發 request，parser/scorer/confidence 診斷只輸出 JSON，UI 只使用 `fetch=false`，platform seed plan 只讀且需 gate。 【下次待辦】 - - 補 UI preview panel 真 390px 截圖 QA；本輪 in-app browser 不支援直接設定 viewport，且 data URL iframe QA 被瀏覽器安全策略阻擋，不做繞過。 - 正式端 seed writer token-hardening drift：優先白名單同步 main 的一次性環境 token 版本，避免 API 暴露固定 approval token hint。 - 正式推版前需實際執行 worktree scope review、`python backup_system.py`、commit/push 目標變更、讀 deployment SOP 與 ADR-011，且只跑 `/health` 與市場情報頁 smoke。 - - 下一步才可在明確批准且具備真實 reviewed sample JSON 後做正式 DB 的 queue writer CLI 小流量 operator run；先用 run readiness、run package、operator drill、post-write smoke 與 run receipt 做順序與只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 + - 下一步才可在明確批准且具備真實 reviewed sample JSON 後做正式 DB 的 queue writer CLI 小流量 operator run；先用 run readiness、run package、operator drill、post-write smoke、run receipt 與 run closeout 做順序與只讀驗證，預設 API/UI 不得寫 DB，也不得執行 migration。 - 市場情報 UI 後續頁面必須沿用 V2 暖紙、暖墨、等寬數字與點陣風格，禁止複製巨型分析頁 template 模式。 ================================================================================ diff --git a/config.py b/config.py index 9a68fae..278ec38 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.247" +SYSTEM_VERSION = "V10.249" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 2275419..40d651e 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -188,6 +188,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue writer run package：`services.market_intel.candidate_queue_writer_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package` 整理正式 CLI 小流量寫入前的 payload manifest、required artifacts、command bundle、operator signoff 與 rollback plan。此 package 只輸出可稽核證據包預覽；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer run readiness：`services.market_intel.candidate_queue_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness` 檢查正式 CLI 小流量寫入前的 reviewed sample 路徑、備份路徑、preflight 輸出、migration live smoke、shell-only token acknowledgement 與禁止 token 進 API。此 readiness 只輸出操作員證據缺口；API/UI 不產檔、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue writer run receipt：`services.market_intel.candidate_queue_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt` 審核 CLI 小流量寫入後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue writer run closeout：`services.market_intel.candidate_queue_writer_run_closeout` 與 `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout` 在 receipt 通過後整理 closeout gate、人工確認與下一階段 promotion 摘要。此 closeout 只允許放行到人工 queue review / read-only inventory；API/UI 不回吐原始 receipt、不讀 approval token、不執行 CLI、不連 DB、不寫 queue、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index a3105ff..66f9fef 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,7 +19,7 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 62 candidate queue writer run receipt | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 63 candidate queue writer run closeout | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index 4707e76..569a043 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -9,27 +9,14 @@ from flask import Blueprint, jsonify, render_template, request from auth import login_required from config import SYSTEM_VERSION from services.market_intel import MarketIntelService -from services.market_intel.candidate_queue_writer_cli import ( - build_candidate_queue_writer_cli_plan, -) -from services.market_intel.candidate_queue_writer_preflight import ( - build_candidate_queue_writer_preflight, -) -from services.market_intel.candidate_queue_writer_postwrite_smoke import ( - build_candidate_queue_writer_postwrite_smoke, -) -from services.market_intel.candidate_queue_writer_operator_drill import ( - build_candidate_queue_writer_operator_drill, -) -from services.market_intel.candidate_queue_writer_run_package import ( - build_candidate_queue_writer_run_package, -) -from services.market_intel.candidate_queue_writer_run_readiness import ( - build_candidate_queue_writer_run_readiness, -) -from services.market_intel.candidate_queue_writer_run_receipt import ( - build_candidate_queue_writer_run_receipt, -) +from services.market_intel.candidate_queue_writer_cli import build_candidate_queue_writer_cli_plan +from services.market_intel.candidate_queue_writer_preflight import build_candidate_queue_writer_preflight +from services.market_intel.candidate_queue_writer_postwrite_smoke import build_candidate_queue_writer_postwrite_smoke +from services.market_intel.candidate_queue_writer_operator_drill import build_candidate_queue_writer_operator_drill +from services.market_intel.candidate_queue_writer_run_package import build_candidate_queue_writer_run_package +from services.market_intel.candidate_queue_writer_run_readiness import build_candidate_queue_writer_run_readiness +from services.market_intel.candidate_queue_writer_run_receipt import build_candidate_queue_writer_run_receipt +from services.market_intel.candidate_queue_writer_run_closeout import build_candidate_queue_writer_run_closeout TAIPEI_TZ = timezone(timedelta(hours=8)) @@ -475,6 +462,21 @@ def _build_candidate_queue_writer_stack( } +def _extract_candidate_queue_writer_run_payload(): + payload = request.get_json(silent=True) + limit = request.args.get("limit", default=20, type=int) + if not isinstance(payload, dict): + return None, {}, {}, {}, "invalid_json_object", limit + return ( + payload.get("sample_result", payload), + payload.get("operator_evidence", {}), + payload.get("writer_output", {}), + payload.get("postwrite_smoke_result", {}), + None, + limit, + ) + + @market_intel_bp.route( "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", methods=["POST"], @@ -562,27 +564,13 @@ def market_intel_manual_sample_candidate_queue_writer_run_readiness(): return jsonify(data), status_code -@market_intel_bp.route( - "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", - methods=["POST"], -) +@market_intel_bp.route("/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", methods=["POST"]) @login_required def market_intel_manual_sample_candidate_queue_writer_run_receipt(): - payload = request.get_json(silent=True) - limit = request.args.get("limit", default=20, type=int) service = _service() - payload_error = None - operator_evidence = {} - writer_output = {} - postwrite_smoke_result = {} - if not isinstance(payload, dict): - sample_result = None - payload_error = "invalid_json_object" - else: - sample_result = payload.get("sample_result", payload) - operator_evidence = payload.get("operator_evidence", {}) - writer_output = payload.get("writer_output", {}) - postwrite_smoke_result = payload.get("postwrite_smoke_result", {}) + sample_result, operator_evidence, writer_output, postwrite_smoke_result, payload_error, limit = ( + _extract_candidate_queue_writer_run_payload() + ) stack = _build_candidate_queue_writer_stack( service=service, @@ -603,6 +591,38 @@ def market_intel_manual_sample_candidate_queue_writer_run_receipt(): return jsonify(data), status_code +@market_intel_bp.route("/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", methods=["POST"]) +@login_required +def market_intel_manual_sample_candidate_queue_writer_run_closeout(): + service = _service() + sample_result, operator_evidence, writer_output, postwrite_smoke_result, payload_error, limit = ( + _extract_candidate_queue_writer_run_payload() + ) + + stack = _build_candidate_queue_writer_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + limit=limit, + operator_evidence=operator_evidence, + ) + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=stack["transaction_preview"], + run_readiness=stack["run_readiness"], + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=operator_evidence, + ) + data = build_candidate_queue_writer_run_closeout( + transaction_preview=stack["transaction_preview"], + run_receipt=receipt, + operator_evidence=operator_evidence, + ) + data["phase"] = service.phase + status_code = 400 if payload_error else 200 + return jsonify(data), status_code + + @market_intel_bp.route("/api/market_intel/match_review_plan") @login_required def market_intel_match_review_plan(): diff --git a/scripts/check_responsive_overflow.js b/scripts/check_responsive_overflow.js index 6eb96e8..cc86d2c 100755 --- a/scripts/check_responsive_overflow.js +++ b/scripts/check_responsive_overflow.js @@ -108,6 +108,7 @@ function parseArgs(argv) { settleMs: 350, maxOverflow: 1, screenshotDir: '', + screenshotAll: false, json: false, }; @@ -133,6 +134,8 @@ function parseArgs(argv) { options.maxOverflow = parseInt(argv[++i], 10); } else if (arg === '--screenshot-dir') { options.screenshotDir = argv[++i]; + } else if (arg === '--screenshot-all') { + options.screenshotAll = true; } else if (arg === '--json') { options.json = true; } else if (arg === '--help' || arg === '-h') { @@ -165,6 +168,7 @@ Options: --settle-ms MS Fixed post-DOM layout settle wait, default 350 --max-overflow PX Allowed body overflow, default 1 --screenshot-dir DIR Save failure screenshots + --screenshot-all Save screenshots for passing routes too --json Print JSON summary `); } @@ -324,7 +328,7 @@ async function main() { const result = { route, viewport: viewport.name, status, passed, error, metrics }; results.push(result); - if (!passed && options.screenshotDir) { + if ((options.screenshotAll || !passed) && options.screenshotDir) { const file = `${safeName(route)}_${safeName(viewport.name)}.png`; await page.screenshot({ path: path.join(options.screenshotDir, file), fullPage: false }); } diff --git a/scripts/quick_review.sh b/scripts/quick_review.sh index 594a5df..d35c9cd 100755 --- a/scripts/quick_review.sh +++ b/scripts/quick_review.sh @@ -180,6 +180,7 @@ AI observability quick-review flags: Run rendered typography, surface, radius, contrast, and mobile density checks. --responsive-overflow [--base-url URL] [--route PATH ...] Run desktop/tablet/mobile body horizontal overflow checks for Flask routes. + Pass --screenshot-dir DIR --screenshot-all to save passing viewport QA shots. --sales-charts [--base-url URL] [--timeout SEC] Run Chart.js runtime and nonblank canvas checks for /daily_sales and /growth_analysis. EOF diff --git a/services/market_intel/candidate_queue_writer_run_closeout.py b/services/market_intel/candidate_queue_writer_run_closeout.py new file mode 100644 index 0000000..3166fc1 --- /dev/null +++ b/services/market_intel/candidate_queue_writer_run_closeout.py @@ -0,0 +1,290 @@ +"""候選審核 queue writer operator run closeout preview。 + +本模組只在 receipt review 之後整理 closeout gate；不回吐原始 receipt、 +不讀 approval token、不執行 CLI、不開 DB connection、不寫 queue、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +REQUIRED_RECEIPT_BOUNDARIES = { + "do_not_execute_cli_from_receipt_preview", + "do_not_read_approval_token_from_api", + "do_not_echo_operator_receipt_payload", + "do_not_open_database_connection_from_receipt_preview", + "do_not_write_queue_from_receipt_preview", + "do_not_attach_scheduler_from_receipt_preview", +} + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _receipt_summary(run_receipt): + run_receipt = _as_dict(run_receipt) + writer = _as_dict(run_receipt.get("writer_output_summary")) + smoke = _as_dict(run_receipt.get("postwrite_smoke_summary")) + expected_keys = _as_list(run_receipt.get("expected_dedupe_keys")) + blocked_reasons = _as_list(run_receipt.get("blocked_reasons")) + safe_boundaries = set(str(item) for item in _as_list(run_receipt.get("safe_boundaries"))) + missing_boundaries = sorted(REQUIRED_RECEIPT_BOUNDARIES - safe_boundaries) + + return { + "provided": bool(run_receipt), + "mode": run_receipt.get("mode"), + "receipt_passed": bool(run_receipt.get("receipt_passed")), + "ready_for_next_manual_review": bool( + run_receipt.get("ready_for_next_manual_review") + ), + "expected_dedupe_key_count": len(expected_keys), + "blocked_count": len(blocked_reasons), + "writer_mode": writer.get("mode"), + "writer_dedupe_keys_match_expected": bool( + writer.get("dedupe_keys_match_expected") + ), + "postwrite_smoke_passed": bool(smoke.get("postwrite_smoke_passed")), + "postwrite_smoke_dedupe_keys_match_expected": bool( + smoke.get("dedupe_keys_match_expected") + ), + "safe_boundaries_complete": not missing_boundaries, + "missing_safe_boundaries": missing_boundaries, + "ready_for_api_database_write": bool( + run_receipt.get("ready_for_api_database_write") + ), + "ready_for_scheduler_attach": bool(run_receipt.get("ready_for_scheduler_attach")), + "api_executes_cli": bool(run_receipt.get("api_executes_cli")), + "api_reads_approval_token": bool(run_receipt.get("api_reads_approval_token")), + "api_writes_file": bool(run_receipt.get("api_writes_file")), + "api_writes_database": bool(run_receipt.get("api_writes_database")), + "database_connection_opened": bool( + run_receipt.get("database_connection_opened") + ), + "database_write_executed": bool(run_receipt.get("database_write_executed")), + "database_commit_executed": bool(run_receipt.get("database_commit_executed")), + "scheduler_attached": bool(run_receipt.get("scheduler_attached")), + } + + +def _operator_closeout_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "closeout_artifact_path_recorded": _has_text( + operator_evidence.get("closeout_artifact_path") + ), + "operator_confirmed_queue_review_next": bool( + operator_evidence.get("operator_confirmed_queue_review_next") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "closeout_notes_recorded": _has_text(operator_evidence.get("closeout_notes")), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _closeout_gates(receipt_summary, closeout_summary): + return [ + { + "key": "receipt_preview_provided", + "label": "必須提供上一階段 receipt preview 摘要", + "passed": bool( + receipt_summary["provided"] + and receipt_summary["mode"] + == "candidate_queue_writer_run_receipt_preview" + ), + }, + { + "key": "receipt_passed", + "label": "receipt 必須已通過 writer output 與 post-write smoke 審核", + "passed": receipt_summary["receipt_passed"], + }, + { + "key": "receipt_ready_for_next_manual_review", + "label": "receipt 只能放行到下一個人工審核階段", + "passed": receipt_summary["ready_for_next_manual_review"], + }, + { + "key": "receipt_expected_dedupe_keys_present", + "label": "receipt 必須保有 transaction dedupe key 摘要", + "passed": bool(receipt_summary["expected_dedupe_key_count"]), + }, + { + "key": "writer_and_smoke_dedupe_match", + "label": "writer output 與 smoke 查詢都必須符合預期 dedupe key", + "passed": bool( + receipt_summary["writer_dedupe_keys_match_expected"] + and receipt_summary["postwrite_smoke_dedupe_keys_match_expected"] + and receipt_summary["postwrite_smoke_passed"] + ), + }, + { + "key": "receipt_safe_boundaries_complete", + "label": "receipt 必須保留不讀 token、不執行 CLI、不寫 queue 的安全邊界", + "passed": receipt_summary["safe_boundaries_complete"], + }, + { + "key": "receipt_no_api_database_write", + "label": "closeout 前不得出現 API/UI DB 寫入或 commit", + "passed": bool( + not receipt_summary["ready_for_api_database_write"] + and not receipt_summary["api_writes_database"] + and not receipt_summary["database_write_executed"] + and not receipt_summary["database_commit_executed"] + ), + }, + { + "key": "receipt_no_scheduler_or_cli_attach", + "label": "closeout 前不得從 API/UI 執行 CLI 或掛 scheduler", + "passed": bool( + not receipt_summary["ready_for_scheduler_attach"] + and not receipt_summary["api_executes_cli"] + and not receipt_summary["scheduler_attached"] + ), + }, + { + "key": "receipt_no_token_or_file_side_effect", + "label": "closeout 前 API/UI 不得讀 token 或寫 artifact 檔案", + "passed": bool( + not receipt_summary["api_reads_approval_token"] + and not receipt_summary["api_writes_file"] + ), + }, + { + "key": "closeout_artifact_path_recorded", + "label": "操作員需記錄 closeout artifact 路徑", + "passed": closeout_summary["closeout_artifact_path_recorded"], + }, + { + "key": "operator_confirmed_queue_review_next", + "label": "操作員確認下一步只進人工 queue review / read-only inventory", + "passed": closeout_summary["operator_confirmed_queue_review_next"], + }, + { + "key": "operator_confirmed_no_scheduler_attach", + "label": "操作員確認本階段不掛 scheduler", + "passed": closeout_summary["operator_confirmed_no_scheduler_attach"], + }, + { + "key": "operator_confirmed_no_api_db_write", + "label": "操作員確認本階段不由 API/UI 寫 DB", + "passed": closeout_summary["operator_confirmed_no_api_db_write"], + }, + { + "key": "closeout_no_approval_token_submitted_to_api", + "label": "closeout payload 不得包含一次性 approval token key", + "passed": not closeout_summary["approval_token_submitted_to_api"], + }, + ] + + +def build_candidate_queue_writer_run_closeout( + *, + transaction_preview, + run_receipt, + operator_evidence=None, +): + """建立 CLI 寫入後 closeout gate；不執行任何副作用。""" + receipt_summary = _receipt_summary(run_receipt) + closeout_summary = _operator_closeout_summary(operator_evidence) + gates = _closeout_gates(receipt_summary, closeout_summary) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + closeout_passed = bool(not blocked_reasons) + statement_count = len(_as_list(_as_dict(transaction_preview).get("statements"))) + + return { + "mode": "candidate_queue_writer_run_closeout_preview", + "target_table": "market_alert_review_queue", + "closeout_reviewed": True, + "closeout_passed": closeout_passed, + "ready_for_next_manual_phase": closeout_passed, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "statement_count": statement_count, + "blocked_reasons": blocked_reasons, + "gates": gates, + "receipt_summary": receipt_summary, + "operator_closeout_summary": closeout_summary, + "promotion_gate": { + "allowed": closeout_passed, + "next_manual_phase": "manual_queue_review_and_live_inventory_read_only", + "requires_real_db_write": False, + "requires_scheduler_attach": False, + "requires_operator_approval": True, + }, + "next_operator_steps": [ + "保存 closeout artifact 與 receipt 摘要", + "以人工方式執行 live DB inventory read-only smoke", + "在審核頁只檢查 needs_review queue row，不從 UI/API 補寫資料", + "若任何 closeout gate 阻擋，停在 receipt 階段並保留 feature flags 關閉", + ], + "safe_boundaries": [ + "do_not_echo_operator_receipt_payload", + "do_not_execute_cli_from_closeout_preview", + "do_not_read_approval_token_from_api", + "do_not_write_closeout_artifact_from_api", + "do_not_open_database_connection_from_closeout_preview", + "do_not_write_queue_from_closeout_preview", + "do_not_attach_scheduler_from_closeout_preview", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index a2cc575..476f08f 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -10,6 +10,24 @@ from services.market_intel.candidate_queue_writer_operator_drill import build_ca from services.market_intel.candidate_queue_writer_run_package import build_candidate_queue_writer_run_package from services.market_intel.candidate_queue_writer_run_readiness import build_candidate_queue_writer_run_readiness from services.market_intel.candidate_queue_writer_run_receipt import build_candidate_queue_writer_run_receipt +from services.market_intel.candidate_queue_writer_run_closeout import build_candidate_queue_writer_run_closeout + + +def _run_review_preview_safe(payload, mode): + blocked_keys = ( + "ready_for_api_database_write", + "ready_for_scheduler_attach", + "api_executes_cli", + "api_reads_approval_token", + "api_writes_file", + "database_connection_opened", + "database_write_executed", + "database_commit_executed", + "scheduler_attached", + ) + return bool( + payload["mode"] == mode and all(not payload.get(key) for key in blocked_keys) + ) def build_deployment_readiness_preview( @@ -85,6 +103,10 @@ def build_deployment_readiness_preview( transaction_preview=manual_sample_candidate_queue_transaction, run_readiness=candidate_queue_writer_run_readiness, ) + candidate_queue_writer_run_closeout = build_candidate_queue_writer_run_closeout( + transaction_preview=manual_sample_candidate_queue_transaction, + run_receipt=candidate_queue_writer_run_receipt, + ) match_review_plan = service.build_match_review_plan() opportunity_plan = service.build_opportunity_plan() opportunity_scoring_plan = service.build_opportunity_scoring_plan() @@ -304,18 +326,13 @@ def build_deployment_readiness_preview( and not candidate_queue_writer_run_readiness["database_commit_executed"] and not candidate_queue_writer_run_readiness["scheduler_attached"] ), - "candidate_queue_writer_run_receipt_preview_safe": bool( - candidate_queue_writer_run_receipt["mode"] - == "candidate_queue_writer_run_receipt_preview" - and not candidate_queue_writer_run_receipt["ready_for_api_database_write"] - and not candidate_queue_writer_run_receipt["ready_for_scheduler_attach"] - and not candidate_queue_writer_run_receipt["api_executes_cli"] - and not candidate_queue_writer_run_receipt["api_reads_approval_token"] - and not candidate_queue_writer_run_receipt["api_writes_file"] - and not candidate_queue_writer_run_receipt["database_connection_opened"] - and not candidate_queue_writer_run_receipt["database_write_executed"] - and not candidate_queue_writer_run_receipt["database_commit_executed"] - and not candidate_queue_writer_run_receipt["scheduler_attached"] + "candidate_queue_writer_run_receipt_preview_safe": _run_review_preview_safe( + candidate_queue_writer_run_receipt, + "candidate_queue_writer_run_receipt_preview", + ), + "candidate_queue_writer_run_closeout_preview_safe": _run_review_preview_safe( + candidate_queue_writer_run_closeout, + "candidate_queue_writer_run_closeout_preview", ), "match_review_plan_preview_safe": bool( match_review_plan["mode"] == "match_review_plan_preview" @@ -536,6 +553,7 @@ def build_deployment_readiness_preview( "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", ], "status": status.to_dict(), "schema_smoke": schema_smoke, @@ -583,6 +601,7 @@ def build_deployment_readiness_preview( "candidate_queue_writer_run_package": candidate_queue_writer_run_package, "candidate_queue_writer_run_readiness": candidate_queue_writer_run_readiness, "candidate_queue_writer_run_receipt": candidate_queue_writer_run_receipt, + "candidate_queue_writer_run_closeout": candidate_queue_writer_run_closeout, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, "opportunity_scoring_plan": opportunity_scoring_plan, diff --git a/services/market_intel/service.py b/services/market_intel/service.py index c18de0d..205411d 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -108,7 +108,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務，先集中 feature gate 與安全狀態。""" - phase = "phase_62_candidate_queue_writer_run_receipt" + phase = "phase_63_candidate_queue_writer_run_closeout" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( diff --git a/templates/admin/ppt_audit_history.html b/templates/admin/ppt_audit_history.html index 12c54fa..482d70c 100644 --- a/templates/admin/ppt_audit_history.html +++ b/templates/admin/ppt_audit_history.html @@ -48,15 +48,15 @@ -
- {% for signal in operator_summary.signals %} -
-
{{ signal.label }}
- {{ signal.value }} - {{ signal.meta }} -
- {% endfor %} + +
+ {% for signal in operator_summary.signals %} +
+
{{ signal.label }}
+ {{ signal.value }} + {{ signal.meta }}
+ {% endfor %}
{% if not vision_status.ready %}
diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 5fe2925..ac85945 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -251,10 +251,20 @@ align-items: stretch; display: grid; gap: 0.75rem; - grid-template-columns: minmax(0, 1fr) auto auto auto auto auto auto auto; + grid-template-columns: minmax(0, 1fr) auto; min-width: 0; } + .market-intel-control-actions { + align-content: flex-start; + display: flex; + flex-wrap: wrap; + gap: 0.75rem; + justify-content: flex-end; + min-width: 0; + max-width: min(34rem, 100%); + } + .market-intel-json-input { background: rgba(255, 250, 241, 0.9); border: 1px solid var(--momo-border, #d8c8aa); @@ -287,6 +297,11 @@ grid-template-columns: 1fr; } + .market-intel-control-actions { + justify-content: flex-start; + max-width: 100%; + } + .market-intel-panel { padding: 1rem; } @@ -573,42 +588,47 @@
- - - - - - - - - - - - +
+ + + + + + + + + + + + + +
@@ -944,6 +964,7 @@ const sampleCandidateQueueRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-package]') : null; const sampleCandidateQueueRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-readiness]') : null; const sampleCandidateQueueRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-receipt]') : null; + const sampleCandidateQueueRunCloseout = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-run-closeout]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -957,6 +978,7 @@ const sampleCandidateQueueRunPackageEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_package') }}"; const sampleCandidateQueueRunReadinessEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_readiness') }}"; const sampleCandidateQueueRunReceiptEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_receipt') }}"; + const sampleCandidateQueueRunCloseoutEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_queue_writer_run_closeout') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -2860,6 +2882,130 @@ } }; + const renderCandidateQueueRunCloseout = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const receipt = data.receipt_summary || {}; + const closeout = data.operator_closeout_summary || {}; + const promotion = data.promotion_gate || {}; + const gates = data.gates || []; + const steps = data.next_operator_steps || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `closeout=${data.closeout_passed ? 'pass' : 'blocked'}`, + `receipt=${receipt.receipt_passed ? 'pass' : 'blocked'}`, + `next=${promotion.allowed ? 'manual' : 'hold'}`, + `api_write=${data.ready_for_api_database_write ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只做 run receipt 後的 closeout gate；通過後也只代表可進人工 queue review / read-only inventory，不代表 API/UI 可寫 DB 或掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

CLOSEOUT GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 closeout gates。
' + }
+
+
+

RECEIPT SUMMARY

+
+ ${[ + ['receipt_passed', receipt.receipt_passed], + ['dedupe_keys', receipt.expected_dedupe_key_count || 0], + ['writer_match', receipt.writer_dedupe_keys_match_expected], + ['smoke_match', receipt.postwrite_smoke_dedupe_keys_match_expected], + ['safe_boundaries_complete', receipt.safe_boundaries_complete] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${typeof value === 'boolean' ? (value ? 'YES' : 'NO') : escapeHtml(value)} +
+ `).join('')} +
+
+
+

OPERATOR CLOSEOUT

+
+ ${[ + ['closeout_artifact_path_recorded', closeout.closeout_artifact_path_recorded], + ['operator_confirmed_queue_review_next', closeout.operator_confirmed_queue_review_next], + ['operator_confirmed_no_scheduler_attach', closeout.operator_confirmed_no_scheduler_attach], + ['operator_confirmed_no_api_db_write', closeout.operator_confirmed_no_api_db_write], + ['approval_token_submitted_to_api', closeout.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+

PROMOTION / NEXT

+
+
+
+ ${escapeHtml(promotion.next_manual_phase || 'manual_phase')} + requires_operator_approval=${promotion.requires_operator_approval ? 'yes' : 'no'} +
+ ${promotion.allowed ? 'ALLOW' : 'HOLD'} +
+ ${steps.map((item, index) => ` +
+
+ ${escapeHtml(`step_${index + 1}`)} + ${escapeHtml(item)} +
+ MANUAL +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueRunCloseout = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + + const body = parsed && parsed.sample_result + ? parsed + : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
收尾 queue writer run closeout 中...
'; + try { + const response = await fetch(sampleCandidateQueueRunCloseoutEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueRunCloseout(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue writer run closeout 收尾失敗：${escapeHtml(error.message)}
`; + } + }; + const renderSchedulerMeta = data => { schedulerMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -4387,6 +4533,9 @@ if (sampleCandidateQueueRunReceipt) { sampleCandidateQueueRunReceipt.addEventListener('click', loadCandidateQueueRunReceipt); } + if (sampleCandidateQueueRunCloseout) { + sampleCandidateQueueRunCloseout.addEventListener('click', loadCandidateQueueRunCloseout); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 020b6c3..60aa4b1 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -667,12 +667,16 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-sample-review-input" in template assert "data-market-intel-sample-review-evaluate" in template assert "data-market-intel-sample-candidate-handoff" in template + assert "data-market-intel-sample-review-actions-rail" in template + assert ".market-intel-control-actions" in template + assert "grid-template-columns: minmax(0, 1fr) auto auto auto" not in template assert "data-market-intel-sample-candidate-queue-draft" in template assert "data-market-intel-sample-candidate-queue-approval" in template assert "data-market-intel-sample-candidate-queue-transaction" in template assert "data-market-intel-sample-candidate-queue-writer" in template assert "data-market-intel-sample-candidate-queue-preflight" in template assert "data-market-intel-sample-candidate-queue-run-receipt" in template + assert "data-market-intel-sample-candidate-queue-run-closeout" in template assert "data-market-intel-approval" in template assert "data-market-intel-approval-gates" in template assert "data-market-intel-deploy" in template @@ -718,6 +722,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel.market_intel_manual_sample_candidate_queue_writer_run_receipt" in template ) + assert ( + "market_intel.market_intel_manual_sample_candidate_queue_writer_run_closeout" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -754,7 +762,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert bridge["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -912,7 +920,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert contract["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1045,7 +1053,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1058,7 +1066,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert gate["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1128,7 +1136,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1140,7 +1148,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1188,7 +1196,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1199,7 +1207,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert acceptance["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1241,7 +1249,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1253,7 +1261,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert review["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1364,7 +1372,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1403,7 +1411,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert review["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1465,7 +1473,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1545,7 +1553,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert handoff["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1609,7 +1617,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1668,7 +1676,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert queue_draft["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1742,7 +1750,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1805,7 +1813,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert approval["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -1883,7 +1891,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -1946,7 +1954,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert transaction["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2026,7 +2034,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -2962,6 +2970,88 @@ def test_candidate_queue_writer_run_receipt_preview_checks_writer_and_smoke_arti ] +def test_candidate_queue_writer_run_closeout_preview_promotes_only_manual_phase(): + from services.market_intel.candidate_queue_writer_run_closeout import ( + build_candidate_queue_writer_run_closeout, + ) + from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, + ) + + fixture = _build_candidate_queue_writer_receipt_fixture() + closeout_evidence = { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "closeout_notes": "ready for read-only inventory", + } + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output=fixture["writer_output"], + postwrite_smoke_result=fixture["postwrite_smoke_result"], + operator_evidence=fixture["operator_evidence"], + ) + closeout = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence=closeout_evidence, + ) + missing = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence=fixture["operator_evidence"], + ) + token_leak = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence={ + **closeout_evidence, + "approval_token": TEST_APPROVAL_TOKEN, + }, + ) + + assert closeout["mode"] == "candidate_queue_writer_run_closeout_preview" + assert closeout["closeout_passed"] is True + assert closeout["ready_for_next_manual_phase"] is True + assert closeout["ready_for_api_database_write"] is False + assert closeout["ready_for_scheduler_attach"] is False + assert closeout["api_executes_cli"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_file"] is False + assert closeout["api_writes_database"] is False + assert closeout["database_connection_opened"] is False + assert closeout["database_write_executed"] is False + assert closeout["database_commit_executed"] is False + assert closeout["scheduler_attached"] is False + assert closeout["receipt_summary"]["receipt_passed"] is True + assert closeout["receipt_summary"]["safe_boundaries_complete"] is True + assert closeout["operator_closeout_summary"][ + "closeout_artifact_path_recorded" + ] is True + assert closeout["promotion_gate"]["allowed"] is True + assert closeout["promotion_gate"]["requires_real_db_write"] is False + assert closeout["blocked_reasons"] == [] + assert "do_not_write_queue_from_closeout_preview" in closeout["safe_boundaries"] + assert missing["closeout_passed"] is False + assert "closeout_artifact_path_recorded" in missing["blocked_reasons"] + assert "operator_confirmed_queue_review_next" in missing["blocked_reasons"] + assert token_leak["closeout_passed"] is False + assert token_leak["operator_closeout_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "closeout_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -3004,7 +3094,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -3061,7 +3151,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -3150,7 +3240,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -3204,7 +3294,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -3260,7 +3350,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -3326,7 +3416,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -3490,6 +3580,76 @@ def test_candidate_queue_writer_run_receipt_preview_reviews_operator_artifacts() assert "do_not_echo_operator_receipt_payload" in receipt["safe_boundaries"] +def test_candidate_queue_writer_run_closeout_preview_blocks_api_write_and_tokens(): + from services.market_intel.candidate_queue_writer_run_closeout import ( + build_candidate_queue_writer_run_closeout, + ) + from services.market_intel.candidate_queue_writer_run_receipt import ( + build_candidate_queue_writer_run_receipt, + ) + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-closeout" + ) + closeout_evidence = { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "closeout_notes": "manual closeout reviewed", + } + receipt = build_candidate_queue_writer_run_receipt( + transaction_preview=fixture["transaction"], + run_readiness=fixture["run_readiness"], + writer_output=fixture["writer_output"], + postwrite_smoke_result=fixture["postwrite_smoke_result"], + operator_evidence=fixture["operator_evidence"], + ) + closeout = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence=closeout_evidence, + ) + token_leak = build_candidate_queue_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=receipt, + operator_evidence={ + **closeout_evidence, + "approval_token": TEST_APPROVAL_TOKEN, + }, + ) + + assert closeout["mode"] == "candidate_queue_writer_run_closeout_preview" + assert closeout["closeout_passed"] is True + assert closeout["ready_for_next_manual_phase"] is True + assert closeout["ready_for_api_database_write"] is False + assert closeout["ready_for_scheduler_attach"] is False + assert closeout["api_executes_cli"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_file"] is False + assert closeout["api_writes_database"] is False + assert closeout["database_connection_opened"] is False + assert closeout["database_write_executed"] is False + assert closeout["database_commit_executed"] is False + assert closeout["scheduler_attached"] is False + assert closeout["blocked_reasons"] == [] + assert closeout["promotion_gate"]["requires_operator_approval"] is True + assert "no_momo_db_lifecycle_change" in closeout["safe_boundaries"] + assert token_leak["closeout_passed"] is False + assert token_leak["operator_closeout_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "closeout_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_write(): from routes.market_intel_routes import market_intel_bp @@ -3558,7 +3718,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -3572,6 +3732,56 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert data["blocked_reasons"] == [] +def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-closeout-route" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_writer_run_closeout", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "closeout_notes": "manual closeout reviewed", + }, + "writer_output": fixture["writer_output"], + "postwrite_smoke_result": fixture["postwrite_smoke_result"], + }, + ) + data = response.get_json() + + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_writer_run_closeout_preview" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" + assert data["closeout_passed"] is True + assert data["ready_for_next_manual_phase"] is True + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_file"] is False + assert data["api_writes_database"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["blocked_reasons"] == [] + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -3600,7 +3810,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -3625,7 +3835,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -3663,7 +3873,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -3674,7 +3884,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -3710,7 +3920,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -3721,7 +3931,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -3762,7 +3972,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -3773,7 +3983,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -3821,7 +4031,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -3833,7 +4043,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -3879,7 +4089,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -3892,7 +4102,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert plan["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -3977,7 +4187,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -4055,7 +4265,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -4070,7 +4280,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert readiness["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -4488,6 +4698,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): readiness["checks"]["candidate_queue_writer_run_receipt_preview_safe"] is True ) + assert ( + readiness["checks"]["candidate_queue_writer_run_closeout_preview_safe"] + is True + ) assert readiness["checks"]["match_review_plan_preview_safe"] is True assert readiness["checks"]["opportunity_plan_preview_safe"] is True assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True @@ -4550,6 +4764,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout" + in readiness["production_smoke_targets"] + ) assert readiness["write_approval_runbook"]["ready_for_real_write"] is False assert readiness["write_approval_runbook"]["writes_executed"] is False assert readiness["migration_blueprint"]["migration_executed"] is False @@ -5042,6 +5260,38 @@ def test_deployment_readiness_reports_app_only_release_gate(): is False ) assert readiness["candidate_queue_writer_run_receipt"]["scheduler_attached"] is False + assert ( + readiness["candidate_queue_writer_run_closeout"]["mode"] + == "candidate_queue_writer_run_closeout_preview" + ) + assert readiness["candidate_queue_writer_run_closeout"]["closeout_passed"] is False + assert ( + readiness["candidate_queue_writer_run_closeout"]["ready_for_api_database_write"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_closeout"]["ready_for_scheduler_attach"] + is False + ) + assert readiness["candidate_queue_writer_run_closeout"]["api_executes_cli"] is False + assert ( + readiness["candidate_queue_writer_run_closeout"]["api_reads_approval_token"] + is False + ) + assert readiness["candidate_queue_writer_run_closeout"]["api_writes_file"] is False + assert ( + readiness["candidate_queue_writer_run_closeout"]["database_connection_opened"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_closeout"]["database_write_executed"] + is False + ) + assert ( + readiness["candidate_queue_writer_run_closeout"]["database_commit_executed"] + is False + ) + assert readiness["candidate_queue_writer_run_closeout"]["scheduler_attached"] is False assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False assert readiness["scheduler_plan"]["crawler_job_started"] is False assert readiness["scheduler_plan"]["database_write_executed"] is False @@ -5146,7 +5396,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert drill["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -5261,7 +5511,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -5273,7 +5523,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert review["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -5388,7 +5638,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -5401,7 +5651,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert smoke["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -5463,7 +5713,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -5476,7 +5726,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert inventory["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -5620,7 +5870,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -5847,7 +6097,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_62_candidate_queue_writer_run_receipt" + assert data["phase"] == "phase_63_candidate_queue_writer_run_closeout" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False diff --git a/web/static/css/page-ppt-audit-history.css b/web/static/css/page-ppt-audit-history.css index dd0b344..0c74fb6 100644 --- a/web/static/css/page-ppt-audit-history.css +++ b/web/static/css/page-ppt-audit-history.css @@ -1405,10 +1405,37 @@ body.ppt-preview-open { @media (max-width: 760px) { .ppt-hero { - padding: var(--momo-space-4, 16px); + padding: 14px; + } + + .ppt-hero-grid { + gap: var(--momo-space-3, 12px); + } + + .ppt-subtitle { + margin-bottom: 0; + line-height: 1.5; + } + + .ppt-hero-note { + font-size: var(--momo-text-caption, 12px); + line-height: 1.4; + } + + .ppt-hero-actions { + margin-top: var(--momo-space-3, 12px); + } + + .ppt-hero-deck { + min-height: 0; + gap: var(--momo-space-2, 8px); + padding: var(--momo-space-3, 12px); + } + + .ppt-hero-deck-run { + padding-top: var(--momo-space-2, 8px); } - .ppt-command, .ppt-auto-grid, .ppt-mini-grid, .ppt-deck-rail, @@ -1420,6 +1447,24 @@ body.ppt-preview-open { grid-template-columns: 1fr; } + .ppt-command--compact { + grid-template-columns: repeat(2, minmax(0, 1fr)); + } + + .ppt-command { + gap: var(--momo-space-2, 8px); + margin-top: var(--momo-space-3, 12px); + } + + .ppt-signal { + min-height: 96px; + padding: var(--momo-space-2, 8px); + } + + .ppt-value { + font-size: var(--momo-text-title, 18px); + } + .ppt-toolbar { grid-template-columns: 1fr; }