OG T 8be87b0f32 fix(review): 首席架構師 Code Review — c439277 Tier 3 紅區修補 ...

Critical:
- C1: decision_manager _collect_mcp_context container 變數 Python ternary 優先度 bug 修正
  原: `A or B or C[0] if list else ""` (ternary 控制全式)
  修: `A or B or (C[0] if list else "")` (明確括號)
- C2: 所有 MCP 呼叫加 asyncio.wait_for timeout=5s，防止阻塞決策主路徑
  同時加 unknown host warning log (C4)
- C3+M1: _DESTRUCTIVE_PATTERNS 補全移至模組頂層常量
  新增: delete pods(複數)/kubectl drain/kubectl cordon/kubectl rollout undo/
        docker rm/docker stop/docker kill/rm -rf/"replicas": 0(JSON patch)

Important:
- I1: webhooks.py IP 排除改用 is_internal_ip() 支援全 RFC-1918 (10.x/172.16-31.x/192.168.x)
- I4: 新增 test_destructive_patterns.py — 25 測試全過
  涵蓋: 常量存在、攔截、誤攔迴歸、critical 永遠攔截

🔴 Tier 3 紅區 — 首席架構師 Code Review 通過後 push

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-04-11 22:05:52 +08:00

..

integration

fix(ci): B5 整合測試加 ssl=disable — asyncpg 預設嘗試 SSL 被 container 拒絕

2026-04-10 11:40:40 +08:00

llm_testing

fix(api): 修復全部 lint 錯誤 (ruff --fix)

2026-03-26 16:06:20 +08:00

conftest.py

docs(logbook): ADR-059 Gitea Webhook 遷移完成記錄

2026-04-05 14:45:02 +08:00

e2e_network_test.py

refactor(api): Phase 22 P1 模組化修復 - Router→Service 封裝

2026-03-31 16:25:00 +08:00

factories.py

feat(test): B5 整合測試框架 — 真實 DB, 5/5 通過

2026-04-10 11:22:57 +08:00

test_action_parsing.py

fix(test): 更新 action_parsing 測試 — 無 -n 參數預設 namespace 改為 awoooi-prod

2026-04-06 11:49:24 +08:00

test_anomaly_counter.py

fix(api): 修復 34 個 Ruff lint 錯誤

2026-03-29 15:27:49 +08:00

test_approval_field_alignment.py

fix(api): 修復 34 個 Ruff lint 錯誤

2026-03-29 15:27:49 +08:00

test_auto_repair_service.py

fix(ci): 修正測試與 Sprint 5.2 部署腳本

2026-04-08 18:17:48 +08:00

test_circuit_breaker.py

feat(api): Wave 1 安全網 - Circuit Breaker + Global Repair Cooldown

2026-03-29 15:48:03 +08:00

test_destructive_patterns.py

fix(review): 首席架構師 Code Review — c439277 Tier 3 紅區修補

2026-04-11 22:05:52 +08:00

test_failure_watcher.py

feat(api): Phase 18.6 E2E 測試驗證 (40 tests)

2026-03-31 12:16:54 +08:00

test_get_incident_type.py

fix(review): 首席架構師 Code Review 修補 — I1 get_incident_type 邏輯修正 + 測試補全

2026-04-11 21:33:19 +08:00

test_gitea_webhook.py

fix(webhook): Gitea 簽章格式修正 — 純 hex，無 sha256= 前綴

2026-04-05 15:40:40 +08:00

test_global_repair_cooldown.py

fix(tests): 首席架構師審查修復 - 測試套件 + DI 強化 (96/100 OUTSTANDING)

2026-04-01 11:11:50 +08:00

test_host_repair_agent.py

refactor(api): Re-Review S1/S2/S3 改善 — 消除重複+防禦性驗證+測試隔離

2026-04-07 11:17:40 +08:00

test_intent_classifier.py

fix(approval): 修復 Y/n 簽核按鈕無動作問題 (Phase 22 P1)

2026-03-31 16:16:16 +08:00

test_learning_service.py

fix(tests): 移除 Mock 違規 - test_learning_service.py

2026-03-31 12:20:29 +08:00

test_llm_tier1_schema.py

fix(api): 修復全部 lint 錯誤 (ruff --fix)

2026-03-26 16:06:20 +08:00

test_model_regression.py

fix(api): 修復全部 lint 錯誤 (ruff --fix)

2026-03-26 16:06:20 +08:00

test_nvidia_chat.py

refactor(ai): 模組化重構 - NVIDIA chat 移至 NvidiaProvider

2026-03-29 20:49:23 +08:00

test_nvidia_provider.py

fix(test): nvidia → openclaw_nemo 對齊 RATE_LIMITS/COST_LIMITS key (I3)

2026-04-03 14:00:21 +08:00

test_p0_diagnose_routing.py

fix(p0): v4.3 — 實測確認 Ollama CPU-only 不可用，DIAGNOSE 統一走 NIM

2026-04-05 01:49:06 +08:00

test_phase22_nemotron_collab.py

feat(web): OpenClaw 風格龍蝦 SVG + 三色狀態燈號 + 測試修正

2026-04-09 08:55:21 +08:00

test_phase25_auto_harvesting.py

test(phase25): Phase 25 P1/P2 source code inspection tests (36 tests)

2026-04-05 00:14:50 +08:00

test_phase25_drift_detection.py

test(phase25): Phase 25 P1/P2 source code inspection tests (36 tests)

2026-04-05 00:14:50 +08:00

test_playbook_service.py

fix(api): 修復全部 lint 錯誤 (ruff --fix)

2026-03-26 16:06:20 +08:00

test_prompt_validation.py

test: skip slow LLM prompt validation tests to fix CI timeout

2026-03-31 14:17:36 +08:00

test_rag_provider.py

fix(mcp): P1 修復 - DI 一致性 + 測試補充 + 配置優化

2026-03-29 16:23:30 +08:00

test_redis_multisig.py

fix(lint): ruff auto-fix + lewooogo-core src 加入 git

2026-03-23 23:51:37 +08:00

test_smart_router.py

fix(test): ComplexityScorer 模型名稱更新 llama3.2:3b → gemma3:4b

2026-04-09 09:01:59 +08:00

test_telegram_adr050.py

fix(test): 更新 TestHistoryMessageFormat 適配 Phase 27 雙層策略

2026-04-10 01:12:00 +08:00

test_telegram_integration.py

fix(api): 修復 34 個 Ruff lint 錯誤

2026-03-29 15:27:49 +08:00

test_telegram_message_templates.py

feat(telegram): 實作 6 種新訊息模板 (ADR-038)

2026-03-29 21:23:07 +08:00

test_terminal_service.py

fix(approval): 修復 Y/n 簽核按鈕無動作問題 (Phase 22 P1)

2026-03-31 16:16:16 +08:00

test_terminal.py

refactor(phase-s): Phase S 技術債清理 - 五項架構改善

2026-04-01 13:12:02 +08:00