OG T
428e66c111
CD Pipeline / build-and-deploy (push) Has been cancelled
fix(arch-review): 首席架構師審查 S1×3 S2×3 S3×3 全修復 + ADR-064
S1 Critical:
- S1-1: asyncio 觸發移至 _call_with_fallback async 上下文,移除 sync 中的 get_event_loop()
- S1-2: _append_rule_to_yaml 加 textwrap.dedent() 正規化 LLM 輸出縮排
- S1-3: _matches() 對 alertname=["*"] 直接回傳 False,防意外命中
S2 Major:
- S2-1: auto_generate_rule() 改為 DI 參數注入 (ollama_url/model/gemini_api_key),移除 import settings
- S2-4: _generate_mock_response docstring 澄清為規則引擎生產路徑,非假數據
- S2-5: suggested_action .strip() 防空白字串繞過 or
S3 Minor:
- S3-2: priority 上界 min(next, 890)
- S3-3: alertname sanitize re.sub([{}]) 防 format KeyError
- S3-4: model_registry.py 最後修改時間戳更新
文件:
- ADR-064: Alert Rule Engine YAML 驅動 + AI 自動學習
- Skills 02: 告警規則引擎 DI 規範 + asyncio 禁止事項
- Skills 03: _generate_mock_response 語意澄清 + 規則引擎降級流程
- LOGBOOK: 本次 Session 完整記錄
2026-04-09 ogt: 首席架構師審查修正
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-09 10:52:40 +08:00
..
2026-04-09 10:52:40 +08:00
2026-03-23 18:40:36 +08:00
2026-03-29 00:00:08 +08:00
2026-03-23 19:44:56 +08:00
2026-03-26 19:10:12 +08:00
2026-03-26 09:55:58 +08:00
2026-03-26 09:55:58 +08:00
2026-03-29 16:03:41 +08:00
2026-03-23 18:40:36 +08:00
2026-03-30 01:21:23 +08:00
2026-03-31 16:13:44 +08:00
2026-03-29 21:23:07 +08:00
2026-03-29 23:56:34 +08:00
2026-04-05 12:13:21 +08:00
2026-03-23 18:40:36 +08:00
2026-03-29 16:03:41 +08:00
2026-04-08 16:07:12 +08:00
2026-03-29 01:19:26 +08:00
2026-03-23 18:40:36 +08:00
2026-03-23 18:40:36 +08:00
2026-03-26 09:55:47 +08:00
2026-03-31 16:06:51 +08:00
2026-03-26 19:10:12 +08:00
2026-03-29 16:03:41 +08:00
2026-03-23 18:40:36 +08:00
2026-04-03 15:36:47 +08:00
2026-03-29 16:03:41 +08:00
2026-04-09 10:52:40 +08:00
2026-03-29 01:52:08 +08:00
2026-03-29 01:52:08 +08:00
2026-03-26 09:55:47 +08:00
2026-03-26 19:10:12 +08:00
2026-03-26 09:55:58 +08:00
2026-03-29 16:35:47 +08:00
2026-03-23 18:40:36 +08:00