修復項目: - P1-1: 從 ModelRegistry 取得模型 (非 hardcoded) - P1-2: models.json 新增 nvidia.rca 模型定義 - P0: 新增 test_openclaw_nvidia.py 測試 首席架構師審查 74/120 → 預期 85+ Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
126 lines
3.3 KiB
Python
126 lines
3.3 KiB
Python
"""
|
||
test_openclaw_nvidia.py - NVIDIA RCA 整合測試
|
||
|
||
2026-03-29 ogt: P0 修復 - 新增 _call_nvidia 測試
|
||
|
||
測試策略 (遵循 feedback_no_mock_testing.md):
|
||
- 使用真實 NVIDIA API (需 NVIDIA_API_KEY)
|
||
- 跳過條件: 無 API Key 時跳過
|
||
"""
|
||
|
||
import pytest
|
||
import os
|
||
|
||
from src.services.openclaw import OpenClawService
|
||
from src.core.config import get_settings
|
||
|
||
|
||
settings = get_settings()
|
||
|
||
|
||
@pytest.fixture
|
||
def openclaw_service():
|
||
"""建立 OpenClawService 實例"""
|
||
return OpenClawService()
|
||
|
||
|
||
@pytest.mark.asyncio
|
||
@pytest.mark.skipif(
|
||
not os.getenv("NVIDIA_API_KEY") and not settings.NVIDIA_API_KEY,
|
||
reason="NVIDIA_API_KEY not configured"
|
||
)
|
||
async def test_call_nvidia_success(openclaw_service):
|
||
"""
|
||
測試 _call_nvidia 成功回應
|
||
|
||
驗證:
|
||
- 回應格式正確 (4-tuple)
|
||
- success = True
|
||
- total_tokens > 0
|
||
- cost_usd = 0 (免費 tier)
|
||
"""
|
||
prompt = """你是一個 JSON 產生器。請回傳以下格式:
|
||
{"status": "ok", "message": "test"}
|
||
只回傳 JSON,不要其他內容。"""
|
||
|
||
response, success, total_tokens, cost_usd = await openclaw_service._call_nvidia(prompt)
|
||
|
||
assert success is True, f"Expected success, got error: {response}"
|
||
assert isinstance(response, str)
|
||
assert len(response) > 0
|
||
assert total_tokens > 0, "Expected token count > 0"
|
||
assert cost_usd == 0.0, "Expected $0 for free tier"
|
||
|
||
|
||
@pytest.mark.asyncio
|
||
async def test_call_nvidia_no_api_key(openclaw_service, monkeypatch):
|
||
"""
|
||
測試無 API Key 時的處理
|
||
|
||
驗證:
|
||
- success = False
|
||
- 回傳適當錯誤訊息
|
||
"""
|
||
# 暫時移除 API Key
|
||
monkeypatch.setattr(settings, "NVIDIA_API_KEY", None)
|
||
|
||
response, success, total_tokens, cost_usd = await openclaw_service._call_nvidia("test")
|
||
|
||
assert success is False
|
||
assert "not configured" in response.lower()
|
||
assert total_tokens == 0
|
||
assert cost_usd == 0.0
|
||
|
||
|
||
@pytest.mark.asyncio
|
||
@pytest.mark.skipif(
|
||
not os.getenv("NVIDIA_API_KEY") and not settings.NVIDIA_API_KEY,
|
||
reason="NVIDIA_API_KEY not configured"
|
||
)
|
||
async def test_call_nvidia_json_response(openclaw_service):
|
||
"""
|
||
測試 JSON 格式回應
|
||
|
||
驗證:
|
||
- 回應是有效 JSON
|
||
"""
|
||
import json
|
||
|
||
prompt = """回傳一個 JSON 物件,包含:
|
||
- action: "NO_ACTION"
|
||
- reason: "測試"
|
||
只回傳 JSON。"""
|
||
|
||
response, success, _, _ = await openclaw_service._call_nvidia(prompt)
|
||
|
||
assert success is True
|
||
|
||
# 驗證是有效 JSON
|
||
try:
|
||
data = json.loads(response)
|
||
assert isinstance(data, dict)
|
||
except json.JSONDecodeError:
|
||
pytest.fail(f"Response is not valid JSON: {response[:200]}")
|
||
|
||
|
||
@pytest.mark.asyncio
|
||
@pytest.mark.skipif(
|
||
not os.getenv("NVIDIA_API_KEY") and not settings.NVIDIA_API_KEY,
|
||
reason="NVIDIA_API_KEY not configured"
|
||
)
|
||
async def test_call_nvidia_uses_model_registry(openclaw_service):
|
||
"""
|
||
測試使用 ModelRegistry 取得模型
|
||
|
||
驗證:
|
||
- 使用 models.json 中定義的 rca 模型
|
||
"""
|
||
from src.services.model_registry import get_model_registry
|
||
|
||
registry = get_model_registry()
|
||
expected_model = registry.get_model("nvidia", "rca")
|
||
|
||
# 模型應該是 llama-3.1-nemotron-70b-instruct
|
||
assert "nemotron" in expected_model.lower()
|
||
assert "70b" in expected_model or "mini" in expected_model
|