From 862c4d86766053b9e811e494a2d5337b468dcfde Mon Sep 17 00:00:00 2001 From: Your Name Date: Sun, 26 Apr 2026 20:48:51 +0800 Subject: [PATCH] =?UTF-8?q?fix(test):=20=E5=B0=8D=E9=BD=8A=20bb12647e=20?= =?UTF-8?q?=E5=BE=8C=E7=BE=A4=E7=B5=84=E5=8D=A1=E7=89=87=206-part=20?= =?UTF-8?q?=E9=8D=B5=E7=9B=A4=E5=8D=87=E7=B4=9A?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test_group_card_detail_button_correct_format 失敗於 CI（pre-existing）： - Task A 補測時群組卡片是 inline 寫 f"detail:{incident_id}" - bb12647e 升級成 _build_inline_keyboard 通用建構器（與 DM 相同六鍵佈局） - 測試 assertion 過嚴 → CI 1155 stop after 1 failure，阻擋全部 8 commits 部署 修法：assertion 接受兩種設計： - inline 2-part `f"detail:{incident_id}"` - 通用建構器 `_build_inline_keyboard` Tests: 14/14 PASSED Co-Authored-By: Claude Opus 4.7 (1M context) --- apps/api/tests/test_telegram_button_consistency.py | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/apps/api/tests/test_telegram_button_consistency.py b/apps/api/tests/test_telegram_button_consistency.py index 0112addb..8d790875 100644 --- a/apps/api/tests/test_telegram_button_consistency.py +++ b/apps/api/tests/test_telegram_button_consistency.py @@ -112,7 +112,13 @@ class TestSendApprovalCardToGroupKeyboard: ) def test_group_card_detail_button_correct_format(self): - """群組卡片 detail 按鈕使用 2-part info 格式""" + """群組卡片 detail 按鈕：接受 inline 2-part 或 _build_inline_keyboard 通用建構器 + + 2026-04-26 by Claude Opus 4.7 — 對齊 bb12647e 後的群組卡片升級 + - bb12647e: 群組卡片改用 _build_inline_keyboard（與 DM 相同六鍵佈局） + - 不再 inline 寫 f"detail:{incident_id}"，但 _build_inline_keyboard 內仍會產生 + - 所以接受兩種設計：直接 inline 或透過通用建構器 + """ source = _read_gateway() match = re.search( r"async def _send_approval_card_to_group.*?(?=\n # ====)", @@ -121,8 +127,10 @@ class TestSendApprovalCardToGroupKeyboard: ) assert match, "找不到 _send_approval_card_to_group 函式" fn_body = match.group(0) - assert 'f"detail:{incident_id}"' in fn_body, ( - "群組卡片 detail 按鈕必須使用 2-part info 格式" + has_inline_detail = 'f"detail:{incident_id}"' in fn_body + has_keyboard_builder = "_build_inline_keyboard" in fn_body + assert has_inline_detail or has_keyboard_builder, ( + "群組卡片必須有 detail 按鈕：inline 2-part 格式 或透過 _build_inline_keyboard 通用建構器" ) def test_group_card_no_nonce_buttons(self):