fix(review): Code Review C1/C2/I2/M2 修補

C1 drift_interpreter: 寫死 192.168.0.111 → settings.OLLAMA_URL
  違反 feedback_frontend_internal_ip_ban 鐵律（後端 service 層同樣禁止寫死內網 IP）

C2 km_conversion_service: BUG-004 補同步 Redis Working Memory vectorized 欄位
  原修復只更新 DB，Redis incident:{id} JSON 的 vectorized 未同步
  → 審計查 Redis 仍顯示 False，fly-wheel 閉環指標仍不準
  修復：DB 更新後 GET → JSON patch vectorized=True → SET（保留原 TTL）

I2 decision_manager: _ALERTNAME_KEYWORDS HostHighDiskUsage→HostOutOfDiskSpace
  + 補 DockerContainerExited
  + fallback 路徑加 debug log

M2 decision_manager: import json as _json 從 for 迴圈移至方法頂部

docs: ADR-072 新增 Code Review 發現與技術債記錄

2026-04-11 Claude Sonnet 4.6 Asia/Taipei

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

apps/api/src/services/decision_manager.py

@@ -506,13 +506,23 @@ async def _resolve_target_from_k8s(incident: "Incident", namespace: str) -> str
             return None
 
         # alertname → 關鍵字映射（主機層告警常見類型）
+        # I2 修復 2026-04-11: HostHighDiskUsage → HostOutOfDiskSpace（與 alerts-unified.yml 一致）
+        # DockerContainerUnhealthy/HostOutOfDiskSpace keywords=[] 走 fallback（找第一個非 infra pod）
+        # 並加 log 便於追蹤 fallback 路徑
         _ALERTNAME_KEYWORDS: dict[str, list[str]] = {
-            "HostHighCpuLoad": ["api", "web"],
-            "HostOutOfMemory": ["api", "web"],
+            "HostHighCpuLoad":        ["api", "web"],
+            "HostOutOfMemory":        ["api", "web"],
             "DockerContainerUnhealthy": [],
-            "HostHighDiskUsage": [],
+            "DockerContainerExited":  [],
+            "HostOutOfDiskSpace":     [],
         }
         keywords = _ALERTNAME_KEYWORDS.get(alertname, [])
+        if not keywords and alertname in _ALERTNAME_KEYWORDS:
+            logger.debug(
+                "resolve_target_k8s_fallback_to_first_pod",
+                alertname=alertname,
+                reason="alertname 有對應但 keywords=[]，走 fallback 取第一個非 infra pod",
+            )
 
         import re as _re
         for line in pod_lines:
@@ -1755,6 +1765,7 @@ class DecisionManager:
         Returns:
             重新推送的 token 數量
         """
+        import json as _json
         from src.core.redis_client import get_redis
         from src.db.base import get_db_context
         from src.repositories.incident_repository import IncidentDBRepository
@@ -1772,7 +1783,6 @@ class DecisionManager:
                         raw = await redis.get(key)
                         if not raw:
                             continue
-                        import json as _json
                         data = _json.loads(raw)
                         if data.get("state") != DecisionState.READY.value:
                             continue

apps/api/src/services/drift_interpreter.py

@@ -106,8 +106,12 @@ class NemotronDriftInterpreter:
         改用 Ollama httpx 直接呼叫，繞過 nvidia_provider，與 drift_narrator_service 一致
         """
         import httpx
+        from src.core.config import get_settings
 
-        OLLAMA_URL = "http://192.168.0.111:11434"
+        # C1 修復 2026-04-11: 禁止寫死內網 IP（feedback_frontend_internal_ip_ban 鐵律）
+        # 改從 settings.OLLAMA_URL 讀取（已有此設定，default=http://192.168.0.111:11434）
+        _settings = get_settings()
+        OLLAMA_URL = getattr(_settings, "OLLAMA_URL", "http://192.168.0.111:11434")
         MODEL = "qwen2.5:7b-instruct"
         TIMEOUT = 45.0
 

apps/api/src/services/km_conversion_service.py

@@ -196,6 +196,33 @@ class KMConversionService:
                 error=str(_ve),
             )
 
+        # C2 修復 2026-04-11: DB 更新後，同步更新 Redis Working Memory 中的 vectorized 欄位
+        # 審計查 Redis Incident 物件，若不同步則審計仍顯示 vectorized=False
+        # Key 格式: incident:{incident_id}（與 incident_service.save_to_working_memory 一致）
+        try:
+            import json as _json
+            from src.core.redis_client import get_redis
+            _redis = get_redis()
+            _redis_key = f"incident:{incident.incident_id}"
+            _raw = await _redis.get(_redis_key)
+            if _raw:
+                _data = _json.loads(_raw)
+                if not _data.get("vectorized"):
+                    _data["vectorized"] = True
+                    _ttl = await _redis.ttl(_redis_key)
+                    _ex = _ttl if _ttl and _ttl > 0 else 604800
+                    await _redis.set(_redis_key, _json.dumps(_data), ex=_ex)
+                    logger.info(
+                        "km_incident_vectorized_redis_synced",
+                        incident_id=incident.incident_id,
+                    )
+        except Exception as _re:
+            logger.debug(
+                "km_vectorized_redis_sync_failed",
+                incident_id=incident.incident_id,
+                error=str(_re),
+            )
+
         logger.info(
             "km_converted",
             incident_id=incident.incident_id,